Re: [PATCH v2 2/4] RISC-V: Fix of_get_cpu_node usage

2019-04-10 Thread Christoph Hellwig
On Wed, Apr 10, 2019 at 04:04:41PM -0700, Atish Patra wrote: > of_get_cpu_node expects a logical cpu id not a hartid. But only because you changed that with your patch 1, so it should be folded into that.

Re: [PATCH v2 1/4] RISC-V: Add RISC-V specific arch_match_cpu_phys_id

2019-04-10 Thread Christoph Hellwig
On Wed, Apr 10, 2019 at 04:04:40PM -0700, Atish Patra wrote: > OF/DT core has a hook for architecture specific logical cpuid to hartid > mapping. By implementing this, we can pass the logical cpu id to cpu > node parsing functions. But that also means we must pass it that way. So as-is this would

Re: [PATCH 2/2] ARM: dts: imx6ul-pico: Add support for the dwarf baseboard

2019-04-10 Thread Shawn Guo
On Sun, Apr 07, 2019 at 04:37:23PM -0300, Otavio Salvador wrote: > From: Fabio Estevam > > Add support for the imx6ul pico board with dwarf baseboard combination. > > Signed-off-by: Fabio Estevam > Signed-off-by: Otavio Salvador > --- > > arch/arm/boot/dts/Makefile | 1 + > arc

Re: [1/3] x86: Update DEBUG_TLBFLUSH options description.

2019-04-10 Thread Christoph Hellwig
Given that this option enables generic code (which you reuse for RISC-V later in this series) please also move the config option to mm/Kconfig, proabbly keyed off another ARCH_HAVE_DEBUG_TLBFLUSH symbol that the architecture can select.

Re: [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG

2019-04-10 Thread Shawn Guo
On Sat, Apr 06, 2019 at 06:00:20PM +0200, Markus Kueffner wrote: > Add Pincfgs to enable the i.MX6's OTG feature for UDOO > > Signed-off-by: Markus Kueffner > --- > arch/arm/boot/dts/imx6qdl-udoo.dtsi | 16 > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/i

Re: [PATCH] mtd: rawnand: Add Macronix NAND read retry and randomizer support

2019-04-10 Thread Boris Brezillon
On Thu, 11 Apr 2019 12:23:11 +0800 masonccy...@mxic.com.tw wrote: > Hi Boris, > > > > > > Subject > > > > > > > > Re: [PATCH] mtd: rawnand: Add Macronix NAND read retry and > randomizer > > > support > > > > > > > > On Tue, 9 Apr 2019 17:35:39 +0800 > > > > masonccy...@mxic.com.tw wrot

Re: WARNING: bad unlock balance in ucma_destroy_id

2019-04-10 Thread syzbot
syzbot has bisected this bug to: commit e1c30298ccab87151a0c4241fc5985c591598361 Author: Yishai Hadas Date: Thu Aug 13 15:32:07 2015 + IB/ucma: HW Device hot-removal support bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=157538d320 start commit: 5b394b2d Linux 4.1

Re: [PATCH] arm64: dts: imx8qxp: Add lpuart1/lpuart2/lpuart3 nodes

2019-04-10 Thread Shawn Guo
On Sat, Mar 30, 2019 at 05:07:44PM +, Daniel Baluta wrote: > lpuart nodes are part of the ADMA subsystem. See Audio DMA > memory map in iMX8 QXP RM [1] > > This patch is based on the dtsi file initially submitted by > Teo Hall in i.MX NXP internal tree. > > [1] https://www.nxp.com/docs/en/ref

[PATCH 1/2] soc: imx-sc: add i.MX system controller soc driver support

2019-04-10 Thread Anson Huang
i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller inside, the system controller is in charge of controlling power, clock and fuse etc.. This patch adds i.MX system controller soc driver support, Linux kernel has to communicate with system controller via MU (message unit) IPC to get

[PATCH 2/2] defconfig: arm64: add i.MX system controller SoC support

2019-04-10 Thread Anson Huang
This patch enables CONFIG_IMX_SC_SOC as module. Signed-off-by: Anson Huang --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index d4c404a..b61cc53 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/

linux-next: Tree for Apr 11

2019-04-10 Thread Stephen Rothwell
Hi all, Changes since 20190410: The orangefs tree gained a build failure so I used the version from next-20190410. The drm tree still had its build failure for which I disabled a driver. The drm-misc tree still had its build failure for which I marked a driver as BROKEN. The apparmor tree

Re: [EXT] Re: [PATCH] can: dev: clean up CAN ctrlmode when close CAN device

2019-04-10 Thread Marc Kleine-Budde
On 4/11/19 3:16 AM, Joakim Zhang wrote: >> Whatever mode you enable via user space use user space to disable them >> again. > > Thank you for your detailed explanation. But in flexcan driver, it > just set register bit when mode on and do not clear register bit when > mode off, e.g. loopback, list

Re: [PATCH 3/4] rhashtable: use bit_spin_locks to protect hash bucket.

2019-04-10 Thread NeilBrown
On Thu, Apr 11 2019, NeilBrown wrote: > On Thu, Apr 11 2019, NeilBrown wrote: > >> On Wed, Apr 10 2019, Guenter Roeck wrote: >> >>> Hi, >>> > . >>> >>> This patch causes my qemu q800 boot test to crash reliably. >>> > >>> Code: 4a89 6604 4280 60ea 2c2b 000c 2748 000c <2869> 000c 082c 0003

Re: [PATCH] clk: rockchip: Fix video codec clocks on rk3288

2019-04-10 Thread Heiko Stübner
Hi Doug, Am Donnerstag, 11. April 2019, 01:37:33 CEST schrieb Doug Anderson: > Hi, > > On Wed, Apr 10, 2019 at 11:38 AM Jonas Karlman wrote: > > > > On 2019-04-10 17:45, Doug Anderson wrote: > > > Hi, > > > > > > On Fri, Mar 29, 2019 at 2:55 PM Douglas Anderson > > > wrote: > > >> It appears t

Re: [PATCH 1/1] arch: arm64: process: Unlock console after SMP stopped

2019-04-10 Thread Jinyoung Park
I have observed this problem during reboot stress test on my ARM64 architecture board which is NVIDIA Tegra ARM64 CPU reference board. The reboot stress test is to restart the system repeatedly for a long time. The system is set with Kernel log level 8 for logging all kernel messages during the tes

Re: [PATCH 1/2] s390: only build for new CPUs with clang

2019-04-10 Thread Heiko Carstens
On Wed, Apr 10, 2019 at 10:12:40PM +0200, Arnd Bergmann wrote: > llvm does does not understand -march=z9-109 and older target > specifiers, so disable the respective Kconfig settings and > the logic to make the boot code work on old systems when > building with clang. > > Signed-off-by: Arnd Bergm

linux-next: manual merge of the akpm tree with the vfs tree

2019-04-10 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the akpm tree got a conflict in: fs/block_dev.c between commit: 6d46d2934aea ("fs/block_dev.c: remove unused include") from the vfs tree and patch: "fs/block_dev.c: Remove duplicate header" from the akpm tree. I fixed it up (see below) and can carry

[no subject]

2019-04-10 Thread Nicholas Piggin
Date: Tue, 9 Apr 2019 20:23:16 +1000 Subject: [PATCH] kernel/sched: run nohz idle load balancer on HK_FLAG_MISC CPUs The nohz idle balancer runs on the lowest idle CPU. This can interfere with isolated CPUs, so confine it to HK_FLAG_MISC housekeeping CPUs. HK_FLAG_SCHED is not used for this beca

[PATCH v2 2/2] dt-bindings: power: reset: add document for NVMEM based reboot-mode

2019-04-10 Thread Han Nandor
Add the device tree bindings document for the NVMEM based reboot-mode driver. Signed-off-by: Nandor Han --- .../power/reset/nvmem-reboot-mode.txt | 32 +++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/reset/nvmem-reboot-mod

[PATCH v2 1/2] power: reset: nvmem-reboot-mode: use NVMEM as reboot mode write interface

2019-04-10 Thread Han Nandor
Add a new reboot mode write interface that is using an NVMEM cell to store the reboot mode magic. Signed-off-by: Nandor Han --- drivers/power/reset/Kconfig | 9 +++ drivers/power/reset/Makefile| 1 + drivers/power/reset/nvmem-reboot-mode.c | 76 +

[PATCH v2 0/2] Use NVMEM as reboot-mode write interface

2019-04-10 Thread Han Nandor
Description --- Extend the reboot mode driver to use a NVMEM cell as writing interface. Testing --- The testing is done by configuring DT from a custom board. The NVMEM cell is configured in an RTC non-volatile memory. Kernel: 4.14.60 (the patchset was rebased on kernel master) DT con

Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Masahiro Yamada
On Thu, Apr 11, 2019 at 2:44 PM Sinan Kaya wrote: > > On 4/11/2019 1:31 AM, Masahiro Yamada wrote: > >> t looks like CONFIG_KALLSYMS_ALL is the only feature that > >> requires CONFIG_DEBUG_KERNEL. > > Which part of KALLSYMS_ALL code requires CONFIG_DEBUG_KERNEL? > > > > I was going by what Kconfig

Some new bio merging behaviors in __bio_try_merge_page

2019-04-10 Thread Gao Xiang
Hi Ming, I found a erofs issue after commit 07173c3ec276 ("block: enable multipage bvecs") is merged. It seems that it tries to merge more physical continuous pages in one iovec. However it breaks the current erofs_read_raw_page logic since it uses nr_iovecs of bio_alloc to limit the maximum numb

Re: [PATCH] ARM: dts: imx6q-logicpd: Reduce inrush current on USBH1

2019-04-10 Thread Shawn Guo
On Tue, Apr 02, 2019 at 02:32:04PM -0500, Adam Ford wrote: > Some USB peripherals draw more power, and the sourcing regulator > take a little time to turn on. This patch fixes an issue where > some devices occasionally do not get detected, because the power > isn't quite ready when communication s

[PATCH v2 11/11] platform/x86: asus-wmi: Do not disable keyboard backlight on unload

2019-04-10 Thread Yurii Pavlovskyi
The keyboard backlight is disabled when module is unloaded as it is exposed as LED device. Change this behavior to ignore setting 0 brightness when the ledclass device is unloading. Signed-off-by: Yurii Pavlovskyi --- drivers/platform/x86/asus-wmi.c | 4 1 file changed, 4 insertions(+) dif

Re: [PATCH V2] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend

2019-04-10 Thread Shawn Guo
On Tue, Apr 02, 2019 at 02:25:46PM -0500, Adam Ford wrote: > The LCD power sequencer is very finicky. The backlight cannot > be driven until after the sequencer is done. Until now, the > regulators were marked with 'regulator-always-on' to make sure > it came up before the backlight. This patch

[PATCH v2 09/11] platform/x86: asus-wmi: Control RGB keyboard backlight

2019-04-10 Thread Yurii Pavlovskyi
The WMI exposes two methods for controlling RGB keyboard backlight which allow to control: * RGB components in range 00 - ff, * Switch between 4 effects, * Switch between 3 effect speed modes, * Separately enable the backlight on boot, in awake state (after driver load), in sleep mode, and probab

[PATCH v2 10/11] platform/x86: asus-wmi: Switch fan boost mode

2019-04-10 Thread Yurii Pavlovskyi
The WMI exposes a write-only device ID where three modes can be switched on some laptops (TUF Gaming FX505GM). There is a hotkey combination Fn-F5 that does have a fan icon which is designed to toggle between these 3 modes. Add a SysFS entry that reads the last written value and updates value in W

[PATCH v2 08/11] platform/x86: asus-wmi: Enhance detection of thermal data

2019-04-10 Thread Yurii Pavlovskyi
The obviously wrong value 1 for temperature device ID in this driver is returned by at least some devices, including TUF Gaming series laptops, instead of 0 as expected previously. Observable effect is that a temp1_input in hwmon reads temperature near absolute zero. * Consider 0.1 K as erroneous

Re: [PATCH V2] ARM: dts: imx6q-logicpd: Reduce inrush current on start

2019-04-10 Thread Shawn Guo
On Tue, Apr 02, 2019 at 02:19:08PM -0500, Adam Ford wrote: > The main 3.3V regulator sources a series of additional regulators. > This patch adds a small delay, so when the 3.3V regulator comes > on it delays a bit before the subsequent regulators can come on. > This reduces the inrush current a bi

Re: [PATCH net] vhost: reject zero size iova range

2019-04-10 Thread David Miller
From: Jason Wang Date: Tue, 9 Apr 2019 12:10:25 +0800 > We used to accept zero size iova range which will lead a infinite loop > in translate_desc(). Fixing this by failing the request in this case. > > Reported-by: syzbot+d21e6e297322a900c...@syzkaller.appspotmail.com > Fixes: 6b1e6cc7 ("vhost

Re: [PATCH V2] ARM: dts: imx6q-logicpd: Enable Analog audio capture

2019-04-10 Thread Shawn Guo
On Tue, Apr 02, 2019 at 02:25:45PM -0500, Adam Ford wrote: > The original submission had functional audio out and was based > on reviewing other boards using the same wm8962 codec. However, > the Logic PD board uses an analog microphone which was being > disabled for a digital mic. This patch corr

[PATCH v2 06/11] platform/x86: asus-nb-wmi: Add microphone mute key code

2019-04-10 Thread Yurii Pavlovskyi
The microphone mute key that is present on FX505GM laptop and possibly others is missing from sparse keymap. Add the missing code. Also comment on the fan mode switch key that has the same code as the already used key. Signed-off-by: Yurii Pavlovskyi --- drivers/platform/x86/asus-nb-wmi.c | 3 +

[PATCH v2 07/11] platform/x86: asus-wmi: Organize code into sections

2019-04-10 Thread Yurii Pavlovskyi
The driver has grown (and will more) pretty big which makes it hard to navigate and understand. Add uniform comments to the code and ensure that it is sorted into logical sections. Signed-off-by: Yurii Pavlovskyi --- drivers/platform/x86/asus-wmi.c | 94 - 1 file

[PATCH v2 05/11] platform/x86: asus-wmi: Support queued WMI event codes

2019-04-10 Thread Yurii Pavlovskyi
Event codes are expected to be polled from a queue on at least some models. The WMI event codes are pushed into queue based on circular buffer. After INIT method is called ACPI code is allowed to push events into this buffer the INIT method can not be reverted. If the module is unloaded and an eve

Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Sinan Kaya
On 4/11/2019 1:31 AM, Masahiro Yamada wrote: t looks like CONFIG_KALLSYMS_ALL is the only feature that requires CONFIG_DEBUG_KERNEL. Which part of KALLSYMS_ALL code requires CONFIG_DEBUG_KERNEL? I was going by what Kconfig tells me Symbol: KALLSYMS_ALL [=n] Depends on: DEBUG_KERNEL [=n] &&

[PATCH v2 04/11] platform/x86: asus-wmi: Add quirk to force DSTS WMI method detection

2019-04-10 Thread Yurii Pavlovskyi
The DSTS method detection fails, as nothing is returned if method is not defined in WMNB. As a result the control of keyboard backlight is not functional for TUF Gaming series laptops (at the time the only functionality of the driver on this model implemented with WMI methods). Patch was tested on

Re: [PATCH 00/11] asus-wmi: Support of ASUS TUF Gaming series laptops

2019-04-10 Thread Yurii Pavlovskyi
Hi, sorry, just realized, I've broken the logging. I will re-post patches 04 to 11 as replies to original ones, 1 to 3 were ok.

Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Masahiro Yamada
On Thu, Apr 11, 2019 at 11:47 AM Kees Cook wrote: > > On Wed, Apr 10, 2019 at 5:56 PM Sinan Kaya wrote: > > > > We can't seem to have a kernel with CONFIG_EXPERT set but > > CONFIG_DEBUG_KERNEL unset these days. > > > > While some of the features under the CONFIG_EXPERT require > > CONFIG_DEBUG_K

Re: [External] Re: Basics : Memory Configuration

2019-04-10 Thread Pankaj Suryawanshi
From: Christopher Lameter Sent: 09 April 2019 21:31 To: Pankaj Suryawanshi Cc: linux-kernel@vger.kernel.org; linux...@kvack.org Subject: [External] Re: Basics : Memory Configuration On Tue, 9 Apr 2019, Pankaj Suryawanshi wrote: > I am confuse about m

Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Masahiro Yamada
On Thu, Apr 11, 2019 at 9:59 AM Sinan Kaya wrote: > > We can't seem to have a kernel with CONFIG_EXPERT set but > CONFIG_DEBUG_KERNEL unset these days. > > While some of the features under the CONFIG_EXPERT require > CONFIG_DEBUG_KERNEL, it doesn't apply for all features. > > It looks like CONFIG_

Re: \\ 答复: [PATCH] of: del redundant type conversion

2019-04-10 Thread Frank Rowand
On 4/10/19 9:21 PM, Frank Rowand wrote: > On 4/10/19 9:13 PM, Frank Rowand wrote: >> On 4/10/19 6:51 PM, xiaojiangfeng wrote: >>> My pleasure. >>> >>> I am very new to sparse. >>> >>> I guess the warning is caused by the macro min. >> >> I think the warning is likely because the type of data is 'vo

Re: [PATCH 1/2] soc: imx: gpc: use devm_platform_ioremap_resource() to simplify code

2019-04-10 Thread Shawn Guo
On Mon, Apr 01, 2019 at 06:07:08AM +, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang Applied both, thanks.

[PATCH] arm64: dts: ls1028a: Add USB dt nodes

2019-04-10 Thread Ran Wang
This patch adds USB dt nodes for LS1028A. Signed-off-by: Ran Wang --- arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls

Re: [PATCH 2/2] x86/pci: Clean up usage of X86_DEV_DMA_OPS

2019-04-10 Thread Christoph Hellwig
On Wed, Apr 10, 2019 at 04:45:01PM -0500, Bjorn Helgaas wrote: > [+cc Keith, Jonathan (VMD guys)] > > I'm OK with this from a PCI perspective. It would be nice if > > dma_domain_list > dma_domain_list_lock > add_dma_domain() > del_dma_domain() > set_dma_domain_ops() > > could all be m

Re: [PATCH] clk: imx: use devm_platform_ioremap_resource() to simplify code

2019-04-10 Thread Shawn Guo
On Mon, Apr 01, 2019 at 05:13:02AM +, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang Applied, thanks.

Re: [PATCH] of: del redundant type conversion

2019-04-10 Thread Frank Rowand
On 4/10/19 1:29 AM, xiaojiangfeng wrote: > The type of variable l in early_init_dt_scan_chosen is > int, there is no need to convert to int. > > Signed-off-by: xiaojiangfeng > --- > drivers/of/fdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/fdt.c b/driv

Re: [PATCH] of: fix expression using sizeof(void)

2019-04-10 Thread Frank Rowand
On 4/10/19 6:47 PM, xiaojiangfeng wrote: > problem detected by sparse: > drivers/of/fdt.c:1094:34: warning: expression using sizeof(void) > > Signed-off-by: xiaojiangfeng > --- > drivers/of/fdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/fdt.c b/drivers

Re: [PATCH v1 00/15] Refactor pgalloc stuff

2019-04-10 Thread Aneesh Kumar K.V
Christophe Leroy writes: > This series converts book3e64 to pte_fragment and refactor > things that are common among subarches. > > Christophe Leroy (15): > powerpc/mm: drop __bad_pte() > powerpc/mm: define __pud_free_tlb() at all time on nohash/64 > powerpc/mm: convert Book3E 64 to pte_fra

Re: [RFC PATCH v3 14/15] dcache: Implement partial shrink via Slab Movable Objects

2019-04-10 Thread Tobin C. Harding
On Thu, Apr 11, 2019 at 05:47:46AM +0100, Al Viro wrote: > On Thu, Apr 11, 2019 at 12:48:21PM +1000, Tobin C. Harding wrote: > > > Oh, so putting entries on a shrink list is enough to pin them? > > Not exactly pin, but __dentry_kill() has this: > if (dentry->d_flags & DCACHE_SHRINK_LIST)

Re: [RFC PATCH v3 14/15] dcache: Implement partial shrink via Slab Movable Objects

2019-04-10 Thread Al Viro
On Thu, Apr 11, 2019 at 12:48:21PM +1000, Tobin C. Harding wrote: > Oh, so putting entries on a shrink list is enough to pin them? Not exactly pin, but __dentry_kill() has this: if (dentry->d_flags & DCACHE_SHRINK_LIST) { dentry->d_flags |= DCACHE_MAY_FREE;

[PATCH] vfs: update d_make_root() description

2019-04-10 Thread Ian Kent
Clearify d_make_root() usage, error handling and cleanup requirements. Signed-off-by: Ian Kent --- Documentation/filesystems/porting | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/Documentation/filesystems/porting b/Documentation/filesystems/porting index

Re: \\ 答复: [PATCH] of: del redundant type conversion

2019-04-10 Thread Frank Rowand
On 4/10/19 9:13 PM, Frank Rowand wrote: > On 4/10/19 6:51 PM, xiaojiangfeng wrote: >> My pleasure. >> >> I am very new to sparse. >> >> I guess the warning is caused by the macro min. > > I think the warning is likely because the type of data is 'void *'. > > Removing the (int) cast is a good fix

Re: \\ 答复: [PATCH] of: del redundant type conversion

2019-04-10 Thread Frank Rowand
On 4/10/19 6:51 PM, xiaojiangfeng wrote: > My pleasure. > > I am very new to sparse. > > I guess the warning is caused by the macro min. I think the warning is likely because the type of data is 'void *'. Removing the (int) cast is a good fix, but does not resolve the sparse warning. -Frank

Re: [PATCH v3 1/2] cpufreq: Add sunxi nvmem based CPU scaling driver

2019-04-10 Thread Viresh Kumar
On 10-04-19, 13:41, Yangtao Li wrote: > For some SoCs, the CPU frequency subset and voltage value of each OPP > varies based on the silicon variant in use. The sunxi-cpufreq-nvmem > driver reads the efuse value from the SoC to provide the OPP framework > with required information. > > Signed-off-b

[v2 PATCH 6/9] mm: vmscan: don't demote for memcg reclaim

2019-04-10 Thread Yang Shi
The memcg reclaim happens when the limit is breached, but demotion just migrate pages to the other node instead of reclaiming them. This sounds pointless to memcg reclaim since the usage is not reduced at all. Signed-off-by: Yang Shi --- mm/vmscan.c | 38 +-

[v2 RFC PATCH 0/9] Another Approach to Use PMEM as NUMA Node

2019-04-10 Thread Yang Shi
With Dave Hansen's patches merged into Linus's tree https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c221c0b0308fd01d9fb33a16f64d2fd95f8830a4 PMEM could be hot plugged as NUMA node now. But, how to use PMEM as NUMA node effectively and efficiently is still a questi

[v2 PATCH 7/9] mm: vmscan: check if the demote target node is contended or not

2019-04-10 Thread Yang Shi
When demoting to PMEM node, the target node may have memory pressure, then the memory pressure may cause migrate_pages() fail. If the failure is caused by memory pressure (i.e. returning -ENOMEM), tag the node with PGDAT_CONTENDED. The tag would be cleared once the target node is balanced again.

[v2 PATCH 5/9] mm: vmscan: demote anon DRAM pages to PMEM node

2019-04-10 Thread Yang Shi
Since PMEM provides larger capacity than DRAM and has much lower access latency than disk, so it is a good choice to use as a middle tier between DRAM and disk in page reclaim path. With PMEM nodes, the demotion path of anonymous pages could be: DRAM -> PMEM -> swap device This patch demotes ano

[v2 PATCH 9/9] mm: numa: add page promotion counter

2019-04-10 Thread Yang Shi
Add counter for page promotion for NUMA balancing. Signed-off-by: Yang Shi --- include/linux/vm_event_item.h | 1 + mm/huge_memory.c | 4 mm/memory.c | 4 mm/vmstat.c | 1 + 4 files changed, 10 insertions(+) diff --git a/include/linux/v

[v2 PATCH 1/9] mm: define N_CPU_MEM node states

2019-04-10 Thread Yang Shi
Kernel has some pre-defined node masks called node states, i.e. N_MEMORY, N_CPU, etc. But, there might be cpuless nodes, i.e. PMEM nodes, and some architectures, i.e. Power, may have memoryless nodes. It is not very straight forward to get the nodes with both CPUs and memory. So, define N_CPU_MEM

[v2 PATCH 8/9] mm: vmscan: add page demotion counter

2019-04-10 Thread Yang Shi
Account the number of demoted pages into reclaim_state->nr_demoted. Add pgdemote_kswapd and pgdemote_direct VM counters showed in /proc/vmstat. Signed-off-by: Yang Shi --- include/linux/vm_event_item.h | 2 ++ include/linux/vmstat.h| 1 + mm/internal.h | 1 + mm/vmscan.c

[v2 PATCH 3/9] mm: numa: promote pages to DRAM when it gets accessed twice

2019-04-10 Thread Yang Shi
NUMA balancing would promote the pages to DRAM once it is accessed, but it might be just one off access. To reduce migration thrashing and memory bandwidth pressure, just promote the page which gets accessed twice by extending page_check_references() to support second reference algorithm for anony

[v2 PATCH 4/9] mm: migrate: make migrate_pages() return nr_succeeded

2019-04-10 Thread Yang Shi
The migrate_pages() returns the number of pages that were not migrated, or an error code. When returning an error code, there is no way to know how many pages were migrated or not migrated. In the following patch, migrate_pages() is used to demote pages to PMEM node, we need account how many page

[v2 PATCH 2/9] mm: page_alloc: make find_next_best_node find return cpuless node

2019-04-10 Thread Yang Shi
Need find the cloest cpuless node to demote DRAM pages. Add "cpuless" parameter to find_next_best_node() to skip DRAM node on demand. Signed-off-by: Yang Shi --- mm/internal.h | 11 +++ mm/page_alloc.c | 14 ++ 2 files changed, 21 insertions(+), 4 deletions(-) diff --git

[PATCH RESEND] fs: drop unused fput_atomic definition

2019-04-10 Thread Lukas Bulwahn
ed Jens to recipient list as he touched the place lately closeby in commit 091141a42e15 ("fs: add fget_many() and fput_many()") - compile-tested with defconfig on v5.1-rc4 and next-20190410 include/linux/fs.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/f

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Randy Dunlap
On 4/10/19 8:02 PM, Josh Triplett wrote: > On April 10, 2019 4:24:18 PM PDT, Kees Cook wrote: >> On Wed, Apr 10, 2019 at 4:22 PM Josh Triplett >> wrote: >>> >>> On April 10, 2019 3:58:55 PM PDT, Kees Cook >> wrote: On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya wrote: > > We can't seem

Re: [PATCH 2/3] clk: rockchip: Make rkpwm a critical clock on rk3288

2019-04-10 Thread elaine.zhang
hi, 在 2019/4/10 下午11:25, Doug Anderson 写道: Hi, On Tue, Apr 9, 2019 at 11:42 PM elaine.zhang wrote: hi, 在 2019/4/10 上午4:47, Douglas Anderson 写道: Most rk3288-based boards are derived from the EVB and thus use a PWM regulator for the logic rail. However, most rk3288-based boards don't specify

Re: [RFC patch 40/41] stacktrace: Remove obsolete functions

2019-04-10 Thread Josh Poimboeuf
On Wed, Apr 10, 2019 at 12:28:34PM +0200, Thomas Gleixner wrote: > No more users of the struct stack_trace based interfaces. Remove them. > > Remove the macro stubs for !CONFIG_STACKTRACE as well as they are pointless > because the storage on the call sites is conditional on CONFIG_STACKTRACE > al

[PATCH] slab: fix an infinite loop in leaks_show()

2019-04-10 Thread Qian Cai
"cat /proc/slab_allocators" could hang forever on SMP machines with kmemleak or object debugging enabled due to other CPUs running do_drain() will keep making kmemleak_object or debug_objects_cache dirty and unable to escape the first loop in leaks_show(), do { set_store_user_clean(cachep)

[PATCH v3 0/5] soundwire: code cleanup

2019-04-10 Thread Pierre-Louis Bossart
SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up. Changes since v2: fixed inversio

[PATCH v3 4/5] soundwire: stream: remove useless initialization of local variable

2019-04-10 Thread Pierre-Louis Bossart
no need to reset return value. Detected with cppcheck: [drivers/soundwire/stream.c:332]: (style) Variable 'ret' is assigned a value that is never used. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH v3 3/5] soundwire: bus: remove useless initializations

2019-04-10 Thread Pierre-Louis Bossart
No need for explicit initialization of page and ssp fields, they are already zeroed with a memset. Detected with cppcheck: [drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is reassigned a value before the old one has been used. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwi

[PATCH v3 5/5] soundwire: add missing newlines in dynamic debug logs

2019-04-10 Thread Pierre-Louis Bossart
For some reason the newlines are not used everywhere. Fix as needed. Reported-by: Joe Perches Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/bus.c| 74 +-- drivers/soundwire/cadence_master.c | 12 ++-- drivers/soundwire/intel.c | 12 ++-- drive

[PATCH v3 2/5] soundwire: fix style issues

2019-04-10 Thread Pierre-Louis Bossart
Visual inspections confirmed by checkpatch.pl --strict expose a number of style issues, specifically parameter alignment is inconsistent as if different contributors used different styles. Before we restart support for SoundWire with Sound Open Firmware on Intel platforms, let's clean all this. Fi

[PATCH v3 1/5] soundwire: intel: fix inversion in devm_kcalloc parameters

2019-04-10 Thread Pierre-Louis Bossart
the number of elements and size are inverted, fix. This probably only worked because the number of properties is hard-coded to 1. Fixes: 71bb8a1b059e ('soundwire: intel: Add Intel Master driver') Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/intel.c | 4 ++-- 1 file changed, 2 inser

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Sinan Kaya
On 4/10/2019 11:02 PM, Josh Triplett wrote: Then let's fix*that*, and get checkpatch to help enforce it in the future. EXPERT doesn't affect code generation, and neither should this. I think we have to do both. We need to go after the users as well as solve the immediate problem per this patch

Re: [PATCH v5 0/5] PCIE support for i.MX8MQ (DT changes)

2019-04-10 Thread Shawn Guo
On Fri, Apr 05, 2019 at 10:29:59AM -0700, Andrey Smirnov wrote: > Andrey Smirnov (5): > arm64: dts: imx8mq: Mark iomuxc_gpr as i.MX6Q compatible > arm64: dts: imx8mq: Add a node for SRC IP block > arm64: dts: imx8mq: Combine PCIE power domains > arm64: dts: imx8mq: Add nodes for PCIe IP blo

Re: [RFC patch 16/41] tracing: Remove the ULONG_MAX stack trace hackery

2019-04-10 Thread Steven Rostedt
On Wed, 10 Apr 2019 21:34:25 -0500 Josh Poimboeuf wrote: > > --- a/kernel/trace/trace_stack.c > > +++ b/kernel/trace/trace_stack.c > > @@ -18,8 +18,7 @@ > > > > #include "trace.h" > > > > -static unsigned long stack_dump_trace[STACK_TRACE_ENTRIES+1] = > > -{ [0 ... (STACK_TRACE_ENTRIES)]

Re: [RFC][PATCH 13/16] sched: Add core wide task selection and scheduling.

2019-04-10 Thread Aaron Lu
On Wed, Apr 10, 2019 at 04:44:18PM +0200, Peter Zijlstra wrote: > On Wed, Apr 10, 2019 at 12:36:33PM +0800, Aaron Lu wrote: > > On Tue, Apr 09, 2019 at 11:09:45AM -0700, Tim Chen wrote: > > > Now that we have accumulated quite a number of different fixes to your > > > orginal > > > posted patches.

Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Josh Triplett
On April 10, 2019 4:24:18 PM PDT, Kees Cook wrote: >On Wed, Apr 10, 2019 at 4:22 PM Josh Triplett >wrote: >> >> On April 10, 2019 3:58:55 PM PDT, Kees Cook >wrote: >> >On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya wrote: >> >> >> >> We can't seem to have a kernel with CONFIG_EXPERT set but >> >> C

Re: [PATCH] arm64: dts: imx8qxp: Add lpuart1/lpuart2/lpuart3 nodes

2019-04-10 Thread Shawn Guo
On Sat, Mar 30, 2019 at 05:07:44PM +, Daniel Baluta wrote: > lpuart nodes are part of the ADMA subsystem. See Audio DMA > memory map in iMX8 QXP RM [1] > > This patch is based on the dtsi file initially submitted by > Teo Hall in i.MX NXP internal tree. > > [1] https://www.nxp.com/docs/en/ref

Re: 32-bit Amlogic (ARM) SoC: kernel BUG in kfree()

2019-04-10 Thread Liang Yang
Hi Martin, On 2019/4/11 1:54, Martin Blumenstingl wrote: Hi Liang, On Wed, Apr 10, 2019 at 1:08 PM Liang Yang wrote: Hi Martin, On 2019/4/5 12:30, Martin Blumenstingl wrote: Hi Liang, On Fri, Mar 29, 2019 at 8:44 AM Liang Yang wrote: Hi Martin, On 2019/3/29 2:03, Martin Blumenstingl wr

Re: [PATCH RFC] clk: ux500: add range to usleep_range

2019-04-10 Thread Nicholas Mc Guire
On Wed, Apr 10, 2019 at 03:53:51PM -0700, Stephen Boyd wrote: > Quoting Nicholas Mc Guire (2019-04-06 20:13:24) > > Providing a range for usleep_range() allows the hrtimer subsystem to > > coalesce timers - the delay is runtime configurable so a factor 2 > > is taken to provide the range. > > > >

Re: [RFC patch 25/41] mm/kasan: Simplify stacktrace handling

2019-04-10 Thread Josh Poimboeuf
On Wed, Apr 10, 2019 at 12:28:19PM +0200, Thomas Gleixner wrote: > Replace the indirection through struct stack_trace by using the storage > array based interfaces. > > Signed-off-by: Thomas Gleixner > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > Cc: Dmitry Vyukov > Cc: kasan-...@googlegrou

Re: [RFC PATCH v3 14/15] dcache: Implement partial shrink via Slab Movable Objects

2019-04-10 Thread Tobin C. Harding
On Thu, Apr 11, 2019 at 03:33:22AM +0100, Al Viro wrote: > On Thu, Apr 11, 2019 at 11:34:40AM +1000, Tobin C. Harding wrote: > > +/* > > + * d_isolate() - Dentry isolation callback function. > > + * @s: The dentry cache. > > + * @v: Vector of pointers to the objects to isolate. > > + * @nr: Number

Re: [PATCH 1/5] media: platform: Aspeed: Remove use of reset line

2019-04-10 Thread Joel Stanley
On Tue, 2 Apr 2019 at 18:24, Eddie James wrote: > > The reset line is toggled by enabling the clocks, so it's not necessary > to manually toggle the reset as well. > > Signed-off-by: Eddie James Reviewed-by: Joel Stanley

[PATCH -next] memstick: remove set but not used variable 'data'

2019-04-10 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/memstick/host/jmb38x_ms.c: In function 'jmb38x_ms_issue_cmd': drivers/memstick/host/jmb38x_ms.c:371:17: warning: variable 'data' set but not used [-Wunused-but-set-variable] It's never used since introduction and can be removed. Signed-off-b

Re: [RFC patch 20/41] backtrace-test: Simplify stack trace handling

2019-04-10 Thread Josh Poimboeuf
On Wed, Apr 10, 2019 at 12:28:14PM +0200, Thomas Gleixner wrote: > Replace the indirection through struct stack_trace by using the storage > array based interfaces. > > Signed-off-by: Thomas Gleixner > --- > kernel/backtracetest.c | 11 +++ > 1 file changed, 3 insertions(+), 8 deletion

Re: [PATCH] cifs: fix page reference leak with readv/writev

2019-04-10 Thread Steve French
How was this discovered? Does it address a reported user problem? On Wed, Apr 10, 2019 at 2:38 PM wrote: > > From: Jérôme Glisse > > CIFS can leak pages reference gotten through GUP (get_user_pages*() > through iov_iter_get_pages()). This happen if cifs_send_async_read() > or cifs_write_from_ite

Re: [PATCH v3] init: Do not select DEBUG_KERNEL by default

2019-04-10 Thread Kees Cook
On Wed, Apr 10, 2019 at 5:56 PM Sinan Kaya wrote: > > We can't seem to have a kernel with CONFIG_EXPERT set but > CONFIG_DEBUG_KERNEL unset these days. > > While some of the features under the CONFIG_EXPERT require > CONFIG_DEBUG_KERNEL, it doesn't apply for all features. > > It looks like CONFIG_

Re: [PATCH 1/4] ARM: dts: imx6: RDU2: Use new CODEC reset pin name

2019-04-10 Thread Shawn Guo
On Fri, Mar 29, 2019 at 01:13:10PM -0500, Andrew F. Davis wrote: > The correct DT property for specifying a GPIO used for reset > is "reset-gpios", the driver now accepts this name, use it here. > > Note the GPIO polarity in the driver was ignored before and always > assumed to be active low, when

[PATCH -next] bus: ti-sysc: Use PTR_ERR_OR_ZERO in sysc_init_resets()

2019-04-10 Thread YueHaibing
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Signed-off-by: YueHaibing --- drivers/bus/ti-sysc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c index b696f26a3894..2b93be2882f3 100644 --- a/drivers/bus/ti-sysc.c

Re: [RFC patch 16/41] tracing: Remove the ULONG_MAX stack trace hackery

2019-04-10 Thread Josh Poimboeuf
On Wed, Apr 10, 2019 at 12:28:10PM +0200, Thomas Gleixner wrote: > No architecture terminates the stack trace with ULONG_MAX anymore. As the > code checks the number of entries stored anyway there is no point in > keeping all that ULONG_MAX magic around. > > The histogram code zeroes the storage b

Re: [RFC PATCH v3 14/15] dcache: Implement partial shrink via Slab Movable Objects

2019-04-10 Thread Al Viro
On Thu, Apr 11, 2019 at 11:34:40AM +1000, Tobin C. Harding wrote: > +/* > + * d_isolate() - Dentry isolation callback function. > + * @s: The dentry cache. > + * @v: Vector of pointers to the objects to isolate. > + * @nr: Number of objects in @v. > + * > + * The slab allocator is holding off frees

Re: [PATCH v3 1/9] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA

2019-04-10 Thread Shawn Guo
On Thu, Mar 28, 2019 at 11:49:16PM -0700, Andrey Smirnov wrote: > Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" > clock to determine if it needs to configure the IP block as operating > at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both > clocks as IMX6QDL_C

Re: [PATCH-tip v2 02/12] locking/rwsem: Implement lock handoff to prevent lock starvation

2019-04-10 Thread Waiman Long
On 04/10/2019 02:44 PM, Peter Zijlstra wrote: > On Fri, Apr 05, 2019 at 03:21:05PM -0400, Waiman Long wrote: >> Because of writer lock stealing, it is possible that a constant >> stream of incoming writers will cause a waiting writer or reader to >> wait indefinitely leading to lock starvation. >>

linux-next: manual merge of the apparmor tree with Linus' tree

2019-04-10 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the apparmor tree got a conflict in: security/apparmor/lsm.c between commit: e33c1b992377 ("apparmor: Restore Y/N in /sys for apparmor's "enabled"") from Linus' tree and commit: 876dd866c084 ("apparmor: Initial implementation of raw policy blob compr

Re: kernel BUG at fs/inode.c:LINE!

2019-04-10 Thread Al Viro
On Thu, Apr 11, 2019 at 08:50:17AM +0800, Ian Kent wrote: > On Wed, 2019-04-10 at 14:41 +0200, Dmitry Vyukov wrote: > > On Wed, Apr 10, 2019 at 2:12 PM Al Viro wrote: > > > > > > On Wed, Apr 10, 2019 at 08:07:15PM +0800, Ian Kent wrote: > > > > > > > > I'm unable to find a branch matching the li

[PATCH] rtc: mxc_v2: use dev_pm_set_wake_irq() to simplify code

2019-04-10 Thread Anson Huang
With calling dev_pm_set_wake_irq() to set MXC_V2 RTC as wakeup source for suspend, generic wake irq mechanism will automatically enable it as wakeup source when suspend, then the suspend/resume callback which are ONLY for enabling/disabling irq wake can be removed, it simplifies the code. Signed-o

  1   2   3   4   5   6   7   8   9   >