This patch adds a better explanation about the sequence number that is
returned per CS. It also fixes the comment about queue numbering rules.
Signed-off-by: Oded Gabbay
---
include/uapi/misc/habanalabs.h | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git
Hello,
syzbot found the following crash on:
HEAD commit:05d08e29 Add linux-next specific files for 20190402
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=10333a9720
kernel config: https://syzkaller.appspot.com/x/.config?x=96b7dfefc1d73906
When building CONFIG_SND_SOC_MT8183_DA7219_MAX98357A=m the following
errro pops up:
../sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c: In function
‘mt8183_da7219_max98357_dev_probe’:
../sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c:413:13: error: ‘struct
snd_soc_dai_link’ has no member
inode has been removed after commit 9511bce9fe8e
("perf/core: Fix bad use of igrab()"), Let's fix the stale comment.
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Song Liu
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Shaokun Zhang
---
include/linux/perf_event.h | 2 +-
1 file changed, 1 insertion(
On 03/04/2019 07.45, George Spelvin wrote:
>
> diff --git a/lib/ubsan.c b/lib/ubsan.c
> index e4162f59a81c..a7eb55fbeede 100644
> --- a/lib/ubsan.c
> +++ b/lib/ubsan.c
> @@ -89,8 +89,8 @@ static bool is_inline_int(struct type_descriptor *type)
> static s_max get_signed_val(struct type_descriptor
On Wed, Apr 3, 2019 at 1:07 PM Srinivas Kandagatla
wrote:
>
>
> On 03/04/2019 04:56, Stephen Rothwell wrote:
> > Hi all,
> >
> > Today's linux-next merge of the char-misc tree got a conflict in:
> >
> >drivers/misc/fastrpc.c
> >
> > between commit:
> >
> >01b76c32e3f3 ("misc: fastrpc: add
On 04/03/19 at 01:53pm, Dave Young wrote:
> On 04/03/19 at 01:35pm, Chao Fan wrote:
> > On Tue, Apr 02, 2019 at 08:03:19PM +0800, Dave Young wrote:
> > >On 04/01/19 at 12:08am, Junichi Nomura wrote:
> > >> Commit 3a63f70bf4c3a ("x86/boot: Early parse RSDP and save it in
> > >> boot_params") broke k
The pull request you sent on Tue, 2 Apr 2019 17:33:07 +0200:
> g...@gitolite.kernel.org:pub/scm/linux/kernel/git/brauner/linux
> tags/pidfd-fixes-v5.1-rc3
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a816fd6b49b6b0628b968faefd49a6de4ce27066
Thank you!
--
Deet-do
> -Original Message-
> From: Alex Williamson
> Sent: Tuesday, April 2, 2019 5:33 PM
> To: Parav Pandit
> Cc: Cornelia Huck ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; kwankh...@nvidia.com; c...@nvidia.com
> Subject: Re: [PATCHv1 6/7] vfio/mdev: Fix aborting mdev child devi
From: Steve Moskovchenko
The MPU6050 driver has recently gained support for the
ICM20602 IMU, which is very similar to MPU6xxx. However,
the ICM20602's FIFO data specifically includes temperature
readings, which were not present on MPU6xxx parts. As a
result, the driver will under-read the ICM206
+ Harish to update his findings on wcn3998.
Mean time i will perform a regression to detect the failure.
On 2019-04-02 23:35, Matthias Kaehlcke wrote:
On Tue, Apr 02, 2019 at 05:32:54PM +0530, Balakrishna Godavarthi wrote:
Hi Matthias,
On 2019-04-01 22:42, Matthias Kaehlcke wrote:
> On Mon, Ap
On 4/2/2019 8:05 PM, Thierry Reding wrote:
On Tue, Apr 02, 2019 at 05:11:25PM +0530, Vidya Sagar wrote:
On 4/1/2019 8:37 PM, Thierry Reding wrote:
On Mon, Apr 01, 2019 at 03:31:54PM +0530, Vidya Sagar wrote:
On 3/28/2019 6:45 PM, Thierry Reding wrote:
On Tue, Mar 26, 2019 at 08:43:22PM +0530,
On Mon, 25 Mar 2019, Matti Vaittinen wrote:
> Split the bd718x7.h to ROHM common and bd718x7 specific parts
> so that we do not need to add same things in every new ROHM
> PMIC header. Please note that this change requires changes also
> in bd718x7 sub-device drivers for regulators and clk.
>
> S
Hi Jean-Baptiste,
That's a good catch. I didn't realize the accel-only configuration
included temperature data as well. I've confirmed this behavior and
will send out a v2 shortly. Thanks!
-Steve
On Tue, Apr 02, 2019 at 12:01:53PM -0700, Guenter Roeck wrote:
> Use devm_platform_ioremap_resource to reduce source code size,
> improve readability, and reduce the likelyhood of bugs.
>
> The conversion was done automatically with coccinelle using the
> following semantic patch.
>
> @r@
> identif
On Tue, Apr 02, 2019 at 10:15:38AM -0600, Alex Williamson wrote:
> Memory backed DMA mappings are accounted against a user's locked
> memory limit, including multiple mappings of the same memory. This
> accounting bounds the number of such mappings that a user can create.
> However, DMA mappings t
drop it from VALID_OPEN_FLAGS.
Signed-off-by: Cao jin
---
include/linux/fcntl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/fcntl.h b/include/linux/fcntl.h
index d019df946cb2..8a2ca434be6d 100644
--- a/include/linux/fcntl.h
+++ b/include/linux/fcntl.h
@@
On 4/3/2019 3:24 AM, Alexandre Belloni wrote:
Remove the unused "depends on I2C" as the config options are already
guarded by if I2C.
Signed-off-by: Alexandre Belloni
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/rtc/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/d
On 4/2/2019 10:37 PM, Oded Gabbay wrote:
This patch removes an extra ; after the closing brackets of a while loop.
Signed-off-by: Oded Gabbay
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/misc/habanalabs/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, Apr 02, 2019 at 03:34:15PM +0200, Oscar Salvador wrote:
> NODEMASK_ALLOC is used to allocate a nodemask bitmap, ant it does it by
> first determining whether it should be allocated in the stack or dinamically
> depending on NODES_SHIFT.
> Right now, it goes the dynamic path whenever the nod
On Mon, Apr 1, 2019 at 10:24 AM Daniel Lezcano
wrote:
>
> The module support for the thermal subsystem does have a little sense:
> - some subsystems relying on it are not modules, thus forcing the
>framework to be compiled in
> - it is compiled in for almost every configs, the remaining ones
If CONFIG_ARCH_SUPPORTS_INT128, s_max is 128 bits, and variable
sign-extending shifts of such a double-word data type are a non-trivial
amount of code and complexity. Do a single-word shift *before* the cast
to (s_max), greatly simplifying the object code.
(Yes, I know "signed long" is redundant.
i2c-designware-platdrv fails to work after the system restored from
hibernation:
[ 272.775692] i2c_designware 80860F41:00: Unknown Synopsys component type:
0x
Commit 48402cee6889 ("ACPI / LPSS: Resume BYT/CHT I2C controllers from
resume_noirq") makes acpi_lpss_{suspend_late,resume_early}(
On Thu, Mar 28, 2019 at 04:47:02PM -0700, Mike Kravetz wrote:
> I stumbled on these two hugetlbfs issues while looking at other things:
> - The 'restore reserve' functionality at page free time should not
> be adjusting subpool counts.
> - A BUG can be triggered (not easily) due to temporarily ma
On 4/2/2019 7:50 PM, Thierry Reding wrote:
On Tue, Apr 02, 2019 at 02:46:27PM +0530, Vidya Sagar wrote:
On 4/1/2019 8:01 PM, Thierry Reding wrote:
On Mon, Apr 01, 2019 at 04:48:42PM +0530, Vidya Sagar wrote:
On 3/31/2019 12:12 PM, Rob Herring wrote:
On Tue, Mar 26, 2019 at 08:43:22PM +0530, V
Hi.
I have a question about 'vdso_install'.
In my understanding, vdso is embedded in the kernel.
In addition, you can run 'make vdso_install'
to install an unstripped version of vdso.
(Mainly, debugging purpose?)
By default, 'make vdso_install' will install it to
/lib/modules/$(uname -r)/vdso/.
On Tue, Apr 02, 2019 at 04:39:12PM -0700, Bart Van Assche wrote:
> On Mon, 2019-04-01 at 21:29 +0300, Leon Romanovsky wrote:
> > On Mon, Apr 01, 2019 at 02:45:54PM -0300, Jason Gunthorpe wrote:
> > > On Mon, Apr 01, 2019 at 10:36:05AM -0700, syzbot wrote:
> > > > Hello,
> > > >
> > > > syzbot found
On 03/04/2019 04:56, Stephen Rothwell wrote:
Hi all,
Today's linux-next merge of the char-misc tree got a conflict in:
drivers/misc/fastrpc.c
between commit:
01b76c32e3f3 ("misc: fastrpc: add checked value for dma_set_mask")
from the char-misc.current tree and commit:
977e6c8d1d1
88301e include/linux/list.h: add list_rotate_to_front()
> 15c8410c67 mm/slob.c: respect list_head abstraction layer
> 05d08e2995 Add linux-next specific files for 20190402
> +---+----+--
On Wed, Apr 03, 2019 at 07:45:35AM +0300, Yury Norov wrote:
> bitmap_parselist has been evolved from a pretty simple idea for long and
> now lacks for refactoring. It is not structured, has nested loops and a
> set of opaque-named variables.
>
> Things are more complicated because bitmap_parselist
Remove __bitmap_parselist helper and split the function to logical
parts.
Signed-off-by: Yury Norov
---
lib/bitmap.c | 258 +--
1 file changed, 145 insertions(+), 113 deletions(-)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index ce9ea804d06d..0c08f1
test_bitmap_parselist currently uses get_cycles which is not
implemented on some platforms, so use ktime_get() instead.
Signed-off-by: Yury Norov
---
lib/test_bitmap.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
index 6cd7d07
Currently we parse user data byte after byte which leads to
overcomplification of parsing algorithm. The only user of
bitmap_parselist_user() is not performance-critical, and so we
can copy user data to kernel buffer and simply call
bitmap_parselist(). This rework lets us unify and simplify
bitmap_
bitmap_parselist has been evolved from a pretty simple idea for long and
now lacks for refactoring. It is not structured, has nested loops and a
set of opaque-named variables.
Things are more complicated because bitmap_parselist() is a part of user
interface, and its behavior should not change.
I
Hi Greg,
Please find the pull request for 5.1 -rc cycle below.
It fixes PHY programming sequence in phy-ti-pipe3 driver to align with
TRM, requests IRQ only for OTG in phy-rcar-gen3-usb2 and a bunch of
other linker errors and compilation warnings seen in randconfig.
Please see the complete list
The patch
spi: gpio: Drop unused spi_to_pdata()
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus duri
On Wed, Apr 03, 2019 at 12:27:53PM +0800, Baolin Wang wrote:
> On Wed, 3 Apr 2019 at 11:35, Mark Brown wrote:
> > We can't leave this broken in -next for that long, can you please post
> > the patch now if you've already got it?
> OK, but I need some time to setup my environment to send this pat
The patch
spi: spi-mem: export spi_mem_default_supports_op()
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent
The patch
spi: lpspi: add missing complete in abort func at dma mode
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) a
The patch
spi: gpio: Simplify SPI_MASTER_NO_TX check in spi_gpio_probe()
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hour
The patch
regulator: lm363x: Use proper data type for regmap_read arguments
has been applied to the regulator tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in t
The patch
spi: gpio: Drop unused pdata copy in struct spi_gpio
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sen
The patch
ASoC: tlv320aic31xx: aic31xx_set_jack() can be static
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and
The patch
spi: gpio: Add local struct device pointer in spi_gpio_probe()
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hour
The patch
spi: gpio: Add local struct spi_bitbang pointer in spi_gpio_probe()
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24
The patch
regulator: lm363x: Constify regulator_ops
has been applied to the regulator tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and se
The patch
regulator: twl: Constify regulator_ops
has been applied to the regulator tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent
The patch
regmap: verify if register is writeable before writing operations
has been applied to the regmap tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the nex
bitmap_parselist has been evolved from a pretty simple idea for long and
now lacks for refactoring. It is not structured, has nested loops and a
set of opaque-named variables.
Things are more complicated because bitmap_parselist() is a part of user
interface, and its behavior should not change.
I
The patch
ASoC: Mediatek: MT8183: TS3A227: fix build error
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent
bitmap_parselist has been evolved from a pretty simple idea for long and
now lacks for refactoring. It is not structured, has nested loops and a
set of opaque-named variables.
Things are more complicated because bitmap_parselist() is a part of user
interface, and its behavior should not change.
I
We just added a module that enables testing the SLUB allocators ability
to defrag/shrink caches via movable objects. Tests are better when they
are automated.
Add automated testing via a python script for SLUB movable objects.
Example output:
$ cd path/to/linux/tools/testing/slab
$ /slub_de
Add output line for NUMA remote node defrag ratio.
Signed-off-by: Tobin C. Harding
---
tools/vm/slabinfo.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
index cbfc56c44c2f..d2c22f9ee2d8 100644
--- a/tools/vm/slabinfo.c
+++ b/tools/vm/slabinf
Add output for the newly added defrag_used_ratio sysfs knob.
Signed-off-by: Tobin C. Harding
---
tools/vm/slabinfo.c | 4
1 file changed, 4 insertions(+)
diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
index d2c22f9ee2d8..ef4ff93df4cc 100644
--- a/tools/vm/slabinfo.c
+++ b/tools/vm/
Add the two methods needed for moving objects and enable the display of
the callbacks via the /sys/kernel/slab interface.
Add documentation explaining the use of these methods and the prototypes
for slab.h. Add functions to setup the callbacks method for a slab
cache.
Add empty functions for SLAB
We have just implemented Slab Movable Objects (SMO). On NUMA systems
slabs can become unbalanced i.e. many slabs on one node while other
nodes have few slabs. Using SMO we can balance the slabs across all
the nodes.
The algorithm used is as follows:
1. Move all objects to node 0 (this has the
-C lists caches that use a ctor.
-M lists caches that support object migration.
Add command line options to show caches with a constructor and caches
that are movable (i.e. have migrate function).
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Harding
---
tools/vm/slabinfo.c | 40
It is advantageous to have all defragmentable slabs together at the
beginning of the list of slabs so that there is no need to scan the
complete list. Put defragmentable caches first when adding a slab cache
and others last.
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Harding
---
On Fri, Mar 29, 2019 at 2:46 PM Andrew-sh.Cheng
wrote:
>
> This API will get voltage as input parameter.
> Search all opp items for the item which with max frequency,
> and the voltae is smaller than provided voltage.
>
> Signed-off-by: Andrew-sh.Cheng
> ---
> drivers/opp/core.c | 55
>
Hi,
Version 2 re-structured to better follow the structure of Chirstoph's
original patchset (linked below). Functions renamed and other suggestions
on v1 from Roman implemented.
This version also adds an attempt at implementing object migration for
the dcache, appropriate filesystem folk CC'd.
The dentry slab cache is susceptible to internal fragmentation. Now
that we have Slab Movable Objects we can defragment the dcache. Object
migration is only possible for dentry objects that are not currently
referenced by anyone, i.e. we are using the object migration
infrastructure to free unuse
We just implemented movable objects for the XArray. Let's test it
intree.
Add test module for the XArray's movable objects implementation.
Functionality of the XArray Slab Movable Object implementation can
usually be seen by simply by using `slabinfo` on a running machine since
the radix tree is
Arch implementation for functions which create or destroy vmemmap mapping
(vmemmap_populate, vmemmap_free) can comprehend and allocate from inside
device memory range through driver provided vmem_altmap structure which
fulfils all requirements to enable ZONE_DEVICE on the platform. Hence just
enabl
We just implemented slab movable objects for the SLUB allocator. We
should test that code. In order to do so we need to be able to do a
number of things
- Create a cache
- Enable Slab Movable Objects for the cache
- Allocate objects to the cache
- Free objects from within specific slabs of t
We have just implemented Slab Movable Objects (object migration).
Currently object migration is used to defrag a cache. On NUMA systems
it would be nice to be able to control the source and destination nodes
when moving objects.
Add CONFIG_SMO_NODE to guard this feature. CONFIG_SMO_NODE depends
Implement functions to migrate objects. This is based on
initial code by Matthew Wilcox and was modified to work with
slab object migration.
Cc: Matthew Wilcox
Co-developed-by: Christoph Lameter
Signed-off-by: Tobin C. Harding
---
lib/radix-tree.c | 13 +
lib/xarray.c | 46
In order to support object migration on the dentry cache we need to have
a determined object state at all times. Without a constructor the object
would have a random state after allocation.
Provide a dentry constructor.
Signed-off-by: Tobin C. Harding
---
fs/dcache.c | 37 ++
From: Robin Murphy
Enabling ZONE_DEVICE (through ARCH_HAS_ZONE_DEVICE) for arm64 reveals that
memremap's internal helpers for sparsemem sections conflict with arm64's
definitions for hugepages which inherit the name of "sections" from earlier
versions of the ARM architecture.
Disambiguate memrem
Internal fragmentation can occur within pages used by the slub
allocator. Under some workloads large numbers of pages can be used by
partial slab pages. This under-utilisation is bad simply because it
wastes memory but also because if the system is under memory pressure
higher order allocations m
Memory hot remove uses get_nid_for_pfn() while tearing down linked sysfs
entries between memory block and node. It first checks pfn validity with
pfn_valid_within() before fetching nid. With CONFIG_HOLES_IN_ZONE config
(arm64 has this enabled) pfn_valid_within() calls pfn_valid().
pfn_valid() is a
ZONE_DEVICE based device memory like persistent memory would typically be
more than available system RAM and can have size in TBs. Allocating struct
pages from system RAM for these vast range of device memory will reduce
amount of system RAM available for other purposes. There is a mechanism
with s
Sysfs memory probe interface (/sys/devices/system/memory/probe) can accept
starting physical address of an entire memory block to be hot added into
the kernel. This is in addition to the existing ACPI based interface. This
just enables it with the required config CONFIG_ARCH_MEMORY_PROBE.
Signed-o
Memory removal from an arch perspective involves tearing down two different
kernel based mappings i.e vmemmap and linear while releasing related page
table pages allocated for the physical memory range to be removed.
Define a common kernel page table tear down helper remove_pagetable() which
can b
This series enables memory hot remove on arm64, fixes a memblock removal
ordering problem in generic __remove_memory(), enables sysfs memory probe
interface on arm64. It also enables ZONE_DEVICE with struct vmem_altmap
support.
Testing:
Tested hot remove on arm64 for all 4K, 16K, 64K page config
On Wed, 3 Apr 2019 at 11:35, Mark Brown wrote:
>
> On Wed, Apr 03, 2019 at 10:12:47AM +0800, Baolin Wang wrote:
>
> > snd-soc-sprd-platform-objs := sprd-pcm-dma.o sprd-pcm-compress.o
>
> > obj-$(CONFIG_SND_SOC_SPRD) += snd-soc-sprd-platform.o
>
> > I will send out one incremental patch to fix this
Fixed - Updated author to match signed off line
On Tue, Apr 2, 2019 at 3:40 PM Stephen Rothwell wrote:
>
> Hi all,
>
> Commit
>
> d0cb257cb7b0 ("Show locallease in /proc/mounts for cifs shares mounted with
> locallease feature.")
>
> is missing a Signed-off-by from its author.
>
> --
> Cheers,
On Tue, Apr 02, 2019 at 10:04:05PM -0300, Andre Dainez wrote:
> Fix checkpatch errors:
>
> CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence
> issues
> CHECK: Macro argument 'nlh' may be better as '(nlh)' to avoid precedence
> issues
>
> Signed-off-by: Andre Dainez
> ---
On Wed, Apr 3, 2019 at 2:02 AM Guenter Roeck wrote:
> Use devm_platform_ioremap_resource to reduce source code size,
> improve readability, and reduce the likelyhood of bugs.
>
> The conversion was done automatically with coccinelle using the
> following semantic patch.
>
> @r@
> identifier res,
From: YueHaibing
When building CONFIG_SND_SOC_MT8183_DA7219_MAX98357A=m
gcc warn this:
sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c: In function
mt8183_da7219_max98357_dev_probe:
sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c:413:13: error: struct
snd_soc_dai_link has no member named
Hi,
On Tue, Apr 2, 2019 at 8:17 PM Guenter Roeck wrote:
>
> On Tue, Apr 2, 2019 at 4:38 PM Doug Anderson wrote:
> >
> > Hi,
> >
> > On Tue, Apr 2, 2019 at 4:19 PM Matthias Kaehlcke wrote:
> > >
> > > Hi Doug,
> > >
> > > On Tue, Apr 02, 2019 at 03:44:44PM -0700, Douglas Anderson wrote:
> > > >
On Sat, Mar 23, 2019 at 1:32 AM Enrico Weigelt, metux IT consult
wrote:
> On 21.03.19 10:23, Andy Shevchenko wrote:
>
> > ...and on top of that GPIO sysfs interface is deprecated.
>
> I don't like the idea of deprecating this. It might not be enough for
> all usecases, but for a lot of usecases, i
Pls ignore this.
On 2019/4/3 12:11, Yue Haibing wrote:
> From: YueHaibing
>
> When building CONFIG_SND_SOC_MT8183_DA7219_MAX98357A=m
> gcc warn this:
>
> sound/soc/mediatek/mt8183/mt8183-mt6358-ts3a227-max98357.c: In function
> mt8183_mt6358_ts3a227_max98357_dev_probe:
> sound/soc/mediatek/mt8
On Tue, Apr 2, 2019 at 7:18 AM Nicolas Pitre wrote:
>
> The @linaro version won't be valid much longer.
Generally I like seeing these come in from the old address just to verify.
But at least the old address is cc'd..
Linus
From: YueHaibing
When building CONFIG_SND_SOC_MT8183_DA7219_MAX98357A=m
gcc warn this:
sound/soc/mediatek/mt8183/mt8183-mt6358-ts3a227-max98357.c: In function
mt8183_mt6358_ts3a227_max98357_dev_probe:
sound/soc/mediatek/mt8183/mt8183-mt6358-ts3a227-max98357.c:325:13: error:
struct snd_soc_dai_
Spi_to_pdata() is not used anywhere in the code. Drop it.
Signed-off-by: Andrey Smirnov
Cc: Mark Brown
Cc: Chris Healy
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/spi/spi-gpio.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/spi/spi-gpio.c b/dri
DT use-case already relies on SPI core to control CS (requested by
of_spi_register_master() and controlled spi_set_cs()), so there's no
need to try to request those GPIO in spi-gpio code. Change the code
such that spi-gpio's CS related code is only used if device is probed
via pdata.
Signed-off-by
The logic of setting mflags in spi_gpio_request() is very simple and
there isn't much benefit in having it in that function. Move all of
that code outside into spi_gpio_probe() in order to simplify things.
Signed-off-by: Andrey Smirnov
Cc: Mark Brown
Cc: Chris Healy
Cc: linux-...@vger.kernel.or
Use a local "struct spi_bitbang *bb" in spi_gpio_probe() for
brevity. No functional change intended.
Signed-off-by: Andrey Smirnov
Cc: Mark Brown
Cc: Chris Healy
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/spi/spi-gpio.c | 27 ++-
1 file c
Drop unused pdata copy in struct spi_gpio. No functional change
intended.
Signed-off-by: Andrey Smirnov
Cc: Mark Brown
Cc: Chris Healy
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/spi/spi-gpio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/spi/spi
There's a number of failure paths in spi_gpio_probe() that do not call
spi_master_put() potentially leaking memory. Fix this problem by
registering a cleanup funciont via devm_add_action_or_reset() right
after SPI controller is allocated.
Signed-off-by: Andrey Smirnov
Cc: Mark Brown
Cc: Chris He
Move all of the code doing struct spi_bitbang initialization, so that
it can be paired with devm_spi_register_master() in order to avoid
having to call spi_bitbang_stop() explicitly.
Signed-off-by: Andrey Smirnov
Cc: Mark Brown
Cc: Chris Healy
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger
There's no code using 'pdev' field in struct spi_gpio. Drop it.
Signed-off-by: Andrey Smirnov
Cc: Mark Brown
Cc: Chris Healy
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/spi/spi-gpio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/spi/spi-gpio.c b/
Move code calling spi_get_gpio_descs() to happen after ctlr->dev's
name is set in order to have proper GPIO consumer names.
Before:
cat /sys/kernel/debug/gpio
gpiochip0: GPIOs 0-31, parent: platform/40049000.gpio, vf610-gpio:
gpio-6 (|regulator-usb0-vbus ) out lo
gpiochip1
Swap branches of the if statement in order to simplify it's logical
condition being checked. No functional change intended.
Signed-off-by: Andrey Smirnov
Cc: Mark Brown
Cc: Chris Healy
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/spi/spi-gpio.c | 12 ++--
Replace spi_bitbang_start() with a combination of spi_bitbang_init()
and devm_spi_register_master() and drop all of the explicit
cleanup-related code that's no longer necessary.
Signed-off-by: Andrey Smirnov
Cc: Mark Brown
Cc: Chris Healy
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kern
Use a local "struct device *dev" in spi_gpio_probe() for brevity. No
functional change intended.
Signed-off-by: Andrey Smirnov
Cc: Mark Brown
Cc: Chris Healy
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/spi/spi-gpio.c | 11 ++-
1 file changed, 6 insertions
Everyone:
This series contains a fix ("spi: Don't call spi_get_gpio_descs()
before device name is set) and improvements for SPI GPIO and driver I
made while looking at that code recently. Hopefully each patch is
self-explanatory.
Feedback is welcome!
Thanks,
Andrey Smirnov
Andrey Smirnov (12):
On Tue, Mar 12, 2019 at 1:56 AM Enrico Weigelt, metux IT consult
wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> Signed-off-by: Enrico Weigelt, metux IT consult
Changed subject to gpio: zynq: and applied.
Yours,
Linus Wall
Hi all,
Today's linux-next merge of the char-misc tree got a conflict in:
drivers/misc/fastrpc.c
between commit:
01b76c32e3f3 ("misc: fastrpc: add checked value for dma_set_mask")
from the char-misc.current tree and commit:
977e6c8d1d18 ("misc: fastrpc: use correct spinlock variant")
f
On Tue, Mar 12, 2019 at 1:56 AM Enrico Weigelt, metux IT consult
wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> Signed-off-by: Enrico Weigelt, metux IT consult
Patch applied.
Yours,
Linus Walleij
1 - 100 of 945 matches
Mail list logo
