Re: [PATCH 4.18 00/53] 4.18.16-stable review

2018-10-19 Thread Greg Kroah-Hartman
On Fri, Oct 19, 2018 at 02:43:12PM -0600, Shuah Khan wrote: > On 10/18/2018 11:53 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.18.16 release. > > There are 53 patches in this series, all will be posted as a response > > to this one. If anyone has any iss

Re: [PATCH 4.18 00/53] 4.18.16-stable review

2018-10-19 Thread Greg Kroah-Hartman
On Fri, Oct 19, 2018 at 08:50:29AM -0700, Guenter Roeck wrote: > On Thu, Oct 18, 2018 at 07:53:53PM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.18.16 release. > > There are 53 patches in this series, all will be posted as a response > > to this one.

Re: [PATCH 0/6] Tracing register accesses with pstore and dynamic debug

2018-10-19 Thread Sai Prakash Ranjan
On 10/20/2018 10:55 AM, Joel Fernandes wrote: On Sun, Sep 09, 2018 at 01:57:01AM +0530, Sai Prakash Ranjan wrote: Hi, This patch series adds Event tracing support to pstore and is continuation to the RFC patch introduced to add a new tracing facility for register accesses called Register Trace

Re: in_compat_syscall() returns from kernel thread for X86_32.

2018-10-19 Thread Andreas Dilger
On Oct 18, 2018, at 11:26 AM, Andy Lutomirski wrote: > > On Wed, Oct 17, 2018 at 9:36 PM NeilBrown wrote: >> >> On Wed, Oct 17 2018, Andy Lutomirski wrote: >> >>> On Wed, Oct 17, 2018 at 6:48 PM NeilBrown wrote: Was: Re: [tip:x86/asm] x86/entry: Rename is_{ia32,x32}_task() to

Re: [PATCH v2 6/5] statx: add STATX_RESULT_MASK flag

2018-10-19 Thread Andreas Dilger
On Oct 19, 2018, at 11:42 AM, Miklos Szeredi wrote: >>> +#define STATX_RESULT_MASK STATX__RESERVED >> >> Please don't use that bit. > > Using it internally is perfectly harmless. If we'll need to extend > statx in the future and make use of this flag externally, then we can > easily move the i

Re: [PATCH 0/6] Tracing register accesses with pstore and dynamic debug

2018-10-19 Thread Joel Fernandes
On Sun, Sep 09, 2018 at 01:57:01AM +0530, Sai Prakash Ranjan wrote: > Hi, > > This patch series adds Event tracing support to pstore and is continuation > to the RFC patch introduced to add a new tracing facility for register > accesses called Register Trace Buffer(RTB). Since we decided to not in

Re: [PATCH 03/34] teach move_mount(2) to work with OPEN_TREE_CLONE [ver #12]

2018-10-19 Thread Al Viro
On Fri, Oct 19, 2018 at 11:36:19PM +0100, David Howells wrote: > Alan Jenkins wrote: > > > # open_tree_clone 3 > # cd /proc/self/fd/3 > > # mount --move . /mnt > > [ 41.747831] mnt_flags=1020 umount=0 > > # cd / > > # umount /mnt > > umount: /mnt: target is busy > > > > ^ a newly introduced bu

Re: [PATCH 03/24] iov_iter: Add I/O discard iterator

2018-10-19 Thread Al Viro
On Sat, Oct 20, 2018 at 02:10:59AM +0100, David Howells wrote: > @@ -1060,6 +1074,9 @@ void iov_iter_revert(struct iov_iter *i, size_t unroll) > } > unroll -= i->iov_offset; > switch (iov_iter_type(i)) { > + case ITER_DISCARD: > + i->iov_offset = 0; > +

Re: [PATCH 02/24] iov_iter: Renumber the ITER_* constants in uio.h

2018-10-19 Thread Al Viro
On Sat, Oct 20, 2018 at 02:10:52AM +0100, David Howells wrote: > Renumber the ITER_* constants in uio.h to be contiguous to make comparing > them more efficient in a switch-statement. Are you sure that they *are* more efficient that way? Some of those paths are fairly hot, so much that I would re

Re: [PATCH 01/24] iov_iter: Separate type from direction and use accessor functions

2018-10-19 Thread Al Viro
On Sat, Oct 20, 2018 at 02:10:44AM +0100, David Howells wrote: One general comment: I would strongly recommend splitting the iov_iter initializers change into a separate patch. > index 8d41ca7bfcf1..dcdbcb6f09f8 100644 > --- a/fs/cifs/file.c > +++ b/fs/cifs/file.c > @@ -2990,7 +2990,7 @@ cifs_rea

Re: [PATCH v4 2/4] perf: add arm64 smmuv3 pmu driver

2018-10-19 Thread kbuild test robot
Hi Neil, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux-sof-driver/master] [also build test ERROR on v4.19-rc8 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: perf overlapping maps...

2018-10-19 Thread David Miller
From: David Miller Date: Fri, 19 Oct 2018 21:05:49 -0700 (PDT) > One solution I've come up with is: > > 1) When synthesizing a fork event, set PERF_RECORD_MISC_COMM_EXEC in >header->misc. > > 2) Use this to elide the map groups clone in >thread__clone_map_groups(). Looking into code hi

perf overlapping maps...

2018-10-19 Thread David Miller
Symbols aren't exactly right all the time on sparc and even the owner of a sample is set to "unknown" from time to time so I turned on some debugging to investigate. One thing that stands out is that we get overlapping maps all the time. So I tried to narrow down how this happens. Here is one

[tip:locking/core 6/10] arch/x86/include/asm/rmwcc.h:23:17: error: jump into statement expression

2018-10-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking/core head: 01a14bda11add9dcd4a59200f13834d634559935 commit: 7aa54be2976550f17c11a1c3e3630002dea39303 [6/10] locking/qspinlock, x86: Provide liveness guarantee config: x86_64-randconfig-u0-10201040 (attached as .config) c

Second attempt to reach you: URGENT

2018-10-19 Thread Kelvin Cord
Hello, I'm Kelvin Cord, with First City Monument Bank here in Nigeria. I was wondering if you received my last email. I sincerely seek to present you as the Next of Kin to a late client who left behind ($170 Million USD) in a fixed deposit account in my bank before his demise. The British born

[PATCH v2 1/1] ARM: dts: imx6sx-sdb: Add flexcan support

2018-10-19 Thread Joakim Zhang
From: Dong Aisheng CAN transceiver is different on RevA and RevB board. It's active high on RevA while active low on Rev B. Signed-off-by: Dong Aisheng Signed-off-by: Joakim Zhang --- arch/arm/boot/dts/imx6sx-sdb-reva.dts | 12 arch/arm/boot/dts/imx6sx-sdb.dts | 5 arch/ar

RE: [PATCH] ARM: dts: imx6sx-sdb: Add flexcan support

2018-10-19 Thread Joakim Zhang
-Original Message- From: Fabio Estevam [mailto:feste...@gmail.com] Sent: 2018年10月19日 20:52 To: Joakim Zhang Cc: Shawn Guo ; Sascha Hauer ; Sascha Hauer ; Fabio Estevam ; dl-linux-imx ; Rob Herring ; Mark Rutland ; A.s. Dong ; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2018-10-19 Thread Moritz Fischer
On Fri, Oct 19, 2018 at 2:33 PM Moritz Fischer wrote: > > Hi Nava, > > Looks good to me, a couple of nits inline below. > > On Fri, Oct 19, 2018 at 1:50 AM Nava kishore Manne > wrote: > > > > This patch adds FPGA Manager support for the Xilinx > > ZynqMp chip. > > Isn't it ZynqMP ? > > > > Signed

[PATCH 1/3] tracing: Fix synthetic event to accept unsigned modifier

2018-10-19 Thread Steven Rostedt
From: Masami Hiramatsu Fix synthetic event to accept unsigned modifier for its field type correctly. Currently, synthetic_events interface returns error for "unsigned" modifiers as below; # echo "myevent unsigned long var" >> synthetic_events sh: write error: Invalid argument This is because

[PATCH 3/3] selftests: ftrace: Add synthetic event syntax testcase

2018-10-19 Thread Steven Rostedt
From: Masami Hiramatsu Add a testcase to check the syntax and field types for synthetic_events interface. Link: http://lkml.kernel.org/r/153986838264.18251.16627517536956299922.stgit@devbox Acked-by: Shuah Khan Signed-off-by: Masami Hiramatsu Signed-off-by: Steven Rostedt (VMware) --- .../

[PATCH 0/3] [GIT PULL] tracing: A few small fixes to synthetic events

2018-10-19 Thread Steven Rostedt
Linus (aka Greg), Masami found some issues with the creation of synthetic events. The first two patches fix handling of unsigned type, and handling of a space before an ending semi-colon. The third patch adds a selftest to test the processing of synthetic events. Please pull the latest trace-v

[PATCH 2/3] tracing: Fix synthetic event to allow semicolon at end

2018-10-19 Thread Steven Rostedt
From: Masami Hiramatsu Fix synthetic event to allow independent semicolon at end. The synthetic_events interface accepts a semicolon after the last word if there is no space. # echo "myevent u64 var;" >> synthetic_events But if there is a space, it returns an error. # echo "myevent u64 var

Re: [RFC PATCH 1/5] x86: introduce preemption disable prefix

2018-10-19 Thread Masami Hiramatsu
On Fri, 19 Oct 2018 04:44:33 + Nadav Amit wrote: > at 9:29 PM, Andy Lutomirski wrote: > > >> On Oct 18, 2018, at 6:08 PM, Nadav Amit wrote: > >> > >> at 10:00 AM, Andy Lutomirski wrote: > >> > On Oct 18, 2018, at 9:47 AM, Nadav Amit wrote: > > at 8:51 PM, Andy Lutomirsk

Re: [PATCH v7 00/21] tpm: separate tpm 1.x and tpm 2.x commands

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: This patch series provides initial separation of tpm 1.x and tpm 2.x commands, in foresight that the tpm 1.x chips will eventually phase out and can be compiled out for modern systems. A new file is added tpm1-cmd.c that contains tpm 1.x specific commands

[PATCH 24/24] afs: Probe multiple fileservers simultaneously

2018-10-19 Thread David Howells
Send probes to all the unprobed fileservers in a fileserver list on all addresses simultaneously in an attempt to find out the fastest route whilst not getting stuck for 20s on any server or address that we don't get a reply from. This alleviates the problem whereby attempting to access a new serv

[PATCH 18/24] afs: Get the target vnode in afs_rmdir() and get a callback on it

2018-10-19 Thread David Howells
Get the target vnode in afs_rmdir() and validate it before we attempt the deletion, The vnode pointer will be passed through to the delivery function in a later patch so that the delivery function can mark it deleted. Signed-off-by: David Howells --- fs/afs/dir.c | 11 ++- 1 file chan

[PATCH 17/24] afs: Calc callback expiry in op reply delivery

2018-10-19 Thread David Howells
Calculate the callback expiration time at the point of operation reply delivery, using the reply time queried from AF_RXRPC on that call as a base. Signed-off-by: David Howells --- fs/afs/afs.h |2 +- fs/afs/fsclient.c | 22 +- fs/afs/inode.c|4 ++-- fs/af

[PATCH 19/24] afs: Expand data structure fields to support YFS

2018-10-19 Thread David Howells
Expand fields in various data structures to support the expanded information that YFS is capable of returning. Signed-off-by: David Howells --- fs/afs/afs.h | 35 ++- fs/afs/fsclient.c |9 + 2 files changed, 23 insertions(+), 21 deletions(-) d

[PATCH 21/24] afs: Allow dumping of server cursor on operation failure

2018-10-19 Thread David Howells
Provide an option to allow the file or volume location server cursor to be dumped if the rotation routine falls off the end without managing to contact a server. Signed-off-by: David Howells --- fs/afs/Kconfig | 12 +++ fs/afs/addr_list.c |2 ++ fs/afs/internal.h |3 +++

[PATCH 15/24] afs: Implement the YFS cache manager service

2018-10-19 Thread David Howells
Implement the YFS cache manager service which gives extra capabilities on top of AFS. This is done by listening for an additional service on the same port and indicating that anyone requesting an upgrade should be upgraded to the YFS port. Signed-off-by: David Howells --- fs/afs/cmservice.c

[PATCH 22/24] afs: Eliminate the address pointer from the address list cursor

2018-10-19 Thread David Howells
Eliminate the address pointer from the address list cursor as it's redundant (ac->addrs[ac->index] can be used to find the same address) and address lists must be replaced rather than being rearranged, so is of limited value. Signed-off-by: David Howells --- fs/afs/addr_list.c |2 -- fs/afs

[PATCH 23/24] afs: Fix callback handling

2018-10-19 Thread David Howells
In some circumstances, the callback interest pointer is NULL, so in such a case we can't dereference it when checking to see if the callback is broken. This causes an oops in some circumstances. Fix this by replacing the function that worked out the aggregate break counter with one that actually

[PATCH 20/24] afs: Implement YFS support in the fs client

2018-10-19 Thread David Howells
Implement support for talking to YFS-variant fileservers in the cache manager and the filesystem client. These implement upgraded services on the same port as their AFS services. YFS fileservers provide expanded capabilities over AFS. Signed-off-by: David Howells --- fs/afs/Makefile

[PATCH 16/24] afs: Fix FS.FetchStatus delivery from updating wrong vnode

2018-10-19 Thread David Howells
The FS.FetchStatus reply delivery function was updating inode of the directory in which a lookup had been done with the status of the looked up file. This corrupts some of the directory state. Fixes: 5cf9dd55a0ec ("afs: Prospectively look up extra files when doing a single lookup") Signed-off-by

[PATCH 11/24] afs: Don't invoke the server to read data beyond EOF

2018-10-19 Thread David Howells
When writing a new page, clear space in the page rather than attempting to load it from the server if the space is beyond the EOF. Signed-off-by: David Howells --- fs/afs/write.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/fs/afs/write.c b/fs/afs/write.c index fdb9d602412

[PATCH 13/24] afs: Commit the status on a new file/dir/symlink

2018-10-19 Thread David Howells
Call the function to commit the status on a new file, dir or symlink so that the access rights for the caller's key are cached for that object. Without this, the next access to the file will cause a FetchStatus operation to be emitted to retrieve the access rights. Signed-off-by: David Howells -

[PATCH 12/24] afs: Increase to 64-bit volume ID and 96-bit vnode ID for YFS

2018-10-19 Thread David Howells
Increase the sizes of the volume ID to 64 bits and the vnode ID (inode number equivalent) to 96 bits to allow the support of YFS. This requires the iget comparator to check the vnode->fid rather than i_ino and i_generation as i_ino is not sufficiently capacious. It also requires this data to be p

[PATCH 14/24] afs: Remove callback details from afs_callback_break struct

2018-10-19 Thread David Howells
Remove unnecessary details of a broken callback, such as version, expiry and type, from the afs_callback_break struct as they're not actually used and make the list take more memory. Signed-off-by: David Howells --- fs/afs/afs.h |2 +- fs/afs/callback.c |8 ++-- fs/afs/cmserv

[PATCH 08/24] afs: Fix TTL on VL server and address lists

2018-10-19 Thread David Howells
Currently the TTL on VL server and address lists isn't set in all circumstances and may be set to poor choices in others, since the TTL is derived from the SRV/AFSDB DNS record if and when available. Fix the TTL by limiting the range to a minimum and maximum from the current time. At some point t

[PATCH 09/24] afs: Handle EIO from delivery function

2018-10-19 Thread David Howells
Fix afs_deliver_to_call() to handle -EIO being returned by the operation delivery function, indicating that the call found itself in the wrong state, by printing an error and aborting the call. Currently, an assertion failure will occur. This can happen, say, if the delivery function falls off th

[PATCH 10/24] afs: Add a couple of tracepoints to log I/O errors

2018-10-19 Thread David Howells
Add a couple of tracepoints to log the production of I/O errors within the AFS filesystem. Signed-off-by: David Howells --- fs/afs/cmservice.c | 10 +++-- fs/afs/dir.c | 18 ++ fs/afs/internal.h | 11 ++ fs/afs/mntpt.c |5 ++- fs/

[PATCH 03/24] iov_iter: Add I/O discard iterator

2018-10-19 Thread David Howells
Add a new iterator, ITER_DISCARD, that can only be used in READ mode and just discards any data copied to it. This is useful in a network filesystem for discarding any unwanted data sent by a server. Signed-off-by: David Howells --- include/linux/uio.h |7 lib/iov_iter.c | 96 +

[PATCH 05/24] afs: Set up the iov_iter before calling afs_extract_data()

2018-10-19 Thread David Howells
afs_extract_data sets up a temporary iov_iter and passes it to AF_RXRPC each time it is called to describe the remaining buffer to be filled. Instead: (1) Put an iterator in the afs_call struct. (2) Set the iterator for each marshalling stage to load data into the appropriate places. A n

[PATCH 07/24] afs: Implement VL server rotation

2018-10-19 Thread David Howells
Track VL servers as independent entities rather than lumping all their addresses together into one set and implement server-level rotation by: (1) Add the concept of a VL server list, where each server has its own separate address list. This code is similar to the FS server list. (2) Use

[PATCH 04/24] afs: Better tracing of protocol errors

2018-10-19 Thread David Howells
Include the site of detection of AFS protocol errors in trace lines to better be able to determine what went wrong. Signed-off-by: David Howells --- fs/afs/cmservice.c |6 ++ fs/afs/fsclient.c | 117 +++- fs/afs/inode.c |

[PATCH 02/24] iov_iter: Renumber the ITER_* constants in uio.h

2018-10-19 Thread David Howells
Renumber the ITER_* constants in uio.h to be contiguous to make comparing them more efficient in a switch-statement. Signed-off-by: David Howells --- include/linux/uio.h |8 +++-- lib/iov_iter.c | 77 ++- 2 files changed, 62 insertions(

[PATCH 01/24] iov_iter: Separate type from direction and use accessor functions

2018-10-19 Thread David Howells
In the iov_iter struct, separate the iterator type from the iterator direction and use accessor functions to access them in most places. Convert a bunch of places to use switch-statements to access them rather then chains of bitwise-AND statements. This makes it easier to add further iterator typ

[PATCH 06/24] afs: Improve FS server rotation error handling

2018-10-19 Thread David Howells
Improve the error handling in FS server rotation by: (1) Cache the latest useful error value for the fs operation as a whole in struct afs_fs_cursor separately from the error cached in the afs_addr_cursor struct. The one in the address cursor gets clobbered occasionally. Copy ove

[PATCH 00/24] AFS development

2018-10-19 Thread David Howells
Hi Al, Here's a set of development patches for AFS if you could pull it for the upcoming merge window. Its main features are: (1) Provide wrapper functions for accessing iov iterators, renumber the iterator types to be more amenable to switching on and provide a new read discard ite

Re: [PATCH v7 13/21] tpm: add tpm_auto_startup() into tpm-interface.c

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: Add wrapper tpm_auto_startup() to tpm-interface.c instead of open coded decision between TPM 1.x and TPM 2.x in tpm-chip.c Signed-off-by: Tomas Winkler Tested-by: Jarkko Sakkinen --- V3: New in the series. V4: Fix the commit message. V5-7: Resend. dri

Re: [PATCH v7 12/21] tpm: factor out tpm_startup function

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: TPM manual startup is used only from within TPM 1.x or TPM 2.x code, hence remove tpm_startup() function from tpm-interface.c and add two static functions implementations tpm1_startup() and tpm2_startup() into to tpm1-cmd.c and tpm2-cmd.c respectively. S

Re: [PATCH v7 11/21] tpm: factor out tpm 1.x pm suspend flow into tpm1-cmd.c

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: Factor out TPM 1.x suspend flow from tpm-interface.c into a new function tpm1_pm_suspend() in tpm1-cmd.c Signed-off-by: Tomas Winkler Reviewed-by: Jarkko Sakkinen I'll test this later. /Jarkko

Re: [PATCH] Documentation: dynamic-debug: fix wildcard description

2018-10-19 Thread Randy Dunlap
On 10/19/18 5:20 PM, Will Korteland wrote: > On 2018-10-20 00:16, Randy Dunlap wrote: >> -A another way is to use wildcard. The match rule support ``*`` (matches >> -zero or more characters) and ``?`` (matches exactly one character).For >> +A another way is to use wildcards. The match rule supports

Re: [PATCH 1/2] sched/fair: move rq_of helper function

2018-10-19 Thread kbuild test robot
Hi Vincent, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on v4.19-rc8 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH v7 09/21] tpm: factor out tpm1_get_random into tpm1-cmd.c

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: Factor out get random implementation from tpm-interface.c into tpm1_get_random function in tpm1-cmd.c. No functional changes. Signed-off-by: Tomas Winkler Reviewed-by: Jarkko Sakkine *If* there is need for a new version can you change that to: Revie

Re: [PATCH v7 04/21] tpm: factor out tpm 1.x duration calculation to tpm1-cmd.c

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: Factor out TPM 1.x commands calculation into tpm1-cmd.c file. and change the prefix from tpm_ to tpm1_. No functional change is done here. Signed-off-by: Tomas Winkler Tested-by: Jarkko Sakkinen --- V2-V3: Rebase V4: 1. Remove the licence statement it'

Re: [PATCH v7 02/21] tpm2: add new tpm2 commands according to TCG 1.36

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: 1. TPM2_CC_LAST has moved from 182 to 193 2. Convert tpm2_ordinal_duration from an array into a switch statement, as there are not so many commands that require special duration relative to a number of commands, the switch statement function is call

Re: [PATCH v7 01/21] tpm: tpm_i2c_nuvoton: use correct command duration for TPM 2.x

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: tpm_i2c_nuvoton calculated commands duration using TPM 1.x values via tpm_calc_ordinal_duration() also for TPM 2.x chips. Call tpm2_calc_ordinal_duration() for retrieving ordinal duration for TPM 2.X chips. Cc: sta...@vger.kernel.org Cc: Nayna Jain Sign

[PATCH] ALSA: ca0106: Disable IZD on SB0570 DAC to fix audio pops

2018-10-19 Thread Alex Stanoev
The Creative Audigy SE (SB0570) card currently exhibits an audible pop whenever playback is stopped or resumed, or during silent periods of an audio stream. Initialise the IZD bit to the 0 to eliminate these pops. The Infinite Zero Detection (IZD) feature on the DAC causes the output to be shunted

[PATCH v3 2/2] perf/x86/kvm: Avoid unnecessary work in guest filtering

2018-10-19 Thread Andi Kleen
From: Andi Kleen KVM added a workaround for PEBS events leaking into guests with 26a4f3c08de4 ("perf/x86: disable PEBS on a guest entry.") This uses the VT entry/exit list to add an extra disable of the PEBS_ENABLE MSR. Intel also added a fix for this issue to microcode updates on Haswell/Broadw

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-19 Thread Joel Fernandes
On Fri, Oct 19, 2018 at 07:35:36PM +0200, Uladzislau Rezki (Sony) wrote: > Objective > - > Initiative of improving vmalloc allocator comes from getting many issues > related to allocation time, i.e. sometimes it is terribly slow. As a result > many workloads which are sensitive for long (mo

[PATCH v3 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-19 Thread Andi Kleen
From: Andi Kleen For bug workarounds or checks it is useful to check for specific microcode revisionss. Add a new table format to check for steppings with min microcode revisions. This does not change the existing x86_cpu_id because it's an ABI shared with modutils, and also has quite different

[PATCH v1] x86/microcode: Handle negative microcode revisions

2018-10-19 Thread Andi Kleen
From: Andi Kleen The Intel ucode revision space is unsigned. Inside Intel there are special microcodes that have the highest bit set, and they are considered to have a higher revision than any microcodes that don't have this bit set. The function comparing the microcodes in the Linux driver comp

Re: [PATCH v2 6/5] statx: add STATX_RESULT_MASK flag

2018-10-19 Thread David Howells
Miklos Szeredi wrote: > This is very much about the basic statx fields. I.e. what does > result_mask == STATX_BASIC_STATS means? > > a) this is a legacy stat() implementation that doesn't fill in the > result_mask properly > > b) this is an up-todate stat() implementation that does fill the

Re: [PATCH v2 1/2] x86/cpufeature: Add facility to match microcode revisions

2018-10-19 Thread Andi Kleen
> > + u32 min_ucode; > > +}; > > + > > +const struct x86_ucode_id *x86_match_ucode(const struct x86_ucode_id > > *match) > > What's the point of returning the struct pointer? Shouldn't it be enough to > make it return bool? Also the function name really should reflect that this > checks whether

RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.

2018-10-19 Thread Jarkko Sakkinen
On Thu, 18 Oct 2018, Winkler, Tomas wrote: -Original Message- From: Jarkko Sakkinen [mailto:jarkko.sakki...@linux.intel.com] Sent: Thursday, October 18, 2018 03:15 To: Winkler, Tomas Cc: Jarkko Sakkinen ; Jason Gunthorpe ; Nayna Jain ; Usyskin, Alexander ; Struk, Tadeusz ; linux-integr..

Re: [PATCH] tpm: fix kdoc for tpm2_flush_context_cmd()

2018-10-19 Thread Jarkko Sakkinen
On Wed, 17 Oct 2018, Tomas Winkler wrote: kdoc for tpm2_flush_context_cmd() was off. Fixes: commit 9aa36b399a50 ("tpm: export tpm2_flush_context_cmd")' Shouldn't this be just Fixes: ? /Jarkko

Re: [PATCH] tpm: tpm_i2c_nuvoton: use correct command duration for TPM 2.x

2018-10-19 Thread Jarkko Sakkinen
On Wed, 17 Oct 2018, Tomas Winkler wrote: tpm_i2c_nuvoton calculated commands duration using TPM 1.x values via tpm_calc_ordinal_duration() also for TPM 2.x chips. Call tpm2_calc_ordinal_duration() for retrieving ordinal duration for TPM 2.X chips. Cc: Nayna Jain Signed-off-by: Tomas Winkler

Re: [PATCH] docs: Extend trusted keys documentation for TPM 2.0

2018-10-19 Thread Randy Dunlap
Hi, Feel free to ignore my comments. I don't know anything about TPM. On 10/19/18 3:17 AM, Stefan Berger wrote: > Extend the documentation for trusted keys with documentation for how to > set up a key for a TPM 2.0 so it can be used with a TPM 2.0 as well. > > Signed-off-by: Stefan Berger > Rev

Re: [PATCH] clk: fix clk_calc_subtree compute duplications

2018-10-19 Thread dbasehore .
On Fri, Aug 31, 2018 at 2:20 PM Derek Basehore wrote: > > clk_calc_subtree was called at every step up the clk tree in > clk_calc_new_rates. Since it recursively calls itself for its > children, this means it would be called once on each clk for each > step above the top clk is. > > This is fixed

Re: [PATCH] kernel/signal: Signal-based pre-coredump notification

2018-10-19 Thread Enke Chen
Hi, Jann: Regarding the security considerations, it seems simpler and more secure to just clear the "pre-coredump signal" cross execve(2), and let the new program decide for itself. What do you think? --- Changes to prctl(2): DESCRIPTION PR_SET_PREDUMP_SIG (since Linux 4.20.x)

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-19 Thread Roman Gushchin
On Fri, Oct 19, 2018 at 07:35:36PM +0200, Uladzislau Rezki (Sony) wrote: > Objective > - > Initiative of improving vmalloc allocator comes from getting many issues > related to allocation time, i.e. sometimes it is terribly slow. As a result > many workloads which are sensitive for long (mo

Re: TSC to Mono-raw Drift

2018-10-19 Thread John Stultz
On Fri, Oct 19, 2018 at 1:50 PM, Thomas Gleixner wrote: > John, > > On Fri, 19 Oct 2018, John Stultz wrote: >> On Fri, Oct 19, 2018 at 11:57 AM, Thomas Gleixner wrote: >> > I don't think you need complex oscillation for that. The error is constant >> > and small enough that it is a fractional nan

Re: [PATCH 03/34] teach move_mount(2) to work with OPEN_TREE_CLONE [ver #12]

2018-10-19 Thread David Howells
Alan Jenkins wrote: > # open_tree_clone 3 # cd /proc/self/fd/3 > # mount --move . /mnt > [ 41.747831] mnt_flags=1020 umount=0 > # cd / > # umount /mnt > umount: /mnt: target is busy > > ^ a newly introduced bug? I do not remember having this problem before. The reason EBUSY is returned is bec

Re: [driver-core PATCH v4 4/6] driver core: Probe devices asynchronously instead of the driver

2018-10-19 Thread Alexander Duyck
On Thu, 2018-10-18 at 19:31 -0700, Bart Van Assche wrote: > On 10/18/18 7:20 PM, Alexander Duyck wrote: > > I see what you are talking about now. Actually I think this was an > > existing issue before my patch even came into play. Basically the > > code > > as it currently stands is device specific

Re: [PATCH 4.4 00/48] 4.4.162-stable review

2018-10-19 Thread Shuah Khan
On 10/18/2018 11:54 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.162 release. > There are 48 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses s

Re: [PATCH v2 1/2] dt-bindings: serial: add documentation for the SiFive UART driver

2018-10-19 Thread Paul Walmsley
On 10/19/18 1:45 PM, Rob Herring wrote: On Fri, Oct 19, 2018 at 1:48 PM Paul Walmsley wrote: Add DT binding documentation for the Linux driver for the SiFive asynchronous serial IP block. Nothing too exotic. Cc: linux-ser...@vger.kernel.org Cc: devicet...@vger.kernel.org Cc: linux-ri...@lis

Re: [PATCH] reiserfs: remove workaround code for GCC 3.x

2018-10-19 Thread Jeff Mahoney
On 8/26/18 10:33 PM, Masahiro Yamada wrote: > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > bumped the minimum GCC version to 4.6 for all architectures. > > The workaround code in fs/reiserfs/Makefile is obsolete now. > > Signed-off-by: Masahiro Yamada Acked-by: Jeff M

[RFC][PATCH] tools/lib/traceevent: Implement libtraceevent man pages

2018-10-19 Thread Steven Rostedt
[ As we are working toward getting libtraceevent cleaned up enough to become a stand alone library, one of the requirements is to have a series of man pages on the API interface. Tzvetomir updated the tool/lib directory to be able to handle this. Sending this as RFC to see how everyon

Re: [PATCH 03/34] teach move_mount(2) to work with OPEN_TREE_CLONE [ver #12]

2018-10-19 Thread David Howells
Alan Jenkins wrote: > I guess this tries to fix the second of the two sequences I mentioned - > mount+unmount, then close the FD.  It doesn't seem to work. It fixes this: unshare --mount /root/test-fsmount mount --move . /mnt mount --move /mnt /mnt cd umount /mnt ex

Re: [PATCH v3] staging: nrf24: add new driver for 2.4GHz radio transceiver

2018-10-19 Thread Marcin Ciupak
On Fri, Oct 19, 2018 at 09:58:01AM +0300, Dan Carpenter wrote: > Hi Marcin, > > Thank you for the patch! Perhaps something to improve: > > url: > https://github.com/0day-ci/linux/commits/Marcin-Ciupak/staging-nrf24-add-new-driver-for-2-4GHz-radio-transceiver/20181018-164230 > > smatch warnin

Re: [PATCH 03/34] teach move_mount(2) to work with OPEN_TREE_CLONE [ver #12]

2018-10-19 Thread David Howells
Alan Jenkins wrote: > And the first sequence I mentioned - close the FD, then mount+unmount - > seems to be unchanged. Unchanged in what sense? Still breaks? I thought I'd fixed that - or are we talking about a different first sequence? Sorry, I'm losing track of how many different ways of b

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2018-10-19 Thread Moritz Fischer
Hi Nava, Looks good to me, a couple of nits inline below. On Fri, Oct 19, 2018 at 1:50 AM Nava kishore Manne wrote: > > This patch adds FPGA Manager support for the Xilinx > ZynqMp chip. Isn't it ZynqMP ? > > Signed-off-by: Nava kishore Manne > --- > Changes for v1: > -None. >

Re: [PATCH 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ Firmware bindings

2018-10-19 Thread Matthias Kaehlcke
On Thu, Oct 11, 2018 at 05:06:00PM +0530, Taniya Das wrote: > Add QCOM cpufreq firmware device bindings for Qualcomm Technology Inc's > SoCs. This is required for managing the cpu frequency transitions which are > controlled by the hardware engine. > > Signed-off-by: Taniya Das > --- > .../bindi

Re: [PATCH] thunderbolt: Fix a missing-check bug

2018-10-19 Thread Wenwen Wang
On Thu, Oct 18, 2018 at 4:13 AM Mika Westerberg wrote: > > Hi Wenwen, > > On Wed, Oct 17, 2018 at 09:00:29AM -0500, Wenwen Wang wrote: > > In tb_cfg_copy(), the header of the received control package, which is in > > the buffer 'pkg->buffer', is firstly parsed through parse_header() to make > > su

Re: [PATCH 4.9 00/35] 4.9.135-stable review

2018-10-19 Thread Shuah Khan
On 10/18/2018 11:54 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.135 release. > There are 35 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses s

[PATCH v3 3/3] bpf: Add system wide BPF JIT limit

2018-10-19 Thread Rick Edgecombe
In case of games played with multiple users, also add a system wide limit (in bytes) for BPF JIT. The default intends to be big enough for 1 BPF JIT filters. This cannot help with the DOS in the case of CONFIG_BPF_JIT_ALWAYS_ON, but it can help with DOS for module space and with forcing a modul

[PATCH v3 2/3] modules: Create rlimit for module space

2018-10-19 Thread Rick Edgecombe
This introduces a new rlimit, RLIMIT_MODSPACE, which limits the amount of module space a user can use. The intention is to be able to limit module space allocations that may come from un-privlidged users inserting e/BPF filters. Since filters attached to sockets can be passed to other processes vi

Re: TSC to Mono-raw Drift

2018-10-19 Thread Thomas Gleixner
John, On Fri, 19 Oct 2018, John Stultz wrote: > On Fri, Oct 19, 2018 at 11:57 AM, Thomas Gleixner wrote: > > I don't think you need complex oscillation for that. The error is constant > > and small enough that it is a fractional nanoseconds thing with an interval > > <= 1s. So you can just add th

[PATCH RFC v3 0/3] Rlimit for module space

2018-10-19 Thread Rick Edgecombe
If BPF JIT is on, there is no effective limit to prevent filling the entire module space with JITed e/BPF filters. For classic BPF filters attached with setsockopt SO_ATTACH_FILTER, there is no memlock rlimit check to limit the number of insertions like there is for the bpf syscall. This patch add

[PATCH v3 1/3] modules: Create arch versions of module alloc/free

2018-10-19 Thread Rick Edgecombe
In prep for module space rlimit, create a singular cross platform module_alloc and module_memfree that call into arch specific implementations. This has only been tested on x86. Signed-off-by: Rick Edgecombe --- arch/arm/kernel/module.c | 2 +- arch/arm64/kernel/module.c | 2 +- arc

Re: INFO: rcu detected stall in do_idle

2018-10-19 Thread luca abeni
On Fri, 19 Oct 2018 13:39:42 +0200 Peter Zijlstra wrote: > On Thu, Oct 18, 2018 at 01:08:11PM +0200, luca abeni wrote: > > Ok, I see the issue now: the problem is that the "while > > (dl_se->runtime <= 0)" loop is executed at replenishment time, but > > the deadline should be postponed at enforce

Re: [PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask

2018-10-19 Thread Miklos Szeredi
On Fri, Oct 19, 2018 at 8:14 PM, Trond Myklebust wrote: > On Fri, 2018-10-19 at 19:46 +0200, Miklos Szeredi wrote: >> How is it then that only STATX_ATIME is cleared and not the other >> fields? > > It isn't just the atime. We can also fail to revalidate the ctime and > mtime if they are not bein

Re: [PATCH 4.4 00/48] 4.4.162-stable review

2018-10-19 Thread Shuah Khan
On 10/18/2018 11:54 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.162 release. > There are 48 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses s

Re: [PATCH 4.9 00/35] 4.9.135-stable review

2018-10-19 Thread Shuah Khan
On 10/18/2018 11:54 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.135 release. > There are 35 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses s

Re: [PATCH v2 1/2] dt-bindings: serial: add documentation for the SiFive UART driver

2018-10-19 Thread Rob Herring
On Fri, Oct 19, 2018 at 1:48 PM Paul Walmsley wrote: > > Add DT binding documentation for the Linux driver for the SiFive > asynchronous serial IP block. Nothing too exotic. > > Cc: linux-ser...@vger.kernel.org > Cc: devicet...@vger.kernel.org > Cc: linux-ri...@lists.infradead.org > Cc: linux-ker

Re: [PATCH 4.14 00/41] 4.14.78-stable review

2018-10-19 Thread Shuah Khan
On 10/18/2018 11:54 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.78 release. > There are 41 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses s

[PATCH v2] rtc: s35390a: Change buf's type to u8 in s35390a_init

2018-10-19 Thread Nathan Chancellor
Clang warns: drivers/rtc/rtc-s35390a.c:124:27: warning: implicit conversion from 'int' to 'char' changes value from 192 to -64 [-Wconstant-conversion] buf = S35390A_FLAG_RESET | S35390A_FLAG_24H; ~ ~~~^~ 1 warning generated. Update buf to be an

Re: [PATCH 4.18 00/53] 4.18.16-stable review

2018-10-19 Thread Shuah Khan
On 10/18/2018 11:53 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.18.16 release. > There are 53 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses s

RE: [tip:irq/core] genirq: Fix race on spurious interrupt detection

2018-10-19 Thread Thomas Gleixner
David, On Fri, 19 Oct 2018, Thomas Gleixner wrote: > On Fri, 19 Oct 2018, David Laight wrote: > > From: Lukas Wunner > > > Sent: 19 October 2018 16:34 > > > > > > genirq: Fix race on spurious interrupt detection > > > > > > Commit 1e77d0a1ed74 ("genirq: Sanitize spurious interrupt detection of >

  1   2   3   4   5   >