Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-21 Thread Sai Prakash Ranjan
On 9/19/2018 2:43 AM, Sai Prakash Ranjan wrote: On 9/19/2018 2:14 AM, Steven Rostedt wrote: On Tue, 18 Sep 2018 23:22:48 +0530 Sai Prakash Ranjan wrote: On 9/18/2018 5:04 AM, Steven Rostedt wrote: It looks like pstore_event_call() gets called from a trace event. You can't call kmalloc() fro

Job Application

2018-09-21 Thread Kelvin Quarterman  
How's it going? My name is Kelvin and I'm interested in a job. I've attached a copy of my resume. The password is "1234" Looking forward to hearing back from you! Kelvin <>

Re: [PATCH 3.16 52/63] xfs: validate cached inodes are free when allocated

2018-09-21 Thread Dave Chinner
On Sat, Sep 22, 2018 at 01:15:42AM +0100, Ben Hutchings wrote: > 3.16.58-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Dave Chinner > > commit afca6c5b2595fc44383919fba740c194b0b76aff upstream. > > A recent fuzzed filesystem image cached

Re: [PATCH 3.16 51/63] xfs: catch inode allocation state mismatch corruption

2018-09-21 Thread Dave Chinner
On Sat, Sep 22, 2018 at 01:15:42AM +0100, Ben Hutchings wrote: > 3.16.58-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Dave Chinner > > commit ee457001ed6c6f31ddad69c24c1da8f377d8472d upstream. > > We recently came across a V4 filesystem

Re: Grant

2018-09-21 Thread M. M. Fridman
-- I, Mikhail Fridman have selected you specifically as one of my beneficiaries for my Charitable Donation of $5 Million Dollars, Check the link below for confirmation: https://www.rt.com/business/343781-mikhail-fridman-will-charity/ I await your earliest response for further directives.

Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-21 Thread Stefan Metzmacher
Hi, >> +    req->Channel = SMB2_CHANNEL_RDMA_V1_INVALIDATE; >> +    if (need_invalidate) >> +    req->Channel = SMB2_CHANNEL_RDMA_V1; >> +    req->ReadChannelInfoOffset = >> +    offsetof(struct smb2_read_plain_req, Buffer); >> +    req->ReadChannelInfoLength = >> +

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Baolin Wang
Hi, On 22 September 2018 at 06:18, Pavel Machek wrote: > On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: >> On 09/21/2018 11:17 PM, Pavel Machek wrote: >> > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: >> >> Hi Baolin, >> >> >> >> On 09/21/2018 05:31 AM, Baolin Wang wrote: >> >>> Hi Ja

Re: [PATCH] zram: fix missing zero pages for memory tracking

2018-09-21 Thread Minchan Kim
On Wed, Sep 19, 2018 at 04:29:16PM +0900, Sergey Senozhatsky wrote: > On (09/19/18 14:18), Minchan Kim wrote: > > We need to count zero filled pages as well as other pages in zram. > > A nit, > > 'ZRAM_FLAG_SHIFT + 1' covers all ZRAM_SAME pages, not only > zero filled pages. Ah, now I got

[PATCH] torture-test modules: Remove unnecessary "ret" variables

2018-09-21 Thread Pierce Griffiths
Remove return variables (declared as "ret") in cases where, depending on whether a condition evaluates as true, the result of a function call can be immediately returned instead of storing the result in the return variable. When the condition evaluates as false, the constant initially stored in the

[PATCH 3.16 16/63] KVM: x86: pass kvm_vcpu to kvm_read_guest_virt and kvm_write_guest_virt_system

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Paolo Bonzini commit ce14e868a54edeb2e30cb7a7b104a2fc4b9d76ca upstream. Int the next patch the emulator's .read_std and .write_std callbacks will grow another argument, which is not needed in

[PATCH 3.16 07/63] usbip: usbip_host: refine probe and disconnect debug msgs to be useful

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Shuah Khan commit 28b68acc4a88dcf91fd1dcf2577371dc9bf574cc upstream. Refine probe and disconnect debug msgs to be useful and say what is in progress. Signed-off-by: Shuah Khan Signed-off-by:

[PATCH 3.16 08/63] usbip: usbip_host: delete device from busid_table after rebind

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: "Shuah Khan (Samsung OSG)" commit 1e180f167d4e413afccbbb4a421b48b2de832549 upstream. Device is left in the busid_table after unbind and rebind. Rebind initiates usb bus scan and the original d

[PATCH 3.16 06/63] usbip: usbip_host: fix to hold parent lock for device_attach() calls

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Shuah Khan commit 4bfb141bc01312a817d36627cc47c93f801c216d upstream. usbip_host calls device_attach() without holding dev->parent lock. Fix it. Signed-off-by: Shuah Khan Signed-off-by: Greg

[PATCH 3.16 03/63] Revert "vti4: Don't override MTU passed on link creation via IFLA_MTU"

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Ben Hutchings This reverts commit 5a79e43ffa5014c020e0d0f4e383205f87b10111, which was commit 03080e5ec72740c1a62e6730f2a5f3f114f11b19 upstream, as it causes test failures. It should not have b

[PATCH 3.16 10/63] usbip: usbip_host: fix NULL-ptr deref and use-after-free errors

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: "Shuah Khan (Samsung OSG)" commit 22076557b07c12086eeb16b8ce2b0b735f7a27e7 upstream. usbip_host updates device status without holding lock from stub probe, disconnect and rebind code paths. Wh

[PATCH 3.16 18/63] sr: pass down correctly sized SCSI sense buffer

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Jens Axboe commit f7068114d45ec55996b9040e98111afa56e010fe upstream. We're casting the CDROM layer request_sense to the SCSI sense buffer, but the former is 64 bytes and the latter is 96 bytes

[PATCH 3.16 02/63] x86/fpu: Default eagerfpu if FPU and FXSR are enabled

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Ben Hutchings This is a limited version of commit 58122bf1d856 "x86/fpu: Default eagerfpu=on on all CPUs". That commit revealed bugs in the use of eagerfpu together with math emulation or with

[PATCH 3.16 09/63] usbip: usbip_host: run rebind from exit when module is removed

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: "Shuah Khan (Samsung OSG)" commit 7510df3f29d44685bab7b1918b61a8ccd57126a9 upstream. After removing usbip_host module, devices it releases are left without a driver. For example, when a keyboa

[PATCH 3.16 00/63] 3.16.58-rc1 review

2018-09-21 Thread Ben Hutchings
This is the start of the stable review cycle for the 3.16.58 release. There are 63 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Mon Sep 24 00:15:41 UTC 2018. Anything recei

[PATCH 3.16 11/63] usbip: usbip_host: fix bad unlock balance during stub_probe()

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: "Shuah Khan (Samsung OSG)" commit c171654caa875919be3c533d3518da8be5be966e upstream. stub_probe() calls put_busid_priv() in an error path when device isn't found in the busid_table. Fix it by

[PATCH 3.16 04/63] net: Set sk_prot_creator when cloning sockets to the right proto

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Christoph Paasch commit 9d538fa60bad4f7b23193c89e843797a1cf71ef3 upstream. sk->sk_prot and sk->sk_prot_creator can differ when the app uses IPV6_ADDRFORM (transforming an IPv6-socket to an IPv

[PATCH 3.16 17/63] kvm: x86: use correct privilege level for sgdt/sidt/fxsave/fxrstor access

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Paolo Bonzini commit 3c9fa24ca7c9c47605672916491f79e8ccacb9e6 upstream. The functions that were used in the emulation of fxrstor, fxsave, sgdt and sidt were originally meant for task switching

[PATCH 3.16 48/63] video: uvesafb: Fix integer overflow in allocation

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Kees Cook commit 9f645bcc566a1e9f921bdae7528a01ced5bc3713 upstream. cmap->len can get close to INT_MAX/2, allowing for an integer overflow in allocation. This uses kmalloc_array() instead to c

[PATCH 3.16 54/63] seccomp: create internal mode-setting function

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Kees Cook commit d78ab02c2c194257a03355fbb79eb721b381d105 upstream. In preparation for having other callers of the seccomp mode setting logic, split the prctl entry point away from the core lo

Re: Code of Conduct: Let's revamp it.

2018-09-21 Thread jonsm...@gmail.com
On Fri, Sep 21, 2018 at 8:05 PM Joey Pabalinas wrote: > > On Fri, Sep 21, 2018 at 07:31:05PM -0400, jonsm...@gmail.com wrote: > > On Fri, Sep 21, 2018 at 7:17 PM Theodore Y. Ts'o wrote: > > > > > > People can decide who they want to respond to, but I'm going to gently > > > suggest that before pe

[PATCH 3.16 61/63] x86/cpu/intel: Add Knights Mill to Intel family

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Piotr Luc commit 0047f59834e5947d45f34f5f12eb330d158f700b upstream. Add CPUID of Knights Mill (KNM) processor to Intel family list. Signed-off-by: Piotr Luc Reviewed-by: Dave Hansen Cc: And

[PATCH 3.16 56/63] seccomp: split mode setting routines

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Kees Cook commit 3b23dd12846215eff4afb073366b80c0c4d7543e upstream. Separates the two mode setting paths to make things more readable with fewer #ifdefs within function bodies. Signed-off-by:

[PATCH 3.16 14/63] KVM: x86: Emulator ignores LDTR/TR extended base on LLDT/LTR

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Nadav Amit commit e37a75a13cdae5deaa2ea2cbf8d55b5dd08638b6 upstream. The current implementation ignores the LDTR/TR base high 32-bits on long-mode. As a result the loaded segment descriptor ma

[PATCH 3.16 05/63] usbip: fix error handling in stub_probe()

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Alexey Khoroshilov commit 3ff67445750a84de67faaf52c6e1895cb09f2c56 upstream. If usb_hub_claim_port() fails, no resources are deallocated and if stub_add_files() fails, port is not released. T

[PATCH 3.16 12/63] futex: Remove requirement for lock_page() in get_futex_key()

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Mel Gorman commit 65d8fc777f6dcfee12785c057a6b57f679641c90 upstream. When dealing with key handling for shared futexes, we can drastically reduce the usage/need of the page lock. 1) For anonym

[PATCH 3.16 62/63] KVM: x86: introduce num_emulated_msrs

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Paolo Bonzini commit 62ef68bb4d00f1a662e487f3fc44ce8521c416aa upstream. We will want to filter away MSR_IA32_SMBASE from the emulated_msrs if the host CPU does not support SMM virtualization.

[PATCH 3.16 57/63] seccomp: add "seccomp" syscall

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Kees Cook commit 48dc92b9fc3926844257316e75ba11eb5c742b2c upstream. This adds the new "seccomp" syscall with both an "operation" and "flags" parameter for future expansion. The third argument

[PATCH 3.16 01/63] x86/fpu: Fix the 'nofxsr' boot parameter to also clear X86_FEATURE_FXSR_OPT

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Ingo Molnar commit d364a7656c1855c940dfa4baf4ebcc3c6a9e6fd2 upstream. I tried to simulate an ancient CPU via this option, and found that it still has fxsr_opt enabled, confusing the FPU code.

[PATCH 3.16 53/63] xfs: don't call xfs_da_shrink_inode with NULL bp

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Eric Sandeen commit bb3d48dcf86a97dc25fe9fc2c11938e19cb4399a upstream. xfs_attr3_leaf_create may have errored out before instantiating a buffer, for example if the blkno is out of range. In t

[PATCH 3.16 47/63] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Sanjeev Sharma commit ab945eff8396bc3329cc97274320e8d2c6585077 upstream. on some architecture spin_is_locked() always return false in uniprocessor configuration and therefore it would be advis

Re: [PATCH] libnvdimm: remove duplicate include

2018-09-21 Thread Dan Williams
On Wed, Sep 19, 2018 at 5:59 AM Pankaj Gupta wrote: > > Removed duplicate include. > > Signed-off-by: Pankaj Gupta > --- > drivers/nvdimm/nd-core.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/nvdimm/nd-core.h b/drivers/nvdimm/nd-core.h > index ac68072fb8cd..182258f64417 10064

[PATCH 3.16 13/63] futex: Remove unnecessary warning from get_futex_key

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Mel Gorman commit 48fb6f4db940e92cfb16cd878cddd59ea6120d06 upstream. Commit 65d8fc777f6d ("futex: Remove requirement for lock_page() in get_futex_key()") removed an unnecessary lock_page() wit

[PATCH 3.16 60/63] x86/cpu/AMD: Fix erratum 1076 (CPB bit)

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Borislav Petkov commit f7f3dc00f61261cdc9ccd8b886f21bc4dffd6fd9 upstream. CPUID Fn8000_0007_EDX[CPB] is wrongly 0 on models up to B1. But they do support CPB (AMD's Core Performance Boosting c

[PATCH 3.16 45/63] x86/paravirt: Fix spectre-v2 mitigations for paravirt guests

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Peter Zijlstra commit 5800dc5c19f34e6e03b5adab1282535cb102fafd upstream. Nadav reported that on guests we're failing to rewrite the indirect calls to CALLEE_SAVE paravirt functions. In particu

[PATCH v4 10/19] Smack: Abstract use of file security blob

2018-09-21 Thread Casey Schaufler
Don't use the file->f_security pointer directly. Provide a helper function that provides the security blob pointer. Signed-off-by: Casey Schaufler --- security/smack/smack.h | 5 + security/smack/smack_lsm.c | 12 2 files changed, 13 insertions(+), 4 deletions(-) diff --gi

[PATCH 3.16 52/63] xfs: validate cached inodes are free when allocated

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Dave Chinner commit afca6c5b2595fc44383919fba740c194b0b76aff upstream. A recent fuzzed filesystem image cached random dcache corruption when the reproducer was run. This often showed up as pan

[PATCH 3.16 63/63] mm: get rid of vmacache_flush_all() entirely

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Linus Torvalds commit 7a9cdebdcc17e426fb5287e4a82db1dfe86339b2 upstream. Jann Horn points out that the vmacache_flush_all() function is not only potentially expensive, it's buggy too. It also

[PATCH 3.16 51/63] xfs: catch inode allocation state mismatch corruption

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Dave Chinner commit ee457001ed6c6f31ddad69c24c1da8f377d8472d upstream. We recently came across a V4 filesystem causing memory corruption due to a newly allocated inode being setup twice and be

[PATCH 3.16 49/63] btrfs: relocation: Only remove reloc rb_trees if reloc control has been initialized

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Qu Wenruo commit 389305b2aa68723c754f88d9dbd268a400e10664 upstream. Invalid reloc tree can cause kernel NULL pointer dereference when btrfs does some cleanup of the reloc roots. It turns out

[PATCH 3.16 50/63] hfsplus: fix NULL dereference in hfsplus_lookup()

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Ernesto A. Fernández commit a7ec7a4193a2eb3b5341243fc0b621c1ac9e4ec4 upstream. An HFS+ filesystem can be mounted read-only without having a metadata directory, which is needed to support hard

[PATCH 3.16 59/63] x86/process: Correct and optimize TIF_BLOCKSTEP switch

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Kyle Huey commit b9894a2f5bd18b1691cb6872c9afe32b148d0132 upstream. The debug control MSR is "highly magical" as the blockstep bit can be cleared by hardware under not well documented circumst

[PATCH 3.16 37/63] ext4: avoid running out of journal credits when appending to an inline file

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit 8bc1379b82b8e809eef77a9fedbb75c6c297be19 upstream. Use a separate journal transaction if it turns out that we need to convert an inline file to use an data block. Otherwi

[PATCH 3.16 55/63] seccomp: extract check/assign mode helpers

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Kees Cook commit 1f41b450416e689b9b7c8bfb750a98604f687a9b upstream. To support splitting mode 1 from mode 2, extract the mode checking and assignment logic into common functions. Signed-off-b

[PATCH v4 13/19] Smack: Abstract use of inode security blob

2018-09-21 Thread Casey Schaufler
Don't use the inode->i_security pointer directly. Provide a helper function that provides the security blob pointer. Signed-off-by: Casey Schaufler Reviewed-by: Kees Cook --- security/smack/smack.h | 9 +++-- security/smack/smack_lsm.c | 32 2 files cha

[PATCH v4 09/19] SELinux: Abstract use of file security blob

2018-09-21 Thread Casey Schaufler
Don't use the file->f_security pointer directly. Provide a helper function that provides the security blob pointer. Signed-off-by: Casey Schaufler Reviewed-by: Kees Cook --- security/selinux/hooks.c | 18 +- security/selinux/include/objsec.h | 5 + 2 files changed,

[PATCH v4 09/19] SELinux: Abstract use of file security blob

2018-09-21 Thread Casey Schaufler
Don't use the file->f_security pointer directly. Provide a helper function that provides the security blob pointer. Signed-off-by: Casey Schaufler Reviewed-by: Kees Cook --- security/selinux/hooks.c | 18 +- security/selinux/include/objsec.h | 5 + 2 files changed,

[PATCH 3.16 36/63] jbd2: don't mark block as modified if the handle is out of credits

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit e09463f220ca9a1a1ecfda84fcda658f99a1f12a upstream. Do not set the b_modified flag in block's journal head should not until after we're sure that jbd2_journal_dirty_metadat

[PATCH 3.16 58/63] x86/process: Optimize TIF checks in __switch_to_xtra()

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Kyle Huey commit af8b3cd3934ec60f4c2a420d19a9d416554f140b upstream. Help the compiler to avoid reevaluating the thread flags for each checked bit by reordering the bit checks and providing an

[PATCH 3.16 15/63] KVM: x86: introduce linear_{read,write}_system

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Paolo Bonzini commit 79367a65743975e5cac8d24d08eccc7fdae832b0 upstream. Wrap the common invocation of ctxt->ops->read_std and ctxt->ops->write_std, so as to have a smaller patch when the funct

[PATCH 3.16 43/63] x86/speculation: Clean up various Spectre related details

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Ingo Molnar commit 21e433bdb95bdf3aa48226fd3d33af608437f293 upstream. Harmonize all the Spectre messages so that a: dmesg | grep -i spectre ... gives us most Spectre related kernel boot

[PATCH 3.16 46/63] cdrom: Fix info leak/OOB read in cdrom_ioctl_drive_status

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Scott Bauer commit 8f3fafc9c2f0ece10832c25f7ffcb07c97a32ad4 upstream. Like d88b6d04: "cdrom: information leak in cdrom_ioctl_media_changed()" There is another cast from unsigned long to int w

[PATCH 3.16 44/63] x86/speculation: Protect against userspace-userspace spectreRSB

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Jiri Kosina commit fdf82a7856b32d905c39afc85e34364491e46346 upstream. The article "Spectre Returns! Speculation Attacks using the Return Stack Buffer" [1] describes two new (sub-)variants of s

[PATCH 3.16 33/63] ext4: never move the system.data xattr out of the inode body

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit 8cdb5240ec5928b20490a2bb34cb87e9a5f40226 upstream. When expanding the extra isize space, we must never move the system.data xattr out of the inode body. For performance r

[PATCH 3.16 41/63] USB: yurex: fix out-of-bounds uaccess in read handler

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Jann Horn commit f1e255d60ae66a9f672ff9a207ee6cd8e33d2679 upstream. In general, accessing userspace memory beyond the length of the supplied buffer in VFS read/write handlers can lead to both

[PATCH 3.16 29/63] ext4: make sure bitmaps and the inode table don't overlap with bg descriptors

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit 77260807d1170a8cf35dbb06e07461a655f67eee upstream. It's really bad when the allocation bitmaps and the inode table overlap with the block group descriptors, since it cause

[PATCH 3.16 30/63] ext4: fix false negatives *and* false positives in ext4_check_descriptors()

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit 44de022c4382541cebdd6de4465d1f4f465ff1dd upstream. Ext4_check_descriptors() was getting called before s_gdb_count was initialized. So for file systems w/o the meta_bg fea

Re: [PATCH] watchdog/hpwdt: Disable PreTimeout when Timeout is smaller

2018-09-21 Thread Guenter Roeck
On 09/21/2018 01:50 PM, Jerry Hoemann wrote: During module install, disable pretimeout if the requested timeout value is not greater than the minimal pretimeout value that is supported by hardware. This makes the module load handling of pretimeout consistent with the ioctl handling of pretimeout

[PATCH v4 11/19] LSM: Infrastructure management of the file security

2018-09-21 Thread Casey Schaufler
Move management of the file->f_security blob out of the individual security modules and into the infrastructure. The modules no longer allocate or free the data, instead they tell the infrastructure how much space they require. Signed-off-by: Casey Schaufler --- include/linux/lsm_hooks.h | 1 +

[PATCH v4 12/19] SELinux: Abstract use of inode security blob

2018-09-21 Thread Casey Schaufler
Don't use the inode->i_security pointer directly. Provide a helper function that provides the security blob pointer. Signed-off-by: Casey Schaufler Reviewed-by: Kees Cook --- security/selinux/hooks.c | 26 +- security/selinux/include/objsec.h | 6 ++ securi

[PATCH 3.16 28/63] ext4: don't allow r/w mounts if metadata blocks overlap the superblock

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit 18db4b4e6fc31eda838dd1c1296d67dbcb3dc957 upstream. If some metadata block, such as an allocation bitmap, overlaps the superblock, it's very likely that if the file system

[PATCH 3.16 27/63] ext4: always check block group bounds in ext4_init_block_bitmap()

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit 819b23f1c501b17b9694325471789e6b5cc2d0d2 upstream. Regardless of whether the flex_bg feature is set, we should always check to make sure the bits we are setting in the blo

[PATCH v4 19/19] LSM: Blob sharing support for S.A.R.A and LandLock

2018-09-21 Thread Casey Schaufler
Two proposed security modules require the ability to share security blobs with existing "major" security modules. These modules, S.A.R.A and LandLock, provide significantly different services than SELinux, Smack or AppArmor. Using either in conjunction with the existing modules is quite reasonable.

[PATCH 3.16 35/63] ext4: add more inode number paranoia checks

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit c37e9e013469521d9adb932d17a1795c139b36db upstream. If there is a directory entry pointing to a system inode (such as a journal inode), complain and declare the file system

[PATCH 3.16 39/63] x86/entry/64: Remove %ebx handling from error_entry/exit

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Andy Lutomirski commit b3681dd548d06deb2e1573890829dff4b15abf46 upstream. error_entry and error_exit communicate the user vs. kernel status of the frame using %ebx. This is unnecessary -- the

[PATCH 3.16 34/63] ext4: clear i_data in ext4_inode_info when removing inline data

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit 6e8ab72a812396996035a37e5ca4b3b99b5d214b upstream. When converting from an inode from storing the data in-line to a data block, ext4_destroy_inline_data_nolock() was only

[PATCH 3.16 32/63] ext4: always verify the magic number in xattr blocks

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit 513f86d73855ce556ea9522b6bfd79f87356dc3a upstream. If there an inode points to a block which is also some other type of metadata block (such as a block allocation bitmap),

[PATCH 3.16 38/63] Fix up non-directory creation in SGID directories

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Linus Torvalds commit 0fa3ecd87848c9c93c2c828ef4c3a8ca36ce46c7 upstream. sgid directories have special semantics, making newly created files in the directory belong to the group of the directo

[PATCH 3.16 23/63] xfs: set format back to extents if xfs_bmap_extents_to_btree

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Eric Sandeen commit 2c4306f719b083d17df2963bc761777576b8ad1b upstream. If xfs_bmap_extents_to_btree fails in a mode where we call xfs_iroot_realloc(-1) to de-allocate the root, set the format

[PATCH 3.16 26/63] ext4: verify the depth of extent tree in ext4_find_extent()

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit bc890a60247171294acc0bd67d211fa4b88d40ba upstream. If there is a corupted file system where the claimed depth of the extent tree is -1, this can cause a massive buffer ove

[PATCH 3.16 31/63] ext4: add corruption check in ext4_xattr_set_entry()

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit 5369a762c882c0b6e9599e4ebbb3a9ba9eee7e2d upstream. In theory this should have been caught earlier when the xattr list was verified, but in case it got missed, it's simple

[PATCH 3.16 42/63] ALSA: rawmidi: Change resized buffers atomically

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Takashi Iwai commit 39675f7a7c7e7702f7d5341f1e0d01db746543a0 upstream. The SNDRV_RAWMIDI_IOCTL_PARAMS ioctl may resize the buffers and the current code is racy. For example, the sequencer cli

[PATCH 3.16 40/63] infiniband: fix a possible use-after-free bug

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Cong Wang commit cb2595c1393b4a5211534e6f0a0fbad369e21ad8 upstream. ucma_process_join() will free the new allocated "mc" struct, if there is any error after that, especially the copy_to_user()

[PATCH 3.16 19/63] jfs: Fix inconsistency between memory allocation and ea_buf->max_size

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Shankara Pailoor commit 92d34134193e5b129dc24f8d79cb9196626e8d7a upstream. The code is assuming the buffer is max_size length, but we weren't allocating enough space for it. Signed-off-by: Sh

[PATCH 3.16 24/63] ext4: only look at the bg_flags field if it is valid

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit 8844618d8aa7a9973e7b527d038a2a589665002c upstream. The bg_flags field in the block group descripts is only valid if the uninit_bg or metadata_csum feature is enabled. We

[PATCH 3.16 20/63] scsi: sg: allocate with __GFP_ZERO in sg_build_indirect()

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Alexander Potapenko commit a45b599ad808c3c982fdcdc12b0b8611c2f92824 upstream. This shall help avoid copying uninitialized memory to the userspace when calling ioctl(fd, SG_IO) with an empty co

[PATCH 3.16 25/63] ext4: fix check to prevent initializing reserved inodes

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Theodore Ts'o commit 5012284700775a4e6e3fbe7eac4c543c4874b559 upstream. Commit 8844618d8aa7: "ext4: only look at the bg_flags field if it is valid" will complain if block group zero does not h

[PATCH 3.16 22/63] scsi: libsas: defer ata device eh commands to libata

2018-09-21 Thread Ben Hutchings
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Jason Yan commit 318aaf34f1179b39fa9c30fa0f3288b645beee39 upstream. When ata device doing EH, some commands still attached with tasks are not passed to libata when abort failed or recover fail

[PATCH v4 15/19] LSM: Infrastructure management of the task security

2018-09-21 Thread Casey Schaufler
Move management of the task_struct->security blob out of the individual security modules and into the security infrastructure. Instead of allocating the blobs from within the modules the modules tell the infrastructure how much space is required, and the space is allocated there. The only user of t

Re: [PATCH 3.16 20/63] scsi: sg: allocate with __GFP_ZERO in sg_build_indirect()

2018-09-21 Thread syzbot
3.16.58-rc1 review patch. If anyone has any objections, please let me know. -- From: Alexander Potapenko commit a45b599ad808c3c982fdcdc12b0b8611c2f92824 upstream. This shall help avoid copying uninitialized memory to the userspace when calling ioctl(fd, SG_IO) with a

[PATCH v4 16/19] SELinux: Abstract use of ipc security blobs

2018-09-21 Thread Casey Schaufler
Don't use the ipc->security pointer directly. Don't use the msg_msg->security pointer directly. Provide helper functions that provides the security blob pointers. Signed-off-by: Casey Schaufler --- security/selinux/hooks.c | 18 +- security/selinux/include/objsec.h | 13

[PATCH v4 02/19] Smack: Abstract use of cred security blob

2018-09-21 Thread Casey Schaufler
Don't use the cred->security pointer directly. Provide a helper function that provides the security blob pointer. Signed-off-by: Casey Schaufler --- security/smack/smack.h| 17 +-- security/smack/smack_access.c | 4 +-- security/smack/smack_lsm.c| 57 +---

Re: [PATCH 0/3] mm: Randomize free memory

2018-09-21 Thread Dan Williams
On Fri, Sep 21, 2018 at 4:51 PM Elliott, Robert (Persistent Memory) wrote: > > > > -Original Message- > > From: linux-kernel-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Kees Cook > > Sent: Friday, September 21, 2018 2:13 PM > > Subject: Re: [PATCH 0/3] mm: Randomize free m

Re: Code of Conduct: Let's revamp it.

2018-09-21 Thread Joey Pabalinas
On Fri, Sep 21, 2018 at 07:31:05PM -0400, jonsm...@gmail.com wrote: > On Fri, Sep 21, 2018 at 7:17 PM Theodore Y. Ts'o wrote: > > > > People can decide who they want to respond to, but I'm going to gently > > suggest that before people think about responding to a particular > > e-mail, that they d

Re: [PATCH resend] uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name

2018-09-21 Thread David Howells
Andrew Morton wrote: > Are there such programs? Do they reference the `private' field? They would use the keyutils.h header from keyutils package probably. There the field was named "priv" not "private". The kernel's UAPI header should be amended again to match that. David

Re: Code of Conduct: Let's revamp it.

2018-09-21 Thread Bernd Petrovitsch
On 22/09/2018 01:31, jonsm...@gmail.com wrote: [...] > How does this part apply to email addresses used to commit code? > > * Publishing others’ private information, such as a physical or electronic > address, without explicit permission I need an (explicit) permission to "publish" an already pub

Re: [PATCH V4 00/27] C-SKY(csky) Linux Kernel Port

2018-09-21 Thread Guo Ren
On Thu, Sep 20, 2018 at 10:18:51PM -0700, Arnd Bergmann wrote: > On Thu, Sep 20, 2018 at 10:52 AM Palmer Dabbelt wrote: > > > > On Fri, 14 Sep 2018 07:37:20 PDT (-0700), ren_...@c-sky.com wrote: > > > On Wed, Sep 12, 2018 at 04:30:36PM +0200, Arnd Bergmann wrote: > > >> On Wed, Sep 12, 2018 at 3:2

RE: [PATCH 0/3] mm: Randomize free memory

2018-09-21 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Kees Cook > Sent: Friday, September 21, 2018 2:13 PM > Subject: Re: [PATCH 0/3] mm: Randomize free memory ... > I'd be curious to hear more about the mentioned cache performance > improveme

Re: [PATCH] selftests: watchdog: Add gettimeout and get|set pretimeout

2018-09-21 Thread Shuah Khan
Hi Jerry, Thanks for the patch. A few comments below: On 09/21/2018 04:55 PM, Jerry Hoemann wrote: > Add command line arguments to call ioctl WDIOC_GETTIMEOUT, > WDIOC_GETPRETIMEOUT and WDIOC_SETPRETIMEOUT. > > Signed-off-by: Jerry Hoemann > --- > tools/testing/selftests/watchdog/watchdog-test

Re: [PATCH v10 24/26] KVM: s390: device attrs to enable/disable AP interpretation

2018-09-21 Thread Tony Krowiak
On 09/17/2018 04:51 AM, David Hildenbrand wrote: Am 12.09.18 um 21:43 schrieb Tony Krowiak: From: Tony Krowiak Introduces two new VM crypto device attributes (KVM_S390_VM_CRYPTO) to enable or disable AP instruction interpretation from userspace via the KVM_SET_DEVICE_ATTR ioctl: * The KVM_S39

Re: [PATCH v2] slub: extend slub debug to handle multiple slabs

2018-09-21 Thread Andrew Morton
On Thu, 20 Sep 2018 21:00:16 +0100 Aaron Tomlin wrote: > Extend the slub_debug syntax to "slub_debug=[,]*", where > may contain an asterisk at the end. For example, the following would poison > all kmalloc slabs: > > slub_debug=P,kmalloc* > > and the following would apply the default fl

Re: [RFC/PATCH 2/5] device property: introduce notion of subnodes for legacy boards

2018-09-21 Thread Dmitry Torokhov
On Thu, Sep 20, 2018 at 01:16:48PM +0300, Heikki Krogerus wrote: > On Wed, Sep 19, 2018 at 10:13:26AM -0700, Dmitry Torokhov wrote: > > > > diff --git a/drivers/base/pset_property.c b/drivers/base/pset_property.c > > > > index 08ecc13080ae..63f2377aefe8 100644 > > > > --- a/drivers/base/pset_proper

Re: [RFC/PATCH 2/5] device property: introduce notion of subnodes for legacy boards

2018-09-21 Thread Dmitry Torokhov
Hi Heikki, On Thu, Sep 20, 2018 at 04:53:48PM +0300, Heikki Krogerus wrote: > Hi Dmitry, > > On Mon, Sep 17, 2018 at 11:16:00AM -0700, Dmitry Torokhov wrote: > > +/** > > + * device_add_child_properties - Add a collection of properties to a > > device object. > > + * @dev: Device to add properti

Re: [PATCH v10 25/26] KVM: s390: CPU model support for AP virtualization

2018-09-21 Thread Tony Krowiak
On 09/12/2018 03:43 PM, Tony Krowiak wrote: From: Tony Krowiak Introduces a new CPU model feature and two CPU model facilities to support AP virtualization for KVM guests. CPU model feature: The KVM_S390_VM_CPU_FEAT_AP feature indicates that AP instructions are available on the guest. This fe

Re: Code of Conduct: Let's revamp it.

2018-09-21 Thread jonsm...@gmail.com
On Fri, Sep 21, 2018 at 7:17 PM Theodore Y. Ts'o wrote: > > People can decide who they want to respond to, but I'm going to gently > suggest that before people think about responding to a particular > e-mail, that they do a quick check using "git log --author=xy...@example.com" > then decide how m

[PATCH v4] i2c: aspeed: fix invalid clock parameters for very large divisors

2018-09-21 Thread Brendan Higgins
The function that computes clock parameters from divisors did not respect the maximum size of the bitfields that the parameters were written to. This fixes the bug. This bug can be reproduced with (and this fix verified with) the test at: https://kunit-review.googlesource.com/c/linux/+/1035/ Disc

  1   2   3   4   5   6   7   >