RE: [PATCH] ARM: dts: imx6ull: correct machine model name

2018-08-22 Thread Anson Huang
Hi, Sacha Anson Huang Best Regards! > -Original Message- > From: Sascha Hauer > Sent: Thursday, August 23, 2018 2:57 PM > To: Anson Huang > Cc: shawn...@kernel.org; ker...@pengutronix.de; Fabio Estevam > ; robh...@kernel.org; mark.rutl...@arm.com; > linux-arm-ker...@lists.infradead.org

Re: [PATCH] ARM: dts: imx6ull: correct machine model name

2018-08-22 Thread Sascha Hauer
Hi Anson, The board name should be in the subject to let the reader know this is no generic i.MX6ull change. Sascha On Thu, Aug 23, 2018 at 02:30:49PM +0800, Anson Huang wrote: > i.MX6ULL is a lite version of i.MX6UL, its full name > is i.MX6 UltraLiteLite, NOT UlltraLite. > > Signed-off-by: An

Re: [PATCH v2 4/5] KVM: s390: vsie: Always test the crycbd for NULL

2018-08-22 Thread Pierre Morel
On 22/08/2018 19:07, David Hildenbrand wrote: On 22.08.2018 18:51, Pierre Morel wrote: BUG: the crycbd must be tested for null even if not crossing a page boundary (which will never occur in this case anyway). I don't see the BUG. Can you elaborate? (maybe it is too late for me) No it was to

RE: [PATCH] ARM: dts: imx6ull: correct machine model name

2018-08-22 Thread Anson Huang
Hi, Stefan Anson Huang Best Regards! > -Original Message- > From: Stefan Wahren > Sent: Thursday, August 23, 2018 2:53 PM > To: Anson Huang ; shawn...@kernel.org; > s.ha...@pengutronix.de; ker...@pengutronix.de; Fabio Estevam > ; robh...@kernel.org; mark.rutl...@arm.com; > linux-arm-ker

Re: [PATCH] ARM: dts: imx6ull: correct machine model name

2018-08-22 Thread Stefan Wahren
Hi Anson, Am 23.08.2018 um 08:30 schrieb Anson Huang: > i.MX6ULL is a lite version of i.MX6UL, its full name > is i.MX6 UltraLiteLite, NOT UlltraLite. > > Signed-off-by: Anson Huang > --- > arch/arm/boot/dts/imx6ull-14x14-evk.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH v2 3/5] KVM: s390: vsie: Allow support for a host without AP

2018-08-22 Thread Pierre Morel
On 22/08/2018 19:06, David Hildenbrand wrote: On 22.08.2018 18:51, Pierre Morel wrote: Currently the CRYCB format used in the host for the shadowed CRYCB is FORMAT2 while no check is done if AP instructions are supported in the host. We better use the format the host calculated for the guest 1

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-22 Thread Martin Schwidefsky
On Wed, 22 Aug 2018 22:20:32 -0700 Linus Torvalds wrote: > On Wed, Aug 22, 2018 at 10:11 PM Linus Torvalds > wrote: > > > > So instead, when you get to the actual "tlb_flush(tlb)", you do > > exactly that - flush the tlb. And the mmu_gather structure shows you > > how much you need to flush. If

Re: v4.19-rc0: compile problem in ./include/media/cec.h:82:24:

2018-08-22 Thread Hans Verkuil
On 22/08/18 23:12, Pavel Machek wrote: > Hi! > >> I'm getting this in -rc0: >> >> CC drivers/gpu/drm/ttm/ttm_tt.o >> In file included from ./include/media/cec-notifier.h:13:0, >>from drivers/gpu/drm/i915/intel_drv.h:42, >> from >> dri

Re: [PATCH 1/1] drm/ttm: Set memory as decrypted for ttm framebuffer mappings

2018-08-22 Thread Christian König
Am 22.08.2018 um 22:57 schrieb Jiandi An: On 08/22/2018 02:09 PM, Christian König wrote: Am 22.08.2018 um 20:57 schrieb Jiandi An: Framebuffer memory needs to be accessed decrypted.  Ensure the memory encryption mask is not set for the ttm framebuffer mappings. NAK, the memory not only needs

Re: [PATCH i2c-next v4] i2c: aspeed: Handle master/slave combined irq events properly

2018-08-22 Thread Brendan Higgins
On Mon, Aug 20, 2018 at 1:16 PM Jae Hyun Yoo wrote: > > In most of cases, interrupt bits are set one by one but there are > also a lot of other cases that Aspeed I2C IP sends multiple > interrupt bits with combining master and slave events using a > single interrupt call. It happens much more in m

Re: [PATCH v2 3/5] KVM: s390: vsie: Allow support for a host without AP

2018-08-22 Thread Pierre Morel
On 22/08/2018 19:06, David Hildenbrand wrote: On 22.08.2018 18:51, Pierre Morel wrote: Currently the CRYCB format used in the host for the shadowed CRYCB is FORMAT2 while no check is done if AP instructions are supported in the host. We better use the format the host calculated for the guest 1

Re: [PATCH v2 1/5] KVM: s390: vsie: BUG correction by shadow_crycb

2018-08-22 Thread Pierre Morel
On 22/08/2018 18:53, David Hildenbrand wrote: On 22.08.2018 18:51, Pierre Morel wrote: Copy the key mask to the right offset inside the shadow CRYCB Signed-off-by: Pierre Morel Reviewed-by: David Hildenbrand --- arch/s390/kvm/vsie.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH] ARM: dts: imx6ull: correct machine model name

2018-08-22 Thread Anson Huang
i.MX6ULL is a lite version of i.MX6UL, its full name is i.MX6 UltraLiteLite, NOT UlltraLite. Signed-off-by: Anson Huang --- arch/arm/boot/dts/imx6ull-14x14-evk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6ull-14x14-evk.dts b/arch/arm/boot/dts/imx

[char-misc for 4.19] mei: fix use-after-free in mei_cl_write

2018-08-22 Thread Tomas Winkler
From: John Hubbard KASAN reports a use-after-free during startup, in mei_cl_write: BUG: KASAN: use-after-free in mei_cl_write+0x601/0x870 [mei] (drivers/misc/mei/client.c:1770) This is caused by commit 98e70866aacb ("mei: add support for variable length mei headers."), which changed

Re: [RDMA bug] KASAN: use-after-free Read in __list_del_entry_valid (4)

2018-08-22 Thread Eric Biggers
Hello RDMA / InfiniBand maintainers, This is an RDMA bug and it still occurs on Linus' tree as of today (commit 815f0ddb346c1960). I've also simplified the reproducer for it; see below after the original report. Apparently it involves a race between RDMA_USER_CM_CMD_RESOLVE_IP and RDMA_USER_CM_CM

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-22 Thread Nicholas Piggin
On Thu, 23 Aug 2018 15:21:30 +1000 Benjamin Herrenschmidt wrote: > On Wed, 2018-08-22 at 22:11 -0700, Linus Torvalds wrote: > > On Wed, Aug 22, 2018 at 9:54 PM Benjamin Herrenschmidt > > wrote: > > > > > > > > > So we do need a different flush instruction for the page tables vs. the > > > n

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-22 Thread Nicholas Piggin
On Wed, 22 Aug 2018 22:03:40 -0700 Linus Torvalds wrote: > On Wed, Aug 22, 2018 at 9:33 PM Nicholas Piggin wrote: > > > > I think it was quite well understood and fixed here, a145abf12c9 but > > again that was before I really started looking at it. > > You don't understand the problem. More

Re: [PATCH 1/2] dt-bindings: dmaengine: add DT binding for UniPhier MIO DMAC

2018-08-22 Thread Jassi Brar
On 23 August 2018 at 10:48, Masahiro Yamada wrote: > Hi Jassi, > > > 2018-08-21 19:44 GMT+09:00 Jassi Brar : >> On 21 August 2018 at 15:17, Masahiro Yamada >> wrote: >>> (+CC Rob, DT, LKML) >>> >>> I forgot to CC this to DT community... >>> >>> >>> 2018-08-21 18:30 GMT+09:00 Masahiro Yamada : >>>

Re: KASAN: null-ptr-deref Write in binder_update_page_range

2018-08-22 Thread Minchan Kim
Hi, On Wed, Aug 22, 2018 at 03:07:04PM +0900, Dae R. Jeong wrote: > Reporting the crash: KASAN: null-ptr-deref Write in binder_update_page_range > > This crash has been found in v4.18-rc3 using RaceFuzzer (a modified > version of Syzkaller), which we describe more at the end of this > report. >

[PATCH] mei: fix use-after-free in mei_cl_write

2018-08-22 Thread john . hubbard
From: John Hubbard KASAN reports a use-after-free during startup, in mei_cl_write: BUG: KASAN: use-after-free in mei_cl_write+0x601/0x870 [mei] (drivers/misc/mei/client.c:1770) This is caused by commit 98e70866aacb ("mei: add support for variable length mei headers."), which changed

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-22 Thread Benjamin Herrenschmidt
On Wed, 2018-08-22 at 22:11 -0700, Linus Torvalds wrote: > On Wed, Aug 22, 2018 at 9:54 PM Benjamin Herrenschmidt > wrote: > > > > > > So we do need a different flush instruction for the page tables vs. the > > normal TLB pages. > > Right. ARM wants it too. x86 is odd in that a regular "invlpg

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 10:11 PM Linus Torvalds wrote: > > So instead, when you get to the actual "tlb_flush(tlb)", you do > exactly that - flush the tlb. And the mmu_gather structure shows you > how much you need to flush. If you see that "freed_tables" is set, > then you know that you need to al

Re: [PATCH 1/2] dt-bindings: dmaengine: add DT binding for UniPhier MIO DMAC

2018-08-22 Thread Masahiro Yamada
Hi Jassi, 2018-08-21 19:44 GMT+09:00 Jassi Brar : > On 21 August 2018 at 15:17, Masahiro Yamada > wrote: >> (+CC Rob, DT, LKML) >> >> I forgot to CC this to DT community... >> >> >> 2018-08-21 18:30 GMT+09:00 Masahiro Yamada : >>> The MIO DMAC (Media IO DMA Controller) is used in UniPhier LD4, >

Re: [PATCH 2/4] mm/tlb: Remove tlb_remove_table() non-concurrent condition

2018-08-22 Thread Nicholas Piggin
On Wed, 22 Aug 2018 21:54:48 -0700 Linus Torvalds wrote: > On Wed, Aug 22, 2018 at 9:16 PM Nicholas Piggin wrote: > > > > On Wed, 22 Aug 2018 20:35:16 -0700 > > Linus Torvalds wrote: > > > > > > And yes, those lazy tlbs are all kernel threads, but they can still > > > speculatively load user

[PATCH] mm: respect arch_dup_mmap() return value

2018-08-22 Thread Nadav Amit
Commit d70f2a14b72a4 ("include/linux/sched/mm.h: uninline mmdrop_async(), etc") ignored the return value of arch_dup_mmap(). As a result, on x86, a failure to duplicate the LDT (e.g., due to memory allocation error), would leave the duplicated memory mapping in an inconsistent state. Fix by regard

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 9:54 PM Benjamin Herrenschmidt wrote: > > > So we do need a different flush instruction for the page tables vs. the > normal TLB pages. Right. ARM wants it too. x86 is odd in that a regular "invlpg" already invalidates all the internal tlb cache nodes. So the "new world o

Re: [PATCH] iscsi-target: Don't use stack buffer for scatterlist

2018-08-22 Thread Mike Christie
ccing Maurizio because he was working on the same issue. On 08/22/2018 12:37 PM, Laura Abbott wrote: > Fedora got a bug report of a crash with iSCSI: > > kernel BUG at include/linux/scatterlist.h:143! > ... > RIP: 0010:iscsit_do_crypto_hash_buf+0x154/0x180 [iscsi_target_mod] > ... > Call Trace:

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 9:33 PM Nicholas Piggin wrote: > > I think it was quite well understood and fixed here, a145abf12c9 but > again that was before I really started looking at it. You don't understand the problem. All the x86 people thought WE ALREADY DID THAT. Because we had done this all

Re: [PATCH 2/4] mm/tlb: Remove tlb_remove_table() non-concurrent condition

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 9:16 PM Nicholas Piggin wrote: > > On Wed, 22 Aug 2018 20:35:16 -0700 > Linus Torvalds wrote: > > > > And yes, those lazy tlbs are all kernel threads, but they can still > > speculatively load user addresses. > > So? > > If the arch does not shoot those all down after the

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-22 Thread Benjamin Herrenschmidt
On Wed, 2018-08-22 at 20:59 -0700, Linus Torvalds wrote: > On Wed, Aug 22, 2018 at 8:45 PM Nicholas Piggin wrote: > > > > powerpc/radix has no such issue, it already does this tracking. > > Yeah, I now realize that this was why you wanted to add that hacky > thing to the generic code, so that yo

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-22 Thread Nicholas Piggin
On Wed, 22 Aug 2018 20:59:46 -0700 Linus Torvalds wrote: > On Wed, Aug 22, 2018 at 8:45 PM Nicholas Piggin wrote: > > > > powerpc/radix has no such issue, it already does this tracking. > > Yeah, I now realize that this was why you wanted to add that hacky > thing to the generic code, so that

[GIT PULL 4/4] ARM: Device-tree updates

2018-08-22 Thread Olof Johansson
Business as usual -- the bulk of our changes are to devicetree files with new hardware support, new SoCs and platforms, and new board types. New SoCs/platforms: - Raspberry Pi Compute Module (CM1) and IO board - i.MX6SSL from NXP - Renesas RZ/N1D SoC (R9A06G032), Dual Cortex-A7 with Ethernet, CAN

[GIT PULL 3/4] ARM: SoC defconfig updates

2018-08-22 Thread Olof Johansson
We keep these separate since some files are shared and conflict-prone, but there isn't really much to write about here. Some of the churnier pieces is for the Aspeed platforms, which did an overdue refresh of the defconfig, and enabled USB gadget and some drivers from there. Most of the rest are m

[GIT PULL 2/4] ARM: SoC driver updates

2018-08-22 Thread Olof Johansson
Some of the larger changes this merge window: - Removal of drivers for Exynos5440, a Samsung SoC that never saw widespread use. - Uniphier support for USB3 and SPI reset handling - Syste control and SRAM drivers and bindings for Allwinner platforms - Qualcomm AOSS (Always-on subsystem) reset contro

[GIT PULL 1/4] ARM: 32-bit SoC platform updates

2018-08-22 Thread Olof Johansson
Most of the SoC updates in this cycle are cleanups and moves to more modern infrastructure: - Davinci was moved to common clock framework - OMAP1-based Amstrad E3 "Superphone" saw a bunch of cleanups to the keyboard interface (bitbanged AT keyboard via GPIO). - Removal of some stale code for Renes

[GIT PULL 0/4] ARM: SoC/platform updates

2018-08-22 Thread Olof Johansson
Hi Linus, Another medium-sized batch of ARM updates this release cycle. Not a large number of new platforms in this release, but there are a few -- from Renesas and TI in particular. 790 patches this time around, 173 authors. 26531 lines added and 13363 removed -- very close to the size of last r

Re: [RFC PATCH 3/5] RISC-V: Add cpu_operatios structure

2018-08-22 Thread Atish Patra
On 8/22/18 8:54 PM, Anup Patel wrote: On Wed, Aug 22, 2018 at 11:33 AM, Christoph Hellwig wrote: On Tue, Aug 21, 2018 at 10:34:38PM +0530, Anup Patel wrote: The cpu_operations is certainly required because SOC vendors will add vendor-specific mechanism to selectively bringing-up CPUs/HARTs ins

Re: [PATCH 2/4] mm/tlb: Remove tlb_remove_table() non-concurrent condition

2018-08-22 Thread Nicholas Piggin
On Wed, 22 Aug 2018 20:35:16 -0700 Linus Torvalds wrote: > On Wed, Aug 22, 2018 at 8:31 PM Nicholas Piggin wrote: > > > > > > So that leaves speculative operations. I don't see where the problem is > > with those either -- this shortcut needs to ensure there are no other > > *non speculative* op

Re: [lkp-robot] [ipc] 296ba26b66: BUG:sleeping_function_called_from_invalid_context_at_mm/memory.c

2018-08-22 Thread Davidlohr Bueso
On Thu, 23 Aug 2018, kernel test robot wrote: FYI, we noticed the following commit (built with gcc-7): commit: 296ba26b6681b6e07ed419b3004647167cb17f61 ("ipc: drop ipc_lock()") https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master I suspect this is because that commit forgot

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 8:45 PM Nicholas Piggin wrote: > > powerpc/radix has no such issue, it already does this tracking. Yeah, I now realize that this was why you wanted to add that hacky thing to the generic code, so that you can add the tlb_flush_pgtable() call. I thought it was because powe

mv: cannot stat 'drivers/net/wireless/intel/iwlwifi/mvm/.tmp_mx_ops.o': No such file or directory

2018-08-22 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 815f0ddb346c196018d4d8f8f55c12b83da1de3f commit: 0fbe9a245c60bedebb6dd329966f463bb724450a microblaze: add endianness options to LDFLAGS instead of LD date: 4 weeks ago config: microblaze-allmodconfig (atta

Re: [PATCH] x86, kdump: Fix efi=noruntime NULL pointer dereference

2018-08-22 Thread Dave Young
On 08/22/18 at 06:23pm, Dave Young wrote: > On 08/21/18 at 03:39pm, Ard Biesheuvel wrote: > > On 9 August 2018 at 11:13, Dave Young wrote: > > > On 08/09/18 at 09:33am, Mike Galbraith wrote: > > >> On Thu, 2018-08-09 at 12:21 +0800, Dave Young wrote: > > >> > Hi Mike, > > >> > > > >> > Thanks for

Re: [PATCH 3/4] mm/tlb, x86/mm: Support invalidating TLB caches for RCU_TABLE_FREE

2018-08-22 Thread Nicholas Piggin
On Wed, 22 Aug 2018 17:55:27 +0200 Peter Zijlstra wrote: > On Wed, Aug 22, 2018 at 05:30:15PM +0200, Peter Zijlstra wrote: > > ARM > > which later used this put an explicit TLB invalidate in their > > __p*_free_tlb() functions, and PowerPC-radix followed that example. > > > +/* > > + * If we w

arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:10: fatal error: linux/crc32poly.h: No such file or directory

2018-08-22 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 815f0ddb346c196018d4d8f8f55c12b83da1de3f commit: faa16bc404d72a5afb857c924c83a5f691f83386 lib: Use existing define with polynomial date: 4 weeks ago config: powerpc-skiroot_defconfig (attached as .config)

Re: [PATCH 2/4] mm/tlb: Remove tlb_remove_table() non-concurrent condition

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 8:35 PM Linus Torvalds wrote: > > No. Because mm_users doesn't contain any lazy tlb users. .. or, as it turns out, the use_mm() case either, which can do gup_fast(). Oh well. Linus

Re: [PATCH 2/4] mm/tlb: Remove tlb_remove_table() non-concurrent condition

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 8:31 PM Nicholas Piggin wrote: > > > So that leaves speculative operations. I don't see where the problem is > with those either -- this shortcut needs to ensure there are no other > *non speculative* operations. mm_users is correct for that. No. Because mm_users doesn't c

linux-next: Tree for Aug 23

2018-08-22 Thread Stephen Rothwell
Hi all, Please do not add any v4.20 material to your linux-next included branches until after v4.19-rc1 has been released. Changes since 20180822: New tree: at91-fixes The kbuild tree gained a build failure so I used the version from next-20180822. Non-merge commits (relative to Linus'

Re: [PATCH 2/4] mm/tlb: Remove tlb_remove_table() non-concurrent condition

2018-08-22 Thread Nicholas Piggin
On Wed, 22 Aug 2018 17:30:14 +0200 Peter Zijlstra wrote: > Will noted that only checking mm_users is incorrect; we should also > check mm_count in order to cover CPUs that have a lazy reference to > this mm (and could do speculative TLB operations). Why is that incorrect? This shortcut has noth

Re: KASAN: use-after-free Write in irq_bypass_register_consumer

2018-08-22 Thread Eric Biggers
On Sat, May 26, 2018 at 11:24:01AM +0200, Dmitry Vyukov wrote: > On Sun, May 13, 2018 at 8:21 AM, Eric Biggers wrote: > > On Thu, Apr 05, 2018 at 08:15:24PM -0700, Eric Biggers wrote: > >> On Mon, Jan 29, 2018 at 01:29:48PM +0800, Tianyu Lan wrote: > >> > > >> > > >> > On 1/27/2018 7:27 AM, Eric B

Compliment of the day to you Dear Friend.

2018-08-22 Thread Mrs. Amina Kadi
Compliment of the day to you Dear Friend. Dear Friend. I am Mrs. Amina Kadi. am sending this brief letter to solicit your partnership to transfer $5.5 million US Dollars. I shall send you more information and procedures when I receive positive response from you. Mrs. Amina Kadi

Re: [PATCH 1/9] of: add helper to lookup compatible child node

2018-08-22 Thread kbuild test robot
Hi Johan, I love your patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on v4.18 next-20180822] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[lkp-robot] [x86] 19efe000d3: PANIC:double_fault

2018-08-22 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-5): commit: 19efe000d3258032d9a1dfb25313a092f9454da0 ("x86: Remap the IRQ stack so it has guard pages") https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git x86/guard_pages in testcase: trinity with following parameters: runtim

[PATCH] cpufreq: ti-cpufreq: Only register platform_device when supported

2018-08-22 Thread Dave Gerlach
Currently the ti-cpufreq driver blindly registers a 'ti-cpufreq' to force the driver to probe on any platforms where the driver is built in. However, this should only happen on platforms that actually can make use of the driver. There is already functionality in place to match the SoC compatible so

Re: [PATCH] include/linux/compiler*.h: make compiler-*.h mutually exclusive

2018-08-22 Thread Masahiro Yamada
Hi Nick 2018-08-23 8:37 GMT+09:00 Nick Desaulniers : > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > recently exposed a brittle part of the build for supporting non-gcc > compilers. > > Both Clang and ICC define __GNUC__, __GNUC_MINOR__, and > __GNUC_PATCHLEVEL__ for quic

Re: [PATCH] irq: ingenic: Drop dependency on MACH_INGENIC

2018-08-22 Thread kbuild test robot
Hi Paul, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/irq/core] [also build test WARNING on v4.18 next-20180822] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[PATCH] scsi/virio_scsi.c: do not call virtscsi_remove_vqs() in virtscsi_init() to avoid crash bug

2018-08-22 Thread piaojun
If some error happened before find_vqs, error branch will goto virtscsi_remove_vqs to free vqs. Actually the vqs have not been allocated successfully, so this will cause wild-pointer-free problem. So virtscsi_remove_vqs could be deleted as no error will happen after find_vqs. Signed-off-by: Jun Pi

[GIT PULL] tracing: gcov and fixes to no kprobes on notrace functions

2018-08-22 Thread Steven Rostedt
Linus, Masami found an off by one bug in the code that keeps "notrace" functions from being traced by kprobes. During my testing, I found that there's places that we may want to add kprobes to notrace, thus we may end up changing this code before 4.19 is released. The history behind this change

Re: linux-next: build warning after merge of the apparmor tree

2018-08-22 Thread John Johansen
On 08/22/2018 05:20 PM, Stephen Rothwell wrote: > Hi John, > > After merging the apparmor tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > security/apparmor/policy_unpack.c: In function 'unpack_dfa': > security/apparmor/policy_unpack.c:426:1: warning: label 'fail'

Re: Overview of performance improvements of recent SMB3 compounding patches

2018-08-22 Thread Ronnie Sahlberg
We also have stat() that drops from 6 to 2 roundtrips. For metadata I think the only remaining low hanging fruit is readdir(). Currently in cifs.ko scanning a directory takes a minimum of 4 roundtrips : open query and get data query and get the error STATUS_NO_MORE_FILES close For small-ish dir

Re: [PATCH v5 0/4] x86/boot/KASLR: Parse ACPI table and limit kaslr in immovable memory.

2018-08-22 Thread Chao Fan
Hi all, No reply for 2 weeks, any comments? Thanks, Chao Fan On Tue, Aug 07, 2018 at 02:49:56PM +0800, Chao Fan wrote: >***Background: >People reported that kaslr may randomly chooses some positions >which are located in movable memory regions. This will break memory >hotplug feature and make th

Re: [BUGFIX PATCH] tracing/kprobes: Fix to check notrace function with correct range

2018-08-22 Thread Steven Rostedt
On Thu, 23 Aug 2018 10:18:31 +0900 Masami Hiramatsu wrote: > On Wed, 22 Aug 2018 08:58:09 -0400 > Steven Rostedt wrote: > > > On Tue, 21 Aug 2018 09:42:49 -0400 > > Steven Rostedt wrote: > > > > > On Tue, 21 Aug 2018 22:04:57 +0900 > > > Masami Hiramatsu wrote: > > > > > > > Fix within_

Re: [RFC PATCH 1/2] x86: WARN() when uaccess helpers fault on kernel addresses

2018-08-22 Thread Andy Lutomirski
On Wed, Aug 22, 2018 at 5:55 PM, Jann Horn wrote: > On Thu, Aug 23, 2018 at 2:28 AM Andy Lutomirski wrote: >> >> On Wed, Aug 22, 2018 at 4:53 PM, Jann Horn wrote: >> > On Tue, Aug 7, 2018 at 4:55 AM Andy Lutomirski wrote: >> >> > On Aug 6, 2018, at 6:22 PM, Jann Horn wrote: >> >> > There have

Re: [BUGFIX PATCH] tracing/kprobes: Fix to check notrace function with correct range

2018-08-22 Thread Masami Hiramatsu
On Wed, 22 Aug 2018 08:58:09 -0400 Steven Rostedt wrote: > On Tue, 21 Aug 2018 09:42:49 -0400 > Steven Rostedt wrote: > > > On Tue, 21 Aug 2018 22:04:57 +0900 > > Masami Hiramatsu wrote: > > > > > Fix within_notrace_func() to check notrace function correctly. > > > > > > Since the ftrace_loc

Re: [PATCH] include/linux/compiler*.h: make compiler-*.h mutually exclusive

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 6:10 PM Dominique Martinet wrote: > > I'm not building linux directly, but BPF programs that indirectly uses > clang with bcc Oh, ok. I _can_ test the basic build (just not get a working link and a kernel) by just forcing it, so I guess I'll call that testing enough. I'l

Re: [PATCH] include/linux/compiler*.h: make compiler-*.h mutually exclusive

2018-08-22 Thread Dominique Martinet
Linus Torvalds wrote on Wed, Aug 22, 2018: > I've fixed that manually, but when I tried to test it I just hit the > > arch/x86/Makefile:179: *** Compiler lacks asm-goto support.. Stop. > > error. > > Do you have some experimental clang build with asm goto support? What > version? Or is it jus

Re: please revert commit ce8556cca6 "kbuild: verify that $DEPMOD is installed" introduced in v4.18.4.

2018-08-22 Thread Randy Dunlap
On 08/22/2018 05:39 PM, Dmitry Torokhov wrote: > On Wed, Aug 22, 2018 at 4:35 PM Randy Dunlap wrote: >> >> On 08/22/2018 11:53 AM, H. Nikolaus Schaller wrote: >>> This patch requires that /sbin/depmod is installed and installable on >>> the build host. >>> >>> But not all build hosts for cross com

Re: [PATCH] include/linux/compiler*.h: make compiler-*.h mutually exclusive

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 5:25 PM Dominique Martinet wrote: > > Overall looks good to me, just pointing at the same error I wrote in my > other mail here -- I saw that by the time I was done writing this this > patch got taken but that alone will probably warrant a follow-up :/ I've fixed that manu

Re: [RFC PATCH 1/2] x86: WARN() when uaccess helpers fault on kernel addresses

2018-08-22 Thread Jann Horn
On Thu, Aug 23, 2018 at 2:28 AM Andy Lutomirski wrote: > > On Wed, Aug 22, 2018 at 4:53 PM, Jann Horn wrote: > > On Tue, Aug 7, 2018 at 4:55 AM Andy Lutomirski wrote: > >> > On Aug 6, 2018, at 6:22 PM, Jann Horn wrote: > >> > There have been multiple kernel vulnerabilities that permitted usersp

Re: [PATCH v4 1/3] Input: edt-ft5x06 - Add support for regulator

2018-08-22 Thread Dmitry Torokhov
On Tue, Aug 07, 2018 at 08:59:44AM +0200, Mylène Josserand wrote: > Hello Dmitry, > > Thank you again for the review. > > On Wed, 25 Jul 2018 17:47:32 -0700 > Dmitry Torokhov wrote: > > > Hi Mylène, > > > > On Wed, Jul 25, 2018 at 09:34:08AM +0200, Mylène Josserand wrote: > > > Add the support

Re: please revert commit ce8556cca6 "kbuild: verify that $DEPMOD is installed" introduced in v4.18.4.

2018-08-22 Thread Dmitry Torokhov
On Wed, Aug 22, 2018 at 4:35 PM Randy Dunlap wrote: > > On 08/22/2018 11:53 AM, H. Nikolaus Schaller wrote: > > This patch requires that /sbin/depmod is installed and installable on > > the build host. > > > > But not all build hosts for cross compiling Linux are Linux systems > > and are able to

Re: [PATCH] ASoC: max98373: Added 10ms delay after amp software reset

2018-08-22 Thread Dmitry Torokhov
On Wed, Aug 22, 2018 at 5:21 PM Ryan Lee wrote: > > Signed-off-by: Ryan Lee > --- > Changes : Applied 10ms delay after amp software reset. >10ms guard time is required for stability. > sound/soc/codecs/max98373.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/c

Re: [RFC PATCH 1/2] x86: WARN() when uaccess helpers fault on kernel addresses

2018-08-22 Thread Andy Lutomirski
On Wed, Aug 22, 2018 at 4:53 PM, Jann Horn wrote: > On Tue, Aug 7, 2018 at 4:55 AM Andy Lutomirski wrote: >> > On Aug 6, 2018, at 6:22 PM, Jann Horn wrote: >> > There have been multiple kernel vulnerabilities that permitted userspace to >> > pass completely unchecked pointers through to userspac

Re: [PATCH] include/linux/compiler*.h: make compiler-*.h mutually exclusive

2018-08-22 Thread Dominique Martinet
Nick Desaulniers wrote on Wed, Aug 22, 2018: > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > recently exposed a brittle part of the build for supporting non-gcc > compilers. > > Both Clang and ICC define __GNUC__, __GNUC_MINOR__, and > __GNUC_PATCHLEVEL__ for quick compat

Re: [PATCH] include/linux/compiler*.h: make compiler-*.h mutually exclusive

2018-08-22 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 4:39 PM Nick Desaulniers wrote: > > Rather than always including compiler-gcc.h then undefining or > redefining macros in compiler-intel.h or compiler-clang.h, let's > separate out the compiler specific macro definitions into mutually > exclusive headers, do more proper com

linux-next: build warning after merge of the apparmor tree

2018-08-22 Thread Stephen Rothwell
Hi John, After merging the apparmor tree, today's linux-next build (x86_64 allmodconfig) produced this warning: security/apparmor/policy_unpack.c: In function 'unpack_dfa': security/apparmor/policy_unpack.c:426:1: warning: label 'fail' defined but not used [-Wunused-label] fail: ^~~~ Introduc

Re: [PATCH] include/linux/compiler*.h: make compiler-*.h mutually exclusive

2018-08-22 Thread Joe Perches
On Wed, 2018-08-22 at 16:37 -0700, Nick Desaulniers wrote: > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > recently exposed a brittle part of the build for supporting non-gcc > compilers. style trivia: > diff --git a/include/linux/compiler_types.h b/include/linux/compile

[PATCH] ASoC: max98373: Added 10ms delay after amp software reset

2018-08-22 Thread Ryan Lee
Signed-off-by: Ryan Lee --- Changes : Applied 10ms delay after amp software reset. 10ms guard time is required for stability. sound/soc/codecs/max98373.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c index 2764fae..6aaf

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Dominique Martinet
Nick Desaulniers wrote on Wed, Aug 22, 2018: > I'm currently testing a fix in > https://github.com/ClangBuiltLinux/linux/commit/1f89ae7622c26b8131f42f3a362d6ef41b88a595, > can you please share with me your steps to test/verify that the patch > fixes the issue for eBPF? I'll go talk to a co-worker

Re: [RFC PATCH 1/2] x86: WARN() when uaccess helpers fault on kernel addresses

2018-08-22 Thread Jann Horn
On Tue, Aug 7, 2018 at 4:55 AM Andy Lutomirski wrote: > > On Aug 6, 2018, at 6:22 PM, Jann Horn wrote: > > There have been multiple kernel vulnerabilities that permitted userspace to > > pass completely unchecked pointers through to userspace accessors: > > > > - the waitid() bug - commit 96ca579

[PATCH] include/linux/compiler*.h: make compiler-*.h mutually exclusive

2018-08-22 Thread Nick Desaulniers
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") recently exposed a brittle part of the build for supporting non-gcc compilers. Both Clang and ICC define __GNUC__, __GNUC_MINOR__, and __GNUC_PATCHLEVEL__ for quick compatibility with code bases that haven't added compiler speci

Re: please revert commit ce8556cca6 "kbuild: verify that $DEPMOD is installed" introduced in v4.18.4.

2018-08-22 Thread Randy Dunlap
On 08/22/2018 11:53 AM, H. Nikolaus Schaller wrote: > This patch requires that /sbin/depmod is installed and installable on > the build host. > > But not all build hosts for cross compiling Linux are Linux systems > and are able to provide a working port of depmod, especially at the > file patch /

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Joe Perches
On Wed, 2018-08-22 at 16:05 -0700, Nick Desaulniers wrote: Hey Nick. > On Wed, Aug 22, 2018 at 1:50 PM Joe Perches wrote: > > A mild suggestion about the patch would be to break it up into > > 2 patches to improve how people read and review them. > > > > 1 include/linux/compiler-* > > 2 everyth

Re: at91 git tree in linux-next

2018-08-22 Thread Stephen Rothwell
Hi all, On Wed, 22 Aug 2018 14:47:56 +0200 Nicolas Ferre wrote: > > Alexandre Ludovic and myself are the group of maintainers for Microchip > ARM SoCs. The current tree that we have in linux-next is mine [1] and we > are moving to a common group kernel.org tree. > > So, can you please add our

Re: [PATCH] compiler-gcc: get back Clang build

2018-08-22 Thread Nick Desaulniers
On Wed, Aug 22, 2018 at 1:50 PM Joe Perches wrote: > > On Wed, 2018-08-22 at 11:31 -0700, Nick Desaulniers wrote: > > On Tue, Aug 21, 2018 at 9:32 PM Dominique Martinet > > wrote: > > > > > > Joe Perches wrote on Tue, Aug 21, 2018: > > > > On Wed, 2018-08-22 at 06:16 +0200, Dominique Martinet wro

Re: [PATCH v2 1/2] Input: atmel_mxt_ts: Add support for optional regulators.

2018-08-22 Thread George G. Davis
Hello Nick, On Tue, Jul 17, 2018 at 10:00:05PM +0100, Nick Dyer wrote: > On Tue, Jul 17, 2018 at 08:16:25PM +0200, Paweł Chmiel wrote: > > This patch adds optional regulators, which can be used to power > > up touchscreen. After enabling regulators, we need to wait 150msec. > > This value is taken

microblaze-linux-ld: cannot find sound/soc/jz4740/jz4740-i2s.o: No such file or directory

2018-08-22 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 899fbc33fd775b9dfa363db28f322272920a2196 commit: 0fbe9a245c60bedebb6dd329966f463bb724450a microblaze: add endianness options to LDFLAGS instead of LD date: 4 weeks ago config: microblaze-allmodconfig (atta

linux-next: build failure after merge of the kbuild tree

2018-08-22 Thread Stephen Rothwell
ed to merge target specific data of file drivers/input/mouse/byd.o and many, many more like this. Sorry, I can't easily tell what caused this. I have used the kbuild tree from next-20180822 for today. -- Cheers, Stephen Rothwell pgpsMUCqr0DYj.pgp Description: OpenPGP digital signature

Re: [PATCH 4/4] x86/mm: Only use tlb_remove_table() for paravirt

2018-08-22 Thread Eduardo Valentin
Hey Peter, On Wed, Aug 22, 2018 at 05:30:16PM +0200, Peter Zijlstra wrote: > If we don't use paravirt; don't play unnecessary and complicated games > to free page-tables. > > Suggested-by: Linus Torvalds > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/x86/Kconfig |

Re: [PATCH 1/4] x86/mm/tlb: Revert the recent lazy TLB patches

2018-08-22 Thread Rik van Riel
On Wed, 2018-08-22 at 14:37 -0700, Linus Torvalds wrote: > On Wed, Aug 22, 2018 at 8:46 AM Peter Zijlstra > wrote: > > > > Revert [..] in order to simplify the TLB invalidate fixes for x86. > > We'll try again later. > > Rik, I assume I should take your earlier "yeah, I can try later" as > an >

Re: [RFC v8 PATCH 3/5] mm: mmap: zap pages with read mmap_sem in munmap

2018-08-22 Thread Dave Hansen
On 08/22/2018 02:56 PM, owner-linux...@kvack.org wrote: > > > On 8/22/18 2:42 PM, Dave Hansen wrote: >> On 08/22/2018 02:10 PM, Kirill A. Shutemov wrote: For x86, mpx_notify_unmap() looks finally zap the VM_MPX vmas in bound table range with zap_page_range() and doesn't update vm f

[RFC PATCH 2/4] drivers/tty/vt/keyboard.c: add keyboard config for each vt's input

2018-08-22 Thread Remi Pommarel
Each connected kbd_handle holds a keyboard config that contains the keymap used to translate keycode into keysym. At init and until the kbd_handle gets detached it uses the global keyboard config (aka key_maps[]) array to translate keycode into keysym. For now, it is not possible for the user to d

[RFC PATCH 1/4] drivers/tty/vt/keyboard.c: refactor getting/setting a keymap entry

2018-08-22 Thread Remi Pommarel
In order to ease the addition of the ability of an input to use a different key configuration (keycode to keysym map), the operations of getting and setting an entry in a key map is moved in respective functions. Signed-off-by: Remi Pommarel Tested-by: Elie Roudninski --- drivers/tty/vt/keyboar

[RFC PATCH 4/4] drivers/tty/vt: add ioctl to manage input specific keyboard configs

2018-08-22 Thread Remi Pommarel
Because user can use different keyboards with different layouts on the same tty, an input could have a different key map from another one. In order to use and modify this specific key map the user can call three new ioctls: 1) KDGKBIENT Get an input key map's entry. If the input does not h

[RFC PATCH 0/4] Add specific vt input's key map

2018-08-22 Thread Remi Pommarel
This patchset adds a way to have a specific keyboard config (i.e. keycode to keysym map) for a vt attached input. Because one can have different keyboards with different layouts on the same VT, it can be useful to be able to associate a different keymap with a different input. In order to do so th

Re: [RFC v8 PATCH 3/5] mm: mmap: zap pages with read mmap_sem in munmap

2018-08-22 Thread Yang Shi
On 8/22/18 2:42 PM, Dave Hansen wrote: On 08/22/2018 02:10 PM, Kirill A. Shutemov wrote: For x86, mpx_notify_unmap() looks finally zap the VM_MPX vmas in bound table range with zap_page_range() and doesn't update vm flags, so it sounds ok to me since vmas have been detached, nobody can find t

Re: [PATCH v3 1/2] mm: migration: fix migration of huge PMD shared pages

2018-08-22 Thread Mike Kravetz
On 08/22/2018 02:05 PM, Kirill A. Shutemov wrote: > On Tue, Aug 21, 2018 at 06:10:42PM -0700, Mike Kravetz wrote: >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index 3103099f64fd..f085019a4724 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -4555,6 +4555,9 @@ static bool vma_shareable(str

Re: [PATCH v3] vfs: don't evict uninitialized inode

2018-08-22 Thread Marc Dionne
On Wed, Aug 22, 2018 at 4:37 PM, Marc Dionne wrote: > > FYI with this patch (now merged) I'm seeing warnings whenever an > object is created in an overlayfs mount: > > [ 842.152673] list_add double add: new=88017efe03d8, > prev=88015c07ad88, next=88017efe03d8. > [ 842.152687] WARNING

Re: [PATCH v2 4/4] dt-bindigs: msm: Update documentation of qcom,llcc

2018-08-22 Thread vnkgutta
On 2018-08-20 12:53, Rob Herring wrote: On Fri, Aug 17, 2018 at 05:08:35PM -0700, Venkata Narendra Kumar Gutta wrote: Add reg-names and interrupts for LLCC documentation and the usage examples. llcc broadcast base is added in addition to llcc base, which is used for llcc broadcast writes. Typo

[GIT PULL] Please pull RDMA subsystem changes

2018-08-22 Thread Jason Gunthorpe
Hi Linus, Second merge window pull request This is the SMC cleanup promised, a randconfig regression fix, and kernel oops fix. I've learned we have at least one regression this merge window in IPoIB, which people are working on. The following changes since commit 0a3173a5f09bc58a3638ecfd0a80bdb

Re: [PATCH 4.4 40/43] loop: add recursion validation to LOOP_CHANGE_FD

2018-08-22 Thread Ben Hutchings
On Mon, 2018-07-16 at 09:36 +0200, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > -- > > From: Theodore Ts'o > > commit d2ac838e4cd7e5e9891ecc094d626734b0245c99 upstream. > > Refactor the validation code used in LOOP_

  1   2   3   4   5   >