Re: [PATCH v3 1/7] tracing: Refactor hist trigger action code

2018-08-09 Thread Namhyung Kim
Hi Tom, On Thu, Aug 09, 2018 at 09:34:11AM -0500, Tom Zanussi wrote: > From: Tom Zanussi > > The hist trigger action code currently implements two essentially > hard-coded pairs of 'actions' - onmax(), which tracks a variable and > saves some event fields when a max is hit, and onmatch(), which

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-09 Thread Rashmica Gupta
On Fri, Aug 10, 2018 at 11:12 AM, Andrew Morton wrote: > On Thu, 9 Aug 2018 12:54:09 +1000 Rashmica Gupta > wrote: > >> When hot-removing memory release_mem_region_adjustable() splits >> iomem resources if they are not the exact size of the memory being >> hot-deleted. Adding this memory back t

Re: Linux 3.18.111

2018-08-09 Thread Seung-Woo Kim
On 2018년 08월 08일 19:06, Seung-Woo Kim wrote: > On 2018년 07월 05일 09:52, Al Viro wrote: >> On Mon, Jul 02, 2018 at 10:01:25PM -0700, Linus Torvalds wrote: >>> On Mon, Jul 2, 2018 at 9:43 PM Seung-Woo Kim wrote: I think the commit itself is required. Simple, but not reliable, workaroun

Re: [PATCH v2 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes.

2018-08-09 Thread Maxime Jourdan
2018-08-09 9:53 GMT+02:00 Neil Armstrong : > On 08/08/2018 10:41, Jerome Brunet wrote: >> On Wed, 2018-08-08 at 00:00 +0200, Maxime Jourdan wrote: >>> Wrap the canvas node in a syscon node. >>> >>> Signed-off-by: Maxime Jourdan >>> --- >>> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 17 ++

Re: [PATCH v2 1/4] soc: amlogic: add meson-canvas driver

2018-08-09 Thread Maxime Jourdan
2018-08-08 17:10 GMT+02:00 Neil Armstrong : > On 08/08/2018 09:45, Jerome Brunet wrote: >> On Wed, 2018-08-08 at 00:00 +0200, Maxime Jourdan wrote: >>> Amlogic SoCs have a repository of 256 canvas which they use to >>> describe pixel buffers. >>> >>> They contain metadata like width, height, block

linux-next: build failure after merge of the ida tree

2018-08-09 Thread Stephen Rothwell
Hi Matthew, After merging the ida tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/target/iscsi/iscsi_target_login.c: In function 'iscsi_login_zero_tsih_s1': drivers/target/iscsi/iscsi_target_login.c:376:16: error: 'sess_idr_lock' undeclared (first use in this func

Re: [PATCH] sched: idle: Avoid retaining the tick when it has been stopped

2018-08-09 Thread leo . yan
On Thu, Aug 09, 2018 at 07:08:34PM +0200, Rafael J . Wysocki wrote: > From: Rafael J. Wysocki > > If the tick has been stopped already, but the governor has not asked to > stop it (which it can do sometimes), the idle loop should invoke > tick_nohz_idle_stop_tick(), to let tick_nohz_stop_tick() t

Re: [PATCH 01/16] MAINTAINERS: Switch a maintainer for drivers/staging/gasket

2018-08-09 Thread Greg Kroah-Hartman
On Thu, Aug 09, 2018 at 08:40:06PM -0700, John Joseph wrote: > Acked-by: John Joseph Why are you acking something you supposidly already signed-off on? > On Thu, Aug 9, 2018 at 8:20 PM, Todd Poynor wrote: > > From: Todd Poynor > > > > Todd Poynor takes over for John Joseph. > > > > Signed-off-

Re: [PATCH v3 0/4] Add i.MX8MQ clock driver

2018-08-09 Thread Sascha Hauer
Hi Abel, On Thu, Aug 09, 2018 at 05:45:37PM +0300, Abel Vesa wrote: > This is basically just a resend of the following patchset: > > https://www.spinics.net/lists/linux-clk/msg23141.html > > I've just updated the patchset and implemented Shawn's > and Aisheng's comments. > > I hope I haven't mi

Re: [PATCH] sched: idle: Reenable sched tick for cpuidle request

2018-08-09 Thread leo . yan
On Thu, Aug 09, 2018 at 11:31:46PM +0200, Rafael J . Wysocki wrote: [...] > > >> And I really would prefer to avoid restarting the tick here, because > > >> it is overhead and quite likely unnecessary. > > > > > > I understand the logic when read the code, actually I did some experiments > > > on

Re: [PATCH 2/3] perf report: Add raw report support for s390 auxiliary trace

2018-08-09 Thread Michael Ellerman
Arnaldo Carvalho de Melo writes: > Em Thu, Aug 09, 2018 at 06:35:58AM +0200, Thomas-Mich Richter escreveu: >> On 08/08/2018 06:42 PM, Arnaldo Carvalho de Melo wrote: >> > So for those I applied this, seems to pass the ones that were failing, >> > restarting tests... > >> I just updated the perf/co

[PATCH] sched/fair : fix typos

2018-08-09 Thread Peng Hao
Signed-off-by: Peng Hao --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 2f0a0be..b7ab23d 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3315,7 +3315,7 @@ static inline void cfs_se_util_chan

Re: [PATCH] perf tools: Check for null when copying nsinfo.

2018-08-09 Thread Namhyung Kim
Hello, On Thu, Aug 09, 2018 at 11:53:48PM +0200, Benno Evers wrote: > The argument to nsinfo__copy() was assumed to be valid, but some code paths > exist that will lead to NULL being passed. > > In particular, running 'perf script -D' on a perf.data file containing an > PERF_RECORD_MMAP event ass

Re: [PATCH v2 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h

2018-08-09 Thread Guenter Roeck
On 08/09/2018 08:59 PM, Palmer Dabbelt wrote: [ ... ] Also, what is your methodology?  I follow     https://wiki.qemu.org/Documentation/Platforms/RISCV Here are my qemu command lines: qemu-system-riscv64 -M virt -m 512M -no-reboot -bios bbl \ -kernel vmlinux -netdev user,id=net0 -devi

Re: [PATCH v1 01/10] arm/arm64: dts: msm8974/msm8916: thermal: Split address space into two

2018-08-09 Thread Amit Kucheria
On Fri, Aug 10, 2018 at 12:41 AM Matthias Kaehlcke wrote: > > On Thu, Aug 09, 2018 at 06:02:33PM +0530, Amit Kucheria wrote: > > We've earlier added support to split the register address space into TM > > and SROT regions. > > > > Split up the regmap address space into two for the remaining platfo

[PATCH v2 1/2] PCI/ACPI: correct error message for ASPM disabling

2018-08-09 Thread Sinan Kaya
If _OSC execution fails today for platforms without an _OSC entry, code is printing a misleading message saying disabling ASPM as follows: acpi PNP0A03:00: _OSC failed (AE_NOT_FOUND); disabling ASPM We need to ensure that platform supports ASPM to begin with. Signed-off-by: Sinan Kaya Reported-

[PATCH v2 2/2] PCI/ACPI: allow _OSC presence to be optional for PCI

2018-08-09 Thread Sinan Kaya
ACPI Spec 6.0 Section 6.2.11.3 OSC Implementation Example for PCI Host Bridge Devices: For a host bridge device that originates a PCI Express hierarchy, the _OSC interface defined in this section is required. For a host bridge device that originates a PCI/PCI-X bus hierarchy, inclusion of an _OSC

[PATCH] riscv: Drop setup_initrd

2018-08-09 Thread Guenter Roeck
setup_initrd() does not appear to serve a practical purpose other than preventing qemu boots with "-initrd" parameter, so let's drop it. Signed-off-by: Guenter Roeck --- arch/riscv/kernel/setup.c | 39 --- 1 file changed, 39 deletions(-) diff --git a/arch/ris

Re: [PATCH v2 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h

2018-08-09 Thread Guenter Roeck
On 08/09/2018 08:59 PM, Palmer Dabbelt wrote: On Thu, 09 Aug 2018 19:40:55 PDT (-0700), li...@roeck-us.net wrote: On 08/09/2018 06:03 PM, Palmer Dabbelt wrote: On Thu, 09 Aug 2018 14:24:22 PDT (-0700), li...@roeck-us.net wrote: On Thu, Aug 09, 2018 at 01:25:24PM -0700, Palmer Dabbelt wrote: T

Re: [PATCH v1 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-08-09 Thread Borislav Petkov
On Wed, Aug 01, 2018 at 01:33:34PM -0700, Venkata Narendra Kumar Gutta wrote: > From: Channagoud Kadabi > > Add error reporting driver for SBEs and DBEs. As of now, this driver Please write out those abbreviations. > supports erp for Last Level Cache Controller (LLCC). This driver takes > care

Re: [PATCH v2 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h

2018-08-09 Thread Palmer Dabbelt
On Thu, 09 Aug 2018 19:40:55 PDT (-0700), li...@roeck-us.net wrote: On 08/09/2018 06:03 PM, Palmer Dabbelt wrote: On Thu, 09 Aug 2018 14:24:22 PDT (-0700), li...@roeck-us.net wrote: On Thu, Aug 09, 2018 at 01:25:24PM -0700, Palmer Dabbelt wrote: This file is expected to be included multiple ti

Re: [PATCH RESEND 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

2018-08-09 Thread Joey Pabalinas
On Thu, Aug 09, 2018 at 01:39:16PM -1000, Joey Pabalinas wrote: > The firmware found in the touch screen of the Surface Pro 3 is slightly > buggy and occasionally doesn't send lift off reports for contacts; add > MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed > reports. > > Sig

Re: [PATCH 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol

2018-08-09 Thread Joey Pabalinas
On Tue, Jul 03, 2018 at 10:16:01AM +0200, Benjamin Tissoires wrote: > There is a tiny difference between the HID group (this device looks > like it is used as a Win 8 device) and the device class (this is > effectively a Win8 device) > > It makes sense to remove this check for Win8 devices, but I

Re: [PATCH 01/16] MAINTAINERS: Switch a maintainer for drivers/staging/gasket

2018-08-09 Thread John Joseph
Acked-by: John Joseph On Thu, Aug 9, 2018 at 8:20 PM, Todd Poynor wrote: > From: Todd Poynor > > Todd Poynor takes over for John Joseph. > > Signed-off-by: John Joseph > Signed-off-by: Todd Poynor > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MA

Re: [PATCH 3/4] HID: multitouch: drop reports containing invalid values

2018-08-09 Thread Joey Pabalinas
On Tue, Jul 03, 2018 at 10:13:54AM +0200, Benjamin Tissoires wrote: > Hi Joey, > You can't really use plain values like that. There is a tiny chance > these values are valid on an other device. > IIRC, MS spec says that we should ignore out of band values if they > are tagged as such. Such input ar

[PATCH 00/16] staging: gasket: return of the son of cleanups

2018-08-09 Thread Todd Poynor
From: Todd Poynor Remove extraneous memory barriers, refactor PCI-specific code in prep for platform devices in the near future, general cleanups, and make de facto maintainership official. Todd Poynor (16): MAINTAINERS: Switch a maintainer for drivers/staging/gasket staging: gasket: core: r

[PATCH 07/16] staging: gasket: page table: remove unnecessary NULL check

2018-08-09 Thread Todd Poynor
From: Todd Poynor gasket_alloc_coherent_memory remove unnecessary NULL check for coherent_pages. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gasket/gasket_page_table.c b/dri

[PATCH 03/16] staging: gasket: core: fix line continuation indent in gasket_alloc_dev

2018-08-09 Thread Todd Poynor
From: Todd Poynor Previous cleanups missed a case of multi-line function call with line continuation parameters not aligned per kernel style. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/sta

[PATCH 05/16] staging: gasket: core: remove ftrace-style debug logs

2018-08-09 Thread Todd Poynor
From: Todd Poynor Remove debug logs that only indicate the name of the entered function, in favor of using ftrace for function tracing style logs. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/gasket/gas

[PATCH 02/16] staging: gasket: core: remove debug log that could crash

2018-08-09 Thread Todd Poynor
From: Todd Poynor A debug log in gasket_alloc_dev() is issued regardless of whether the device pointer used returned success or error. The log isn't that useful anyway, remove it. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH 13/16] staging: gasket: core: rename lookup_internal_desc to be PCI-specific

2018-08-09 Thread Todd Poynor
From: Todd Poynor Rename lookup_internal_desc() to lookup_pci_internal_desc() to reflect use for PCI devices only, in prep for non-PCI devices in the future. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH 11/16] staging: gasket: core: factor out generic device add code from PCI code

2018-08-09 Thread Todd Poynor
From: Todd Poynor Split out generic gasket device add code from the code for adding a PCI gasket device, in prep for other gasket device types in the future. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 76 ++-- 1 file changed, 48 insertions(+),

[PATCH 12/16] staging: gasket: core: factor out generic device remove code from PCI

2018-08-09 Thread Todd Poynor
From: Todd Poynor Separate code for generic parts of gasket device removal sequence from the PCI device removal code, in prep for non-PCI devices later. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions

[PATCH 06/16] staging: gasket: remove gasket_exit()

2018-08-09 Thread Todd Poynor
From: Todd Poynor Remove now-empty gasket_exit() function. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c index 0fe5b86b294c8..aee819f379e9a

[PATCH 08/16] staging: gasket: page table: use dma_mapping_error for error detection

2018-08-09 Thread Todd Poynor
From: Todd Poynor gasket_perform_mapping() call dma_mapping_error() to determine if mapping failed. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_page_table.c b/driv

[PATCH 14/16] staging: gasket: interrupt: refactor PCI MSIX-specific handler code

2018-08-09 Thread Todd Poynor
From: Todd Poynor Split interrupt handler into PCI MSIX-specific and generic functions, for adding non-MSIX handlers in the future. Move MSIX init code together,, out of generic init path. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_interrupt.c | 48 --- 1

[PATCH 16/16] staging: gasket: interrupt: remove unimplemented interrupt types

2018-08-09 Thread Todd Poynor
From: Todd Poynor Interrupt types PCI_MSI and PLATFORM_WIRE are unused and unimplemented. Remove these. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.h | 11 drivers/staging/gasket/gasket_interrupt.c | 34 +-- 2 files changed, 1 insertion(+

[PATCH 04/16] staging: gasket: core: remove kobj_name param from gasket_alloc_dev

2018-08-09 Thread Todd Poynor
From: Todd Poynor gasket_alloc_dev can retrieve the device name from the parent parameter, a separate parameter isn't needed for this. Rename the variable to better reflect its meaning, as the name of the parent device for which a gasket device is being allocated. Signed-off-by: Todd Poynor --

[PATCH 01/16] MAINTAINERS: Switch a maintainer for drivers/staging/gasket

2018-08-09 Thread Todd Poynor
From: Todd Poynor Todd Poynor takes over for John Joseph. Signed-off-by: John Joseph Signed-off-by: Todd Poynor --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index af64fe0f0b41f..f3466b5c50482 100644 --- a/MAINTAINERS +++ b/MAINT

[PATCH 15/16] staging: gasket: interrupt: simplify interrupt init parameters

2018-08-09 Thread Todd Poynor
From: Todd Poynor Pass the gasket driver descriptor to the interrupt init function, rather than exploding out separate parameters from various fields of that structure. This allows us to make more localized changes to the types of interrupts supported (MSIX vs. wire, etc.) without affecting the

[PATCH 09/16] staging: gasket: core: switch to relaxed memory-mapped I/O

2018-08-09 Thread Todd Poynor
From: Todd Poynor Use of readl() is deprecated; readl_relaxed() with appropriate memory barriers is preferred. Switch to relaxed reads and writes for better performance as well. Memory barriers required for I/O vs. normal memory access on Apex devices have already been explicitly coded in the p

[PATCH 10/16] staging: gasket: page table: remove extraneous memory barriers

2018-08-09 Thread Todd Poynor
From: Todd Poynor Some explicit memory barriers in the page table code are not necessary, either because: (a) The barrier follows a non-relaxed MMIO access that already performs a read or write memory barrier. (b) The barrier follows DMA API calls for which the device-visible effects of IOMMU p

Re: [PATCH] reiserfs: fix broken xattr handling (heap corruption, bad retval)

2018-08-09 Thread Jann Horn
On Thu, Aug 2, 2018 at 5:16 PM Jann Horn wrote: > > This fixes the following issues: > > - When a buffer size is supplied to reiserfs_listxattr() such that each >individual name fits, but the concatenation of all names doesn't >fit, reiserfs_listxattr() overflows the supplied buffer. This

Re: [PATCH 0/5 - V2] locks: avoid thundering-herd wake-ups

2018-08-09 Thread NeilBrown
On Thu, Aug 09 2018, J. Bruce Fields wrote: > On Fri, Aug 10, 2018 at 11:50:58AM +1000, NeilBrown wrote: >> You're good at this game! > > Everybody's got to have a hobby, mine is pathological posix locking > cases > >> So, because a locker with the same "owner" gets a free pass, you can >> *ne

mmotm 2018-08-09-20-10 uploaded

2018-08-09 Thread akpm
The mm-of-the-moment snapshot 2018-08-09-20-10 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You wi

Re: [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-09 Thread Stephen Boyd
What's with the top posting? ;-) Quoting Julius Werner (2018-08-09 16:44:43) > Actually, looking at what IO_STRICT_DEVMEM really does, would it > really prevent userspace accesses to these areas? Because it seems > that it only prevents accesses to areas marked as IORESOURCE_BUSY, and > while I ca

Re: [PATCH 0/5 - V2] locks: avoid thundering-herd wake-ups

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 11:50:58AM +1000, NeilBrown wrote: > You're good at this game! Everybody's got to have a hobby, mine is pathological posix locking cases > So, because a locker with the same "owner" gets a free pass, you can > *never* say that any lock which conflicts with A also confl

[PATCH] arm:pm: Use kmemdup to replace duplicating its implementation

2018-08-09 Thread zhong jiang
kmemdup is better than kmalloc() + memcpy(), and we do not like open code. So just use kmemdup instead. Signed-off-by: zhong jiang --- arch/arm/mach-lpc32xx/pm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-lpc32xx/pm.c b/arch/arm/mach-lpc32xx/pm.c ind

[PATCH] ia64:tioce_provider: Use kmemdup rather than implement the function

2018-08-09 Thread zhong jiang
The kmemdup has implemented the function that kmalloc() + memcpy will do. So just replace them to make the code concise. Signed-off-by: zhong jiang --- arch/ia64/sn/pci/tioce_provider.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/ia64/sn/pci/tioce_provider.c b/a

[PATCH] 9p: Add Dominique Martinet to MAINTAINERS

2018-08-09 Thread Dominique Martinet
From: Dominique Martinet Signed-off-by: Dominique Martinet Cc: Eric Van Hensbergen Cc: Latchesar Ionkov Cc: Ron Minnich Cc: Andrew Morton --- I've had an off-list Ack from Lucho and Eric about adding myself, and got reminded I should probably do it sooner than later by Andrew. Could (a sub

Re: [PATCH v2 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h

2018-08-09 Thread Guenter Roeck
On 08/09/2018 06:03 PM, Palmer Dabbelt wrote: On Thu, 09 Aug 2018 14:24:22 PDT (-0700), li...@roeck-us.net wrote: On Thu, Aug 09, 2018 at 01:25:24PM -0700, Palmer Dabbelt wrote: This file is expected to be included multiple times in the same file in order to allow the __SYSCALL macro to generat

[PATCH] sched/core: Fix compiling warring in smp=n case

2018-08-09 Thread Dou Liyang
When compiling kernel with SMP disabled, the build warns with: kernel/sched/core.c: In function ‘update_rq_clock_task’: kernel/sched/core.c:139:17: warning: unused variable ‘irq_delta’ [-Wunused-variable] s64 steal = 0, irq_delta = 0; Fix this by revert the HAVE_SCHED_AVG_IRQ to defined(CON

Re: [PATCH v2 2/4] phy: socionext: add USB3 PHY driver for UniPhier SoC

2018-08-09 Thread Kunihiko Hayashi
Hi Kishon, On Thu, 9 Aug 2018 16:00:19 +0530 Kishon Vijay Abraham I wrote: > Hi, > > On Friday 03 August 2018 03:24 PM, Kunihiko Hayashi wrote: > > Add a driver for PHY interface built into USB3 controller > > implemented in UniPhier SoCs. > > This driver supports High-Speed PHY and Super-Speed

Re: [PATCH 1/2] PCI/ACPI: correct error message for ASPM disabling

2018-08-09 Thread Sinan Kaya
On 8/9/2018 8:27 PM, Joe Perches wrote: I think this would read better not using a temporary and using a ternary instead. Makes sense.

Re: [PATCH RESEND v2] arm64: clean the additional checks before calling ghes_notify_sea()

2018-08-09 Thread Tyler Baicar
On Thu, Aug 9, 2018 at 6:16 PM, gengdongjiu wrote: > 2018-08-10 5:05 GMT+08:00 Tyler Baicar : >> On Thu, Aug 9, 2018 at 8:32 AM, gengdongjiu wrote: >>> >>> 2018-08-08 0:26 GMT+08:00 Dongjiu Geng : >>> > In order to remove the additional check before calling the >>> > ghes_notify_sea(), make stub

Re: [PATCH 0/5 - V2] locks: avoid thundering-herd wake-ups

2018-08-09 Thread NeilBrown
On Thu, Aug 09 2018, J. Bruce Fields wrote: > On Fri, Aug 10, 2018 at 08:12:43AM +1000, NeilBrown wrote: >> On Thu, Aug 09 2018, J. Bruce Fields wrote: >> >> > I think there's also a problem with multiple tasks sharing the same >> > lock owner. >> > >> > So, all locks are exclusive locks for the

Re: FW: [PATCH v2] RISC-V: Add the directive for alignment of stvec's value

2018-08-09 Thread Palmer Dabbelt
On Thu, 09 Aug 2018 17:37:39 PDT (-0700), zong...@gmail.com wrote: Subject: [PATCH v2] RISC-V: Add the directive for alignment of stvec's value The stvec's value must be 4 byte alignment by specification definition. These directives avoid to stvec be set the non-alignment value. Signed-off-by:

Re: [PATCH v3 2/2] net/9p: add a per-client fcall kmem_cache

2018-08-09 Thread piaojun
Thanks for clearing my doubt, and you can add: Acked-by: Jun Piao On 2018/8/10 9:41, Dominique Martinet wrote: > piaojun wrote on Fri, Aug 10, 2018: >> Could you help paste the test result of before-after-applied this patch in >> comment? And please see my comments below. > > Thanks the the rev

Re: [PATCH v3 2/2] net/9p: add a per-client fcall kmem_cache

2018-08-09 Thread Dominique Martinet
piaojun wrote on Fri, Aug 10, 2018: > Could you help paste the test result of before-after-applied this patch in > comment? And please see my comments below. Thanks the the review, do you mean the commit message? I'll add the summary I wrote in reply to your question a few mails before. > > dif

Re: [PATCH v7 02/10] Makefile: Prepare for using macros for inline asm

2018-08-09 Thread Masahiro Yamada
Hi Nadav, 2018-08-10 5:15 GMT+09:00 Nadav Amit : > Using macros for inline assembly improves both readability and > compilation decisions that are distorted by big assembly blocks that use > alternative sections. Compile macros.S and use it to assemble all C > files. Currently, only x86 will use i

[PATCH] zsmalloc: fix linking bug in init_zspage

2018-08-09 Thread zhouxianrong
From: zhouxianrong The last partial object in last subpage of zspage should not be linked in allocation list. Otherwise it could trigger BUG_ON explicitly at function zs_map_object. But it happened rarely. Signed-off-by: zhouxianrong --- mm/zsmalloc.c | 2 ++ 1 file changed, 2 insertions(+) d

Re: [PATCH v3 2/2] net/9p: add a per-client fcall kmem_cache

2018-08-09 Thread piaojun
Hi Dominique, Could you help paste the test result of before-after-applied this patch in comment? And please see my comments below. On 2018/8/9 22:33, Dominique Martinet wrote: > From: Dominique Martinet > > Having a specific cache for the fcall allocations helps speed up > allocations a bit, e

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-09 Thread Andrew Morton
On Thu, 9 Aug 2018 12:54:09 +1000 Rashmica Gupta wrote: > When hot-removing memory release_mem_region_adjustable() splits > iomem resources if they are not the exact size of the memory being > hot-deleted. Adding this memory back to the kernel adds a new > resource. > > Eg a node has memory 0x0

Re: [PATCH] checkpatch: DT bindings should be a separate patch

2018-08-09 Thread Joe Perches
On Thu, 2018-08-09 at 14:50 -0600, Rob Herring wrote: > Devicetree bindings should be their own patch as documented in > Documentation/devicetree/bindings/submitting-patches.txt section I.1. > This is because bindings are logically independent from a driver > implementation, they have a different m

Re: [PATCH 0/4] locks: avoid thundering-herd wake-ups

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 09:56:07AM +1000, NeilBrown wrote: > On Thu, Aug 09 2018, J. Bruce Fields wrote: > > If we only cared about the former, and only in simple cases, we could > > walk the entire list and skip waking up only the locks that conflict > > with the first one we wake. We wouldn't ne

Re: [PATCH v2 2/2] RISC-V: Don't use a global include guard for uapi/asm/syscalls.h

2018-08-09 Thread Palmer Dabbelt
On Thu, 09 Aug 2018 14:24:22 PDT (-0700), li...@roeck-us.net wrote: On Thu, Aug 09, 2018 at 01:25:24PM -0700, Palmer Dabbelt wrote: This file is expected to be included multiple times in the same file in order to allow the __SYSCALL macro to generate system call tables. With a global include gu

Re: [PATCH 3/5] fs/locks: change all *_conflict() functions to return a new enum.

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 09:40:35AM +1000, NeilBrown wrote: > caller_fl is first and sys_fl is second. > > if sys_fl, the second, is a read lock, and caller_fl, the first, is a > write lock, they clearly conflict but any other lock that conflict > with caller_fl (The write lock) would *not* necessa

Re: [PATCH] checkpatch: DT bindings should be a separate patch

2018-08-09 Thread Andrew Morton
On Thu, 9 Aug 2018 14:50:32 -0600 Rob Herring wrote: > Devicetree bindings should be their own patch as documented in > Documentation/devicetree/bindings/submitting-patches.txt section I.1. > This is because bindings are logically independent from a driver > implementation, they have a different

Re: [PATCH v3 1/2] net/9p: embed fcall in req to round down buffer allocs

2018-08-09 Thread piaojun
LGTM On 2018/8/9 22:33, Dominique Martinet wrote: > From: Dominique Martinet > > 'msize' is often a power of two, or at least page-aligned, so avoiding > an overhead of two dozen bytes for each allocation will help the > allocator do its work and reduce memory fragmentation. > > Suggested-by: M

Re: FW: [PATCH v2] RISC-V: Add the directive for alignment of stvec's value

2018-08-09 Thread Zong Li
> Subject: [PATCH v2] RISC-V: Add the directive for alignment of stvec's value > > The stvec's value must be 4 byte alignment by specification definition. > These directives avoid to stvec be set the non-alignment value. > > Signed-off-by: Zong Li > --- > arch/riscv/kernel/head.S | 2 ++ > 1 file

Re: [PATCH 5/5] fs/locks: create a tree of dependent requests.

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 08:19:26AM +1000, NeilBrown wrote: > On Thu, Aug 09 2018, J. Bruce Fields wrote: > > I think you could simplify the code a lot by maintaining the tree so > > that it always satisfies the condition that waiters are always strictly > > "weaker" than their descendents, so that

Re: [PATCH] module: Add the print format of Elf_Addr for 32/64-bit compatibly

2018-08-09 Thread Zong Li
Zong Li 於 2018年7月17日 週二 上午11:06寫道: > > Use a similar way like fixed width integer types in inttypes.h. > > For the ELF, the Elf32_Addr is int type and Elf64_Addr is long long > type. It is opposite to definition of inttypes.h, so the Elf_Addr cannot > re-use the header. > > In many architectures,

Re: [PATCH v4 0/4] seccomp trap to userspace

2018-08-09 Thread Dinesh Subhraveti
On Mon, Aug 6, 2018 at 7:44 PM Tycho Andersen wrote: > > Hi all, > > Dinesh Subhraveti has claimed that some part of this series might be > patented. While he has not furnished me with anything to confirm this > claim, I'll put this series on hold. For the sake of everyone's clarity, there is no

Re: [PATCH 0/5 - V2] locks: avoid thundering-herd wake-ups

2018-08-09 Thread J. Bruce Fields
On Fri, Aug 10, 2018 at 08:12:43AM +1000, NeilBrown wrote: > On Thu, Aug 09 2018, J. Bruce Fields wrote: > > > I think there's also a problem with multiple tasks sharing the same > > lock owner. > > > > So, all locks are exclusive locks for the same range. We have four > > tasks. Tasks 1 and 4 s

Re: [PATCH 1/2] PCI/ACPI: correct error message for ASPM disabling

2018-08-09 Thread Joe Perches
On Thu, 2018-08-09 at 18:46 +, Sinan Kaya wrote: > If _OSC execution fails today for platforms without an _OSC > entry, code is printing a misleading message saying disabling > ASPM as follows: > > acpi PNP0A03:00: _OSC failed (AE_NOT_FOUND); disabling ASPM > > We need to ensure that platform

Re: [RFC PATCH v2 1/4] dt-bindings: misc: Add bindings for misc. BMC control fields

2018-08-09 Thread Kun Yi
Andrew, Benjamin, Rob, Thanks for bringing up the set of patches and a great discussion. After going through the thread I figured that I'd like to share a few things we needed to hack when programming several BMC boards: - Debug UART enable/mux - Disable GPIO D/E passthrough (I think this is supp

[PATCH] hid: microsoft: Add rumble support for Xbox One S controller

2018-08-09 Thread Andrey Smirnov
Add HID quirk driver for Xbox One S controller over bluetooth. This driver only adds support for rumble. Standard controller functionality is exposed by default HID driver. Cc: Dmitry Torokhov Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: linux-in...@vger.kernel.org Cc: linux-kernel@vger.kernel.o

Re: [PATCH 4/4] HID: multitouch: remove unneeded else conditional cases

2018-08-09 Thread Joey Pabalinas
On Tue, Jul 03, 2018 at 10:17:58AM +0200, Benjamin Tissoires wrote: > This one looks good. > Reviewed-by: Benjamin Tissoires > > Just FYI, I sent out a big refactor of the hid-multitouch code. Jiri > should be still reviewing it, so I am not so sure who will have to > rebase which series on top o

Re: [PATCH 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

2018-08-09 Thread Joey Pabalinas
On Tue, Jul 03, 2018 at 09:53:19AM +0200, Benjamin Tissoires wrote: > NACK on this. > If the Surface has a buggy firmware, we should handle it as a special > case, not as a common failure. > Also, I am not sure this quirk is compatible with Win 8 specification. > Last, we now have a timeout for unr

Re: [PATCH 0/4] locks: avoid thundering-herd wake-ups

2018-08-09 Thread NeilBrown
On Thu, Aug 09 2018, J. Bruce Fields wrote: > On Wed, Aug 08, 2018 at 06:50:06PM -0400, Jeff Layton wrote: >> That seems like a legit problem. >> >> One possible fix might be to have the waiter on (1,2) walk down the >> entire subtree and wake up any waiter that is waiting on a lock that >> doesn

Re: [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-09 Thread Julius Werner
Actually, looking at what IO_STRICT_DEVMEM really does, would it really prevent userspace accesses to these areas? Because it seems that it only prevents accesses to areas marked as IORESOURCE_BUSY, and while I can't fully follow how the kernel assigns that, comments suggest that this is only set w

Re: [PATCH v3 6/7] firmware: coreboot: Only populate devices in coreboot_table_init()

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 14:02:53) > On Thu, Aug 9, 2018 at 10:17 AM Stephen Boyd wrote: > > @@ -162,26 +143,37 @@ static int coreboot_table_probe(struct > > platform_device *pdev) > > if (!res->start || !len) > > return -EINVAL; > > > > + /* Map and check j

Re: [PATCH 3/5] fs/locks: change all *_conflict() functions to return a new enum.

2018-08-09 Thread NeilBrown
On Thu, Aug 09 2018, J. Bruce Fields wrote: > On Thu, Aug 09, 2018 at 12:04:41PM +1000, NeilBrown wrote: >> In a future patch we will need to differentiate between conflicts that >> are "transitive" and those that aren't. >> A "transitive" conflict is defined as one where any lock that >> conflict

[PATCH RESEND 4/4] HID: multitouch: remove unneeded else conditional cases

2018-08-09 Thread Joey Pabalinas
Elide lone `else` cases and replace `else if` clauses with plain `if` conditionals when they occur immediately after return statements. Signed-off-by: Joey Pabalinas 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 0

[PATCH RESEND 1/4] HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks

2018-08-09 Thread Joey Pabalinas
The firmware found in the touch screen of the Surface Pro 3 is slightly buggy and occasionally doesn't send lift off reports for contacts; add MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed reports. Signed-off-by: Joey Pabalinas 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH RESEND 3/4] HID: multitouch: drop reports containing invalid values

2018-08-09 Thread Joey Pabalinas
Avoid processing reports containing invalid values to reduce multitouch input stutter. Signed-off-by: Joey Pabalinas 1 file changed, 9 insertions(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index c0654db0b736543ca0..08b50e5908cecdda66 100644 --- a/drivers/hid/hi

[PATCH RESEND 0/4] reduce Surface Pro 3 multitouch jitter

2018-08-09 Thread Joey Pabalinas
The Surface Pro 3 firmware doesn't reliably send contact lift off reports nor handle invalid report values gracefully. To reduce touchscreen input jitter: - add MT_QUIRK_NOT_SEEN_MEANS_UP to the MT_CLS_WIN_8 - drop invalid report values Patches have been tested on my personal Surface Pro 3 fo

[PATCH RESEND 2/4] HID: multitouch: don't check HID_GROUP_MULTITOUCH_WIN_8 for serial protocol

2018-08-09 Thread Joey Pabalinas
The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial protocol, so avoid setting `td->serial_maybe = true;` in order to avoid an unnecessary mt_post_parse_default_settings() call Signed-off-by: Joey Pabalinas 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH 1/1] staging: fbtft: Removes ";" from very used macro definition.

2018-08-09 Thread Leonardo Brás
All usages of this macro append the ";" at the end of line. It is not recommended nor necessary to append a ";" at the end of this macro definition. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/

Re: [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access

2018-08-09 Thread Julius Werner
> Furthermore, I see that my system RAM excludes this coreboot table so it > doesn't fall into the bucket that CONFIG_STRICT_DEVMEM would find. Yes, that is intentional. We don't want the kernel to try to use that memory for anything else (since we want those tables to survive), so we mark them as

[RFC v7 PATCH 4/4] mm: unmap special vmas with regular do_munmap()

2018-08-09 Thread Yang Shi
Unmapping vmas, which have VM_HUGETLB | VM_PFNMAP flag set or have uprobes set, need get done with write mmap_sem held since they may update vm_flags. So, it might be not safe enough to deal with these kind of special mappings with read mmap_sem. Deal with such mappings with regular do_munmap() ca

[RFC v7 PATCH 0/4] mm: zap pages with read mmap_sem in munmap for large mapping

2018-08-09 Thread Yang Shi
Background: Recently, when we ran some vm scalability tests on machines with large memory, we ran into a couple of mmap_sem scalability issues when unmapping large memory space, please refer to https://lkml.org/lkml/2017/12/14/733 and https://lkml.org/lkml/2018/2/20/576. History: Then akpm sugg

[RFC v7 PATCH 1/4] mm: refactor do_munmap() to extract the common part

2018-08-09 Thread Yang Shi
Introduces three new helper functions: * addr_ok() * munmap_lookup_vma() * munlock_vmas() They will be used by do_munmap() and the new do_munmap with zapping large mapping early in the later patch. There is no functional change, just code refactor. Reviewed-by: Laurent Dufour Signed-off-b

[RFC v7 PATCH 3/4] uprobes: make vma_has_uprobes non-static

2018-08-09 Thread Yang Shi
vma_has_uprobes() will be used in the following patch to check if a vma could be unmapped with holding read mmap_sem, but it is static. So, make it non-static to use outside uprobe. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyu

[RFC v7 PATCH 2/4] mm: mmap: zap pages with read mmap_sem in munmap

2018-08-09 Thread Yang Shi
When running some mmap/munmap scalability tests with large memory (i.e. > 300GB), the below hung task issue may happen occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 "echo 0 > /proc/sys/kernel/hung_task_timeo

Re: [PATCH v3 3/7] firmware: coreboot: Make bus registration symmetric

2018-08-09 Thread Stephen Boyd
Quoting Julius Werner (2018-08-09 11:10:42) > > @@ -138,8 +136,10 @@ int coreboot_table_init(struct device *dev, void > > __iomem *ptr) > > ptr_entry += entry.size; > > } > > > > - if (ret) > > + if (ret) { > > + bus_unregister(&coreboot_bus_type);

[PATCH 2/2] staging: fbtft: Adds space around "/"

2018-08-09 Thread Leonardo Brás
Kernel coding style recommends a space char around "/". Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h index 798a8fe98e95..25302ffc4000 100644 --- a/d

[PATCH 1/2] staging: fbtft: Moves ";" from macro definition to macro usage.

2018-08-09 Thread Leonardo Brás
This makes the macro usage more like a function declaration. Also, ending a macro definition with ";" is not recommended by checkpatch.pl. Signed-off-by: Leonardo Brás --- drivers/staging/fbtft/fbtft-bus.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/stagin

Re: [PATCH 5/5] fs/locks: create a tree of dependent requests.

2018-08-09 Thread NeilBrown
On Thu, Aug 09 2018, Jeff Layton wrote: > On Thu, 2018-08-09 at 12:04 +1000, NeilBrown wrote: >> When we find an existing lock which conflicts with a request, >> and the request wants to wait, we currently add the request >> to a list. When the lock is removed, the whole list is woken. >> This ca

Re: [PATCH v3 2/7] firmware: coreboot: Unmap ioregion on failure

2018-08-09 Thread Stephen Boyd
Quoting Brian Norris (2018-08-09 12:52:13) > Hi, > > On Thu, Aug 09, 2018 at 12:40:31PM -0700, Stephen Boyd wrote: > > Quoting Brian Norris (2018-08-09 10:49:38) > > > On Thu, Aug 09, 2018 at 10:17:17AM -0700, Stephen Boyd wrote: > > > > Both callers of coreboot_table_init() ioremap the pointer th

  1   2   3   4   5   6   7   >