Re: [PATCH v2 3/3] serial: 8250_dw: add fractional divisor support

2018-07-04 Thread Jisheng Zhang
On Thu, 5 Jul 2018 14:39:21 +0800 Jisheng Zhang wrote: > > > > > + serial_port_out(p, UART_LCR, up->lcr | UART_LCR_DLAB); > > > + serial_dl_write(up, quot); > > > > At some point it would be a helper, I think. We can call > > serial8250_do_set_divisor() here. So, perhaps we might export

[PATCH v2 1/2] dt-bindings: clock: Introduce QCOM LPASS clock bindings

2018-07-04 Thread Taniya Das
Add device tree bindings for Low Power Audio subsystem clock controller for Qualcomm Technology Inc's SDM845 SoCs. Signed-off-by: Taniya Das --- .../devicetree/bindings/clock/qcom,lpasscc.txt | 22 ++ include/dt-bindings/clock/qcom,lpass-sdm845.h | 18 +++

[PATCH v2 0/2] Add support for LPASS clock controller for SDM845

2018-07-04 Thread Taniya Das
[v2] * Make gcc_lpass_sway_clk static. * Remove using child nodes and use reg-names to differentiate various domains of LPASS CC. Add support for the lpass clock controller found on SDM845 based devices. This would allow lpass peripheral loader drivers to control the clocks to bring the s

[PATCH v2 2/2] clk: qcom: Add lpass clock controller driver for SDM845

2018-07-04 Thread Taniya Das
Add support for the lpass clock controller found on SDM845 based devices. This would allow lpass peripheral loader drivers to control the clocks to bring the subsystem out of reset. Signed-off-by: Taniya Das --- drivers/clk/qcom/Kconfig | 9 ++ drivers/clk/qcom/lpasscc-sdm845.c | 243

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-07-04 Thread Faiz Abbas
Hi, On Thursday 05 July 2018 11:25 AM, Tony Lindgren wrote: > * Faiz Abbas [180704 13:37]: >> After taking a second look at this thread, I don't see anything big to >> be modified. >> >> We both agree that "reset status bit in sysconfig register" is the quirk >> case which can be added once such

RE: [PATCH] Debug: Add cpu registers dump in case of kernel panic

2018-07-04 Thread Tian, Baofeng
Resubmit again for review, this patch save register and used for RAM dump. Ramdump is an debug feature used to analysis complex panic/hang issues, it will recover all the data after pull the RAM to host and use an host tool to decode and analysis the RAM. Thanks Tim From: Tian, Baofeng Sent:

RE: [PATCH] reboot: add reboot_panic parameter

2018-07-04 Thread Tian, Baofeng
Hi, Morton On android platform, if use adb reboot, it will automatically reboot with cold reset. cold reset will reset RAM and cause RAM lose data information, if we want to enable some debug features like pstore, and ramdump etc, warm reset is needed to keep RAM across reset So, we add this in

RE: [PATCH] watchdog: add NMI handler for iTCO watchdog

2018-07-04 Thread Tian, Baofeng
Hi, Roeck Yes, as long as NMI interrupt generated, this handler will be called before reboot. We have another patch to handle NMI generation on X86 platform, it use perf event to generate NMI in TCO WDT driver. Will submit later. Thanks Tim -Original Message- From: Guenter Roeck [mail

linux-next: Tree for Jul 5

2018-07-04 Thread Stephen Rothwell
Hi all, Changes since 20180704: New tree: ida The slave-dma tree gained a build failure so I used the version from next-20180704. The ida tree gained a build failure for which I applied a patch and another for which I reverted 2 commits. Non-merge commits (relative to Linus' tree): 3867

Re: [PATCH v2 3/3] serial: 8250_dw: add fractional divisor support

2018-07-04 Thread Jisheng Zhang
Hi Andy, On Wed, 04 Jul 2018 19:08:22 +0300 Andy Shevchenko wrote: > On Wed, 2018-07-04 at 17:03 +0800, Jisheng Zhang wrote: > > Thanks for an update, my comments below. > > > For Synopsys DesignWare 8250 uart which version >= 4.00a, there's a > > valid divisor latch fraction register. The frac

Re: [PATCH] power: remove possible deadlock when unregistering power_supply

2018-07-04 Thread Benjamin Tissoires
Hi, On Mon, Jun 25, 2018 at 9:51 AM, Benjamin Tissoires wrote: > If a device gets removed right after having registered a power_supply node, > we might enter in a deadlock between the remove call (that has a lock on > the parent device) and the deferred register work. > > Allow the deferred regis

Re: [PATCH] Use short unix-style option instead of --longname.

2018-07-04 Thread Masahiro Yamada
2018-07-05 11:05 GMT+09:00 : > Hi. > >> -Original Message- >> From: Rob Landley [mailto:r...@landley.net] >> Sent: Thursday, July 05, 2018 4:06 AM >> To: triv...@kernel.org; Yamada, Masahiro/山田 真弘 >> ; Kees Cook ; Ulf >> Magnusson >> Subject: [PATCH] Use short unix-style option instead of

Re: [PATCH 2/4] i2c: imx: Fix race condition in dma read

2018-07-04 Thread Uwe Kleine-König
On Wed, May 23, 2018 at 11:56:21AM +0200, Esben Haabendal wrote: > From: Esben Haabendal > > This fixes a race condition, where the DMAEN bit ends up being set after > I2C slave has transmitted a byte following the dummy read. When that > happens, an interrupt is generated instead, and no DMA re

RE: [PATCH] watchdog: add module parameter "force_no_reboot" for iTCO

2018-07-04 Thread Tian, Baofeng
Hi, Roeck Yes, this patch is for add a parameter to TCO to prevent reboot happen if you don't want to reboot system and want to stay here to check some HW status, logs, etc for debug purpose. Under some android related stability test, developer want to stay at the crash and use debug tools(LTB

Re: [PATCH v2] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-07-04 Thread Thomas Gleixner
On Thu, 5 Jul 2018, Bin Yang wrote: > static inline pgprot_t static_protections(pgprot_t prot, unsigned long > address, > -unsigned long pfn) > +unsigned long pfn, unsigned long *page_num) > { > pgprot_t forbidden = __pgprot(0

[PATCH] gcc-plugins: split out Kconfig entries to scripts/gcc-plugins/Kconfig

2018-07-04 Thread Masahiro Yamada
Collect relevant code into the scripts/gcc-plugins directory. Signed-off-by: Masahiro Yamada --- arch/Kconfig| 146 +--- scripts/gcc-plugins/Kconfig | 141 ++ 2 files changed, 143 insertions(+), 144

[PATCH] f2fs: enable real-time discard by default

2018-07-04 Thread Chao Yu
f2fs is focused on flash based storage, so let's enable real-time discard by default, if user don't want to enable it, 'nodiscard' mount option should be used on mount. Signed-off-by: Chao Yu --- fs/f2fs/super.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/s

[PATCH v2] fs: shave 8 bytes off of struct inode

2018-07-04 Thread Amir Goldstein
Here is a link to Linus' reply to Jan's concern about making i_blkbibts byte addressable: https://marc.info/?l=linux-fsdevel&m=152882624707975&w=2 Here is a link to an lkp.org report about potential performance improvement in some workload, which could(?) be related to packing i_blkbits closer to

RE: [PATCH] watchdog: change ITCO_WDT type from tristate to bool

2018-07-04 Thread Tian, Baofeng
Hi, Roeck Yes, this patch submitted more than 1 year ago in our internal tree, I just tested latest 4.18 kernel, even without this patch, there is no error. So I am ok to reject this patch. Thanks Tim -Original Message- From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter

Re: [PATCH] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-07-04 Thread Thomas Gleixner
On Thu, 5 Jul 2018, Yang, Bin wrote: > Sorry for the misunderstanding. I mean I will improve the check loop in patch > v2. > I just submitted patch v2. Thanks in advance for your kind review. Did you actually read what I wrote? > On Thu, 5 Jul 2018, Yang, Bin wrote: > > Please do not top post

Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig

2018-07-04 Thread Masahiro Yamada
2018-07-03 5:50 GMT+09:00 Randy Dunlap : > On 07/02/18 13:41, Randy Dunlap wrote: > >> --- linux-next-20180702.orig/init/Kconfig >> +++ linux-next-20180702/init/Kconfig >> @@ -1717,6 +1717,12 @@ config PROFILING >> config TRACEPOINTS >> bool >> >> +# Note: arch/$(SRCARCH)/Kconfig needs to b

Re: [PATCH 4.16 234/279] x86/pkeys/selftests: Adjust the self-test to fresh distros that export the pkeys ABI

2018-07-04 Thread Michael Ellerman
Greg Kroah-Hartman writes: > On Tue, Jul 03, 2018 at 01:36:43PM +0200, Vlastimil Babka wrote: >> On 06/18/2018 10:13 AM, Greg Kroah-Hartman wrote: >> > 4.16-stable review patch. If anyone has any objections, please let me >> > know. >> >> So I was wondering, why backport such a considerable nu

Re: [lkp-robot] [fs] 5c6de586e8: vm-scalability.throughput +12.4% improvement (from reorganizing struct inode?)

2018-07-04 Thread Amir Goldstein
On Mon, Jul 2, 2018 at 9:27 AM, Amir Goldstein wrote: > Linus, > > This may be a test fluctuation or as a result of moving > i_blkbits closer to i_bytes and i_lock. > > In any case, ping for: > https://marc.info/?l=linux-fsdevel&m=152882624707975&w=2 > Linus, Per your request, I will re-post the

[PATCH 3/6] ipc/util.c: Use ipc_rcu_putref() for failues in ipc_addid()

2018-07-04 Thread Manfred Spraul
ipc_addid() is impossible to use: - for certain failures, the caller must not use ipc_rcu_putref(), because the reference counter is not yet initialized. - for other failures, the caller must use ipc_rcu_putref(), because parallel operations could be ongoing already. The patch cleans that up,

Re: [PATCH] cpuidle:powernv: Add the CPUIDLE_FLAG_POLLING for snooze

2018-07-04 Thread Michael Ellerman
Gautham R Shenoy writes: > On Tue, Jul 03, 2018 at 07:36:16PM +0530, Vaidyanathan Srinivasan wrote: >> * Gautham R Shenoy [2018-07-03 10:54:16]: >> >> > From: "Gautham R. Shenoy" >> > >> > In the situations where snooze is the only cpuidle state due to >> > firmware not exposing any platform i

[PATCH 2/6] ipc: reorganize initialization of kern_ipc_perm.seq

2018-07-04 Thread Manfred Spraul
ipc_addid() initializes kern_ipc_perm.seq after having called ipc_idr_alloc(). Thus a parallel semop() or msgrcv() that uses ipc_obtain_object_check() may see an uninitialized value. The patch moves the initialization of kern_ipc_perm.seq before the calls of ipc_idr_alloc(). Notes: 1) This patch

[PATCH 6/6] ipc/util.c: correct comment in ipc_obtain_object_check

2018-07-04 Thread Manfred Spraul
The comment that explains ipc_obtain_object_check is wrong: The function checks the sequence number, not the reference counter. Note that checking the reference counter would be meaningless: The reference counter is decreased without holding any locks, thus an object with kern_ipc_perm.deleted=true

[PATCH 4/6] ipc: Rename ipcctl_pre_down_nolock().

2018-07-04 Thread Manfred Spraul
Both the comment and the name of ipcctl_pre_down_nolock() are misleading: The function must be called while holdling the rw semaphore. Therefore the patch renames the function to ipcctl_obtain_check(): This name matches the other names used in util.c: - "obtain" function look up a pointer in the id

[PATCH 5/6] ipc: rename ipc_lock() to ipc_lock_idr()

2018-07-04 Thread Manfred Spraul
ipc/util.c contains multiple functions to get the ipc object pointer given an id number. There are two sets of function: One set verifies the sequence counter part of the id number, other functions do not check the sequence counter. The standard for function names in ipc/util.c is - ..._check() f

[PATCH 1/6] ipc: reorganize initialization of kern_ipc_perm.id

2018-07-04 Thread Manfred Spraul
ipc_addid() initializes kern_ipc_perm.id after having called ipc_idr_alloc(). Thus a parallel semop() or msgrcv() that uses ipc_obtain_object_idr() may see an uninitialized value. The patch moves all accesses to kern_ipc_perm.id under the spin_lock(). The issues is related to the finding of syzb

[PATCH 0/5] ipc: cleanups & bugfixes

2018-07-04 Thread Manfred Spraul
Hi, Dmitry convinced me that I should properly review the initialization of new ipc objects, and I found another issue. The series corrects 3 issues with ipc_addid(), and also renames two functions and corrects a wrong comment. 0001-ipc-reorganize-initialization-of-kern_ipc_perm.id: Acce

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-07-04 Thread Tony Lindgren
* Faiz Abbas [180704 13:37]: > After taking a second look at this thread, I don't see anything big to > be modified. > > We both agree that "reset status bit in sysconfig register" is the quirk > case which can be added once such an IP is discovered in ti-sysc. Yes agreed. > All I need to chang

Re: [PATCH v7 1/4] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

2018-07-04 Thread Lee Jones
On Wed, 04 Jul 2018, Enric Balletbo Serra wrote: > Missatge de Dmitry Torokhov del dia dc., 4 > de jul. 2018 a les 17:10: > > > > Hi Enric, > > > > On Tue, Jun 26, 2018 at 11:06:33AM +0200, Enric Balletbo Serra wrote: > > > Hi Matti, > > > > > > Thanks for the patch, a few comments below, some ar

Re: ltp/read_all_sys (read_all -d /sys -q -r 10) cause system panic with kernel-4.18.0-rc1

2018-07-04 Thread Li Wang
Hi there, The problem is still in kernel-v4.18-rc3. Panic was caused by command: # ./read_all -d /sys -q -r 10 Or, you can try the full steps to reproduce: # git clone https://github.com/linux-test-project/ltp/ # cd ltp # ./build.sh # cd ../ltp-install # ./runltp -s read_all_sys dmesg log

Re: [lkp-robot] [fs] 5c6de586e8: vm-scalability.throughput +12.4% improvement (from reorganizing struct inode?)

2018-07-04 Thread Amir Goldstein
On Thu, Jul 5, 2018 at 4:37 AM, Linus Torvalds wrote: > On Wed, Jul 4, 2018 at 4:34 PM Al Viro wrote: >> >> I don't hate that patch, but there are immediate followup questions - e.g. >> how sensitive is relative position of i_lock/i_hash/i_sb? Those are *not* >> close to each other. E.g. what h

Re: [PATCH] gpiolib: Defer on non-DT find_chip_by_name() failure

2018-07-04 Thread Lee Jones
On Wed, 04 Jul 2018, Janusz Krzysztofik wrote: > On Tuesday, July 3, 2018 7:31:41 PM CEST Boris Brezillon wrote: > > Hi Janusz, > > > > On Tue, 3 Jul 2018 19:26:35 +0200 > > > > Janusz Krzysztofik wrote: > > > Avoid replication of error code conversion in non-DT GPIO consumers' > > > code by r

Re: [PATCH] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-07-04 Thread Yang, Bin
Sorry for the misunderstanding. I mean I will improve the check loop in patch v2. I just submitted patch v2. Thanks in advance for your kind review. Thanks, Bin On 05/07/2018, 1:30 PM, "Thomas Gleixner" wrote: Sorry, I don't see in which way your patch would improve the check loop.

Re: include architecture Kconfig files from top-level Kconfig

2018-07-04 Thread Masahiro Yamada
Hi. 2018-07-02 23:47 GMT+09:00 Christoph Hellwig : > Hi Masahiro, > > what do you think about the series below, which moves the includes > of all the architecture independ Kconfig files to the top-level > Kconfig instead of duplicating the includes in all architectures? > > Note that this only han

[PATCH v2] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-07-04 Thread Bin Yang
When changing a 4K page attr inside 1G/2M large page range, __change_page_attr() will call try_preserve_large_page() to decide to split the big page or not. And try_preserve_large_page() will call static_protections() to check all 4K pages inside the large page range one by one. The check loop is v

Re: [PATCH 2/5] Kconfig: consolidate the "Kernel hacking menu"

2018-07-04 Thread Masahiro Yamada
2018-07-02 23:47 GMT+09:00 Christoph Hellwig : > Move the source of lib/Kconfig.debug and arch/$(ARCH)/Kconfig.debug to > the top-level Kconfig. For two architectures that means moving their > arch-specific symbols in that menu into a new arch Kconfig.debug file, > and for a few more creating a du

Re: [PATCH 1/5] kconfig: include common Kconfig files from top-level Kconfig

2018-07-04 Thread Masahiro Yamada
2018-07-04 1:11 GMT+09:00 Randy Dunlap : > On 07/03/18 06:36, Christoph Hellwig wrote: >> On Mon, Jul 02, 2018 at 01:08:16PM -0700, Randy Dunlap wrote: I would prefer to have init/Kconfig before arch/$(SRCARCH)/Kconfig. >>> >>> Ugh, that won't get this set correctly on x86_64: >>> CONFIG_PGTAB

Re: [PATCH V2 05/19] csky: System Call

2018-07-04 Thread Guo Ren
On Wed, Jul 04, 2018 at 11:04:37PM +0200, Arnd Bergmann wrote: > Right, I do understand what it's used for, my point was that you > don't really need a separate system call number for it, just redirect > the entry point using the same trick that nds32 has in > arch/nds32/kernel/syscall_table.c: >

Re: general protection fault in vmx_vcpu_run

2018-07-04 Thread Dmitry Vyukov
On Wed, Jul 4, 2018 at 9:31 PM, Raslan, KarimAllah wrote: > Dmitry, > > Can you share the host kernel version? > > I can not reproduce any of these crash signatures and I think it's > really a nested virtualization bug. So I will need the exact host > kernel version as well. > > I am currently get

Re: [PATCH] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-07-04 Thread Thomas Gleixner
On Thu, 5 Jul 2018, Yang, Bin wrote: Please do not top post. > This is what my new patch tries to improve. > On 04/07/2018, 10:02 PM, "Thomas Gleixner" wrote: > > The check loop itself is stupid as well. Instead of looping in 4K steps > the thing can be rewritten to check for overl

Re: [PATCH] gpiolib: Defer on non-DT find_chip_by_name() failure

2018-07-04 Thread Uwe Kleine-König
Hello, On Wed, Jul 04, 2018 at 09:13:42PM +0200, Janusz Krzysztofik wrote: > On Tuesday, July 3, 2018 7:31:41 PM CEST Boris Brezillon wrote: > > Hi Janusz, > > > > On Tue, 3 Jul 2018 19:26:35 +0200 > > > > Janusz Krzysztofik wrote: > > > Avoid replication of error code conversion in non-DT GPI

[PATCH] zlib: remove fall through warnings

2018-07-04 Thread Corentin Labbe
This patch remove all following fall through warnings by adding /* fall through */ markers. Note that we cannot add "__attribute__ ((fallthrough));" due to it is GCC7 only arch/arm/boot/compressed/../../../../lib/zlib_inflate/inflate.c:384:25: warning: this statement may fall through [-Wimplicit-f

[PATCH v3 02/11] hugetlb: Introduce generic version of hugetlb_free_pgd_range

2018-07-04 Thread Alexandre Ghiti
arm, arm64, mips, parisc, sh, x86 architectures use the same version of hugetlb_free_pgd_range, so move this generic implementation into asm-generic/hugetlb.h. Signed-off-by: Alexandre Ghiti --- arch/arm/include/asm/hugetlb.h | 12 ++-- arch/arm64/include/asm/hugetlb.h | 10 ---

linux-next: build failure after merge of the ida tree

2018-07-04 Thread Stephen Rothwell
Hi Matthew, After merging the ida tree, today's linux-next build (x86_64 allmodconfig) failed like this: lib/test_xarray.c: In function 'xa_alloc_value': lib/test_xarray.c:39:16: error: implicit declaration of function 'xa_alloc'; did you mean 'ida_alloc'? [-Werror=implicit-function-declaration]

[PATCH 1/2] dt-bindings: thermal: Allow multiple devices to share cooling map

2018-07-04 Thread Viresh Kumar
Allow cooling devices sharing same trip point with same contribution value to share the cooling map as well. Otherwise the same information will be duplicated for each device sharing the trip point. Signed-off-by: Viresh Kumar --- Documentation/devicetree/bindings/thermal/thermal.txt | 11 +++---

[PATCH 0/2] dt: thermal: Fix broken cooling-maps

2018-07-04 Thread Viresh Kumar
Hi, This is an attempt to fix the broken or partially defined DT bindings for cooling-maps. We should list every device that participates in cooling down at a certain trip point, instead of just the first in the list as that depends on certain ordering of events to work properly. The first patch

[PATCH 2/2] arm64: dts: hi6220: Add all CPUs in cooling maps

2018-07-04 Thread Viresh Kumar
Each CPU can (and does) participate in cooling down the system but the DT only captures the CPU0 in the cooling maps. Things work by chance as under normal circumstances its the CPU0 which is used by the operating systems to probe the cooling devices. But as soon as that ordering changes and any ot

Re: [PATCH V2 18/19] clocksource: add C-SKY clocksource drivers

2018-07-04 Thread Guo Ren
On Wed, Jul 04, 2018 at 04:35:43PM +0200, Thomas Gleixner wrote: > On Wed, 4 Jul 2018, Guo Ren wrote: > > On Tue, Jul 03, 2018 at 11:39:05AM +0200, Thomas Gleixner wrote: > > > > +static inline u64 get_ccvr(void) > > > > +{ > > > > + u32 lo, hi, t; > > > > + > > > > + do { > > > > +

Re: linux-next: build warning after merge of the slave-dma tree

2018-07-04 Thread Vinod
Hi Stephen, On 05-07-18, 12:47, Stephen Rothwell wrote: > On Wed, 4 Jul 2018 09:50:17 +0530 Vinod wrote: > > On 04-07-18, 13:30, Stephen Rothwell wrote: > > > > > > After merging the slave-dma tree, today's linux-next build (x86_64 > > > allmodconfig) produced this warning: > > > > > > WARNING:

[PATCH v2] w1: fix w1_ds2438 documentation

2018-07-04 Thread Mariusz Bialonczyk
The previous documentation was wrongly stating about the order of magnitude of CONVERT_V result files contents (vad, vdd). This commit is correcting this. Reported-by: Adam Stolarczyk Signed-off-by: Mariusz Bialonczyk --- Resending as V2 because it was malformed by mail mail app recently. I als

KASAN: stack-out-of-bounds Read in __run_timers

2018-07-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2bdea157b999 Merge branch 'sctp-fully-support-for-dscp-and.. git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=15438ad040 kernel config: https://syzkaller.appspot.com/x/.config?x=f62553dc846b0692 da

KASAN: stack-out-of-bounds Read in move_expired_inodes

2018-07-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:2bdea157b999 Merge branch 'sctp-fully-support-for-dscp-and.. git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=17d35aa440 kernel config: https://syzkaller.appspot.com/x/.config?x=f62553dc846b0692 da

Re: XArray -next inclusion request

2018-07-04 Thread Stephen Rothwell
Hi Willy, On Wed, 4 Jul 2018 15:54:31 -0700 Matthew Wilcox wrote: > > I have some additional patches for the IDA that I'd like to > send to Linus as a separate pull request. Unfortunately, they conflict with > the XArray patches, so I've done them as a separate branch in the same tree: > > git:

linux-next: build failure after merge of the ida tree

2018-07-04 Thread Stephen Rothwell
Hi all, After merging the ida tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: In file included from include/linux/kernel.h:14:0, from include/asm-generic/bug.h:18, from arch/powerpc/include/asm/bug.h:128, from include/l

Re: [PATCH] tpm: Fix NULL pointer dereference in tpm_transmit()

2018-07-04 Thread S, Shirish
On 7/4/2018 10:43 PM, Jarkko Sakkinen wrote: On Wed, Jul 04, 2018 at 02:33:40PM +0530, Shirish S wrote: During system shutdown, tpm_class_shutdown() when called with TPM_CHIP_FLAG_TPM2 flag set, makes chip->ops NULL. However tpm_chip_unregister() called later in shutdown sequence tries to ac

[RESEND PATCH 1/2] Makefile: .PHONY is not a variable, but PHONY is

2018-07-04 Thread Masahiro Yamada
From: Ulf Magnusson .PHONY is a target, not a variable. Signed-off-by: Ulf Magnusson Signed-off-by: Masahiro Yamada --- Ulf sent this a long time ago. https://patchwork.kernel.org/patch/7111711/ Unfortunately, it was lost for some reason. I am resending to apply it if Ulf does not mind it.

[RESEND PATCH 2/2] kbuild: remove duplicated comments about PHONY

2018-07-04 Thread Masahiro Yamada
The comment is the same as in the top-level Makefile. Also, the comments contain typos: - the .PHONY variable -> the PHONY variable - se we can ...-> so we can ... Instead of fixing the typos, just remove the duplicated comments. Signed-off-by: Masahiro Yamada --- scripts/Makef

Re: [PATCH V2 18/19] clocksource: add C-SKY clocksource drivers

2018-07-04 Thread Guo Ren
On Wed, Jul 04, 2018 at 07:05:05PM +0200, Daniel Lezcano wrote: > > create mode 100644 drivers/clocksource/timer-csky-v1.c > > create mode 100644 drivers/clocksource/timer-nationalchip.c > > Provide two separates patches, one for each timer. Ok. > > +obj-$(CONFIG_CSKY) += timer-

Re: [PATCH 1/1] ASoC: rsnd: cmd: Add missing newline to debug message

2018-07-04 Thread Kuninori Morimoto
Hi > From: Andrew Gabbasov > > To comply with the style of all kernel messages, add newline > to the end of every message. > > Fixes: 70fb10529f61 ("ASoC: rsnd: add MIX (Mixer) support") > Signed-off-by: Andrew Gabbasov > Signed-off-by: Jiada Wang > --- Acked-by: Kuninori Morimoto Best r

[RFC PATCH] watchdog: sp805: Add clock-frequency property

2018-07-04 Thread Srinath Mannam
When using ACPI node, binding clock devices are not available as device tree, So clock-frequency property given in _DSD object of ACPI device is used to calculate Watchdog rate. Signed-off-by: Srinath Mannam --- drivers/watchdog/sp805_wdt.c | 29 - 1 file changed, 24

RE: [PATCH 1/3] mmc: sdhci-esdhc-imx: get rid of support_vsel

2018-07-04 Thread A.s. Dong
> -Original Message- > From: Stefan Agner [mailto:ste...@agner.ch] > Sent: Thursday, June 28, 2018 4:13 PM > To: adrian.hun...@intel.com; ulf.hans...@linaro.org > Cc: Fabio Estevam ; Bough Chen > ; A.s. Dong ; > mich...@amarulasolutions.com; rmk+ker...@armlinux.org.uk; linux- > m...@vger.ke

Re: [PATCH 0/3] pinctrl: meson-g12a: add pinctrl driver support

2018-07-04 Thread Yixun Lan
HI Neil On 07/04/18 22:57, Neil Armstrong wrote: > Hi Yixun, > > On 05/07/2018 00:45, Yixun Lan wrote: >> This patch series try to add pinctrl driver support for >> the Meson-G12A SoC. > > Thanks for submitting these patches. > > Can you explicit this patchset with more details on the G12A SoC

[PATCH] kbuild: do not drop -I without parameter

2018-07-04 Thread Masahiro Yamada
The comment line for addtree says "skip if -I has no parameter". What it actually does is "drop if -I has no parameter". For example, if you have the compiler flag '-I foo' (a space between), it will be converted to 'foo'. This completely changes the meaning. What we want is, "do nothing" for -

[PATCH] kbuild: document the KBUILD_KCONFIG env. variable

2018-07-04 Thread Randy Dunlap
From: Randy Dunlap Add usage info for the Kbuild environment variable KBUILD_KCONFIG. Signed-off-by: Randy Dunlap --- Documentation/kbuild/kbuild.txt |5 + 1 file changed, 5 insertions(+) --- lnx-418-rc3.orig/Documentation/kbuild/kbuild.txt +++ lnx-418-rc3/Documentation/kbuild/kbuild.

[PATCH] kconfig: handle format string before calling conf_message_callback()

2018-07-04 Thread Masahiro Yamada
As you see in mconf.c and nconf.c, conf_message_callback() hooks are likely to end up with the boilerplate of vsnprintf(). Process the string format before calling conf_message_callback() so that it receives a simple string. Signed-off-by: Masahiro Yamada --- scripts/kconfig/confdata.c | 17 +

Re: linux-next: build warning after merge of the slave-dma tree

2018-07-04 Thread Stephen Rothwell
'...' before string constant MODULE_LICENSE("GPL v2"); ^~~~ presumable a missing include of module.h ... I have gone back to the slave-dma tree from next-20180704 for today. -- Cheers, Stephen Rothwell pgpfIhizur9j_.pgp Description: OpenPGP digital signature

[PATCH v3 02/12] kconfig: split out helpers to check file/directory, create directory

2018-07-04 Thread Masahiro Yamada
Split out helpers: is_file() - check if the given path exists and it is a regular file is_dir() - check if the given path exists and it is a directory mkdir_p() - create the parent directories of the given path These helpers will be reused in later commits. Signed-off-by: Masahiro Yamada ---

[PATCH v3 00/12] kbuild/kconfig: do not update config during installation

2018-07-04 Thread Masahiro Yamada
The main motivation of this patch series is to suppress the syncconfig during running installation targets. V1 consisted of only two patches: https://patchwork.kernel.org/patch/10468105/ https://patchwork.kernel.org/patch/10468103/ I noticed that installation targets would continue running

[PATCH v3 04/12] kconfig: create directories needed for syncconfig by itself

2018-07-04 Thread Masahiro Yamada
'make syncconfig' creates some files such as include/config/auto.conf, include/generate/autoconf.h, etc. but the necessary directory creation relies on scripts/kconfig/Makefile. To make Kconfig self-contained, create directories as needed in conf_write_autoconf(). This change allows scripts/kconf

[PATCH v3 06/12] kconfig: allow all config targets to write auto.conf if missing

2018-07-04 Thread Masahiro Yamada
Currently, only syncconfig creates or updates include/config/auto.conf and some other files. Other config targets create or update only the .config file. When you configure and build the kernel from a pristine source tree, any config target is followed by syncconfig in the build stage since inclu

[PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-04 Thread Masahiro Yamada
syncconfig updates the .config only when sym_change_count > 0, i.e. any change in config symbols has been detected. Not only symbols but also comments are contained in the .config file. If only comments are updated, they are not fed back to the .config, then the stale comments are left-over. Of c

[PATCH v3 01/12] kconfig: rename file_write_dep and move it to confdata.c

2018-07-04 Thread Masahiro Yamada
file_write_dep() is called only from conf_write_autoconf(). Move it from util.c to confdata.c to make it static. Also, rename it to conf_write_dep() since it should belong to the group of conf_write* functions. Signed-off-by: Masahiro Yamada --- scripts/kconfig/confdata.c | 31 +

[PATCH v3 03/12] kconfig: remove unneeded directory generation from local*config

2018-07-04 Thread Masahiro Yamada
Commit 17263baf958b ("kconfig: Create include/generated for localmodconfig") added the 'mkdir' line because local{yes,mod}config ran streamline_config.pl followed by silentoldconfig at that time. Since commit 81d2bc227305 ("kconfig: invoke oldconfig instead of silentoldconfig from local*config"),

Re: [PATCH v3] media: dvb-frontends: add Socionext SC1501A ISDB-S/T demodulator driver

2018-07-04 Thread Mauro Carvalho Chehab
Em Thu, 5 Jul 2018 10:58:42 +0900 "Katsuhiro Suzuki" escreveu: > Hi Mauro, > > > -Original Message- > > From: Mauro Carvalho Chehab > > Sent: Thursday, July 5, 2018 1:58 AM > > To: Suzuki, Katsuhiro/鈴木 勝博 > > Cc: linux-me...@vger.kernel.org; Masami Hiramatsu > ; > > Jassi Brar ; > >

[PATCH v3 07/12] kbuild: use 'include' directive to load auto.conf from top Makefile

2018-07-04 Thread Masahiro Yamada
When you build targets that require the kernel configuration, dot-config is set to 1, then the top-level Makefile includes auto.conf. However, Make considers its inclusion is optional because the '-include' directive is used here. If a necessary configuration file is missing for the external modu

[PATCH v3 11/12] kbuild: remove auto.conf and tristate.conf from prerequisites

2018-07-04 Thread Masahiro Yamada
The top-level Makefile adds include/config/auto.conf as prerequisites of 'scripts', 'prepare1', etc. They were needed to terminate the build when include/config/auto.conf is missing. Now that the inclusion of include/config/auto.conf is mandatory in the top-level Makefile if dot-config is 1 (Note

[PATCH v3 10/12] kbuild: do not update config for 'make kernelrelease'

2018-07-04 Thread Masahiro Yamada
'make kernelrelease' depends on CONFIG_LOCALVERSION(_AUTO), but for the same reason as install targets, we do not want to update the configuration just for printing the kernelrelease string. This is likely to happen when you compiled the kernel with CROSS_COMPILE, but forget to pass it to 'make ke

[PATCH v3 12/12] kbuild: replace include/config/%.conf with include/config/auto.conf

2018-07-04 Thread Masahiro Yamada
Now that include/config/tristate.conf does not appear in the top-level Makefile. Replace the pattern rule with include/config/auto.conf . Signed-off-by: Masahiro Yamada --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c6ab38c4..58bd78b

[PATCH v3 08/12] kbuild: add .DELETE_ON_ERROR special target

2018-07-04 Thread Masahiro Yamada
If Make gets a fatal signal while a shell is executing, it may delete the target file that the recipe was supposed to update. This is needed to make sure that it is remade from scratch when Make is next run; if Make is interrupted after the recipe has begun to write the target file, it results in

[PATCH v3 09/12] kbuild: do not update config when running install targets

2018-07-04 Thread Masahiro Yamada
"make syncconfig" is automatically invoked when any of the following happens: - .config is updated - any of Kconfig files is updated - any of environment variables referenced in Kconfig is changed Then, it updates configuration files such as include/config/auto.conf include/generated/autoconf.

RE: [PATCH v2] mmc: sdhci-esdhc-imx: allow 1.8V modes without 100/200MHz pinctrl states

2018-07-04 Thread A.s. Dong
> -Original Message- > From: Stefan Agner [mailto:ste...@agner.ch] > Sent: Wednesday, July 4, 2018 11:08 PM > To: adrian.hun...@intel.com; ulf.hans...@linaro.org > Cc: Fabio Estevam ; Bough Chen > ; A.s. Dong ; > mich...@amarulasolutions.com; rmk+ker...@armlinux.org.uk; linux- > m...@vger.k

Re: [PATCH] kbuild: delete INSTALL_FW_PATH from kbuild documentation

2018-07-04 Thread Randy Dunlap
nel firmware") >> >> Signed-off-by: Randy Dunlap >> Cc: sta...@vger.kernel.org # 4.14 and later >> Cc: Greg Kroah-Hartman >> --- >> Documentation/kbuild/kbuild.txt |9 ----- >> 1 file changed, 9 deletions(-) >> >> --- linux-next

[PATCH 1/1] ASoC: rsnd: cmd: Add missing newline to debug message

2018-07-04 Thread jiada_wang
From: Andrew Gabbasov To comply with the style of all kernel messages, add newline to the end of every message. Fixes: 70fb10529f61 ("ASoC: rsnd: add MIX (Mixer) support") Signed-off-by: Andrew Gabbasov Signed-off-by: Jiada Wang --- sound/soc/sh/rcar/cmd.c | 2 +- 1 file changed, 1 insertion(

[PATCH 3/3] drivers/speakup: kobjects : Fixed Coding issues -Debugging

2018-07-04 Thread Tamir Suliman
Updated printk() of i18n messages to include KERN_INFO facility level to improve debuggin. then later noticed that I forgot to add a space on printk. Signed-off-by: Tamir Suliman --- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s

RE: [PATCH] Use short unix-style option instead of --longname.

2018-07-04 Thread yamada.masahiro
Hi. > -Original Message- > From: Rob Landley [mailto:r...@landley.net] > Sent: Thursday, July 05, 2018 4:06 AM > To: triv...@kernel.org; Yamada, Masahiro/山田 真弘 > ; Kees Cook ; Ulf > Magnusson > Subject: [PATCH] Use short unix-style option instead of --longname. > > From: Rob Landley >

Re: [PATCH] kbuild: delete INSTALL_FW_PATH from kbuild documentation

2018-07-04 Thread Masahiro Yamada
; --- > Documentation/kbuild/kbuild.txt |9 ----- > 1 file changed, 9 deletions(-) > > --- linux-next-20180704.orig/Documentation/kbuild/kbuild.txt > +++ linux-next-20180704/Documentation/kbuild/kbuild.txt > @@ -149,15 +149,6 @@ stripped after they are installed. If I &g

Re: [RESEND PATCH] dt-bindings: input: Add common keyboard document bindings

2018-07-04 Thread Chen Zhong
On Wed, 2018-07-04 at 15:25 +, Dmitry Torokhov wrote: > On Fri, Jun 22, 2018 at 02:39:55PM +0800, Chen Zhong wrote: > > Hi Dmitry, > > > > The other patches in the series to add mediatek pmic keys support are > > now available in 4.18-rc1, but this patch seems not being merged. > > > > git:

[PATCH v7 0/5] Add system timer driver for Mediatek SoCs

2018-07-04 Thread Stanley Chu
Changes since v6: - Remove duplicated variable gpt_sched_reg. - Remove log for mtk_syst_init(). Changes since v5: - Optimize driver and remove redundant register operations. - Docuement registers. - Fix system timer base address. Changes since v4: - Simplify dt-bindings. - Add error handling for

[PATCH v7 2/5] clocksource/drivers/timer-mediatek: Rename mtk_timer to timer-mediatek

2018-07-04 Thread Stanley Chu
Rename mtk_timer to timer-mediatek to apply new naming convention in clocksource folder. Signed-off-by: Stanley Chu --- drivers/clocksource/Makefile |2 +- drivers/clocksource/mtk_timer.c | 268 -- drivers/clocksource/timer-mediatek.c | 268

Re: [BUG] Serial/dma stall/failure after "dmaengine: fsl-edma: extract common fsl-edma code (no changes in behavior intended)"

2018-07-04 Thread Randy Dunlap
x A5, serial configured > with DMA) on Iris Carrier. > > Commit found with bisect: > git bisect start > # bad: [bce40927669338cc4a361fc97d46bf650573ce5c] Add linux-next > specific files for 20180704 > git bisect bad bce40927669338cc4a361fc97d46bf650573ce5c > # good: [410da1e12

[PATCH v7 4/5] clocksource/drivers/timer-mediatek: Convert the driver to timer-of

2018-07-04 Thread Stanley Chu
Convert the driver to use the timer_of helpers. This allows to remove custom proprietary structure, factors out and simplifies the code. Signed-off-by: Stanley Chu --- drivers/clocksource/timer-mediatek.c | 205 +- 1 file changed, 80 insertions(+), 125 deletions(

[PATCH v7 5/5] clocksource/drivers/timer-mediatek: Add support for system timer

2018-07-04 Thread Stanley Chu
This patch adds a new "System Timer" on the Mediatek SoCs. The System Timer is introduced as an always-on timer being clockevent device for tick-broadcasting. For clock, it is driven by 13 MHz system clock. The implementation uses the system clock with no clock source divider. For interrupt, the

[PATCH v7 3/5] clocksource/drivers/timer-mediatek: Use specific prefix for GPT

2018-07-04 Thread Stanley Chu
Use specific prefix to specify the name of supported timer hardware: "General Purpose Timer (GPT)". Signed-off-by: Stanley Chu --- drivers/clocksource/timer-mediatek.c | 157 +- 1 file changed, 80 insertions(+), 77 deletions(-) diff --git a/drivers/clocksource/t

[PATCH v7 1/5] clocksource/drivers/timer-mediatek: Add system timer bindings

2018-07-04 Thread Stanley Chu
This patch fixes bindings of existed "General Purpose Timer", and then add bindings of new "System Timer" on Mediatek SoCs. Signed-off-by: Stanley Chu --- .../bindings/timer/mediatek,mtk-timer.txt | 36 1 file changed, 21 insertions(+), 15 deletions(-) diff --git

Re: [PATCH] x86/mm: fix cpu stuck issue in __change_page_attr_set_clr

2018-07-04 Thread Yang, Bin
This is what my new patch tries to improve. On 04/07/2018, 10:02 PM, "Thomas Gleixner" wrote: The check loop itself is stupid as well. Instead of looping in 4K steps the thing can be rewritten to check for overlapping ranges and then check explicitely for those. If there is no

Re: [PATCH v6 5/5] clocksource/drivers/timer-mediatek: Add support for system timer

2018-07-04 Thread Stanley Chu
On Thu, 2018-07-05 at 02:13 +0200, Daniel Lezcano wrote: > On 04/07/2018 16:50, Stanley Chu wrote: Hi Daniel, Well remove duplicate one in v7. > > + > > +static void __iomem *gpt_sched_reg __read_mostly; > > duplicate 'gpt_sched_reg' variable. > > > > +static void mtk_syst_ack_irq(struct time

  1   2   3   4   5   6   7   >