linux-next: Signed-off-by missing for commits in the vfs tree

2018-06-15 Thread Stephen Rothwell
Hi Al, Commits b6cfbecafbd2 ("afs: Handle CONFIG_PROC_FS=n") 0aac4bce4b49 ("afs: Show all of a server's addresses in /proc/fs/afs/servers") are missing a Signed-off-by from their committer. -- Cheers, Stephen Rothwell pgpYdVPwTolJN.pgp Description: OpenPGP digital signature

WARNING: suspicious RCU usage in pid_task

2018-06-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:f0dc7f9c6dd9 Merge git://git.kernel.org/pub/scm/linux/kern.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=124b698f80 kernel config: https://syzkaller.appspot.com/x/.config?x=fa9c20c48788d1c1 da

Re: [PATCH] x86/pti: don't report XenPV as vulnerable

2018-06-15 Thread Juergen Gross
On 15/06/18 23:10, Jiri Kosina wrote: > On Fri, 15 Jun 2018, Juergen Gross wrote: > >> Like it is possible to switch off PTI in the kernel it is possible to do >> the same with XPTI in the hypervisor (it is even possible to disable >> XPTI for dom0 only). >> >> In case XPTI is disabled for the c

Re: [PATCH] staging: rtl8192u: fix line over 80 characters

2018-06-15 Thread Julia Lawall
On Sat, 16 Jun 2018, Hyunil Kim wrote: > *fix checkpatch.pl warnings: > WARNING: line over 80 characters Describe what you do and why, rather than just saying "Fix". Often something can be fixed in multiple ways. julia > > Signed-off-by: Hyunil Kim > --- > drivers/staging/rtl8192u/r8192U

[PATCH v2] staging: rtl8712: Adjust if statements to reduce indentation level

2018-06-15 Thread Joonhwan Kim
Merge two condition of if statements in r8712_surveydone_event_callback() Signed-off-by: Joonhwan Kim --- v2: fix my name without period in email header drivers/staging/rtl8712/rtl871x_mlme.c | 51 +- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/driver

[PATCH] staging: rtl8192u: fix line over 80 characters

2018-06-15 Thread Hyunil Kim
*fix checkpatch.pl warnings: WARNING: line over 80 characters Signed-off-by: Hyunil Kim --- drivers/staging/rtl8192u/r8192U_core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 74c58

[PATCH] staging: rtl8712: Adjust if statements to reduce indentation level

2018-06-15 Thread JoonHwan.Kim
Merge two condition of if statements in r8712_surveydone_event_callback() Signed-off-by: Joonhwan Kim --- drivers/staging/rtl8712/rtl871x_mlme.c | 51 +- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/stag

Re: OpenAFS module libafs.ko uses GPL-only symbol '__put_devmap_managed_page'

2018-06-15 Thread John Hubbard
On 06/15/2018 10:22 PM, Dan Williams wrote: > On Fri, Jun 15, 2018 at 9:43 PM, John Hubbard wrote: >> On 06/13/2018 12:51 PM, Dan Williams wrote: >>> [ adding Andrew, Christoph, and linux-mm ] >>> >>> On Wed, Jun 13, 2018 at 12:33 PM, Joe Gorse wrote: [snip] P.S. The build failure, for

Re: OpenAFS module libafs.ko uses GPL-only symbol '__put_devmap_managed_page'

2018-06-15 Thread Dan Williams
On Fri, Jun 15, 2018 at 9:43 PM, John Hubbard wrote: > On 06/13/2018 12:51 PM, Dan Williams wrote: >> [ adding Andrew, Christoph, and linux-mm ] >> >> On Wed, Jun 13, 2018 at 12:33 PM, Joe Gorse wrote: >>> Greetings, >>> >>> Please CC answers & comments to this email. Thanks! =) >>> >>> Our build

Re: [RFC PATCH 5/5] fsi/scom: Major overhaul

2018-06-15 Thread Joel Stanley
On 12 June 2018 at 14:49, Benjamin Herrenschmidt wrote: > This was too hard to split ... this adds a number of features > to the SCOM user interface: > > - Support for indirect SCOMs > > - read()/write() interface now handle errors and retries > > - New ioctl() "raw" interface for use by debugg

Re: OpenAFS module libafs.ko uses GPL-only symbol '__put_devmap_managed_page'

2018-06-15 Thread John Hubbard
On 06/13/2018 12:51 PM, Dan Williams wrote: > [ adding Andrew, Christoph, and linux-mm ] > > On Wed, Jun 13, 2018 at 12:33 PM, Joe Gorse wrote: >> Greetings, >> >> Please CC answers & comments to this email. Thanks! =) >> >> Our build is breaking as of >> commit e7638488434415aa478e78435cac8f0365

Re: [PATCH 1/2] staging: rtl8192e: remove brace for single statement

2018-06-15 Thread 김현일
Thanks greg. Let me check and send again regards Hyunil Kim On Fri, Jun 15, 2018 at 8:08 PM, Greg KH wrote: > On Sat, Jun 09, 2018 at 03:05:56PM +0900, thtlwlsmsgk...@gmail.com wrote: >> * fix checkpatch.pl warning: >> WARNING: braces { are not necessary for single statement blocks >> >> Signed

Re: [PATCH 2/2] staging: rtl8192e: fix line over 80 characters

2018-06-15 Thread 김현일
Hi Joe. Thanks to your notice. i will check again. Regards, Hyunil Kim. On Sat, Jun 9, 2018 at 3:45 PM, Joe Perches wrote: > On Sat, 2018-06-09 at 15:07 +0900, thtlwlsmsgk...@gmail.com wrote: >> *fix checkpatch.pl warnings: >> WARNING: line over 80 characters > > Consider using a temporary for

Re: [PATCH 1/2] staging: mt7621-spi: change indentation from space to tab

2018-06-15 Thread 김준환
Hi greg, I didn't noticed that. :( Thank you for your attention! Sincerely, JoonHwan 2018-06-15 20:02 GMT+09:00 Greg KH : > On Sat, Jun 09, 2018 at 03:03:27PM +0900, JoonHwan.Kim wrote: >> * fix checkpatch.pl error: >> ERROR: code indent should use tabs where possible >> >> Signed-off-by: Joon

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-15 Thread kbuild test robot
Hi Matthias, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kvm/linux-next] [also build test WARNING on v4.17 next-20180615] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH v2] nds32: Fix build error caused by configuration flag rename

2018-06-15 Thread Greentime Hu
James Hogan 於 2018年6月15日 週五 下午8:34寫道: > > On Fri, Jun 15, 2018 at 02:12:58PM +0800, Greentime Hu wrote: > > Thank you James and Guenter. > > Should I pick it in my tree? It will be ok to put in your tree. :) > > > > Acked-by: Greentime Hu > > I think your tree makes most sense for this patch, sin

[CFT][PATCH] proc: Simplify and fix proc by removing the kernel mount

2018-06-15 Thread Eric W. Biederman
Today there are three users of proc_mnt. - The legacy sysctl system call implementation. - The uml mconsole driver. - The process cleanup function proc_flush_task. The first two are slow path and for the sysctl code there is even a case for removing it. A new wrapper file_open_proc to mount an

[RFC PATCH 4/8] cpuidle: Set up maximum umwait time and umwait states

2018-06-15 Thread Fenghua Yu
UMWAIT or TPAUSE called by user process makes processor to reside in a light-weight power/performance optimized state (C0.1 state) or an improved power/performance optimized state (C0.2 state). IA32_UMAIT_CONTROL MSR register control allows OS to set maximum umwait time and disable C0.2 on the pro

[RFC PATCH 8/8] selftests/x86: Self test for the APIs in lib_direct_store.h and lib_user_wait.h

2018-06-15 Thread Fenghua Yu
The self test checks APIs defined in arch/x86/include/uapi/asm/ lib_direct_store.h and arch/x86/include/uapi/asm/lib_user_wait.h Limited by testing environment, this test suit only tests simple cases. More test cases may be added later. Signed-off-by: Fenghua Yu --- tools/testing/selftests/x86/

[RFC PATCH 7/8] x86/lib_user_wait.h: Add APIs for user wait instructions

2018-06-15 Thread Fenghua Yu
A few new user wait instructions UMONITOR, UMWAIT, and TPAUSE are published in the latest Intel Instruction Set Extensions document. Define the APIs for user or kernel to use the instructions. If feature enabled GCC is available in the future, implementation of the APIs will be changed to call th

[RFC PATCH 6/8] x86/lib_direct_store.h: Add APIs for direct store instructions

2018-06-15 Thread Fenghua Yu
Direct store instructions MOVDIRI and MOVDIR64B are published in the latest Intel Instruction Set Extensions document. Define the APIs for user or kernel to use the instructions. If feature enabled GCC is available in the future, implementation of the APIs will be changed to call the intrinsic in

[RFC PATCH 5/8] x86/umwait.c: Add sysfs interface to show tsc_khz

2018-06-15 Thread Fenghua Yu
User wait process or any other process wants to know tsc frequency to convert seconds to tsc ticks. Kernel already gets tsc freqency in kernel internal variable tsc_khz. The sysfs interface /sys/devices/system/cpu/ user_mwait/tsc_khz exposes the internal variable tsc_khz in decimal to user. tsc_kh

[RFC PATCH 3/8] x86/cpufeatures: Enumerate UMONITOR, UMWAIT, and TPAUSE instructions

2018-06-15 Thread Fenghua Yu
UMONITOR, UMWAIT, and TPAUSE are a set of user wait instructions. UMONITOR arms address monitoring hardware using an address. A store to an address within the specified address range triggers the monitoring hardware to wake up the processor waiting in umwait. UMWAIT instructs the processor to ent

[RFC PATCH 0/8] x86: Enable a few new instructions

2018-06-15 Thread Fenghua Yu
A few new instructions including direct stores (movdiri and movdir64b) and user wait (umwait, umonitor, and tpause) and IA32_MWAIT_CONTROL MSR to control umwait/umonitor/tpause behaviors will be available in Tremont and other future x86 processors. This patch set enumerates the instructions, adds

[RFC PATCH 1/8] x86/cpufeatures: Enumerate MOVDIRI instruction

2018-06-15 Thread Fenghua Yu
MOVDIRI moves doubleword or quadword from register to memory through direct store which is implemented by using write combining (WC) for writing data directly into memory without caching the data. Availability of the MOVDIRI instruction is indicated by the presence of the CPUID feature flag MOVDIR

[RFC PATCH 2/8] x86/cpufeatures: Enumerate MOVDIR64B instruction

2018-06-15 Thread Fenghua Yu
MOVDIR64B moves 64-bytes as direct-store with 64-bytes write atomicity. Direct store is implemented by using write combining (WC) for writing data directly into memory without caching the data. Availability of the MOVDIR64B instruction is indicated by the presence of the CPUID feature flag MOVDIR6

Re: [PATCH 01/11] staging: lustre: simplify use of interval-tree.

2018-06-15 Thread James Simmons
> Lustre has a private interval-tree implementation. This > implementation (inexplicably) refuses to insert an interval if an > identical interval already exists. It is OK with all sorts of > overlapping intervals, but identical intervals are rejected. I talked to Oleg about this since this ch

[git pull] vfs.git afs stuff from dhowells (mostly procfs followups)

2018-06-15 Thread Al Viro
Assorted AFS stuff - ended up in vfs.git since most of that consists of David's AFS-related followups to Christoph's procfs series. The following changes since commit 96362fb474bad694812c18cbc9943fe0f7e2ce31: isdn/gigaset: add back gigaset_procinfo assignment (2018-05-17 19:59:55 -0400)

[git pull] vfs.git - misc compat stuff

2018-06-15 Thread Al Viro
Some biarch patches - getting rid of assorted compat_alloc_user_space() (mis)uses. Not much in that area this cycle... The following changes since commit 4faa99965e027cc057c5145ce45fa772caa04e8d: fix io_destroy()/aio_complete() race (2018-05-23 22:53:22 -0400) are available in the git

Re: [PATCH] mm: skip invalid pages block at a time in zero_resv_unresv

2018-06-15 Thread Pavel Tatashin
On Fri, Jun 15, 2018 at 5:48 PM Andrew Morton wrote: > > On Fri, 15 Jun 2018 11:57:33 -0400 Pavel Tatashin > wrote: > > > The role of zero_resv_unavail() is to make sure that every struct page that > > is allocated but is not backed by memory that is accessible by kernel is > > zeroed and not in

[git pull] vfs.git - more aio followups

2018-06-15 Thread Al Viro
Assorted AIO followups and fixes. The following changes since commit 9a6d9a62e0fd4b9927c3124db0f25fc6b4fb6576: fs: aio ioprio use ioprio_check_cap ret val (2018-06-04 14:20:39 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git w

[PATCH v4] staging: rtl8192u: add error handling for usb_alloc_urb

2018-06-15 Thread Zhouyang Jia
When usb_alloc_urb fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling usb_alloc_urb. Signed-off-by: Zhouyang Jia --- v1->v2: - Fix memory leak. v2->v3: - Release memory in error path. v3->v4: - Use kcalloc instead of kmalloc_arr

[PATCH] sysfs: Fix internal_create_group() for named group updates

2018-06-15 Thread Rajat Jain
There are a couple of problems with named group updates in the code today: * sysfs_update_group() will always fail for a named group, because internal_create_group() will try to create a new sysfs directory unconditionally, which will ofcourse fail with -EEXIST. * We can leak the kernfs_node

Re: [PATCH v1 1/2] perf/core: Use sysctl to turn on/off dropping leaked kernel samples

2018-06-15 Thread Linus Torvalds
On Fri, Jun 15, 2018 at 8:36 PM Mark Rutland wrote: > > At least for sampling the GPRs, we could do something like below > unconditionally, which seems sufficient for my test cases. Ack. The PEBS case may need checking, but maybe PEBS doesn't even have this issue? Linus

Re: [PATCH v1 0/2] perf: Drop leaked kernel samples

2018-06-15 Thread Jin, Yao
On 6/16/2018 8:56 AM, Kyle Huey wrote: On Fri, Jun 15, 2018 at 5:50 PM, Jin, Yao wrote: Hi All, This patch raised many questions, I was prepared. :) I'd like to try another proposal that it adds a special flag in the returned perf_sample_data to indicate the perf binary that this sample is

Re: [PATCH v1 0/2] perf: Drop leaked kernel samples

2018-06-15 Thread Kyle Huey
On Fri, Jun 15, 2018 at 5:50 PM, Jin, Yao wrote: > Hi All, > > This patch raised many questions, I was prepared. :) > > I'd like to try another proposal that it adds a special flag in the returned > perf_sample_data to indicate the perf binary that this sample is a leaked > sample. > > For example

Re: [PATCH v1 0/2] perf: Drop leaked kernel samples

2018-06-15 Thread Jin, Yao
Hi All, This patch raised many questions, I was prepared. :) I'd like to try another proposal that it adds a special flag in the returned perf_sample_data to indicate the perf binary that this sample is a leaked sample. For example, create a new PERF_SAMPLE_RETURN_LEAKAGE in perf_event_samp

Re: [PATCH] mm/memblock: add missing include

2018-06-15 Thread Luck, Tony
This both compiles and boots on ia64. Builds OK on x86_64 with an Enterprise OS .config that includes: CONFIG_HAVE_MEMBLOCK=y CONFIG_NO_BOOTMEM=y -Tony diff --git a/mm/memblock.c b/mm/memblock.c index cc16d70b8333..0a54d488f767 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1225,6 +122

Re: [PATCH v3] staging: rtl8192u: add error handling for usb_alloc_urb

2018-06-15 Thread Kees Cook
On Fri, Jun 15, 2018 at 10:28 AM, Zhouyang Jia wrote: > When usb_alloc_urb fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling usb_alloc_urb. > > Signed-off-by: Zhouyang Jia > --- > v1->v2: > - Fix memory leak. > v2->v3: > -

Re: [patch] mm, oom: fix unnecessary killing of additional processes

2018-06-15 Thread David Rientjes
On Fri, 15 Jun 2018, Michal Hocko wrote: > > Signed-off-by: David Rientjes > > Nacked-by: Michal Hocko > as already explained elsewhere in this email thread. > I don't find this to be surprising, but I'm not sure that it actually matters if you won't fix a regression that you introduced. Te

Re: [PATCH] slub: fix failure when we delete and create a slab cache

2018-06-15 Thread Andrew Morton
On Fri, 15 Jun 2018 18:25:29 -0400 (EDT) Mikulas Patocka wrote: > In the kernel 4.17 I removed some code from dm-bufio that did slab cache > merging (21bb13276768) - both slab and slub support merging caches with > identical attributes, so dm-bufio now just calls kmem_cache_create and > relies o

[RFC v6 1/1] mconf: global i-search in menu structure

2018-06-15 Thread Dirk Gouders
This patch implements an i-search navigation concept for mconf based on an idea of Sam Ravnborg: * mconf now distinguishes if the focus is on the menu items or the buttons below it. * At startup focus is on the menu items and printable characters (details see below) entered are used to form a

[RFC v6 0/1] mconf: global i-search in menu structure

2018-06-15 Thread Dirk Gouders
Hello, version 6 of this RFC was mainly influenced by a discussion with Randy Dunlap about a patch for i-search in nconf. In that discussion I stated that it would be a lot of work to implement a global i-search but while thinking about that statement afterwards, I realized that most of the neede

Re: [PATCH] mm/memblock: add missing include

2018-06-15 Thread Tony Luck
On Fri, Jun 15, 2018 at 12:17 PM, Andrew Morton wrote: > Huh. How did that ever work. I guess it's either this: > > --- a/mm/Makefile~a > +++ a/mm/Makefile > @@ -45,6 +45,7 @@ obj-y += init-mm.o > > ifdef CONFIG_NO_BOOTMEM > obj-y += nobootmem.o > + obj-$(CONFIG_HAVE_ME

[PATCH] slub: fix failure when we delete and create a slab cache

2018-06-15 Thread Mikulas Patocka
In the kernel 4.17 I removed some code from dm-bufio that did slab cache merging (21bb13276768) - both slab and slub support merging caches with identical attributes, so dm-bufio now just calls kmem_cache_create and relies on implicit merging. This uncovered a bug in the slub subsystem - if we del

[PATCH] ASoC: tegra: fix device_node refcounting

2018-06-15 Thread Alexey Khoroshilov
tegra_rt5677_probe() gets a couple of device nodes with of_parse_phandle(), but there is no release of them. The patch adds the release to tegra_rt5677_remove() and to error handling paths in the probe. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshi

[PATCH] configfs: Use kvasprintf() instead of open-coding it

2018-06-15 Thread Bart Van Assche
Signed-off-by: Bart Van Assche --- fs/configfs/item.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/fs/configfs/item.c b/fs/configfs/item.c index 88f266efc09b..99d491cd01f9 100644 --- a/fs/configfs/item.c +++ b/fs/configfs/item.c @@ -64,7 +64,6 @@ s

Re: [PATCH v6 2/4] mfd: bd71837: Devicetree bindings for ROHM BD71837 PMIC

2018-06-15 Thread Rob Herring
On Fri, Jun 15, 2018 at 7:30 AM, Matti Vaittinen wrote: > Document devicetree bindings for ROHM BD71837 PMIC MFD. > > Signed-off-by: Matti Vaittinen > --- > .../devicetree/bindings/mfd/rohm,bd71837-pmic.txt | 67 > ++ > 1 file changed, 67 insertions(+) > create mode 100644

Re: [RFC PATCH 3/6] serial: 8250_omap: Add support for AM654 UART controller

2018-06-15 Thread Rob Herring
On Fri, Jun 15, 2018 at 11:17 AM, Sekhar Nori wrote: > Hi Rob, > > On Wednesday 13 June 2018 02:36 AM, Rob Herring wrote: >> On Tue, Jun 05, 2018 at 01:01:22AM -0500, Nishanth Menon wrote: >>> AM654 uses a UART controller that is compatible (partially) with >>> existing 8250 UART, however, has a f

[PATCH] uio: ensure class is registered before devices

2018-06-15 Thread Alexandre Belloni
When both uio and the uio drivers are built in the kernel, it is possible for a driver to register devices before the uio class is registered. This may result in a NULL pointer dereference later on in get_device_parent() when accessing the class glue_dirs spinlock. The trace looks like that: Una

Re: [PATCH] mm: skip invalid pages block at a time in zero_resv_unresv

2018-06-15 Thread Andrew Morton
On Fri, 15 Jun 2018 11:57:33 -0400 Pavel Tatashin wrote: > The role of zero_resv_unavail() is to make sure that every struct page that > is allocated but is not backed by memory that is accessible by kernel is > zeroed and not in some uninitialized state. > > Since struct pages are allocated in

Re: [PATCH v3 6/7] soc: qcom: Add RPMh Power domain driver

2018-06-15 Thread David Collins
Hello Ulf, On 06/15/2018 02:25 AM, Ulf Hansson wrote: > On 14 June 2018 at 20:17, David Collins wrote: >> On 06/13/2018 11:54 PM, Rajendra Nayak wrote: >>> On 06/14/2018 06:02 AM, David Collins wrote: On 06/11/2018 09:40 PM, Rajendra Nayak wrote: >> ... > +static int rpmhpd_power_off(str

[PATCH v3 1/1] shiftfs: uid/gid shifting bind mount

2018-06-15 Thread James Bottomley
This allows any subtree to be uid/gid shifted and bound elsewhere. It does this by operating simlarly to overlayfs. Its primary use is for shifting the underlying uids of filesystems used to support unpriviliged (uid shifted) containers. The usual use case here is that the container is operating

[PATCH v3 0/1] shiftfs: uid/gid shifting filesystem

2018-06-15 Thread James Bottomley
This is a repost of the v2 patch updated for the d_real changes For those who want to test it out, there's a git tree here git://git.kernel.org/pub/scm/linux/kernel/git/jejb/binfmt_misc.git on the shiftfs-v3 branch v2: This is a rewrite of the original shiftfs code to make use of super block u

Re: [PATCH v3 01/12] PM / devfreq: Init user limits from OPP limits, not viceversa

2018-06-15 Thread Matthias Kaehlcke
On Fri, Jun 15, 2018 at 02:06:21PM -0700, Brian Norris wrote: > Hi, > > On Thu, Jun 14, 2018 at 12:47:01PM -0700, Matthias Kaehlcke wrote: > > Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding > > the devfreq device") introduced the initialization of the user > > limits min/max_freq

clang: objtool: native_machine_emergency_restart() falls through to next function

2018-06-15 Thread Matthias Kaehlcke
Hi Josh, with your work on objtool and the upcoming implementation of -fno-delete-null-pointer-checks (https://reviews.llvm.org/D47894, https://reviews.llvm.org/D47895) in clang most objtool warnings for clang builds will be fixed. However even with -fno-delete-null-pointer-checks we currently st

[PATCH] cpufreq: intel_pstate: Fix scaling max/min limits with Turbo 3.0

2018-06-15 Thread Srinivas Pandruvada
When scaling max/min settings are changed, internally they are converted to a ratio using the max turbo 1 core turbo frequency. This works fine when 1 core max is same irrespective of the core. But under Turbo 3.0, this will not be the case. For example: Core 0: max turbo pstate: 43 (4.3GHz) Core 1

Re: [PATCH] x86/pti: don't report XenPV as vulnerable

2018-06-15 Thread Jiri Kosina
On Fri, 15 Jun 2018, Juergen Gross wrote: > Like it is possible to switch off PTI in the kernel it is possible to do > the same with XPTI in the hypervisor (it is even possible to disable > XPTI for dom0 only). > > In case XPTI is disabled for the currently running system it is possible > to m

Re: [PATCH] KASAN: slab-out-of-bounds Read in find_first_zero_bit

2018-06-15 Thread Tigran Aivazian
Hi Andrew, Here is the detailed information about the bug which Tomas fixed. As for the word-wrapping --- I enabled "plain text mode" in Gmail. However, just in case, I am sending the combined patch as a text file attachment. Is this ok? Kind regards, Tigran On 15 June 2018 at 19:33, tomas wrot

Re: [PATCH v3 01/12] PM / devfreq: Init user limits from OPP limits, not viceversa

2018-06-15 Thread Brian Norris
Hi, On Thu, Jun 14, 2018 at 12:47:01PM -0700, Matthias Kaehlcke wrote: > Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding > the devfreq device") introduced the initialization of the user > limits min/max_freq from the lowest/highest available OPPs. Later > commit f1d981eaecf8 ("PM

Tracing to console

2018-06-15 Thread Bart Van Assche
Hello Steven, If I run the following commands as root: cd /sys/kernel/debug/tracing grep pm_ available_events > set_event echo function >current_tracer grep scsi_ available_filter_functions | while read a b; do echo $a; done >set_ftrace_filter echo 1 >events/printk/enable echo 1 >tracing_on echo

Re: Lazy FPU restoration / moving kernel_fpu_end() to context switch

2018-06-15 Thread Rik van Riel
On Fri, 2018-06-15 at 13:42 -0700, Dave Hansen wrote: > On 06/15/2018 01:33 PM, Jason A. Donenfeld wrote: > > On Fri, Jun 15, 2018 at 8:32 PM Andy Lutomirski > > wrote: > > > quite in the form you imagined. The idea that we've tossed > > > around is > > > to restore FPU state on return to user mo

Re: [PATCHv3 07/17] x86/mm: Preserve KeyID on pte_modify() and pgprot_modify()

2018-06-15 Thread Kirill A. Shutemov
On Fri, Jun 15, 2018 at 08:45:21PM +, Dave Hansen wrote: > On 06/15/2018 01:45 PM, Kirill A. Shutemov wrote: > > On Fri, Jun 15, 2018 at 04:58:24PM +, Dave Hansen wrote: > >> On 06/15/2018 09:06 AM, Kirill A. Shutemov wrote: > >>> I have no idea what such concept should be called. I cannot

Re: Lazy FPU restoration / moving kernel_fpu_end() to context switch

2018-06-15 Thread Andy Lutomirski
> On Jun 15, 2018, at 1:42 PM, Dave Hansen wrote: > >> On 06/15/2018 01:33 PM, Jason A. Donenfeld wrote: >>> On Fri, Jun 15, 2018 at 8:32 PM Andy Lutomirski wrote: >>> quite in the form you imagined. The idea that we've tossed around is >>> to restore FPU state on return to user mode. Rough

Re: Lazy FPU restoration / moving kernel_fpu_end() to context switch

2018-06-15 Thread Jason A. Donenfeld
On Fri, Jun 15, 2018 at 10:27 PM Jason A. Donenfeld wrote: > AVX512 - Intel(R) Xeon(R) Gold 5120 CPU @ 2.20GHz > Inside: 634415672 > Outside: 286698960 > Percent speedup: 121 More realistic results, with turbo turned off: Inside: 616851298 Outside: 339606790 Percent speedup: 81 Still a pretty o

Re: [PATCHv3 07/17] x86/mm: Preserve KeyID on pte_modify() and pgprot_modify()

2018-06-15 Thread Dave Hansen
On 06/15/2018 01:45 PM, Kirill A. Shutemov wrote: > On Fri, Jun 15, 2018 at 04:58:24PM +, Dave Hansen wrote: >> On 06/15/2018 09:06 AM, Kirill A. Shutemov wrote: >>> I have no idea what such concept should be called. I cannot come with >>> anything better than PTE_PFN_MASK_MAX. Do you? >> PTE_P

Re: [PATCHv3 07/17] x86/mm: Preserve KeyID on pte_modify() and pgprot_modify()

2018-06-15 Thread Kirill A. Shutemov
On Fri, Jun 15, 2018 at 04:58:24PM +, Dave Hansen wrote: > On 06/15/2018 09:06 AM, Kirill A. Shutemov wrote: > > I have no idea what such concept should be called. I cannot come with > > anything better than PTE_PFN_MASK_MAX. Do you? > > PTE_PRESERVE_MASK > > Or maybe: > > PTE_MODIFY_PRESERV

Re: Lazy FPU restoration / moving kernel_fpu_end() to context switch

2018-06-15 Thread Dave Hansen
On 06/15/2018 01:33 PM, Jason A. Donenfeld wrote: > On Fri, Jun 15, 2018 at 8:32 PM Andy Lutomirski wrote: >> quite in the form you imagined. The idea that we've tossed around is >> to restore FPU state on return to user mode. Roughly, we'd introduce >> a new thread flag TIF_FPU_UNLOADED (name T

Re: [PATCH v2 6/7] vmw_balloon: update copyright message

2018-06-15 Thread Nadav Amit
at 1:35 PM, valdis.kletni...@vt.edu wrote: > On Thu, 14 Jun 2018 05:33:46 -, Nadav Amit said: > In addition, updating the year and adding a license tag. > +// SPDX-License-Identifier: GPL-2.0 > >>> You still have a lot of boiler-plate text in here that can be removed. >>> Please d

Re: [PATCH v2 6/7] vmw_balloon: update copyright message

2018-06-15 Thread valdis . kletnieks
On Thu, 14 Jun 2018 05:33:46 -, Nadav Amit said: > >> In addition, updating the year and adding a license tag. > >> +// SPDX-License-Identifier: GPL-2.0 > > You still have a lot of boiler-plate text in here that can be removed. > > Please do so. > But what else do you want me to remove? Thi

Re: Lazy FPU restoration / moving kernel_fpu_end() to context switch

2018-06-15 Thread Jason A. Donenfeld
On Fri, Jun 15, 2018 at 8:32 PM Andy Lutomirski wrote: > quite in the form you imagined. The idea that we've tossed around is > to restore FPU state on return to user mode. Roughly, we'd introduce > a new thread flag TIF_FPU_UNLOADED (name TBD). > prepare_exit_to_usermode() would notice this fla

Re: Lazy FPU restoration / moving kernel_fpu_end() to context switch

2018-06-15 Thread Jason A. Donenfeld
On Fri, Jun 15, 2018 at 9:34 PM Peter Zijlstra wrote: > Didn't we recently do a bunch of crypto patches to help with this? > > I think they had the pattern: > > kernel_fpu_begin(); > for (units-of-work) { > do_unit_of_work(); > if (need_resched()) {

Re: Lazy FPU restoration / moving kernel_fpu_end() to context switch

2018-06-15 Thread Jason A. Donenfeld
On Fri, Jun 15, 2018 at 8:53 PM Andy Lutomirski wrote: > > On Fri, Jun 15, 2018 at 11:50 AM Dave Hansen > wrote: > Even with the modified optimization, kernel_fpu_end() still needs to > reload the state that was trashed by the kernel FPU use. If the > kernel is using something like AVX512 state,

Re: [PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Add sensors

2018-06-15 Thread Fabio Estevam
On Thu, Jun 14, 2018 at 7:17 AM, Leonard Crestez wrote: > Should I also assign a label, like "isl29023: light-sensor@44"? I > couldn't find any recommendation on this. > > There are no immediate uses for a label but this practice is very > common. Having labels allows creating minor board variant

Re: [PATCH 8/8] NTB: ntb_test: Fix bug when counting remote files

2018-06-15 Thread Logan Gunthorpe
On 15/06/18 01:51 PM, Serge Semin wrote: > On Fri, Jun 08, 2018 at 06:08:19PM -0600, Logan Gunthorpe > wrote: >> When remote files are counted in get_files_count, without using SSH, >> the code returns 0 because there is a colon prepended to $LOC. $VPATH >> should have been used instead of $LO

Re: [PATCH 6/8] NTB: perf: Fix support for hardware that doesn't have port numbers

2018-06-15 Thread Logan Gunthorpe
On 15/06/18 01:50 PM, Serge Semin wrote: > On Fri, Jun 08, 2018 at 06:08:17PM -0600, Logan Gunthorpe > wrote: >> Legacy drivers do not have port numbers (but is reliably only two ports) >> and was broken by the recent commit that added mult-port support to >> ntb_perf. This is especially impor

Re: [PATCH 7/8] NTB: perf: Fix race condition when run with ntb_test

2018-06-15 Thread Logan Gunthorpe
On 15/06/18 01:51 PM, Serge Semin wrote: > On Fri, Jun 08, 2018 at 06:08:18PM -0600, Logan Gunthorpe > wrote: >> When running ntb_test, the script tries to run the ntb_perf test >> immediately after probing the modules. Since adding multi-port support, >> this fails seeing the new initializati

Re: [PATCH 4/8] NTB: ntb_pingpong: Choose doorbells based on port number

2018-06-15 Thread Logan Gunthorpe
On 15/06/18 01:49 PM, Serge Semin wrote: > Regarding the patch. The idea of using the port number instead of linearised > unique index should also work for Intel/AMD/IDT drivers. But the ports-space > linearization algorithm was created for the case if the real port numbers > would exceed the av

Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

2018-06-15 Thread Logan Gunthorpe
On 15/06/18 01:48 PM, Serge Semin wrote: > Concerning the fix of the discovered issues and fixes introduced by this > patchset. I'd suggest to add the ports-index callbacks to the Switchtec > driver, which identify local and peer ports. After this the current version > of all the test drivers sh

Re: [PATCH 8/8] NTB: ntb_test: Fix bug when counting remote files

2018-06-15 Thread Serge Semin
On Fri, Jun 08, 2018 at 06:08:19PM -0600, Logan Gunthorpe wrote: > When remote files are counted in get_files_count, without using SSH, > the code returns 0 because there is a colon prepended to $LOC. $VPATH > should have been used instead of $LOC. > Good catch. Thanks for the patch. I discover

Re: [PATCH 7/8] NTB: perf: Fix race condition when run with ntb_test

2018-06-15 Thread Serge Semin
On Fri, Jun 08, 2018 at 06:08:18PM -0600, Logan Gunthorpe wrote: > When running ntb_test, the script tries to run the ntb_perf test > immediately after probing the modules. Since adding multi-port support, > this fails seeing the new initialization procedure in ntb_perf > can not complete instant

Re: [PATCH 6/8] NTB: perf: Fix support for hardware that doesn't have port numbers

2018-06-15 Thread Serge Semin
On Fri, Jun 08, 2018 at 06:08:17PM -0600, Logan Gunthorpe wrote: > Legacy drivers do not have port numbers (but is reliably only two ports) > and was broken by the recent commit that added mult-port support to > ntb_perf. This is especially important to support the cross link > topology which is

Re: [PATCH 4/8] NTB: ntb_pingpong: Choose doorbells based on port number

2018-06-15 Thread Serge Semin
On Fri, Jun 08, 2018 at 06:08:14PM -0600, Logan Gunthorpe wrote: > This commit fixes pingpong support for existing drivers that do not > implement ntb_default_port_number() and ntb_default_peer_port_number(). > This is required for hardware (like the crosslink topology of > switchtec) which canno

Re: [PATCH 5/8] NTB: perf: Don't require one more memory window than number of peers

2018-06-15 Thread Serge Semin
On Fri, Jun 08, 2018 at 06:08:15PM -0600, Logan Gunthorpe wrote: > ntb_perf should not require more than one memory window per peer. This > was probably an off-by-one error. > Good catch. Thanks. IDT got a lot of MWs especially if LookUpTables are enabled. That's why I didn't find the effect of

Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

2018-06-15 Thread Serge Semin
On Fri, Jun 08, 2018 at 06:08:13PM -0600, Logan Gunthorpe wrote: > When the commit adding ntb_default_port_number() and > ntb_default_peer_port_number() entered the kernel there was no > users of it so it was impossible to tell what the API needed. > > When a user finally landed a year later (n

Re: [PATCH 1/8] NTB: ntb_tool: reading the link file should not end in a NULL byte

2018-06-15 Thread Serge Semin
On Fri, Jun 08, 2018 at 06:08:11PM -0600, Logan Gunthorpe wrote: > When running ntb_test this warning is issued: > > ./ntb_test.sh: line 200: warning: command substitution: ignored null > byte in input > This is weird. Neither me nor the folks' who tested the script saw this warning. I tried i

Re: [PATCH 0/8] Fix breakage caused by the NTB multi-port patchset

2018-06-15 Thread Serge Semin
On Fri, Jun 08, 2018 at 06:08:10PM -0600, Logan Gunthorpe wrote: Good day, Logan. Thanks for the patchset you submitted. My hopefully useful comments are under the corresponding patches. Regards, -Sergey > Hey, > > Here are all the fixes required to get ntb_test on switchtec working > again a

Re: INFO: task hung in __sb_start_write

2018-06-15 Thread Tetsuo Handa
On 2018/06/15 18:19, Dmitry Vyukov wrote: > On Thu, Jun 14, 2018 at 12:33 PM, Tetsuo Handa > wrote: >> On 2018/06/11 16:39, Dmitry Vyukov wrote: >>> On Mon, Jun 11, 2018 at 9:30 AM, Peter Zijlstra >>> wrote: On Sun, Jun 10, 2018 at 11:47:56PM +0900, Tetsuo Handa wrote: > This looks

Re: [PATCH v1 3/3] x86/bugs: Switch the selection of mitigation from CPU vendor to CPU features

2018-06-15 Thread Konrad Rzeszutek Wilk
On Fri, Jun 15, 2018 at 08:57:40PM +0200, Thomas Gleixner wrote: > On Tue, 12 Jun 2018, Tom Lendacky wrote: > > On 6/11/2018 9:01 AM, Konrad Rzeszutek Wilk wrote: > > >> I think you will have to keep the case statements and explicitly check > > >> for > > >> X86_FEATURE_AMD_SSBD before using SPEC_

Re: Cgroups "pids" controller does not update "pids.current" count immediately

2018-06-15 Thread Ivan Zahariev
Hello, On 15.6.2018 г. 22:07 ч., Tejun Heo wrote: On Fri, Jun 15, 2018 at 08:40:02PM +0300, Ivan Zahariev wrote: The lazy pids accounting + modern fast CPUs makes the "pids.current" metric practically unusable for resource limiting in our case. For a test, when we started and ended one single

Re: [PATCH] mm/madvise: allow MADV_DONTNEED to free memory that is MLOCK_ONFAULT

2018-06-15 Thread Jason Baron
On 06/13/2018 03:15 AM, Michal Hocko wrote: > On Wed 13-06-18 08:32:19, Vlastimil Babka wrote: >> On 06/12/2018 04:11 PM, Jason Baron wrote: >>> >>> >>> On 06/12/2018 03:46 AM, Michal Hocko wrote: On Mon 11-06-18 12:23:58, Jason Baron wrote: > On 06/11/2018 11:03 AM, Michal Hocko wrote:

Re: Lazy FPU restoration / moving kernel_fpu_end() to context switch

2018-06-15 Thread Peter Zijlstra
On Fri, Jun 15, 2018 at 06:25:39PM +0200, Thomas Gleixner wrote: > On Fri, 15 Jun 2018, Jason A. Donenfeld wrote: > > In a loop this looks like: > > > > for (thing) { > > kernel_fpu_begin(); > > encrypt(thing); > > kernel_fpu_end(); > > } > > > > This is obviously very bad, because begin()

Re: [PATCH] mm: skip invalid pages block at a time in zero_resv_unresv

2018-06-15 Thread Pavel Tatashin
> Hi Pavel, > > Thanks for the patch. > This looks good to me. > > Reviewed-by: Oscar Salvador Thank you Oscar! Pavel

Re: [PATCH] mm/madvise: allow MADV_DONTNEED to free memory that is MLOCK_ONFAULT

2018-06-15 Thread Jason Baron
On 06/13/2018 05:13 AM, Michal Hocko wrote: > On Tue 12-06-18 10:11:33, Jason Baron wrote: > [...] >> Ok, I share the concern that there is a chance that userspace is relying >> on MADV_DONTNEED not free'ing locked memory. In that case, what if we >> introduce a MADV_DONTNEED_FORCE, which does e

Re: [PATCH] arch/sh: use slow path for get_user_pages_fast() on SMP

2018-06-15 Thread Thomas Petazzoni
Hello, On Fri, 15 Jun 2018 19:04:45 +0300, Sergei Shtylyov wrote: > Hello! > > On 06/15/2018 06:52 PM, Thomas Petazzoni wrote: > > > The fast path of get_user_pages_fast() disables IRQs and then does: > > > > - gup_pud_range() > >- gup_pmd_range() > > - gup_pte_range() > >- fl

Re: [PATCH] mm/memblock: add missing include

2018-06-15 Thread Andrew Morton
On Fri, 15 Jun 2018 11:59:10 -0700 Tony Luck wrote: > On Wed, Jun 6, 2018 at 12:41 PM, Mathieu Malaterre wrote: > > Commit 26f09e9b3a06 ("mm/memblock: add memblock memory allocation apis") > > introduced two new function definitions: > > ‘memblock_virt_alloc_try_nid_nopanic’ > > and > > ‘mem

Recall: PROBLEM: JFFS2 Empty summary info causes OOPS

2018-06-15 Thread Veluthakkal, Sreeram
Veluthakkal, Sreeram would like to recall the message, "PROBLEM: JFFS2 Empty summary info causes OOPS".

PROBLEM: JFFS2 Empty summary info causes OOPS

2018-06-15 Thread Veluthakkal, Sreeram
Hi, [1.] Summary: JFFS2 Empty summary node info causes OOPS [2.] Description: Under stress situations on the filesystem, OOPs are observed. The OOPs points to empty summary node info bug. Confirmed that the filesystem is not full, not corrupted and is accessible. [3.] Keywords (i.e., modules, ne

Re: [PATCH] infiniband: fix a subtle race condition

2018-06-15 Thread Jason Gunthorpe
On Fri, Jun 15, 2018 at 10:57:49AM -0700, Cong Wang wrote: > > No, it *is* the point - you've proposed a solution, one of many, and > > we need to see an actual sensible design for how the locking around > > ctx->file should work correctly. > > I proposed to a solution for imbalance unlock, you a

Re: Cgroups "pids" controller does not update "pids.current" count immediately

2018-06-15 Thread Tejun Heo
Hello, Ivan. On Fri, Jun 15, 2018 at 08:40:02PM +0300, Ivan Zahariev wrote: > The lazy pids accounting + modern fast CPUs makes the "pids.current" > metric practically unusable for resource limiting in our case. For a > test, when we started and ended one single process very quickly, we > saw "pid

  1   2   3   4   >