Re: regression: "95cde3c59966 debugfs: inode: debugfs_create_dir uses mode permission from parent" terminally annoys libvirt

2018-06-09 Thread Greg Kroah-Hartman
On Fri, Jun 08, 2018 at 02:13:57PM +0200, Thomas-Mich Richter wrote: > On 06/08/2018 09:16 AM, Mike Galbraith wrote: > > Greetings, > > > > $subject bisected and verified via revert. Box is garden variety > > i4790, distro is openSUSE Leap 15.0. > > > > Error starting domain: internal error: pro

Re: [PATCH 00/15] fsi: Overall improvements and new SBE fifo driver

2018-06-09 Thread Greg Kroah-Hartman
On Sun, Jun 10, 2018 at 04:46:53PM +1000, Benjamin Herrenschmidt wrote: > (Greg, see below) > > On Tue, 2018-05-29 at 22:00 +0930, Joel Stanley wrote: > > On 29 May 2018 at 11:00, Benjamin Herrenschmidt > > wrote: > > > This series brings in a number of improvements to our FSI stack > > > (one of

Re: [Bug 199965] New: Memory management: BUG in kernel_restart

2018-06-09 Thread Mateusz Lenik
On Sat, Jun 09, 2018 at 04:07:26PM +0200, Greg Kroah-Hartman wrote: > Here's the full callstack, but yeah, it's not very obvious as to what > device is having the problem, which isn't good. I don't know what to > suggest here. I think it is related to amdgpu -- when the script that unbinds the s

Re: [PATCH 00/15] fsi: Overall improvements and new SBE fifo driver

2018-06-09 Thread Benjamin Herrenschmidt
(Greg, see below) On Tue, 2018-05-29 at 22:00 +0930, Joel Stanley wrote: > On 29 May 2018 at 11:00, Benjamin Herrenschmidt > wrote: > > This series brings in a number of improvements to our FSI stack > > (one of the service interfaces for communicating between a BMC chip and > > our POWER process

Re: [PATCH 2/2] IB/mad: Use IDR for agent IDs

2018-06-09 Thread Leon Romanovsky
On Fri, Jun 08, 2018 at 10:42:18AM -0700, Matthew Wilcox wrote: > From: Matthew Wilcox > > Allocate agent IDs from a global IDR instead of an atomic variable. > This eliminates the possibility of reusing an ID which is already in > use after 4 billion registrations, and we can also limit the assig

[GIT pull] x86 updates for 4.18

2018-06-09 Thread Thomas Gleixner
Linus, please pull the latest x86-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus A pile of x86 updates and fixes: - Fix the (late) fallout from the vector management rework causing hlist corruption and irq descriptor refere

Re: what trees/branches to test on syzbot

2018-06-09 Thread Dmitry Vyukov
On Sun, Jun 10, 2018 at 3:51 AM, Theodore Y. Ts'o wrote: > On Sat, Jun 09, 2018 at 03:17:21PM -0700, Linus Torvalds wrote: >> I think it would be lovely to get linux-next back eventually, but it >> sounds like it's just too noisy right now, and yes, we should have a >> baseline for the standard tr

Re: [PATCH 09/11] vfs: factor out inode_insert5()

2018-06-09 Thread Al Viro
On Sun, Jun 10, 2018 at 06:49:10AM +0100, Al Viro wrote: > On Tue, May 29, 2018 at 04:41:41PM +0200, Miklos Szeredi wrote: > > From: Miklos Szeredi > > > > Split out common helper for race free insertion of an already allocated > > inode into the cache. Use this from iget5_locked() and > > inser

[GIT pull] x86/pti updates for 4.18

2018-06-09 Thread Thomas Gleixner
Linus, please pull the latest x86-pti-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-pti-for-linus Three small commits updating the SSB mitigation to take the updated AMD mitigation variants into account. Thanks, tglx --> Konr

Re: [GIT PULL] overlayfs update for 4.18

2018-06-09 Thread Al Viro
On Fri, Jun 08, 2018 at 11:52:08PM -0700, Christoph Hellwig wrote: > On Fri, Jun 08, 2018 at 02:13:30PM +0200, Miklos Szeredi wrote: > > Hi Linus, > > > > Please pull from: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git > > tags/ovl-update-4.18 > > > > This contains tw

[GIT pull] perf updates for 4.18

2018-06-09 Thread Thomas Gleixner
Linus, please pull the latest perf-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-urgent-for-linus perf updates and fixes: perf stat: - Display user and system time for workload targets (Jiri Olsa) perf record:

Re: [PATCH 09/11] vfs: factor out inode_insert5()

2018-06-09 Thread Al Viro
On Tue, May 29, 2018 at 04:41:41PM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > Split out common helper for race free insertion of an already allocated > inode into the cache. Use this from iget5_locked() and > insert_inode_locked4(). Make iget5_locked() use new_inode()/iput() instea

Re: [PATCH 15/39] ovl: add helper to return real file

2018-06-09 Thread Al Viro
On Tue, May 29, 2018 at 04:43:15PM +0200, Miklos Szeredi wrote: > In the common case we can just use the real file cached in > file->private_data. There are two exceptions: > > 1) File has been copied up since open: in this unlikely corner case just > use a throwaway real file for the operation.

Re: [intel-sgx-kernel-dev] [PATCH v11 13/13] intel_sgx: in-kernel launch enclave

2018-06-09 Thread Andy Lutomirski
On Fri, Jun 8, 2018 at 10:32 AM Jarkko Sakkinen wrote: > > The Launch Enclave (LE) generates cryptographic launch tokens for user > enclaves. A launch token is used by EINIT to check whether the enclave > is authorized to launch or not. By having its own launch enclave, Linux > has full control of

Re: [intel-sgx-kernel-dev] [PATCH v11 09/13] x86, sgx: basic routines for enclave page cache

2018-06-09 Thread Andy Lutomirski
On Fri, Jun 8, 2018 at 10:22 AM Jarkko Sakkinen wrote: > > SGX has a set of data structures to maintain information about the enclaves > and their security properties. BIOS reserves a fixed size region of > physical memory for these structures by setting Processor Reserved Memory > Range Registers

Re: [PATCH 23/39] ovl: add O_DIRECT support

2018-06-09 Thread Al Viro
On Tue, May 29, 2018 at 04:43:23PM +0200, Miklos Szeredi wrote: > Signed-off-by: Miklos Szeredi > --- > fs/overlayfs/file.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c > index 3f610a5b38e4..e5e7ccaaf9ec 100644 > --- a/fs/overlayfs/file.c

[GIT pull] irq updates for 4.18

2018-06-09 Thread Thomas Gleixner
Linus, please pull the latest irq-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-urgent-for-linus Two small fixlets: - Add the missing iomu mapping call in the Fleescale/NXP/Qualcomm/whoever owns it now/ SCFG MSI irqchip driver. Otherwise I

Re: [PATCH 19/39] ovl: add ovl_mmap()

2018-06-09 Thread Al Viro
On Tue, May 29, 2018 at 04:43:19PM +0200, Miklos Szeredi wrote: > Implement stacked mmap. > > Signed-off-by: Miklos Szeredi > --- > fs/overlayfs/file.c | 28 > 1 file changed, 28 insertions(+) > > diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c > index 7b47dc

[GIT pull] core updates for 4.18

2018-06-09 Thread Thomas Gleixner
Linus, please pull the latest core-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-urgent-for-linus A small set of core updates: - Make objtool cope with GCC8 oddities some more - Remove a stale local_irq_save/restore sequence in the signal

Re: [PATCH v7 2/2] Refactor part of the oom report in dump_header

2018-06-09 Thread Mike Rapoport
On Fri, Jun 08, 2018 at 05:53:14PM +0800, 禹舟键 wrote: > Hi Mike > > My question was why do you call to alloc_constrained in the dump_header() > > function rather than pass the constraint that was detected a bit earlier to > > that function? > > dump_header will be called by three functions: oom_kil

Re: [PATCH 07/39] vfs: export vfs_ioctl() to modules

2018-06-09 Thread Al Viro
On Mon, Jun 04, 2018 at 01:49:04AM -0700, Christoph Hellwig wrote: > On Tue, May 29, 2018 at 04:43:07PM +0200, Miklos Szeredi wrote: > > This is needed by the stacked ioctl implementation in overlayfs. > > EXPORT_SYMBOL_GPL for exporting random internals, please. Same > for any following patches.

Re: [PATCH 05/39] vfs: optionally don't account file in nr_files

2018-06-09 Thread Al Viro
On Tue, May 29, 2018 at 04:43:05PM +0200, Miklos Szeredi wrote: > +++ b/fs/open.c > @@ -732,8 +732,8 @@ static int do_dentry_open(struct file *f, > static const struct file_operations empty_fops = {}; > int error; > > - f->f_mode = OPEN_FMODE(f->f_flags) | FMODE_LSEEK | > -

Re: [PATCH 04/39] vfs: add path_open()

2018-06-09 Thread Al Viro
On Mon, Jun 04, 2018 at 01:46:09AM -0700, Christoph Hellwig wrote: > > +EXPORT_SYMBOL(path_open); > > EXPORT_SYMBOL_GPL, please. No. If interface makes sense, export it. If it doens't, don't. Don't mix "it's a shit API, but we need it for some in-kernel module" with "out-of-tree

[tip:core/urgent] signal: Remove no longer required irqsave/restore

2018-06-09 Thread tip-bot for Anna-Maria Gleixner
Commit-ID: 59dc6f3c6d81c0c4379025c4eb56919391d62b67 Gitweb: https://git.kernel.org/tip/59dc6f3c6d81c0c4379025c4eb56919391d62b67 Author: Anna-Maria Gleixner AuthorDate: Fri, 25 May 2018 11:05:07 +0200 Committer: Thomas Gleixner CommitDate: Sun, 10 Jun 2018 06:14:01 +0200 signal: Remove

[tip:core/urgent] rcu: Update documentation of rcu_read_unlock()

2018-06-09 Thread tip-bot for Anna-Maria Gleixner
Commit-ID: ec84b27f9b3b569f9235413d1945a2006b97b0aa Gitweb: https://git.kernel.org/tip/ec84b27f9b3b569f9235413d1945a2006b97b0aa Author: Anna-Maria Gleixner AuthorDate: Fri, 25 May 2018 11:05:06 +0200 Committer: Thomas Gleixner CommitDate: Sun, 10 Jun 2018 06:14:01 +0200 rcu: Update doc

Re: [PATCH 14/39] ovl: stack file ops

2018-06-09 Thread Al Viro
On Tue, May 29, 2018 at 04:43:14PM +0200, Miklos Szeredi wrote: > Implement file operations on a regular overlay file. The underlying file > is opened separately and cached in ->private_data. > > It might be worth making an exception for such files when accounting in > nr_file to confirm to users

Re: what trees/branches to test on syzbot

2018-06-09 Thread Theodore Y. Ts'o
On Sat, Jun 09, 2018 at 03:17:21PM -0700, Linus Torvalds wrote: > I think it would be lovely to get linux-next back eventually, but it > sounds like it's just too noisy right now, and yes, we should have a > baseline for the standard tree first. > > But once there's a "this is known for the baseli

Re: [PATCH 0/8] Fix breakage caused by the NTB multi-port patchset

2018-06-09 Thread Allen Hubbe
On Fri, Jun 8, 2018 at 8:08 PM, Logan Gunthorpe wrote: > Hey, > > Here are all the fixes required to get ntb_test on switchtec working > again after the multi-port test patches were merged. > > I'd appreciate it if future changes can be a) more careful about > not breaking things, b) communicated

Re: [PATCH] bluetooth: remove unused bt-nokia-h4p.h header

2018-06-09 Thread Sebastian Reichel
Hi, On Thu, Jun 07, 2018 at 07:50:38PM +, Corentin Labbe wrote: > Nothing in tree use this header which seems a remains of a staging > driver. > This patch remove it. > > Signed-off-by: Corentin Labbe Right, this is not used by drivers/bluetooth/hci_nokia.c, but a leftover from the staging

Re: [GIT PULL] overlayfs update for 4.18

2018-06-09 Thread Al Viro
On Sat, Jun 09, 2018 at 02:42:20PM -0700, Linus Torvalds wrote: > Hmm. > > So I had held off on pulling this in the hope that it would get more comments. > > I like most of the vfs-level stuff - it gets rid of some of the > hackery we had for overlayfs. > > It does add some new hackery to replac

Re: [PATCH v2] pci/aspm: Remove CONFIG_PCIEASPM_DEBUG

2018-06-09 Thread Sinan Kaya
> On Thu, May 10, 2018 at 4:39 PM Rajat Jain wrote: >> >> Currently, the linux kernel disables ASPM when a device is >> removed from the kernel. But it is not enabled again when >> a new device is added on that slot even if it was originally >> enabled (by the BIOS) when the system booted up (assu

Re: [PATCH] staging: rts5208: add check on NULL before dereference

2018-06-09 Thread okaya
On 2018-06-09 15:34, Andy Shevchenko wrote: On Sat, Jun 9, 2018 at 7:58 PM, wrote: On 2018-06-09 12:38, Anton Vasilyev wrote: If rtsx_probe fails to allocate dev->chip, then NULL pointer dereference occurs at rtsx_release_resources(). Patch adds checks chip on NULL before its dereference at

[PATCH] ASoC: rockchip: put device_node on remove

2018-06-09 Thread Alexey Khoroshilov
snd_rk_mc_probe() gets a couple of device nodes with of_parse_phandle(), but there is no release of them. The patch adds remove handler and proper error handling in the probe. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- sound/soc/rockchi

[PATCH] acpi/x86: enable touchscreen on Dell Venue Pro 7139

2018-06-09 Thread Tristian Celestin
Permanently enable the SYNA7500 touchscreen device on the Dell Venue Pro 7139. The DSDT hides the touchscreen ACPI device on the 7139 in the same fashion as the 7130, and needs to be enabled in the same way. Signed-off-by: Tristian Celestin --- drivers/acpi/x86/utils.c | 12 +--- 1 file

Re: what trees/branches to test on syzbot

2018-06-09 Thread Linus Torvalds
On Fri, Jun 8, 2018 at 11:36 PM Tetsuo Handa wrote: > On 2018/01/22 22:32, Dmitry Vyukov wrote: > > > > FTR I've just dropped linux-next and mmots from syzbot. > > I hope that we can test linux-next on syzbot, as a tree for testing debug > printk() patches. I think it would be lovely to get linux

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-09 Thread Luc Van Oostenryck
On Sat, Jun 09, 2018 at 01:00:08PM -0700, Palmer Dabbelt wrote: > On Fri, 08 Jun 2018 17:13:12 PDT (-0700), luc.vanoostenr...@gmail.com wrote: > > I tried it and ... the preprocessed asm is as expected: > > .globl __asm_copy_to_user ; .balign 4 ; __asm_copy_to_user: > > .globl __asm_copy_fr

Re: [GIT PULL] overlayfs update for 4.18

2018-06-09 Thread Linus Torvalds
Hmm. So I had held off on pulling this in the hope that it would get more comments. I like most of the vfs-level stuff - it gets rid of some of the hackery we had for overlayfs. It does add some new hackery to replace it (like the file accounting), though. And Christoph's copmmentary isn't real

[PATCH] hpfs: Use EUCLEAN for filesystem errors

2018-06-09 Thread Mikulas Patocka
Use the error code EUCLEAN for filesystem errors because other filesystems use this code too. Signed-off-by: Mikulas Patocka --- fs/hpfs/hpfs_fn.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-4.17/fs/hpfs/hpfs_fn.h ===

Re: [PATCH] HID: steam: use hid_device.driver_data instead of hid_set_drvdata()

2018-06-09 Thread Mariusz Ceier
Hello Rodrigo, I confirm that this patch fixes the steam controller related crash for me. I don't know if it's correct, but at least it's: Tested-by: Mariusz Ceier I'm attaching the backtrace of crash I was getting before applying the patch. Best regards, Mariusz Ceier On 22 May 2018 at 22

Re: [PATCH 3/3] riscv: fix __user annotation for __copy_user()

2018-06-09 Thread Palmer Dabbelt
On Fri, 08 Jun 2018 17:13:12 PDT (-0700), luc.vanoostenr...@gmail.com wrote: On Fri, Jun 08, 2018 at 03:33:36PM -0700, Palmer Dabbelt wrote: On Thu, 07 Jun 2018 09:51:33 PDT (-0700), luc.vanoostenr...@gmail.com wrote: > On Thu, Jun 07, 2018 at 09:30:19AM -0700, Palmer Dabbelt wrote: > > diff --g

[PATCH] proc: add proc_seq_release

2018-06-09 Thread Chunyu Hu
kmemleak reported some memory leak on reading proc files. After adding some debug lines, find that proc_seq_fops is using seq_release as release handler, which won't handle the free of 'private' field of seq_file, while in fact the open handler proc_seq_open could create the private data with __seq

Re: [PATCH] staging: rts5208: add check on NULL before dereference

2018-06-09 Thread Andy Shevchenko
On Sat, Jun 9, 2018 at 7:58 PM, wrote: > On 2018-06-09 12:38, Anton Vasilyev wrote: >> >> If rtsx_probe fails to allocate dev->chip, then NULL pointer >> dereference occurs at rtsx_release_resources(). >> >> Patch adds checks chip on NULL before its dereference at >> rtsx_release_resources and pa

sd 6:0:0:0: [sdb] Unaligned partial completion (resid=12, sector_sz=512)

2018-06-09 Thread Christoph Anton Mitterer
Hey. I'm seeing these errors: Jun 09 21:13:22 heisenberg kernel: sd 6:0:0:0: [sdb] Unaligned partial completion (resid=16, sector_sz=512) Jun 09 21:13:22 heisenberg kernel: sd 6:0:0:0: [sdb] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE Jun 09 21:13:22 heisenberg kernel: sd 6:0:0:

[PATCH v4 1/7] interconnect: Add generic on-chip interconnect API

2018-06-09 Thread Georgi Djakov
Hi Alexandre, On 8.06.18 г. 18:57, Alexandre Bailon wrote: > On 03/09/2018 10:09 PM, Georgi Djakov wrote: >> This patch introduce a new API to get requirements and configure the >> interconnect buses across the entire chipset to fit with the current >> demand. >> >> The API is using a consumer/pro

Re: [PATCH resend v2] dcdbas: Add support for WSMT ACPI table

2018-06-09 Thread Andy Shevchenko
On Sat, Jun 9, 2018 at 4:04 AM, Darren Hart wrote: > On Thu, Jun 07, 2018 at 08:11:41PM +0300, Andy Shevchenko wrote: >> On Thu, Jun 7, 2018 at 6:59 PM, Stuart Hayes >> wrote: >> > +static inline struct smm_eps_table *check_eps_table(u8 *addr) >> > +{ >> > + struct smm_eps_table *eps = (s

[GIT PULL] power-supply changes for 4.18

2018-06-09 Thread Sebastian Reichel
Hi Linus, Stephen reported a merge conflict in the USB tree, that I pulled into power-supply via a tag Greg prepared for me. The issue has been fixed by Greg in the USB tree in the meantime, so I suppose git will figure it out by itself. -- Sebastian The following changes since commit 6d08b06e67

[GIT PULL] hsi changes for hsi-4.18

2018-06-09 Thread Sebastian Reichel
Hi Linus, Just one patch for the HSI subsystem this time: The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338: Linux 4.17-rc1 (2018-04-15 18:24:20 -0700) are available in the Git repository at: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.gi

[PATCH] Add a configure option ARM_ERRATA_WFE_BROKEN

2018-06-09 Thread Bernd Edlinger
This works around problems with Altera Cyclone5 Devices. See https://bugzilla.kernel.org/show_bug.cgi?id=111951 I just wanted to let you know that we use this patch since more than two years now and the problem never repeated for us. There is one possibly related observation with CONFIG_PL310_ERR

[GIT PULL] MD update for 4.18-rc

2018-06-09 Thread Shaohua Li
Hi, A few fixes of MD for this merge window. Mostly bug fixes: - raid5 stripe batch fix from Amy - Read error handling for raid1 FailFast device from Gioh - raid10 recovery NULL pointer dereference fix from Guoqing - Support write hint for raid5 stripe cache from Mariusz - Fixes for device hot add/

[BUG] igb: reconnecting of cable not always detected

2018-06-09 Thread Thomas Netousek
I have a similar problem. If I disconnect and reconnect the ethernet cable on a Intel Ethernet card then the device does not come up again. For me this problem happens on the first pull of the LAN cable all the time. It is reproducible on Supermicro X8, X9 and X10 dual CPU mainboards with onboard

Re: [PATCH] staging: rts5208: add check on NULL before dereference

2018-06-09 Thread okaya
On 2018-06-09 12:38, Anton Vasilyev wrote: If rtsx_probe fails to allocate dev->chip, then NULL pointer dereference occurs at rtsx_release_resources(). Patch adds checks chip on NULL before its dereference at rtsx_release_resources and passing with dereference inside rtsx_release_chip. Found by

Re: building in 32bit chroot on x86_64 host broken

2018-06-09 Thread Theodore Y. Ts'o
On Sat, Jun 09, 2018 at 09:23:55PM +0900, Masahiro Yamada wrote: > Just a note. > > In case of cross-compiling, not only ARCH but also CROSS_COMPILE > must be passed when you do "make *config". Sure, what was being discussed was people who build 32-bit x86 kernels on a 64-bit platform. I do this

[PATCH] staging: rts5208: add check on NULL before dereference

2018-06-09 Thread Anton Vasilyev
If rtsx_probe fails to allocate dev->chip, then NULL pointer dereference occurs at rtsx_release_resources(). Patch adds checks chip on NULL before its dereference at rtsx_release_resources and passing with dereference inside rtsx_release_chip. Found by Linux Driver Verification project (linuxtest

[PATCH 4.17 11/15] team: use netdev_features_t instead of u32

2018-06-09 Thread Greg Kroah-Hartman
4.17-stable review patch. If anyone has any objections, please let me know. -- From: Dan Carpenter [ Upstream commit 25ea66544bfd1d9df1b7e1502f8717e85fa1e6e6 ] This code was introduced in 2011 around the same time that we made netdev_features_t a u64 type. These days a u32 is

[PATCH 4.17 12/15] vrf: check the original netdevice for generating redirect

2018-06-09 Thread Greg Kroah-Hartman
4.17-stable review patch. If anyone has any objections, please let me know. -- From: Stephen Suryaputra [ Upstream commit 2f17becfbea5e9a0529b51da7345783e96e69516 ] Use the right device to determine if redirect should be sent especially when using vrf. Same as well as when sen

[PATCH 4.17 03/15] ip6mr: only set ip6mr_table from setsockopt when ip6mr_new_table succeeds

2018-06-09 Thread Greg Kroah-Hartman
4.17-stable review patch. If anyone has any objections, please let me know. -- From: Sabrina Dubroca [ Upstream commit 848235edb5c93ed086700584c8ff64f6d7fc778d ] Currently, raw6_sk(sk)->ip6mr_table is set unconditionally during ip6_mroute_setsockopt(MRT6_TABLE). A subsequent a

[PATCH 4.17 05/15] l2tp: fix refcount leakage on PPPoL2TP sockets

2018-06-09 Thread Greg Kroah-Hartman
4.17-stable review patch. If anyone has any objections, please let me know. -- From: Guillaume Nault [ Upstream commit 3d609342cc04129ff7568e19316ce3d7451a27e8 ] Commit d02ba2a6110c ("l2tp: fix race in pppol2tp_release with session object destroy") tried to fix a race conditio

[PATCH 4.17 00/15] 4.17.1-stable review

2018-06-09 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.17.1 release. There are 15 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Mon Jun 11 14:59:48 UTC 2018. Anything receive

[PATCH 4.17 07/15] net: metrics: add proper netlink validation

2018-06-09 Thread Greg Kroah-Hartman
4.17-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 5b5e7a0de2bbf2a1afcd9f49e940010e9fb80d53 ] Before using nla_get_u32(), better make sure the attribute is of the proper size. Code recently was changed, but bug

[PATCH 4.17 14/15] ipmr: fix error path when ipmr_new_table fails

2018-06-09 Thread Greg Kroah-Hartman
4.17-stable review patch. If anyone has any objections, please let me know. -- From: Sabrina Dubroca [ Upstream commit e783bb00ad86d9d1f01d9d3a750713070036358e ] commit 0bbbf0e7d0e7 ("ipmr, ip6mr: Unite creation of new mr_table") refactored ipmr_new_table, so that it now retur

[PATCH 4.16 01/48] mmap: introduce sane default mmap limits

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Linus Torvalds commit be83bbf806822b1b89e0a0f23cd87cddc409e429 upstream. The internal VM "mmap()" interfaces are based on the mmap target doing everything using page indexes rather than byte o

[PATCH 4.16 03/48] netfilter: nf_flow_table: attach dst to skbs

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Jason A. Donenfeld commit 2a79fd3908acd88e6cb0e620c314d7b1fee56a02 upstream. Some drivers, such as vxlan and wireguard, use the skb's dst in order to determine things like PMTU. They therefore

[PATCH 4.16 00/48] 4.16.15-stable review

2018-06-09 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.16.15 release. There are 48 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Mon Jun 11 14:59:28 UTC 2018. Anything receiv

[PATCH 4.16 12/48] ipmr: properly check rhltable_init() return value

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 66fb33254f45df4b049f487aff1cbde1ef919390 ] commit 8fb472c09b9d ("ipmr: improve hash scalability") added a call to rhltable_init() without checking its return val

Re: [RFC][PATCHES] getting rid of int *open in ->atomic_open() and friends

2018-06-09 Thread Al Viro
On Sat, Jun 09, 2018 at 06:10:51AM +0100, Al Viro wrote: > That leaves > * anon_inode_getfile() - converts to similar form, at the price of > ihold done slightly earlier, so that failure exit needs a (non-final, i.e. > very cheap) iput() we currently avoid. Not a problem. > * do_shmat

[PATCH 4.16 14/48] ipv6: omit traffic class when calculating flow hash

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Michal Kubecek [ Upstream commit fa1be7e01ea863e911349e30456706749518eeab ] Some of the code paths calculating flow hash for IPv6 use flowlabel member of struct flowi6 which, despite its name,

[PATCH 4.16 06/48] bnx2x: use the right constant

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Julia Lawall [ Upstream commit dd612f18a49b63af8b3a5f572d999bdb197385bc ] Nearby code that also tests port suggests that the P0 constant should be used when port is zero. The semantic match t

[PATCH 4.16 09/48] enic: set DMA mask to 47 bit

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Govindarajulu Varadarajan [ Upstream commit 322eaa06d55ebc1402a4a8d140945cff536638b4 ] In commit 624dbf55a359b ("driver/net: enic: Try DMA 64 first, then failover to DMA") DMA mask was changed

[PATCH 4.16 11/48] ip6_tunnel: remove magic mtu value 0xFFF8

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Nicolas Dichtel [ Upstream commit f7ff1fde9441b4fcc8ffb6e66e6e5a00d008937e ] I don't know where this value comes from (probably a copy and paste and paste and paste ...). Let's use standard va

[PATCH 4.16 17/48] l2tp: fix refcount leakage on PPPoL2TP sockets

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Guillaume Nault [ Upstream commit 3d609342cc04129ff7568e19316ce3d7451a27e8 ] Commit d02ba2a6110c ("l2tp: fix race in pppol2tp_release with session object destroy") tried to fix a race conditio

[PATCH 4.16 27/48] qed: Fix mask for physical address in ILT entry

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Shahed Shaikh [ Upstream commit fdd13dd350dda1826579eb5c333d76b14513b812 ] ILT entry requires 12 bit right shifted physical address. Existing mask for ILT entry of physical address i.e. ILT_EN

[PATCH 4.16 32/48] vrf: check the original netdevice for generating redirect

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Stephen Suryaputra [ Upstream commit 2f17becfbea5e9a0529b51da7345783e96e69516 ] Use the right device to determine if redirect should be sent especially when using vrf. Same as well as when sen

[PATCH 4.16 28/48] rtnetlink: validate attributes in do_setlink()

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 644c7eebbfd59e72982d11ec6cc7d39af12450ae ] It seems that rtnl_group_changelink() can call do_setlink while a prior call to validate_linkmsg(dev = NULL, ...) coul

[PATCH 4.16 29/48] sctp: not allow transport timeout value less than HZ/5 for hb_timer

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Xin Long [ Upstream commit 1d88ba1ebb2763aa86172cd7ca05dedbeccc0d35 ] syzbot reported a rcu_sched self-detected stall on CPU which is caused by too small value set on rto_min with SCTP_RTOINFO

[PATCH 4.16 33/48] ipv6: sr: fix memory OOB access in seg6_do_srh_encap/inline

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Mathieu Xhonneux [ Upstream commit bbb40a0b75209734ff9286f3326171638c9f6569 ] seg6_do_srh_encap and seg6_do_srh_inline can possibly do an out-of-bounds access when adding the SRH to the packet

[PATCH 4.16 31/48] vhost: synchronize IOTLB message with dev cleanup

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Jason Wang [ Upstream commit 1b15ad683ab42a203f98b67045b40720e99d0e9a ] DaeRyong Jeong reports a race between vhost_dev_cleanup() and vhost_process_iotlb_msg(): Thread interleaving: CPU0 (vho

[PATCH 4.16 18/48] mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Petr Machata [ Upstream commit 47bf9df2e8201d07c40670e093629f8dfd1b5d9f ] VLAN 1 is internally used for untagged traffic. Prevent creation of explicit netdevice for that VLAN, because that cur

[PATCH 4.16 35/48] net-sysfs: Fix memory leak in XPS configuration

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Alexander Duyck [ Upstream commit 664088f8d68178809b848ca450f2797efb34e8e7 ] This patch reorders the error cases in showing the XPS configuration so that we hold off on memory allocation until

[PATCH 4.16 34/48] net: phy: broadcom: Fix auxiliary control register reads

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Florian Fainelli [ Upstream commit 733a969a7ed14fc5786bcc59c1bdda83c7ddb46e ] We are currently doing auxiliary control register reads with the shadow register value 0b111 (0x7) which incidenta

[PATCH 4.16 21/48] net: ipv4: add missing RTA_TABLE to rtm_ipv4_policy

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Roopa Prabhu [ Upstream commit 2eabd764cb5512f1338d06ffc054c8bc9fbe9104 ] Signed-off-by: Roopa Prabhu Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv4/fib_fron

[PATCH 4.16 23/48] net/packet: refine check for priv area size

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit eb73190f4fbeedf762394e92d6a4ec9ace684c88 ] syzbot was able to trick af_packet again [1] Various commits tried to address the problem in the past, but failed to

[PATCH 4.16 46/48] net: netsec: reduce DMA mask to 40 bits

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Ard Biesheuvel [ Upstream commit 312564269535892cc082bc80592150cd1f5e8ec3 ] The netsec network controller IP can drive 64 address bits for DMA, and the DMA mask is set accordingly in the drive

[PATCH 4.16 37/48] virtio-net: fix leaking page for gso packet during mergeable XDP

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Jason Wang [ Upstream commit 3d62b2a0db505bbf9ed0755f254e45d775f9807f ] We need to drop refcnt to xdp_page if we see a gso packet. Otherwise it will be leaked. Fixing this by moving the check

[PATCH 4.16 22/48] net: metrics: add proper netlink validation

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 5b5e7a0de2bbf2a1afcd9f49e940010e9fb80d53 ] Before using nla_get_u32(), better make sure the attribute is of the proper size. Code recently was changed, but bug

[PATCH 4.16 16/48] kcm: Fix use-after-free caused by clonned sockets

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Kirill Tkhai [ Upstream commit eb7f54b90bd8f469834c5e86dcf72ebf9a629811 ] (resend for properly queueing in patchwork) kcm_clone() creates kernel socket, which does not take net counter. Thus,

[PATCH 4.16 39/48] net/mlx5e: When RXFCS is set, add FCS data into checksum calculation

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Eran Ben Elisha [ Upstream commit 902a545904c71d719ed144234d67df75f31db63b ] When RXFCS feature is enabled, the HW do not strip the FCS data, however it is not present in the checksum calculat

[PATCH 4.16 40/48] tun: Fix NULL pointer dereference in XDP redirect

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Toshiaki Makita [ Upstream commit 6547e387d7f52f2ba681a229de3c13e5b9e01ee1 ] Calling XDP redirection requires bh disabled. Softirq can call another XDP function and redirection functions, then

[PATCH 4.16 38/48] net/mlx4: Fix irq-unsafe spinlock usage

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Jack Morgenstein [ Upstream commit d546b67cda015fb92bfee93d5dc0ceadb91deaee ] spin_lock/unlock was used instead of spin_un/lock_irq in a procedure used in process space, on a spinlock which ca

[PATCH 4.16 48/48] PCI: hv: Do not wait forever on a device that has disappeared

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Dexuan Cui commit c3635da2a336441253c33298b87b3042db100725 upstream. Before the guest finishes the device initialization, the device can be removed anytime by the host, and after that the host

[PATCH 4.14 01/41] scsi: sd_zbc: Fix potential memory leak

2018-06-09 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Damien Le Moal commit 4b433924b2755a94f99258c178684a0e05c344de upstream. Rework sd_zbc_check_zone_size() to avoid a memory leak due to an early return if sd_zbc_report_zones() fails. Reported

[PATCH 4.16 43/48] net : sched: cls_api: deal with egdev path only if needed

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Or Gerlitz [ Upstream commit f8f4bef322e4600c5856911c7a632c0e3da920d6 ] When dealing with ingress rule on a netdev, if we did fine through the conventional path, there's no need to continue in

[PATCH 4.14 11/41] ip6mr: only set ip6mr_table from setsockopt when ip6mr_new_table succeeds

2018-06-09 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Sabrina Dubroca [ Upstream commit 848235edb5c93ed086700584c8ff64f6d7fc778d ] Currently, raw6_sk(sk)->ip6mr_table is set unconditionally during ip6_mroute_setsockopt(MRT6_TABLE). A subsequent a

[PATCH 4.16 36/48] virtio-net: correctly transmit XDP buff after linearizing

2018-06-09 Thread Greg Kroah-Hartman
4.16-stable review patch. If anyone has any objections, please let me know. -- From: Jason Wang [ Upstream commit 5d458a13dd59d04b4d6658a6d5b94d42732b15ae ] We should not go for the error path after successfully transmitting a XDP buffer after linearizing. Since the error path

[PATCH 4.14 02/41] scsi: sd_zbc: Avoid that resetting a zone fails sporadically

2018-06-09 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Bart Van Assche commit ccce20fc7968d546fb1e8e147bf5cdc8afc4278a upstream. Since SCSI scanning occurs asynchronously, since sd_revalidate_disk() is called from sd_probe_async() and since sd_rev

[PATCH 4.14 05/41] btrfs: define SUPER_FLAG_METADUMP_V2

2018-06-09 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Anand Jain commit e2731e55884f2138a252b0a3d7b24d57e49c3c59 upstream. btrfs-progs uses super flag bit BTRFS_SUPER_FLAG_METADUMP_V2 (1ULL << 34). So just define that in kernel so that we know it

[PATCH 4.14 10/41] enic: set DMA mask to 47 bit

2018-06-09 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Govindarajulu Varadarajan [ Upstream commit 322eaa06d55ebc1402a4a8d140945cff536638b4 ] In commit 624dbf55a359b ("driver/net: enic: Try DMA 64 first, then failover to DMA") DMA mask was changed

[PATCH 4.14 04/41] mmap: relax file size limit for regular files

2018-06-09 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Linus Torvalds commit 423913ad4ae5b3e8fb8983f70969fb522261ba26 upstream. Commit be83bbf80682 ("mmap: introduce sane default mmap limits") was introduced to catch problems in various ad-hoc cha

[PATCH 4.14 09/41] dccp: dont free ccid2_hc_tx_sock struct in dccp_disconnect()

2018-06-09 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Alexey Kodanev [ Upstream commit 2677d20677314101293e6da0094ede7b5526d2b1 ] Syzbot reported the use-after-free in timer_is_static_object() [1]. This can happen because the structure for the r

[PATCH 4.14 13/41] ipmr: properly check rhltable_init() return value

2018-06-09 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 66fb33254f45df4b049f487aff1cbde1ef919390 ] commit 8fb472c09b9d ("ipmr: improve hash scalability") added a call to rhltable_init() without checking its return val

[PATCH 4.14 24/41] packet: fix reserve calculation

2018-06-09 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Willem de Bruijn [ Upstream commit 9aad13b087ab0a588cd68259de618f100053360e ] Commit b84bbaf7a6c8 ("packet: in packet_snd start writing at link layer allocation") ensures that packet_snd alway

  1   2   >