Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding

2018-05-07 Thread Johan Hovold
On Mon, May 07, 2018 at 10:50:32AM -0700, Tony Lindgren wrote: > * Johan Hovold [180507 16:36]: > > On Mon, May 07, 2018 at 08:45:15AM -0700, Tony Lindgren wrote: > > > Hi, > > > > > > * Johan Hovold [180507 03:03]: > > > > On Fri, May 04, 2018 at 01:42:13PM +0200, Sebastian Reichel wrote: > >

Re: [RFC PATCH] sched/cpufreq/schedutil: handling urgent frequency requests

2018-05-07 Thread Viresh Kumar
On 07-05-18, 16:43, Claudio Scordino wrote: > At OSPM, it was mentioned the issue about urgent CPU frequency requests > arriving when a frequency switch is already in progress. > > Besides the various issues (physical time for switching frequency, > on-going kthread activity, etc.) one (minor) iss

Re: [PATCH v2 10/26] drm/bridge: panel: provide an owner .odev device

2018-05-07 Thread Jyri Sarha
On 05/04/18 16:51, Peter Rosin wrote: > It gets rid of an #ifdef and the .of_node member is going away. > > Signed-off-by: Peter Rosin > --- > drivers/gpu/drm/bridge/panel.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/

[PATCH] net: aquantia: Fix an error handling path in 'aq_pci_probe()'

2018-05-07 Thread Christophe JAILLET
The position of 2 labels should be swapped in order to release resources in the correct order and avoid leaks. Fixes: 23ee07ad3c2f ("net: aquantia: Cleanup pci functions module") Signed-off-by: Christophe JAILLET --- The order of 'pci_release_regions()' and 'free_netdev()' is in reverse order in

Re: [PATCH v1 6/7] Bluetooth: hci_mediatek: Add protocol support for MediaTek serial devices

2018-05-07 Thread Sean Wang
Hi, Marcel On Tue, 2018-04-03 at 12:27 +0200, Marcel Holtmann wrote: > Hi Sean, > [ ... ] > > + > > +static int mtk_wmt_cmd_sync(struct hci_uart *hu, u8 opcode, u8 flag, u16 > > plen, > > + const void *param) > > +{ > > + struct mtk_bt_dev *btdev = hu->priv; > > + str

Re: [PATCH] net: 8390: Fix possible data races in __ei_get_stats

2018-05-07 Thread Jia-Ju Bai
On 2018/5/8 13:04, Eric Dumazet wrote: On 05/07/2018 07:16 PM, Jia-Ju Bai wrote: Yes, "&dev->stats" will not change, because it is a fixed address. But the field data in "dev->stats" is changed (rx_frame_errors, rx_crc_errors and rx_missed_errors). So if the driver returns "&dev->stats" wit

Re: [PATCH v3 2/3] platform: move the early platform device support to arch/sh

2018-05-07 Thread Geert Uytterhoeven
Hi Bartosz, On Fri, May 4, 2018 at 3:27 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > SuperH is the only user of the current implementation of early platform > device support. We want to introduce a more robust approach to early > probing. As the first step - move all the curren

Re: [PATCH 2/2] media: v4l: Add new 10-bit packed grayscale format

2018-05-07 Thread Todor Tomov
Hi Sakari, On 7.05.2018 13:59, Sakari Ailus wrote: > Hi Todor, > > On Fri, Apr 27, 2018 at 02:40:39PM +0300, Todor Tomov wrote: >> The new format will be called V4L2_PIX_FMT_Y10P. >> It is similar to the V4L2_PIX_FMT_SBGGR10P family formats >> but V4L2_PIX_FMT_Y10P is a grayscale format. >> >> S

Re: [PATCH 2/2] serial: imx: dma_unmap_sg buffers on shutdown

2018-05-07 Thread Uwe Kleine-König
On Mon, May 07, 2018 at 11:36:10PM +0200, Sebastian Reichel wrote: > This properly unmaps DMA SG on device shutdown. > > Reported-by: Nandor Han > Suggested-by: Nandor Han > Signed-off-by: Sebastian Reichel > --- > drivers/tty/serial/imx.c | 12 ++-- > 1 file changed, 10 insertions(+),

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

2018-05-07 Thread Tiwei Bie
On Tue, May 08, 2018 at 01:40:40PM +0800, Jason Wang wrote: > On 2018年05月08日 11:05, Jason Wang wrote: > > > > > > Because in virtqueue_enable_cb_delayed(), we may set an > > > event_off which is bigger than new and both of them have > > > wrapped. And in this case, although new is smaller than > >

Re: [PATCH 0/3] scsi: arcmsr: Add driver parameter cmd_timeout for scsi command timeout setting

2018-05-07 Thread Ching Huang
On Tue, 2018-05-08 at 14:32 +0800, Ching Huang wrote: > On Tue, 2018-05-08 at 01:41 -0400, Martin K. Petersen wrote: > > Hello Ching, > > > > > 1. Add driver parameter cmd_timeout, default value is > > > ARCMSR_DEFAULT_TIMEOUT. > > > 2. Add slave_configure callback function to set device command

[PATCH] sched/schedutil: Don't set next_freq to UINT_MAX

2018-05-07 Thread Viresh Kumar
The schedutil driver sets sg_policy->next_freq to UINT_MAX on certain occasions: - In sugov_start(), when the schedutil governor is started for a group of CPUs. - And whenever we need to force a freq update before rate-limit duration, which happens when: - there is an update in cpufreq policy

Re: [PATCH v7 1/6] dt-bindings: define vendor prefix for Wi2Wi, Inc.

2018-05-07 Thread H. Nikolaus Schaller
HI Rob, > Am 07.05.2018 um 22:54 schrieb Rob Herring : > > On Thu, May 03, 2018 at 11:35:46AM +0200, H. Nikolaus Schaller wrote: >> Introduce vendor prefix for Wi2Wi, Inc. for W2SG0004 GPS module >> and W2CBW003 Bluetooth/WiFi combo (CSR/Marvell). >> >> Signed-off-by: H. Nikolaus Schaller >> Ac

Re: [PATCH 1/2] serial: imx: cleanup imx_uart_disable_dma()

2018-05-07 Thread Uwe Kleine-König
Hello, On Mon, May 07, 2018 at 11:36:09PM +0200, Sebastian Reichel wrote: > Remove unrelated CTSC/CTS disabling from imx_uart_disable_dma() and > move it to imx_uart_shutdown(), which is the only user of the DMA > disabling function. This should not change the driver's behaviour, > but improves re

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

2018-05-07 Thread Andrzej Hajda
On 07.05.2018 15:53, Daniel Vetter wrote: > On Mon, May 07, 2018 at 02:59:45PM +0200, Andrzej Hajda wrote: >> On 04.05.2018 15:52, Peter Rosin wrote: >>> If the bridge supplier is unbound, this will bring the bridge consumer >>> down along with the bridge. Thus, there will no longer linger any >>>

Re: [PATCH] i2c-mux-pca954x: Force reset on probe if available

2018-05-07 Thread Peter Rosin
On 2018-05-01 13:42, Mike Looijmans wrote: > Instead of just hogging the reset GPIO into deactivated state, activate and > then de-activate the reset. This allows for better recovery if the CPU was > reset halfway through an I2C transaction for example. I can't see any problems with this, and a re

Re: [PATCH 5/7] cifs: smbd: Protect memory registration using RCU

2018-05-07 Thread kbuild test robot
Hi Long, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on cifs/for-next] [also build test WARNING on v4.17-rc4 next-20180507] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH 2/2] leds: lm3601x: Introduce the lm3601x LED driver

2018-05-07 Thread kbuild test robot
Hi Dan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on v4.17-rc4 next-20180507] [cannot apply to j.anaszewski-leds/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

RE: [LINUX PATCH v8 2/2] memory: pl353: Add driver for arm pl353 static memory controller

2018-05-07 Thread Naga Sureshkumar Relli
> -Original Message- > From: Julia Cartwright [mailto:ju...@ni.com] > Sent: Monday, May 7, 2018 10:23 PM > To: Naga Sureshkumar Relli > Cc: nagasureshkumarre...@gmail.com; boris.brezil...@bootlin.com; > rog...@ti.com; > lee.jo...@linaro.org; alexandre.bell...@free-electrons.com; > nico

Re: [PATCH 0/3] scsi: arcmsr: Add driver parameter cmd_timeout for scsi command timeout setting

2018-05-07 Thread Ching Huang
On Tue, 2018-05-08 at 01:41 -0400, Martin K. Petersen wrote: > Hello Ching, > > > 1. Add driver parameter cmd_timeout, default value is > > ARCMSR_DEFAULT_TIMEOUT. > > 2. Add slave_configure callback function to set device command timeout > > value. > > 3. Update driver version to v1.40.00.06-20

Re: [PATCH] nubus: Unconditionally register bus type

2018-05-07 Thread Geert Uytterhoeven
Hi Finn, On Tue, May 8, 2018 at 1:44 AM, Finn Thain wrote: > On Mon, 7 May 2018, I wrote: >> On Sun, 6 May 2018, Greg Kroah-Hartman wrote: >> > > > Why not just have an "bus is registered" flag in your driver >> > > > register function that refuses to let drivers register with the >> > > > driver

Re: [PATCH] IB/umem: use tgid instead of pid in ib_umem structure

2018-05-07 Thread Jason Gunthorpe
On Mon, May 07, 2018 at 09:38:53AM +0800, 858585 jemmy wrote: > On Sat, May 5, 2018 at 2:23 AM, Jason Gunthorpe wrote: > > On Fri, May 04, 2018 at 04:51:15PM +0800, 858585 jemmy wrote: > >> On Fri, May 4, 2018 at 11:14 AM, 858585 jemmy > >> wrote: > >> > On Thu, May 3, 2018 at 11:33 PM, Jason Gu

Re: [PATCH] nubus: Unconditionally register bus type

2018-05-07 Thread Geert Uytterhoeven
Hi Greg, On Mon, May 7, 2018 at 4:45 PM, Greg Kroah-Hartman wrote: > On Mon, May 07, 2018 at 02:53:13PM +0200, Geert Uytterhoeven wrote: >> On Mon, May 7, 2018 at 1:57 AM, Finn Thain >> wrote: >> > On Sun, 6 May 2018, Greg Kroah-Hartman wrote: >> >> > > Why not just have an "bus is registered"

Re: [PATCH v2 01/14] mtd: rawnand: helper function for setting up ECC parameters

2018-05-07 Thread Masahiro Yamada
2018-05-07 16:39 GMT+09:00 Boris Brezillon : > On Mon, 7 May 2018 12:40:39 +0900 > Masahiro Yamada wrote: > >> 2018-05-03 21:20 GMT+09:00 Abhishek Sahu : >> > commit 2c8f8afa7f92 ("mtd: nand: add generic helpers to check, >> > match, maximize ECC settings") provides generic helpers which >> > driv

[PATCH] media: i2c: tda1997: Fix an error handling path 'tda1997x_probe()'

2018-05-07 Thread Christophe JAILLET
If 'media_entity_pads_init()' fails, we must free the resources allocated by 'v4l2_ctrl_handler_init()', as already done in the previous error handling path. 'goto' the right label to fix it. Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI receiver driver") Signed-off-by: Christophe JAILLET

Re: [PATCH v3 0/4] Better integrate seccomp logging and auditing

2018-05-07 Thread Paul Moore
On Sun, May 6, 2018 at 7:36 PM, Kees Cook wrote: > On Sun, May 6, 2018 at 2:31 PM, Paul Moore wrote: >> On Thu, May 3, 2018 at 9:08 PM, Tyler Hicks wrote: >>> Seccomp received improved logging controls in v4.14. Applications can opt >>> into >>> logging of "handled" actions (SECCOMP_RET_TRAP, S

[PATCH] f2fs: fix to let checkpoint guarantee atomic page persistence

2018-05-07 Thread Chao Yu
1. thread A: commit_inmem_pages submit data into block layer, but haven't waited it writeback. 2. thread A: commit_inmem_pages update related node. 3. thread B: do checkpoint, flush all nodes to disk. 4. SPOR Then, atomic file becomes corrupted since nodes is flushed before data. This patch fixes

Re: [PATCH] f2fs: fix to wait IO writeback in __revoke_inmem_pages()

2018-05-07 Thread Chao Yu
On 2018/5/8 11:31, Jaegeuk Kim wrote: > On 05/08, Chao Yu wrote: >> On 2018/5/8 4:46, Jaegeuk Kim wrote: >>> On 04/27, Chao Yu wrote: On 2018/4/27 0:36, Jaegeuk Kim wrote: > On 04/26, Chao Yu wrote: >> On 2018/4/26 23:48, Jaegeuk Kim wrote: >>> On 04/26, Chao Yu wrote: Thr

Re: BUG: spinlock bad magic in tun_do_read

2018-05-07 Thread Eric Dumazet
On 05/07/2018 10:54 PM, Cong Wang wrote: > On Mon, May 7, 2018 at 10:27 PM, syzbot > wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:75bc37fefc44 Linux 4.17-rc4 >> git tree: upstream >> console output: https://syzkaller.appspot.com/x/log.txt?x=1162c6978000

Re: Kernel build with gcc 8 a lot of warnings

2018-05-07 Thread Greg KH
On Tue, May 08, 2018 at 07:51:26AM +0200, Greg KH wrote: > On Sun, May 06, 2018 at 11:54:53PM -0500, Josh Poimboeuf wrote: > > On Sat, May 05, 2018 at 09:21:12PM +0200, damian wrote: > > > Helllo together, > > > > > > Hello everybody, > > > > > > is something special to note when kernel build wit

Re: BUG: spinlock bad magic in tun_do_read

2018-05-07 Thread Cong Wang
On Mon, May 7, 2018 at 10:27 PM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:75bc37fefc44 Linux 4.17-rc4 > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1162c69780 > kernel config: https://syzkaller.appspot.com/x/.

Re: Kernel build with gcc 8 a lot of warnings

2018-05-07 Thread Greg KH
On Sun, May 06, 2018 at 11:54:53PM -0500, Josh Poimboeuf wrote: > On Sat, May 05, 2018 at 09:21:12PM +0200, damian wrote: > > Helllo together, > > > > Hello everybody, > > > > is something special to note when kernel build with gcc 8? I receive > > various warnings from the objtool: > > With GCC

[PATCH v2] f2fs: fix to avoid race during access gc_thread pointer

2018-05-07 Thread Chao Yu
Thread AThread B - f2fs_remount - stop_gc_thread - f2fs_sbi_store sbi->gc_thread = NULL; access sbi->gc_thread->gc_* Previously, we allocate memory for sbi->gc_thread based on background gc thread mount o

[PATCH] iw_cxgb4: Fix an error handling path in 'c4iw_get_dma_mr()'

2018-05-07 Thread Christophe JAILLET
The error handling path of 'c4iw_get_dma_mr()' does not free resources in the correct order. If an error occures, it can leak 'mhp->wr_waitp'. Fixes: a3f12da0e99a ("iw_cxgb4: allocate wait object for each memory object") Signed-off-by: Christophe JAILLET --- drivers/infiniband/hw/cxgb4/mem.c | 4

Re: [PATCH 0/3] scsi: arcmsr: Add driver parameter cmd_timeout for scsi command timeout setting

2018-05-07 Thread Martin K. Petersen
Hello Ching, > 1. Add driver parameter cmd_timeout, default value is ARCMSR_DEFAULT_TIMEOUT. > 2. Add slave_configure callback function to set device command timeout value. > 3. Update driver version to v1.40.00.06-20180504. I am not so keen on arcmsr overriding the timeout set by the admin or a

[PATCH v2 2/2] leds: Add Spreadtrum SC27xx breathing light controller driver

2018-05-07 Thread Baolin Wang
From: Xiaotong Lu This patch adds Spreadtrum SC27xx PMIC series breathing light controller driver, which can support 3 LEDs. Each LED can work at normal PWM mode and breathing mode. Signed-off-by: Xiaotong Lu Signed-off-by: Baolin Wang --- Changes since v1: - Add ABI documentation. - Add mut

Re: [RFC v3 4/5] virtio_ring: add event idx support in packed ring

2018-05-07 Thread Jason Wang
On 2018年05月08日 11:05, Jason Wang wrote: Because in virtqueue_enable_cb_delayed(), we may set an event_off which is bigger than new and both of them have wrapped. And in this case, although new is smaller than event_off (i.e. the third param -- old), new shouldn't add vq->num, and actually we a

[PATCH v2 1/2] dt-bindings: leds: Add SC27xx breathing light controller documentation

2018-05-07 Thread Baolin Wang
This patch adds the binding documentation for Spreadtrum SC27xx series breathing light controller, which supports 3 outputs: red LED, green LED and blue LED. Signed-off-by: Baolin Wang --- Changes since v1: - Change the compatible string to be one explicit SoC name. - Change the child node name

Re: [PATCH v2] scsi: 3w-9xxx: fix a missing-check bug

2018-05-07 Thread Martin K. Petersen
Wenwen, > In twa_chrdev_ioctl(), the ioctl driver command is firstly copied from the > userspace pointer 'argp' and saved to the kernel object 'driver_command'. > Then a security check is performed on the data buffer size indicated by > 'driver_command', which is 'driver_command.buffer_length'. I

[lkp-robot] [EXP rcu] 21560e1007: WARNING:possible_recursive_locking_detected

2018-05-07 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-7): commit: 21560e10077bf9f7baf69aa82527850271173862 ("EXP rcu: Diagnostics for grace-period hangs") https://git.kernel.org/cgit/linux/kernel/git/paulmck/linux-rcu.git dev.2018.05.01a in testcase: ebizzy with following parameters: n

Re: [PATCH v2 2/2] pinctrl: generic: improve apply_setting error verbosity

2018-05-07 Thread Matheus Castello
Hi Linus, thanks for the tips, I will study this to break dependency from OF. Best Regards, Matheus Castello On 05/02/2018 08:51 AM, Linus Walleij wrote: On Tue, May 1, 2018 at 9:10 PM, Matheus Castello wrote: For generic pinconf: print the dev_error with the pinctrl vendor driver name, err

Re: [PATCH] scsi: mptsas: fix spelling mistake: "matchs" -> "matches"

2018-05-07 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in warning message Applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH][V2] scsi: lpfc: fix spelling mistakes: "mabilbox" and "maibox"

2018-05-07 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistakes in lpfc_printf_log log message > > "mabilbox" -> "mailbox" > "maibox" -> "mailbox" Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

BUG: spinlock bad magic in tun_do_read

2018-05-07 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:75bc37fefc44 Linux 4.17-rc4 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1162c69780 kernel config: https://syzkaller.appspot.com/x/.config?x=31f4b3733894ef79 dashboard link: https://syzkaller.a

Re: [PATCH] scsi: qla2xxx: remove the unused tcm_qla2xxx_cmd_wq

2018-05-07 Thread Martin K. Petersen
Andrei, Applied to 4.18/scsi-queue. thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/7] cifs: smbd: Make upper layer decide when to destroy the transport

2018-05-07 Thread kbuild test robot
Hi Long, Thank you for the patch! Yet something to improve: [auto build test ERROR on cifs/for-next] [also build test ERROR on v4.17-rc4 next-20180507] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH] scsi: mptfusion: fix spelling mistake: "initators" -> "initiators"

2018-05-07 Thread Martin K. Petersen
Colin, > Trivial fix to spelling mistake in text string Applied to 4.18/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

linux-next: Tree for May 8

2018-05-07 Thread Stephen Rothwell
Hi all, Changes since 20180507: The pci tree gained a conflict against the dma-mapping tree. The bpf-next tree gained a conflict against the s390 tree. The drm-intel tree gained a build failure due to an interaction with the dma-mapping tree for which I applied a merge fix patch. Non-merge

Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type

2018-05-07 Thread Martin K. Petersen
Luc, > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. You forgot to update the function prototype accordingly. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/11] hisi_sas: some misc patches

2018-05-07 Thread Martin K. Petersen
John, > This patchset introduces some misc changes for the > driver. These include: > - fixes for potential problems related to SCSI EH > and device removal races > - fix protection info size for all hw versions > - some SoC bug workarounds > - minor optimisations > - other more minor things A

Re: [PATCH v2 15/35] ovl: add ovl_fsync()

2018-05-07 Thread Amir Goldstein
On Mon, May 7, 2018 at 11:37 AM, Miklos Szeredi wrote: > Implement stacked fsync(). > > Signed-off-by: Miklos Szeredi > --- > fs/overlayfs/file.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c > index a7af56861aa5..419aa3f

Re: [PATCH v3 2/2] usb: dwc2: fix isoc split in transfer with no data

2018-05-07 Thread Doug Anderson
Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: > If isoc split in transfer with no data (the length of DATA0 > packet is zero), we can't simply return immediately. Because > the DATA0 can be the first transaction or the second transaction > for the isoc split in transaction. If the DATA0 p

[lkp-robot] [rcu] 6ec8474821: WARNING:at_kernel/softirq.c:#__local_bh_enable_ip

2018-05-07 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-7): commit: 6ec84748215d9b0c91dba0b8674540e493ce2dcf ("rcu: Make simple callback acceleration refer to rdp->gp_seq_needed") https://git.kernel.org/cgit/linux/kernel/git/paulmck/linux-rcu.git dev.2018.05.01a in testcase: boot on test machine

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-07 Thread Doug Anderson
Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: > +static int dwc2_alloc_split_dma_aligned_buf(struct dwc2_hsotg *hsotg, > + struct dwc2_qh *qh, > + struct dwc2_host_chan *chan) > +{ > + if (!hsotg->un

Re: [PATCH] net: 8390: Fix possible data races in __ei_get_stats

2018-05-07 Thread Eric Dumazet
On 05/07/2018 07:16 PM, Jia-Ju Bai wrote: > Yes, "&dev->stats" will not change, because it is a fixed address. > But the field data in "dev->stats" is changed (rx_frame_errors, rx_crc_errors > and rx_missed_errors). > So if the driver returns "&dev->stats" without lock protection (like on line

Re: [PATCH v1 0/2] Add QCOM video clock controller driver

2018-05-07 Thread Amit Nischal
On 2018-05-07 22:41, Rob Herring wrote: On Mon, May 07, 2018 at 04:16:53PM +0530, Amit Nischal wrote: On 2018-05-04 22:01, Stephen Boyd wrote: > Quoting Amit Nischal (2018-05-03 05:35:23) > > Changes in v1: > >https://lkml.org/lkml/2018/4/24/545 > > Addressed below review comments given by R

Re: bug in tag handling in blk-mq?

2018-05-07 Thread Mike Galbraith
On Mon, 2018-05-07 at 20:02 +0200, Paolo Valente wrote: > > > > Is there a reproducer? Just building fat config kernels works for me. It was highly non- deterministic, but reproduced quickly twice in a row with Paolos hack.    > Ok Mike, I guess it's your turn now, for at least a stack trace.

Re: [PATCH] PM / devfreq: Drop custom MIN/MAX macros

2018-05-07 Thread Chanwoo Choi
Hi, On 2018년 04월 25일 04:46, Bjorn Andersson wrote: > Drop the custom MIN/MAX macros in favour of the standard min/max from > kernel.h > > Signed-off-by: Bjorn Andersson > --- > drivers/devfreq/devfreq.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/driver

[PATCH V4 10/10] ASoC: amd: dma driver changes for bt i2s instance

2018-05-07 Thread Vijendar Mukunda
With in ACP, There are three I2S controllers can be configured/enabled ( I2S SP, I2S MICSP, I2S BT). Default enabled I2S controller instance is I2S SP. This patch provides required changes to support I2S BT controller Instance. Signed-off-by: Vijendar Mukunda Reviewed-by: Daniel Kurtz --- v1->v2

[PATCH 09/10] ASoC: AMD: Add const to snd_soc_ops instances

2018-05-07 Thread Vijendar Mukunda
From: Akshu Agrawal Marking snd_soc_ops instances const Signed-off-by: Akshu Agrawal Signed-off-by: Vijendar Mukunda Reviewed-by: Daniel Kurtz --- sound/soc/amd/acp-da7219-max98357a.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/amd/acp-da7219-max98357a

[PATCH 08/10] ASoC: AMD: Fix clocks in CZ DA7219 machine driver

2018-05-07 Thread Vijendar Mukunda
From: Akshu Agrawal System clock on the platform is 25Mhz and not 24Mhz. PLL_OUT for da7219 codec to use DA7219_PLL_FREQ_OUT_98304 as it is for 48KHz SR. Signed-off-by: Akshu Agrawal Signed-off-by: Vijendar Mukunda Reviewed-by: Daniel Kurtz --- sound/soc/amd/acp-da7219-max98357a.c | 5 ++---

[PATCH 07/10] ASoC: AMD: Move clk enable from hw_params/free to startup/shutdown

2018-05-07 Thread Vijendar Mukunda
From: Akshu Agrawal hw_param can be called multiple times and thus we can have more clk enable. The clk may not get diabled due to refcounting. startup/shutdown ensures single clk enable/disable call. Signed-off-by: Akshu Agrawal Signed-off-by: Vijendar Mukunda Reviewed-by: Daniel Kurtz ---

[PATCH 06/10] ASoC: amd: memory release for rtd structure

2018-05-07 Thread Vijendar Mukunda
rtd structure freed early may result in kernel panic in dma close call back. moved releasing memory for rtd structure to the end of dma close callback. Signed-off-by: Vijendar Mukunda Reviewed-by: Daniel Kurtz --- sound/soc/amd/acp-pcm-dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH 05/10] ASoC: amd: sram bank update changes

2018-05-07 Thread Vijendar Mukunda
Added sram bank variable to audio_substream_data structure. Signed-off-by: Vijendar Mukunda Reviewed-by: Daniel Kurtz --- sound/soc/amd/acp-pcm-dma.c | 20 +--- sound/soc/amd/acp.h | 20 ++-- 2 files changed, 19 insertions(+), 21 deletions(-) diff --git

[PATCH V2 04/10] ASoC: amd: pte offset related dma driver changes

2018-05-07 Thread Vijendar Mukunda
Added pte offset variable in audio_substream_data structure. Added Stoney related PTE offset macros in acp header file. Modified hw_params callback to assign the pte offset value based on asic_type. PTE Offset macros used to calculate no of PTE entries need to be programmed when memory allocated fo

[PATCH V2 03/10] ASoC: amd: removed separate byte count variables for playback and capture

2018-05-07 Thread Vijendar Mukunda
Removed separate byte count variables for playback and capture. Signed-off-by: Vijendar Mukunda Reviewed-by: Daniel Kurtz --- v1->v2: Fixed review comment in acp_dma_pointer callback sound/soc/amd/acp-pcm-dma.c | 19 +-- sound/soc/amd/acp.h | 3 +-- 2 files changed, 6 i

[PATCH V2 02/10] ASoC: amd: added byte count register offset variables to rtd

2018-05-07 Thread Vijendar Mukunda
Added byte count register offset variables to audio_substream_data structure. Modified dma pointer callback. Signed-off-by: Vijendar Mukunda Reviewed-by: Daniel Kurtz --- v1->v2: Fixed Indentation issues sound/soc/amd/acp-pcm-dma.c | 36 +++- sound/soc/amd/acp.h

[PATCH V2 01/10] ASoC: amd: dma config parameters changes

2018-05-07 Thread Vijendar Mukunda
Added dma configuration parameters to rtd structure. Moved dma configuration parameters initialization to hw_params callback. Removed hard coding in prepare and trigger callbacks. Signed-off-by: Vijendar Mukunda Reviewed-by: Daniel Kurtz --- v1->v2 : Fixed capture stream wrong channel assignment

Re: [External] [RFC PATCH v1 3/6] mm, zone_type: create ZONE_NVM and fill into GFP_ZONE_TABLE

2018-05-07 Thread Randy Dunlap
On 05/07/2018 07:33 PM, Huaisheng HS1 Ye wrote: > diff --git a/mm/Kconfig b/mm/Kconfig > index c782e8f..5fe1f63 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -687,6 +687,22 @@ config ZONE_DEVICE > > +config ZONE_NVM > + bool "Manage NVDIMM (pmem) by memory management (EXPERIMENTAL)" > +

Re: [PATCH 4/9] hwmon: fschmd: fix typo 'can by' to 'can be'

2018-05-07 Thread Guenter Roeck
On 05/06/2018 04:23 AM, Wolfram Sang wrote: Signed-off-by: Wolfram Sang Applied to hwmon-next. Thanks, Guenter --- drivers/hwmon/fschmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/fschmd.c b/drivers/hwmon/fschmd.c index 5e78229ade049f..22d3a84f13ef

[PATCH v3] staging: lustre: o2iblnd: Enable Multiple OPA Endpoints between Nodes

2018-05-07 Thread Doug Oucharek
OPA driver optimizations are based on the MPI model where it is expected to have multiple endpoints between two given nodes. To enable this optimization for Lustre, we need to make it possible, via an LND-specific tuneable, to create multiple endpoints and to balance the traffic over them. Both si

[PATCH v1 04/13] drm/kms/mode/fsl-dcu: using helper func drm_display_mode_to_videomode for calculating timing parameters

2018-05-07 Thread Satendra Singh Thakur
-Using drm_display_mode_to_videomode to avoid duplicate logic -Removed index = drm_crtc_index(crtc) as it is unused -Replaced DRM_MODE_FLAG_* flags with DISPLAY_FLAGS_* flags -Replaced mode->h/vdisplay with vm.h/vactive Acked-by: Stefan Agner Signed-off-by: Satendra Singh Thakur Cc: Madhur Verma

Re: [PATCH] mm: expland documentation over __read_mostly

2018-05-07 Thread Joel Fernandes
On May 7, 2018 4:15:06 PM PDT, "Luis R. Rodriguez" wrote: >__read_mostly can easily be misused by folks, its not meant for >just read-only data. There are performance reasons for using it, but >we also don't provide any guidance about its use. Provide a bit more >guidance over it use. > >Signed-

Re: [PATCH net-next] net-next/hinic: add pci device ids for 25ge and 100ge card

2018-05-07 Thread David Miller
From: Zhao Chen Date: Mon, 7 May 2018 09:21:57 -0400 > This patch adds PCI device IDs to support 25GE and 100GE card: > > 1. Add device id 0x0201 for HINIC 100GE dual port card. > 2. Add device id 0x0200 for HINIC 25GE dual port card. > 3. Macro of device id 0x1822 is modified for HINIC 25GE qua

Re: [PATCH v3 2/3] usb: dwc3: Add Qualcomm DWC3 glue driver

2018-05-07 Thread Manu Gautam
On 5/5/2018 12:18 AM, Manu Gautam wrote: > DWC3 controller on Qualcomm SOCs has a Qscratch wrapper. > Some of its uses are described below resulting in need to > have a separate glue driver instead of using dwc3-of-simple: > - It exposes register interface to override vbus-override >and lane

Re: [PATCH] trivial: fix inconsistent help texts

2018-05-07 Thread David Miller
From: Georg Hofmann Date: Mon, 7 May 2018 14:03:18 +0200 > This patch removes "experimental" from the help text where depends on > CONFIG_EXPERIMENTAL was already removed. > > Signed-off-by: Georg Hofmann Applied.

Re: [PATCH v4 1/2] clk: x86: Add ST oscout platform clock

2018-05-07 Thread Agrawal, Akshu
On 5/8/2018 3:14 AM, Deucher, Alexander wrote: >> -Original Message- >> From: Agrawal, Akshu >> Sent: Monday, May 7, 2018 6:14 AM >> Cc: djku...@chromium.org; Agrawal, Akshu ; >> Deucher, Alexander ; >> mturque...@baylibre.com; sb...@kernel.org; Koenig, Christian >> ; airl...@redhat.com;

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

2018-05-07 Thread Masami Hiramatsu
On Mon, 7 May 2018 11:30:03 -0400 Steven Rostedt wrote: > On Sun, 6 May 2018 00:51:43 +0900 > Masami Hiramatsu wrote: > > > OK, now I think it is a time to introduce new unified interface for dynamic > > events, > > tracefs/dynamic_events and make uprobe_events and kprobe_events as > > symbol

Re: [PATCH v2 6/7] ocxl: Add an IOCTL so userspace knows what CPU features are available

2018-05-07 Thread Alastair D'Silva
On Tue, 2018-05-08 at 13:50 +1000, Nicholas Piggin wrote: > On Tue, 08 May 2018 10:41:55 +1000 > "Alastair D'Silva" wrote: > > > On Mon, 2018-05-07 at 20:14 +0200, Frederic Barrat wrote: > > > > > > Le 18/04/2018 à 03:08, Alastair D'Silva a écrit : > > > > From: Alastair D'Silva > > > > > >

Re: [PATCH] f2fs: fix to avoid race during access gc_thread pointer

2018-05-07 Thread Jaegeuk Kim
On 05/08, Chao Yu wrote: > Thread A Thread B > - f2fs_remount > - stop_gc_thread > - f2fs_sbi_store >sbi->gc_thread = NULL; > access sbi->gc_thread->gc_* > > Previously, we allocate memory for sbi->gc_thread ba

Re: [External] Re: [RFC PATCH v1 0/6] use mm to manage NVDIMM (pmem) zone

2018-05-07 Thread Dan Williams
On Mon, May 7, 2018 at 7:59 PM, Huaisheng HS1 Ye wrote: >> >>Dan Williams writes: >> >>> On Mon, May 7, 2018 at 11:46 AM, Matthew Wilcox >>wrote: On Mon, May 07, 2018 at 10:50:21PM +0800, Huaisheng Ye wrote: > Traditionally, NVDIMMs are treated by mm(memory management) >>subsystem as >>

Re: [PATCH v2 6/7] ocxl: Add an IOCTL so userspace knows what CPU features are available

2018-05-07 Thread Nicholas Piggin
On Tue, 08 May 2018 10:41:55 +1000 "Alastair D'Silva" wrote: > On Mon, 2018-05-07 at 20:14 +0200, Frederic Barrat wrote: > > > > Le 18/04/2018 à 03:08, Alastair D'Silva a écrit : > > > From: Alastair D'Silva > > > > > > In order for a userspace AFU driver to call the Power9 specific > > > OC

Re: [Ksummit-discuss] bug-introducing patches

2018-05-07 Thread Theodore Y. Ts'o
On Tue, May 08, 2018 at 02:34:41AM +, Sasha Levin via Ksummit-discuss wrote: > > Tony, I'm curious, how many users are you aware of who actually run > Linus's tree? All the users I've encountered so far on Azure seem to be > running something based on -stable. The people who run Linus's tree

Re: [PATCH] watchdog: mena21_wdt: Fix a possible data race in a21_wdt_set_timeout

2018-05-07 Thread Jia-Ju Bai
On 2018/5/8 11:42, Guenter Roeck wrote: On 05/07/2018 08:32 PM, Jia-Ju Bai wrote: On 2018/5/8 11:28, Guenter Roeck wrote: On 05/07/2018 08:18 PM, Jia-Ju Bai wrote: The write operation to "wdt->timeout" is protected by the lock on line 118, but the read operation to this data on line 105 is

Re: [PATCH 8/9] net: flow_dissector: fix typo 'can by' to 'can be'

2018-05-07 Thread David Miller
From: Wolfram Sang Date: Sun, 6 May 2018 13:23:52 +0200 > Signed-off-by: Wolfram Sang Applied.

[PATCH] ata: ata_piix: Fix a possible data race in piix_pci_device_resume

2018-05-07 Thread Jia-Ju Bai
The write operation to "host->flags" is protected by the lock on line 1048, but the read operation to this data on line 1046 is not protected by the lock. Thus, there may exist a data race for "host->flags". To fix this data race, the read operation to "host->flags" should be also protected by th

Re: [PATCH 1/7] cifs: smbd: Make upper layer decide when to destroy the transport

2018-05-07 Thread kbuild test robot
Hi Long, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on cifs/for-next] [also build test WARNING on v4.17-rc4 next-20180507] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH] watchdog: mena21_wdt: Fix a possible data race in a21_wdt_set_timeout

2018-05-07 Thread Guenter Roeck
On 05/07/2018 08:32 PM, Jia-Ju Bai wrote: On 2018/5/8 11:28, Guenter Roeck wrote: On 05/07/2018 08:18 PM, Jia-Ju Bai wrote: The write operation to "wdt->timeout" is protected by the lock on line 118, but the read operation to this data on line 105 is not protected by the lock. Thus, there may

Re: [PATCH 04/15] powerpc/powernv: opal-kmsg use flush fallback from console code

2018-05-07 Thread Nicholas Piggin
On Mon, 07 May 2018 20:36:39 +1000 Michael Ellerman wrote: > Nicholas Piggin writes: > > On Fri, 04 May 2018 15:16:37 +1000 > > Michael Ellerman wrote: > >> Nicholas Piggin writes: > >> > Use the more refined and tested event polling loop from opal_put_chars > >> > as the fallback console

[PATCH] f2fs: fix to avoid race during access gc_thread pointer

2018-05-07 Thread Chao Yu
Thread AThread B - f2fs_remount - stop_gc_thread - f2fs_sbi_store sbi->gc_thread = NULL; access sbi->gc_thread->gc_* Previously, we allocate memory for sbi->gc_thread based on background gc thread mount o

Re: [PATCH 09/24] selftests: ftrace: return Kselftest Skip code for skipped tests

2018-05-07 Thread Masami Hiramatsu
On Fri, 4 May 2018 19:13:13 -0600 "Shuah Khan (Samsung OSG)" wrote: > When ftrace test is skipped because of unmet dependencies and/or > unsupported configuration, it returns 0 which is treated as a pass > by the Kselftest framework. This leads to false positive result even > when the test could

Re: [PATCH 08/15] powerpc/powernv: implement opal_put_chars_atomic

2018-05-07 Thread Nicholas Piggin
On Mon, 07 May 2018 20:35:42 +1000 Michael Ellerman wrote: > Nicholas Piggin writes: > > > On Tue, 01 May 2018 19:48:58 +1000 > > Benjamin Herrenschmidt wrote: > > > >> On Tue, 2018-05-01 at 00:55 +1000, Nicholas Piggin wrote: > >> > The RAW console does not need writes to be atomic, so re

[PATCH] xen: xenbus: Fix a possible data race in xs_request_enter

2018-05-07 Thread Jia-Ju Bai
The read operation to "req->type" is protected by the lock on line 128, but the write operation to this data on line 118 is not protected by the lock. Thus, there may exist a data race for "req->type". To fix this data race, the write operation to "req->type" should be also protected by the lock.

Re: [PATCH] f2fs: fix to wait IO writeback in __revoke_inmem_pages()

2018-05-07 Thread Jaegeuk Kim
On 05/08, Chao Yu wrote: > On 2018/5/8 4:46, Jaegeuk Kim wrote: > > On 04/27, Chao Yu wrote: > >> On 2018/4/27 0:36, Jaegeuk Kim wrote: > >>> On 04/26, Chao Yu wrote: > On 2018/4/26 23:48, Jaegeuk Kim wrote: > > On 04/26, Chao Yu wrote: > >> Thread A Threa

Re: [PATCH] watchdog: mena21_wdt: Fix a possible data race in a21_wdt_set_timeout

2018-05-07 Thread Jia-Ju Bai
On 2018/5/8 11:28, Guenter Roeck wrote: On 05/07/2018 08:18 PM, Jia-Ju Bai wrote: The write operation to "wdt->timeout" is protected by the lock on line 118, but the read operation to this data on line 105 is not protected by the lock. Thus, there may exist a data race for "wdt->timeout". To

Re: [PATCH 2/2] net: nixge: Address compiler warnings about signedness

2018-05-07 Thread David Miller
From: Moritz Fischer Date: Fri, 4 May 2018 10:18:34 -0700 > Fixes the following warnings: > warning: pointer targets in passing argument 1 of > ‘is_valid_ether_addr’ differ in signedness [-Wpointer-sign] > if (mac_addr && is_valid_ether_addr(mac_addr)) { >

Re: [PATCH 1/2] net: nixge: Fix error path for obtaining mac address

2018-05-07 Thread David Miller
From: Moritz Fischer Date: Fri, 4 May 2018 10:18:33 -0700 > Fix issue where nixge_get_nvmem_address() returns a non-NULL > return value on a failed nvmem_cell_get() that causes an invalid > access when error value encoded in pointer is dereferenced. > > Furthermore ensure that buffer allocated

Re: [PATCH 09/24] selftests: ftrace: return Kselftest Skip code for skipped tests

2018-05-07 Thread Masami Hiramatsu
On Mon, 7 May 2018 11:17:21 -0400 Steven Rostedt wrote: > On Fri, 4 May 2018 19:13:13 -0600 > "Shuah Khan (Samsung OSG)" wrote: > > > When ftrace test is skipped because of unmet dependencies and/or > > unsupported configuration, it returns 0 which is treated as a pass > > by the Kselftest fra

Re: [PATCH] selftests: net: use TEST_PROGS_EXTENDED

2018-05-07 Thread David Miller
From: Anders Roxell Date: Fri, 4 May 2018 18:47:25 +0200 > When a script file that isn't generated uses the variable > TEST_GEN_PROGS_EXTENDED and a 'make -C tools/testing/selftests clean' is > performed the script file gets removed and git shows the file as > deleted. For script files that isn'

Re: [PATCH] watchdog: mena21_wdt: Fix a possible data race in a21_wdt_set_timeout

2018-05-07 Thread Guenter Roeck
On 05/07/2018 08:18 PM, Jia-Ju Bai wrote: The write operation to "wdt->timeout" is protected by the lock on line 118, but the read operation to this data on line 105 is not protected by the lock. Thus, there may exist a data race for "wdt->timeout". To fix this data race, the read operation to "

  1   2   3   4   5   6   7   8   9   10   >