[PATCH] staging: greybus: Remove unused local variable

2018-05-05 Thread Nathan Chancellor
Fixes the following W=1 warning: variable ‘intf_id’ set but not used [-Wunused-but-set-variable] Signed-off-by: Nathan Chancellor --- drivers/staging/greybus/svc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/greybus/svc.c b/drivers/staging/greybus/svc.c index a874fed761

Re: [PATCH 0/7] gnss: add new GNSS subsystem

2018-05-05 Thread Marcel Holtmann
Hi Pavel, (*) I have those in mind: Nokia N900: The phone has GPS integrated into the modem and uses ISI encapsulated data. The protocol has been reverse engineered and it should be possible to write a kernel driver for handling the GPS packets and dumping the raw da

[PATCH V7 2/7] ARM: dts: imx6sx-sabreauto: add max7322 IO expander support

2018-05-05 Thread Anson Huang
Add MAX7322 IO expander support. Signed-off-by: Anson Huang --- changes since V6: remove unnecessary sign-off. arch/arm/boot/dts/imx6sx-sabreauto.dts | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dt

[PATCH V7 4/7] ARM: dts: imx6sx-sabreauto: add fec support

2018-05-05 Thread Anson Huang
Add FEC support on i.MX6SX Sabre Auto board. Signed-off-by: Anson Huang --- changes since V6: remove unnecessary sign-off and remove unused regulator for adjusting fec IO voltage. arch/arm/boot/dts/imx6sx-sabreauto.dts | 69 ++ 1 file changed, 69 insertio

[PATCH V7 3/7] ARM: dts: imx6sx-sabreauto: add IO expander max7310 support

2018-05-05 Thread Anson Huang
i.MX6SX Sabre Auto board has two max7310 IO expander on I2C3 bus, add support for them. Signed-off-by: Anson Huang --- changes since V6: remove unnecessary sign-off. arch/arm/boot/dts/imx6sx-sabreauto.dts | 28 1 file changed, 28 insertions(+) diff --git a/a

[PATCH V7 6/7] ARM: dts: imx6sx-sabreauto: add debug LED support

2018-05-05 Thread Anson Huang
There is a debug LED(D11) connected to GPIO1_IO24, add support for it. Signed-off-by: Anson Huang --- no change. arch/arm/boot/dts/imx6sx-sabreauto.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabre

[PATCH V7 7/7] ARM: dts: imx6sx-sabreauto: add egalax touch screen support

2018-05-05 Thread Anson Huang
Add egalax touch screen support on i2c2 bus. Signed-off-by: Anson Huang --- changes since V6: remove unnecessary sign-off, improve node name and add PAD setting value. arch/arm/boot/dts/imx6sx-sabreauto.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/b

[PATCH V7 5/7] ARM: dts: imx6sx-sabreauto: add wdog external reset

2018-05-05 Thread Anson Huang
i.MX6SX Sabre Auto board has GPIO1_IO13 pin can be MUXed as WDOG output to reset PMIC, add this function support. Signed-off-by: Anson Huang --- no change. arch/arm/boot/dts/imx6sx-sabreauto.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.

[PATCH V7 1/7] ARM: dts: imx6sx-sabreauto: add PMIC support

2018-05-05 Thread Anson Huang
Add pfuze100 support on i.MX6SX Sabre Auto board. Signed-off-by: Anson Huang --- changes since V6: remove unnecessary sign-off. arch/arm/boot/dts/imx6sx-sabreauto.dts | 116 + 1 file changed, 116 insertions(+) diff --git a/arch/arm/boot/dts/imx6sx-sabreau

Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource

2018-05-05 Thread Baoquan He
On 04/26/18 at 11:01am, kbuild test robot wrote: > Hi Baoquan, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.17-rc2 next-20180424] > [if your patch is applied to the wrong git tree, please drop us a note to > help impr

Re: [PATCH v3 1/3] resource: Use list_head to link sibling resource

2018-05-05 Thread Baoquan He
On 04/26/18 at 11:23am, kbuild test robot wrote: > Hi Baoquan, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.17-rc2 next-20180424] > [if your patch is applied to the wrong git tree, please drop us a note to > help impr

Re: [PATCH v3 2/3] resource: add walk_system_ram_res_rev()

2018-05-05 Thread Baoquan He
On 05/04/18 at 12:16pm, Borislav Petkov wrote: > On Thu, Apr 26, 2018 at 09:22:04PM +0800, Baoquan He wrote: > > I noticed maintainers merged patches with this Message-ID, could you > > tell how to get this Message-ID? > > https://en.wikipedia.org/wiki/Message-ID thx. > > > This is not a thing th

Re: [PATCH v3 3/5] kernel hacking: new config NO_AUTO_INLINE to disable compiler auto-inline optimizations

2018-05-05 Thread kbuild test robot
Hi Changbin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.17-rc3 next-20180504] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-

RE: [PATCH V6 7/7] ARM: dts: imx6sx-sabreauto: add egalax touch screen support

2018-05-05 Thread Anson Huang
Hi, Fabio Anson Huang Best Regards! > -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: Saturday, May 5, 2018 11:18 PM > To: Anson Huang > Cc: Shawn Guo ; Sascha Hauer > ; Fabio Estevam ; Rob > Herring ; Mark Rutland ; > Haibo Chen ; Andy Duan > ; A.s. Dong ;

RE: [PATCH V6 4/7] ARM: dts: imx6sx-sabreauto: add fec support

2018-05-05 Thread Anson Huang
Hi, Fabio Anson Huang Best Regards! > -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: Saturday, May 5, 2018 8:11 PM > To: Anson Huang > Cc: Shawn Guo ; Sascha Hauer > ; Fabio Estevam ; Rob > Herring ; Mark Rutland ; > Haibo Chen ; Andy Duan > ; A.s. Dong ; R

RE: [PATCH V6 7/7] ARM: dts: imx6sx-sabreauto: add egalax touch screen support

2018-05-05 Thread Anson Huang
Hi, Fabio Anson Huang Best Regards! > -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: Saturday, May 5, 2018 7:56 PM > To: Anson Huang > Cc: Shawn Guo ; Sascha Hauer > ; Fabio Estevam ; Rob > Herring ; Mark Rutland ; > Haibo Chen ; Andy Duan > ; A.s. Dong ; R

Re: [PATCH] nubus: Unconditionally register bus type

2018-05-05 Thread Finn Thain
On Sat, 5 May 2018, Greg Kroah-Hartman wrote: > On Sun, May 06, 2018 at 11:47:52AM +1000, Finn Thain wrote: > > Loading a NuBus driver module on a non-NuBus machine triggers the > > BUG_ON(!drv->bus->p) in driver_register() because the bus does not get > > registered unless MACH_IS_MAC(). Avoid th

[PATCH] scsi: 3ware: fix a missing-check bug

2018-05-05 Thread Wenwen Wang
In twl_chrdev_ioctl(), the ioctl driver command is firstly copied from the userspace pointer 'argp' and saved to the kernel object 'driver_command'. Then a security check is performed on the data buffer size indicated by 'driver_command', which is 'driver_command.buffer_length'. If the security che

Re: [PATCH v3 3/5] kernel hacking: new config NO_AUTO_INLINE to disable compiler auto-inline optimizations

2018-05-05 Thread kbuild test robot
Hi Changbin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.17-rc3 next-20180504] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-

[PATCH] scsi: 3w-xxxx: fix a missing-check bug

2018-05-05 Thread Wenwen Wang
In tw_chrdev_ioctl(), the length of the data buffer is firstly copied from the userspace pointer 'argp' and saved to the kernel object 'data_buffer_length'. Then a security check is performed on it to make sure that the length is not more than 'TW_MAX_IOCTL_SECTORS * 512'. Otherwise, an error code

[PATCH v3] block: add verifier for cmdline partition

2018-05-05 Thread Wang YanQing
I meet strange filesystem corruption issue recently, the reason is there are overlaps partitions in cmdline partition argument. This patch add verifier for cmdline partition, then if there are overlaps partitions, cmdline_partition will log a warning. Signed-off-by: Wang YanQing --- Changes v2

Re: [PATCH 8/8] rhashtable: don't hold lock on first table throughout insertion.

2018-05-05 Thread Herbert Xu
On Sun, May 06, 2018 at 08:00:49AM +1000, NeilBrown wrote: > > The insert function must (and does) take the lock on the bucket before > testing if there is a "next" table. > If one inserter finds that it has locked the "last" table (because there > is no next) and successfully inserts, then the oth

Re: [PATCH 4/8] rhashtable: fix race in nested_table_alloc()

2018-05-05 Thread Herbert Xu
On Sun, May 06, 2018 at 07:48:20AM +1000, NeilBrown wrote: > > The spinlock protects 2 or more buckets. The nested table contains at > least 512 buckets, maybe more. > It is quite possible for two insertions into 2 different buckets to both > get their spinlock and both try to instantiate the same

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-05 Thread Tetsuo Handa
On 2018/05/06 11:24, Theodore Y. Ts'o wrote: > On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> EXT4-fs error (device loop0): ext4_iget:4756: inode #2: comm >> syz-executor909: root inode unallocated >> Kernel panic - not syncing: EX

Re: [PATCH] nubus: Unconditionally register bus type

2018-05-05 Thread Greg Kroah-Hartman
On Sun, May 06, 2018 at 11:47:52AM +1000, Finn Thain wrote: > Loading a NuBus driver module on a non-NuBus machine triggers the > BUG_ON(!drv->bus->p) in driver_register() because the bus does not get > registered unless MACH_IS_MAC(). Avoid this by registering the bus > unconditionally using postc

[PATCH v2] block: add verifier for cmdline partition

2018-05-05 Thread Wang YanQing
I meet strange filesystem corruption issue recently, the reason is there are overlaps partitions in cmdline partition argument. This patch add verifier for cmdline partition, then if there are overlaps partitions, cmdline_partition will log a warning. We don't treat overlaps partition as a error:

Re: [PATCH] x86/kvm: replace TASK_UNINTERRUPTIBLE with TASK_KILLABLE

2018-05-05 Thread Joey Pabalinas
On Thu, Mar 29, 2018 at 11:41:20PM +0200, Radim Krčmář wrote: > I remember we had a bug where tasks were getting stuck when running > nested and maybe there are going to be other cases to excuse the change. > I'm slightly against changing the behavior as it's pretty hard to test, > but I can be eas

Re: BUG: corrupted list in rdma_listen

2018-05-05 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:d2d741e5d189 kmsan: add initialization for shmem pages git tree: https://github.com/google/kmsan.git/master console output: https://syzkaller.appspot.com/x/log.txt?x=126df29780 kernel config: https://syzkaller.ap

[PATCH] scsi: 3w-9xxx: fix a missing-check bug

2018-05-05 Thread Wenwen Wang
In twa_chrdev_ioctl(), the ioctl driver command is firstly copied from the userspace pointer 'argp' and saved to the kernel object 'driver_command'. Then a security check is performed on the data buffer size indicated by 'driver_command', which is 'driver_command.buffer_length'. If the security che

Re: [PATCH 05/12] perf pmu: Fix pmu events parsing rule

2018-05-05 Thread Andi Kleen
Jiri Olsa writes: Please fix this quickly, PT is currently totally non functional in Linus mainline. -Andi

[PATCH] virt: vbox: fix a missing-check bug

2018-05-05 Thread Wenwen Wang
In vbg_misc_device_ioctl(), the header of the ioctl argument is copied from the userspace pointer 'arg' and saved to the kernel object 'hdr'. Then the 'version', 'size_in', and 'size_out' fields of 'hdr' are verified. For example, if 'hdr.version' is not VBG_IOCTL_HDR_VERSION, an error code -EINVAL

[PATCH] scsi: sg: fix a missing-check bug

2018-05-05 Thread Wenwen Wang
In sg_write(), the opcode of the command is firstly copied from the userspace pointer 'buf' and saved to the kernel variable 'opcode', using the __get_user() function. The size of the command, i.e., 'cmd_size' is then calculated based on the 'opcode'. After that, the whole command, including the op

Re: [PATCH v2 2/2] MIPS: Convert update_persistent_clock() to update_persistent_clock64()

2018-05-05 Thread Arnd Bergmann
On Fri, May 4, 2018 at 3:07 AM, Baolin Wang wrote: > Since struct timespec is not y2038 safe on 32bit machines, this patch > converts update_persistent_clock() to update_persistent_clock64() using > struct timespec64. > > The rtc_mips_set_time() and rtc_mips_set_mmss() interfaces were using > 'uns

Re: [RFC PATCH] locking/atomics/powerpc: Introduce optimized cmpxchg_release() family of APIs for PowerPC

2018-05-05 Thread Benjamin Herrenschmidt
On Sat, 2018-05-05 at 12:00 +0200, Ingo Molnar wrote: > This clearly suggests that PPC_RELEASE_BARRIER is in active use and 'lwsync' > is > the 'release barrier' instruction, if I interpreted that right. The closest to one we got. The semantics are that it orders all load/store pairs to cachabl

Re: crosstool requirements?

2018-05-05 Thread Arnd Bergmann
On Sat, May 5, 2018 at 2:20 PM, Randy Dunlap wrote: > Hi Arnd, > > I was trying to use the x86_64 hosted openrisc/or1k gcc compiler > (7.3.0-nolibc) > but I mostly what I get are errors like the following: > > crosstool/gcc-7.3.0-nolibc/or1k-linux/bin/../libexec/gcc/or1k-linux/7.3.0/cc1: > error

Re: kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-05 Thread Theodore Y. Ts'o
On Sat, May 05, 2018 at 05:57:02PM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > EXT4-fs error (device loop0): ext4_iget:4756: inode #2: comm > syz-executor909: root inode unallocated > Kernel panic - not syncing: EXT4-fs (device loop0): panic forced after error I do

[GIT PULL] platform-drivers-x86 for 4.17-2

2018-05-05 Thread Darren Hart
Hi Linus, I was trying to keep DELL_LAPTOP visible in the menu, but the "select" behavior makes that impossible. I'm planning on refactoring the Kconfig by vendor for those with many options in 4.18 which should clean things up. This fix from Mario corrects the potential for misconfiguration for 4

Re: [Intel-wired-lan] [PATCH v2 1/1] drivers core: multi-threading device shutdown

2018-05-05 Thread kbuild test robot
Hi Pavel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on driver-core/driver-core-testing] [also build test WARNING on v4.17-rc3 next-20180504] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://

[RFC PATCH] drivers core: device_root_tasks_done can be static

2018-05-05 Thread kbuild test robot
Fixes: 6d54ba128905 ("drivers core: multi-threading device shutdown") Signed-off-by: Fengguang Wu --- core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 110d797..666c163 100644 --- a/drivers/base/core.c +++ b/drivers/base

[PATCH] nubus: Unconditionally register bus type

2018-05-05 Thread Finn Thain
Loading a NuBus driver module on a non-NuBus machine triggers the BUG_ON(!drv->bus->p) in driver_register() because the bus does not get registered unless MACH_IS_MAC(). Avoid this by registering the bus unconditionally using postcore_initcall(). Cc: Greg Kroah-Hartman Reported-by: Michael Schmit

Re: moving affs + RDB partition support to staging?

2018-05-05 Thread Al Viro
On Thu, Apr 26, 2018 at 12:45:41PM +0200, John Paul Adrian Glaubitz wrote: > Exactly. It works fine as is: > > root@elgar:~> uname -a > Linux elgar 4.16.0-rc2-amiga-16784-ga8917fc #650 Mon Mar 5 15:32:52 NZDT 2018 > m68k GNU/Linux > root@elgar:~> mount /dev/sda1 /mnt -taffs > root@elgar:~> ls -l

BUG: please report to d...@vger.kernel.org => prev = 0, last = 0 at net/dccp/ccids/lib/packet_history.c:LINE/tfrc_rx_his

2018-05-05 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:c1c07416cdd4 Merge tag 'kbuild-fixes-v4.17' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13d5de4780 kernel config: https://syzkaller.appspot.com/x/.config?x=5a1dc06635c10d27 da

kernel panic: EXT4-fs (device loop0): panic forced after error

2018-05-05 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:c1c07416cdd4 Merge tag 'kbuild-fixes-v4.17' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11a8a07b80 kernel config: https://syzkaller.appspot.com/x/.config?x=5a1dc06635c10d27 da

Re: drivers/gpu/drm/bridge/sil-sii8620.c:2229: undefined reference to `extcon_find_edev_by_node'

2018-05-05 Thread Randy Dunlap
On 05/05/2018 04:22 PM, kbuild test robot wrote: > Hi Maciej, > > FYI, the error/warning still remains. Hi M. Robot, I am cc-ing dri-de...@lists.freedesktop.org so that they are aware of the multiple times that you have posted this kbuild error (I have 3 different posts in my Inbox with the same

[PATCH v3 4/5] kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to apply GCC -Og optimization

2018-05-05 Thread changbin . du
From: Changbin Du This will apply GCC '-Og' optimization level which is supported since GCC 4.8. This optimization level offers a reasonable level of optimization while maintaining fast compilation and a good debugging experience. It is similar to '-O1' while perferring to keep debug ability over

[PATCH v3 2/5] regulator: add dummy function of_find_regulator_by_node

2018-05-05 Thread changbin . du
From: Changbin Du If device tree is not enabled, of_find_regulator_by_node() should have a dummy function since the function call is still there. This is to fix build error after CONFIG_NO_AUTO_INLINE is introduced. If this option is enabled, GCC will not auto-inline functions that are not expli

[PATCH v3 3/5] kernel hacking: new config NO_AUTO_INLINE to disable compiler auto-inline optimizations

2018-05-05 Thread changbin . du
From: Changbin Du This patch add a new kernel hacking option NO_AUTO_INLINE. Selecting this option will prevent the compiler from optimizing the kernel by auto-inlining functions not marked with the inline keyword. With this option, only functions explicitly marked with "inline" will be inlined.

[PATCH v3 5/5] asm-generic: fix build error in fix_to_virt with CONFIG_CC_OPTIMIZE_FOR_DEBUGGING

2018-05-05 Thread changbin . du
From: Changbin Du With '-Og' optimization level, GCC would not optimize a count for a loop as a constant value. But BUILD_BUG_ON() only accept compile-time constant values. Let's use __fix_to_virt() to avoid the error. arch/arm/mm/mmu.o: In function `fix_to_virt': /home/changbin/work/linux/./inc

[PATCH v3 0/5] kernel hacking: GCC optimization for better debug experience (-Og)

2018-05-05 Thread changbin . du
From: Changbin Du Hi all, I know some kernel developers was searching for a method to dissable GCC optimizations, probably they want to apply GCC '-O0' option. But since Linux kernel replys on GCC optimization to remove some dead code, so '-O0' just breaks the build. They do need this because the

[PATCH v3 1/5] x86/mm: surround level4_kernel_pgt with #ifdef CONFIG_X86_5LEVEL...#endif

2018-05-05 Thread changbin . du
From: Changbin Du The level4_kernel_pgt is only defined when X86_5LEVEL is enabled. So surround level4_kernel_pgt with #ifdef CONFIG_X86_5LEVEL...#endif to make code correct. Signed-off-by: Changbin Du --- arch/x86/include/asm/pgtable_64.h | 2 ++ arch/x86/kernel/head64.c | 13 ++

Re: [PATCH v2 4/5] kernel hacking: new config DEBUG_EXPERIENCE to apply GCC -Og optimization

2018-05-05 Thread Randy Dunlap
On 05/05/2018 04:57 PM, Du, Changbin wrote: > On Thu, May 03, 2018 at 10:28:23AM -0400, Steven Rostedt wrote: >> On Thu, 3 May 2018 21:45:46 +0800 >> "Du, Changbin" wrote: >> With that gcc comment, I still think CONFIG_OPTIMIZE_DEBUG is more inline with what it is and understandable than

Re: [PATCH v2 4/5] kernel hacking: new config DEBUG_EXPERIENCE to apply GCC -Og optimization

2018-05-05 Thread Du, Changbin
On Thu, May 03, 2018 at 10:28:23AM -0400, Steven Rostedt wrote: > On Thu, 3 May 2018 21:45:46 +0800 > "Du, Changbin" wrote: > > > > With that gcc comment, I still think CONFIG_OPTIMIZE_DEBUG is more > > > inline with what it is and understandable than > > > CONFIG_DEBUG_EXPERIENCE. The "OPTIMIZE"

[GIT PULL] USB driver fixes for 4.17-rc4

2018-05-05 Thread Greg KH
The following changes since commit 6da6c0db5316275015e8cc2959f12a17584aeb64: Linux v4.17-rc3 (2018-04-29 14:17:42 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.17-rc4 for you to fetch changes up to 6844dc42722cac3776

drivers/gpu/drm/bridge/sil-sii8620.c:2229: undefined reference to `extcon_find_edev_by_node'

2018-05-05 Thread kbuild test robot
Hi Maciej, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: c1c07416cdd47161a359286021d483f449ad8c4f commit: 688838442147d9dd94c2ef7c2c31a35cf150c5fa drm/bridge/sii8620: use micro-USB cable detection logic to detect

Re: [PATCH v4 05/22] iommu: introduce iommu invalidate API function

2018-05-05 Thread Jerry Snitselaar
On Mon Apr 16 18, Jacob Pan wrote: From: "Liu, Yi L" When an SVM capable device is assigned to a guest, the first level page tables are owned by the guest and the guest PASID table pointer is linked to the device context entry of the physical IOMMU. Host IOMMU driver has no knowledge of cachin

Re: WARNING in kernfs_add_one

2018-05-05 Thread Greg KH
On Sat, May 05, 2018 at 10:43:45AM -0700, Eric Dumazet wrote: > > > On 05/05/2018 09:40 AM, Greg KH wrote: > > On Sat, May 05, 2018 at 08:47:02AM -0700, syzbot wrote: > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit:8fb11a9a8d51 net/ipv6: rename rt6_next to fib

Re: [PATCH 8/8] rhashtable: don't hold lock on first table throughout insertion.

2018-05-05 Thread NeilBrown
On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> rhashtable_try_insert() currently hold a lock on the bucket in >> the first table, while also locking buckets in subsequent tables. >> This is unnecessary and looks like a hold-over from some ear

Re: [PATCH 6/8] rhashtable: further improve stability of rhashtable_walk

2018-05-05 Thread NeilBrown
On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> If the sequence: >>obj = rhashtable_walk_next(iter); >>rhashtable_walk_stop(iter); >>rhashtable_remove_fast(ht, &obj->head, params); >>rhashtable_walk_start(iter); >> >> races w

Re: [PATCH 1/8] rhashtable: silence RCU warning in rhashtable_test.

2018-05-05 Thread NeilBrown
On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> print_ht in rhashtable_test calls rht_dereference() with neither >> RCU protection or the mutex. This triggers an RCU warning. >> So take the mutex to silence the warning. >> >> Signed-off-by:

Re: [PATCH 4/8] rhashtable: fix race in nested_table_alloc()

2018-05-05 Thread NeilBrown
On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> If two threads run nested_table_alloc() at the same time >> they could both allocate a new table. >> Best case is that one of them will never be freed, leaking memory. >> Worst case is hat entry

Re: [PATCH 3/8] rhashtable: use cmpxchg() to protect ->future_tbl.

2018-05-05 Thread NeilBrown
On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> Rather than borrowing one of the bucket locks to >> protect ->future_tbl updates, use cmpxchg(). >> This gives more freedom to change how bucket locking >> is implemented. >> >> Signed-off-by: N

Handling lm3559 flash on Motorola Droid 4 and others

2018-05-05 Thread Pavel Machek
Hi! It seems lm3559 flash driver is available on github ( https://github.com/ZenfoneArea/android_kernel_asus_zenfone5/tree/master/linux/modules/camera/drivers/media/i2c ) but there'll be some fun getting it cleaned up and merged. Did anyone start doing anything in that area? Is there possibly bet

[RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit

2018-05-05 Thread Andrea Greco
From: Andrea Greco If com20020 clock is major of 40Mhz SLOWARB bit is requested. Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index f09ea77dd6a8..abd32ed8ec9b

Re: [PATCH 2/8] rhashtable: remove nulls_base and related code.

2018-05-05 Thread NeilBrown
On Sat, May 05 2018, Herbert Xu wrote: > On Fri, May 04, 2018 at 01:54:14PM +1000, NeilBrown wrote: >> This "feature" is unused, undocumented, and untested and so >> doesn't really belong. If a use for the nulls marker >> is found, all this code would need to be reviewed to >> ensure it works as

[RFC PATCH 1/3] arcnet: com20020: Add memory map of com20020

2018-05-05 Thread Andrea Greco
From: Andrea Greco Add support for com20022I/com20020, memory mapped chip version. Support bus: Intel 80xx and Motorola 68xx. Bus size: Only 8 bit bus size is supported. Added related device tree bindings Signed-off-by: Andrea Greco --- .../devicetree/bindings/net/smsc-com20020.txt | 23

[RFC PATCH 3/3] arcnet: com20020: Add ethtool support

2018-05-05 Thread Andrea Greco
From: Andrea Greco Setup ethtols for export com20020 diag register Signed-off-by: Andrea Greco --- drivers/net/arcnet/com20020-isa.c| 1 + drivers/net/arcnet/com20020-membus.c | 1 + drivers/net/arcnet/com20020.c| 29 + drivers/net/arcnet/com20020.h

Re: [PATCH] ANDROID: binder: remove 32-bit binder interface.

2018-05-05 Thread kbuild test robot
/linux/commits/Martijn-Coenen/ANDROID-binder-remove-32-bit-binder-interface/20180505-130632 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin

Re: [PATCH 0/7] gnss: add new GNSS subsystem

2018-05-05 Thread Pavel Machek
Hi! > > > (*) I have those in mind: > > > > > > Nokia N900: The phone has GPS integrated into the modem and uses > > > ISI encapsulated data. The protocol has been reverse engineered > > > and it should be possible to write a kernel driver for handling > > > the GPS packets and dumping the raw da

RE: [PATCH] tpm: tpm_crb: relinquish locality on error path.

2018-05-05 Thread Winkler, Tomas
> > On Thu, May 03, 2018 at 06:42:26AM +, Winkler, Tomas wrote: > > > > > > > > > > > > > > > > On Tue, Apr 24, 2018 at 08:04:01PM +, Winkler, Tomas wrote: > > > > > > > Subject: Re: [PATCH] tpm: tpm_crb: relinquish locality on error > path. > > > > > > > > > > > > > > On Fri, Apr 20, 201

Re: [PATCH net-next v2 03/13] net: phy: sfp: warn the user when no tx_disable pin is available

2018-05-05 Thread Andrew Lunn
On Sat, May 05, 2018 at 01:38:31PM -0700, Florian Fainelli wrote: > On May 4, 2018 10:14:25 AM PDT, Andrew Lunn wrote: > >On Fri, May 04, 2018 at 10:07:53AM -0700, Florian Fainelli wrote: > >> On 05/04/2018 06:56 AM, Antoine Tenart wrote: > >> > In case no Tx disable pin is available the SFP modul

Re: [PATCH v3] sh: mm: Fix unprotected access to struct device

2018-05-05 Thread Rich Felker
On Thu, May 03, 2018 at 09:15:39AM +0200, jacopo mondi wrote: > Hi Christoph, > > On Wed, May 02, 2018 at 05:39:09AM -0700, Christoph Hellwig wrote: > > On Wed, May 02, 2018 at 09:46:31AM +0200, jacopo mondi wrote: > > > Hi again Christoph, > > > > > > The gentle ping actually applies to this

Re: [PATCH net-next v2 03/13] net: phy: sfp: warn the user when no tx_disable pin is available

2018-05-05 Thread Florian Fainelli
On May 4, 2018 10:14:25 AM PDT, Andrew Lunn wrote: >On Fri, May 04, 2018 at 10:07:53AM -0700, Florian Fainelli wrote: >> On 05/04/2018 06:56 AM, Antoine Tenart wrote: >> > In case no Tx disable pin is available the SFP modules will always >be >> > emitting. This could be an issue when using module

[PATCH] acpi: add missing prototype for ‘arch_post_acpi_subsys_init’

2018-05-05 Thread Mathieu Malaterre
In commit e7ff3a47630d ("x86/amd: Check for the C1E bug post ACPI subsystem init") a new function ‘arch_post_acpi_subsys_init’ was introduced. This weak function can potentially be overridden on a per arch basis, introduce the prototype for clarity. Silence the following gcc warning (W=1): init

Re: [PATCH net-next] net: phy: sfp: handle cases where neither BR,min nor BR,max is given

2018-05-05 Thread Florian Fainelli
On May 4, 2018 8:21:03 AM PDT, Antoine Tenart wrote: >When computing the bitrate using values read from an SFP module EEPROM, >we use the nominal BR plus BR,min and BR,max to determine the >boundaries. But in some cases BR,min and BR,max aren't provided, which >led the SFP code to end up having t

Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18

2018-05-05 Thread Krzysztof Halasa
"Luis R. Rodriguez" writes: > So we can nuke CONFIG_WANXL_BUILD_FIRMWARE now? I'm uncertain I understand why do you want it, or maybe what are you trying to do at all. And what use would wanxlfw.S (the assembly source) have if the option is removed? >> It's more about delivering the .S source

[PATCH] nvmem: properly handle returned value nvmem_reg_read

2018-05-05 Thread Mathieu Malaterre
Function nvmem_reg_read can return a non zero value indicating an error. This returned value must be read and error propagated to nvmem_cell_prepare_write_buffer. Silence the following gcc warning (W=1): drivers/nvmem/core.c:1093:9: warning: variable ‘rc’ set but not used [-Wunused-but-set-vari

[PATCH] mm: move function ‘is_pageblock_removable_nolock’ inside blockers

2018-05-05 Thread Mathieu Malaterre
Function ‘is_pageblock_removable_nolock’ is not used unless CONFIG_MEMORY_HOTREMOVE is activated. Move it in between #ifdef sentinel to match prototype in . Silence gcc warning (W=1): mm/page_alloc.c:7704:6: warning: no previous prototype for ‘is_pageblock_removable_nolock’ [-Wmissing-prototype

Re: [PATCH] tpm_tis: verify locality released before returning from release_locality

2018-05-05 Thread Jerry Snitselaar
On Sat May 05 18, Jerry Snitselaar wrote: For certain tpm chips releasing locality can take long enough that a subsequent call to request_locality will see the locality as being active when the access register is read in check_locality. So check that the locality has been released before returnin

[PATCH] slub: add __printf verification to ‘slab_err’:

2018-05-05 Thread Mathieu Malaterre
__printf is useful to verify format and arguments. Remove the following warning (with W=1): mm/slub.c:721:2: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] Signed-off-by: Mathieu Malaterre --- mm/slub.c | 2 +- 1 file changed, 1 i

[PATCH] ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static

2018-05-05 Thread Mathieu Malaterre
Since function ‘ext4_getfsmap_find_fixed_metadata’ can be made static, make it so. Remove the following gcc warning (W=1): fs/ext4/fsmap.c:405:5: warning: no previous prototype for ‘ext4_getfsmap_find_fixed_metadata’ [-Wmissing-prototypes] Signed-off-by: Mathieu Malaterre --- fs/ext4/fsmap.c

[PATCH] driver core: add __printf verification to __ata_ehi_pushv_desc

2018-05-05 Thread Mathieu Malaterre
__printf is useful to verify format and arguments. Remove the following warning (with W=1): drivers/ata/libata-eh.c:183:10: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] Signed-off-by: Mathieu Malaterre --- drivers/ata/libata-eh.

[PATCH] driver core: add __printf verification to device_create_groups_vargs

2018-05-05 Thread Mathieu Malaterre
__printf is useful to verify format and arguments. Remove the following warning (with W=1): drivers/base/core.c:2435:2: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] Signed-off-by: Mathieu Malaterre --- drivers/base/core.c | 2 +-

[PATCH] tpm_tis: verify locality released before returning from release_locality

2018-05-05 Thread Jerry Snitselaar
For certain tpm chips releasing locality can take long enough that a subsequent call to request_locality will see the locality as being active when the access register is read in check_locality. So check that the locality has been released before returning from release_locality. Cc: Jarkko Sakkine

[PATCH] agp: uninorth: make two functions static

2018-05-05 Thread Mathieu Malaterre
Both ‘uninorth_remove_memory’ and ‘null_cache_flush’ can be made static. So make them. Silence the following gcc warning (W=1): drivers/char/agp/uninorth-agp.c:198:5: warning: no previous prototype for ‘uninorth_remove_memory’ [-Wmissing-prototypes] and drivers/char/agp/uninorth-agp.c:473:

Re: Motorola Droid 4 progress, power consumption

2018-05-05 Thread Tony Lindgren
* Pavel Machek [180504 21:49]: > > > Battery is not user-replacable (and this will recalibrate itself on > > > charge/discharge cycle) so.. I don't think keying is strictly > > > neccessary for D4. > > > > Yeah right, that can be added later on if needed if you just > > plan accordingly. It's rep

[PATCH] isdn: eicon: fix a missing-check bug

2018-05-05 Thread Wenwen Wang
In divasmain.c, the function divas_write() firstly invokes the function diva_xdi_open_adapter() to open the adapter that matches with the adapter number provided by the user, and then invokes the function diva_xdi_write() to perform the write operation using the matched adapter. The two functions d

Kernel build with gcc 8 a lot of warnings

2018-05-05 Thread damian
Helllo together, Hello everybody, is something special to note when kernel build with gcc 8? I receive various warnings from the objtool: With GCC 7 works all fine. kernel/cgroup/cgroup.o: warning: objtool: parse_cgroup_root_flags()+0x40: sibling call from callable instruction with modified st

[PATCH RFC] drivers: nvmem: Export nvmem_add_cells()

2018-05-05 Thread Andrew Lunn
Not all platforms use device tree. It is useful to be able to add cells to a NVMEM device from code. Export nvmem_add_cells() so making this possible. This required changing the parameters a bit, so that just the cells and the number of cells are passed, not the whole nvmem config structure. Sign

[PATCH v3 2/9] ALSA: hda/ca0132: Add pincfg for SBZ + R3Di, add fp hp auto-detect

2018-05-05 Thread Connor McAdams
This patch adds an unsolicited response tag for the front headphone panel which uses the same hp_callback as the rear headphone detection. This patch also adds pincfgs for the R3Di and SBZ which were taken from the Windows driver. The pins are also defined in the function ca0132_config. Both the R

[PATCH v3 3/9] ALSA: hda/ca0132: Add PCI region2 iomap for SBZ

2018-05-05 Thread Connor McAdams
This patch adds iomapping for the region2 section of memory on the SBZ. This memory region is used in later patches for setting inputs and outputs. If the mapping fails, the quirk is changed back to QUIRK_NONE to avoid attempts to write to uninitialized memory. It also adds a new exit sequence to

[PATCH v3 7/9] ALSA: hda/ca0132: Add DSP Volume set and New mixers for SBZ + R3Di

2018-05-05 Thread Connor McAdams
Adds lookup table for floating point decibel volume, and new functions to allow for setting the decibel level on the DSP. Signed-off-by: Connor McAdams --- sound/pci/hda/patch_ca0132.c | 203 ++- 1 file changed, 202 insertions(+), 1 deletion(-) diff --git

[PATCH v3 8/9] ALSA: hda/ca0132: add ca0132_alt_set_vipsource

2018-05-05 Thread Connor McAdams
Add function to set vipsource on cards that use_alt_controls. Different sequence. Also, add cvoice_switch_set at end of ca0132_select_in so that when switching between inputs cvoice state is maintained. Signed-off-by: Connor McAdams --- sound/pci/hda/patch_ca0132.c | 71 +

[PATCH v3 5/9] ALSA: hda/ca0132: add/change helper functions for R3Di and SBZ

2018-05-05 Thread Connor McAdams
Edit core functions to support the Sound Blaster Z and Recon3Di for startup and loading of the DSP, as well as setting effects. Signed-off-by: Connor McAdams --- sound/pci/hda/patch_ca0132.c | 1064 -- 1 file changed, 1018 insertions(+), 46 deletions(-) d

[PATCH v3 9/9] ALSA: hda/ca0132: Add new control changes for SBZ + R3Di

2018-05-05 Thread Connor McAdams
This patch adds new controls to set the effect levels on the R3Di and SBZ. It also adds vmaster controls to control all surround sound channels. So that Surround effect switch doesn't conflict with Surround volume, FX: prefix added to all effect related switches. Tested-by: Mariusz Ceier Signed-o

[PATCH v3 1/9] ALSA: hda/ca0132: R3Di and SBZ quirk entires + alt firmware loading

2018-05-05 Thread Connor McAdams
This patch adds PCI quirk ID's for the Sound Blaster Z and Recon3Di. Only the currently tested ID's have been added. This patch also adds the ability to load alternative firmwares for each card, the firmwares can be obtained from within the Windows driver. The Recon3Di uses "ctefx-r3di.bin" and th

[PATCH v3 4/9] ALSA: hda/ca0132: Add extra exit functions for R3Di and SBZ

2018-05-05 Thread Connor McAdams
This patch adds extra functions for shutdown on the Sound Blaster Z and Recon3Di. The Recon3Di only has one specific functions, which sets the GPIO data pins to 0 to prevent a popping noise. The Sound Blaster Z exit sequence was taken from Windows. Without this exit function, the card will not rel

[PATCH v3 0/9] ALSA: hda/ca0132: Patch Series for Recon3Di and Sound Blaster Z Support

2018-05-05 Thread Connor McAdams
This patchset adds support for the Sound Blaster Z and the Recon3Di. In order to figure out how to get these cards to work, I made a program called QemuHDADump[1], which uses the trace function of qemu to see interactions with the memory mapped pci BAR space of the card being used in the virtual m

[PATCH v3 6/9] ALSA: hda/ca0132: add alt_select_in/out for R3Di + SBZ

2018-05-05 Thread Connor McAdams
Add functions ca0132_alt_select_out and ca0132_alt_select_in for switching outputs and inputs for r3di and sbz. Also, add enumerated controls for selecting output and input source. Signed-off-by: Connor McAdams --- sound/pci/hda/patch_ca0132.c | 597 +-- 1

[PATCH] crypto: chtls - fix a missing-check bug

2018-05-05 Thread Wenwen Wang
In do_chtls_setsockopt(), the tls crypto info is first copied from the poiner 'optval' in userspace and saved to 'tmp_crypto_info'. Then the 'version' of the crypto info is checked. If the version is not as expected, i.e., TLS_1_2_VERSION, error code -ENOTSUPP is returned to indicate that the provi

Re: [PATCH] net: dsa: drop some VLAs in switch.c

2018-05-05 Thread Andrew Lunn
> > You could make the bitmap part of the dsa_switch structure. This is > > allocated by dsa_switch_alloc() and is passed the number of ports. > > Doing the allocation there means you don't need to worry about it > > failing in dsa_switch_mdb_add() or dsa_switch_vlan_add(). > > Are dsa_switch_mdb_

  1   2   3   >