Re: [PATCH v4 3/5] pinctrl: add mt2712 pinctrl driver

2018-03-23 Thread Sean Wang
Hi, Zhiyong I got a warning when I applied the patch. Applying: pinctrl: add mt2712 pinctrl driver .git/rebase-apply/patch:679: new blank line at EOF. + warning: 1 line adds whitespace errors. It should probably happen at the last line in pinctrl-2712.c Apart from that Reviewed-by: Sean Wang

Re: Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle"

2018-03-23 Thread Vincent Guittot
Hi Heiner, Le Friday 23 Mar 2018 à 22:28:09 (+0100), Heiner Kallweit a écrit : > Recently I started to get the following problems with linux-next: > > - When working via Putty/SSH on the system the console frequently freezes > for few seconds. Sometimes only opening a second console makes the >

[PATCH 2/2] staging: ks7010: Fix spelling mistakes.

2018-03-23 Thread Quytelda Kahja
Fix two spelling mistakes in comments. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_hostif.h | 2 +- drivers/staging/ks7010/ks_wlan.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h i

[PATCH 1/2] staging: ks7010: Remove trailing "_t" from all structure names.

2018-03-23 Thread Quytelda Kahja
The "_t" suffix is not needed for structure names in this driver, and is a reflection of an older typedef system that is no longer in place. Remove the "_t" suffix from every structure defined in this driver. Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- drive

Re: [PATCH v4 7/8] clocksource: Add a new timer-ingenic driver

2018-03-23 Thread Daniel Lezcano
On 18/03/2018 00:29, Paul Cercueil wrote: > This driver will use the TCU (Timer Counter Unit) present on the Ingenic > JZ47xx SoCs to provide the kernel with a clocksource and timers. Please provide a more detailed description about the timer. Where is the clocksource ? I don't see the point of

Re: [PATCH v5 00/13] ARM: dts: ipq: updates to enable a few peripherals

2018-03-23 Thread sricharan
On 2018-03-24 07:47, Richard Cochran wrote: On Fri, Mar 23, 2018 at 03:48:43PM +0530, Sricharan R wrote: [v5] * Fixed a minor comment that i missed earlier. I tried booting this series with qcom_defconfig on my custom, dk07-like board. It works! Thanks. Can i take that as a Tested-by:

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

2018-03-23 Thread Joel Fernandes
On March 23, 2018 6:34:22 PM PDT, Quentin Perret wrote: >On Friday 23 Mar 2018 at 18:13:56 (-0700), Joel Fernandes wrote: >> Hi Morten, >> >> On Fri, Mar 23, 2018 at 8:47 AM, Morten Rasmussen >> wrote: >> > On Thu, Mar 22, 2018 at 01:10:22PM -0700, Joel Fernandes wrote: > >[...] > >> > You mea

Re: [PATCH 3/3] Storvsc: Select channel based on available percentage of ring buffer to write

2018-03-23 Thread kbuild test robot
Hi Long, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc6] [cannot apply to linus/master net-next/master net/master next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[REVIEW][PATCH 13/11] ipc/smack: Tidy up from the change in type of the ipc security hooks

2018-03-23 Thread Eric W. Biederman
Rename the variables shp, sma, msq to isp. As that is how the code already refers to those variables. Collapse smack_of_shm, smack_of_sem, and smack_of_msq into smack_of_ipc, as the three functions had become completely identical. Collapse smack_shm_alloc_security, smack_sem_alloc_security and s

[REVIEW][PATCH 12/11] ipc: Directly call the security hook in ipc_ops.associate

2018-03-23 Thread Eric W. Biederman
After the last round of cleanups the shm, sem, and msg associate operations just became trivial wrappers around the appropriate security method. Simplify things further by just calling the security method directly. Signed-off-by: "Eric W. Biederman" --- ipc/msg.c | 10 +- ipc/sem.c | 1

Re: [REVIEW][PATCH 03/11] msg/security: Pass kern_ipc_perm not msg_queue into the msg_queue security hooks

2018-03-23 Thread Eric W. Biederman
Casey Schaufler writes: > On 3/23/2018 12:16 PM, Eric W. Biederman wrote: >> All of the implementations of security hooks that take msg_queue only >> access q_perm the struct kern_ipc_perm member. This means the >> dependencies of the msg_queue security hooks can be simplified by >> passing the

Re: [PATCH]cgroup: __cpuset_node_allowed return bool

2018-03-23 Thread yuankuiz
From 304cec1cc42255fbd9e231a810f4eea20ab74b90 Mon Sep 17 00:00:00 2001 From: John Zhao Date: Sat, 24 Mar 2018 13:01:32 +0800 Subject: [PATCH] cgroup: __cpuset_node_allowed return bool as a bool, __cpuset_node_allowed(...) return should be bool. Signed-off-by: John Zhao --- kernel/cgroup/cpuse

[PATCH]cgroup: __cpuset_node_allowed return bool

2018-03-23 Thread yuankuiz
as a bool, __cpuset_node_allowed(...) return should be bool. Signed-off-by: John Zhao --- kernel/cgroup/cpuset.c.orig 2018-03-24 12:39:27.854178608 +0800 +++ kernel/cgroup/cpuset.c 2018-03-24 12:40:51.020708670 +0800 @@ -2552,7 +2552,7 @@ static struct cpuset *nearest_hardwall_a bool __cp

Re: [PATCH v2 0/2] Fix __earlycon_table stride... again

2018-03-23 Thread Daniel Kurtz
On Fri, Mar 23, 2018 at 7:34 AM Greg Kroah-Hartman < gre...@linuxfoundation.org> wrote: > On Tue, Mar 20, 2018 at 11:57:10AM -0600, Daniel Kurtz wrote: > > The __earlycon_table lives in a special "__earlycon_table" section. The > > contents of this table are added using some macros that deposit i

Re: [PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct

2018-03-23 Thread Matthew Wilcox
> So, introduce a new rwlock in mm_struct to protect the concurrent access > to arg_start|end and env_start|end. I don't think an rwlock makes much sense here. There is almost no concurrency on the read side, and an rwlock is more expensive than a spinlock. Just use a spinlock.

[PATCH 2/3] ieee80211: Replace bit shifts with the BIT() macro for measurement masks.

2018-03-23 Thread Quytelda Kahja
It is neater and more consistent with the rest of the document to use the BIT() macro from 'linux/bitops.h' to define the IEEE80211_SPCT_MSR_RPRT_MODE_* bitmasks. Signed-off-by: Quytelda Kahja --- include/linux/ieee80211.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 3/3] ieee80211: Replace bit shifts with the BIT() macro for 802.11g ERP IEs.

2018-03-23 Thread Quytelda Kahja
It is neater and more consistent with the rest of the document to use the BIT() macro from 'linux/bitops.h' to define the WLAN_ERP_* bitmasks. Signed-off-by: Quytelda Kahja --- include/linux/ieee80211.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/ieee8

[PATCH 1/3] ieee80211: Replace bit shifts with the BIT() macro for WLAN_CAPABILITY_*.

2018-03-23 Thread Quytelda Kahja
It is neater and more consistent with the rest of the document to use the BIT() macro from 'linux/bitops.h' to define the WLAN_CAPABILITY_* bitmasks. In the case of WLAN_CAPABILITY_DMG_TYPE_{IBSS, PBSS, AP}, bitshifting integers by 0 does nothing, so there is no reason to do it in the code; replac

Re: [PATCH v6 6/6] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs

2018-03-23 Thread Sinan Kaya
On 3/23/2018 6:36 PM, Michael Chan wrote: >> + mmiowb(); > Sorry for the late review. mmiowb() is not required here because we > are in NAPI context, so only one CPU will be updating this doorbell. > > Other than that, it looks good. > OK, I'll fix this on the next version. -- S

Re: [PATCH v3 01/11] PCI/P2PDMA: Support peer-to-peer memory

2018-03-23 Thread Bjorn Helgaas
On Fri, Mar 23, 2018 at 03:59:14PM -0600, Logan Gunthorpe wrote: > On 23/03/18 03:50 PM, Bjorn Helgaas wrote: > > Popping way up the stack, my original point was that I'm trying to > > remove restrictions on what devices can participate in > > peer-to-peer DMA. I think it's fairly clear that in co

[PATCH net-next 1/5] net: hns3: fix for returning wrong value problem in hns3_get_rss_key_size

2018-03-23 Thread Peng Li
From: Fuyun Liang The return type of hns3_get_rss_key_size is u32. But a negative value is returned. This patch fixes it by replacing the negative value with zero. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +- 1 file changed,

[PATCH net-next 4/5] net: hns3: fix for not initializing VF rss_hash_key problem

2018-03-23 Thread Peng Li
From: Fuyun Liang Default rss_hash_key value should be given to all vports. But just the PF rss_hash_key has the default value here. This patch adds rss_hash_key Initialization for all vports. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hcl

[PATCH net-next 5/5] net: hns3: never send command queue message to IMP when reset

2018-03-23 Thread Peng Li
IMP will not handle and command queue message any more when it is in core/global, driver should not send command queue message to IMP until reinitialize the NIC HW. This patch checks the status and avoid the message sent to IMP when reset. Signed-off-by: Peng Li --- .../ethernet/hisilicon/hns3/

[PATCH net-next 3/5] net: hns3: fix for the wrong shift problem in hns3_set_txbd_baseinfo

2018-03-23 Thread Peng Li
From: Fuyun Liang Third parameter of hnae_set_field is shift, But a mask is given. This patch fixes it by replacing HNS3_TXD_BDTYPE_M with HNS3_TXD_BDTYPE_S. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- 1 file changed, 1 inserti

[PATCH net-next 2/5] net: hns3: fix for returning wrong value problem in hns3_get_rss_indir_size

2018-03-23 Thread Peng Li
From: Fuyun Liang The return type of hns3_get_rss_indir_size is u32. But a negative value is returned. This patch fixes it by replacing the negative value with zero. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +- 1 file changed

[PATCH net-next 0/5] fix some bugs for HNS3

2018-03-23 Thread Peng Li
This patchset fixes some bugs for HNS3 driver: [Patch 1/5 - 2/5] fix 2 return vlaue issues. [Patch 3/5 - 4/5] fix 2 comments reported by code review. [Ptach 5/5] avoid sending message to IMP because IMP will not handle any message when it is resetting. Fuyun Liang (4): net: hns3: fix for returni

[PATCH 3/3] module: Support to disable validity enforcement in runtime

2018-03-23 Thread Jia Zhang
In order to disable the module validity enforcement, writing a PKCS#7 signature corresponding the signed content '0' is required. Given a simple way to archive this: $ echo -n 0 > no_sig_enforce $ openssl smime -sign -nocerts -noattr -binary \ -in no_sig_enforce -inkey \ -signer -outform

[PATCH 2/3] module: Create the entry point initialize_module()

2018-03-23 Thread Jia Zhang
This entry point currently includes the procfs initialization, and will include a securityfs initialization. Signed-off-by: Jia Zhang --- kernel/module.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/kernel/module.c b/kernel/module.c index 003d0ab..79825ea 10

[PATCH 1/3] module: Do not access sig_enforce directly

2018-03-23 Thread Jia Zhang
Call is_module_sig_enforced() instead. Signed-off-by: Jia Zhang --- kernel/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/module.c b/kernel/module.c index ad2d420..003d0ab 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -2789,7 +2789,7 @@ static int mod

[PATCH v3 0/3][RESEND] modsign enhancement

2018-03-23 Thread Jia Zhang
This patch series allows to disable module validity enforcement in runtime through the control switch located in securityfs. In order to keep /sys/module/module/parameters/sig_enforce simple, the disablement switch is located at /sys/kernel/security/modsign/disable_enforce. Assuming CONFIG_MODULE

Re: [PATCH v5 00/13] ARM: dts: ipq: updates to enable a few peripherals

2018-03-23 Thread Richard Cochran
On Fri, Mar 23, 2018 at 03:48:43PM +0530, Sricharan R wrote: > [v5] > * Fixed a minor comment that i missed earlier. I tried booting this series with qcom_defconfig on my custom, dk07-like board. It works! Thanks a bunch, Richard

Re: [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init()

2018-03-23 Thread Rick Chang
On Fri, 2018-03-23 at 11:44 +0800, Ryder Lee wrote: > The error return value should be fixed as it may return EPROBE_DEFER. > > Cc: Rick Chang > Cc: Bin Liu > Signed-off-by: Ryder Lee > --- >  drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletio

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

2018-03-23 Thread Quentin Perret
On Thursday 22 Mar 2018 at 13:19:03 (-0700), Joel Fernandes wrote: > On Thu, Mar 22, 2018 at 11:06 AM, Patrick Bellasi > wrote: [...] > >> > @@ -6555,6 +6613,14 @@ select_task_rq_fair(struct task_struct *p, int > >> > prev_cpu, int sd_flag, int wake_f > >> > break; > >>

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

2018-03-23 Thread Quentin Perret
On Friday 23 Mar 2018 at 18:13:56 (-0700), Joel Fernandes wrote: > Hi Morten, > > On Fri, Mar 23, 2018 at 8:47 AM, Morten Rasmussen > wrote: > > On Thu, Mar 22, 2018 at 01:10:22PM -0700, Joel Fernandes wrote: [...] > > You mean if SD_BALANCE_WAKE isn't set on sched_domains? > > Yes. > > > The

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

2018-03-23 Thread Benson Leung
On Fri, Mar 23, 2018 at 06:08:07PM -0700, Andrew Chant wrote: > >> +"New USB device found, idVendor=%04x, idProduct=%04x, > >> bcdDevice=%04x\n", > > Can you please decode bcdDevice into a decimal string? > > > > lsusb -v does this (bcdDevice: 0.03 for example) and in my experience

[PATCH v2] USB: announce bcdDevice as well as idVendor, idProduct.

2018-03-23 Thread Benson Leung
Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson Leung --

Re: [PATCH] [RFC] drm: rcar-du: keep temporary dtb files around during build

2018-03-23 Thread Frank Rowand
Hi Geert, On 03/22/18 07:26, Geert Uytterhoeven wrote: > Hi Frank, > > On Fri, Mar 16, 2018 at 2:39 AM, wrote: >> On Thursday, March 15, 2018 8:37 AM, Arnd Bergmann [mailto:a...@arndb.de] >> wrote: >>> >>> The *.dtb and *.dtb.S files get removed by 'make' during the build >>> process, >>> and

Re: [PATCH 01/10] .gitignore: move *.lex.c *.tab.[ch] patterns to the top-level .gitignore

2018-03-23 Thread Frank Rowand
On 03/23/18 06:04, Masahiro Yamada wrote: > These patterns are common to host programs that require lexer and parser. > Move them to the top .gitignore. > > Signed-off-by: Masahiro Yamada Acked-by: Frank Rowand -Frank > --- > > .gitignore | 2 ++ > scripts/dtc/.gitignore

Re: [PATCH 10/10] kbuild: mark $(targets) as .SECONDARY and remove .PRECIOUS specifier

2018-03-23 Thread Frank Rowand
On 03/23/18 06:04, Masahiro Yamada wrote: > GNU Make automatically deletes intermediate files that are updated > in a chain of pattern rules. > > Example 1) %.dtb.o <- %.dtb.S <- %.dtb.S <- %.dts > Example 2) %.o <- %.c <- %.c_shipped > > A couple of makefiles mark such targets as .PRECIOUS to pr

Re: [PATCH 05/10] kbuild: add %.dtb.S and %.dtb to 'targets' automatically

2018-03-23 Thread Frank Rowand
On 03/23/18 06:04, Masahiro Yamada wrote: > Another common pattern that consists of chained commands is to compile > a DTB as binary data into the kernel image or a module. It is used in > several places in the source tree. Let's support it in the build core. > > $(call if_changed,dt_S_dtb) is m

Re: [PATCH 04/10] kbuild: add %.lex.c and %.tab.[ch] to 'targets' automatically

2018-03-23 Thread Frank Rowand
On 03/23/18 06:04, Masahiro Yamada wrote: > Files generated by if_changed* must be added to 'targets' to include > *.cmd files. Otherwise, they would be regenerated every time. > > The build system automatically adds objects to 'targets' where > appropriate, such as obj-y, extra-y, etc. but does

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

2018-03-23 Thread Quentin Perret
On Friday 23 Mar 2018 at 15:47:45 (+), Morten Rasmussen wrote: > On Thu, Mar 22, 2018 at 01:10:22PM -0700, Joel Fernandes wrote: > > On Wed, Mar 21, 2018 at 8:35 AM, Patrick Bellasi > > wrote: > > > [...] > > > > > >> @@ -6555,6 +6613,14 @@ select_task_rq_fair(struct task_struct *p, int > > >

Re: rcu: Add might_sleep() check to synchronize_rcu()

2018-03-23 Thread Steven Rostedt
On Fri, 23 Mar 2018 15:57:04 -0700 Joel Fernandes wrote: > > diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c > > index 194a7483bb93..857b494bee29 100644 > > --- a/net/l2tp/l2tp_core.c > > +++ b/net/l2tp/l2tp_core.c > > @@ -1677,6 +1677,8 @@ void __l2tp_session_unhash(struct l2tp_session

Re: [PATCH 02/10] kbuild: clean up *.lex.c and *.tab.[ch] patterns from top-level Makefile

2018-03-23 Thread Frank Rowand
On 03/23/18 06:04, Masahiro Yamada wrote: > Files suffixed by .lex.c, .tab.[ch] are generated lexers, parsers, > respectively. Clean them up globally from the top Makefile. > > Some of the final host programs they are linked into are needed for > building external modules, but those intermediates

Re: ftrace on MIPS/ath79

2018-03-23 Thread Steven Rostedt
On Fri, 23 Mar 2018 23:20:10 +0100 Matthias Schiffer wrote: > Hi, > I'm currently trying to debug a performance bottleneck on low-end ath79 > hardware running OpenWrt/LEDE, but it seems that ftrace is not working > correctly on these systems. I have tried this with recent 4.4.y and 4.9.y > with s

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

2018-03-23 Thread Joel Fernandes
Hi Morten, On Fri, Mar 23, 2018 at 8:47 AM, Morten Rasmussen wrote: > On Thu, Mar 22, 2018 at 01:10:22PM -0700, Joel Fernandes wrote: >> On Wed, Mar 21, 2018 at 8:35 AM, Patrick Bellasi >> wrote: >> > [...] >> > >> >> @@ -6555,6 +6613,14 @@ select_task_rq_fair(struct task_struct *p, int >> >> p

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

2018-03-23 Thread Andrew Chant
On Fri, Mar 23, 2018 at 5:48 PM, Andrew Chant wrote: > On Fri, Mar 23, 2018 at 5:33 PM, Benson Leung wrote: >> Print bcdDevice which is used by vendors to identify different versions >> of the same product (or different versions of firmware). >> >> Adding this to the logs will be useful for suppo

Re: [PATCH v3 2/2] x86, cpuid: allow cpuid_read() to schedule

2018-03-23 Thread Eric Dumazet
On 03/23/2018 03:17 PM, H. Peter Anvin wrote: > On 03/23/18 14:58, Eric Dumazet wrote: >> I noticed high latencies caused by a daemon periodically reading various >> MSR and cpuid on all cpus. KASAN kernels would see ~10ms latencies >> simply reading one cpuid. Even without KASAN, sending IPI to

Re: [PATCH 00/11] Use global pages with PTI

2018-03-23 Thread Linus Torvalds
On Fri, Mar 23, 2018 at 5:46 PM, Linus Torvalds wrote: > > It is, of course, possible that I misunderstood what you actually > benchmarked. But I assume the above benchmark numbers are with the > whole "don't even do global entries if you have PCID". Oh, I went back and read your description, and

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

2018-03-23 Thread Andrew Chant
On Fri, Mar 23, 2018 at 5:33 PM, Benson Leung wrote: > Print bcdDevice which is used by vendors to identify different versions > of the same product (or different versions of firmware). > > Adding this to the logs will be useful for support purposes. > > Signed-off-by: Benson Leung > --- > drive

Re: [PATCH 00/11] Use global pages with PTI

2018-03-23 Thread Linus Torvalds
On Fri, Mar 23, 2018 at 5:40 PM, Dave Hansen wrote: > > Well, rats. This somehow makes things slower with PCIDs on. .. what happens when you enable global pages with PCID? You disabled them explicitly because you thought they wouldn't matter.. Even with PCID, a global TLB entry for the shared p

Re: [PATCH 00/11] Use global pages with PTI

2018-03-23 Thread Dave Hansen
On 03/23/2018 11:26 AM, Linus Torvalds wrote: > On Fri, Mar 23, 2018 at 10:44 AM, Dave Hansen > wrote: >> >> This adds one major change from the last version of the patch set >> (present in the last patch). It makes all kernel text global for non- >> PCID systems. This keeps kernel data protecte

[PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct

2018-03-23 Thread Yang Shi
mmap_sem is on the hot path of kernel, and it very contended, but it is abused too. It is used to protect arg_start|end and evn_start|end when reading /proc/$PID/cmdline and /proc/$PID/environ, but it doesn't make sense since those proc files just expect to read 4 values atomically and not related

Re: [RFC PATCH 5/6] sched/fair: Select an energy-efficient CPU on task wake-up

2018-03-23 Thread Joel Fernandes
On Fri, Mar 23, 2018 at 9:00 AM, Morten Rasmussen wrote: > On Thu, Mar 22, 2018 at 09:27:43AM -0700, Joel Fernandes wrote: >> > >> > In case an energy model is available, waking tasks are re-routed into a >> > new energy-aware placement algorithm. The eligible CPUs to be used in the >> > energy-aw

[PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

2018-03-23 Thread Benson Leung
Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Signed-off-by: Benson Leung --- drivers/usb/core/hub.c | 16 +--- 1 file changed, 9 insertion

[PATCH 0/4] tty/nozomi: general module cleanup

2018-03-23 Thread Joey Pabalinas
The nozomi module code has a fair amount of sections which could use a bit of improvement; both style and clarity could be improved while maintaining equivalent semantics. Cleanup messy portions of the module code while preserving existing behavior by: - Replacing constructs like `len__ > TMP_BU

[PATCH 3/4] tty/nozomi: improve code readability and style

2018-03-23 Thread Joey Pabalinas
Improve code clarity by renaming identifiers and reorganizing function control flow. Signed-off-by: Joey Pabalinas 1 file changed, 92 insertions(+), 91 deletions(-) 1 file changed, 76 insertions(+), 90 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index 0fcb4db721d2a4

[PATCH 2/4] tty/nozomi: fix inconsistent indentation

2018-03-23 Thread Joey Pabalinas
Correct misaligned indentation and remove extraneous spaces. Signed-off-by: Joey Pabalinas 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index f26bf1d1e9ee0e74eb..0fcb4db721d2a42f08 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty

[PATCH 4/4] tty/nozomi: refactor conditional statements

2018-03-23 Thread Joey Pabalinas
Reduce unnecessarily deep nesting of blocks and simplify control flow (e.g. "if/else" constructs changed to "if/return" and single case "switch" statements changed to "if" conditionals where possible). Signed-off-by: Joey Pabalinas 1 file changed, 52 insertions(+), 50 deletions(-) diff --git a

Re: [PATCH v4 0/8] ARM: davinci: complete the conversion to using the reset framework

2018-03-23 Thread Suman Anna
Hi Bart, On 03/23/2018 12:16 PM, Bartosz Golaszewski wrote: > 2018-03-23 18:08 GMT+01:00 Stephen Boyd : >> Quoting Bartosz Golaszewski (2018-03-23 09:55:47) >>> 2018-03-23 17:49 GMT+01:00 Stephen Boyd : Quoting Bartosz Golaszewski (2018-03-23 06:04:47) > From: Bartosz Golaszewski > >

[PATCH 1/4] tty/nozomi: cleanup DUMP() macro

2018-03-23 Thread Joey Pabalinas
Replace snprint() with strscpy() and use max_t() instead of the conditional operator. Signed-off-by: Joey Pabalinas 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index b57b35066ebea94639..f26bf1d1e9ee0e74eb 100644 --- a/drivers/tty/n

Re: Return checks for clock calls

2018-03-23 Thread Fabio Estevam
Hi Abel, On Fri, Mar 23, 2018 at 6:49 AM, Abel Vesa wrote: > Hi Shawn, Fabio, > > I'm trying to get the imx clks changes upstreamed. To that end, I reached this > old commit that adds some wrappers over the generic clk API. Here is the > commit > message: > > ARM: imx6: add return check

[PATCH] kfifo: fix comment

2018-03-23 Thread Valentin Vidic
Cleanup unusual formatting in the note about locking. Signed-off-by: Valentin Vidic --- include/linux/kfifo.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h index e251533a5939..89fc8dc7bf38 100644 --- a/include/linux/kfif

Re: [PATCH v3] usb: dwc2: dwc2_vbus_supply_init: fix error check

2018-03-23 Thread kbuild test robot
Hi Tomeu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on balbi-usb/next] [also build test WARNING on next-20180323] [cannot apply to v4.16-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH][next] apparmor: fix error returns checks by making size a ssize_t

2018-03-23 Thread John Johansen
On 03/23/2018 04:34 PM, Colin King wrote: > From: Colin Ian King > > Currently variable size is a unsigned size_t, hence comparisons to > see if it is less than zero (for error checking) will always be > false. Fix this by making size a ssize_t > > Detected by CoverityScan, CID#1466080 ("Unsign

Re: [PATCH] watchdog: davinci_wdt: fix error handling in davinci_wdt_probe()

2018-03-23 Thread Guenter Roeck
On 03/23/2018 02:36 PM, Alexey Khoroshilov wrote: clk_disable_unprepare() was added to one error path, but there is another one. The patch makes sure clk is disabled at the both of them. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Reviewed

Re: [PATCH v2] x86,sched: allow topologies where NUMA nodes share an LLC

2018-03-23 Thread Alison Schofield
On Thu, Mar 22, 2018 at 05:42:41PM -0700, Tim Chen wrote: > On 03/22/2018 01:49 PM, Alison Schofield wrote: > > > > +*/ > > + if (!topology_same_node(c, o) && > > + (c->x86_vendor == X86_VENDOR_INTEL && > > +c->x86_model == INTEL_FAM6_SKYLAKE_X)) { > > + /* Use NUMA in

Re: [PATCH 4.15 00/84] 4.15.13-stable review

2018-03-23 Thread Guenter Roeck
On 03/23/2018 02:53 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.15.13 release. There are 84 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be m

Re: [PATCH 4.14 00/77] 4.14.30-stable review

2018-03-23 Thread Guenter Roeck
On 03/23/2018 02:53 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.30 release. There are 77 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be m

Re: [PATCH 4.9 000/177] 4.9.90-stable review

2018-03-23 Thread Guenter Roeck
On 03/23/2018 02:52 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.90 release. There are 177 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be m

Re: [PATCH 4.4 00/97] 4.4.124-stable review

2018-03-23 Thread Guenter Roeck
On 03/23/2018 02:53 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.4.124 release. There are 97 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be m

Re: [PATCH 3.18 00/47] 3.18.102-stable review

2018-03-23 Thread Guenter Roeck
On 03/23/2018 02:54 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 3.18.102 release. There are 47 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 2/2] drivers: soc: Add LLCC driver

2018-03-23 Thread Channa
On 2018-03-19 07:55, Jordan Crouse wrote: On Thu, Jan 25, 2018 at 03:55:13PM -0800, Channagoud Kadabi wrote: LLCC (Last Level Cache Controller) provides additional cache memory in the system. LLCC is partitioned into muliple slices and each slice gets its own priority, size, ID and other config

Re: [PATCH v2] venus: vdec: fix format enumeration

2018-03-23 Thread Stanimir Varbanov
Hi Hans, Could you take this patch it not too late. On 20.03.2018 15:42, Stanimir Varbanov wrote: Hi Alex, Thanks! On 03/19/2018 11:32 AM, Alexandre Courbot wrote: find_format_by_index() stops enumerating formats as soon as the index matches, and returns NULL if venus_helper_check_codec() fi

[PATCH] net: qualcomm: rmnet: check for null ep to avoid null pointer dereference

2018-03-23 Thread Colin King
From: Colin Ian King The call to rmnet_get_endpoint can potentially return NULL so check for this to avoid any subsequent null pointer dereferences on a NULL ep. Detected by CoverityScan, CID#1465385 ("Dereference null return value") Fixes: 23790ef12082 ("net: qualcomm: rmnet: Allow to configur

Re: [PATCH v4 0/5] Support qcom pinctrl protected pins

2018-03-23 Thread Timur Tabi
On 03/23/2018 11:34 AM, Stephen Boyd wrote: Stephen Boyd (5): dt-bindings: gpio: Add a gpio-reserved-ranges property gpiolib: Extract mask allocation into subroutine gpiolib: Change bitmap allocation to kmalloc_array gpiolib: Support 'gpio-reserved-ranges' property pinctrl: qcom: D

[alsa-devel][PATCH 3/3] ASoC: TSCS42xx: Add CCF support to get sysclk

2018-03-23 Thread Steven Eckhoff
The TSCS42xx relies on set_sysclk to get a unique clock id and rate, which prevents it from being used with the simple-card. Remove set_sysclk callback Add CCF support to get clock id and rate Add clocks and clock-names to device tree binding Signed-off-by: Steven Eckhoff --- .../devicetree/bin

[PATCH v1 2/2] drivers: soc: Add LLCC driver

2018-03-23 Thread Rishabh Bhatnagar
From: "ckad...@codeaurora.org" LLCC (Last Level Cache Controller) provides additional cache memory in the system. LLCC is partitioned into muliple slices and each slice getting its own priority, size, ID and other config parameters. LLCC driver programs these parameters for each slice. Clients th

[PATCH v1 1/2] Documentation: Documentaion for qcom, llcc

2018-03-23 Thread Rishabh Bhatnagar
From: "ckad...@codeaurora.org" Documentation for last level cache controller device tree bindings, client bindings usage examples. Change-Id: Ic2d6d6154ab8269cfce6828e9f2250320a0572e8 Signed-off-by: Channagoud Kadabi Signed-off-by: Rishabh Bhatnagar --- .../devicetree/bindings/arm/msm/qcom,ll

[PATCH v1 0/2] SDM845 System Cache Driver

2018-03-23 Thread Rishabh Bhatnagar
This series implements system cache or LLCC(Last Level Cache Controller) driver for SDM845 SOC. The purpose of the driver is to partition the system cache and program the settings such as priortiy, lines to probe while doing a look up in the system cache, low power related settings etc. The partiti

[PATCH][next] apparmor: fix error returns checks by making size a ssize_t

2018-03-23 Thread Colin King
From: Colin Ian King Currently variable size is a unsigned size_t, hence comparisons to see if it is less than zero (for error checking) will always be false. Fix this by making size a ssize_t Detected by CoverityScan, CID#1466080 ("Unsigned compared against 0") Fixes: 8e51f9087f40 ("apparmor:

[alsa-devel][PATCH 2/3] ASoC: TSCS42xx: Cleanup private data members

2018-03-23 Thread Steven Eckhoff
In the TSCS42xx driver there are some unnecesarry private data members Remove blrcm from private data Remove dev from private data Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs

[alsa-devel][PATCH 1/3] ASoC: TSCS42xx: Shorten lines and other cleanup

2018-03-23 Thread Steven Eckhoff
Shorten lines greater than 80 chars Add const to struct snd_soc_component_driver Signed-off-by: Steven Eckhoff --- sound/soc/codecs/tscs42xx.c | 87 - 1 file changed, 55 insertions(+), 32 deletions(-) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/s

Re: [PATCH 1/2] fs: Extend mount_ns with support for a fast namespace to vfsmount function

2018-03-23 Thread Al Viro
On Fri, Mar 23, 2018 at 04:41:40PM -0500, Eric W. Biederman wrote: > struct dentry *mount_ns(struct file_system_type *fs_type, > int flags, void *data, void *ns, struct user_namespace *user_ns, > + struct vfsmount *(*ns_to_mnt)(void *ns), > int (*fill_super)(struct super_block *,

[PATCH 4/8] cgroup: Reorganize kernel/cgroup/rstat.c

2018-03-23 Thread Tejun Heo
Currently, rstat.c has rstat and base stat implementations intermixed. Collect base stat implementation at the end of the file. Also, reorder the prototypes. This patch doesn't make any functional changes. Signed-off-by: Tejun Heo --- kernel/cgroup/cgroup-internal.h | 2 +- kernel/cgroup/rst

[PATCH 3/8] cgroup: Distinguish base resource stat implementation from rstat

2018-03-23 Thread Tejun Heo
Base resource stat accounts universial (not specific to any controller) resource consumptions on top of rstat. Currently, its implementation is intermixed with rstat implementation making the code confusing to follow. This patch clarifies the distintion by doing the followings. * Encapsulate bas

[PATCH 5/8] cgroup: Factor out and expose cgroup_rstat_*() interface functions

2018-03-23 Thread Tejun Heo
cgroup_rstat is being generalized so that controllers can use it too. This patch factors out and exposes the following interface functions. * cgroup_rstat_updated(): Renamed from cgroup_rstat_cpu_updated() for consistency. * cgroup_rstat_flush_hold/release(): Factored out from base stat imple

[PATCH 2/8] cgroup: Rename stat to rstat

2018-03-23 Thread Tejun Heo
stat is too generic a name and ends up causing subtle confusions. It'll be made generic so that controllers can plug into it, which will make the problem worse. Let's rename it to something more specific - cgroup_rstat for cgroup recursive stat. This patch does the following renames. No other ch

[PATCH 6/8] cgroup: Replace cgroup_rstat_mutex with a spinlock

2018-03-23 Thread Tejun Heo
Currently, rstat flush path is protected with a mutex which is fine as all the existing users are from interface file show path. However, rstat is being generalized for use by controllers and flushing from atomic contexts will be necessary. This patch replaces cgroup_rstat_mutex with a spinlock a

[PATCH 7/8] cgroup: Add cgroup_subsys->css_rstat_flush()

2018-03-23 Thread Tejun Heo
This patch adds cgroup_subsys->css_rstat_flush(). If a subsystem has this callback, its csses are linked on cgrp->css_rstat_list and rstat will call the function whenever the associated cgroup is flushed. Flush is also performed when such csses are released so that residual counts aren't lost. Co

[PATCH 8/8] cgroup: Add memory barriers to plug cgroup_rstat_updated() race window

2018-03-23 Thread Tejun Heo
cgroup_rstat_updated() has a small race window where an updated signaling can race with flush and could be lost till the next update. This wasn't a problem for the existing usages, but we plan to use rstat to track counters which need to be accurate. This patch plugs the race window by synchronizi

[PATCHSET] cgroup/for-4.17: Make cgroup_rstat available to controllers

2018-03-23 Thread Tejun Heo
Hello, cgroup has scalable recursive stat mechanism implemented in kernel/stat.c. It's currently only used to track cpu consumptions and difficult to use outside of cgroup core. This patchset generalizes the mechanism and exposes it as cgroup_rstat so that controllers can use it. This patchset

[PATCH 1/8] cgroup: Rename kernel/cgroup/stat.c to kernel/cgroup/rstat.c

2018-03-23 Thread Tejun Heo
stat is too generic a name and ends up causing subtle confusions. It'll be made generic so that controllers can plug into it, which will make the problem worse. Let's rename it to something more specific - cgroup_rstat for cgroup recursive stat. First, rename kernel/cgroup/stat.c to kernel/cgroup

Re: [PATCH] x86/speculation: Fill the RSB on context switch also on non-IBPB CPUs

2018-03-23 Thread Maciej S. Szmigiero
On 22.03.2018 16:46, Dave Hansen wrote: > On 03/21/2018 05:09 PM, Maciej S. Szmigiero wrote: >> As far as I understand the issue this should provide a good protection >> for userspace processes that were recompiled with retpolines as they >> won't have any indirect jumps and calls. > > Instead of

Re: [PATCH v1 0/4] platform/x86: mlx-platform: Add bus differed and auto detection functionalities

2018-03-23 Thread Darren Hart
On Fri, Mar 23, 2018 at 03:59:22PM +, Vadim Pasternak wrote: > > > > -Original Message- > > From: Darren Hart [mailto:dvh...@infradead.org] > > Sent: Friday, March 23, 2018 1:56 AM > > To: Vadim Pasternak > > Cc: andy.shevche...@gmail.com; gre...@linuxfoundation.org; platform- > > dr

Re: [QUESTION] Mainline support for B43_PHY_AC wifi cards

2018-03-23 Thread Rafał Miłecki
On 23 March 2018 at 15:09, Juri Lelli wrote: > On 23/03/18 14:43, Rafał Miłecki wrote: >> Hi, >> >> On 23 March 2018 at 10:47, Juri Lelli wrote: >> > I've got a Dell XPS 13 9343/0TM99H (BIOS A15 01/23/2018) mounting a >> > BCM4352 802.11ac (rev 03) wireless card and so far I've been using it on >

Re: rcu: Add might_sleep() check to synchronize_rcu()

2018-03-23 Thread Joel Fernandes
On Fri, Mar 23, 2018 at 2:40 PM, Steven Rostedt wrote: > On Fri, 23 Mar 2018 22:33:29 +0100 (CET) > Thomas Gleixner wrote: > >> On Fri, 23 Mar 2018, Steven Rostedt wrote: >> >> > On Fri, 23 Mar 2018 22:12:24 +0100 (CET) >> > Thomas Gleixner wrote: >> > >> > > synchronize_rcu() lacks a might_slee

[PATCH 4/4] drivers/net: Use octal not symbolic permissions

2018-03-23 Thread Joe Perches
Prefer the direct use of octal for permissions. Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace and some typing. Miscellanea: o Whitespace neatening around these conversions. Signed-off-by: Joe Perches --- drivers/net/bonding/bond_procfs.c | 2 +- drivers/net/bonding/bond_s

[PATCH 3/4] net: Use octal not symbolic permissions

2018-03-23 Thread Joe Perches
Prefer the direct use of octal for permissions. Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace and some typing. Miscellanea: o Whitespace neatening around these conversions. Signed-off-by: Joe Perches --- net/8021q/vlanproc.c | 6 ++--- net/appletalk/atalk

[PATCH 2/4] wireless: Use octal not symbolic permissions

2018-03-23 Thread Joe Perches
Prefer the direct use of octal for permissions. Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace and some typing. Miscellanea: o Whitespace neatening around these conversions. Signed-off-by: Joe Perches --- drivers/net/wireless/ath/ath5k/base.c | 6 +- drivers/net/w

  1   2   3   4   5   6   7   8   9   10   >