Hi,
On 3/16/2018 4:25 PM, Felipe Balbi wrote:
>
> Hi,
>
> Minas Harutyunyan writes:
> On 09/03/18 14:47, Roger Quadros wrote:
>> In the following test we get stuck by sleeping forever in
>> _dwc3_set_mode()
>> after which dual-role switching doesn't work.
>>
>> On dra7-
On Fri, Mar 16, 2018 at 3:59 PM, Andrew Morton
wrote:
> On Thu, 15 Mar 2018 15:59:19 -0700 Kees Cook wrote:
>
>> Avoid stack VLAs[1] by always allocating the upper bound of stack space
>> needed. The existing users of rslib appear to max out at 24 roots[2],
>> so use that as the upper bound until
.de, linux-kernel@vger.kernel.org
CC: zhangq...@rock-chips.com, x...@rock-chips.com, tony@rock-chips.com,
w.ego...@phytec.de, linux-kernel@vger.kernel.org
Hi Daniel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v4.16-rc4]
[also build test WARNING on next-2
Hi Gabriel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20180309]
[cannot apply to v4.16-rc4 v4.16-rc3 v4.16-rc2 v4.16-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-c
On 03/16/2018 10:52 PM, 李書帆 wrote:
Hi Guenter,
2018-03-17 10:16 GMT+08:00 Guenter Roeck :
On 03/16/2018 10:40 AM, ShuFan Lee wrote:
From: ShuFan Lee
Richtek RT1711H Type-C chip driver that works with
Type-C Port Controller Manager to provide USB PD and
USB Type-C functionalities.
Add defini
Hi Kyle,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc5 next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
Hi Guenter,
2018-03-17 10:16 GMT+08:00 Guenter Roeck :
> On 03/16/2018 10:40 AM, ShuFan Lee wrote:
>>
>> From: ShuFan Lee
>>
>> Richtek RT1711H Type-C chip driver that works with
>> Type-C Port Controller Manager to provide USB PD and
>> USB Type-C functionalities.
>> Add definition of TCPC_CC_ST
On Wed, Mar 7, 2018 at 8:28 AM Lee Jones wrote:
> On Wed, 21 Feb 2018, Enric Balletbo i Serra wrote:
> > From: Gwendal Grignou
> >
> > This adds a sysfs attribute (/sys/class/chromeos/cros_ec/kb_wake_angle)
> > used to set and get the keyboard wake lid angle. This attribute is
> > present only
Chromebooks use coreboot for system initialization. coreboot has always
had the default mainboard vendor string for Google machines set to
"Google". Google engineers set this string to "GOOGLE" in the coreboot
copies of the Chromium OS tree. The atmel_mxt_ts driver in it's current
state is set to
On 03/16/2018 08:47 PM, John Hubbard wrote:
> On 03/16/2018 07:36 PM, John Hubbard wrote:
>> On 03/16/2018 12:14 PM, jgli...@redhat.com wrote:
>>> From: Ralph Campbell
>>>
>>
>>
>>
>>> +static void hmm_release(struct mmu_notifier *mn, struct mm_struct *mm)
>>> +{
>>> + struct hmm *hmm = mm->hmm
Hi Manu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v4.16-rc4]
[also build test WARNING on next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits
On 03/16/2018 12:14 PM, jgli...@redhat.com wrote:
> From: Jérôme Glisse
>
> Special vma (one with any of the VM_SPECIAL flags) can not be access by
> device because there is no consistent model accross device drivers on
> those vma and their backing memory.
>
> This patch directly use hmm_range
On Wed, Mar 14, 2018 at 01:21:32PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA and replace it
> with a fixed-length array instead.
>
> Fixed as part of the directive to remove all VLAs from
> the kernel: https://lkml.org/lkml/2018/3/7/621
>
> Also, remove max_
On Fri, Mar 16, 2018 at 11:25 PM, Sinan Kaya wrote:
> @@ -477,15 +477,16 @@ static inline void t4_ring_sq_db(struct t4_wq *wq, u16
> inc, union t4_wr *wqe)
> (u64 *)wqe);
> } else {
> pr_debug("DB wq->sq.pidx = %d\n", wq->sq
On 3/17/2018 12:03 AM, Sinan Kaya wrote:
> On 3/16/2018 11:40 PM, Sinan Kaya wrote:
>> I'll change writel_relaxed() with __raw_writel() in the series like you
>> suggested
>> and also look at your other comments.
>
> I spoke too soon.
>
> Now that I realized, code needs to follow one of the foll
On 3/16/18 6:04 PM, Steve Wise wrote:
Anybody understand why the PPC implementation of writeX_relaxed() isn't
relaxed?
You probably should ask that on the linuxppc-...@lists.ozlabs.org
mailing list.
I've always wondered why PowerPC has non-standard I/O accessors.
--
Qualcomm Datacenter Tech
On 3/16/2018 11:40 PM, Sinan Kaya wrote:
> I'll change writel_relaxed() with __raw_writel() in the series like you
> suggested
> and also look at your other comments.
I spoke too soon.
Now that I realized, code needs to follow one of the following patterns for
correctness
1)
wmb()
writel()/wri
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v4.16-rc4]
[also build test ERROR on next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/jason-vas
On 03/16/2018 12:14 PM, jgli...@redhat.com wrote:
> From: Jérôme Glisse
>
Hi Jerome,
This one looks great. A couple of trivial typo fixes are listed below.
You can add:
Reviewed-by: John Hubbard
> All device driver we care about are using 64bits page table entry. In
> order to match this an
On 03/16/2018 07:36 PM, John Hubbard wrote:
> On 03/16/2018 12:14 PM, jgli...@redhat.com wrote:
>> From: Ralph Campbell
>>
>
>
>
>> +static void hmm_release(struct mmu_notifier *mn, struct mm_struct *mm)
>> +{
>> +struct hmm *hmm = mm->hmm;
>> +struct hmm_mirror *mirror;
>> +struct
Some protocols over I2C are designed for bi-directional transferring
messages by using I2C Master Write protocol. Like the MCTP (Management
Component Transport Protocol) and IPMB (Intelligent Platform Management
Bus), they both require that the userspace can receive messages from
I2C dirvers under
On 3/16/2018 7:05 PM, Steve Wise wrote:
>>
>> On 3/16/2018 5:05 PM, Steve Wise wrote:
Code includes wmb() followed by writel(). writel() already has a barrier
>>> on
some architectures like arm64.
This ends up CPU observing two barriers back to back before executing
>> the
On 03/16/2018 12:14 PM, jgli...@redhat.com wrote:
> From: Jérôme Glisse
>
> Only peculiar architecture allow write without read thus assume that
> any valid pfn do allow for read. Note we do not care for write only
> because it does make sense with thing like atomic compare and exchange
> or any
On 03/16/2018 12:14 PM, jgli...@redhat.com wrote:
> From: Jérôme Glisse
>
Hi Jerome,
I failed to find any problems in this patch, so:
Reviewed-by: John Hubbard
There are a couple of documentation recommended typo fixes listed
below, which are very minor but as long as I'm here I'll point the
On Sat, 17 Mar 2018 10:22:11 +0900
Masami Hiramatsu wrote:
> Or, we can check it by ftrace_location_range() as below patch.
Cute ;-)
>
> Note that as a side-effect, we can not trace functions in trace_kprobe.c
> anymore, and this means it is hard to me to make a testcase of kprobe events.
> It
On 03/16/2018 12:14 PM, jgli...@redhat.com wrote:
> From: Ralph Campbell
>
> +static void hmm_release(struct mmu_notifier *mn, struct mm_struct *mm)
> +{
> + struct hmm *hmm = mm->hmm;
> + struct hmm_mirror *mirror;
> + struct hmm_mirror *mirror_next;
> +
> + down_write(&hmm->m
On 03/16/2018 10:40 AM, ShuFan Lee wrote:
From: ShuFan Lee
Richtek RT1711H Type-C chip driver that works with
Type-C Port Controller Manager to provide USB PD and
USB Type-C functionalities.
Add definition of TCPC_CC_STATUS_TOGGLING.
Signed-off-by: ShuFan Lee
Does this patch require DT revi
On 03/16/2018 12:14 PM, jgli...@redhat.com wrote:
> From: Jérôme Glisse
>
> The private field of mm_walk struct point to an hmm_vma_walk struct and
> not to the hmm_range struct desired. Fix to get proper struct pointer.
>
> Signed-off-by: Jérôme Glisse
> Cc: sta...@vger.kernel.org
> Cc: Evgeny
On 03/16/2018 06:37 AM, Marcus Folkesson wrote:
Hi,
Am I supposed to do something more to make this patchset picked up?
Did you check linux-next ?
Guenter
Thanks,
Marcus Folkesson
On Sun, Feb 11, 2018 at 09:08:41PM +0100, Marcus Folkesson wrote:
watchdog_init_timeout() will allways pick
On 03/16/2018 02:22 PM, Eddie James wrote:
The ucd9000 series chips have gpio pins. Add a gpio chip interface to the ucd
device so that users can query and set the state of the gpio pins.
Add a debugfs interface using the existing pmbus debugfs directory to provide
MFR_STATUS and the status of t
On Fri, Mar 16, 2018 at 9:14 PM, Linus Torvalds
wrote:
> On Fri, Mar 16, 2018 at 1:03 PM, Miguel Ojeda
> wrote:
>>>
>>> Kees - is there some online "gcc-4.4 checker" somewhere? This does
>>> seem to work with my gcc. I actually tested some of those files you
>>> pointed at now.
>>
>> I use this o
On Fri, Mar 16, 2018 at 04:14:11PM +0100, Marcus Folkesson wrote:
> - Add SPDX identifier
> - Remove boiler plate license text
> - If MODULE_LICENSE and boiler plate does not match, go for boiler plate
> license
>
> Signed-off-by: Marcus Folkesson
> Acked-by: Adam Thomson
> Acked-by: Baruch Si
Hi Christophe,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v4.16-rc4]
[also build test ERROR on next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits
On (03/16/18 09:55), Petr Mladek wrote:
[..]
> I am not sure if it is worth it. I think that we would catch 99% of
> problems by checking the first byte.
>
> This patch was motivated by a code clean up rather than bug reports.
OK. Then I think we really need this "the patch is just good enough" l
On Sat, 17 Mar 2018 09:13:34 +0900
Masami Hiramatsu wrote:
> On Fri, 16 Mar 2018 13:53:01 -0400 (EDT)
> Mathieu Desnoyers wrote:
>
> > - On Mar 16, 2018, at 12:48 PM, rostedt rost...@goodmis.org wrote:
> >
> > > On Fri, 16 Mar 2018 12:41:34 -0400
> > > Steven Rostedt wrote:
> > >
> > >>
From: Jérôme Glisse
The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong. Because
of this after multiple include there was multiple definition of both
hmm_mm_init() and hmm_mm_destroy() leading to build failure if HMM
was enabled (CONFIG_HMM set).
Changed since v1:
- Fix the maze when CO
On Mon, 2018-03-05 at 18:56 +0200, Jarkko Sakkinen wrote:
> index 9e80a953d693..1adb976a2e37 100644
> --- a/drivers/char/tpm/tpm-interface.c
> +++ b/drivers/char/tpm/tpm-interface.c
> @@ -537,14 +537,26 @@ ssize_t tpm_transmit_cmd(struct tpm_chip *chip,
> struct tpm_space *space,
>
[ adding Toshi's correct address ]
On Thu, Mar 15, 2018 at 8:08 PM, Dan Williams wrote:
> Commit 99759869faf1 "acpi: Add acpi_map_pxm_to_online_node()" added
> support for mapping a given proximity to its nearest, by SLIT distance,
> online node. However, it sometimes returns unexpected results d
On Fri, Mar 16, 2018 at 02:13:42PM -0400, Waiman Long wrote:
> When the CTL_FLAGS_CLAMP_RANGE flag is set in the ctl_table
> entry, any update from the userspace will be clamped to the given
> range without error if either the proc_dointvec_minmax() or the
> proc_douintvec_minmax() handlers is used
Add the QCOM RPMh regulator driver to manage PMIC regulators
which are controlled via RPMh on some Qualcomm Technologies, Inc.
SoCs. RPMh is a hardware block which contains several
accelerators which are used to manage various hardware resources
that are shared between the processors of the SoC.
Hello,
This patch series adds a driver and device tree binding documentation for
PMIC regulator control via Resource Power Manager-hardened (RPMh) on some
Qualcomm Technologies, Inc. SoCs such as SDM845. RPMh is a hardware block
which contains several accelerators which are used to manage various
Introduce bindings for RPMh regulator devices found on some
Qualcomm Technlogies, Inc. SoCs. These devices allow a given
processor within the SoC to make PMIC regulator requests which
are aggregated within the RPMh hardware block along with requests
from other processors in the SoC to determine th
Hi,
Dne petek, 16. marec 2018 ob 15:02:13 CET je Icenowy Zheng napisal(a):
> The Allwinner H6 SoC has a CCU which has been largely rearranged.
>
> Add support for it in the sunxi-ng CCU framework.
>
> Signed-off-by: Icenowy Zheng
> Acked-by: Maxime Ripard
> ---
> Changes in v4:
> - Extract the
On 03/15/2018 08:11 PM, Josh Poimboeuf wrote:
On Thu, Mar 15, 2018 at 08:06:26AM -0700, Laura Abbott wrote:
This only showed up with the very latest rawhide snapshot, .17 worked and
.18 started failing. I had to download .18 manually to test locally
https://koji.fedoraproject.org/koji/packageinf
On Fri, Mar 16, 2018 at 02:13:43PM -0400, Waiman Long wrote:
> Checking code is added to provide the following additional
> ctl_table.flags checks:
>
> 1) No unknown flag is allowed.
> 2) Minimum of a range cannot be larger than the maximum value.
> 3) The signed and unsigned flags are mutually
On Fri, Mar 16, 2018 at 06:02:20PM +, Lorenzo Pieralisi wrote:
> On Thu, Mar 08, 2018 at 02:33:26PM +0100, Niklas Cassel wrote:
> > If a BAR supports 64-bit width or not depends on the hardware,
> > and should thus not depend on sizeof(dma_addr_t).
> >
> > Since this driver is generic, default
Hi Jérôme,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc5 next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
On Fri, Mar 16, 2018 at 9:14 PM, Linus Torvalds
wrote:
> On Fri, Mar 16, 2018 at 1:03 PM, Miguel Ojeda
> wrote:
>>>
>>> Kees - is there some online "gcc-4.4 checker" somewhere? This does
>>> seem to work with my gcc. I actually tested some of those files you
>>> pointed at now.
>>
>> I use this o
On Fri, Mar 9, 2018 at 3:26 PM Lina Iyer wrote:
> Platform drivers need make a lot of resource state requests at the same
> time, say, at the start or end of an usecase. It can be quite
> inefficient to send each request separately. Instead they can give the
> RPMH library a batch of requests to
On Fri, Mar 9, 2018 at 3:27 PM Lina Iyer wrote:
> Active state requests are sent immediately to the mailbox controller,
> while sleep and wake state requests are cached in this driver to avoid
> taxing the mailbox controller repeatedly. The cached values will be sent
> to the controller when the
On Fri, Mar 9, 2018 at 3:27 PM Lina Iyer wrote:
> Sleep and wake requests are sent when the application processor
> subsystem of the SoC is entering deep sleep states like in suspend.
> These requests help lower the system power requirements when the
> resources are not in use.
> Sleep and wake
branches. If you do that kind
> of stuff, at least do it against something in the public trees
> and _tell_ _what_ _it_ _is_ _against_.
Hello Al,
I always base my patches on linux-next, which is usually correct,
and if it isn't, the maintainer usually says something :)
The patch in ques
Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set
warnings to full") enabled extra warnings for i915 to spot possible
bugs in new code, and then disabled a subset of these warnings to keep
the current code building without warnings (with gcc). Enabling the
extra warnings also enab
On Fri, Mar 16, 2018 at 04:59:02PM -0700, syzbot wrote:
> Hello,
>
> syzbot hit the following crash on upstream commit
> e2c15aff5f353ba80bd3bb49840837f65fa5cc43 (Thu Mar 15 18:07:35 2018 +)
> Merge tag 'sound-4.16-rc6' of
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
>
> So far
On Fri, 16 Mar 2018 13:53:01 -0400 (EDT)
Mathieu Desnoyers wrote:
> - On Mar 16, 2018, at 12:48 PM, rostedt rost...@goodmis.org wrote:
>
> > On Fri, 16 Mar 2018 12:41:34 -0400
> > Steven Rostedt wrote:
> >
> >> Yes, kprobes are dangerous. I'm not saying it shouldn't be fixed, I'm
> >> sayi
On Fri, 16 Mar 2018 12:28:59 -0400 (EDT)
Mathieu Desnoyers wrote:
> - On Mar 16, 2018, at 11:25 AM, rostedt rost...@goodmis.org wrote:
>
> > On Fri, 16 Mar 2018 11:18:25 -0400
> > Francis Deslauriers wrote:
> >
> >> Hi Steven,
> >>
> >> I completely forgot about this issue until recently
Hi Christophe,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v4.16-rc4]
[also build test ERROR on next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits
We have found that MLX5 will trigger a dump_cqe if we don't
invalidate the rkey on a newly alloated MR for FastReg usage.
This fix just tags the MR as invalid on its creation if we are
using FastReg and that will force it to do an invalidate of the
rkey on first usage.
Signed-off-by: Doug Ouchare
On Fri, Mar 16, 2018 at 09:50:21AM +0100, Geert Uytterhoeven wrote:
> Hi Dmitry,
>
> On Thu, Mar 15, 2018 at 11:42 PM, Dmitry Torokhov
> wrote:
> > Instead of backlight legacy platform data, let's switch to using device
> > properties and GPIO lookup tables.
> >
> > Signed-off-by: Dmitry Torokhov
Hi Jacopo,
On Fri, Mar 16, 2018 at 11:07:48AM +0100, jacopo mondi wrote:
> Hello Dmitry
>
> FYI I am brushing the ecovec board these days as well
> https://www.spinics.net/lists/linux-sh/msg52536.html
>
What is the ecovec board BTW? Is it some devkit or what? It seems quite
old to me.
> And I
On Sat, 17 Mar 2018 02:21:47 +0300 Alexey Dobriyan wrote:
> /proc/kmsg can and will block if read under root.
>
This fixes
proc-shotgun-test-read-readdir-readlink-a-little-write.patch. It helps
to point that out, so that reviewers won't be scrambling around
asking wtf.
On Fri, Mar 16, 2018 at 03:13:37PM -0700, Andrew Morton wrote:
> On Fri, 16 Mar 2018 15:55:16 +0800 Huacai Chen wrote:
>
> > Call __stack_chk_guard_setup() in decompress_kernel() is too late that
> > stack checking always fails for decompress_kernel() itself. So remove
> > __stack_chk_guard_setup
/proc/kmsg can and will block if read under root.
Signed-off-by: Alexey Dobriyan
---
tools/testing/selftests/proc/read.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/tools/testing/selftests/proc/read.c
+++ b/tools/testing/selftests/proc/read.c
@@ -54,7 +54,8 @@ static void
>
> On 3/16/2018 5:05 PM, Steve Wise wrote:
> >> Code includes wmb() followed by writel(). writel() already has a barrier
> > on
> >> some architectures like arm64.
> >>
> >> This ends up CPU observing two barriers back to back before executing
> the
> >> register write.
> >>
> >> Since code alrea
"Gustavo A. R. Silva" writes:
> In preparation to enabling -Wvla, remove VLA. In this particular
> case use macro ARRAY_SIZE so the length of array _bo_ can be
> computed at preprocessing time.
>
> The use of stack Variable Length Arrays needs to be avoided, as they
> can be a vector for stack ex
>
> On Fri, Mar 16, 2018 at 04:05:10PM -0500, Steve Wise wrote:
> > > Code includes wmb() followed by writel(). writel() already has a
barrier
> > on
> > > some architectures like arm64.
> > >
> > > This ends up CPU observing two barriers back to back before executing
> the
> > > register write.
>
El Sat, Mar 03, 2018 at 11:16:11PM -0800 Nick Desaulniers ha dit:
> Clang complains when a variable is declared extern twice, but with two
> different sections. num_poisoned_pages is marked extern and __read_mostly
> in include/linux/swapops.h, but only extern in include/linux/mm.h. Some
> c sourc
Quoting Sudeep Holla (2018-02-23 08:23:46)
> diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c
> new file mode 100644
> index ..1e4d7a57779b
> --- /dev/null
> +++ b/drivers/clk/clk-scmi.c
> + hws[idx] = &sclk->hw;
> + }
> + }
> +
> +
On Thu, 15 Mar 2018 15:59:19 -0700 Kees Cook wrote:
> Avoid stack VLAs[1] by always allocating the upper bound of stack space
> needed. The existing users of rslib appear to max out at 24 roots[2],
> so use that as the upper bound until we have a reason to change it.
>
> Alternative considered:
Quoting Arnd Bergmann (2018-02-20 07:15:21)
> The symbol is in the __initconst section but not marked init, which
> caused a warning when building with LTO.
>
> This makes it 'const' as was obviously intended.
>
> Signed-off-by: Arnd Bergmann
> ---
Applied to clk-next
On 03/13/2018 04:56 PM, Andy Lutomirski wrote:
> On Tue, Mar 13, 2018 at 11:16 PM, Howard McLauchlan
> wrote:
>> Error injection is a useful mechanism to fail arbitrary kernel
>> functions. However, it is often hard to guarantee an error propagates
>> appropriately to user space programs. By inje
Quoting Arnd Bergmann (2018-02-16 07:27:47)
> When we build this driver with on x86-32, gcc produces a false-positive
> warning:
>
> drivers/clk/renesas/clk-sh73a0.c: In function 'sh73a0_cpg_clocks_init':
> drivers/clk/renesas/clk-sh73a0.c:155:10: error: 'parent_name' may be used
> uninitialized
Greg,
Sorry, if I'm missing something, but I see 3 patches for
hpwdt queued up for 4.4:
queue-4.4/watchdog-hpwdt-fix-unused-variable-warning.patch
queue-4.4/watchdog-hpwdt-smbios-check.patch
queue-4.4/watchdog-hpwdt-check-source-of-nmi.patch
Shouldn't there also be a 4.
Quoting Chunyan Zhang (2018-02-09 01:55:09)
> From: Chunyan Zhang
>
> Add a few gate clocks which are used for gating RTC for some
> devices on AON area of SC9860.
>
> This patch has been tested on SC9860, with this patch and proper DT
> configurations, the watchdog can be initialized and work w
Quoting Chunyan Zhang (2018-02-09 01:48:10)
> From: Chunyan Zhang
>
> Added index of RTC gate clocks which are used by some devices on aon
> area of SC9860, for example the Watchdog timer.
>
> Signed-off-by: Chunyan Zhang
> ---
Applied to clk-next
Quoting Stephen Boyd (2018-02-01 16:33:26)
> Signed-off-by: Stephen Boyd
> ---
Applied to clk-next
The read operation for the I2C function has many duplications that can
be generalized into a single function. This patch reworks the read
operation for I2C to centralizes all similar code in a single function.
Part of the rework includes a proper error handling and a fix on the
i2c_master_recv for
The original code had a read function per data size; after updates, all
read functions tasks were centralized in a single function, but the old
signature was kept to maintain the module working without problems. This
patch removes a set of duplications associated with read_reg_*, and
update the are
Rework read SPI function to reduce the code duplication and centralizes
all the task in a single function.
Signed-off-by: Rodrigo Siqueira
---
drivers/staging/iio/meter/ade7854-spi.c | 140 +---
1 file changed, 37 insertions(+), 103 deletions(-)
diff --git a/drivers/
The write operation using SPI has a many code duplications (similar to
I2C) and four different interfaces per data size. This patch introduces
a single function that centralizes the main task related to SPI.
Signed-off-by: Rodrigo Siqueira
---
drivers/staging/iio/meter/ade7854-spi.c | 108 ++
This patch removes code duplications related to the write_reg_*
functions and centralizes them in a single function. Also, it eliminates
the legacy functions and replaces them by a unique signature that is
used by SPI and I2C.
Signed-off-by: Rodrigo Siqueira
---
drivers/staging/iio/meter/ade7854
The function ade7854_i2c_read_reg_32() have to invoke the
i2c_master_recv() for read 32 bits values, however, the counter is set
to 3 which means 24 bits. This patch fixes the wrong size of 24 bits, to
32 bits. Finally, this patch is based on John Syne patches.
Signed-off-by: Rodrigo Siqueira
Sig
The write operation using I2C has many code duplications and four
different interfaces per data size. This patch introduces a single
function that centralizes the main tasks.
The central function inserted by this patch can easily replace all the
four functions related to the data size. However, th
This patchset reworks the I2C/SPI code from meter module. The set of
patches try to reduce the code duplication and make the communication
reliable. The current version of the module had many code duplications,
which make the code more error-prone and hard to read. Jonh Syne
identified some wrong e
The original code does not correctly handle the error related to I2C
read and write. This patch fixes the error handling related to all
read/write functions for I2C. This patch is an adaptation of the John
Syne patches.
Signed-off-by: Rodrigo Siqueira
Signed-off-by: John Syne
---
drivers/stagin
Quoting Dong Aisheng (2018-01-23 04:24:45)
> we need it even when !CONFIG_HAVE_CLK because it allows
> us to catch missing checking return values in the non-clk
> compile configurations too. More test coverage.
>
> Cc: Stephen Boyd
> Suggested-by: Stephen Boyd
> Signed-off-by: Dong Aisheng
> --
Quoting Dong Aisheng (2018-01-19 05:37:15)
> The core does not need to hold enable lock for clk_is_enabled API.
> Update the doc to reflect it.
>
> Cc: Jonathan Corbet
> Cc: Stephen Boyd
> Suggested-by: Stephen Boyd
> Signed-off-by: Dong Aisheng
> ---
Applied to clk-next
On Thu, 15 Mar 2018 15:59:19 -0700 Kees Cook wrote:
> Avoid stack VLAs[1] by always allocating the upper bound of stack space
> needed. The existing users of rslib appear to max out at 24 roots[2],
> so use that as the upper bound until we have a reason to change it.
>
> Alternative considered:
Quoting srinivas.kandaga...@linaro.org (2017-12-07 02:59:22)
> From: Srinivas Kandagatla
>
> aggre0 bus clks are not associated with any of the drivers, so its
> important that these clks are always on to get peripherals on this
> bus working. So mark them as critical.
>
> Eventually when we hav
On 02/21/2018 05:55 PM, Ram Pai wrote:
> From: Thiago Jung Bauermann
>
> The sig_chld() handler calls dprintf2() taking care of setting
> dprint_in_signal so that sigsafe_printf() won't call printf().
> Unfortunately, this precaution is is negated by dprintf_level(), which
> has a call to fflush(
On 02/21/2018 05:55 PM, Ram Pai wrote:
...
> @@ -888,6 +917,7 @@ void setup_hugetlbfs(void)
> void *(*pkey_malloc[])(long size, int prot, u16 pkey) = {
>
> malloc_pkey_with_mprotect,
> + malloc_pkey_with_mprotect_subpage,
> malloc_pkey_anon_huge,
> malloc_pkey_hugetlb
> /*
On 02/21/2018 05:55 PM, Ram Pai wrote:
> Generally the signal handler restores the state of the pkey register
> before returning. However there are times when the read/write operation
> can legitamely fail without invoking the signal handler. Eg: A
> sys_read() operaton to a write-protected page s
Quoting Brian Starkey (2017-11-13 07:27:51)
> clk_round_rate() is intended to be used to round a given clock rate to
> the closest one achievable by the actual clock. This implies that the
> input to clk_round_rate() is expected to be unachievable - and such
> cases shouldn't be treated as exceptio
On 02/21/2018 05:55 PM, Ram Pai wrote:
> detect write-violation on a page to which write-disabled
> key is associated much after the page is mapped.
The more tests the merrier.
Acked-by: Dave Hansen
On 02/21/2018 05:55 PM, Ram Pai wrote:
> detect write-violation on a page to which access-disabled
> key is associated much after the page is mapped.
Acked-by: Dave Hansen
Quoting Sudeep Holla (2017-11-10 08:06:57)
> Clock framework has a provider API(clk_hw_set_rate_range) to set the
> min/max rate of a clock. Use the same to set the boundaries for the
> vexpress osc clock.
>
> Cc: Michael Turquette
> Cc: Stephen Boyd
> Cc: linux-...@vger.kernel.org
> Signed-off-
Quoting Sudeep Holla (2018-02-19 07:55:37)
> On Fri, Nov 10, 2017 at 4:06 PM, Sudeep Holla wrote:
> > Clock framework has a provider API(clk_hw_set_rate_range) to set the
> > min/max rate of a clock. Use the same to set the boundaries for the
> > vexpress osc clock.
> >
> > Cc: Michael Turquette
On 02/21/2018 05:55 PM, Ram Pai wrote:
> detect access-violation on a page to which access-disabled
> key is associated much after the page is mapped.
Looks fine to me. Did this actually find a bug for you?
Acked-by: Dave Hansen
Quoting David Lechner (2018-01-04 16:38:05)
> I am writing some clock drivers that use struct clk_onecell_data a few
> times, so I decided to write a helper function to allocate the memory
> since it is a two step process and can be tedious. Then I noticed that
> mediatek already had such a helper
On 02/21/2018 05:55 PM, Ram Pai wrote:
> +static inline int arch_reserved_keys(void)
> +{
> +#if defined(__i386__) || defined(__x86_64__) /* arch */
> + return NR_RESERVED_PKEYS;
> +#elif __powerpc64__ /* arch */
> + if (sysconf(_SC_PAGESIZE) == 4096)
> + return NR_RESERVED_PKEY
1 - 100 of 1393 matches
Mail list logo