[PATCH] tty: ehv_bytechan: fix spelling mistake

2017-10-28 Thread Arvind Yadav
Trivial fix to spelling mistakes "interupt" -> "interrupt". Signed-off-by: Arvind Yadav --- drivers/tty/ehv_bytechan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/ehv_bytechan.c b/drivers/tty/ehv_bytechan.c index a1c7125..ec0989d 100644 --- a/drivers/tty/e

[PATCH] mtd: mtdswap: fix spelling mistake: 'TRESHOLD' -> 'THRESHOLD'

2017-10-28 Thread Arvind Yadav
Trivial fix to spelling mistakes. Signed-off-by: Arvind Yadav --- drivers/mtd/mtdswap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c index 7d9080e..f07492c 100644 --- a/drivers/mtd/mtdswap.c +++ b/drivers/mtd/mtdswap.c @@ -

Re: [PATCH] Enable SR-IOV instantiation through /sys file

2017-10-28 Thread Christoph Hellwig
On Fri, Oct 27, 2017 at 11:20:41PM +, Duyck, Alexander H wrote: > I don't see this so much as a security problem per-se. It all depends > on the hardware setup. If I recall correctly, there are devices where > the PF function doesn't really do much other than act as a bit more > heavy-weight VF

[PATCH] scsi: scsi_transport_iscsi: fix spelling mistake: 'Cound' -> 'Could'

2017-10-28 Thread Arvind Yadav
Trivial fix to spelling mistakes in 'iscsi_get_host_stats'. Signed-off-by: Arvind Yadav --- drivers/scsi/scsi_transport_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index 8934f19..590a56c 10

[PATCH] mfd: pcf50633: fix spelling mistake: 'Falied' -> 'Failed'

2017-10-28 Thread Arvind Yadav
Trivial fix to spelling mistakes in 'pcf50633_client_dev_register'. Signed-off-by: Arvind Yadav --- drivers/mfd/pcf50633-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c index 6155d12..f952dff 100644 --- a/driver

gma500: mmu: unmap the correct address

2017-10-28 Thread Pan Bian
The function kunmap_atomatic() is called on the same variable twice, i.e. pt->v. In the second call, its parameter should be variable v rather than pt->v. Signed-off-by: Pan Bian --- drivers/gpu/drm/gma500/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

[PATCH] leds: lp55xx: fix spelling mistake: 'cound' -> 'could'

2017-10-28 Thread Arvind Yadav
Trivial fix to spelling mistakes in 'lp5523_init_program_engine'. Signed-off-by: Arvind Yadav --- drivers/leds/leds-lp5523.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index 924e50a..52b6f529 100644 --- a/drivers/le

Re: [PATCH net-next] hv_netvsc: Set tx_table to equal weight after subchannels open

2017-10-28 Thread David Miller
From: Haiyang Zhang Date: Fri, 27 Oct 2017 12:36:38 -0700 > From: Haiyang Zhang > > In some cases, like internal vSwitch, the host doesn't provide > send indirection table updates. This patch sets the table to be > equal weight after subchannels are all open. Otherwise, all workload > will be o

[PATCH] Fix line too long warning

2017-10-28 Thread Kien Ha
>From fc52a98aca0c033f2c03fdc7e8f83ae49625675a Mon Sep 17 00:00:00 2001 From: Kien Ha Date: Fri, 27 Oct 2017 14:07:55 -0400 Subject: [PATCH] Fix line too long warning Signed-off-by: Kien Ha --- drivers/staging/rtlwifi/base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/

Re: [PATCH v2] fs: fsnotify: account fsnotify metadata to kmemcg

2017-10-28 Thread Matthew Wilcox
On Sat, Oct 28, 2017 at 05:19:36PM +0300, Amir Goldstein wrote: > > Due to the current design of kmemcg, the memcg of the process who does the > allocation gets the accounting, so event allocations get accounted for > the memcg of > the event producer process, even though the misbehaving process i

Re: Linux 4.14-rc6 bisected regression tun devices not working anymore in openvpn

2017-10-28 Thread David Miller
From: Cong Wang Date: Sat, 28 Oct 2017 10:37:27 -0700 > On Sat, Oct 28, 2017 at 7:57 AM, Sander Eikelenboom > wrote: >> The offending commit is: >> 0ad646c81b2182f7fa67ec0c8c825e0ee165696d >> "tun: call dev_get_valid_name() before register_netdevice()" >> >> Reverting this commit fixes t

Re: [PATCH 2/4] x86/alternatives: Don't need text_mutex when text_poke() on UP

2017-10-28 Thread zhouchengming
Oops, this is very wrong. Please ignore this patchset. Sorry for the noise... Thanks! On 2017/10/28 20:50, Zhou Chengming wrote: The alternatives_smp_lock/unlock only be used on UP, so we don't need to hold the text_mutex when text_poke(). Then in the next patch, we can remove the outside smp_

Re: [PATCH v3] KVM: arm/arm64: fix the incompatible matching for external abort

2017-10-28 Thread Marc Zyngier
On Sat, Oct 28 2017 at 2:45:59 pm BST, Dongjiu Geng wrote: > For this matching, switch expression uses fault type which is > not {I,D}FSC value, but the case expression uses {I,D}FSC, > they are incompatible. So change the switch expression to > use {I,D}FSC. I'm sorry, but I can't manage to pa

Re: [f2fs-dev] [PATCH v2] f2fs: update dirty status for CURSEG as well

2017-10-28 Thread Chao Yu
Hi Yunlong, On 2017/10/28 23:58, Yunlong Song wrote: > Hi Chao, >     Thanks for your work. I send a v2 patch, which changes refresh_sit_entry > to static. The cleanup looks good to me, but you know, the commit title is not friendly for reading, what about using common 'Revert: "original commit

Re: rseq event_counter field

2017-10-28 Thread Mathieu Desnoyers
- On Oct 28, 2017, at 10:20 PM, Andy Lutomirski l...@kernel.org wrote: > Answering both emails here. > > Also, welcome Kyle. Kyle, how badly does rseq's proposed > event_counter break rr? For that matter, how badly does rseq without > an event_counter break rr? > > (Linus, if you care, I'm

Re: [PATCH] fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get

2017-10-28 Thread Gustavo A. R. Silva
Hi Moritz, Quoting Moritz Fischer : On Fri, Oct 27, 2017 at 08:19:51PM +, Gustavo A. R. Silva wrote: Notice that bridge = to_fpga_bridge(dev); expands to: bridge = container_of(dev, struct fpga_bridge, dev); and container_of is never null, so this null check is unnecessary. Addresses-Co

[PATCH] Coccinelle: use false positive annotation

2017-10-28 Thread Julia Lawall
/// is to describe the semantic patch, while //# indicates reasons for false positives. Signed-off-by: Julia Lawall --- scripts/coccinelle/misc/ifcol.cocci |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/coccinelle/misc/ifcol.cocci b/scripts/coccinelle/misc

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-28 Thread Gustavo A. R. Silva
Quoting Bjørn Mork : "Gustavo A. R. Silva" writes: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I replaced "...drop on through" comments with a proper "fall through" comment on its own line,

Re: Can we break RDPID/RDTSCP ABI ASAP and see if it's okay?

2017-10-28 Thread Linus Torvalds
On Sat, Oct 28, 2017 at 12:38 PM, Andy Lutomirski wrote: > > This won't break any existing RDPID users if we do it quickly because > there aren't any (the CPUs aren't available). I would be a bit > surprised if anyone uses RDTSCP for this because it's absurdly slow. Why do you think that? Lots

[tip:perf/urgent] perf symbols: Fix memory corruption because of zero length symbols

2017-10-28 Thread tip-bot for Ravi Bangoria
Commit-ID: 331c7cb307971eac38e9470340e10c87855bf4bc Gitweb: https://git.kernel.org/tip/331c7cb307971eac38e9470340e10c87855bf4bc Author: Ravi Bangoria AuthorDate: Tue, 24 Oct 2017 19:50:06 +0530 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 25 Oct 2017 13:01:09 -0300 perf symbols

[tip:perf/urgent] perf tools: Unwind properly location after REJECT

2017-10-28 Thread tip-bot for Jiri Olsa
Commit-ID: 9445464bb8318e42e5232b37fc7218ed028517f6 Gitweb: https://git.kernel.org/tip/9445464bb8318e42e5232b37fc7218ed028517f6 Author: Jiri Olsa AuthorDate: Thu, 12 Oct 2017 17:03:38 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 27 Oct 2017 11:42:51 -0300 perf tools: Unwi

Re: [PATCH 07/27] kexec_file: Disable at runtime if securelevel has been set

2017-10-28 Thread Mimi Zohar
On Thu, 2017-10-26 at 10:17 -0400, Mimi Zohar wrote: > On Thu, 2017-10-26 at 15:42 +0800, joeyli wrote: > > Hi Mimi, > > > > Thank you for reviewing. > > > > On Mon, Oct 23, 2017 at 11:54:43AM -0400, Mimi Zohar wrote: > > > On Thu, 2017-10-19 at 15:51 +0100, David Howells wrote: > > > > From: Chu

[PATCH v2 4/4] platform/x86: topstar-laptop: add optional WLAN LED workaround

2017-10-28 Thread Guillaume Douézan-Grard
Topstar U931 laptops provide an LED synced with the WLAN adapter hard-blocking state. Unfortunately, some models seem to be defective, making impossible to hard-block the adapter with the WLAN switch and thus the LED is useless. An ACPI method is available to programmatically control this switch a

[PATCH v2 3/4] platform/x86: topstar-laptop: add platform device

2017-10-28 Thread Guillaume Douézan-Grard
* add platform device to support further addition of a led subsystem, * add existing input device to the new platform device. Signed-off-by: Guillaume Douézan-Grard --- drivers/platform/x86/topstar-laptop.c | 59 +-- 1 file changed, 57 insertions(+), 2 deletions(

[PATCH v2 2/4] platform/x86: topstar-laptop: change to generic module

2017-10-28 Thread Guillaume Douézan-Grard
Signed-off-by: Guillaume Douézan-Grard --- drivers/platform/x86/topstar-laptop.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/topstar-laptop.c b/drivers/platform/x86/topstar-laptop.c index 106537fdc4e6..714d9d56c79f 100644 --- a/dr

[PATCH v2 1/4] platform/x86: topstar-laptop: non-functional changes

2017-10-28 Thread Guillaume Douézan-Grard
Minor consistency changes to prepare further addition of platform device and LED. More precisely: * more consistent naming (module description, header text, devices names and programming constructs), * clear separation between systems (ACPI events and input handling), * copyright and module aut

[PATCH v2 0/4] Topstar ACPI LED Workaround

2017-10-28 Thread Guillaume Douézan-Grard
Hi Andy, Thank you for your review. Changes since the previous submission are highlighted below. On Topstar U931 Notebooks, an issue prevents the WLAN toggle key from being properly managed by the Embedded Controller and successfully disconnect the adapter. A specific ACPI method allows to toggle

Re: [PATCH V2 net] tuntap: properly align skb->head before building skb

2017-10-28 Thread Wei Wei
With this patch, the crash can’t be reproduced with the syz-repro and crash log0/log1. The auto-generated reproducers are here: https://github.com/dotweiba/skb_clone_atomic_inc_bug Thanks, Wei > On 28 Oct 2017, at 6:06 AM, David Miller wrote: > > From: Jason Wang > Date: Fri, 27 Oct 2017 11:

Re: [PATCH] phylink: Use common error handling code in phylink_create()

2017-10-28 Thread Russell King - ARM Linux
On Sat, Oct 28, 2017 at 10:00:33PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 28 Oct 2017 21:48:31 +0200 > > * Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > * Adjust three condition checks. > > This issue

Re: [PATCH] staging: vc04_services: Convert timers to use timer_setup()

2017-10-28 Thread Stefan Wahren
> Kees Cook hat am 24. Oktober 2017 um 10:26 > geschrieben: > > > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Greg Kroah-Hartman > Cc:

[PATCH v2 1/3] iio: adc: ina2xx: Shift bus voltage register to mask flag bits

2017-10-28 Thread Stefan Brüns
Lower bits of the INA219/220 bus voltage register are conversion status flags, properly shift the value. When reading via IIO buffer, the value is passed on unaltered, shifting is the responsibility of the user. Signed-off-by: Stefan Brüns --- Changes in v2: - Apply to the shunt voltage, not b

[PATCH v2 0/3] iio: adc: ina2xx: Fixes and extensions

2017-10-28 Thread Stefan Brüns
The first patch fixes an issue with the conversion-ready status flag showing up in the bus voltage raw value. (removed original second patch from series, as already applied to togreg branch) The second patch cleans up the specification of the LSB value for the shunt voltage register. For code rea

[PATCH v2 3/3] iio: adc: ina2xx: Allow setting Shunt Voltage PGA gain and Bus Voltage range

2017-10-28 Thread Stefan Brüns
Reducing shunt and bus voltage range improves the accuracy, so allow altering the default settings. Both settings are exposed as gain values. While for the shunt voltage this is straightforward, the bus range settings of 32V (default) and 16V are mapped to gain values of 1 resp. 2, to provide a un

[PATCH v2 2/3] iio: adc: ina2xx: Use LSB specifier instead of divider in config

2017-10-28 Thread Stefan Brüns
While the config uses the physical value corresponding to the LSB for both the power and the bus voltage register, the shunt voltage is specified as parts of 1 mV. Use the LSB physical value for all registers. No functional change. Signed-off-by: Stefan Brüns --- Changes in v2: - new patch d

Re: [PATCH] phylink: Use common error handling code in phylink_create()

2017-10-28 Thread Florian Fainelli
On 10/28/2017 01:00 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 28 Oct 2017 21:48:31 +0200 > > * Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > * Adjust three condition checks. > > This issue was detected by

[PATCH] lan78xx: Use common error handling code in lan78xx_phy_init()

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 22:42:52 +0200 * Add a jump target so that a specific error message is stored only once at the end of this function implementation. * Replace two calls of the function "netdev_err" by goto statements. * Adjust two condition checks. This issue was d

Re: [PATCH] i2c: generic recovery: check SCL before SDA

2017-10-28 Thread Wolfram Sang
On Thu, Oct 05, 2017 at 02:44:14PM +0200, Claudio Foellmi wrote: > Move the check for a stuck SCL before the check for a high SDA. > This prevent false positives in the specific case that SDA is fine > and SCL is stuck, which previously returned 0. > > Also check SDA again after the loop, if we ca

[PATCH] net: dccp: ccids: lib: packet_history: use swap macro in tfrc_rx_hist_swap

2017-10-28 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/dccp/ccids/lib/packet_history.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-

[PATCH 5/9] media: staging/imx: pass fwnode handle to find/add async subdev

2017-10-28 Thread Steve Longerbeam
Pass the subdev's fwnode_handle to imx_media_find_async_subdev() and imx_media_add_async_subdev(), instead of a device_node. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-dev.c | 20 ++-- drivers/staging/media/imx/imx-media-of.c | 7 +++ drivers/st

[PATCH 6/9] media: staging/imx: remove static subdev arrays

2017-10-28 Thread Steve Longerbeam
For more complex OF graphs, there will be more async subdevices registered. Remove the static subdev[IMX_MEDIA_MAX_SUBDEVS] array, so that imx-media places no limits on the number of async subdevs that can be added and registered. There were two uses for 'struct imx_media_subdev'. First was to act

[PATCH 4/9] media: staging/imx: remove devname string from imx_media_subdev

2017-10-28 Thread Steve Longerbeam
A separate string for the device name, for DEVNAME async match, was never needed. Just assign the asd device name to the passed platform device name pointer in imx_media_add_async_subdev(). Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-dev.c | 3 +-- drivers/staging/med

[PATCH 3/9] media: staging/imx: of: allow for recursing downstream

2017-10-28 Thread Steve Longerbeam
Calling of_parse_subdev() recursively to a downstream path that has already been followed is ok, it just means that call will return immediately since the subdevice was already added to the async list. With that there is no need to determine whether a subdevice's port is a sink or source, so 'num_

[PATCH 1/9] media: staging/imx: get CSI bus type from nearest upstream entity

2017-10-28 Thread Steve Longerbeam
The imx-media driver currently supports a device tree graph of limited complexity. This patch is a first step in allowing imx-media to work with more general OF graphs. The CSI subdevice assumes the originating upstream subdevice (the "sensor") is connected directly to either the CSI mux or the MI

[PATCH 7/9] media: staging/imx: convert static vdev lists to list_head

2017-10-28 Thread Steve Longerbeam
Although not technically necessary because imx-media has only a maximum of 8 video devices, and once setup the video device lists are static, in anticipation of moving control ineritance to v4l2-core, make the vdev lists more generic by converting to dynamic list_head's. After doing that, 'struct

[PATCH 9/9] media: staging/imx: update TODO

2017-10-28 Thread Steve Longerbeam
Update TODO file: - Remove TODO info about the OV564x driver, while this still needs to be done (add a OV5642 driver or merge with OV5640 driver), it is not relevant here. - Update TODO about methods for retrieving CSI bus config. - Add some TODO's about OF graph parsing restrictions. Signe

[PATCH 2/9] media: staging/imx: remove static media link arrays

2017-10-28 Thread Steve Longerbeam
Remove the static list of media links that were formed at probe time. These links can instead be created after all registered async subdevices have been bound in imx_media_probe_complete(). The media links between subdevices that exist in the device tree, can be created post-async completion by us

[PATCH 8/9] media: staging/imx: reorder function prototypes

2017-10-28 Thread Steve Longerbeam
Re-order some of the function prototypes in imx-media.h to group them correctly by source file. No functional changes. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media.h | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/stag

[PATCH 0/9] media: imx: Add better OF graph support

2017-10-28 Thread Steve Longerbeam
This is a set of patches that improve support for more complex OF graphs. Currently the imx-media driver only supports a single device with a single port connected directly to either the CSI muxes or the MIPI CSI-2 receiver input ports. There can't be a multi-port device in between. This patch set

[PATCH] net: decnet: dn_nsp_out: use swap macro in dn_mk_ack_header

2017-10-28 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/decnet/dn_nsp_out.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff

Re: [RFC PATCH v8 7/7] PCI / PM: Add support for the PCIe WAKE# signal for OF

2017-10-28 Thread Brian Norris
On Sat, Oct 28, 2017 at 02:01:46PM -0400, Sinan Kaya wrote: > I was looking for some code that can be used between OF and ACPI rather than > duplicating the code in two different places just to extract some information > from the platform firmware. > > My initial look at your code suggested it to

[PATCH] netfilter: ipset: ip_set_bitmap_port: use swap macro in bitmap_port_create

2017-10-28 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/netfilter/ipset/ip_set_bitmap_port.c | 8 ++-- 1 file changed, 2 insertions(+), 6 d

Re: [PATCH] ARM: dts: meson8b: add reserved memory zone to fix silent freezes

2017-10-28 Thread Linus Lüssing
On Mon, Oct 23, 2017 at 09:47:21AM +0200, Linus Lüssing wrote: > I'm currently continuing to bisect which difference in Emiliano's > and my kernel image makes mine boot successfully but not > Emiliano's. (And I'm continuing reading and testing with the > filter-range option to better understand wha

[RFC] Testing builds with Clang

2017-10-28 Thread Nick Desaulniers
Hello, Recently, a fair amount of effort has gone into compiling the kernel with Clang/LLVM. We were curious what might be some of the requirements to getting 0-day coverage for Clang built kernels? https://lwn.net/Articles/734071/ As in, does Clang need to support allmodconfig, randconfig, all

[PATCH] netfilter: ipset: ip_set_bitmap_ip: use swap macro in bitmap_ip_create

2017-10-28 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/netfilter/ipset/ip_set_bitmap_ip.c | 8 ++-- 1 file changed, 2 insertions(+), 6 del

Re: rseq event_counter field

2017-10-28 Thread Andy Lutomirski
Answering both emails here. Also, welcome Kyle. Kyle, how badly does rseq's proposed event_counter break rr? For that matter, how badly does rseq without an event_counter break rr? (Linus, if you care, I'm proposing that rseq is probably fine for 4.15, but that it should be merged without the e

Re: [PATCH] ipv6: exthdrs: use swap macro in ipv6_dest_hao

2017-10-28 Thread Gustavo A. R. Silva
Quoting David Miller : From: "Gustavo A. R. Silva" Date: Thu, 26 Oct 2017 23:10:35 -0500 make use of the swap macro and remove unnecessary variable tmp_addr. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Si

[PATCH] netfilter: ipset: ip_set_bitmap_ipmac: use swap macro in bitmap_ipmac_create

2017-10-28 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/netfilter/ipset/ip_set_bitmap_ipmac.c | 8 ++-- 1 file changed, 2 insertions(+), 6

Re: can: Use common error handling code in vxcan_newlink()

2017-10-28 Thread SF Markus Elfring
>> Are you interested in related adjustments for a bigger code base? > > No. Definitely not. You might have noticed that I am proposing similar changes already for other software modules. ;-) > If you aim for the the deletion of “ < 0” for all rtnl_configure_link() users > you would need to d

"PM / QoS: Fix device resume latency PM QoS" breaks sound

2017-10-28 Thread Chris Clayton
Hi, I pulled the latestchanges from Linus' tree this evening and have found that with the new kernel, sound is not working on my laptop. More precisely, the built-in speakers don't produce any sound. Sound does work when I use ear-plugs in the headphone socket. It also works via a bluetooth spea

[PATCH] phylink: Use common error handling code in phylink_create()

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 21:48:31 +0200 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. * Adjust three condition checks. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH] i2c: xgene-slimpro: Support v2

2017-10-28 Thread Wolfram Sang
> > I can't tell if __force is justified here but I don't know much about > > ACPI... Andy, can you have a look? > > Few comments to the patch as well. Thanks, Andy! And was nice to finally meet you in Prague :) signature.asc Description: PGP signature

Re: can: Use common error handling code in vxcan_newlink()

2017-10-28 Thread Oliver Hartkopp
On 10/28/2017 09:18 PM, SF Markus Elfring wrote: If you want to change the semantic of the result check I am curious if another source code reduction (by the deletion of “ < 0”) will become acceptable at similar places. Source code reduction is not the main target. If you can simplify code w

Can we break RDPID/RDTSCP ABI ASAP and see if it's okay?

2017-10-28 Thread Andy Lutomirski
We currently do this on boot: write_rdtscp_aux((node << 12) | cpu); This *sucks*. It means that, to very quickly obtain the CPU number using RDPID, an ALU op is needed. It also doesn't bloody work on systems with more than 4096 CPUs. IMO it should be ((u64)node << 32) | cpu. Then getting the

[PATCH] net: decnet: dn_nsp_in: use swap macro in dn_nsp_rx_packet

2017-10-28 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/decnet/dn_nsp_in.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff

Re: [PATCH] i2c: xgene-slimpro: Support v2

2017-10-28 Thread Andy Shevchenko
On Sat, 2017-10-28 at 14:11 +0200, Wolfram Sang wrote: > Thanks for the patch! > > On Mon, Oct 23, 2017 at 03:12:20PM -0700, Hoan Tran wrote: > > This patch supports xgene-slimpro-i2c v2 which uses the non-cachable > > memory > > as the PCC shared memory. > > > > Signed-off-by: Hoan Tran > > I

Re: can: Use common error handling code in vxcan_newlink()

2017-10-28 Thread SF Markus Elfring
> If you want to change the semantic of the result check I am curious if another source code reduction (by the deletion of “ < 0”) will become acceptable at similar places. > - this has to done consistently at all rtnl_configure_link() caller sites. Are there any more functions to consider? >

Re: can: Use common error handling code in vxcan_newlink()

2017-10-28 Thread Oliver Hartkopp
On 10/28/2017 08:33 PM, SF Markus Elfring wrote: So if you would like to change the if-statement: It will need a small adjustment for the shown transformation. I was also unsure if the proposal will work in a single update step. 1. Send a patch for vxcan.c to improve the error handling flow

Re: can: Use common error handling code in vxcan_newlink()

2017-10-28 Thread SF Markus Elfring
> So if you would like to change the if-statement: It will need a small adjustment for the shown transformation. I was also unsure if the proposal will work in a single update step. > 1. Send a patch for vxcan.c to improve the error handling flow I am going to send a second approach for this u

[PATCH] libata: fix spelling mistake: 'ambigious' -> 'ambiguous'

2017-10-28 Thread Arvind Yadav
Trivial fix to spelling mistakes in ata_parse_force_one(). Signed-off-by: Arvind Yadav --- drivers/ata/libata-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 1945a8e..b38df2db 100644 --- a/drivers/ata/libata-c

[PATCH] netcp_core: Use common error handling code in netcp_create_interface()

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 20:11:02 +0200 Add a jump target so that a specific error code assignment is stored only once at the end of this function implementation. Replace five assignments by goto statements. This issue was detected by using the Coccinelle software. Signed-off

Re: [RFC PATCH v8 7/7] PCI / PM: Add support for the PCIe WAKE# signal for OF

2017-10-28 Thread Sinan Kaya
On 10/27/2017 8:04 PM, Brian Norris wrote: >> I think you can make this code common by abstracting the IRQ number and >> have some generic code like pci-wake.c in pci directory without the of prefix >> in this file. > Why would 'pci-wake' be a good name for this? We're doing basically the > same th

[git pull] Input updates for v4.14-rc6

2017-10-28 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. You will get: - a change to gtco tablet driver tightening parsing of HID descriptors; - a new ACPI ID added to Elan driver to be able to handle

Re: psmouse_disconnect lockdep splat

2017-10-28 Thread Kirill A. Shutemov
On Tue, Oct 18, 2016 at 02:09:22PM +0200, Borislav Petkov wrote: > Adding more people to CC. > > I still see this after 4.8 is out. > > So PeterZ suggested something like this: > > --- > diff --git a/drivers/input/mouse/psmouse-base.c > b/drivers/input/mouse/psmouse-base.c > index fb4b185dea96.

Re: [PATCH] can: Use common error handling code in vxcan_newlink()

2017-10-28 Thread Oliver Hartkopp
On 10/28/2017 10:23 AM, SF Markus Elfring wrote: @@ -227,10 +227,8 @@ static int vxcan_newlink(struct net *net, struct net_device *dev,   netif_carrier_off(peer);     err = rtnl_configure_link(peer, ifmp); -    if (err < 0) { -    unregister_netdevice(peer); -    return err; -

Re: Linux 4.14-rc6 bisected regression tun devices not working anymore in openvpn

2017-10-28 Thread Cong Wang
On Sat, Oct 28, 2017 at 7:57 AM, Sander Eikelenboom wrote: > L.S., > > While testing a linux 4.14-rc6 kernel i noticed OpenVPN didn't function > anymore. > My openvpn config uses tun devices and is pretty standard. > The openvpn version is current Debian stable: openvpn 2.4.0-6+deb9u2 > > From th

Re: [RFC PATCH] clk: move of_clk_get_parent_count() declaration to

2017-10-28 Thread Masahiro Yamada
Hi Stephen, 2017-10-13 8:17 GMT+09:00 Stephen Boyd : > On 10/05, Masahiro Yamada wrote: >> The clock consumer, drivers/video/fbdev/simplefb.c, includes >> just for calling of_clk_get_parent_count(). >> This is ugly. >> >> Looking at simplefb_clocks_get(), of_clk_get_parent_count() seems >> usefu

[PATCH] ARM: dts: exynos: fix property values of LDO15/17 for ODROID-XU3/4

2017-10-28 Thread tobetter
From: Dongjin Kim Looking at the schematic, LDO15 and LDO17 are tied as a power source of a builtin network chipset. The voltage on LDO15 is corrected to 3.3V and the name of LDO17 is corrected to "vdd_ldo17". Signed-off-by: Dongjin Kim --- arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi |

[PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/renesas/ravb_main

Re: [PATCH] fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get

2017-10-28 Thread Moritz Fischer
On Fri, Oct 27, 2017 at 08:19:51PM +, Gustavo A. R. Silva wrote: > Notice that bridge = to_fpga_bridge(dev); expands to: > > bridge = container_of(dev, struct fpga_bridge, dev); > > and container_of is never null, so this null check is > unnecessary. > > Addresses-Coverity-ID: 1397912 > Repo

Re: [PATCH] nfp: Improve unlocking of a mutex in area_cache_get()

2017-10-28 Thread Jakub Kicinski
On Sat, 28 Oct 2017 17:18:56 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 28 Oct 2017 17:12:10 +0200 > > Add a jump target so that a call of the function "mutex_unlock" is stored > only once at the end of this function implementation. > Replace four calls by goto statements

Re: [PATCH v2 7/7] gpio: brcmstb: implement suspend/resume/shutdown

2017-10-28 Thread Florian Fainelli
On 10/24/2017 12:54 PM, Doug Berger wrote: > This commit corrects problems with the previous wake implementation > by implementing suspend and resume power management operations and > the driver shutdown operation. > > Wake masks are used to keep track of which GPIO should wake the > device. On

Re: [PATCH v2 6/7] gpio: brcmstb: consolidate interrupt domains

2017-10-28 Thread Florian Fainelli
On 10/24/2017 12:54 PM, Doug Berger wrote: > The GPIOLIB IRQ chip helpers were very appealing, but badly broke > the 1:1 mapping between a GPIO controller's device_node and its > interrupt domain. > > When another device-tree node references a GPIO device as its > interrupt parent, the irq_creat

Re: [PATCH v2 1/7] gpio: brcmstb: Do not use gc->pin2mask()

2017-10-28 Thread Florian Fainelli
On 10/24/2017 12:54 PM, Doug Berger wrote: > From: Linus Walleij > > The pin2mask() accessor only shuffles BIT ORDER in big endian systems, > i.e. the bitstuffing is swizzled big endian so "bit 0" is bit 7 or > bit 15 or bit 31 or so. > > The brcmstb only uses big endian BYTE ORDER which will

[PATCH 4/4] reset: remove reset_control_get(_optional)

2017-10-28 Thread Masahiro Yamada
No more users of these two. Signed-off-by: Masahiro Yamada --- include/linux/reset.h | 12 1 file changed, 12 deletions(-) diff --git a/include/linux/reset.h b/include/linux/reset.h index 53e5e78..0aa3d0d 100644 --- a/include/linux/reset.h +++ b/include/linux/reset.h @@ -343,18 +3

[PATCH 2/4] reset: remove remaining WARN_ON() in

2017-10-28 Thread Masahiro Yamada
Commit bb475230b8e5 ("reset: make optional functions really optional") gave a new meaning to _get_optional variants. The differentiation by WARN_ON() is not needed any more. We already have inconsistency about this; (devm_)reset_control_get_exclusive() has WARN_ON() check, but of_reset_control_ge

[PATCH 1/4] reset: make device_reset_optional() really optional

2017-10-28 Thread Masahiro Yamada
Commit bb475230b8e5 ("reset: make optional functions really optional") converted *_get_optional* functions, but device_reset_optional() was left behind. Convert it in the same way. Signed-off-by: Masahiro Yamada --- drivers/reset/core.c | 9 + include/linux/reset.h | 28 +

[PATCH 3/4] reset: minimize the number of headers included from

2017-10-28 Thread Masahiro Yamada
Commit 62e24c5775ec ("reset: add exported __reset_control_get, return NULL if optional") moved the dev->of_node reference to core.c, so does not need to know the members of struct device. Declaring device and device_node as structure is enough. is necessary for bool, true, and false. Signed-off

[PATCH] cgroup, perf_event: Fix perf cgroup hierarchy support

2017-10-28 Thread Tejun Heo
864c2357ca89 ("perf/core: Do not set cpuctx->cgrp for unscheduled cgroups") made list_update_cgroup_event() skip setting cpuctx->cgrp if no cgroup event targets %current's cgroup. This breaks perf_event's hierarchical support because events which target one of the ancestors get ignored. Fix it by

[RESEND PATCH v2 2/2] dt-bindings: power: add amlogic meson power domain bindings

2017-10-28 Thread Neil Armstrong
Acked-by: Rob Herring Signed-off-by: Neil Armstrong --- .../bindings/power/amlogic,meson-gx-pwrc.txt | 61 ++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/amlogic,meson-gx-pwrc.txt diff --git a/Documentation/devicetree/b

[RESEND PATCH v2 1/2] soc: amlogic: add Meson GX VPU Domains driver

2017-10-28 Thread Neil Armstrong
The Video Processing Unit needs a specific Power Domain powering scheme this driver handles this as a PM Power Domain driver. Signed-off-by: Neil Armstrong --- drivers/soc/amlogic/Kconfig | 10 ++ drivers/soc/amlogic/Makefile| 1 + drivers/soc/amlogic/meson-gx-pwrc-vpu

[RESEND PATCH v2 0/2] soc: amlogic: add support for Meson GX VPU Domains

2017-10-28 Thread Neil Armstrong
[Resent with *correct* linux-pm in CC] On the Amlogic Gx SoCs (GXBB, GXL & GXM), the VPU power domain is initialized by the vendor U-Boot code, but running mainline U-boot has been possible on these SoCs. But lacking such init made the system lock at kernel boot. This patchset adds the Video Proc

[RESEND PATCH v2 1/2] soc: amlogic: add Meson GX VPU Domains driver

2017-10-28 Thread Neil Armstrong
The Video Processing Unit needs a specific Power Domain powering scheme this driver handles this as a PM Power Domain driver. Signed-off-by: Neil Armstrong --- drivers/soc/amlogic/Kconfig | 10 ++ drivers/soc/amlogic/Makefile| 1 + drivers/soc/amlogic/meson-gx-pwrc-vpu

[RESEND PATCH v2 0/2] soc: amlogic: add support for Meson GX VPU Domains

2017-10-28 Thread Neil Armstrong
[Resent with linux-pm in CC] On the Amlogic Gx SoCs (GXBB, GXL & GXM), the VPU power domain is initialized by the vendor U-Boot code, but running mainline U-boot has been possible on these SoCs. But lacking such init made the system lock at kernel boot. This patchset adds the Video Processing Uni

[RESEND PATCH v2 2/2] dt-bindings: power: add amlogic meson power domain bindings

2017-10-28 Thread Neil Armstrong
Acked-by: Rob Herring Signed-off-by: Neil Armstrong --- .../bindings/power/amlogic,meson-gx-pwrc.txt | 61 ++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/amlogic,meson-gx-pwrc.txt diff --git a/Documentation/devicetree/b

[PATCH] forcedeth: Use common error handling code in two functions

2017-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 28 Oct 2017 18:15:44 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/nvidia/forcedet

Re: [v9,4/5] watchdog: Add RAVE SP watchdog driver

2017-10-28 Thread Guenter Roeck
On Wed, Oct 25, 2017 at 12:04:20PM -0700, Andrey Smirnov wrote: > This driver provides access to RAVE SP watchdog functionality. > > Cc: linux-kernel@vger.kernel.org > Cc: linux-watch...@vger.kernel.org > Cc: cphe...@gmail.com > Cc: Lucas Stach > Cc: Nikita Yushchenko > Cc: Lee Jones > Cc: Greg

Re: [f2fs-dev] [PATCH v2] f2fs: update dirty status for CURSEG as well

2017-10-28 Thread Yunlong Song
Hi Chao, Thanks for your work. I send a v2 patch, which changes refresh_sit_entry to static. On 2017/10/28 20:02, Chao Yu wrote: Hi Yunlong, I think you're so busy, I just help to refactor your patch, and send it out authored with you, please check that patch, if you have different opinio

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-10-28 Thread Stefan Wahren
Hi Doug, [add Felipe since this should go through his tree] i'm back from vacation and happy to see this patch. > Douglas Anderson hat am 26. Oktober 2017 um 22:22 > geschrieben: > > > On rk3288-veyron devices on Chrome OS it was found that plugging in an > Arduino-based USB device could cau

[PATCH v2] This reverts commit 5e443818fa0b2a2845561ee25bec181424fb2889

2017-10-28 Thread Yunlong Song
The commit should be reverted because call sequence of below two parts of code must be kept: a. update sit information, it needs to be updated before segment allocation since latter allocation may trigger SSR, and SSR allocation needs latest valid block information of all segments. b. update segmen

Re: [v2] hwmon: (pmbus/core): Prevent unintentional setting of page to 0xFF

2017-10-28 Thread Guenter Roeck
On Fri, Oct 27, 2017 at 11:55:05AM -0500, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > The pmbus core may call read/write word data functions with a page value > of -1, intending to perform the operation without setting the page. > However, the read/write word data functions ac

  1   2   >