Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label_init()

2017-10-24 Thread Juergen Gross
On 25/10/17 06:26, Dou Liyang wrote: > Hi Juergen, > > At 10/23/2017 09:49 PM, Juergen Gross wrote: >> Don't try to set the static virt_spin_lock_key to a value before >> jump_label_init() has been called, as this will result in a WARN(). >> >> Solve the problem by introducing a new lock_init() ho

Re: [PATCH] Audit: remove unused audit_log_secctx function

2017-10-24 Thread James Morris
On Tue, 24 Oct 2017, Casey Schaufler wrote: > The function audit_log_secctx() is unused in the upstream kernel. > All it does is wrap another function that doesn't need wrapping. > It claims to give you the SELinux context, but that is not true if > you are using a different security module. > >

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

2017-10-24 Thread Greg KH
On Wed, Oct 25, 2017 at 02:30:56PM +0800, Chen Feng wrote: > Hi Ted, > > On 2017/10/24 18:25, Theodore Ts'o wrote: > > On Tue, Oct 24, 2017 at 11:09:27AM +0200, Greg KH wrote: > >> On Tue, Oct 24, 2017 at 03:44:17PM +0800, Chen Feng wrote: > >>> [pid:11940,cpu6,syz-executor][flp_ioctl]cmd[0x1] > >

[PATCH v6 1/1] pwm: mediatek: add MT2712/MT7622 support

2017-10-24 Thread Zhi Mao
Add support to MT2712 and MT7622. Due to register offset address of pwm7 for MT2712 is not fixed 0x40, add mtk_pwm_reg_offset array for pwm register offset. Add NULL pointer checking for "data", and remove "struct mtk_pwm_platform_data" member from "mtk_pwm_chip". Signed-off-by: Zhi Mao --- dri

Re: [PATCH] Hugetlb pages rss accounting is incorrect in /proc//smaps

2017-10-24 Thread Michal Hocko
[CCing Naoya] On Tue 24-10-17 16:56:08, Prakash Sangappa wrote: > Resident set size(Rss) accounting of hugetlb pages is not done > currently in /proc//smaps. The pmap command reads rss from > this file and so it shows Rss to be 0 in pmap -x output for > hugetlb mapped vmas. This patch fixes it. W

Re: [PATCH] fs, mm: account filp and names caches to kmemcg

2017-10-24 Thread Greg Thelen
Michal Hocko wrote: > On Tue 24-10-17 14:58:54, Johannes Weiner wrote: >> On Tue, Oct 24, 2017 at 07:55:58PM +0200, Michal Hocko wrote: >> > On Tue 24-10-17 13:23:30, Johannes Weiner wrote: >> > > On Tue, Oct 24, 2017 at 06:22:13PM +0200, Michal Hocko wrote: >> > [...] >> > > > What would prevent

Re: [PATCH 4.4 00/27] 4.4.95-stable review

2017-10-24 Thread Greg Kroah-Hartman
On Tue, Oct 24, 2017 at 12:01:29PM -0700, kernelci.org bot wrote: > stable-rc/linux-4.4.y boot: 43 boots: 1 failed, 42 passed > (v4.4.94-28-ga2b7c8b78a72) > > Full Boot Summary: > https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.94-28-ga2b7c8b78a72/ > Full Build Summary

Re: [PATCH 4.13 00/85] 4.13.10-stable review

2017-10-24 Thread Greg Kroah-Hartman
On Tue, Oct 24, 2017 at 02:28:57PM -0700, Guenter Roeck wrote: > On Tue, Oct 24, 2017 at 03:06:34PM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.13.10 release. > > There are 85 patches in this series, all will be posted as a response > > to this one.

[PATCH v3 1/1] xen/time: do not decrease steal time after live migration on xen

2017-10-24 Thread Dongli Zhang
After guest live migration on xen, steal time in /proc/stat (cpustat[CPUTIME_STEAL]) might decrease because steal returned by xen_steal_lock() might be less than this_rq()->prev_steal_time which is derived from previous return value of xen_steal_clock(). For instance, steal time of each vcpu is 33

Re: drm/rcar-du: Adjust 14 checks for null pointers

2017-10-24 Thread SF Markus Elfring
>> The script “checkpatch.pl” pointed information out like the following. >> >> Comparison to NULL could be written !… >> >> Thus fix the affected source code places. >> > > This one is fine This kind of feedback is nice. > except for the commit message. Would you like to support Unicode chara

Re: Clarification for approaches around exception handling

2017-10-24 Thread SF Markus Elfring
> But anyways I guess other people sometimes disagree with me. Am I one of them? ;-) > Unwinding is for when you allocate five things in a row. This is a general issue. I find that it is also needed in this function as usual. > You have to undo four if the last allocation fails. Concrete

6ee98ffeea ("x86/ftrace: Make sure that ftrace trampolines are not RWX"): BUG: kernel reboot-without-warning in test stage

2017-10-24 Thread Fengguang Wu
Hi Thomas, FYI this commit turns a warning into kernel crash: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 6ee98ffeea0bc9e072e419497d78697d8afcdd6d Author: Thomas Gleixner AuthorDate: Thu May 25 10:57:51 2017 +0200 Commit: Steven Rostedt (VMware) Com

Re: [PATCH v4 6/7] workqueue: Remove unnecessary acquisitions wrt workqueue flush

2017-10-24 Thread Ingo Molnar
* Byungchul Park wrote: > The workqueue added manual acquisitions to catch deadlock cases. > Now crossrelease was introduced, some of those are redundant, since > wait_for_completion() already includes the acquisition for itself. > Removed it. > > Signed-off-by: Byungchul Park > --- > include

Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

2017-10-24 Thread Jonathan Woithe
On Wed, Oct 25, 2017 at 06:29:46AM +0200, Micha?? K??pie?? wrote: > Radio LED detection method implemented in commit 4f62568c1fcf > ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it > causes a radio LED to be erroneously detected on a Fujitsu Lifebook E751 > which has a slide s

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

2017-10-24 Thread Chen Feng
Hi Ted, On 2017/10/24 18:25, Theodore Ts'o wrote: > On Tue, Oct 24, 2017 at 11:09:27AM +0200, Greg KH wrote: >> On Tue, Oct 24, 2017 at 03:44:17PM +0800, Chen Feng wrote: >>> [pid:11940,cpu6,syz-executor][flp_ioctl]cmd[0x1] >>> Restart is not permit >>>

Re: [PATCH v4 7/7] block: Assign a lock_class per gendisk used for wait_for_completion()

2017-10-24 Thread Byungchul Park
On Wed, Oct 25, 2017 at 08:01:24AM +0200, Ingo Molnar wrote: > Beyond the #ifdef reduction I mentioned in the other thread, there's four > other > things I noticed that need to be fixed in this patch: > > - Please write out 'minor' instead of the 'm' abbreviation that is > meaningless. >'

Re: [PATCH 1/2] f2fs: add missing quota_initialize in f2fs_set_acl

2017-10-24 Thread Jaegeuk Kim
On 10/25, Chao Yu wrote: > On 2017/10/25 13:44, Jaegeuk Kim wrote: > > On 10/24, Chao Yu wrote: > >> On 2017/10/24 6:14, Jaegeuk Kim wrote: > >>> This patch adds to call quota_intialize in f2fs_set_acl. > >>> > >>> Signed-off-by: Jaegeuk Kim > >>> --- > >>> fs/f2fs/acl.c | 4 > >>> 1 file ch

[PATCH v2] Make a log in dmesg when file creation fails due to no free inodes

2017-10-24 Thread Gazala Muhamed
The error code for both "out of disk space" and "out of inodes" is the same This is misleading to the user. Logging the exact reason helps to find and debug the issue from the user's side. Fix bug 197335 - https://bugzilla.kernel.org/show_bug.cgi?id=197335 Signed-off-by: Gazala Muhamed --- Chang

[PATCH] staging: wlan-ng: resolve sparse endianness error.

2017-10-24 Thread Matthew Giassa
Adding le16_to_cpu conversion in prism2sta.c, to resolve outstanding sparse errors as noted in the current TODO in staging-next. Original error: CHECK drivers/staging//wlan-ng/prism2usb.c drivers/staging//wlan-ng/prism2sta.c:1450:29: warning: incorrect type in assignment (different base types

Re: hwmon/amc6821: Use common error handling code in amc6821_init_client()

2017-10-24 Thread SF Markus Elfring
> Nack; I am not a friend of that much verboseness to start with, > and I don't think the patch improves readability. * Do you care to avoid code duplication for two error messages in this use case? * How do you think about to return a single error code directly without using an intermediate va

Re: [PATCH 2/2] drm/rcar-du: Adjust 14 checks for null pointers

2017-10-24 Thread Dan Carpenter
On Tue, Oct 24, 2017 at 06:02:30PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 24 Oct 2017 17:47:37 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script “checkpatch.pl” pointed information out like the followi

Re: [PATCH v4 7/7] block: Assign a lock_class per gendisk used for wait_for_completion()

2017-10-24 Thread Ingo Molnar
* Byungchul Park wrote: > Darrick posted the following warning and Dave Chinner analyzed it: > > > == > > WARNING: possible circular locking dependency detected > > 4.14.0-rc1-fixes #1 Tainted: GW > > --

Re: [PATCH 1/2] drm/rcar-du: Use common error handling code in rcar_du_encoders_init()

2017-10-24 Thread Dan Carpenter
This is a subtle thing but my preference on this type of thing is the way the original code is written. I'm still slightly annoyed that someone once made me rewrite a patch using the new style... But anyways I guess other people sometimes disagree with me. Unwinding is for when you allocate five

Re: [PATCH 1/2] f2fs: add missing quota_initialize in f2fs_set_acl

2017-10-24 Thread Chao Yu
On 2017/10/25 13:44, Jaegeuk Kim wrote: > On 10/24, Chao Yu wrote: >> On 2017/10/24 6:14, Jaegeuk Kim wrote: >>> This patch adds to call quota_intialize in f2fs_set_acl. >>> >>> Signed-off-by: Jaegeuk Kim >>> --- >>> fs/f2fs/acl.c | 4 >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a

Re: [PATCH v3 8/8] block: Assign a lock_class per gendisk used for wait_for_completion()

2017-10-24 Thread Ingo Molnar
* Byungchul Park wrote: > > Isn't lockdep_map a zero size structure that is always defined? If yes then > > there's no need for an #ifdef. > > No, a zero size structure for lockdep_map is not provided yet. > There are two options I can do: > > 1. Add a zero size structure for lockdep_map and

Re: [PATCH v2 6/6] f2fs: give up CP_TRIMMED_FLAG if it drops discards

2017-10-24 Thread Chao Yu
On 2017/10/25 13:45, Jaegeuk Kim wrote: > On 10/24, Chao Yu wrote: >> On 2017/10/24 20:46, Jaegeuk Kim wrote: >>> On 10/24, Chao Yu wrote: Hi Jaegeuk, On 2017/10/4 9:08, Chao Yu wrote: > From: Chao Yu > > In ->umount, once we drop remained discard entries, we should not

Re: 492b95e597 ("rcuperf: Set more user-friendly defaults"): WARNING: CPU: 0 PID: 1 at arch/x86/kernel/smp.c:128 native_smp_send_reschedule

2017-10-24 Thread Fengguang Wu
Hi Paul, On Tue, Oct 24, 2017 at 06:25:13AM -0700, Paul E. McKenney wrote: On Tue, Oct 24, 2017 at 04:49:52AM +0200, Fengguang Wu wrote: Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git mast

Re: [PATCH v3 2/8] lockdep: Introduce CROSSRELEASE_STACK_TRACE and make it not unwind as default

2017-10-24 Thread Ingo Molnar
* Byungchul Park wrote: > On Tue, Oct 24, 2017 at 12:05:16PM +0200, Ingo Molnar wrote: > > > > * Byungchul Park wrote: > > > > > Johan Hovold reported a performance regression by crossrelease like: > > > > Pplease add Reported-by and Analyzed-by tags - you didn't even Cc: Johan! > > Excuse

Re: [RESEND PATCH] irq_work: Don't reinvent the wheel but use existing llist API

2017-10-24 Thread Byungchul Park
On Wed, May 31, 2017 at 04:04:17PM +0200, Frederic Weisbecker wrote: > On Tue, May 30, 2017 at 02:29:20PM +0900, Byungchul Park wrote: > > On Fri, May 12, 2017 at 09:45:35AM +0900, Byungchul Park wrote: > > > Although llist provides proper APIs, they are not used. Make them used. > > > > +to pet..

Re: [PATCH v10] vfio: platform: reset: Add Broadcom FlexRM reset module

2017-10-24 Thread Anup Patel
On Tue, Oct 3, 2017 at 10:57 AM, Anup Patel wrote: > This patch adds Broadcom FlexRM low-level reset for > VFIO platform. > > It will do the following: > 1. Disable/Deactivate each FlexRM ring > 2. Flush each FlexRM ring > > The cleanup sequence for FlexRM rings is adapted from > Broadcom FlexRM m

Re: [PATCH v2 6/6] f2fs: give up CP_TRIMMED_FLAG if it drops discards

2017-10-24 Thread Jaegeuk Kim
On 10/24, Chao Yu wrote: > On 2017/10/24 20:46, Jaegeuk Kim wrote: > > On 10/24, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2017/10/4 9:08, Chao Yu wrote: > >>> From: Chao Yu > >>> > >>> In ->umount, once we drop remained discard entries, we should not > >>> set CP_TRIMMED_FLAG with another chec

Re: [PATCH 1/2] f2fs: add missing quota_initialize in f2fs_set_acl

2017-10-24 Thread Jaegeuk Kim
On 10/24, Chao Yu wrote: > On 2017/10/24 6:14, Jaegeuk Kim wrote: > > This patch adds to call quota_intialize in f2fs_set_acl. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/acl.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c > > index

Re: [PATCH 1/2 v2] f2fs: add missing quota_initialize in f2fs_set_acl

2017-10-24 Thread Jaegeuk Kim
This patch adds to call quota_intialize in f2fs_set_acl. Signed-off-by: Jaegeuk Kim --- fs/f2fs/xattr.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index 147b481c6902..8801db019892 100644 --- a/fs/f2fs/xattr.c +++ b/fs/f2fs/xattr.c @@ -686,6 +686,10

Re: [PATCH] kbuild: fix dependency of dtbs targets

2017-10-24 Thread Masahiro Yamada
Hi. 2017-10-10 0:05 GMT+09:00 Russell King - ARM Linux : > On Wed, Oct 04, 2017 at 01:27:20PM +0900, Masahiro Yamada wrote: >> The target "dtbs" should depend on "scripts" because it needs to >> build dtc. The "prepare" target is unneeded here. > > Looks fine for ARM, as the only thing the dtbs

[PATCH 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer

2017-10-24 Thread rick
ATCPIT100 is often used on the Andes architecture, This timer provide 4 PIT channels. Each PIT channel is a multi-function timer, can be configured as 32,16,8 bit timers or PWM as well. For system timer it will set 32-bit timer0 as clock source and count downwards until underflow and restart again

[PATCH 3/3] dt-bindings: timer: Add andestech atcpit100 timer binding doc

2017-10-24 Thread rick
Signed-off-by: rick Signed-off-by: rick Signed-off-by: Greentime Hu --- .../bindings/timer/andestech,atcpit100-timer.txt | 31 1 file changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/andestech,atcpit100-timer.txt diff --git a/Docu

[PATCH 2/3] clocksource/drivers/Kconfig: Support andestech atcpit100

2017-10-24 Thread rick
Signed-off-by: rick Signed-off-by: rick Signed-off-by: Greentime Hu --- drivers/clocksource/Kconfig |6 ++ drivers/clocksource/Makefile |1 + 2 files changed, 7 insertions(+) diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig index cc60620..e950066 100644 --- a

Re: [PATCH] drivers/wireless: iwlwifi/mvm: Convert timers to use timer_setup()

2017-10-24 Thread Luca Coelho
On Tue, 2017-10-24 at 02:29 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > The RCU lifetime on baid_data is unclear,

Re: [PATCH 1/3] driver: mailbox: add support for Hi3660

2017-10-24 Thread Leo Yan
Hi Jassi, On Wed, Oct 25, 2017 at 09:47:34AM +0530, Jassi Brar wrote: > On Mon, Aug 7, 2017 at 2:47 PM, Zhong Kaihua wrote: > > From: Kaihua Zhong > > > > Add mailbox driver for Hi3660. > > > > Signed-off-by: Leo Yan > > Signed-off-by: Ruyi Wang > > Tested-by: Kaihua Zhong > > > > --- > > dr

[PATCH v4 5/7] completion: Add support for initializing completion with lockdep_map

2017-10-24 Thread Byungchul Park
Sometimes, we want to initialize completions with sparate lockdep maps to assign lock classes as desired. For example, the workqueue code needs to directly manage lockdep maps, since only the code is aware of how to classify lockdep maps properly. Provide additional macros initializing completions

[PATCH v4 1/7] block: use DECLARE_COMPLETION_ONSTACK in submit_bio_wait

2017-10-24 Thread Byungchul Park
From: Christoph Hellwig Simplify the code by getting rid of the submit_bio_ret structure. Signed-off-by: Christoph Hellwig --- block/bio.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/block/bio.c b/block/bio.c index 5f5472e..99d0ca5 100644 --- a/bloc

[PATCH v4 7/7] block: Assign a lock_class per gendisk used for wait_for_completion()

2017-10-24 Thread Byungchul Park
Darrick posted the following warning and Dave Chinner analyzed it: > == > WARNING: possible circular locking dependency detected > 4.14.0-rc1-fixes #1 Tainted: GW > -- > loop0/31693 is t

[PATCH v4 2/7] locking/lockdep: Add a boot parameter allowing unwind in cross-release and disable it by default

2017-10-24 Thread Byungchul Park
Johan Hovold reported a heavy performance regression caused by lockdep cross-release: > Boot time (from "Linux version" to login prompt) had in fact doubled > since 4.13 where it took 17 seconds (with my current config) compared to > the 35 seconds I now see with 4.14-rc4. > > I quick bisect

[PATCH v4 6/7] workqueue: Remove unnecessary acquisitions wrt workqueue flush

2017-10-24 Thread Byungchul Park
The workqueue added manual acquisitions to catch deadlock cases. Now crossrelease was introduced, some of those are redundant, since wait_for_completion() already includes the acquisition for itself. Removed it. Signed-off-by: Byungchul Park --- include/linux/workqueue.h | 4 ++-- kernel/workqu

[PATCH v4 4/7] locking/lockdep: Introduce CONFIG_BOOTPARAM_LOCKDEP_CROSSRELEASE_FULLSTACK

2017-10-24 Thread Byungchul Park
The boot parameter, crossrelease_fullstack, was introduced to control whether to enable unwind in cross-release or not. Add a Kconfig doing the same thing. Suggested-by: Ingo Molnar Signed-off-by: Byungchul Park --- kernel/locking/lockdep.c | 4 lib/Kconfig.debug| 15 +

[PATCH v4 0/7] cross-release: Enhence performance and fix false positives

2017-10-24 Thread Byungchul Park
There are two things I didn't apply as Ingo suggested, since I didn't understand his intention exactly: 1. Adding 'Analyzed-by' tag at the 2nd patch 2. Using a inline function instead #define at the 7th patch Let me know if the above should still be applied. Changes from v3 - Exclude a pat

[PATCH v4 3/7] locking/lockdep: Remove the BROKEN flag from CONFIG_LOCKDEP_CROSSRELEASE and CONFIG_LOCKDEP_COMPLETIONS

2017-10-24 Thread Byungchul Park
Now that the performance regression is fixed, re-enable CONFIG_LOCKDEP_CROSSRELEASE=y and CONFIG_LOCKDEP_COMPLETIONS=y. Signed-off-by: Byungchul Park --- lib/Kconfig.debug | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 3db9167.

[PATCH 1/2] gpio: gpiolib: Expand sleep tolerance to include controller reset

2017-10-24 Thread Andrew Jeffery
Reset tolerance is added to gpiolib with the introduction of a new pinconf parameter propagating the request to hardware. The existing persistence support for sleep is augmented to include reset tolerance if the GPIO driver provides it. Persistence continues to be enabled by default; in-kernel cons

[PATCH 2/2] gpio: aspeed: Add support for reset tolerance

2017-10-24 Thread Andrew Jeffery
Use the new pinconf parameter for reset tolerance to expose the associated capability of the Aspeed GPIO controller. Signed-off-by: Andrew Jeffery --- drivers/gpio/gpio-aspeed.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/g

[PATCH 0/2] gpio: Expose reset tolerance capability

2017-10-24 Thread Andrew Jeffery
Hello, This short series enables GPIO state persistence across controller resets, modifying gpiolib to expose control of the behaviour and providing an initial implementation in the Aspeed GPIO controller. This is a follow-up to the initial RFC series[1], which had some undesirable features (and

Re: Kernel error messages: leds fujitsu::radio_led: Setting an LED's brightness failed

2017-10-24 Thread Michał Kępień
> > - Investigating the E LED. This requires taking a look at the DSDT > > dump from your laptop and searching for clues as to how this LED is > > handled. I will be happy to do that, but again, no promises about > > how much time it will take. (And given the nature of this task, I

Re: [PATCH v7 2/2] crypto: s5p-sss: Add HASH support for Exynos

2017-10-24 Thread Vladimir Zapolskiy
Hi Kamil, I'll just answer to your question, all the comments from you are accepted, please send a new version with the minor fixes, hopefully the change will be included into v4.15-rc. On 10/24/2017 02:27 PM, Kamil Konieczny wrote: > Hi Vladimir, > > Thank you for review, I will apply almost al

[PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection

2017-10-24 Thread Michał Kępień
Radio LED detection method implemented in commit 4f62568c1fcf ("fujitsu-laptop: Support radio LED") turned out to be incorrect as it causes a radio LED to be erroneously detected on a Fujitsu Lifebook E751 which has a slide switch (and thus no radio LED). Use bit 17 of flags_supported (the value r

Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label_init()

2017-10-24 Thread Dou Liyang
Hi Juergen, At 10/23/2017 09:49 PM, Juergen Gross wrote: Don't try to set the static virt_spin_lock_key to a value before jump_label_init() has been called, as this will result in a WARN(). Solve the problem by introducing a new lock_init() hook called after jump_label_init() instead of doing t

Re: [PATCH] drivers/net: wan/sbni: Convert timers to use timer_setup()

2017-10-24 Thread David Miller
From: Kees Cook Date: Tue, 24 Oct 2017 01:47:00 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: David Howells > Cc: net...@vger.kerne

Re: [PATCH v7 1/2] crypto: s5p-sss: change spaces into tabs in defines

2017-10-24 Thread Vladimir Zapolskiy
Hi Kamil, On 10/24/2017 01:19 PM, Kamil Konieczny wrote: > Hi Vladimir, > > Thank you for review. > > On 22.10.2017 12:18, Vladimir Zapolskiy wrote: >> Hi Kamil, >> >> On 10/17/2017 02:28 PM, Kamil Konieczny wrote: >>> change spaces into tabs in defines >> >> Here a grammatically correct sentenc

Re: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG

2017-10-24 Thread David Miller
From: Herbert Xu Date: Wed, 25 Oct 2017 12:05:41 +0800 > On Tue, Oct 24, 2017 at 05:48:42PM +0900, David Miller wrote: >> >> This discussion has happened before. >> >> But I'll explain the conclusion here for your benefit. >> >> BUG_ON() is a statement and everything inside of it will >> alway

Re: [PATCH] drivers/net: sis: Convert timers to use timer_setup()

2017-10-24 Thread David Miller
From: Kees Cook Date: Tue, 24 Oct 2017 01:46:52 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Francois Romieu > Cc: Daniele Venzano

Re: [PATCH 1/3] driver: mailbox: add support for Hi3660

2017-10-24 Thread Jassi Brar
On Mon, Aug 7, 2017 at 2:47 PM, Zhong Kaihua wrote: > From: Kaihua Zhong > > Add mailbox driver for Hi3660. > > Signed-off-by: Leo Yan > Signed-off-by: Ruyi Wang > Tested-by: Kaihua Zhong > > --- > drivers/mailbox/Kconfig | 6 + > drivers/mailbox/Makefile | 2 + > drivers

Re: [PATCH] net: atm/mpc: Stop using open-coded timer .data field

2017-10-24 Thread David Miller
From: Kees Cook Date: Tue, 24 Oct 2017 01:46:45 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using an explicit static variable to hold > additional expiration details. > > Cc: "David S. Miller" > Cc: Bhumika Goyal > Cc: An

Re: [PATCH] ipv6: esp6: use BUG_ON instead of if condition followed by BUG

2017-10-24 Thread Herbert Xu
On Tue, Oct 24, 2017 at 11:28:26AM -0500, Gustavo A. R. Silva wrote: > Use BUG_ON instead of if condition followed by BUG in esp_remove_trailer. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > net/ipv6/esp6.c | 3 +-- > 1 file changed, 1 i

Re: [PATCH] net: xfrm_user: use BUG_ON instead of if condition followed by BUG

2017-10-24 Thread Herbert Xu
On Tue, Oct 24, 2017 at 05:48:42PM +0900, David Miller wrote: > > This discussion has happened before. > > But I'll explain the conclusion here for your benefit. > > BUG_ON() is a statement and everything inside of it will > always execute. > > BUG_ON() is always preferred because it allows arc

Re: [PATCH] net: hsr: Convert timers to use timer_setup()

2017-10-24 Thread David Miller
From: Kees Cook Date: Tue, 24 Oct 2017 01:46:16 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Arvid Brodin > Cc: "David S. Miller"

Re: [PATCH] net: af_packet: Convert timers to use timer_setup()

2017-10-24 Thread David Miller
From: Kees Cook Date: Tue, 24 Oct 2017 01:46:26 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "David S. Miller" > Cc: Eric Dumazet

Re: [PATCH v7] printk: hash addresses printed with %p

2017-10-24 Thread Jason A. Donenfeld
On Wed, Oct 25, 2017 at 5:49 AM, Tobin C. Harding wrote: > static_branch_disable(&no_ptr_secret) : Doesn't sleep, just atomic read > and set and maybe a WARN_ONCE. Are you sure about that? I just looked myself, and though there is a !HAVE_JUMP_LABEL ifdef that does what you described, there's als

Re: [PATCH] net: dccp: Convert timers to use timer_setup()

2017-10-24 Thread David Miller
From: Kees Cook Date: Tue, 24 Oct 2017 01:46:09 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Adds a pointer back to the sock. > > Cc: Gerri

Re: [PATCH] net: ethernet/sfc: Convert timers to use timer_setup()

2017-10-24 Thread David Miller
From: Kees Cook Date: Tue, 24 Oct 2017 01:45:59 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Solarflare linux maintainers > Cc: Ed

[PATCH v3 5/6] dt-bindings: add the rockchip,dual-channel for dw-mipi-dsi

2017-10-24 Thread Nickey Yang
Configure dsi slave channel when driving a panel which needs 2 DSI links. Signed-off-by: Nickey Yang --- .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_r

[PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

2017-10-24 Thread Nickey Yang
This patch correct Feedback divider setting: 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN 2、Due to the use of a "by 2 pre-scaler," the range of the feedback multiplication Feedback divider is limited to even division numbers, and Feedback divider must be greater than 12, less than 1000. 3、Make

[PATCH v3 4/6] drm/rockchip/dsi: add dual mipi channel support

2017-10-24 Thread Nickey Yang
This patch add dual mipi channel support: 1.add definition of dsi1 register and grf operation. 2.dsi0 and dsi1 will work in master and slave mode when driving dual mipi panel. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 377 drivers/g

[PATCH v3 6/6] arm64: dts: rockchip: add mipi_dsi1 support for rk3399

2017-10-24 Thread Nickey Yang
This patch adds the mipi_dsi1 related needed information. e.g.: interrupts, grf, clocks, ports and so on. Signed-off-by: Nickey Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 39 1 file changed, 39 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3

[PATCH v3 2/6] drm/rockchip/dsi: correct phy parameter setting

2017-10-24 Thread Nickey Yang
As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0> should depend on frequency,so fix it. Reviewed-by: Sean Paul Reviewed-by: Matthias Kaehlcke Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 98 -- 1 file changed, 70 insertions(+)

[PATCH v3 1/6] drm/rockchip/dsi: Define and use macros for PHY register addresses

2017-10-24 Thread Nickey Yang
Replace the hardcoded register address numerical values with macros to clarify the code. Signed-off-by: Nickey Yang --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 129 ++--- 1 file changed, 85 insertions(+), 44 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw-mipi

Re: [PATCH v7] printk: hash addresses printed with %p

2017-10-24 Thread Tobin C. Harding
On Tue, Oct 24, 2017 at 01:25:52PM +0200, Jason A. Donenfeld wrote: > On Tue, Oct 24, 2017 at 2:31 AM, Tobin C. Harding wrote: > > On Tue, Oct 24, 2017 at 01:00:03AM +0200, Jason A. Donenfeld wrote: > >> Provided you've tested this and the static_key guard stuff actually > >> works as intended, >

[PATCH] Input: synaptics-rmi4: Limit the range of what GPIOs are buttons

2017-10-24 Thread Andrew Duggan
By convention the first 6 bits of F30 Ctrl 2 and 3 are used to signify GPIOs which are connected to buttons. Additional GPIOs may be used as input GPIOs to signal the touch controller of some event (ie disable touchpad). These additional GPIOs may meet the criteria of a button in rmi_f30_is_valid_b

Re: [PATCH] usb: usbatm: Convert timers to use timer_setup()

2017-10-24 Thread Allen
> In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Additionally corrects and on-stack > timer usage. > > Cc: Greg Kroah-Hartman > Cc: Duncan Sands > Cc:

[PATCH 0/3] Housekeeping: Rebase last 3 patches against tip:sched/core

2017-10-24 Thread Frederic Weisbecker
This is a resend of the last three patches that had a conflict against e22cdc3fc: ("sched/isolcpus: Fix "isolcpus=" boot parameter handling when !CONFIG_CPUMASK_OFFSTACK") The conflict has been resolved by moving the following check 'cpumask_last(cpu_isolated_mask) >= nr_cpus_id' to the h

[PATCH 1/3] housekeeping: Move isolcpus to housekeeping

2017-10-24 Thread Frederic Weisbecker
We want to centralize the isolation features on the housekeeping subsystem and scheduler domain isolation is a significant part of it. No intended behaviour change, we just reuse the housekeeping cpumask and core code. Signed-off-by: Frederic Weisbecker Cc: Chris Metcalf Cc: Rik van Riel Cc: P

[PATCH 3/3] housekeeping: Document isolcpus flags

2017-10-24 Thread Frederic Weisbecker
Signed-off-by: Frederic Weisbecker Cc: Chris Metcalf Cc: Rik van Riel Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Mike Galbraith Cc: Ingo Molnar Cc: Christoph Lameter Cc: Paul E. McKenney Cc: Wanpeng Li Cc: Luiz Capitulino --- Documentation/admin-guide/kernel-parameters.txt | 35

[PATCH 2/3] housekeeping: Add basic isolcpus flags

2017-10-24 Thread Frederic Weisbecker
Add flags to control nohz and domain isolations from "isolcpus=", in order to centralize the isolation features to a common interface. Domain isolation remains the default so not to break the existing isolcpus boot paramater behaviour. Further flags in the future may include 0hz (1hz tick offload)

Re: [PATCH] net: LLC: Convert timers to use timer_setup()

2017-10-24 Thread David Miller
From: Kees Cook Date: Tue, 24 Oct 2017 01:45:48 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: "David S. Miller" > Cc: Eric Dumazet

[PATCH] usb: atm: cxacru: mark expected switch fall-throughs

2017-10-24 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/atm/cxacru.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index 600a670..e4

Re: [PATCH] net: ax25: Convert timers to use timer_setup()

2017-10-24 Thread David Miller
From: Kees Cook Date: Tue, 24 Oct 2017 01:45:39 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Joerg Reuter > Cc: Ralf Baechle > Cc

Re: [PATCH] net: sctp: Convert timers to use timer_setup()

2017-10-24 Thread David Miller
From: Kees Cook Date: Tue, 24 Oct 2017 01:45:31 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Vlad Yasevich > Cc: Neil Horman > Cc

Re: [PATCH net-next v3 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-10-24 Thread Masahiro Yamada
2017-10-25 10:07 GMT+09:00 Kunihiko Hayashi : > + > +/* Descriptor Control Register Group */ > +#define AVE_DESCC 0x300 /* Descriptor Control */ > +#define AVE_TXDC 0x304 /* TX Descriptor Configuration */ > +#define AVE_RXDC0 0x308 /* RX Descriptor Ring0 Configuration */ > +#

[PATCH] usb: class: usbtmc: mark expected switch fall-through

2017-10-24 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/class/usbtmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index 6ebfabf

Re: [PATCH V3 0/6] event synthesization multithreading for perf record

2017-10-24 Thread Namhyung Kim
Hi Ingo, On Tue, Oct 24, 2017 at 03:25:23PM +0200, Ingo Molnar wrote: > > * Arnaldo Carvalho de Melo wrote: > > > Em Tue, Oct 24, 2017 at 02:59:44PM +0200, Ingo Molnar escreveu: > > > > > > * Jiri Olsa wrote: > > > > > > > I recently made some changes on threaded record, which are based > >

Re: [PATCH -mm] mm, swap: Fix false error message in __swp_swapcount()

2017-10-24 Thread Huang, Ying
Minchan Kim writes: > On Tue, Oct 24, 2017 at 10:47:00AM +0800, Huang, Ying wrote: >> From: Ying Huang >> >> __swp_swapcount() is used in __read_swap_cache_async(). Where the >> invalid swap entry (offset > max) may be supplied during swap >> readahead. But __swp_swapcount() will print error

Re: [PATCH] perf/tools : remove default system_wide in sched record

2017-10-24 Thread Namhyung Kim
On Tue, Oct 24, 2017 at 10:46:44AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 24, 2017 at 03:45:34PM +0800, Cheng Jian escreveu: > > When running perf sched record, there is a bug. > > > > It's system_wide when we specify a command line. > > Humm, isn't this because if you trace just a

[4.14rc6] suspicious nfs rcu dereference

2017-10-24 Thread Dave Jones
WARNING: suspicious RCU usage 4.14.0-rc6-think+ #2 Not tainted - net/sunrpc/clnt.c:1206 suspicious rcu_dereference_check() usage! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 2 locks held by kworker/2:0/9104: #0: ( "rpciod" ){

Re: [PATCH] xen: fix booting ballooned down hvm guest

2017-10-24 Thread Willy Tarreau
On Tue, Oct 24, 2017 at 02:59:00PM +, HW42 wrote: > I think you really should allow pseudonymous contributions. But in my > case my nickname is anyway linked to my legal name so fell free to use: > Simon Gaiser I personally always have difficulties with pseudos in emails, I think it's just a

[PATCH AUTOSEL for 4.9 05/50] xen/netback: set default upper limit of tx/rx queues to 8

2017-10-24 Thread Levin, Alexander (Sasha Levin)
From: Juergen Gross [ Upstream commit 56dd5af9bc23d0d5d23bb207c477715b4c2216c5 ] The default for the maximum number of tx/rx queues of one interface is the number of cpus of the system today. As each queue pair reserves 512 grant pages this default consumes a ridiculous number of grants for larg

[PATCH AUTOSEL for 4.9 06/50] ARM: dts: imx53-qsb-common: fix FEC pinmux config

2017-10-24 Thread Levin, Alexander (Sasha Levin)
From: Patrick Bruenn [ Upstream commit 8b649e426336d7d4800ff9c82858328f4215ba01 ] The pinmux configuration in device tree was different from manual muxing in /board/freescale/mx53loco/mx53loco.c All pins were configured as NO_PAD_CTL(1 << 31), which was fine as the bootloader already did the cor

[PATCH AUTOSEL for 4.9 07/50] dt-bindings: clockgen: Add compatible string for LS1012A

2017-10-24 Thread Levin, Alexander (Sasha Levin)
From: Harninder Rai [ Upstream commit 73447f68d7b2bc1df870da88b0e21d2bc1afc025 ] Signed-off-by: Harninder Rai Signed-off-by: Bhaskar Upadhaya Acked-by: Rob Herring Signed-off-by: Shawn Guo Signed-off-by: Sasha Levin --- Documentation/devicetree/bindings/clock/qoriq-clock.txt | 1 + 1 file

[PATCH AUTOSEL for 4.9 01/50] [media] adv7604: Initialize drive strength to default when using DT

2017-10-24 Thread Levin, Alexander (Sasha Levin)
From: Lars-Peter Clausen [ Upstream commit da8892d410db224d9a24104529794e6e37e0c100 ] The adv7604 driver platform data contains fields for configuring the drive strength of the output pins. When probing the driver through DT these fields are not explicitly initialized, which means they are left

[PATCH AUTOSEL for 4.9 13/50] iommu/arm-smmu-v3: Clear prior settings when updating STEs

2017-10-24 Thread Levin, Alexander (Sasha Levin)
From: Nate Watterson [ Upstream commit 810871c57011eb3e89e6768932757f169d666cd2 ] To prevent corruption of the stage-1 context pointer field when updating STEs, rebuild the entire containing dword instead of clearing individual fields. Signed-off-by: Nate Watterson Signed-off-by: Will Deacon

[PATCH AUTOSEL for 4.9 16/50] cxl: Force psl data-cache flush during device shutdown

2017-10-24 Thread Levin, Alexander (Sasha Levin)
From: Vaibhav Jain [ Upstream commit d7b1946c7925a270062b2e0718aa57b42ba619c0 ] This change adds a force psl data cache flush during device shutdown callback. This should reduce a possibility of psl holding a dirty cache line while the CAPP is being reinitialized, which may result in a UE [load/

[PATCH AUTOSEL for 4.9 02/50] video: fbdev: pmag-ba-fb: Remove bad `__init' annotation

2017-10-24 Thread Levin, Alexander (Sasha Levin)
From: "Maciej W. Rozycki" [ Upstream commit 879e5a0df626f39cbb3c61bb90373e56d67012c4 ] Fix: WARNING: drivers/video/fbdev/pmag-ba-fb.o(.text+0x308): Section mismatch in reference from the function pmagbafb_probe() to the function .init.text:pmagbafb_erase_cursor() The function pmagbafb_probe()

[PATCH AUTOSEL for 4.9 23/50] iio: magnetometer: mag3110: claim direct mode during raw writes

2017-10-24 Thread Levin, Alexander (Sasha Levin)
From: Alison Schofield [ Upstream commit 80dea21f95a4672cce545f48dc2ca500b69a2584 ] Driver was checking for direct mode but not locking it. Use claim/release helper functions to guarantee the device stays in direct mode during raw writes. Signed-off-by: Alison Schofield Acked-by: Peter Meerwa

[PATCH AUTOSEL for 4.9 10/50] clk: samsung: exynos5433: Add IDs for PHYCLK_MIPIDPHY0_* clocks

2017-10-24 Thread Levin, Alexander (Sasha Levin)
From: Marek Szyprowski [ Upstream commit 5ccb58968bf7f46dbd128df88f71838a5a9750b8 ] Add missing identifiers for phyclk_mipidphy0_bitclkdiv8_phy and phyclk_mipidphy0_rxclkesc0_phy clocks. Access to those clocks is needed to setup initial clock configuration for display subsystem in device tree in

  1   2   3   4   5   6   7   8   9   10   >