[tip:x86/timers 8/11] WARNING: vmlinux.o(.text+0x4223a): Section mismatch in reference from the function uv_tsc_check_sync() to the function .init.text:uv_early_read_mmr()

2017-10-20 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/timers head: d240e4b79fedad1346796b045286fad5ca70ada9 commit: 97d21003df3e7504c899b1701546f18ff475966f [8/11] x86/platform/UV: Add check of TSC state set by UV BIOS config: x86_64-randconfig-b0-10211156 (attached as .config)

[PATCH] stmmac: Don't access tx_q->dirty_tx before netif_tx_lock

2017-10-20 Thread Bernd Edlinger
This is the possible reason for different hard to reproduce problems on my ARMv7-SMP test system. The symptoms are in recent kernels imprecise external aborts, and in older kernels various kinds of network stalls and unexpected page allocation failures. My testing indicates that the trouble start

[PATCH] drivers/x86: add thinkpad-wmi

2017-10-20 Thread Corentin Chary
This driver has been available on https://github.com/iksaif/thinkpad-wmi for a few year and is already deployed on large fleets of thinkpad laptops. The WMI interface is documented here: http://download.lenovo.com/ibmdl/pub/pc/pccbbs/thinkcentre_pdf/hrdeploy_en.pdf It mostly focused on changing B

Re: [PATCH] lkdtm: Convert from jprobe to kprobe

2017-10-20 Thread Masami Hiramatsu
On Fri, 20 Oct 2017 06:31:27 -0700 Kees Cook wrote: > The jprobe subsystem is being removed, so convert to using kprobe instead. > Looks good to me:) Acked-by: Masami Hiramatsu Thanks, > Cc: Masami Hiramatsu > Signed-off-by: Kees Cook > --- > drivers/misc/lkdtm_core.c | 154 > ++

Re: [PATCH 1/2] mm/mmu_notifier: avoid double notification when it is useless v2

2017-10-20 Thread Balbir Singh
On Thu, 2017-10-19 at 12:58 -0400, Jerome Glisse wrote: > On Thu, Oct 19, 2017 at 09:53:11PM +1100, Balbir Singh wrote: > > On Thu, Oct 19, 2017 at 2:28 PM, Jerome Glisse wrote: > > > On Thu, Oct 19, 2017 at 02:04:26PM +1100, Balbir Singh wrote: > > > > On Mon, 16 Oct 2017 23:10:02 -0400 > > > > j

Re: [PATCH 12/27] x86/msr: Restrict MSR access when the kernel is locked down

2017-10-20 Thread joeyli
On Fri, Oct 20, 2017 at 09:48:16PM +0100, David Howells wrote: > Alan Cox wrote: > > > There are a load of standard tools that use this so I think you are going > > to need a whitelist. Can you at least log *which* MSR in the failing case > > so a whitelist can be built over time ? > [...snip] >

Re: [PATCH v3 02/13] dax: require 'struct page' for filesystem dax

2017-10-20 Thread Dan Williams
On Fri, Oct 20, 2017 at 8:20 PM, Matthew Wilcox wrote: > On Fri, Oct 20, 2017 at 03:29:57PM -0700, Dan Williams wrote: >> Ok, I'd also like to kill DAX support in the brd driver. It's a source >> of complexity and maintenance burden for zero benefit. It's the only >> ->direct_access() implementati

[PATCH] net: can: dev: remove unused code in can_restart

2017-10-20 Thread Gustavo A. R. Silva
Value assigned to variable err is overwritten at line 562: err = priv->do_set_mode(dev, CAN_MODE_START); before it can be used. Also, notice that this code has been there since 2014. Addresses-Coverity-ID: 1227031 Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only.

Re: [PATCH v3 02/13] dax: require 'struct page' for filesystem dax

2017-10-20 Thread Matthew Wilcox
On Fri, Oct 20, 2017 at 03:29:57PM -0700, Dan Williams wrote: > Ok, I'd also like to kill DAX support in the brd driver. It's a source > of complexity and maintenance burden for zero benefit. It's the only > ->direct_access() implementation that sleeps and it's the only > implementation where there

Re: [PATCH mmotm] lib/bug.c: fix build when MODULES are not enabled

2017-10-20 Thread Andi Kleen
On Fri, Oct 20, 2017 at 04:53:50PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build when CONFIG_MODULES is not enabled. > Fixes multiple build errors. Thanks. I already sent a patch earlier. -Andi > > Signed-off-by: Randy Dunlap > Reported-by: kbuild test robot > Cc: Andi Kleen

Re: [PATCH 00/23] Hardened usercopy whitelisting

2017-10-20 Thread Kees Cook
On Fri, Oct 20, 2017 at 4:25 PM, Paolo Bonzini wrote: > On 21/10/2017 00:40, Paolo Bonzini wrote: >> This breaks KVM completely on x86, due to two ioctls >> (KVM_GET/SET_CPUID2) accessing the cpuid_entries field of struct >> kvm_vcpu_arch. >> >> There's also another broken ioctl, KVM_XEN_HVM_CONFI

[PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-20 Thread Dongjiu Geng
For the SEA notification, the two functions ghes_sea_add() and ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA is defined. If not, it will return errors in the ghes_probe() and not continue. If the probe is failed, the ghes_sea_remove() also has no chance to be called. Hence, remove the

Re: [PATCH 2/3] watchdog: hpwdt: SMBIOS check

2017-10-20 Thread Guenter Roeck
On 10/20/2017 03:54 PM, Jerry Hoemann wrote: Correct test on SMBIOS table 219 Misc Features bits for UEFI supported. Please explain in more detail. There is no table 219 in the SMBIOS specification. There is table 9, BIOS Characteristics Extension Byte 2, which specifies bit 3 as "UEFI Specifi

Re: [PATCH 1/3] watchdog: hpwdt: add ioctl WDIOC_GETPRETIMEOUT

2017-10-20 Thread Guenter Roeck
On 10/20/2017 03:54 PM, Jerry Hoemann wrote: Add support for WDIOC_GETPRETIMEOUT ioctl so that user applications can determine when the NMI should arrive. Signed-off-by: Jerry Hoemann --- drivers/watchdog/hpwdt.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/watchdog/hpw

Re: [RESEND PATCH 1/3] completion: Add support for initializing completion with lockdep_map

2017-10-20 Thread Byungchul Park
On Sat, Oct 21, 2017 at 4:58 AM, Bart Van Assche wrote: > Sorry but I'm not sure that's the best possible answer. In my opinion > avoiding that completion objects have dependencies on other lock objects, > e.g. by avoiding to wait on a completion object while holding a mutex, is a > far superior s

Re: [PATCH] [v2] tomoyo: fix timestamping for y2038

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, Arnd Bergmann wrote: > Tomoyo uses an open-coded version of time_to_tm() to create a timestamp > from the current time as read by get_seconds(). This will overflow and > give wrong results on 32-bit systems in 2038. > > To correct this, this changes the code to use ktime_get_

Re: [PATCH 26/27] efi: Add an EFI_SECURE_BOOT flag to indicate secure boot mode

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, David Howells wrote: > + if (efi_enabled(EFI_BOOT)) { > + switch (mode) { > + case efi_secureboot_mode_disabled: > + pr_info("Secure boot disabled\n"); > + break; > + case efi_secureboot_mode_enabl

Re: [PATCH 25/27] Lock down /proc/kcore

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, David Howells wrote: > Disallow access to /proc/kcore when the kernel is locked down to prevent > access to cryptographic data. > > Signed-off-by: David Howells Reviewed-by: James Morris I have to wonder, though, after everything is locked down, how easy will it be for n

[PATCH v6] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-20 Thread Dongjiu Geng
For the SEA notification, the two functions ghes_sea_add() and ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA is defined. If not, it will return errors in the ghes_probe() and not continue. If the probe is failed, the ghes_sea_remove() also has no chance to be called. Hence, remove the

Re: [PATCH 1/4] mm/zsmalloc: Prepare to variable MAX_PHYSMEM_BITS

2017-10-20 Thread Nitin Gupta
On Fri, Oct 20, 2017 at 12:59 PM, Kirill A. Shutemov wrote: > With boot-time switching between paging mode we will have variable > MAX_PHYSMEM_BITS. > > Let's use the maximum variable possible for CONFIG_X86_5LEVEL=y > configuration to define zsmalloc data structures. > > The patch introduces MAX_

Re: [PATCH net] hv_sock: add locking in the open/close/release code paths

2017-10-20 Thread David Miller
From: Dexuan Cui Date: Thu, 19 Oct 2017 03:33:14 + > > Without the patch, when hvs_open_connection() hasn't completely established > a connection (e.g. it has changed sk->sk_state to SS_CONNECTED, but hasn't > inserted the sock into the connected queue), vsock_stream_connect() may see > the

[PATCH v1] mm: broken deferred calculation

2017-10-20 Thread Pavel Tatashin
In reset_deferred_meminit we determine number of pages that must not be deferred. We initialize pages for at least 2G of memory, but also pages for reserved memory in this node. The reserved memory is determined in this function: memblock_reserved_memory_within(), which operates over physical addr

Re: [PATCH 0/12] PM / sleep: Driver flags for system suspend/resume

2017-10-20 Thread Rafael J. Wysocki
On Friday, October 20, 2017 10:46:07 PM CEST Bjorn Helgaas wrote: > On Mon, Oct 16, 2017 at 03:12:35AM +0200, Rafael J. Wysocki wrote: > > Hi All, > > > > Well, this took more time than expected, as I tried to cover everything I > > had > > in mind regarding PM flags for drivers. > > For the par

Re: swap_info_get: Bad swap offset entry 0200f8a7

2017-10-20 Thread Christian Kujau
On Fri, 20 Oct 2017, huang ying wrote: > > 4 May < Linux version 4.11.2-1-ARCH > > 4 Jun < Linux version 4.11.3-1-ARCH > > 7 Jul < Linux version 4.11.9-1-ARCH > > 4 Aug < Linux version 4.12.8-2-ARCH > > 24 Sep < Linux version 4.12.13-1-ARCH > > 158 Oct < Linux

[PATCH v2 2/4] android: binder: Fix null ptr dereference in debug msg

2017-10-20 Thread Sherry Yang
Don't access next->data in kernel debug message when the next buffer is null. Acked-by: Arve Hjønnevåg Signed-off-by: Sherry Yang --- drivers/android/binder_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.

[PATCH v2 3/4] android: binder: Remove unused vma argument

2017-10-20 Thread Sherry Yang
The vma argument in update_page_range is no longer used after 74310e06 ("android: binder: Move buffer out of area shared with user space"), since mmap_handler no longer calls update_page_range with a vma. Acked-by: Arve Hjønnevåg Signed-off-by: Sherry Yang --- drivers/android/binder_alloc.c | 1

[PATCH v2 1/4] android: binder: Don't get mm from task

2017-10-20 Thread Sherry Yang
Use binder_alloc struct's mm_struct rather than getting a reference to the mm struct through get_task_mm to avoid a potential deadlock between lru lock, task lock and dentry lock, since a thread can be holding the task lock and the dentry lock while trying to acquire the lru lock. Acked-by: Arve H

[PATCH v2 4/4] android: binder: Change binder_shrinker to static

2017-10-20 Thread Sherry Yang
binder_shrinker struct is not used anywhere outside of binder_alloc.c and should be static. Acked-by: Arve Hjønnevåg Signed-off-by: Sherry Yang --- drivers/android/binder_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/android/binder_alloc.c b/drivers/android

[PATCH v2 0/4] android: binder: fixes for memory allocator change

2017-10-20 Thread Sherry Yang
This patchset resolves a potential deadlock between lru lock, task lock and dentry lock reported by lockdep. It also fixes the null pointer dereference in kernel debug message in binder_alloc.c. Unused vma argument is removed, and binder shrinker is made static. android: binder: Don't get mm f

Re: [PATCH net 5/5] net/ncsi: Fix length of GVI response packet

2017-10-20 Thread David Miller
From: Samuel Mendoza-Jonas Date: Thu, 19 Oct 2017 13:43:09 +1100 > From: Gavin Shan > > The length of GVI (GetVersionInfo) response packet should be 40 instead > of 36. This issue was found from /sys/kernel/debug/ncsi/eth0/stats. > > # ethtool --ncsi eth0 swstats > : > RESPONSE OK

Re: [PATCH net 2/5] net/ncsi: Stop monitor if channel times out or is inactive

2017-10-20 Thread David Miller
From: Samuel Mendoza-Jonas Date: Thu, 19 Oct 2017 13:43:06 +1100 > ncsi_channel_monitor() misses stopping the channel monitor in several > places that it should, causing a WARN_ON_ONCE() to trigger when the > monitor is re-started later, eg: > > [ 459.04] WARNING: CPU: 0 PID: 1093 at net/nc

Re: [PATCH net 3/5] net/ncsi: Disable HWA mode when no channels are found

2017-10-20 Thread David Miller
From: Samuel Mendoza-Jonas Date: Thu, 19 Oct 2017 13:43:07 +1100 > From: Gavin Shan > > When there are no NCSI channels probed, HWA (Hardware Arbitration) > mode is enabled. It's not correct because HWA depends on the fact: > NCSI channels exist and all of them support HWA mode. This disables >

Re: [PATCH net 4/5] net/ncsi: Enforce failover on link monitor timeout

2017-10-20 Thread David Miller
From: Samuel Mendoza-Jonas Date: Thu, 19 Oct 2017 13:43:08 +1100 > From: Gavin Shan > > The NCSI channel has been configured to provide service if its link > monitor timer is enabled, regardless of its state (inactive or active). > So the timeout event on the link monitor indicates the out-of-s

Re: [PATCH net 1/5] net/ncsi: Fix AEN HNCDSC packet length

2017-10-20 Thread David Miller
From: Samuel Mendoza-Jonas Date: Thu, 19 Oct 2017 13:43:05 +1100 > Correct the value of the HNCDSC AEN packet. > Fixes: 7a82ecf4cfb85 "net/ncsi: NCSI AEN packet handler" > > Signed-off-by: Samuel Mendoza-Jonas Applied.

Re: [PATCH 7/7] gpio: brcmstb: implement suspend/resume/shutdown

2017-10-20 Thread Gregory Fong
On Thu, Oct 19, 2017 at 11:39 AM, Doug Berger wrote: >>> +static int brcmstb_gpio_resume(struct device *dev) >>> +{ >>> +struct brcmstb_gpio_priv *priv = dev_get_drvdata(dev); >>> +struct brcmstb_gpio_bank *bank; >>> +u32 wake_mask = 0; >> >> This isn't really being used as a mask, con

Re: [PATCH 0/3] arm64: cpuinfo: make /proc/cpuinfo more human-readable

2017-10-20 Thread Jon Masters
On 10/20/2017 01:24 PM, Jon Masters wrote: > 1). The first thing people do when they get an Arm server is to cat > /proc/cpuinfo. They then come complaining that it's not like x86. They > can't get the output their looking for and this results in bug filing, > and countless hours on phone calls di

[PATCH] net: core: rtnetlink: use BUG_ON instead of if condition followed by BUG

2017-10-20 Thread Gustavo A. R. Silva
Use BUG_ON instead of if condition followed by BUG in do_setlink. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only. net/core/rtnetlink.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net

Re: [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo

2017-10-20 Thread David Daney
On 10/20/2017 01:47 PM, Maciej W. Rozycki wrote: On Fri, 20 Oct 2017, Aleksandar Markovic wrote: Remove unnecessary space from FPU info segment of /proc/cpuinfo. NAK. As I recall back in Nov 2001 I placed the extra space there to visually separate the CPU part from the FPU part, e.g.: cpu

Re: [PATCH] PCI/AER: update AER status string print to match other AER logs

2017-10-20 Thread Bjorn Helgaas
On Tue, Oct 17, 2017 at 09:42:02AM -0600, Tyler Baicar wrote: > Currently the AER driver uses cper_print_bits() to print the AER status > string. This causes the status string to not include the proper PCI device > name prefix that the other AER prints include. Also, it has a different > print leve

[PATCH mmotm] lib/bug.c: fix build when MODULES are not enabled

2017-10-20 Thread Randy Dunlap
From: Randy Dunlap Fix build when CONFIG_MODULES is not enabled. Fixes multiple build errors. Signed-off-by: Randy Dunlap Reported-by: kbuild test robot Cc: Andi Kleen --- lib/bug.c |2 ++ 1 file changed, 2 insertions(+) --- mmotm-2017-1019-1700.orig/lib/bug.c +++ mmotm-2017-1019-1700/l

Re: [bug report] regression bisected to "block: Make most scsi_req_init() calls implicit"

2017-10-20 Thread Bart Van Assche
On Fri, 2017-10-20 at 16:54 -0600, dann frazier wrote: > hey, > I'm seeing a regression when executing 'dmraid -r -c' in an arm64 > QEMU guest, which I've bisected to the following commit: > > ca18d6f7 "block: Make most scsi_req_init() calls implicit" > > I haven't yet had time to try and deb

Re: [PATCH 09/27] uswsusp: Disable when the kernel is locked down

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, David Howells wrote: > From: Matthew Garrett > > uswsusp allows a user process to dump and then restore kernel state, which > makes it possible to modify the running kernel. Disable this if the kernel > is locked down. > > Signed-off-by: Matthew Garrett > Signed-off-by: D

Re: [PATCH 07/27] kexec_file: Disable at runtime if securelevel has been set

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, David Howells wrote: > From: Chun-Yi Lee > > When KEXEC_VERIFY_SIG is not enabled, kernel should not loads image > through kexec_file systemcall if securelevel has been set. > > This code was showed in Matthew's patch but not in git: > https://lkml.org/lkml/2015/3/13/778 >

Re: [PATCH 0/3] arm64: cpuinfo: make /proc/cpuinfo more human-readable

2017-10-20 Thread Al Stone
On 10/20/2017 10:10 AM, Mark Rutland wrote: > Hi Al, > > On Mon, Oct 16, 2017 at 05:43:19PM -0600, Al Stone wrote: >> On 10/13/2017 08:27 AM, Mark Rutland wrote: >>> I certainly agree that exposing the information that we have is useful, >>> as I have stated several times. I'm not NAKing exposing

Re: [PATCH 00/23] Hardened usercopy whitelisting

2017-10-20 Thread Paolo Bonzini
On 21/10/2017 00:40, Paolo Bonzini wrote: > This breaks KVM completely on x86, due to two ioctls > (KVM_GET/SET_CPUID2) accessing the cpuid_entries field of struct > kvm_vcpu_arch. > > There's also another broken ioctl, KVM_XEN_HVM_CONFIG, but it is > obsolete and not a big deal at all. > > I can

[PATCH 2/2] KVM: fix KVM_XEN_HVM_CONFIG ioctl

2017-10-20 Thread Paolo Bonzini
This ioctl is obsolete (it was used by Xenner as far as I know) but still let's not break it gratuitously... Its handler is copying directly into struct kvm. Go through a bounce buffer instead, with the added benefit that we can actually do something useful with the flags argument---the previous

[PATCH 0/2] KVM: fixes for the kernel-hardening tree

2017-10-20 Thread Paolo Bonzini
Two KVM ioctls (KVM_GET/SET_CPUID2) directly access the cpuid_entries field of struct kvm_vcpu_arch. Therefore, the new usercopy hardening work in linux-next, which forbids copies from and to slab objects unless they are from kmalloc or explicitly whitelisted, breaks KVM completely. This series f

[PATCH 1/2] KVM: allow setting a usercopy region in struct kvm_vcpu

2017-10-20 Thread Paolo Bonzini
On x86, struct kvm_vcpu has a usercopy region corresponding to the CPUID entries. The area is read and written by the KVM_GET/SET_CPUID2 ioctls. Without this patch, KVM is completely broken on x86 with usercopy hardening enabled. Define kvm_init in terms of a more generic function that allows set

Re: [PATCH 05/27] kexec: Disable at runtime if the kernel is locked down

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, David Howells wrote: > From: Matthew Garrett > > kexec permits the loading and execution of arbitrary code in ring 0, which > is something that lock-down is meant to prevent. It makes sense to disable > kexec in this situation. > > This does not affect kexec_file_load() whi

Re: [PATCH 04/27] Restrict /dev/mem and /dev/kmem when the kernel is locked down

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, David Howells wrote: > From: Matthew Garrett > > Allowing users to write to address space makes it possible for the kernel to > be subverted, avoiding module loading restrictions. Prevent this when the > kernel has been locked down. > > Signed-off-by: Matthew Garrett > Si

Re: [PATCH 03/27] Enforce module signatures if the kernel is locked down

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, David Howells wrote: > If the kernel is locked down, require that all modules have valid > signatures that we can verify. > > Signed-off-by: David Howells Reviewed-by: James Morris -- James Morris

Re: [PATCH 0/5] xfs refcount conversions

2017-10-20 Thread Dave Chinner
On Fri, Oct 20, 2017 at 02:07:53PM +0300, Elena Reshetova wrote: > Note: our previous thread didn't finish in any conclusion, so > I am resending this now (rebased at latest linux-next) to revive > the discussion. refcount_t is slowly becoming a standard for > refcounters and we would really like t

Re: [PATCH 01/27] Add the ability to lock down access to the running kernel image

2017-10-20 Thread James Morris
On Thu, 19 Oct 2017, David Howells wrote: > Provide a single call to allow kernel code to determine whether the system > should be locked down, thereby disallowing various accesses that might > allow the running kernel image to be changed including the loading of > modules that aren't validly sign

Re: [PATCH v6 03/10] drm/bridge: analogix: Do not use device's drvdata

2017-10-20 Thread jeffy
Hi Sean, On 10/21/2017 12:52 AM, Sean Paul wrote: On Thu, Oct 19, 2017 at 11:48:05AM +0800, Jeffy Chen wrote: This patch has somehow lost it's original author. I assume this is not intentional. oops, sorry, guess i used some wrongly command during the rebasing... will fix that.

[patch] tools/testing/radix-tree: ida_get_new_above returns EAGAIN

2017-10-20 Thread Jeff Moyer
...not ENOMEM. Fix it. Signed-off-by: Jeff Moyer diff --git a/tools/testing/radix-tree/idr-test.c b/tools/testing/radix-tree/idr-test.c index 30cd0b2..2056d83 100644 --- a/tools/testing/radix-tree/idr-test.c +++ b/tools/testing/radix-tree/idr-test.c @@ -380,7 +380,7 @@ void ida_check_random(vo

Re: [PATCH v2] dwc: dra7xx: Print link state to console for debug

2017-10-20 Thread Bjorn Helgaas
On Thu, Oct 19, 2017 at 06:13:29PM +0530, Faiz Abbas wrote: > Enable support for printing the LTSSM link state for debugging PCI > when link is down. > > Signed-off-by: Faiz Abbas > --- > v2: > 1. Changed dev_err() to dev_dbg() > 2. Changed static char array to static const char * const > 3. f

Re: [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo

2017-10-20 Thread Joe Perches
On Fri, 2017-10-20 at 22:46 +0100, Maciej W. Rozycki wrote: > On Fri, 20 Oct 2017, Joe Perches wrote: > > > > > That's somewhat unpleasant code as it formats a fmt string > > > > and the compiler can not verify fmt and args. > > > > > > > > Perhaps something like the below is preferable: > > > >

Re: [PATCH] PCI: faraday: fix inconsistent IS_ERR and PTR_ERR

2017-10-20 Thread Bjorn Helgaas
On Tue, Oct 17, 2017 at 12:07:17PM -0500, Gustavo A. R. Silva wrote: > Fix inconsistent IS_ERR and PTR_ERR in faraday_pci_probe. > The proper pointer to be passed as argument is p->bus_clk. > > This issue was detected with the help of Coccinelle. > > Reported-by: Julia Lawall > Signed-off-by: Gu

[PATCH 2/3] watchdog: hpwdt: SMBIOS check

2017-10-20 Thread Jerry Hoemann
Correct test on SMBIOS table 219 Misc Features bits for UEFI supported. Signed-off-by: Jerry Hoemann --- drivers/watchdog/hpwdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index ef54b03..4c011e8 100644 --- a/drivers/wa

[PATCH 3/3] watchdog: hpwdt: Check source of NMI

2017-10-20 Thread Jerry Hoemann
Do not claim the NMI (i.e. return NMI_DONE) if the source of the NMI isn't the iLO watchdog or debug. Signed-off-by: Jerry Hoemann --- drivers/watchdog/hpwdt.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index 4c011e8..b64ce

[PATCH 0/3] watchdog: hpwdt: driver update

2017-10-20 Thread Jerry Hoemann
Three short patches to the hpwdt driver. 1. Add WDIOC_GETPRETIMEOUT so that user space can determine when to expect the NMI arrivial. 2. The SMBIOS check was incorrect. 3. Do not claim NMI unless generated from iLO. Jerry Hoemann (3): watchdog: hpwdt: add ioctl WDIOC_GETPRETIMEOUT watchd

[PATCH 1/3] watchdog: hpwdt: add ioctl WDIOC_GETPRETIMEOUT

2017-10-20 Thread Jerry Hoemann
Add support for WDIOC_GETPRETIMEOUT ioctl so that user applications can determine when the NMI should arrive. Signed-off-by: Jerry Hoemann --- drivers/watchdog/hpwdt.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index 67fbe35..ef

Re: [patch 0/3] x86/PCI/MSI: Make sure that irq reservation mode works everywhere

2017-10-20 Thread Bjorn Helgaas
On Tue, Oct 17, 2017 at 09:54:56AM +0200, Thomas Gleixner wrote: > Dexuan reported that the recent rework of the vector allocation mode in x86 > broke HyperV PCI passtrough because the rework missed to add the > MSI_FLAG_MUST_REACTIVATE flag to the HyperV/PCI interrupt domain info. > > The simple

Re: [PATCH 18/27] bpf: Restrict kernel image access functions when the kernel is locked down

2017-10-20 Thread Alexei Starovoitov
On Fri, Oct 20, 2017 at 11:57:48PM +0800, j...@suse.com wrote: > On Fri, Oct 20, 2017 at 09:08:48AM +0100, David Howells wrote: > > Hi Joey, > > > > Should I just lock down sys_bpf() entirely for now? We can always free it > > up > > somewhat later. > > > > David > > OK~~ Please just remove my

[bug report] regression bisected to "block: Make most scsi_req_init() calls implicit"

2017-10-20 Thread dann frazier
hey, I'm seeing a regression when executing 'dmraid -r -c' in an arm64 QEMU guest, which I've bisected to the following commit: ca18d6f7 "block: Make most scsi_req_init() calls implicit" I haven't yet had time to try and debug it yet, but wanted to get the report out there before the weekend.

Re: PROBLEM: Remapping hugepages mappings causes kernel to return EINVAL

2017-10-20 Thread Mike Kravetz
On 10/19/2017 12:34 AM, C.Wehrmeyer wrote: > I apologise in case this message is going to arrive multiple times at the > mailing list. I've had connection problems this morning while trying to push > it through regardless, but it might or might not have been sent properly. I'm > sorry for the in

Re: [PATCH 00/23] Hardened usercopy whitelisting

2017-10-20 Thread Paolo Bonzini
On 20/06/2017 01:36, Kees Cook wrote: > > This updates the slab allocator to add annotations (useroffset and > usersize) to define allowed usercopy regions. Currently, hardened > usercopy performs dynamic bounds checking on whole slab cache objects. > This is good, but still leaves a lot of kernel

Re: [PATCH v3 1/3] interconnect: Add generic on-chip interconnect API

2017-10-20 Thread Bjorn Andersson
On Fri 20 Oct 07:43 PDT 2017, Georgi Djakov wrote: > Hi, > > On 09/08/2017 08:18 PM, Georgi Djakov wrote: > > This patch introduce a new API to get requirements and configure the > > interconnect buses across the entire chipset to fit with the current demand. > > > > The API is using a consumer/

Re: [PATCH v3 02/13] dax: require 'struct page' for filesystem dax

2017-10-20 Thread Dan Williams
On Fri, Oct 20, 2017 at 9:29 AM, Christoph Hellwig wrote: > On Fri, Oct 20, 2017 at 08:23:02AM -0700, Dan Williams wrote: >> Yes, however it seems these drivers / platforms have been living with >> the lack of struct page for a long time. So they either don't use DAX, >> or they have a constrained

[PATCH v3] display: panel: Add Mitsubishi aa070mc01 display support (800x480)

2017-10-20 Thread Lukasz Majewski
This commit adds support for Mitsubishi aa070mc01 TFT panel working with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector). Signed-off-by: Lukasz Majewski --- Changes for v2: - Place the code sorted alphabetically - Add missing ./Documentation/devicetree/binding/display properties de

[PATCH] display: panel: Add Tianma tm070rvhg71 display support (800x480)

2017-10-20 Thread Lukasz Majewski
Signed-off-by: Lukasz Majewski --- .../bindings/display/panel/tianma,tm070rvhg71.txt | 7 ++ drivers/gpu/drm/panel/panel-simple.c | 27 ++ 2 files changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/tianma,tm070rvh

Re: [PATCH] MIPS: kernel: proc: Remove spurious white space in cpuinfo

2017-10-20 Thread Maciej W. Rozycki
On Fri, 20 Oct 2017, Joe Perches wrote: > > > That's somewhat unpleasant code as it formats a fmt string > > > and the compiler can not verify fmt and args. > > > > > > Perhaps something like the below is preferable: > > > > Hmm, what problem exactly are you trying to solve with code that has

[PATCH v2] display: panel: Add Mitsubishi aa070mc01 display support (800x480)

2017-10-20 Thread Lukasz Majewski
This commit adds support for Mitsubishi aa070mc01 TFT panel working with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector). Signed-off-by: Lukasz Majewski --- Changes for v2: - Place the code sorted alphabetically - Add missing ./Documentation/devicetree/binding/display properties de

Re: [PATCH v9 19/29] x86/insn-eval: Add support to resolve 32-bit address encodings

2017-10-20 Thread Borislav Petkov
On Fri, Oct 20, 2017 at 12:16:06PM -0700, Ricardo Neri wrote: > Perhaps I can send the v10 of patches 1-18 (or a v1 since is a new > series?). Patches 19-29 would constitute a series of improved emulation > plus UMIP code. > > Does it make sense? Yap, it does. It is still tip guys' final decision

Re: [PATCH] PM / QoS: Fix device resume latency PM QoS

2017-10-20 Thread Reinette Chatre
Hi Rafael, Thank you very much! With this patch I am now able to dynamically modify the latency requirements via the kernel API. Below I provide the details of what I tested. On a four core system I wanted to dynamically constrain two cores from entering deeper C-states. # grep . /sys/devices

[PATCH] usb: phy: tahvo: fix error handling in tahvo_usb_probe()

2017-10-20 Thread Alexey Khoroshilov
If devm_extcon_dev_allocate() fails, we should disable clk before return. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Fixes: 860d2686fda7 ("usb: phy: tahvo: Use devm_extcon_dev_[allocate|register]() and replace deprecated API") --- drivers/u

[RFC v4 02/17] [media] v4l: use v4l2_subscribe_event_v4l2() on vtables

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan In all places that we were calling v4l2_ctrl_subscribe event() we now call v4l2_subscribe_event_v4l2() that embed v4l2_ctrl_subscribe event() and can be expanded to support more events. Signed-off-by: Gustavo Padovan --- drivers/media/common/saa7146/saa7146_video.c

[RFC v4 01/17] [media] v4l: create v4l2_event_subscribe_v4l2()

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan We need a common function to subscribe all the common events in drivers, so far we had only V4L2_EVENT_CTRL, so such a function wasn't necessary, but we are about to introduce a new event for the upcoming explicit fences implementation, thus a common place is needed. Signed

[RFC v4 04/17] WIP: [media] v4l2: add v4l2_event_queue_fh_with_cb()

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan For some type of events we may require the event user in the kernel to run some operation when DQ_EVENT() is called. V4L2_EVENT_OUT_FENCE is the first user of this mechanism as it needs to call v4l2 core back to install a file descriptor. This is WIP, I believe we are able

[RFC v4 07/17] [media] vivid: assign the specific device to the vb2_queue->dev

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan Instead of assigning the global v4l2 device, assign the specific device. This was causing trouble when using V4L2 events with vivid devices. The device's queue should be the same we opened in userspace. This is needed for the upcoming V4L2_EVENT_OUT_FENCE support. The curre

[RFC v4 09/17] [media] vb2: add 'ordered_in_vb2' property to queues

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan By setting this member on vb2_queue the driver tell vb2 core that it requires the buffers queued in QBUF to be queued with same order to the driver. Signed-off-by: Gustavo Padovan --- include/media/videobuf2-core.h | 4 1 file changed, 4 insertions(+) diff --git a/i

[RFC v4 12/17] [media] vb2: add explicit fence user API

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan Turn the reserved2 field into fence_fd that we will use to send an in-fence to the kernel and return an out-fence from the kernel to userspace. Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that should be used when sending a fence to the kernel to be waited on, and V4L2

[RFC v4 14/17] [media] vb2: add videobuf2 dma-buf fence helpers

2017-10-20 Thread Gustavo Padovan
From: Javier Martinez Canillas Add a videobuf2-fence.h header file that contains different helpers for DMA buffer sharing explicit fence support in videobuf2. v2: - use fence context provided by the caller in vb2_fence_alloc() Signed-off-by: Javier Martinez Canillas Signed-off-by: Gustavo

[RFC v4 11/17] [media] vb2: check earlier if stream can be started

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan To support explicit synchronization we need to run all operations that can fail before we queue the buffer to the driver. With fences the queueing will be delayed if the fence is not signaled yet and it will be better if such callback do not fail. For that we move the vb2_s

[RFC v4 13/17] [media] vb2: add in-fence support to QBUF

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan Receive in-fence from userspace and add support for waiting on them before queueing the buffer to the driver. Buffers are only queued to the driver once they are ready. A buffer is ready when its in-fence signals. For queues that require vb2 to queue buffers to the v4l2 dri

[RFC v4 15/17] [media] vb2: add infrastructure to support out-fences

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan Add vb2_setup_out_fence() and the needed members to struct vb2_buffer. v2: - change it to reflect fd_install at DQEVENT - add fence context for out-fences Signed-off-by: Gustavo Padovan --- drivers/media/v4l2-core/videobuf2-core.c | 31 +++

[RFC v4 16/17] [media] vb2: add out-fence support to QBUF

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create an out_fence and send to userspace on the V4L2_EVENT_OUT_FENCE when the buffer is queued to the driver, or right away if the queue is ordered both in VB2 and in the driver. The fence is signaled on buffer

[RFC v4 17/17] [media] v4l: Document explicit synchronization behaviour

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan Add section to VIDIOC_QBUF about it v3: - make the out_fence refer to the current buffer (Hans) - Note what happens when the IN_FENCE is not set (Hans) v2: - mention that fences are files (Hans) - rework for the new API Signed-off-by: Gusta

Re: [PATCH v2] mm: mlock: remove lru_add_drain_all()

2017-10-20 Thread Balbir Singh
On Fri, Oct 20, 2017 at 9:25 AM, Shakeel Butt wrote: > lru_add_drain_all() is not required by mlock() and it will drain > everything that has been cached at the time mlock is called. And > that is not really related to the memory which will be faulted in > (and cached) and mlocked by the syscall i

[RFC v4 10/17] [media] vivid: mark vivid queues as ordered_in_driver

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan To enable vivid to be used with explicit synchronization we need to mark its queues as ordered. vivid queues are already ordered by default so we no changes are needed. v2: rename 'ordered' to 'ordered_in_driver' to avoid confusion. Signed-off-by: Gustavo Padovan Acked-by

[RFC v4 08/17] [media] vb2: add 'ordered_in_driver' property to queues

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan For explicit synchronization (and soon for HAL3/Request API) we need the v4l2-driver to guarantee the ordering in which the buffers were queued by userspace. This is already true for many drivers, but we never needed to say it. v2: rename property to 'ordered_in_driver' to

[RFC v4 06/17] [media] vb2: add .send_out_fence() to notify userspace of out_fence_fd

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan With the upcoming explicit synchronization support to V4L2 we need a way to notify userspace of the out_fence_fd when buffers are queued to the driver - buffers with in-fences attached to it can only be queued once the fence signal, so the queueing to the driver might be def

[RFC v4 03/17] [media] v4l: use v4l2_subscribe_event_v4l2() on drivers

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan Driver that implement their own .vidioc_subscribe_event function should be using v4l2_subscribe_event_v4l2() instead of v4l2_ctrl_subscribe_event(). Signed-off-by: Gustavo Padovan --- drivers/media/pci/cobalt/cobalt-v4l2.c | 2 +- drivers/media/pci/ivtv/ivtv-i

[RFC v4 05/17] [media] v4l: add V4L2_EVENT_OUT_FENCE event

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan Add a new event the userspace can subscribe to receive notifications of the out_fence_fd when a buffer is queued onto the driver. The event provides the index of the queued buffer and the out_fence_fd. v3: - Rename event to V4L2_EVENT_OUT_FENCE v2: - Add missing Documentat

[RFC v4 00/17] V4L2 Explicit Synchronization support

2017-10-20 Thread Gustavo Padovan
From: Gustavo Padovan Hi, I renamed this back to RFC as many things are still under discussion/open but it integrates all comments received on the previous round[1]. My main goal now is to fit as many use cases as possible into this Explicit Synchronization implementation, but first I'd like to

Re: [PATCH 1/2] serdev: ttyport: enforce tty-driver open() requirement

2017-10-20 Thread Rob Herring
On Fri, Oct 20, 2017 at 7:21 AM, Greg Kroah-Hartman wrote: > On Tue, Oct 17, 2017 at 11:07:20AM -0500, Rob Herring wrote: >> On Mon, Oct 16, 2017 at 8:06 AM, Johan Hovold wrote: >> > The tty-driver open routine is mandatory, but the serdev >> > tty-port-controller implementation did not treat it

Re: [PATCH 2/9] PCI: host: brcmstb: add DT docs for Brcmstb PCIe device

2017-10-20 Thread Rob Herring
On Fri, Oct 20, 2017 at 12:27 PM, Brian Norris wrote: > Hi, > > On Thu, Oct 19, 2017 at 02:58:55PM -0700, Florian Fainelli wrote: >> On 10/19/2017 02:49 PM, Rob Herring wrote: >> > On Tue, Oct 17, 2017 at 5:42 PM, Jim Quinlan wrote: >> >> On Tue, Oct 17, 2017 at 4:24 PM, Rob Herring wrote: >> >>

Re: [PATCH v2 0/8] PCI: Improvements for native PCIe hotplug

2017-10-20 Thread Bjorn Helgaas
On Fri, Oct 13, 2017 at 09:35:40PM +0300, Mika Westerberg wrote: > Currently when plugging PCIe device using native PCIe hotplug Linux PCI > core tries to allocate bus space and resources so that the newly enumerated > topology barely fits there. Now, if the PCIe topology that was just plugged > in

RE: [PATCH 0/3] Drivers: hv: vmbus: Miscellaneous enhancements and fixes

2017-10-20 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday, October 20, 2017 3:28 PM > To: KY Srinivasan > Cc: linux-kernel@vger.kernel.org; de...@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; vkuzn...@redhat.com; > jasow...@redhat.com; leann.

[GIT PULL] ARM: SoC fixes for 4.14

2017-10-20 Thread Arnd Bergmann
The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/armsoc-fixes for you to fetch changes up to 6bf99a6cb69f78de0083

  1   2   3   4   5   6   7   8   9   >