Hi Daniel, Kees, David, Russel,
>> Any plans to implement above especially BPF_JMP | BPF_CALL in near future?
>> Reason why I'm asking is that i) currently the arm32 cBPF JIT implements
>> all of the cBPF extensions (except SKF_AD_RANDOM and SKF_AD_VLAN_TPID).
>> Some of the programs that were JIT
FYI, we noticed the following commit:
commit: f99973e18b65ca1fff8c81532e3132b8f622aea8 ("nohz: Fix buggy tick delay
on IRQ storms")
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
in testcase: boot
on test machine: qemu-system-x86_64 -enable-kvm -cpu host -smp 2 -m 1G
Kalle,
在 2017年06月13日 14:28, Kalle Valo 写道:
Caesar Wang writes:
We have always met the unused log be printed as following.
...
[23193.523182] mwifiex_pcie :01:00.0: mwifiex_get_cfp:
cannot find cfp by band 2& channel=13 freq=0
[23378.633684] mwifiex_pcie :01:00.0: mwifiex_get_cfp:
If a tty driver wants to notify the user of some exceptional event,
such as a usb cdc acm device set_line_coding event, it needs a way to
modify the mask returned by poll() and possible also add wait queues.
In order to do that, we allow the driver to supply a poll() callback
of its own, which will
GetLineCoding and SetLineCoding are a cdc-acm thing. It doesn't make
sense to have that in the generic u_serial layer. Moreso, f_acm has its
own port_line_coding in its own struct and it uses that, while the one
in struct gserial is set once upon initialization and then never used.
Also, the initia
sorry for the inconvenience caused i have corrected it.
Regards,
Jaya Durga R
On June 13, 2017 at 11:25 AM Greg KH wrote:
> On Tue, Jun 13, 2017 at 10:47:58AM +0530, R Jayadurga wrote:
> > This e-mail is for the sole use of the intended recipient(s) and may
> > contain confidential and privilege
The user can issue USB_F_GET_LINE_CODING to get the current line coding
as set by the host (or the default if unset yet).
Signed-off-by: Tal Shorer
---
Documentation/ioctl/ioctl-number.txt | 1 +
drivers/usb/gadget/function/f_acm.c | 19 +++
include/uapi/linux/usb/f_acm.h
We shouldn't accept malformed set_line_coding requests.
All values were taken from table 17 (section 6.3.11) of the cdc1.2 spec
available at http://www.usb.org/developers/docs/devclass_docs/
The table is in the file PTSN120.pdf.
Signed-off-by: Tal Shorer
---
drivers/usb/gadget/function/f_acm.c |
Hyunchul,
Am 13.06.2017 um 08:30 schrieb Hyunchul Lee:
> From: Hyunchul Lee
>
> Use readahead_gfp_mask for gfp flags when allocating pages.
> This set additional flags which are __GFP_NORETRY and
> __GFP_NOWARN. So OOMs and a failure message can be
> avoided.
> And we should remove __GFP_FS from
Initialize acm->port_line_coding with something that makes sense so
that we can return a valid line coding if the host requests
GetLineCoding before requesting SetLineCoding
Signed-off-by: Tal Shorer
---
drivers/usb/gadget/function/f_acm.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
In order for a serial function to implement its own ioctl() calls,
propagate the ioctl() callback to the next layer so it can handle it if
it sees fit to do so.
Signed-off-by: Tal Shorer
---
drivers/usb/gadget/function/u_serial.c | 15 +++
drivers/usb/gadget/function/u_serial.h | 1
Notify the user with a POLLPRI event when the host issues a
SetLineCoding request so that they can act upon it, for example by
configuring the line coding on a real serial port.
The event is cleared when the user reads the line coding using
USB_F_ACM_GET_LINE_CODING ioctl()
Signed-off-by: Tal Sho
In order for a serial function to add flags to the poll() mask of their
tty files, propagate the poll() callback to the next layer so it can
return a mask if it sees fit to do so.
Signed-off-by: Tal Shorer
---
drivers/usb/gadget/function/u_serial.c | 16
drivers/usb/gadget/funct
I'm currently working on a project where I'd like to have an omap board
running linux be a usb-to-uart converter (using f_acm), and I've ran
into an issue: there's no way for the application to know if the host
has issued a SetLineCoding requests (after which parity/baudrate should
be changed to ma
* Andy Lutomirski wrote:
> The kernel has several code paths that read CR3. Most of them assume that
> CR3 contains the PGD's physical address, whereas some of them awkwardly
> use PHYSICAL_PAGE_MASK to mask off low bits.
>
> Add explicit mask macros for CR3 and convert all of the CR3 readers.
On 06/12/2017 10:35 PM, Helen Koike wrote:
Hi Hans,
Thank you for your review. Please check my comments below
On 2017-06-12 07:37 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
+static struct component_match *vimc_add_subdevs(struct vimc_device
*vimc)
+{
+struct compon
Hi Nicholas,
Today's linux-next merge of the target-updates tree got a conflict in:
drivers/scsi/qla2xxx/qla_target.c
between commit:
f775bd14e44d ("scsi: qla2xxx: Convert 32-bit LUN usage to 64-bit")
from the scsi-mkp tree and commit:
6b26726af699 ("qla2xxx: Convert QLA_TGT_ABTS to
TA
Hi Philipp,
On 06/01/2017 10:22 PM, Philipp Zabel wrote:
Reset controls already may control multiple reset lines with a single
hardware bit. So from the user perspective, reset control arrays are not
at all different from single reset controls.
Therefore, hide reset control arrays behind struct
On Mon, May 15, 2017 at 09:59:14PM +0800, Dong Aisheng wrote:
> This patch series intends to add imx7ulp clk support.
>
> i.MX7ULP Clock functions are under joint control of the System
> Clock Generation (SCG) modules, Peripheral Clock Control (PCC)
> modules, and Core Mode Controller (CMC)1 block
* Paul E. McKenney wrote:
> Hello, Ingo,
>
> This pull request is unusual in being a single linear set of commits,
> as opposed to my usual topic branches. This is due to the many
> large-footprint changes, which means that reasonable topic branches
> result in large numbers of merge conflicts
* Matthias Kaehlcke wrote:
> This series fixes an issue with the stack of the x86 boot code not
> being aligned as intended. Further it adapts the Makefile to account
> for the fact that clang uses a different option to configure the
> stack alignment than gcc (-mstack-alignment=N vs
> -mpreferr
On Mon, Jun 12, 2017 at 04:49:29PM +0200, Peter Zijlstra wrote:
> On Sun, Jun 11, 2017 at 09:56:32PM +0800, Boqun Feng wrote:
>
> > I think the term we use to refer this behavior is "fully-ordered"?
>
> Right, that is what we used to call it, and the term even occurs in
> memory-barriers.txt but
* Matthias Kaehlcke wrote:
> For gcc stack alignment is configured with -mpreferred-stack-boundary=N,
> clang has the option -mstack-alignment=N for that purpose. Use the same
> alignment as for gcc.
>
> If the alignment is not specified clang assumes an alignment of
> 16 bytes, as required by
On 06/12/2017 07:20 PM, Helen Koike wrote:
Hi Hans,
Thanks for your review, just a question below
On 2017-06-12 06:50 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
+/* The width, height, code and colorspace must match. */
+if (source_fmt.format.width != sink_fmt.f
On Mon, Jun 12, 2017 at 06:56:54PM +0200, Salvatore Mesoraca wrote:
> Creation of a new LSM hook to check if a given configuration of vmflags,
> for a new memory allocation request, should be allowed or not.
> It's placed in "do_mmap", "do_brk_flags" and "__install_special_mapping".
Please always
From: Hyunchul Lee
Use readahead_gfp_mask for gfp flags when allocating pages.
This set additional flags which are __GFP_NORETRY and
__GFP_NOWARN. So OOMs and a failure message can be
avoided.
And we should remove __GFP_FS from flags to prevent from
calling ubifs_writepage during page reclaim.
S
On (06/13/17 08:20), Greg KH wrote:
> On Tue, Jun 13, 2017 at 04:04:18PM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> >
> > After merging the driver-core tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/block/zram/zram_drv.c:1296:28: error: expected ')'
Caesar Wang writes:
> We have always met the unused log be printed as following.
>
> ...
> [23193.523182] mwifiex_pcie :01:00.0: mwifiex_get_cfp:
> cannot find cfp by band 2& channel=13 freq=0
> [23378.633684] mwifiex_pcie :01:00.0: mwifiex_get_cfp:
> cannot find cfp by band 2& ch
Hi Christoph,
On Tue, 13 Jun 2017 08:20:55 +0200 Christoph Hellwig wrote:
>
> Btw, scm_blk.c blk-mq conversion seems odd if not broken. It should
> always call blk_mq_complete_request from scm_request_finish and
> then pass the error to blk_mq_end_request frin
> there.
>
> It would be great if
On Mon, Jun 12, 2017 at 5:44 PM, jmondi wrote:
> Hi Linus,
>
> On Sun, Jun 11, 2017 at 11:45:49PM +0200, Linus Walleij wrote:
>> On Fri, Jun 9, 2017 at 9:50 AM, jmondi wrote:
>> > On Fri, Jun 09, 2017 at 03:26:57PM +0800, Dong Aisheng wrote:
>>
>> >> > I see three options here:
>> >> >
>> >> > 1)
Hi Greg,
On Tue, 13 Jun 2017 08:20:48 +0200 Greg KH wrote:
>
> Odd that 0-day isn't giving me any failed build reports :(
Yeah, I wonder if 0-day is doing x86_64 allmodconfig builds regularly ...
--
Cheers,
Stephen Rothwell
Hi all,
Today's linux-next merge of the char-misc tree got a conflict in:
Documentation/admin-guide/index.rst
between commit:
504f231cda56 ("doc: ReSTify and split LSM.txt")
from the jc_docs tree and commit:
163f15115203 ("thunderbolt: Add documentation how Thunderbolt bus can be
used"
On Tue, Jun 13, 2017 at 11:31:42AM +0530, bincy wrote:
> Signed-off-by: bincy k philip
> ---
> drivers/staging/octeon-usb/octeon-hcd.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
You didn't fix everything my patch-bot told you about, please try again.
thanks,
greg k-
From: Fenglin Wu
Power source selection in DIG_VIN_CTL is indexed from 0, in the range
check it shouldn't be equal to the total number of power sources.
Signed-off-by: Fenglin Wu
---
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dr
Btw, scm_blk.c blk-mq conversion seems odd if not broken. It should
always call blk_mq_complete_request from scm_request_finish and
then pass the error to blk_mq_end_request frin
there.
It would be great if such major block driver changes were Cc'ed to
linux-block.
On Tue, Jun 13, 2017 at 04:04:18PM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the driver-core tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/block/zram/zram_drv.c:1296:28: error: expected ')' before numeric
> constant
> static CLASS_ATTR(ho
From: Fenglin Wu
Add property "qcom,dtest-buffer" to specify which dtest rail to feed
when the pin is configured as a digital input.
Signed-off-by: Fenglin Wu
---
.../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 15
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 45 +
From: Fenglin Wu
GPIO LV (low voltage)/MV (medium voltage) subtypes have different
features and register mappings than 4CH/8CH subtypes. Add support
for LV and MV subtypes.
Signed-off-by: Fenglin Wu
---
.../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 28 ++-
drivers/pinctrl/qcom/pinctrl-
On 02/06/17 21:31, Stefano Stabellini wrote:
> Allocate a socket. Keep track of socket <-> ring mappings with a new data
> structure, called sock_mapping. Implement the connect command by calling
> inet_stream_connect, and mapping the new indexes page and data ring.
> Allocate a workqueue and a wor
From: Fenglin Wu
LV (low voltage) and MV (medium voltage) subtype GPIO modules are support
in QCOM PMICs like PMI8998, PM660. These modules support addtional features
(func3, func4, analog-pass-through) and the register mappings are
also different compared with legacy 4CH/8CH subtypes.
These pat
Hi Felipe,
Today's linux-next merge of the usb-gadget tree got a conflict in:
drivers/usb/gadget/function/f_mass_storage.c
between commit:
dc9217b69dd6 ("usb: gadget: f_mass_storage: Serialize wake and sleep
execution")
from Linus' tree and commit:
225785aec726 ("USB: f_mass_storage: i
On Sun, 2017-06-11 at 23:26 +0200, Linus Walleij wrote:
> This timer is often used on the ARM architecture, so as with so
> many siblings, we can implement delay timers, removing the need
> for the system to calibrate jiffys at boot, and potentially
> handling CPU frequency scaling on targets.
>
>
From: Wanpeng Li
Adds another flag bit (bit 2) to MSR_KVM_ASYNC_PF_EN. If bit 2 is 1, async
page faults are delivered to L1 as #PF vmexits; if bit 2 is 0,
kvm_can_do_async_pf
returns 0 if in guest mode.
Cc: Paolo Bonzini
Cc: Radim Krčmář
Signed-off-by: Wanpeng Li
---
Documentation/virtual
INFO: task gnome-terminal-:1734 blocked for more than 120 seconds.
Not tainted 4.12.0-rc4+ #8
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
gnome-terminal- D0 1734 1015 0x
Call Trace:
__schedule+0x3cd/0xb30
schedule+0x40/0x90
kvm_async_pf_
From: Wanpeng Li
This patch removes all arguments except the first in
kvm_x86_ops->queue_exception
since they can extract the arguments from vcpu->arch.exception themselves, do
the
same in nested_{vmx,svm}_check_exception.
Cc: Paolo Bonzini
Cc: Radim Krčmář
Signed-off-by: Wanpeng Li
---
From: Wanpeng Li
This patch adds the L1 guest async page fault #PF vmexit handler, such
#PF is converted into vmexit from L2 to L1 on #PF which is then handled
by L1 similar to ordinary async page fault.
Cc: Paolo Bonzini
Cc: Radim Krčmář
Signed-off-by: Wanpeng Li
---
arch/x86/kvm/vmx.c |
From: Wanpeng Li
Add an async_page_fault field to vcpu->arch.exception to identify an async
page fault, and constructs the expected vm-exit information fields. Force
a nested VM exit from nested_vmx_check_exception() if the injected #PF
is async page fault.
Cc: Paolo Bonzini
Cc: Radim Krčmář
On Tue, 13 Jun 2017 00:40:26 +0200,
Ben Skeggs wrote:
>
> On 06/10/2017 06:25 AM, Takashi Iwai wrote:
> > Hi,
> >
> > we've received a bug report about 4.4.70 kernel showing the hang up at
> > boot. And, this turned out to be a regression in nouveau driver:
> > https://bugzilla.suse.com/show_b
On 02/06/17 21:31, Stefano Stabellini wrote:
> Just reply with success to the other end for now. Delay the allocation
> of the actual socket to bind and/or connect.
>
> Signed-off-by: Stefano Stabellini
> CC: boris.ostrov...@oracle.com
> CC: jgr...@suse.com
> ---
> drivers/xen/pvcalls-back.c | 2
Hi Greg,
After merging the driver-core tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/block/zram/zram_drv.c:1296:28: error: expected ')' before numeric
constant
static CLASS_ATTR(hot_add, 0400, hot_add_show, NULL);
^
drivers/block/zram
On Tue, 2017-06-13 at 08:52 +0300, Aviya Erenfeld wrote:
> Shorten lines over 80 chars
Most of these changes are not useful.
Style nits if 80 columns are _really_ desired.
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
[]
> @@ -157,7
On Fri, Jun 09, 2017 at 12:15:42PM -0700, Jin Qian wrote:
> Reviewed-by: Jin Qian
>
> Can we merge this to stable?
I don't understand the question, what kernel(s) exactly do you want this
commit to be added to?
thanks,
greg k-h
On 02/06/17 21:31, Stefano Stabellini wrote:
> Also add pvcalls-back to the Makefile.
>
> Signed-off-by: Stefano Stabellini
> CC: boris.ostrov...@oracle.com
> CC: jgr...@suse.com
> ---
> drivers/xen/Kconfig | 12
> drivers/xen/Makefile | 1 +
> 2 files changed, 13 insertions(+)
>
On 13-06-17, 14:58, Tomasz Wilczynski wrote:
> This is my first patch so please bare with me...
No worries, we were just telling you about what's the right way..
> I am just a little
> confused. Does this mean that it is all right to leave the patch as it is,
> or should I still add the Fixes: ta
Hi Takashi,
On Tue, 13 Jun 2017 07:29:12 +0200 Takashi Iwai wrote:
>
> On Tue, 13 Jun 2017 01:49:45 +0200,
> Stephen Rothwell wrote:
> >
> > After merging the sound-current tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > sound/synth/emux/emux.c: In function 's
Boris,
On Mon, Jun 12, 2017 at 07:58:52PM +0200, Borislav Petkov wrote:
> From: Borislav Petkov
>
> Ok,
>
> I think I've dreamt of a simple solution to the early microcode
> application deal with suspend-to-RAM. The commit message of patch 2
> should explain it in more detail. Patch 1 is a fix
Rafael,
On Mon, Jun 12, 2017 at 10:46:47PM +0200, Rafael J. Wysocki wrote:
> Hi All,
>
> On Thursday, June 08, 2017 02:00:40 AM Rafael J. Wysocki wrote:
> > Hi All,
> >
> > This series is a replacement for commit eed4d47efe95 (ACPI / sleep: Ignore
> > spurious SCI wakeups from suspend-to-idle) w
Enric Balletbo i Serra wrote:
> When request firmware fails, brcmf_ops_sdio_remove is being called and
> brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle
> the kernel hangs on resume due a NULL pointer dereference in resume
> function.
>
> Steps to reproduce the problem:
On Tue, Jun 13, 2017 at 10:47:58AM +0530, R Jayadurga wrote:
> This e-mail is for the sole use of the intended recipient(s) and may
> contain confidential and privileged information. If you are not the
> intended recipient, please contact the sender by reply e-mail and destroy
> all copies and the
On Tuesday, June 13, 2017 2:00:16 AM CEST Richard Zhu wrote:
> > -Original Message-
> > From: Bjorn Helgaas [mailto:helg...@kernel.org]
> > Sent: Tuesday, June 13, 2017 7:49 AM
> > To: Stefan Schoefegger
> > Cc: linux-...@vger.kernel.org; Richard Zhu ; Arnd
> > Bergmann ; open list ;
> > K
Shorten lines over 80 chars
Signed-off-by: Aviya Erenfeld
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 58 +++-
1 file changed, 39 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging/rtl8188eu/core/rtw_sta_mgt
Remove unneeded blank lines
Signed-off-by: Aviya Erenfeld
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
index c6a7df5..cd348ca 100644
--- a/d
Hi, Jaehoon
Thank you very much for your advices; I'll follow your advices and fix all the
other places but except for the following one:
"You have assumption...always.
mshc0 -> eMMC,
mshc1 -> SD
mshc2 -> SDIO"
yes, mshc0 -> eMMC, mshc1 -> SD,mshc2 -> SDIO. Can you point it out in detail?
Tha
Remove redundant parenthesis
Signed-off-by: Aviya Erenfeld
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
in
Fix some of the issues that checkpatch complains on like redundant
parenthesis, redundant blank lines and lines over 80 chars.
Aviya Erenfeld (3):
staging: rtl8188eu: Remove redundant parenthesis
staging: rtl8188eu: Remove unneeded blank lines
staging: rtl8188eu: Shorten lines over 80 chars
On Monday, June 12, 2017 6:49:24 PM CEST Bjorn Helgaas wrote:
> On Wed, Jun 07, 2017 at 01:36:11PM +0200, Stefan Schoefegger wrote:
> > Link speed must not be limited to gen1 during link test for compliance
> > tests
> >
> > Signed-off-by: Stefan Schoefegger
> > ---
> >
> > Changes since v1:
> >
On Tue, Jun 13, 2017 at 9:58 AM, Oza Oza wrote:
> On Tue, Jun 13, 2017 at 5:00 AM, Bjorn Helgaas wrote:
>> Please wrap your changelogs to use 75 columns. "git log" indents the
>> changelog by four spaces, so if your text is 75 wide, it will still
>> fit without wrapping.
>>
>> On Sun, Jun 11, 20
Dear Takiguchi,
Roger that.
Thanks for explanation !
2017-06-13 1:35 GMT-04:00 Takiguchi, Yasunari :
> Dear Abylay Ospan
>
> Thank you for your review and proposal.
>
> Unfortunately, we supposed it's difficult to cover CXD2841 functionality by
> CXD2880 driver.
> CXD2880 is for mobile IC, tuner
Dear Abylay Ospan
Thank you for your review and proposal.
Unfortunately, we supposed it's difficult to cover CXD2841 functionality by
CXD2880 driver.
CXD2880 is for mobile IC, tuner (RF) and demodulator convined IC.
On the other hand, CXD2841 is demodulator only IC for stationary use.
CXD2841 su
On Fri, 2017-06-09 at 19:36 +0200, Sylwester Nawrocki wrote:
> On 04/06/2017 08:11 AM, Smitha T Murthy wrote:
> > This patch series adds MFC v10.10 support. MFC v10.10 is used in some
> > of Exynos7 variants.
> >
> > This adds support for following:
> >
> > * Add support for HEVC encoder and deco
Hello LKML,
Attempted to play with BFQ but after building with CONFIG_IOSCHED_BFQ=y I'm
still not seeing it:
# cat
/sys/devices/pci:00/:00:1f.2/ata1/host0/target0:0:0/0:0:0:0/block/sda/queue/scheduler
noop deadline [cfq]
#
Even though:
# dmesg | grep sched
[0.514536] io schedu
On Tue, 13 Jun 2017 01:49:45 +0200,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> After merging the sound-current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/synth/emux/emux.c: In function 'snd_emux_new':
> sound/synth/emux/emux.c:51:5: error: 'struct snd_emu
Hello Rob
On 06/13/2017 12:53 AM, Rob Herring wrote:
On Thu, Jun 08, 2017 at 02:16:01PM +0900, Jiada Wang wrote:
ECSPI contorller for iMX53 and iMX6 has few hardware issues
comparing to iMX51.
The change add possibility to detect which controller is used
to apply possible workaround and limitat
The cros_ec requires CS line to be active after last message. But the CS
would be toggled when powering off/on rockchip spi, which breaks ec xfer.
Use GPIO CS to prevent that.
Signed-off-by: Jeffy Chen
---
Changes in v2:
Fix wrong pinconf for spi5_cs0.
arch/arm64/boot/dts/rockchip/rk3399-gru.d
Update document devicetree bindings to support "cs-gpios" property.
Signed-off-by: Jeffy Chen
---
Changes in v2: None
Documentation/devicetree/bindings/spi/spi-rockchip.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt
b/Documenta
Support using "cs-gpios" property to specify cs gpios.
Signed-off-by: Jeffy Chen
1/ request cs gpios in probe for better error handling
2/ use gpiod* function
(suggested by Heiko Stuebner)
3/ split dt-binding changes to new patch
(suggested by Shawn Lin & Heiko Stuebner)
---
Changes in v2: Non
After failed to request dma tx chain, we need to disable pm_runtime.
Also cleanup error labels for better readability.
Signed-off-by: Jeffy Chen
---
Changes in v2: None
drivers/spi/spi-rockchip.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/
Stephen,
On 6/9/2017 3:11 PM, Varadarajan Narayanan wrote:
From: Abhishek Sahu
This patch adds support for the global clock controller found on
the ipq8074 based devices. This includes UART, I2C, SPI etc.
Signed-off-by: Abhishek Sahu
Signed-off-by: Varadarajan Narayanan
---
drivers/clk/qc
Bjorn,
On 6/9/2017 3:11 PM, Varadarajan Narayanan wrote:
Add initial pinctrl driver to support pin configuration with
pinctrl framework for ipq8074.
Acked-by: Rob Herring (bindings)
Signed-off-by: Manoharan Vijaya Raghavan
Signed-off-by: Varadarajan Narayanan
---
.../bindings/pinctrl/qcom,
On Tue, Jun 13, 2017 at 4:27 AM, wrote:
> Update: got another reproducible KASAN report on commit
> 32c1431eea4881a6b17bd7c639315010aeefa452(4.12-rc5) :
Hi,
If it's reproducible, please provide the reproducer.
> ==
> BUG: KASAN:
It is not a good idea to re-use macros that represent a specific
register bit field for the transfer direction.
It is true that bit 8 indicates the direction for the MAP10 pipeline
operation and the data DMA operation, but this is not valid across
the IP.
Use a simple flag (write: 1, read: 0) for
This driver stores the currently addressed page into denali->page,
which is later read out by helper functions. While I am tackling on
this driver, I often missed to insert "denali->page = page;" where
needed. This makes page_read/write callbacks to get access to a
wrong page, which is a bug hard
Simplify the interrupt handling and fix issues:
- The register field view of INTR_EN / INTR_STATUS is different
among IP versions. The global macro DENALI_IRQ_ALL is hard-coded
for Intel platforms. The interrupt mask should be determined at
run-time depending on the running platform.
- wa
File size before:
textdatabss dec hex filename
4240 200 80 4520 11a8 drivers/power/supply/power_supply_core.o
File size After adding 'const':
textdatabss dec hex filename
4296 136 80 4512 11a0 drivers/power/supply/power_supply_core.o
Signed-off-
On Mon, Jun 12, 2017 at 01:26:00PM -0700, Arun Parameswaran wrote:
> +Example:
> +
> +ptp_dte: ptp_dte@180af650 {
> + compatible = "brcm,ptp-dte";
> + reg = <0x180af650 0x10>;
> + status = "okay";
> +};
This patch set looks okay, as far as it goes, but how does one
actually use the clo
The NAND_CMD_SET_FEATURES support is missing from denali_cmdfunc().
Besides, we see /* TODO: Read OOB data */ comment line.
It would be possible to add more commands along with the current
implementation, but having ->cmd_ctrl() seems a better approach from
the discussion with Boris [1].
Rely on
The current bank reset implementation polls the INTR_STATUS register
until interested bits are set. This is not good because:
- polling simply wastes time-slice of the thread
- The while() loop may continue eternally if no bit is set, for
example, due to the controller problem. The denali_wai
Handling timing parameters in a driver's own way should be avoided
because it duplicates efforts of drivers/mtd/nand/nand_timings.c
Besides, this driver hard-codes Intel specific parameters such as
CLK_X=5, CLK_MULTI=4. Taking a certain device (Samsung K9WAG08U1A)
into account by get_samsung_nand_
The function find_valid_banks() issues the Read ID (0x90) command,
then compares the first byte (Manufacturer ID) of each bank with
the one of bank0.
This is equivalent to what nand_scan_ident() does. The number of
chips is detected there, so this is unneeded.
What is worse for find_valid_banks(
NAND_CMD_PARAM is not working at all due to multiple bugs.
[1] The command 0x90 issued instead of 0xec
The command code 0x90 is hard-code as
index_addr(denali, addr | 0, 0x90)
So, Read ID (0x90) command is sent to the device instead of Read
Parameter Page (0xec).
[2] only first 8 bytes are re
Recent versions of this IP support automatic erased page detection.
If an erased page is detected on reads, the controller does not set
INTR__ECC_UNCOR_ERR, but INTR__ERASED_PAGE.
The detection of erased pages is based on the number of zeros in a
page; if the number of zeros is less than the value
Introduce some macros and helpers to avoid magic numbers and
rename macros/functions for clarification.
- We see '| 2' in several places. This means Data Cycle in MAP11 mode.
The Denali User's Guide says bit[1:0] of MAP11 is like follows:
b'00 = Command Cycle
b'01 = Address Cycle
b'10 =
As Russell and Lars stated in the discussion [1], using
devm_k*alloc() with DMA is not a good idea.
Let's use kmalloc (not kzalloc because no need for zero-out).
Also, allocate the buffer as late as possible because it must be
freed for any error that follows.
[1] https://lkml.org/lkml/2017/3/8/6
The nand_scan_ident() iterates over maxchips, and calls nand_reset()
for each. This driver currently passes the maximum number of banks
(=chip selects) supported by the controller as maxchips. So, maxchips
is typically 4 or 8. Usually, less number of NAND chips are connected
to the controller.
This patch series intends to solve various problems.
[1] The driver just retrieves the OOB area as-is
whereas the controller uses syndrome page layout.
[2] ONFi devices are not working
[3] It can not read Bad Block Marker
Outstanding changes are:
- Fix raw/oob callbacks for syndrome page la
For ecc->read_page() and ecc->write_page(), it is possible to call
dma_map_single() against the given buffer. This bypasses the driver
internal bounce buffer and save the memcpy().
Signed-off-by: Masahiro Yamada
---
Changes in v6: None
Changes in v5: None
Changes in v4:
- Remove dma_unmap_sin
The current NAND_CMD_STATUS handling is weird; it just reads the
WRITE_PROTECT register, and returns NAND_STATUS_WP if it is set.
It does not send Read Status (0x70) command, so it is not helpful
for checking the current device status.
Signed-off-by: Masahiro Yamada
---
Changes in v6: None
Chan
The denali_cmdfunc() actually does nothing valuable for
NAND_CMD_{PAGEPROG,READ0,SEQIN}.
For NAND_CMD_{READ0,SEQIN}, it copies "page" to "denali->page", then
denali_read_page(_raw) compares them just for the sanity check.
(Inconsistently, this check is missing from denali_write_page(_raw).)
The D
Now struct nand_buf has only two members, so I see no reason for the
separation.
Signed-off-by: Masahiro Yamada
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2:
- Newly added
drivers/mtd/nand/denali.c | 29 ++---
drive
Now this driver is ready to remove NAND_SKIP_BBTSCAN.
The BBT descriptors in denali.c are equivalent to the ones in
nand_bbt.c. There is no need to duplicate the equivalent structures.
The with-oob decriptors do not work for this driver anyway.
The bbt_pattern (offs = 8) and the version (veroffs
1 - 100 of 1294 matches
Mail list logo
