Re: [PATCH 0/2] Fix incorrect warning from dma-debug

2017-05-06 Thread Jon Masters
On 05/09/2016 06:00 AM, Robin Murphy wrote: > On 09/05/16 10:37, Robin Murphy wrote: >> Hi Niklas, >> >> On 08/05/16 11:59, Niklas Söderlund wrote: >>> Hi, >>> >>> While using CONFIG_DMA_API_DEBUG i came across this warning which I >>> think is a false positive. As shown dma_sync_single_for_device(

[RFC] NMI: Generic per-code NMI handler (panic/kdump)

2017-05-06 Thread Adrien Mahieux
Hello, I'm new to the LKML, so should I make mistakes, please tell me along with the correct way to do (or doc I've read but forgotten). I've written a small module to manage NMI events based on their code, so a sysadmin can drop them (avoid console messages) or panic the kernel (kdump). https:/

Re: [PATCH 0/3] staging: ccree: resolve checkpatch issues.

2017-05-06 Thread Matthew Giassa
* Matthew Giassa [2017-05-06 15:46:53 -0700]: Included is a set of small fixes to resolve all outstanding checkpatch warnings issues for drivers/staging/ccree/cc_hal.h. Two are cosmetic (training whitespace and 80+ character comment), and the other is functional (macro argument previously not w

[PATCH 2/3] staging: ccree: resolve columns over 80 chars in cc_hal.h

2017-05-06 Thread Matthew Giassa
Modified comment to resolve 80+ characters warning from checkpatch. ie: WARNING: line over 80 characters Warnings no longer present after change. Signed-off-by: Matthew Giassa --- drivers/staging/ccree/cc_hal.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/stagi

[PATCH 3/3] staging: ccree: resolve possible macro issue in cc_hal.h

2017-05-06 Thread Matthew Giassa
Wrapping "offset" in macro definition to resolve checkpatch issue, ie: CHECK: Macro argument 'offset' may be better as '(offset)' to avoid precedence issues Signed-off-by: Matthew Giassa --- drivers/staging/ccree/cc_hal.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 0/3] staging: ccree: resolve checkpatch issues.

2017-05-06 Thread Matthew Giassa
Included is a set of small fixes to resolve all outstanding checkpatch warnings issues for drivers/staging/ccree/cc_hal.h. Two are cosmetic (training whitespace and 80+ character comment), and the other is functional (macro argument previously not wrapped in parentheses).

[PATCH 1/3] staging: ccree: resolve training whitespace in cc_hal.h

2017-05-06 Thread Matthew Giassa
Removing trailing newlines reported by checkpatch.pl. ie: ERROR: trailing whitespace (lines 3, 7, 12). Warnings no longer present after change. Signed-off-by: Matthew Giassa --- drivers/staging/ccree/cc_hal.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/stag

Re: [PATCH] ACPI: SPCR: Use access width to determine mmio usage

2017-05-06 Thread Jon Masters
On 05/04/2017 11:05 AM, Jon Mason wrote: > The current SPCR code does not check the access width of the mmio, and > uses a default of 8bit register accesses. This prevents devices that > only do 16 or 32bit register accesses from working. By simply checking > this field and setting the mmio strin

[PATCH] docs: complete bumping minimal GNU Make version to 3.81

2017-05-06 Thread Max Filippov
Commit 37d69ee3080811 ("docs: bump minimal GNU Make version to 3.81") changes one entry of GNU make version in the changes.rst, there's still one more entry saying that one need version 3.80. Fix that. Signed-off-by: Max Filippov --- Documentation/process/changes.rst | 2 +- 1 file changed, 1 in

[PATCH] scsi: lpfc: ensure els_wq is being checked before destroying it

2017-05-06 Thread Colin King
From: Colin Ian King I believe there is a typo on the wq destroy of els_wq, currently the driver is checking if els_cq is not null and I think this should be a check on els_wq instead. Detected by CoverityScan, CID#1411629 ("Copy-paste error") Signed-off-by: Colin Ian King --- drivers/scsi/lp

Re: [PATCH V6 1/9] PM / OPP: Introduce "power-domain-opp" property

2017-05-06 Thread Kevin Hilman
Rob Herring writes: > On Wed, Apr 26, 2017 at 04:27:05PM +0530, Viresh Kumar wrote: >> Power-domains need to express their active states in DT and the devices >> within the power-domain need to express their dependency on those active >> states. The power-domains can use the OPP tables without an

Re: [PATCH V6 1/9] PM / OPP: Introduce "power-domain-opp" property

2017-05-06 Thread Kevin Hilman
Sudeep Holla writes: > On 28/04/17 21:48, Rob Herring wrote: >> On Wed, Apr 26, 2017 at 04:27:05PM +0530, Viresh Kumar wrote: >>> Power-domains need to express their active states in DT and the devices >>> within the power-domain need to express their dependency on those active >>> states. The po

[PATCH 4.9 0/9] 4.9.27-stable review

2017-05-06 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.9.27 release. There are 9 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Mon May 8 20:38:28 UTC 2017. Anything received

[PATCH 4.9 2/9] Handle mismatched open calls

2017-05-06 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Sachin Prabhu commit 38bd49064a1ecb67baad33598e3d824448ab11ec upstream. A signal can interrupt a SendReceive call which result in incoming responses to the call being ignored. This is a problem

[PATCH 4.9 3/9] tpm_tis: use default timeout value if chip reports it as zero

2017-05-06 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Maciej S. Szmigiero commit 1d70fe9d9c3a4c627f9757cbba5d628687b121c1 upstream. Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM access") Atmel 3203 TPM on ThinkPad X61S

[PATCH 4.10 1/5] timerfd: Protect the might cancel mechanism proper

2017-05-06 Thread Greg Kroah-Hartman
4.10-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Gleixner commit 1e38da300e1e395a15048b0af1e5305bd91402f6 upstream. The handling of the might_cancel queueing is not properly protected, so parallel operations on the file descriptor can

[PATCH 4.9 8/9] cpu/hotplug: Serialize callback invocations proper

2017-05-06 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior commit dc434e056fe1dada20df7ba07f32739d3a701adf upstream. The setup/remove_state/instance() functions in the hotplug core code are serialized against concurrent CPU ho

[PATCH 4.9 4/9] scsi: storvsc: Workaround for virtual DVD SCSI version

2017-05-06 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Stephen Hemminger commit f1c635b439a5c01776fe3a25b1e2dc546ea82e6f upstream. Hyper-V host emulation of SCSI for virtual DVD device reports SCSI version 0 (UNKNOWN) but is still capable of suppor

[PATCH 4.9 6/9] 8250_pci: Fix potential use-after-free in error path

2017-05-06 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Gabriel Krisman Bertazi commit c130b666a9a711f985a0a44b58699ebe14bb7245 upstream. Commit f209fa03fc9d ("serial: 8250_pci: Detach low-level driver during PCI error recovery") introduces a potent

[PATCH 4.9 9/9] dm ioctl: prevent stack leak in dm ioctl call

2017-05-06 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Adrian Salido commit 4617f564c06117c7d1b611be49521a4430042287 upstream. When calling a dm ioctl that doesn't process any data (IOCTL_FLAGS_NO_PARAMS), the contents of the data field in struct d

[PATCH 4.9 7/9] ceph: try getting buffer capability for readahead/fadvise

2017-05-06 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Yan, Zheng commit 2b1ac852eb67a6e95595e576371d23519105559f upstream. For readahead/fadvise cases, caller of ceph_readpages does not hold buffer capability. Pages can be added to page cache whil

[PATCH 4.9 5/9] hwmon: (it87) Avoid registering the same chip on both SIO addresses

2017-05-06 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Guenter Roeck commit 8358378b22518d92424597503d3c1cd302a490b6 upstream. IT8705F is known to respond on both SIO addresses. Registering it twice may result in system lockups. Reported-by: Russe

[PATCH 4.9 1/9] timerfd: Protect the might cancel mechanism proper

2017-05-06 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Gleixner commit 1e38da300e1e395a15048b0af1e5305bd91402f6 upstream. The handling of the might_cancel queueing is not properly protected, so parallel operations on the file descriptor can

[PATCH 4.10 5/5] dm ioctl: prevent stack leak in dm ioctl call

2017-05-06 Thread Greg Kroah-Hartman
4.10-stable review patch. If anyone has any objections, please let me know. -- From: Adrian Salido commit 4617f564c06117c7d1b611be49521a4430042287 upstream. When calling a dm ioctl that doesn't process any data (IOCTL_FLAGS_NO_PARAMS), the contents of the data field in struct

[PATCH 4.10 4/5] hwmon: (it87) Avoid registering the same chip on both SIO addresses

2017-05-06 Thread Greg Kroah-Hartman
4.10-stable review patch. If anyone has any objections, please let me know. -- From: Guenter Roeck commit 8358378b22518d92424597503d3c1cd302a490b6 upstream. IT8705F is known to respond on both SIO addresses. Registering it twice may result in system lockups. Reported-by: Russ

[PATCH 4.10 2/5] Handle mismatched open calls

2017-05-06 Thread Greg Kroah-Hartman
4.10-stable review patch. If anyone has any objections, please let me know. -- From: Sachin Prabhu commit 38bd49064a1ecb67baad33598e3d824448ab11ec upstream. A signal can interrupt a SendReceive call which result in incoming responses to the call being ignored. This is a proble

[PATCH 4.10 3/5] scsi: storvsc: Workaround for virtual DVD SCSI version

2017-05-06 Thread Greg Kroah-Hartman
4.10-stable review patch. If anyone has any objections, please let me know. -- From: Stephen Hemminger commit f1c635b439a5c01776fe3a25b1e2dc546ea82e6f upstream. Hyper-V host emulation of SCSI for virtual DVD device reports SCSI version 0 (UNKNOWN) but is still capable of suppo

[PATCH 4.10 0/5] 4.10.15-stable review

2017-05-06 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.10.15 release. There are 5 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Mon May 8 20:38:36 UTC 2017. Anything receive

Re: [PATCH 3/3] staging: rtl8723bs: fix up for cfg80211_roamed() API change

2017-05-06 Thread kbuild test robot
Hi Stephen, [auto build test ERROR on staging/staging-testing] [cannot apply to v4.11 next-20170505] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Greg-KH/staging-rtl8723bs-merge-fix-for-add-ch

Re: [PATCH 2/3] staging: rtl8723bs: merge fix for "nl80211: allow multiple active scheduled scan requests"

2017-05-06 Thread kbuild test robot
Hi Stephen, [auto build test ERROR on staging/staging-testing] [cannot apply to v4.11 next-20170505] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Greg-KH/staging-rtl8723bs-merge-fix-for-add-ch

Re: [PATCH] staging: lustre: llite: Fix variable length array warning

2017-05-06 Thread Guru Das Srinagesh
On Fri, May 05, 2017 at 01:52:36AM -0700, Joe Perches wrote: > On Thu, 2017-05-04 at 23:41 -0700, Guru Das Srinagesh wrote: > > Fix sparse warning "warning: Variable length array is used." by using > > kmalloc_array to allocate the required amount of memory instead and > > kfree to deallocate memor

Re: [git pull] drm pull for v4.12

2017-05-06 Thread Linus Torvalds
On Tue, May 2, 2017 at 8:44 PM, Dave Airlie wrote: > > i915: > vblank evasion improvements These may be "improvements", but they end up being very noisy. I geta fair amount of messages like [drm] Atomic update on pipe (A) took 161 us, max time under evasion is 100 us on my desktop (i7-6700K)

Re: [PATCH] kthread: fix use-after-free if kthread fork fails

2017-05-06 Thread Oleg Nesterov
On 05/05, Vegard Nossum wrote: > > On 05/05/17 18:44, Oleg Nesterov wrote: > > > >Can't we just move both > > > > p->set_child_tid = (clone_flags & CLONE_CHILD_SETTID) ? child_tidptr : > > NULL; > > /* > > * Clear TID on mm_release()? > > */ > > p->clear_child_tid = (clone_fl

[PATCH 3/3] kernel-sched: Combine two seq_printf() calls into one in show_schedstat()

2017-05-06 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 6 May 2017 21:26:19 +0200 Some data were put into a sequence by two separate function calls. Print the same data by a single function call instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- kernel/sched/stats.c

[PATCH 2/3] kernel-sched: Adjust four checks for null pointers

2017-05-06 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 6 May 2017 21:17:36 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code pla

Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules

2017-05-06 Thread Oleg Nesterov
On 05/05, Geert Uytterhoeven wrote: > > I'm using signal_wake_up() to abort a task blocked on > wait_for_completion_interruptible(), cfr. sh_msiof_slave_abort() in > "spi: sh-msiof: Add slave mode support" > (http://www.spinics.net/lists/devicetree/msg175575.html). > > Is exporting signal_wake_up_s

[PATCH 1/3] kernel-sched: Use seq_putc() in three functions

2017-05-06 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 6 May 2017 20:45:35 +0200 Four single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- kernel/sched/cpuacct.c | 6

[PATCH 0/3] kernel-sched: Fine-tuning for eight function implementations

2017-05-06 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 6 May 2017 21:35:45 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use seq_putc() in three functions Adjust four checks for null pointers Combine two seq_printf() calls into one in show_schedstat(

Re: [PATCH] pinctrl: imx: Check for memory allocation failure

2017-05-06 Thread Stafford Horne
Hi Christophe, On Sat, May 06, 2017 at 10:23:59AM +0200, Christophe JAILLET wrote: > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > Return -ENOMEM instead, as done for the other memory allocation just a > few lines below. This looks fine. > BTW, change the 'devm_kzalloc' into a

Re: [PATCH 2/2] arm64:vdso: Remove ISB from gettimeofday.

2017-05-06 Thread Jon Masters
Quick reply - didn't realize it could be speculatively read as described, but I should have. Makes sense now, thanks. -- Computer Architect | Sent from my 64-bit #ARM Powered phone > On May 6, 2017, at 13:38, Pinski, Andrew wrote: > > Sorry sending again as plain text (I did not notice that b

Re: [PATCH] scsi: qedf: Avoid reading past end of buffer

2017-05-06 Thread Chad Dupuis
On Fri, 5 May 2017, 7:10pm, Kees Cook wrote: > On Fri, May 5, 2017 at 4:01 PM, Bart Van Assche > wrote: > > On Fri, 2017-05-05 at 15:42 -0700, Kees Cook wrote: > >> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c > >> index cceddd995a4b..a5c97342fd5d 100644 > >> --- a/

Re: [4.12.0-rc0]: compile error in initramfs.c

2017-05-06 Thread Stafford Horne
On Sat, May 06, 2017 at 10:39:01AM -0700, Linus Torvalds wrote: > On Sat, May 6, 2017 at 10:28 AM, Randy Dunlap wrote: > > > > A fix was posted here: > > http://marc.info/?l=linux-kernel&m=149405418520059&w=2 > > That looks like it will just cause a warning instead ("unused label"). > > The prop

Re: [RFC PATCH] x86/boot: Add the secdata section to the setup header

2017-05-06 Thread hpa
On May 6, 2017 10:34:49 AM PDT, Brian Gerst wrote: >On Fri, May 5, 2017 at 5:26 AM, Gary Lin wrote: >> This is a different approach to replace my previous implementation of >> Security Version(*). Instead of using the fields in the PE/COFF >header, >> this commit adds secdata_offset in the setup

Re: [PATCH] Input: psxpad-spi - Add PlayStation 1/2 joypads via SPI interface Driver

2017-05-06 Thread Tomohiro Yoshidomi
Mr.Torokhov Mr.Herrmann Sorry, I sent Playstation 1/2 joypads patch again. Mr.Torokhov's Reviewed-by added. Best regard. 2017-05-07 3:41 GMT+09:00 Tomohiro Yoshidomi : > PlayStation 1/2 joypads can be connected directly to the SPI interface. > > Signed-off-by: Tomohiro Yoshidomi > Reviewed-by:

[PATCH] Input: psxpad-spi - Add PlayStation 1/2 joypads via SPI interface Driver

2017-05-06 Thread Tomohiro Yoshidomi
PlayStation 1/2 joypads can be connected directly to the SPI interface. Signed-off-by: Tomohiro Yoshidomi Reviewed-by: Dmitry Torokhov Acked-by: David Herrmann --- drivers/input/joystick/Kconfig | 22 ++ drivers/input/joystick/Makefile | 1 + drivers/input/joystick/psxpad-spi.c | 4

Re: [PATCH] Input: psxpad-spi - Add PlayStation 1/2 joypads via SPI interface Driver

2017-05-06 Thread Tomohiro Yoshidomi
Mr.Torokhov Mr.Herrmann I sent Playstation 1/2 joypads patch, Mr.Hrrmann's Ack-by added. Best regard.

Re: [PATCH v7] Input: psxpad-spi - Add PlayStation 1/2 joypads via SPI interface Driver

2017-05-06 Thread Tomohiro Yoshidomi
Mr.Torokhov Mr.Herrmann I sent Playstation 1/2 joypads patch, Mr.Hrrmann's Ack-by added. Best regard.

[PATCH] Input: psxpad-spi - Add PlayStation 1/2 joypads via SPI interface Driver

2017-05-06 Thread Tomohiro Yoshidomi
PlayStation 1/2 joypads can be connected directly to the SPI interface. Signed-off-by: Tomohiro Yoshidomi Acked-by: David Herrmann --- drivers/input/joystick/Kconfig | 22 ++ drivers/input/joystick/Makefile | 1 + drivers/input/joystick/psxpad-spi.c | 438 +++

Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1

2017-05-06 Thread James Bottomley
On Sat, 2017-05-06 at 11:00 -0700, Linus Torvalds wrote: > On Fri, May 5, 2017 at 10:09 PM, Stephen Rothwell < > s...@canb.auug.org.au> wrote: > > > > On Fri, 5 May 2017 13:01:34 -0700 Linus Torvalds < > > torva...@linux-foundation.org> wrote: > > > > > > > > > I prefer doing merge resolutions m

[PATCH v3] backlight: report error on failure

2017-05-06 Thread Sudip Mukherjee
It is possible to update the backlight power and the brightness using the sysfs and on writing it either returns the count or if the callback function does not exist then returns the error code 'ENXIO'. We have a situation where the userspace client is writing to the sysfs to update the power and

Re: [GIT PULL] Char/Misc driver patches for 4.12-rc1

2017-05-06 Thread Linus Torvalds
On Fri, May 5, 2017 at 10:09 PM, Stephen Rothwell wrote: > > On Fri, 5 May 2017 13:01:34 -0700 Linus Torvalds > wrote: >> >> >> I prefer doing merge resolutions myself, but I *also* really really >> prefer the two sides of the conflict having been more aware of the >> clash. > > Would that be th

Re: [PATCH] usb: cdc-wdm: use memdup_user

2017-05-06 Thread Bjørn Mork
Geliang Tang writes: > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang > --- > drivers/usb/class/cdc-wdm.c | 15 +++ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/cl

Re: [4.12.0-rc0]: compile error in initramfs.c

2017-05-06 Thread Linus Torvalds
On Sat, May 6, 2017 at 10:28 AM, Randy Dunlap wrote: > > A fix was posted here: > http://marc.info/?l=linux-kernel&m=149405418520059&w=2 That looks like it will just cause a warning instead ("unused label"). The proper fix is to just add an empty statement. Pushing that out. Lin

RE: [PATCH 2/2] arm64:vdso: Remove ISB from gettimeofday.

2017-05-06 Thread Pinski, Andrew
Sorry sending again as plain text (I did not notice that before). On 5/6/2017 9:29 AM, Jon Masters wrote: On 04/23/2017 07:47 PM, Andrew Pinski wrote: > ISB is normally required before mrs CNTVCT if we want the > mrs to completed after the loads. In this case it is not. > As we are taking the diff

Re: [RFC PATCH] x86/boot: Add the secdata section to the setup header

2017-05-06 Thread Brian Gerst
On Fri, May 5, 2017 at 5:26 AM, Gary Lin wrote: > This is a different approach to replace my previous implementation of > Security Version(*). Instead of using the fields in the PE/COFF header, > this commit adds secdata_offset in the setup header for the file offset > of secdata. Currently, the s

Re: [4.12.0-rc0]: compile error in initramfs.c

2017-05-06 Thread Linus Torvalds
On Sat, May 6, 2017 at 8:40 AM, Jörg Otte wrote: > In kernel 4.11.0-10502-g3ef2bc0 I get following compile error: > > /kernel/linux/init/initramfs.c: In function 'populate_rootfs': > /kernel/linux/init/initramfs.c:644:2: error: label at end of compound > statement > done: Ok,need to add an emp

Re: GPU-DRM-STI: Fine-tuning for some function implementations

2017-05-06 Thread SF Markus Elfring
>> 1. I suggest to combine a few functions into fewer ones. >>* Do you spot any programming mistakes in these concrete cases? > > Not in the patches I skimmed. Thanks for such feedback. > However, your history of breaking code tells me that there have been mistakes > missed in the past. I

Re: [PATCH 1/2] kbuild: clang: Disable 'address-of-packed-member' warning

2017-05-06 Thread Masahiro Yamada
Hi Matthias, 2017-05-02 10:23 GMT+09:00 Matthias Kaehlcke : > Hi Masahiro, > > El Sun, Apr 30, 2017 at 10:59:52PM +0900 Masahiro Yamada ha dit: > >> 2017-04-22 6:39 GMT+09:00 Matthias Kaehlcke : >> > clang generates plenty of these warnings in different parts of the code, >> > to an extent that t

Re: FYI, tiny-kernel fix for rcu_segcblist separate .c file

2017-05-06 Thread Paul E. McKenney
On Sat, May 06, 2017 at 09:15:51AM +0200, Ingo Molnar wrote: > > * Paul E. McKenney wrote: > > > Hello, Ingo, > > > > Just in case you get complaints about kernel size... > > > > In response to Linus's feedback, I did commit 98059b98619d ("rcu: > > Separately compile large rcu_segcblist functi

Re: [PATCH 0/4] KVM: x86: kvm_mwait_in_guest() cleanup and fixes

2017-05-06 Thread Gabriel L. Somlo
On Thu, May 04, 2017 at 08:07:15PM +0200, Radim Krčmář wrote: > 2017-05-04 13:56-0400, Gabriel L. Somlo: > > If I wanted to test this (e.g. with OS X 10.8 guests on several of my older > > Mac boxes running Fedora), which git repo would you have me use? (The series > > won't apply directly on top o

[GIT PULL] xfs: updates for 4.12

2017-05-06 Thread Darrick J. Wong
Hi Linus, Here are the XFS changes for 4.12. The big new feature for this release is the new space mapping ioctl that we've been discussing since LSF2016, but other than that most of the patches are larger bug fixes, memory corruption prevention, and other cleanups. I tried a test merge against

Re: [rcu:dev.2017.05.04c 87/92] include/linux/spinlock_api_smp.h:160:2: note: in expansion of macro 'local_irq_restore'

2017-05-06 Thread Paul E. McKenney
On Sat, May 06, 2017 at 09:33:37PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > dev.2017.05.04c > head: b015d142a08cdd2b69b9a59dd664a14a64e383bb > commit: 7683511c453ce2bb1b7d30fde281ecdacca04f6b [87/92] rcu: Move ktime > need

Re: [PATCH 2/2] arm64:vdso: Remove ISB from gettimeofday.

2017-05-06 Thread Jon Masters
On 04/23/2017 07:47 PM, Andrew Pinski wrote: > ISB is normally required before mrs CNTVCT if we want the > mrs to completed after the loads. In this case it is not. > As we are taking the difference and if that difference > was going to be negative, we just use the last counter value > instead. >

[PATCH 2/2] batman-adv: Combine two seq_puts() calls into one call in batadv_nc_nodes_seq_print_text()

2017-05-06 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 6 May 2017 17:57:36 +0200 A bit of text was put into a sequence by two separate function calls. Print the same data by a single function call instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/batman-adv/net

[PATCH 1/2] batman-adv: Replace a seq_puts() call by seq_putc() in two functions

2017-05-06 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 6 May 2017 17:50:13 +0200 Two single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/batman-adv/bat_iv_ogm.c

[PATCH 0/2] batman-adv: Fine-tuning for three function implementations

2017-05-06 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 6 May 2017 18:03:45 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Replace a seq_puts() call by seq_putc() in two functions Combine two seq_puts() calls into one call in batadv_nc_nodes_seq_print_text

Re: [PATCH v2] tags: honor COMPILED_SOURCE with apart output directory

2017-05-06 Thread Masahiro Yamada
Hi Robert, 2017-05-04 15:29 GMT+09:00 Robert Jarzmik : > Masahiro Yamada writes: > >> Hi Robert, >> >> 2017-04-26 5:07 GMT+09:00 Robert Jarzmik : >>> Masahiro Yamada writes: >>> Hi Robert, > diff --git a/scripts/tags.sh b/scripts/tags.sh > index a2ff3388e5ea..35cb64d5211c 100755 >>>

[PATCH] wil6210: use memdup_user

2017-05-06 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/net/wireless/ath/wil6210/debugfs.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath

[PATCH] net/hippi/rrunner: use memdup_user

2017-05-06 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/net/hippi/rrunner.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c index 9b0d614..1ce623

[PATCH] wlcore: use memdup_user

2017-05-06 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/net/wireless/ti/wlcore/debugfs.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wl

[PATCH] xfrm: use memdup_user

2017-05-06 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- net/xfrm/xfrm_state.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index fc3c5aa..5780cda 100644 --- a/net/xfrm/x

[PATCH] usb: cdc-wdm: use memdup_user

2017-05-06 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/class/cdc-wdm.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index 08669fe..0e4f18c

[PATCH] yam: use memdup_user

2017-05-06 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/net/hamradio/yam.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index b6891ad..7a7c522 100644 --

[PATCH] spi: spidev: use memdup_user

2017-05-06 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/spi/spidev.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 9a2a79a..b00a88f 100644 --- a/drivers/spi/spi

[PATCH] agp: use memdup_user

2017-05-06 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/char/agp/compat_ioctl.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/char/agp/compat_ioctl.c b/drivers/char/agp/compat_ioctl.c index 2053f7

[PATCH] docs: bump minimal GNU Make version to 3.81

2017-05-06 Thread Masahiro Yamada
Recent kernel versions have broken compatibility with GNU Make version 3.80 here and there: $ git describe v4.11 $ make --version | head -1 GNU Make 3.80 $ make defconfig HOSTCC scripts/basic/fixdep scripts/Makefile.host:135: *** missing separator. Stop. make: *** [defconfig] E

[4.12.0-rc0]: compile error in initramfs.c

2017-05-06 Thread Jörg Otte
In kernel 4.11.0-10502-g3ef2bc0 I get following compile error: /kernel/linux/init/initramfs.c: In function 'populate_rootfs': /kernel/linux/init/initramfs.c:644:2: error: label at end of compound statement done: the compile error goes away if I revert commit 17a9be31747535184f2af156b1f080ec4c92

[PATCH] sparc: use memdup_user_nul in sun4m LED driver

2017-05-06 Thread Geliang Tang
Use memdup_user_nul() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- arch/sparc/kernel/led.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/arch/sparc/kernel/led.c b/arch/sparc/kernel/led.c index 44a3ed9..e278bf5 100644 ---

[PATCH] platform/x86: toshiba_acpi: use memdup_user_nul

2017-05-06 Thread Geliang Tang
Use memdup_user_nul() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/platform/x86/toshiba_acpi.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c

[PATCH] ima: use memdup_user_nul

2017-05-06 Thread Geliang Tang
Use memdup_user_nul() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- security/integrity/ima/ima_fs.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/security/integrity/ima/ima_fs.c b/security/integrity/ima/ima_fs.c index ca30

[PATCH] drm/i915: use memdup_user_nul

2017-05-06 Thread Geliang Tang
Use memdup_user_nul() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/gpu/drm/i915/i915_debugfs.c | 13 +++-- drivers/gpu/drm/i915/intel_pipe_crc.c | 13 +++-- 2 files changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/gp

[PATCH v2] dm bio prison: use rb_entry()

2017-05-06 Thread Geliang Tang
To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang Acked-by: Coly Li --- Changes in v2: - Apply to dm-bio-prison-v1.c and dm-bio-prison-v2.c --- drivers/md/dm-bio-prison-v1.c | 2 +- drivers/md/dm-bio-prison-v2.c | 2 +- 2 files

[PATCH] powerpc/cell: set no_llseek in spufs_cntl_fops

2017-05-06 Thread Geliang Tang
In spufs_cntl_fops, since we use nonseekable_open() to open, we should use no_llseek() to seek, not generic_file_llseek(). Signed-off-by: Geliang Tang --- arch/powerpc/platforms/cell/spufs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/cell/spuf

[PATCH] KVM: set no_llseek in stat_fops_per_vm

2017-05-06 Thread Geliang Tang
In vm_stat_get_per_vm_fops and vcpu_stat_get_per_vm_fops, since we use nonseekable_open() to open, we should use no_llseek() to seek, not generic_file_llseek(). Signed-off-by: Geliang Tang --- virt/kvm/kvm_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/virt/kvm/kv

[PATCH] fs: set no_llseek in DEFINE_SIMPLE_ATTRIBUTE

2017-05-06 Thread Geliang Tang
In DEFINE_SIMPLE_ATTRIBUTE() macro, since we use nonseekable_open() to open, we should use no_llseek() to seek, not generic_file_llseek(). Signed-off-by: Geliang Tang --- include/linux/fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fs.h b/include/linux/fs.

[PATCH] crypto: mediatek - drop .owner field in mtk_crypto_driver

2017-05-06 Thread Geliang Tang
Drop .owner field in mtk_crypto_driver, since platform_driver_register() will set it automatically. Signed-off-by: Geliang Tang --- drivers/crypto/mediatek/mtk-platform.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/mediatek/mtk-platform.c b/drivers/crypto/mediatek/mtk-plat

[PATCH] lightnvm: fix error return code of memdup_user

2017-05-06 Thread Geliang Tang
The error return code of memdup_user() should be -ENOMEM or -EFAULT. So this patch changed it to PTR_ERR(info). Signed-off-by: Geliang Tang --- drivers/lightnvm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index 54a0

[PATCH V4] hwmon: (ibmpowernv) Add highest/lowest attributes to sensors

2017-05-06 Thread Shilpasri G Bhat
OCC provides historical minimum and maximum value for the sensor readings. This patch exports them as highest and lowest attributes for the inband sensors copied by OCC to main memory. Signed-off-by: Shilpasri G Bhat --- Changes from V3: - Removed extra variable 'hwmon_index' - Retain the initial

Re: [PATCH] kernel/cpu.c: fix many errors related to style.

2017-05-06 Thread Joe Perches
On Sat, 2017-05-06 at 17:09 +0200, Matej Dujava wrote: > This patch fixes the checkpatch.pl warning: > ERROR: spaces required around that '=' (ctx:VxW) > WARNING: Block comments use a trailing */ on a separate line > CHECK: Please don't use multiple blank lines > CHECK: Blank lines aren't necessary

Re: GPU-DRM-STI: Fine-tuning for some function implementations

2017-05-06 Thread Sean Paul
On Sat, May 06, 2017 at 03:54:51PM +0200, SF Markus Elfring wrote: > > Generally speaking, I don't care about checkpatch/cocci changes that aren't > > tested. > > I find this view interesting only to some degree. We're bordering on becoming unproductive here, but I'll try once more. > > 1. I s

[PATCH] kernel/cpu.c: fix many errors related to style.

2017-05-06 Thread Matej Dujava
This patch fixes the checkpatch.pl warning: ERROR: spaces required around that '=' (ctx:VxW) WARNING: Block comments use a trailing */ on a separate line CHECK: Please don't use multiple blank lines CHECK: Blank lines aren't necessary before a close brace '}' CHECK: braces {} should be used on all

Re: [PATCH v2] clk: sunxi-ng: v3s: Fix usb otg device reset bit

2017-05-06 Thread icenowy
在 2017-05-06 04:04,Maxime Ripard 写道: Hi, On Fri, May 05, 2017 at 06:31:57PM +0800, Yong Deng wrote: V3S's usb otg device reset bit should be 24, not 23. Signed-off-by: Yong Deng Reviewed-By: Icenowy Zheng Applied, thanks. Maxime Maybe it should also apply to 4.11 stable? Cc: sta...@vger

Re: [GIT PULL] Staging/IIO driver fixes for 4.12-rc1

2017-05-06 Thread Greg KH
On Sun, May 07, 2017 at 12:21:17AM +1000, Ian W MORRISON wrote: > > On 5/6/17 11:41 PM, Greg KH wrote: > > On Sat, May 06, 2017 at 06:00:24PM +1000, Ian W MORRISON wrote: > > > The kernel when booted with Ubuntu 17.04 results in an unusable system > > > however with the following patch booting is

Re: [PATCH] net: dsa: loop: Check for memory allocation failure

2017-05-06 Thread Andrew Lunn
On Sat, May 06, 2017 at 07:29:45AM +0200, Christophe JAILLET wrote: > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > Return -ENOMEM instead, as done for some other memory allocation just a > few lines above. > > Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver") > > Signed-off-by:

Re: [PATCH 7/7] DWARF: add the config option

2017-05-06 Thread Jiri Kosina
[ adding Josh to CC ] On Fri, 5 May 2017, Linus Torvalds wrote: > > The DWARF unwinder is in place and ready. So introduce the config option > > to allow users to enable it. It is by default off due to missing > > assembly annotations. > > Who actually ends up using this? As a datapoint -- we'

Re: [PATCH 00/10] fujitsu-laptop: use device-specific data instead of module-wide globals

2017-05-06 Thread Andy Shevchenko
On Sat, May 6, 2017 at 5:21 PM, Andy Shevchenko wrote: > On Sat, May 6, 2017 at 3:45 PM, Michał Kępień wrote: > >> To be fair, one thing that may be "unnatural" with this approach is that >> even though fujitsu-backlight would depend on fujitsu-laptop, it would >> still have to get a handle to FU

Re: [PATCH 00/10] fujitsu-laptop: use device-specific data instead of module-wide globals

2017-05-06 Thread Andy Shevchenko
On Sat, May 6, 2017 at 3:45 PM, Michał Kępień wrote: > To be fair, one thing that may be "unnatural" with this approach is that > even though fujitsu-backlight would depend on fujitsu-laptop, it would > still have to get a handle to FUJ02E3 using: > > acpi_get_handle(NULL, "\\_SB.FEXT", ...)

Re: [GIT PULL] Staging/IIO driver fixes for 4.12-rc1

2017-05-06 Thread Ian W MORRISON
On 5/6/17 11:41 PM, Greg KH wrote: On Sat, May 06, 2017 at 06:00:24PM +1000, Ian W MORRISON wrote: The kernel when booted with Ubuntu 17.04 results in an unusable system however with the following patch booting is successful and the system is usable. The patch and kernel builds have been tested

[PATCH] Staging: greybus: Prefer kcalloc over kzalloc

2017-05-06 Thread karthik
From: Karthik Tummala Fixed following checkpatch.pl warning: * WARNING: Prefer kcalloc over kzalloc with multiply Instead of specifying no.of bytes * size as arugment in kzalloc, prefer kcalloc. Signed-off-by: Karthik Tummala --- drivers/staging/greybus/light.c | 4 ++-- 1 file changed, 2 in

Re: [PATCH v2] x86, uaccess: introduce copy_from_iter_wt for pmem / writethrough operations

2017-05-06 Thread Dan Williams
On Sat, May 6, 2017 at 2:46 AM, Ingo Molnar wrote: > > * Dan Williams wrote: > >> On Fri, May 5, 2017 at 3:44 PM, Kani, Toshimitsu wrote: >> > On Fri, 2017-05-05 at 15:25 -0700, Dan Williams wrote: >> >> On Fri, May 5, 2017 at 1:39 PM, Kani, Toshimitsu >> >> wrote: >> > : >> >> > > --- >> >> >

  1   2   >