Re: [PATCH 3.18 000/145] 3.18.49-stable review

2017-04-16 Thread Greg Kroah-Hartman
On Sun, Apr 16, 2017 at 04:30:32PM -0700, Guenter Roeck wrote: > On 04/16/2017 03:48 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 3.18.49 release. > > There are 145 patches in this series, all will be posted as a response > > to this one. If anyone has any

Re: [PATCH 3/4] restrict unprivileged TIOCSTI tty ioctl

2017-04-16 Thread Greg KH
On Mon, Apr 17, 2017 at 02:07:05AM -0400, Matt Brown wrote: > this patch depends on patch 1 and 2 > > enforces restrictions on unprivileged users injecting commands > into other processes in the same tty session using the TIOCSTI ioctl > > Signed-off-by: Matt Brown > --- > drivers/tty/tty_io.c

Re: [PATCH v4 2/2] vfio/type1: Prune vfio_pin_page_external()

2017-04-16 Thread Peter Xu
On Sun, Apr 16, 2017 at 07:42:39PM -0600, Alex Williamson wrote: > With vfio_lock_acct() testing the locked memory limit under mmap_sem, > it's redundant to do it here for a single page. We can also reorder > our tests such that we can avoid testing for reserved pages if we're > not doing accounti

Re: [PATCH 2/4] add tiocsti_restrict variable

2017-04-16 Thread Greg KH
On Mon, Apr 17, 2017 at 02:07:04AM -0400, Matt Brown wrote: > adding extern variable tiocsti_restrict to allow it to be included > in sysctl > > Signed-off-by: Matt Brown > --- > include/linux/tty.h | 2 ++ > 1 file changed, 2 insertions(+) I'm all for breaking up changes to be tiny logical pie

Re: [PATCH 1/4] added SECURITY_TIOCSTI_RESTRICT kernel config

2017-04-16 Thread Greg KH
On Mon, Apr 17, 2017 at 02:07:03AM -0400, Matt Brown wrote: > adding the kernel config SECURITY_TIOCSTI_RESTRICT in order to allow > the user to restrict unprivileged command injection using TIOCSTI > tty ioctls "unpriviledged command injection"? That sounds a bit "odd", don't you think? > > Si

Re: [patch 20/20] cpu/hotplug: Convert hotplug locking to percpu rwsem

2017-04-16 Thread Peter Zijlstra
On Sat, Apr 15, 2017 at 07:01:27PM +0200, Thomas Gleixner wrote: > There are no more (known) nested calls to get_online_cpus() so it's > possible to remove the nested call magic and convert the mutex to a > percpu-rwsem, which speeds up get/put_online_cpus() significantly for the > uncontended case

Re: [PATCH v4 1/2] vfio/type1: Remove locked page accounting workqueue

2017-04-16 Thread Peter Xu
On Sun, Apr 16, 2017 at 07:42:27PM -0600, Alex Williamson wrote: [...] > -static void vfio_lock_acct(struct task_struct *task, long npage) > +static int vfio_lock_acct(struct task_struct *task, long npage, bool > lock_cap) > { > - struct vwork *vwork; > struct mm_struct *mm; > b

Re: [patch 17/20] PCI: Use cpu_hotplug_disable() instead of get_online_cpus()

2017-04-16 Thread Peter Zijlstra
On Sat, Apr 15, 2017 at 07:01:24PM +0200, Thomas Gleixner wrote: > +++ b/drivers/pci/pci-driver.c > @@ -320,10 +320,19 @@ static long local_pci_probe(void *_ddi) > return 0; > } > > +static bool pci_physfn_is_probed(struct pci_dev *dev) > +{ > +#ifdef CONFIG_ATS > + return dev->physfn-

Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

2017-04-16 Thread Ilia Mirkin
On Tue, Apr 11, 2017 at 10:18 AM, Ilia Mirkin wrote: >> However, I totally agree with Alex that someone with a BE machine >> should review the whole stack before we could be confident with anything. > > Here's what I'm confident about: xf86-video-nouveau worked just fine > on top of kernel 4.3 on

[PATCH] net: cx89x0: move attribute declaration before struct keyword

2017-04-16 Thread Stefan Agner
The attribute declaration is typically before the definition. Move the __maybe_unused attribute declaration before the struct keyword. Signed-off-by: Stefan Agner --- drivers/net/ethernet/cirrus/cs89x0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cir

Re: [PATCH] ARM: dts: dra7: Add power hold and power controller properties to palmas

2017-04-16 Thread Keerthy
On Friday 14 April 2017 07:51 PM, Tony Lindgren wrote: > * Keerthy [170412 21:55]: >> Add power hold and power controller properties to palmas node. >> This is needed to shutdown pmic correctly on boards with >> powerhold set. > > Is this OK to wait for v4.12 or is this needed as a fix for > th

[PATCH 2/4] add tiocsti_restrict variable

2017-04-16 Thread Matt Brown
adding extern variable tiocsti_restrict to allow it to be included in sysctl Signed-off-by: Matt Brown --- include/linux/tty.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/tty.h b/include/linux/tty.h index 1017e904..7011102 100644 --- a/include/linux/tty.h +++ b/include/li

Patchset to Restrict Unprivileged TIOCSTI TTY Command Injection

2017-04-16 Thread Matt Brown
The following patchset reproduces GRKERNSEC_HARDEN_TTY functionality from the grsecurity project in-kernel. The purpose of this feature is to restrict unprivileged users from injecting commands into other processes in the same tty session by using the TIOCSTI ioctl. It creates the kernel config

[PATCH v2 3/3] arm64: dts: exynos: Add support for s6e3hf2 panel device on TM2e board

2017-04-16 Thread Hoegeun Kwon
This patch add the panel device tree node for s6e3hf2 display controller to TM2e dts. Signed-off-by: Hoegeun Kwon --- arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot

[PATCH 1/4] added SECURITY_TIOCSTI_RESTRICT kernel config

2017-04-16 Thread Matt Brown
adding the kernel config SECURITY_TIOCSTI_RESTRICT in order to allow the user to restrict unprivileged command injection using TIOCSTI tty ioctls Signed-off-by: Matt Brown --- security/Kconfig | 12 1 file changed, 12 insertions(+) diff --git a/security/Kconfig b/security/Kconfig i

[PATCH 3/4] restrict unprivileged TIOCSTI tty ioctl

2017-04-16 Thread Matt Brown
this patch depends on patch 1 and 2 enforces restrictions on unprivileged users injecting commands into other processes in the same tty session using the TIOCSTI ioctl Signed-off-by: Matt Brown --- drivers/tty/tty_io.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/tty/tty_io.c

[PATCH 4/4] added kernel.tiocsti_restrict sysctl

2017-04-16 Thread Matt Brown
this patch depends on patches 1, 2 and 3 Allow CONFIG_SECURITY_TIOCSTI_RESTRICT to be controlled via sysctl Signed-off-by: Matt Brown --- kernel/sysctl.c | 12 1 file changed, 12 insertions(+) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index acf0a5a..68d1363 100644 --- a/kerne

[PATCH V2 02/17] thermal: cpu_cooling: rearrange globals

2017-04-16 Thread Viresh Kumar
Just to make it look better. Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index be29489dd247..ce94aafed25d 100644 --- a/drivers/thermal/cpu_cooling.c

[PATCH V2 03/17] thermal: cpu_cooling: Name cpufreq cooling devices as cpufreq_cdev

2017-04-16 Thread Viresh Kumar
Objects of "struct cpufreq_cooling_device" are named a bit inconsistently. Lets use cpufreq_cdev everywhere. Also note that the lists containing such devices is renamed similarly too. Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 248 +-

[PATCH V2 06/17] thermal: cpu_cooling: get rid of a variable in cpufreq_set_cur_state()

2017-04-16 Thread Viresh Kumar
'cpu' is used at only one place and there is no need to keep a separate variable for it. Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index 1f4b6a7

[PATCH V2 08/17] cpufreq: create cpufreq_table_count_valid_entries()

2017-04-16 Thread Viresh Kumar
We need such a routine at two places already, lets create one. Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq_stats.c | 13 - drivers/thermal/cpu_cooling.c | 22 +- include/linux/cpufreq.h | 14 ++ 3 files changed, 27 insertions(+),

[PATCH V2 11/17] thermal: cpu_cooling: get rid of 'allowed_cpus'

2017-04-16 Thread Viresh Kumar
'allowed_cpus' is a copy of policy->related_cpus and can be replaced by it directly. At some places we are only concerned about online CPUs and policy->cpus can be used there. Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 77 --- 1 file c

[PATCH V2 10/17] thermal: cpu_cooling: OPPs are registered for all CPUs

2017-04-16 Thread Viresh Kumar
The OPPs are registered for all CPUs of a cpufreq policy now and we don't need to run the loop in build_dyn_power_table(). Just check for the policy->cpu and we should be fine. Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 26 +++--- 1 file changed, 11 inser

[PATCH V2 13/17] thermal: cpu_cooling: create structure for idle time stats

2017-04-16 Thread Viresh Kumar
We keep two arrays for idle time stats and allocate memory for them separately. It would be much easier to follow if we create an array of idle stats structure instead and allocate it once. Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 53 ---

[PATCH V2 09/17] thermal: cpu_cooling: store cpufreq policy

2017-04-16 Thread Viresh Kumar
The cpufreq policy can be used by the cpu_cooling driver, lets store it in the cpufreq_cooling_device structure. Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c inde

[PATCH V2 14/17] thermal: cpu_cooling: get_level() can't fail

2017-04-16 Thread Viresh Kumar
The frequency passed to get_level() is returned by cpu_power_to_freq() and it is guaranteed that get_level() can't fail. Get rid of error code. Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a

[PATCH V2 17/17] thermal: cpu_cooling: Rearrange struct cpufreq_cooling_device

2017-04-16 Thread Viresh Kumar
This shrinks the size of the structure on arm64 by 8 bytes by avoiding padding of 4 bytes at two places. Also add missing doc comment for freq_table Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/

[PATCH V2 15/17] thermal: cpu_cooling: don't store cpu_dev in cpufreq_cdev

2017-04-16 Thread Viresh Kumar
'cpu_dev' is used by only one function, get_static_power(), and it wouldn't be time consuming to get the cpu device structure within it. This would help removing cpu_dev from struct cpufreq_cooling_device. Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 22 ++

[PATCH V2 12/17] thermal: cpu_cooling: merge frequency and power tables

2017-04-16 Thread Viresh Kumar
The cpu_cooling driver keeps two tables: - freq_table: table of frequencies in descending order, built from policy->freq_table. - power_table: table of frequencies and power in ascending order, built from OPP table. If the OPPs are used for the CPU device then both these tables are actually

[PATCH V2 16/17] thermal: cpu_cooling: 'freq' can't be zero in cpufreq_state2power()

2017-04-16 Thread Viresh Kumar
The frequency table shouldn't have any zero frequency entries and so such a check isn't required. Though it would be better to make sure 'state' is within limits. Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --gi

[PATCH V2 05/17] thermal: cpu_cooling: remove cpufreq_cooling_get_level()

2017-04-16 Thread Viresh Kumar
There is only one user of cpufreq_cooling_get_level() and that already has pointer to the cpufreq_cdev structure. It can directly call get_level() instead and we can get rid of cpufreq_cooling_get_level(). Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 33 +--

[PATCH V2 07/17] thermal: cpu_cooling: use cpufreq_policy to register cooling device

2017-04-16 Thread Viresh Kumar
The CPU cooling driver uses the cpufreq policy, to get clip_cpus, the frequency table, etc. Most of the callers of CPU cooling driver's registration routines have the cpufreq policy with them, but they only pass the policy->related_cpus cpumask. The __cpufreq_cooling_register() routine then gets th

[PATCH V2 04/17] thermal: cpu_cooling: replace cool_dev with cdev

2017-04-16 Thread Viresh Kumar
Objects of "struct thermal_cooling_device" are named a bit inconsistently. Lets use cdev everywhere. Signed-off-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 37 ++--- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/thermal/cpu_cooli

[PATCH v2 1/3] dt-bindings: Add support for samsung s6e3hf2 panel

2017-04-16 Thread Hoegeun Kwon
The samsung s6e3hf2 panel is a 5.65" 1600x2560 AMOLED panel connected using MIPI-DSI interfaces. The s6e3hf2 is add to samsung,s6e3ha2.txt binding because it is a panel similar to the s6e3ha2. So add the compatible string and comments. Signed-off-by: Hoegeun Kwon --- Documentation/devicetree/bi

[PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

2017-04-16 Thread Viresh Kumar
Hi Guys, The cpu_cooling driver is designed to use CPU frequency scaling to avoid high thermal states for a platform. But it wasn't glued really well with cpufreq core. This series tries to improve interactions between cpufreq core and cpu_cooling driver and does some fixes/cleanups to the cpu_co

[PATCH V2 01/17] thermal: cpu_cooling: Avoid accessing potentially freed structures

2017-04-16 Thread Viresh Kumar
After the lock is dropped, it is possible that the cpufreq_dev gets freed before we call get_level() and that can cause kernel to crash. Drop the lock after we are done using the structure. Cc: 4.2+ # 4.2+ Fixes: 02373d7c69b4 ("thermal: cpu_cooling: fix lockdep problems in cpu_cooling") Signed-

[PATCH v2 0/3] Add support for the S6E3HF2 panel on TM2e board

2017-04-16 Thread Hoegeun Kwon
Hi all, First, thanks for Andrzej review. The purpose of this patch is add support for s6e3hf2 AMOLED panel on the TM2e board. The panel has 1600x2560 resolution in 5.65" physical panel in the TM2e device. The s6e3hf2 panel(5.65") is simliar to the previous s6e3ha2 panel(5.7"), but resolution an

[PATCH v2 2/3] drm/panel: s6e3ha2: Add support for s6e3hf2 panel on TM2e board

2017-04-16 Thread Hoegeun Kwon
This patch supports TM2e panel and the panel has 1600x2560 resolution in 5.65" physical. This identify panel type with compatibility string, also invoke display mode that matches the type. So add the check code for s6e3ha2 compatibility and s6e3hf2 type and select the drm_display_mode of default a

Re: [PATCH 1/2] init/main: Fix double "the" in comment

2017-04-16 Thread Viresh Kumar
On 23-03-17, 17:00, Viresh Kumar wrote: > s/the\ the/the > > Signed-off-by: Viresh Kumar > --- > init/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/init/main.c b/init/main.c > index f9c9d9948203..717b2ab803e5 100644 > --- a/init/main.c > +++ b/init/main.c > @@

[PATCH] pci-sysfs: Make PCI bridge attribute visible in sysfs

2017-04-16 Thread Wong Vee Khee
From: vwong Export the PCIe link attributes of PCI bridges to sysfs. Signed-off-by: Wong Vee Khee Signed-off-by: Hui Chun Ong --- drivers/pci/pci-sysfs.c | 197 +- include/uapi/linux/pci_regs.h | 4 + 2 files changed, 197 insertions(+), 4 deleti

Re: [PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on stack

2017-04-16 Thread Viresh Kumar
On 21-03-17, 16:09, Viresh Kumar wrote: > On 21-03-17, 10:37, Jon Hunter wrote: > > > > On 21/03/17 05:24, Viresh Kumar wrote: > > > The size of the struct tegra_powergate is quite big and if any more > > > fields are added to the internal genpd structure, following warnings are > > > thrown: > >

Re: [PATCH] MAINTAINERS: drop akarwar from mwifiex

2017-04-16 Thread amit karwar
On Thu, Apr 13, 2017 at 6:47 PM, Kalle Valo wrote: > Brian Norris writes: > >> His email is bouncing, and I expect he's not doing this work any more. >> >> Cc: Amitkumar Karwar >> Cc: Nishant Sarmukadam >> Cc: Ganapathi Bhat >> Cc: Xinming Hu >> Signed-off-by: Brian Norris >> --- >> Or alter

Re: your mail

2017-04-16 Thread Joonsoo Kim
On Sat, Apr 15, 2017 at 02:17:31PM +0200, Michal Hocko wrote: > Hi, > here I 3 more preparatory patches which I meant to send on Thursday but > forgot... After more thinking about pfn walkers I have realized that > the current code doesn't check offline holes in zones. From a quick > review that do

Re: [RFC/RFT][PATCH 1/2] cpufreq: schedutil: Use policy-dependent transition delays

2017-04-16 Thread Viresh Kumar
On 11-04-17, 00:20, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Make the schedutil governor take the initial (default) value of the > rate_limit_us sysfs attribute from the (new) transition_delay_us > policy parameter (to be set by the scaling driver). > > That will allow scaling driv

Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for power-domains

2017-04-16 Thread Viresh Kumar
On 13-04-17, 14:43, Sudeep Holla wrote: > Interesting. My understand of power domain and in particular power > domain performance was that it would control both. The abstract number > you introduce would hide clocks and regulators. > > But if the concept treats it just as yet another regulator, we

Re: [PATCH V2] mm/madvise: Move up the behavior parameter validation

2017-04-16 Thread Naoya Horiguchi
On Fri, Apr 14, 2017 at 07:21:41PM +0530, Anshuman Khandual wrote: > The madvise_behavior_valid() function should be called before > acting upon the behavior parameter. Hence move up the function. > This also includes MADV_SOFT_OFFLINE and MADV_HWPOISON options > as valid behavior parameter for the

Re: [PATCH V4 1/9] PM / OPP: Allow OPP table to be used for power-domains

2017-04-16 Thread Viresh Kumar
On 13-04-17, 14:42, Sudeep Holla wrote: > What I was referring is about power domain provider with multiple power > domains(simply #power-domain-cells=<1> case as explained in the > power-domain specification. I am not sure if we should be looking to target such a situation for now, as that would

RE: [EXT] Re: [PATCH] MAINTAINERS: drop akarwar from mwifiex

2017-04-16 Thread Ganapathi Bhat
Hi Kalle/Brian, > Brian Norris writes: > > > His email is bouncing, and I expect he's not doing this work any > more. > > > > Cc: Amitkumar Karwar > > Cc: Nishant Sarmukadam > > Cc: Ganapathi Bhat > > Cc: Xinming Hu > > Signed-off-by: Brian Norris > > --- > > Or alternatively, we can update

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-16 Thread Logan Gunthorpe
On 16/04/17 04:32 PM, Benjamin Herrenschmidt wrote: >> I'll consider this. Given the fact I can use your existing >> get_dev_pagemap infrastructure to look up the p2pmem device this >> probably isn't as hard as I thought it would be anyway (we probably >> don't even need a page flag). We'd just h

Re: [PATCH v2 0/15] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

2017-04-16 Thread Takiguchi, Yasunari
On 2017/04/14 10:50, Takiguchi, Yasunari wrote: > From: Yasunari Takiguchi > > Hi, > > This is the patch series (version 2) of Sony CXD2880 DVB-T2/T tuner + > demodulator driver. > The driver supports DVB-API and interfaces through SPI. > > We have tested the driver on Raspberry Pi 3 and got p

Re: [PATCH v2 01/15] [dt-bindings] [media] Add document file for CXD2880 SPI I/F

2017-04-16 Thread Takiguchi, Yasunari
> From: Yasunari Takiguchi > > This is the document file for Sony CXD2880 DVB-T2/T tuner + demodulator. > It contains the description of the SPI adapter binding. > > Signed-off-by: Yasunari Takiguchi > Signed-off-by: Masayuki Yamamoto > Signed-off-by: Hideki Nozawa > Signed-off-by: Kota Yonez

Re: [PATCH v3] powerpc: mm: support ARCH_MMAP_RND_BITS

2017-04-16 Thread Bhupesh SHARMA
On Thu, Apr 13, 2017 at 12:39 PM, Balbir Singh wrote: >>> >>> Yes. It was derived from TASK_SIZE : >>> >>> http://lxr.free-electrons.com/source/arch/powerpc/include/asm/processor.h#L105 >>> >> >> That is getting update to 128TB by default and conditionally to 512TB >> > > Since this is compile tim

Re: [RFC 0/1] add support for reclaiming priorities per mem cgroup

2017-04-16 Thread Minchan Kim
Hi Johannes, On Thu, Apr 13, 2017 at 12:01:47PM -0400, Johannes Weiner wrote: > On Thu, Apr 13, 2017 at 01:30:47PM +0900, Minchan Kim wrote: > > On Thu, Mar 30, 2017 at 12:40:32PM -0700, Tim Murray wrote: > > > As a result, I think there's still a need for relative priority > > > between mem cgrou

Re: [patch 06/20] cpufreq: Use cpuhp_setup_state_nocalls_locked()

2017-04-16 Thread Viresh Kumar
On 15-04-17, 19:01, Thomas Gleixner wrote: > From: Sebastian Andrzej Siewior > > cpufreq holds get_online_cpus() while invoking cpuhp_setup_state_nocalls() > to make subsys_interface_register() and the registration of hotplug calls > atomic versus cpu hotplug. > > cpuhp_setup_state_nocalls() inv

Re: [PATCH v3 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-04-16 Thread Madhavan Srinivasan
On Thursday 13 April 2017 06:08 PM, Peter Zijlstra wrote: On Tue, Apr 11, 2017 at 07:21:05AM +0530, Madhavan Srinivasan wrote: From: Sukadev Bhattiprolu perf_mem_data_src is an union that is initialized via the ->val field and accessed via the bitmap fields. For this to work on big endian pl

Re: [PATCH v3 1/6] powerpc/perf: Define big-endian version of perf_mem_data_src

2017-04-16 Thread Madhavan Srinivasan
On Thursday 13 April 2017 06:53 PM, Michael Ellerman wrote: Peter Zijlstra writes: On Tue, Apr 11, 2017 at 07:21:05AM +0530, Madhavan Srinivasan wrote: From: Sukadev Bhattiprolu perf_mem_data_src is an union that is initialized via the ->val field and accessed via the bitmap fields. For t

Re: [PATCH v1 1/1] mtd: mtk-nor: set controller's address width according to nor flash

2017-04-16 Thread Guochun Mao
Hi Cyrille, On Sun, 2017-04-16 at 19:18 +0200, Cyrille Pitchen wrote: > Le 13/04/2017 à 10:24, Cyrille Pitchen a écrit : > > Hi Guochun, > > > > Le 13/04/2017 à 04:40, Guochun Mao a écrit : > >> Hi Cyrille, > >> > >> On Wed, 2017-04-12 at 22:57 +0200, Cyrille Pitchen wrote: > >>> Hi Guochun, > >>

Re: [virtio-dev] Re: [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS

2017-04-16 Thread Wei Wang
On 04/15/2017 05:38 AM, Michael S. Tsirkin wrote: On Fri, Apr 14, 2017 at 04:37:52PM +0800, Wei Wang wrote: On 04/14/2017 12:34 AM, Michael S. Tsirkin wrote: On Thu, Apr 13, 2017 at 05:35:05PM +0800, Wei Wang wrote: So we don't need the bitmap to talk to host, it is just a data structure we ch

Re: [PATCH V5 1/4] arm64: dts: Add basic DT to support Spreadtrum's SP9860G

2017-04-16 Thread Chunyan Zhang
Hi Arnd, Could you please take this patch through arm-soc git if there are no further comments? (The three other patches in this series have been taken by Greg.) Thanks, Chunyan On 27 March 2017 at 15:32, Chunyan Zhang wrote: > From: Orson Zhai > > SC9860G is a 8 cores of A53 SoC with 4G LTE s

Re: [PATCH v3 1/8] trace: ras: add ARM processor error information trace event

2017-04-16 Thread Xie XiuQi
Hi Tyler, On 2017/4/17 11:08, Xie XiuQi wrote: > Hi Tyler, > > Thanks for your comments and testing. > > On 2017/4/15 4:36, Baicar, Tyler wrote: >> On 3/30/2017 4:31 AM, Xie XiuQi wrote: >>> Add a new trace event for ARM processor error information, so that >>> the user will know what error occu

[PATCH] usb: gadget: remove redundant self assignment

2017-04-16 Thread Stefan Agner
The assignment ret = ret is redundant and can be removed. Signed-off-by: Stefan Agner --- A very similar patch has been applied already last year, but there is a second such assignment... -- Stefan drivers/usb/gadget/udc/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --g

Re: [PATCH v3 1/8] trace: ras: add ARM processor error information trace event

2017-04-16 Thread Xie XiuQi
Hi Tyler, Thanks for your comments and testing. On 2017/4/15 4:36, Baicar, Tyler wrote: > On 3/30/2017 4:31 AM, Xie XiuQi wrote: >> Add a new trace event for ARM processor error information, so that >> the user will know what error occurred. With this information the >> user may take appropriate

Re: [PATCH] acpica: trivial changes on comments

2017-04-16 Thread Cao jin
Re-to: linux-a...@vger.kernel.org On 04/17/2017 10:56 AM, Cao jin wrote: > Remove superfluous word; unify comments and function prototype. > > Signed-off-by: Cao jin > --- > drivers/acpi/acpica/tbfadt.c | 2 +- > drivers/acpi/acpica/tbutils.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 del

[PATCH] acpica: trivial changes on comments

2017-04-16 Thread Cao jin
Remove superfluous word; unify comments and function prototype. Signed-off-by: Cao jin --- drivers/acpi/acpica/tbfadt.c | 2 +- drivers/acpi/acpica/tbutils.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/acpica/tbfadt.c b/drivers/acpi/acpica/tbfadt.c inde

[lkp-robot] [cpu/hotplug] 94380da276: INFO:possible_recursive_locking_detected

2017-04-16 Thread kernel test robot
FYI, we noticed the following commit: commit: 94380da2765a391335c2326ba327e835c2e7aa03 ("cpu/hotplug: Convert hotplug locking to percpu rwsem") https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git WIP.hotplug in testcase: trinity with following parameters: runtime: 300s test-descr

[PATCH 2/4] ftrace: Add 'function-fork' trace option

2017-04-16 Thread Namhyung Kim
The function-fork option is same as event-fork that it tracks task fork/exit and set the pid filter properly. This can be useful if user wants to trace selected tasks including their children only. Signed-off-by: Namhyung Kim --- kernel/trace/ftrace.c | 37 +

[PATCH 0/4] ftrace: Add 'function-fork' trace option (v2)

2017-04-16 Thread Namhyung Kim
Hello, This patchset add 'function-fork' option to function tracer which makes pid filter to be inherited like 'event-fork' does. During the test, I found a bug of pid filter on an instance directory. The patch 1 fixes it and maybe it should go to the stable tree. The function-fork option is di

[PATCH 4/4] selftests: ftrace: Add a testcase for function PID filter

2017-04-16 Thread Namhyung Kim
Like event pid filtering test, add function pid filtering test with the new "function-fork" option. It also tests it on an instance directory so that it can verify the bug related pid filtering on instances. Cc: Masami Hiramatsu Cc: Steven Rostedt Cc: Shuah Khan Signed-off-by: Namhyung Kim --

[PATCH 1/4] ftrace: Fix function pid filter on instances

2017-04-16 Thread Namhyung Kim
When function tracer has a pid filter, it adds a probe to sched_switch to track if current task can be ignored. The probe checks the ftrace_ignore_pid from current tr to filter tasks. But it misses to delete the probe when removing an instance so that it can cause a crash due to the invalid tr po

[PATCH 3/4] selftests: ftrace: Add -l/--logdir option

2017-04-16 Thread Namhyung Kim
In my virtual machine setup, running ftracetest failed on creating LOG_DIR on a read-only filesystem. It'd be convenient to provide an option to specify a different directory as log directory. Acked-by: Masami Hiramatsu Cc: Steven Rostedt Cc: Shuah Khan Signed-off-by: Namhyung Kim --- tools/

Re: [PATCH v2 2/4] zram: implement deduplication in zram

2017-04-16 Thread Joonsoo Kim
On Mon, Apr 17, 2017 at 10:38:16AM +0900, Minchan Kim wrote: > Hi Joonsoo, > > I reviewed this patch and overall, looks great! Thanks. Thanks! > However, as you know, recently, zram had lots of clean up so > this patchset should be rebased on it massively. > Sorry for the inconvenience. No prob

Re: [PATCH 1/3] zram: fix operator precedence to get offset

2017-04-16 Thread Minchan Kim
Hi Sergey, On Mon, Apr 17, 2017 at 10:54:29AM +0900, Sergey Senozhatsky wrote: > On (04/17/17 10:21), Sergey Senozhatsky wrote: > > > However, it should be *fixed* to prevent confusion in future > > or may be something like below? can save us some cycles. > > remove this calculation > > -

Re: [PATCH V2] PM / OPP: Use - instead of @ for DT entries

2017-04-16 Thread Masahiro Yamada
2017-04-15 7:47 GMT+09:00 Rafael J. Wysocki : > On Monday, April 10, 2017 02:51:35 PM Viresh Kumar wrote: >> Compiling the DT file with W=1, DTC warns like follows: >> >> Warning (unit_address_vs_reg): Node /opp_table0/opp@10 has a >> unit name, but no reg property >> >> Fix this by replaci

Re: [PATCH] slab: avoid IPIs when creating kmem caches

2017-04-16 Thread Joonsoo Kim
On Sun, Apr 16, 2017 at 02:45:44PM -0700, Greg Thelen wrote: > Each slab kmem cache has per cpu array caches. The array caches are > created when the kmem_cache is created, either via kmem_cache_create() > or lazily when the first object is allocated in context of a kmem > enabled memcg. Array ca

Re: [PATCH v7 0/7] Introduce ZONE_CMA

2017-04-16 Thread Joonsoo Kim
On Thu, Apr 13, 2017 at 01:56:15PM +0200, Michal Hocko wrote: > On Wed 12-04-17 10:35:06, Joonsoo Kim wrote: > > On Tue, Apr 11, 2017 at 08:15:20PM +0200, Michal Hocko wrote: > > > Hi, > > > I didn't get to read though patches yet but the cover letter didn't > > > really help me to understand the b

Re: [kbuild-all] [tip:x86/cpu 8/12] arch/x86/kernel/cpu/intel_rdt.c:63: error: unknown field 'cache' specified in initializer

2017-04-16 Thread Fengguang Wu
On Sat, Apr 15, 2017 at 07:40:34AM +0200, Thomas Gleixner wrote: On Sat, 15 Apr 2017, kbuild test robot wrote: tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/cpu head: 64e8ed3d4a6dcd6139a869a3e760e625cb0d3022 commit: 05b93417ce5b924c6652de19fdcc27439ab37c90 [8/12] x86

Re: [PATCH 1/3] zram: fix operator precedence to get offset

2017-04-16 Thread Sergey Senozhatsky
On (04/17/17 10:21), Sergey Senozhatsky wrote: > > However, it should be *fixed* to prevent confusion in future or may be something like below? can save us some cycles. remove this calculation - offset = sector & (SECTORS_PER_PAGE - 1) << SECTOR_SHIFT; and pass 0 to zram_bvec_rw() -

Re: [PATCH 00/10] mac68k: Miscellaneous fixes, cleanup and modernization

2017-04-16 Thread Finn Thain
On Sun, 16 Apr 2017, Geert Uytterhoeven wrote: > Hi Finn, > > On Sun, Apr 9, 2017 at 1:51 AM, Finn Thain > wrote: > > This series has various patches from several different people. Two > > printk modernization patches were originally from Geert Uytterhoeven > > and three Nubus patches were o

Re: [PATCH 2/3] zram: do not use copy_page with non-page alinged address

2017-04-16 Thread Sergey Senozhatsky
On (04/13/17 09:17), Minchan Kim wrote: > The copy_page is optimized memcpy for page-alinged address. > If it is used with non-page aligned address, it can corrupt memory which > means system corruption. With zram, it can happen with > > 1. 64K architecture > 2. partial IO > 3. slub debug > > Par

copy_page() on a kmalloc-ed page with DEBUG_SLAB enabled (was "zram: do not use copy_page with non-page alinged address")

2017-04-16 Thread Sergey Senozhatsky
Hello, I'll fork it into a separate thread and Cc more MM people. sorry for top-posting. Minchan reported that doing copy_page() on a kmalloc(PAGE_SIZE) page with DEBUG_SLAB enabled can cause a memory corruption (See below or lkml.kernel.org/r/1492042622-12074-2-git-send-email-minc...@kernel.org

[PATCH v4 2/2] vfio/type1: Prune vfio_pin_page_external()

2017-04-16 Thread Alex Williamson
With vfio_lock_acct() testing the locked memory limit under mmap_sem, it's redundant to do it here for a single page. We can also reorder our tests such that we can avoid testing for reserved pages if we're not doing accounting, and test the process CAP_IPC_LOCK only if we are doing accounting. F

[PATCH v4 1/2] vfio/type1: Remove locked page accounting workqueue

2017-04-16 Thread Alex Williamson
If the mmap_sem is contented then the vfio type1 IOMMU backend will defer locked page accounting updates to a workqueue task. This has a few problems and depending on which side the user tries to play, they might be over-penalized for unmaps that haven't yet been accounted or race the workqueue to

[PATCH v4 0/2] vfio/type1: Synchronous locked page accounting

2017-04-16 Thread Alex Williamson
v4: vfio_lock_acct() should not fail due to RLIMIT_MEMLOCK if task has CAP_IPC_LOCK capability. Introduced 2nd patch to remove redundancy from vfio_pin_page_external() and fix return value. Please re-review. Thanks! Alex --- Alex Williamson (2): vfio/type1: Remove locked page ac

Re: [PATCH v2 2/4] zram: implement deduplication in zram

2017-04-16 Thread Minchan Kim
Hi Joonsoo, I reviewed this patch and overall, looks great! Thanks. However, as you know, recently, zram had lots of clean up so this patchset should be rebased on it massively. Sorry for the inconvenience. And there are some minor in below. I hope you handle them in next submit, please. On Thu

RE: [PATCH 1/2 v2] dt-bindings: qoriq-clock: Add coreclk

2017-04-16 Thread Andy Tang
Hi Stephen and Michael, This patch set has been pending for more than two months since it was first sent. I have not received any response from you until now. Could you give some comments on it? Regards, Andy -Original Message- From: Andy Tang Sent: Wednesday, April 05, 2017 2:16 PM T

[PATCH 2/2] staging:skein: skein_base.h, skein_block.h: move macros into appropriate header files

2017-04-16 Thread Karim Eshapa
Macros more related to BLK operations. Signed-off-by: Karim Eshapa --- drivers/staging/skein/skein_base.h | 28 drivers/staging/skein/skein_block.h | 28 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/sk

Re: [PATCH 1/3] zram: fix operator precedence to get offset

2017-04-16 Thread Sergey Senozhatsky
Hello, On (04/15/17 00:33), Minchan Kim wrote: > On Fri, Apr 14, 2017 at 02:07:47PM +0900, Sergey Senozhatsky wrote: > > On (04/13/17 09:17), Minchan Kim wrote: > > [..] > > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > > > index 9e2199060040..83c38a123242 100644 >

Re: [PATCH 1/3] zram: fix operator precedence to get offset

2017-04-16 Thread Sergey Senozhatsky
On (04/13/17 09:17), Minchan Kim wrote: > Date: Thu, 13 Apr 2017 09:17:00 +0900 > From: Minchan Kim > To: Andrew Morton > CC: linux-kernel@vger.kernel.org, Sergey Senozhatsky > , kernel-t...@lge.com, Minchan Kim > , sta...@vger.kernel.org > Subject: [PATCH 1/3] zram: fix operator precedence to

Re: [PATCH v5 2/5] drivers: watchdog: Add STM32 IWDG driver

2017-04-16 Thread Guenter Roeck
On 04/06/2017 05:19 AM, Yannick Fertre wrote: This patch adds IWDG (Independent WatchDoG) support for STM32 platform. Signed-off-by: Yannick FERTRE Reviewed-by: Guenter Roeck --- drivers/watchdog/Kconfig | 12 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/stm32_iwdg.c |

Re: [PATCH] arm: dma: fix sharing of coherent DMA memory without struct page

2017-04-16 Thread Shuah Khan
On 04/14/2017 03:46 AM, Russell King - ARM Linux wrote: > On Fri, Apr 14, 2017 at 09:56:07AM +0200, Marek Szyprowski wrote: This would be however quite large task, especially taking into account all current users of DMA-buf framework... >>> Yeah it will be a large task. >> >> Maybe once s

[PATCH 2/2] staging:skein: skein_base.h, skein_block.h: move macros into appropriate header files

2017-04-16 Thread Karim Eshapa
Macros more related to BLK operations. Signed-off-by: Karim Eshapa --- drivers/staging/skein/skein_base.h | 28 drivers/staging/skein/skein_block.h | 28 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/sk

4.11-rc7 crash when booting with 1 numa node?

2017-04-16 Thread Darrick J. Wong
Hi, When booting 4.11-rc7 on a qemu guest with a single numa node, I hit the following[1] crash on boot. If I configure more than one node, the problem goes away. I tracked the relevant line down to: (gdb) l *(irq_create_affinity_masks+0x237) 0x81103a87 is in irq_create_affinity_masks (

Re: [PATCH] hugetlbfs: fix offset overflow in huegtlbfs mmap

2017-04-16 Thread Naoya Horiguchi
On Sat, Apr 15, 2017 at 03:58:59PM -0700, Mike Kravetz wrote: > On 04/13/2017 08:32 PM, Naoya Horiguchi wrote: > > On Tue, Apr 11, 2017 at 03:51:58PM -0700, Mike Kravetz wrote: > > ... > >> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > >> index 7163fe0..dde8613 100644 > >> --- a/fs/hug

Re: [PATCH 3.18 000/145] 3.18.49-stable review

2017-04-16 Thread Guenter Roeck
On 04/16/2017 03:48 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 3.18.49 release. There are 145 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. - Wait, what

[PATCH 0/2] ACPI: Device enumeration udates

2017-04-16 Thread Rafael J. Wysocki
Hi, These two patches change a couple of things related to the ACPI enumeration of devices. [1/2] causes the default enumeration to also be used for device objects with ACPI drivers bound for consistency. [2/2] makes acpi_bus_attach() look at the "visited" flag of device objects as it should rea

[PATCH 2/2] ACPI / scan: Avoid enumerating devices more than once

2017-04-16 Thread Rafael J. Wysocki
From: Rafael J. Wysocki acpi_bus_attach() does not check the visited flag for devices that have been enumerated already and some of them may be enumerated for multiple times as a result, because some callers of acpi_bus_scan() don't check the visited flag either. For this reason, modify acpi_bus

[PATCH 1/2] ACPI / scan: Apply default enumeration to devices with ACPI drivers

2017-04-16 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The current code in acpi_bus_attach() is inconsistent with respect to device objects with ACPI drivers bound to them, as it allows ACPI drivers to bind to device objects with existing "physical" device companions, but it doesn't allow "physical" device objects to be create

[PATCH RFC] ptr_ring: add ptr_ring_unconsume

2017-04-16 Thread Michael S. Tsirkin
Applications that consume a batch of entries in one go can benefit from ability to return some of them back into the ring. Add an API for that - assuming there's space. If there's no space naturally we can't do this and have to drop entries, but this implies ring is full so we'd likely drop some a

Re: [patch 19/20] ACPI/processor: Use cpu_hotplug_disable() instead of get_online_cpus()

2017-04-16 Thread Rafael J. Wysocki
On Saturday, April 15, 2017 07:01:26 PM Thomas Gleixner wrote: > Converting the hotplug locking, i.e. get_online_cpus(), to a percpu rwsem > unearthed a circular lock dependency which was hidden from lockdep due to > the lockdep annotation of get_online_cpus() which prevents lockdep from > creating

Re: [RESEND PATCH] tools/power/x86/intel_pstate_tracer: Adjust directory permissions

2017-04-16 Thread Rafael J. Wysocki
On Sun, Apr 16, 2017 at 5:17 PM, Doug Smythies wrote: > Depending on what is being done, the intel_pstate_tracer.py script > needs to be run as root, or can be run as a regular user. > If run the first time as root the results directory will be > incorrect for any subsequent run as a regular user.

  1   2   3   4   5   >