RE: [RESEND PATCH V6 0/6] Add support for privileged mappings

2016-12-03 Thread Sricharan
Hi Robin, >Hi Sricharan, > >On 02/12/16 14:55, Sricharan R wrote: >> This series is a resend of the V5 that Mitch sent sometime back [2] >> All the patches are the same and i have just rebased. Not sure why this >> finally did not make it last time. The last patch in the previous >> series does no

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-03 Thread Alan Modra
On Fri, Dec 02, 2016 at 11:55:58AM +0100, Arnd Bergmann wrote: > I have managed to bisect the link failure to a specific binutils > commit by Alan Modra now: > > d983c8c ("Strip undefined symbols from .symtab") > > went into binutils-2_26 and was reverted in > > a82e3ef ("Revert "Strip undefine

Re: [Intel-wired-lan] [PATCH v2] e1000e: free IRQ regardless of __E1000_DOWN

2016-12-03 Thread Neftin, Sasha
On 12/2/2016 7:02 PM, Baicar, Tyler wrote: > Hello Sasha, > > Were you able to reproduce this issue? > > Do you have a patch fixing the close function inconsistencies that you > mentioned which I could try out? > > Thanks, > Tyler > > On 11/21/2016 1:40 PM, Baicar, Tyler wrote: >> On 11/17/2016

Re: [PATCH 1/1] infiniband: hw: mlx4: fix improper return value

2016-12-03 Thread Leon Romanovsky
On Sun, Dec 04, 2016 at 02:45:38PM +0800, Pan Bian wrote: > From: Pan Bian > > If uhw->inlen is non-zero, the value of variable err is 0 if the copy > succeeds. Then, if kzalloc() or kmalloc() returns a NULL pointer, it > will return 0 to the callers. As a result, the callers cannot detect the > e

[PATCH 1/1] infiniband: hw: mlx4: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian If uhw->inlen is non-zero, the value of variable err is 0 if the copy succeeds. Then, if kzalloc() or kmalloc() returns a NULL pointer, it will return 0 to the callers. As a result, the callers cannot detect the errors. This patch fixes the bug, assign "-ENOMEM" to err before the N

arch/xtensa/include/asm/initialize_mmu.h:41: Error: invalid register 'atomctl' for 'wsr' instruction

2016-12-03 Thread kbuild test robot
Hi Pete, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0cb65c83304a341b9d09678448d7c8b550689531 commit: d0b73b488c55df905ea8faaad079f8535629ed26 xtensa: Add config files for Diamond 233L - Rev C processor variant

[PATCH 1/1] net: ethernet: broadcom: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate memory, and jumps to label "lbl" if the allocation fails. Label "lbl" first cleans memory and then returns variable rc. Before calling the macro, the value of variable rc is 0. Because 0 means no error, the calle

[PATCH 1/1] xen: set error code on failures

2016-12-03 Thread Pan Bian
From: Pan Bian The return variable rc is initialized with "-ENOMEM" outside the loop. However, it is reset in the loop, and its value is not negative during the second or after repeat of the loop. If kzalloc() fails then, it will return 0. This patch fixes the bug, assigning "-ENOMEM" to rc whe

Re: [PATCH 1/1] infiniband: hw: ocrdma: fix bad initialization

2016-12-03 Thread Leon Romanovsky
On Sat, Dec 03, 2016 at 09:10:21PM +0800, Pan Bian wrote: > From: Pan Bian > > In function ocrdma_mbx_create_ah_tbl(), returns the value of status on > errors. However, because status is initialized with 0, 0 will be > returned even if on error paths. This patch initialize status with > "-ENOMEM".

[PATCH 1/1] mtd: ubi: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian When __vmalloc() returns a NULL pointer, the region is not checked, and we cannot make sure that only 0xFF bytes are present at offset. Thus, returning 0 seems improper. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189081 Signed-off-by: Pan Bian --- drivers/mtd/ubi/io.

[PATCH 1/1] net: ethernet: qlogic: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian When the call to qlcnic_alloc_mbx_args() fails, returning variable "err" seems improper. With reference to the context, returing variable "config" may be better. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189101 Signed-off-by: Pan Bian --- drivers/net/ethernet/qlogic

Re: [PATCH 1/1] infiniband: hw: mlx4: fix improper return value

2016-12-03 Thread Leon Romanovsky
On Sun, Dec 04, 2016 at 01:49:04PM +0800, Pan Bian wrote: > From: Pan Bian > > If uhw->inlen is non-zero, the value of variable err is 0 if the copy > succeeds. Then, if kzalloc() or kmalloc() returns a NULL pointer, it > will return 0 to the callers. As a result, the callers cannot detect the > e

[PATCH 1/1] net: ethernet: qlogic: set error code on failure

2016-12-03 Thread Pan Bian
From: Pan Bian When calling dma_mapping_error(), the value of return variable rc is 0. And when the call returns an unexpected value, rc is not set to a negative errno. Thus, it will return 0 on the error path, and its callers cannot detect the bug. This patch fixes the bug, assigning "-ENOMEM" t

Re: [PATCH v3 07/13] net: ethernet: ti: cpts: clean up event list if event pool is empty

2016-12-03 Thread kbuild test robot
Hi WingMan, [auto build test ERROR on net/master] [also build test ERROR on v4.9-rc7 next-20161202] [cannot apply to net-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Grygorii-Stra

[PATCH 1/1] edac: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian When the call to zalloc_cpumask_var() fails, returning "false" seems improper. The real value of macro "false" is 0, and 0 means no error. This patch fixes the bug, returning "-ENOMEM". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071 Signed-off-by: Pan Bian --- dri

[PATCH 1/1] scsi: snic: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian When the calls to mempool_create_slab_pool() return unexpected values, the value of return variable ret is 0. 0 means no error. Thus, the caller of fnic_probe() cannot detect the error, and may be misled. This patch fixes the bug, assigning "-ENOMEM" to ret before calling mempool_c

[PATCH 1/1] scsi: fnic: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian When the calls to mempool_create_slab_pool() return unexpected values, the value of return variable err is 0. 0 means no error. Thus, the caller of fnic_probe() cannot detect the error, and may be misled. This patch fixes the bug, assigning "-ENOMEM" to err before calling mempool_c

[PATCH 1/1] infiniband: hw: mlx4: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian If uhw->inlen is non-zero, the value of variable err is 0 if the copy succeeds. Then, if kzalloc() or kmalloc() returns a NULL pointer, it will return 0 to the callers. As a result, the callers cannot detect the errors. This patch fixes the bug, assigning "-ENOMEM" to err before th

[PATCH 1/1] atm: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian It returns variable "error" when ioremap_nocache() returns a NULL pointer. The value of "error" is 0 then, which will mislead the callers to believe that there is no error. This patch fixes the bug, returning "-ENOMEM". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189021

[PATCH 1/1] media: pci: meye: set error code on failures

2016-12-03 Thread Pan Bian
From: Pan Bian The value of return variable ret is 0 on some error paths, for example, when pci_resource_start() returns a NULL pointer. 0 means no error in this context, which is contrary to the fact. This patch fixes the bug. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189011 Signed

[PATCH 1/1] media: pci: meye: set error code on failures

2016-12-03 Thread Pan Bian
From: Pan Bian The value of return variable ret is 0 on some error paths, for example, when pci_resource_start() returns a NULL pointer. 0 means no error in this context, which is contrary to the fact. This patch fixes the bug. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189011 Signed

[PATCH 1/2] scsi: be2iscsi: set errno on error path

2016-12-03 Thread Pan Bian
From: Pan Bian Variable ret is reset in the loop, and its value will be 0 during the second and after repeat of the loop. If pci_alloc_consistent() returns a NULL pointer then, it will leaves with return value 0. 0 means no error, which is contrary to the fact. This patches fixes the bug, explici

[PATCH 1/1] scsi: 3w-sas: set errno on failures

2016-12-03 Thread Pan Bian
From: Pan Bian On some error paths (e.g. pci_iomap() returns a NULL pointer), the value of return variable retval is 0. 0 means no error. This patch fixes the bug, set retval with negative errno on error paths. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189001 Signed-off-by: Pan Bian

[PATCH 1/1] memstick: host: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian When pci_ioremap_bar() returns a NULL pointer, the value of return variable "error" is 0. 0 means no error, which is contrary to the fact. Similarly, the return values are also improper when request_irq() or memstick_add_host() returns unexpected values. This patch fixes the bug, a

include/linux/bug.h:37:45: error: bit-field '' width not an integer constant

2016-12-03 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0cb65c83304a341b9d09678448d7c8b550689531 commit: 80cca775cdc4f8555612d2943a2872076b33e0ff net: fec: cache statistics while device is down date: 4 days ago config: m68k-m5272c3_defconfig (attached as .confi

[PATCH 1/1] net: irda: set error code on failures

2016-12-03 Thread Pan Bian
From: Pan Bian When the calls to kzalloc() fail, the value of return variable ret may be 0. 0 means success in this context. This patch fixes the bug, assigning "-ENOMEM" to ret before calling kzalloc(). Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188971 Signed-off-by: Pan Bian ---

[PATCH 2/2] scsi: be2iscsi: set errno on error path

2016-12-03 Thread Pan Bian
From: Pan Bian Variable ret is reset in the loop, and its value will be 0 during the second and after repeat of the loop. If pci_alloc_consistent() returns a NULL pointer then, it will leaves with return value 0. 0 means no error, which is contrary to the fact. This patches fixes the bug, explici

[PATCH 1/1] isdn: hisax: set error code on failure

2016-12-03 Thread Pan Bian
From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to request_region() returns NULL, the value of err is 0. This patch fixes the bug, assiging "-ENOMEM" to err on the path that request_region() fails. Bugzilla: http

[PATCH 1/1] input: usbhid: fix improper check

2016-12-03 Thread Pan Bian
From: Pan Bian Function hid_post_reset() returns 0 on success, or 1 on failures. However, in function hid_reset_resume(), uses "status >= 0" to check the return value of hid_post_reset(). Obviously, the condition will always be satisfied. This patch fixes the bug, uses "status == 0" to check the

Re: [PATCH 1/1] net: dcb: set error code on failures

2016-12-03 Thread David Miller
From: Pan Bian Date: Sat, 3 Dec 2016 21:49:08 +0800 > From: Pan Bian > > In function dcbnl_cee_fill(), returns the value of variable err on > errors. However, on some error paths (e.g. nla put fails), its value may > be 0. It may be better to explicitly set a negative errno to variable > err b

[PATCH 1/1] btrfs: fix improper return value

2016-12-03 Thread Pan Bian
In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret on errors. However, it directly returns 0. It may be better to return ret. This patch also removes the warning, because the caller already prints a warning. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731 Signed-

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

2016-12-03 Thread David Miller
From: Arnd Bergmann Date: Sat, 3 Dec 2016 00:04:32 +0100 > ptp now depends on the optional POSIX_TIMERS setting and fails to build > if we select it without that: > > warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet > direct dependencies (NET && POSIX_TIMERS) > warning:

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

2016-12-03 Thread Al Viro
On Wed, Nov 23, 2016 at 12:55:51AM +, David Howells wrote: > + * vfs_xgetattr - Get the enhanced basic attributes of a file > + * @path: The file of interest > + * @stat: Where to return the statistics > + * > + * Ask the filesystem for a file's attributes. The caller must have preset > + * s

Re: [PATCH] dt-binding: soc: qcom: smd: Add label property

2016-12-03 Thread Andy Gross
On Wed, Oct 26, 2016 at 05:08:20PM -0500, Rob Herring wrote: > On Wed, Oct 19, 2016 at 07:38:10PM -0700, Bjorn Andersson wrote: > > The label property can be used to specify a name of the edge, for > > consistent naming purposes. > > > > Signed-off-by: Bjorn Andersson > > --- > > Documentation/d

[PATCH 1/1] net: caif: remove ineffective check

2016-12-03 Thread Pan Bian
The check of the return value of sock_register() is ineffective. "if(!err)" seems to be a typo. It is better to propagate the error code to the callers of caif_sktinit_module(). This patch removes the check statment and directly returns the result of sock_register(). Bugzilla: https://bugzilla.ker

cc1: error: '-march=r3900' requires '-mfp32'

2016-12-03 Thread kbuild test robot
Hi James, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0cb65c83304a341b9d09678448d7c8b550689531 commit: 034827c727f7f3946a18355b63995b402c226c82 MIPS: Fix -mabi=64 build of vdso.lds date: 8 weeks ago config: mi

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

2016-12-03 Thread Al Viro
On Wed, Nov 23, 2016 at 12:55:51AM +, David Howells wrote: > -int vfs_getattr_nosec(struct path *path, struct kstat *stat) > +int vfs_xgetattr_nosec(struct path *path, struct kstat *stat) const struct path *, please. Especially since we feed &file->f_path to it. And yes, I realize that the

Re: [PATCH V4 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads

2016-12-03 Thread kbuild test robot
Hi Laxman, [auto build test ERROR on tegra/for-next] [also build test ERROR on v4.9-rc7 next-20161202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Laxman-Dewangan/pinctrl-tegra-Add-DT-binding

cc1: error: '-march=r3000' requires '-mfp32'

2016-12-03 Thread kbuild test robot
Hi James, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 commit: 034827c727f7f3946a18355b63995b402c226c82 MIPS: Fix -mabi=64 build of vdso.lds date: 8 weeks ago config: mi

[PATCH] zram: restrict add/remove attributes to root only

2016-12-03 Thread Sergey Senozhatsky
Only root must be able to create a new zram device, therefore hot_add attribute must have S_IRUSR mode, not S_IRUGO. Otherwise, anyone can create a new zram device (device initialization with the disksize attr requires root permission). Fixes: 6566d1a32bf72 ("zram: add dynamic device add/remove fu

Urgent Pls

2016-12-03 Thread Dr. Andrea
Dear, I'm Dr. Andrea Thompson, I'm seeking for investment opportunities around the globe and wonder if you can be of assistance. Basically, all I need from you is sincerity, authenticity, integrity protection, virtue, accountability and honor which brings trust in business. As you already know

Re: [PATCH v5 1/1] crypto: add virtio-crypto driver

2016-12-03 Thread kbuild test robot
Hi Gonglei, [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.9-rc7 next-20161202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gonglei/crypto-add-virtio-crypto-driver/2

[PATCH 04/19] staging: iio: isl29028: add power management support

2016-12-03 Thread Brian Masney
This patch adds power management support to the isl29028 driver. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 59 1 file changed, 59 insertions(+) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl290

[PATCH 11/19] staging: iio: isl29028: made column alignment in isl29028_channels consistent

2016-12-03 Thread Brian Masney
The three info_mask_separate members OR several BIT(xxx) fields together. This patch changes the column alignment of these fields to be aligned at the same column to improve the overall code readability. It also moves the { for the next channel to the next line to improve code readability. Signed-

[PATCH 01/19] staging: iio: isl29028: remove nested if statements

2016-12-03 Thread Brian Masney
There are two callers to the function isl29028_set_als_ir_mode() and both instances use a nested if statement to only change the chip state if it is not in the proper mode. This patch moves this check into the isl29028_set_als_ir_mode() function to remove the nested if statements. Signed-off-by: B

[PATCH 12/19] staging: iio: isl29028: fix comparison between signed and unsigned integers

2016-12-03 Thread Brian Masney
Fixed warning found by make W=2 to reduce the amount of build noise: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[PATCH 09/19] staging: iio: isl29028: change newlines to improve readability

2016-12-03 Thread Brian Masney
Add and remove newlines to improve code readability in preparation for moving the driver out of staging. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/l

[PATCH 10/19] staging: iio: isl29028: remove unused define ISL29028_DEV_ATTR

2016-12-03 Thread Brian Masney
The #define ISL29028_DEV_ATTR was not used so this patch removes the unnecessary code. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index 8f9295

[PATCH 07/19] staging: iio: isl29028: fix alignment of function arguments

2016-12-03 Thread Brian Masney
Two separate calls to regmap_update_bits() in isl29028_set_als_scale() and isl29028_set_als_ir_mode() did not have their function arguments on the next line aligned correctly to the open parenthesis. This patch corrects the alignment. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl

[PATCH 05/19] staging: iio: isl29028: made alignment of #defines consistent

2016-12-03 Thread Brian Masney
The alignment of the #defines at the top of the file is not consistent. This changes all of the defines to use consistent alignment to improve the code readability. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 42 ++-- 1 file changed, 21

[PATCH 06/19] staging: iio: isl29028: made alignment of variables in struct isl29028_chip consistent

2016-12-03 Thread Brian Masney
The alignment of the variables in the struct isl29028_chip is not consistent. This changes all of the variables to use consistent alignment to improve the code readability. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 10 +- 1 file changed, 5 insertions(+), 5 de

[PATCH 08/19] staging: iio: isl29028: combine isl29028_proxim_get() and isl29028_read_proxim()

2016-12-03 Thread Brian Masney
isl29028_proxim_get() checks to see if the promixity needs to be enabled on the chip and then calls isl29028_read_proxim(). There are no other callers of isl29028_read_proxim(). The naming between these two functions can be confusing so this patch combines the two to avoid the confusion. Signed-of

[PATCH 18/19] staging: iio: isl29028: remove unnecessary parenthesis

2016-12-03 Thread Brian Masney
isl29028_write_raw() contains unnecessary parenthesis when checking to see if the passed in lux scale is valid. This patch removes the unnecessary parenthesis. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 19/19] staging: iio: isl29028: remove legacy device tree binding

2016-12-03 Thread Brian Masney
The isl29028 staging driver contains a legacy binding of "isl,isl29028" that is marked as legacy and to not use. There are no in tree references to that binding. This patch removes the legacy binding in preparation for moving the driver out of staging. Otherwise, we will have to support this bindin

[PATCH 17/19] staging: iio: isl29028: remove out of memory log message

2016-12-03 Thread Brian Masney
If the call to devm_iio_device_alloc() fails, then isl29028_probe() logs a message saying that memory cannot be allocated. The user's system most likely has larger issues at this point. This patch removes that error message since the error code is passed on and the message is not necessary. Signed

[PATCH 13/19] staging: iio: isl29028: move failure logging into isl29028_set_proxim_sampling()

2016-12-03 Thread Brian Masney
When isl29028_set_proxim_sampling() fails, it was up to both callers to log the failure message. This patch moves the logging into isl29028_set_proxim_sampling() to reduce the overall amount of code in the driver. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 28

[PATCH 15/19] staging: iio: isl29028: made error messages consistent

2016-12-03 Thread Brian Masney
The wording and style of the different error messages was not consistent. This patches makes the wording and style consistent throughout the driver. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 56 1 file changed, 32 insertions(+), 2

[PATCH 02/19] staging: iio: isl29028: remove enable flag from isl29028_enable_proximity()

2016-12-03 Thread Brian Masney
isl29028_enable_proximity() has a boolean argument named enable. This function is only called once and the enable flag is set to true in that call. This patch removes the enable parameter from that function. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 10 -- 1

[PATCH 16/19] staging: iio: isl29028: remove unnecessary error logging in isl29028_chip_init_and_power_on()

2016-12-03 Thread Brian Masney
If the call to isl29028_chip_init_and_power_on() in isl29028_probe() fails, then isl29028_probe() will log an error message. All of the error paths in that call path already have error logging in place. This patch removes the unnecessary logging. Signed-off-by: Brian Masney --- drivers/staging/i

[PATCH 14/19] staging: iio: isl29028: move failure logging into isl29028_set_als_scale()

2016-12-03 Thread Brian Masney
When isl29028_set_als_scale() fails, it was up to both callers to log the failure message. This patch moves the logging into isl29028_set_als_scale() to reduce the overall amount of code in the driver. Signed-off-by: Brian Masney --- drivers/staging/iio/light/isl29028.c | 23 +---

[PATCH 03/19] staging: iio: isl29028: remove chip test and defaults from isl29028_chip_init()

2016-12-03 Thread Brian Masney
isl29028_chip_init() contains the device driver defaults and two I2C calls that detect the presence of the chip. This patch moves these into isl29028_probe() so that this function can be used by the power management runtinme in a followup patch. This patch also renames isl29028_chip_init() to isl29

[PATCH 00/19] staging: iio: isl29028: staging cleanups

2016-12-03 Thread Brian Masney
This is my first round of cleanups to the isl29028 light driver in preparation for moving the driver out of staging. The main feature introduced by this patch set is support for power management. The rest of the patches are minor improvements, mostly style. I have one of these devices from https:/

Re: [PATCH 1/7] vfs - merge path_is_mountpoint() and path_is_mountpoint_rcu()

2016-12-03 Thread Ian Kent
On Sat, 2016-12-03 at 23:29 +, Al Viro wrote: > On Sat, Dec 03, 2016 at 05:13:22AM +, Al Viro wrote: > > > > * path_has_submounts() is broken.  At the very least, it's > > AB-BA between mount_lock and rename_lock.  I would suggest trying to > > put read_seqlock_excl(&mount_lock) around

{standard input}:199: Error: unknown opcode

2016-12-03 Thread kbuild test robot
Hi Rich, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 commit: b4214e41b7152b1964a3421a40251d202ae2d2c0 sh: add SMP support for J2 date: 4 months ago config: sh-j2_defconf

arch/mips/vdso/gettimeofday.c:1:0: error: '-march=r3000' requires '-mfp32'

2016-12-03 Thread kbuild test robot
Hi Guenter, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 commit: 398c7500a1f5f74e207bd2edca1b1721b3cc1f1e MIPS: VDSO: Fix build error with binutils 2.24 and earlier date

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-12-03 Thread kbuild test robot
Hi Lino, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161126-202438 config: sparc64-allyesconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1

Re: [PATCH 1/7] vfs - merge path_is_mountpoint() and path_is_mountpoint_rcu()

2016-12-03 Thread Ian Kent
On Sat, 2016-12-03 at 05:13 +, Al Viro wrote: > FWIW, I've folded that pile into vfs.git#work.autofs. > > Problems: > * (fixed) __path_is_mountpoint() should _not_ treat NULL from > __lookup_mnt() as "nothing's mounted there" until it has checked > that mount_lock hadn't been touch

arch/mips/vdso/elf.S:1:0: error: '-march=r3000' requires '-mfp32'

2016-12-03 Thread kbuild test robot
Hi Alex, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 commit: ebb5e78cc63417a35254a791de66e1cc84f963cc MIPS: Initial implementation of a VDSO date: 1 year, 1 month ago c

Re: [PATCH] fpga: fix sparse warnings in fpga-mgr and fpga-bridge

2016-12-03 Thread atull
On Sat, 3 Dec 2016, Moritz Fischer wrote: > On Fri, Dec 2, 2016 at 1:23 PM, Dinh Nguyen wrote: > > Fix up these sparse warnings: > > > > drivers/fpga/fpga-mgr.c:189:21: warning: symbol '__fpga_mgr_get' was not > > declared. Should it be static? > > drivers/fpga/fpga-bridge.c:30:12: warning: symbo

[PATCH] sysctl: Add KERN_CONT to deprecated_sysctl_warning()

2016-12-03 Thread Tetsuo Handa
Do not break lines while printk()ing values. kernel: warning: process `tomoyo_file_tes' used the deprecated sysctl system call with kernel: 3. kernel: 5. kernel: 56. kernel: Signed-off-by: Tetsuo Handa --- kernel/sysctl_binary.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

RE: [PATCH 02/22] NTB: Add peer indexed ports NTB API

2016-12-03 Thread Allen Hubbe
From: Serge Semin > Add new port-index NTB API. Additionally lets get rid of Primary and > Secondary topologies, since port-number can be effectively used instead. Split into two patches please. I see no harm to the TOPO changes, though I wonder if they are necessary. > Signed-off-by: Serge Semi

RE: [PATCH 06/22] NTB: Slightly alter link state NTB API

2016-12-03 Thread Allen Hubbe
From: Serge Semin > Some minor changes of link state NTB API. Particularly link_is_up() > method from now shall return a bitfield of link states for all accessible > port indexes. Looks good. I plan to ack. See comment on ntb_link_enable. > > Signed-off-by: Serge Semin > > --- > include/li

RE: [PATCH 03/22] NTB: Alter NTB API to support both inbound and outbound MW based interfaces

2016-12-03 Thread Allen Hubbe
From: Serge Semin > Alter NTB API to support inbound and outbound MW based interfaces. > Additionally I made it supporting multi-port devices as well. Useful > infographics is added right before MW API is declared. It shall help to > better understand how the new API really works and how it can be

RE: [PATCH 08/22] NTB: Add T-Platforms copyrights to NTB API

2016-12-03 Thread Allen Hubbe
> From: Serge Semin > > Signed-off-by: Serge Semin This patch has no comment, but instead... This can be squashed with your first commit of significant changes to each file. > > --- > drivers/ntb/ntb.c | 2 ++ > include/linux/ntb.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git

RE: [PATCH 04/22] NTB: Add messaging NTB API

2016-12-03 Thread Allen Hubbe
From: Serge Semin > IDT PCIe-switches have message registers to communicate with peer devices. > This patch adds new NTB API callback methods, which can be used to utilize > these registers functionality. > Please split: add msg api; make spads optional. See comments below on ntb_dev_ops_is_val

Re: alpha: Checking for a failed kmalloc() in process_reloc_for_got()?

2016-12-03 Thread Jiri Kosina
On Sat, 3 Dec 2016, SF Markus Elfring wrote: > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/alpha/kernel/module.c?id=e05f574a0bb1f4502a4b2264fdb0ef6419cf3772#n40 > > Would it be useful to check the return value from a call of the > function “kmalloc” also there? *dr

RE: [PATCH 07/22] NTB: Fix a few ntb.h issues

2016-12-03 Thread Allen Hubbe
From: Serge Semin > Fix some minor issues found in ntb.h file. > "Fix a few issues" is not a descriptive commit title or message. Please split: add NTB_SPEED_GEN4, ntb.h comments. Changes look good and I will ack. > Signed-off-by: Serge Semin > > --- > include/linux/ntb.h | 18

RE: [PATCH 01/22] NTB: Move link state API being first in sources

2016-12-03 Thread Allen Hubbe
From: Serge Semin > Since link operations are usually performed before memory window access > operations, it's logically better to declared link-related API before any > other methods. Additionally it's good practice for readability to declare > NTB device callback methods of hadrware drivers with

RE: [PATCH 05/22] NTB: Alter Scratchpads NTB API to support multi-ports interface

2016-12-03 Thread Allen Hubbe
From: Serge Semin > Even though there is no any real NTB hardware, which would have both more > than two ports and Scratchpad registers, it is logically correct to have > Scratchpad API accepting a peer port index as well. Intel/AMD drivers used > to utilize Primary and Secondary topology to split

Re: [PATCH 1/7] vfs - merge path_is_mountpoint() and path_is_mountpoint_rcu()

2016-12-03 Thread Al Viro
On Sat, Dec 03, 2016 at 05:13:22AM +, Al Viro wrote: > * path_has_submounts() is broken. At the very least, it's > AB-BA between mount_lock and rename_lock. I would suggest trying to > put read_seqlock_excl(&mount_lock) around the call of d_walk() in there, > and using __lookup_mnt() in

Re: [PATCH 1/2 v2] sched: fix find_idlest_group for fork

2016-12-03 Thread Matt Fleming
On Fri, 25 Nov, at 04:34:32PM, Vincent Guittot wrote: > During fork, the utilization of a task is init once the rq has been > selected because the current utilization level of the rq is used to set > the utilization of the fork task. As the task's utilization is still > null at this step of the for

Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH

2016-12-03 Thread Richard Cochran
On Mon, Nov 28, 2016 at 05:04:25PM -0600, Grygorii Strashko wrote: > This also change overflow polling period when HW_TS_PUSH feature is > enabled - overflow check work will be scheduled more often (every > 200ms) for proper HW_TS_PUSH events reporting. For proper reporting, you should make use of

Re: [PATCH] ARM: dts: sunxi: Add num-cs for A20 spi nodes

2016-12-03 Thread kbuild test robot
Hi Emmanuel, [auto build test ERROR on robh/for-next] [also build test ERROR on v4.9-rc7 next-20161202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Emmanuel-Vadot/ARM-dts-sunxi-Add-num-cs-for

Re: [PATCH] tty: serial: fsl_lpuart: fix del_timer_sync() vs timer routine deadlock

2016-12-03 Thread Bhuvanchandra DV
On 12/03/2016 02:58 AM, Nikita Yushchenko wrote: Problem found via lockdep: - lpuart_set_termios() calls del_timer_sync(&sport->lpuart_timer) while holding sport->port.lock - sport->lpuart_timer routine is lpuart_timer_func() that calls lpuart_copy_rx_to_tty() that acquires same lock. T

Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

2016-12-03 Thread Florian Fainelli
Le 12/03/16 à 13:35, Rob Herring a écrit : > On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote: >> Add documentations for macb mdio driver. > > Bindings document h/w, not drivers. > >> >> Signed-off-by: Harini Katakam >> --- >> .../devicetree/bindings/net/macb-mdio.txt | 3

[PATCH v2 3/3] ARM: dts: vf610-zii-dev-rev-b: Remove 'fixed-link' from DSA ports

2016-12-03 Thread Andrey Smirnov
Remove 'fixed-link' nodes from DSA ports since they are not needed (they are not limiting link's speed and the ports will be configured to their maximux speed as a default) Suggested-by: Andrew Lunn Signed-off-by: Andrey Smirnov --- Changes since v1: - Patch was not present in v1 arch

[PATCH v2 1/3] ARM: dts: vf610-zii-dev-rev-b: Remove leftover PWM pingroup

2016-12-03 Thread Andrey Smirnov
Remove pwm0grp since it is: a) Not referenced anywhere in the DTS file (unlike Tower board it is based on, this board does not use/expose FTM0) b) Configures PTB2 and PTB3 in a way that contradicts pinctrl-mdio-mux Signed-off-by: Andrey Smirnov --- No changes si

[PATCH v2 2/3] ARM: dts: vf610-zii-dev: Add .dts file for rev. C

2016-12-03 Thread Andrey Smirnov
Add .dts file for rev. C of the board by factoring out commonalities into a shared include file (vf610-zii-dev.dtsi) and deriving revision specific file from it (vf610-zii-dev-rev-b.dts and vf610-zii-dev-reb-c.dts). Signed-off-by: Andrey Smirnov --- Changes since v1: - Removed fixed-link

Re: [PATCH 39/39] mtd: nand: denali_dt: add compatible strings for UniPhier SoC variants

2016-12-03 Thread Dinh Nguyen
Hi, On Fri, Dec 2, 2016 at 8:49 PM, Marek Vasut wrote: > On 12/03/2016 03:41 AM, Masahiro Yamada wrote: >> Hi Rob, > > Hi! > >> 2016-12-03 1:26 GMT+09:00 Rob Herring : >> (Plan A) "denali,socfpga-nand" (for Altera SOCFPGA variant) "denali,uniphier-nand-v1"

Re: [PATCH 0/6] UBIFS related fscrypt updates

2016-12-03 Thread Theodore Ts'o
On Thu, Dec 01, 2016 at 11:14:52PM +0100, Richard Weinberger wrote: > This series applies on top of Ted's fscrypt tree[0] addresses the review > comments from Eric. > Ted, it would be awesome to have this patches in the v4.10 merge window. Your patch 4/6 won't apply on my branch because it referen

Re: [PATCH 2/2 v2] sched: use load_avg for selecting idlest group

2016-12-03 Thread Matt Fleming
On Fri, 02 Dec, at 07:31:04PM, Brendan Gregg wrote: > > For background, is this from the "A decade of wasted cores" paper's > patches? No, this patch fixes an issue I originally reported here, https://lkml.kernel.org/r/20160923115808.2330-1-m...@codeblueprint.co.uk Essentially, if you have an

Re: [PATCH 1/1 linux-next] ext4: fix block_validity definition

2016-12-03 Thread Theodore Ts'o
I've applied this patch with some further cleanups. The documentation for the mount options now reads: block_validity(*) These options enable or disable the in-kernel noblock_validityfacility for tracking filesystem metadata blocks within internal data struct

Re: [RFC PATCH 2/2] Documentation: devictree: Add macb mdio bindings

2016-12-03 Thread Rob Herring
On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote: > Add documentations for macb mdio driver. Bindings document h/w, not drivers. > > Signed-off-by: Harini Katakam > --- > .../devicetree/bindings/net/macb-mdio.txt | 31 > ++ > 1 file changed, 31 inser

Re: [PATCH] dt-bindings: add MYIR Tech hardware vendor prefix

2016-12-03 Thread Rob Herring
On Mon, Nov 28, 2016 at 09:56:51AM +0200, Vladimir Zapolskiy wrote: > MYIR Tech Limited offers a range of ARM powered development boards and SoMs, > for details reference a list on http://elinux.org/Development_Platforms#ARM > or company's website http://myirtech.com > > Signed-off-by: Vladimir Za

Re: [PATCH 1/6] net: stmmac: return error if no DMA configuration is found

2016-12-03 Thread David Miller
When you post a series of related changes as a patch set, you must provide a proper "[PATCH 0/N] ..." posting which explains what the series is doing at a high level, how it is doing it, and why it is doing it that way. Please repost this entire series with a proper header posting included. Than

Re: [PATCH 1/1] net: caif: fix ineffective error check

2016-12-03 Thread Sergei Shtylyov
On 12/03/2016 06:38 PM, Pan Bian wrote: In function caif_sktinit_module(), the check of the return value of sock_register() seems ineffective. This patch fixes it. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751 Signed-off-by: Pan Bian --- net/caif/caif_socket.c | 2 +- 1 file ch

[PATCH] ARM: OMAP2+: PRM: Delete an error message for a failed memory allocation

2016-12-03 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 3 Dec 2016 21:46:02 +0100 Omit an extra message for a memory allocation failure in this function. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- arch/arm/mach-omap2/prm_comm

[git pull] drm fixes for v.4.9

2016-12-03 Thread Dave Airlie
Hi Linus, I awoke this morning to realise I hadn't sent my -fixes pull, I then discovered the office where my build and sign tags machine had a power cut, and since nobody will be in until tomorrow I can't restart my desktop. So this tag is unsigned due to that and the realisation I don't keep my

Re: [PATCH 1/7] net: ethernet: ti: cpdma: am437x: allow descs to be plased in ddr

2016-12-03 Thread David Miller
From: Grygorii Strashko Date: Thu, 1 Dec 2016 17:34:26 -0600 > @@ -167,10 +167,10 @@ static struct cpdma_control_info controls[] = { > > /* various accessors */ > #define dma_reg_read(ctlr, ofs) __raw_readl((ctlr)->dmaregs + > (ofs)) > -#define chan_read(chan, fld) __raw

Re: [PATCH 2/2] net: stmmac: unify mdio functions

2016-12-03 Thread David Miller
From: Corentin Labbe Date: Thu, 1 Dec 2016 16:19:41 +0100 > stmmac_mdio_{read|write} and stmmac_mdio_{read|write}_gmac4 are not > enought different for being split. > The only differences between thoses two functions are shift/mask for > addr/reg/clk_csr. > > This patch introduce a per platform

  1   2   3   >