Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-03 Thread SF Markus Elfring
>> NAK, just noise. > > And frankly I hate that leading space. Would you like to comment the recent update of the document "CodingStyle" any more? https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 Regard

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread SF Markus Elfring
>> Which test environments would you find acceptable for further clarification? > > Compiling it on GCC for Sparc, obviously. Are there any more configuration details to consider? >>> I must also point out that these sorts of optimisations are things the >>> compiler does automatically when com

[PATCH] [SCSI] aacraid: mark aac_src_select_comm() static

2016-09-03 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/scsi/aacraid/src.c:616:5: warning: no previous prototype for 'aac_src_select_comm' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this p

[PATCH] drm/imx: Fix of_node ref counting

2016-09-03 Thread Christophe JAILLET
This code is spurious. It takes a ref on a node, then call 'of_node_put' on it and then store this node somewhere. It is likely that taking the ref on the parent node and releasing the child node was expected instead. So, use 'of_get_next_parent' instead. It does all this in just one function cal

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread Julian Calaby
Hi David, On Sun, Sep 4, 2016 at 4:32 PM, David Miller wrote: > > Markus, I'm really not going to consider any of these changes. > > And your replies to the feedback you were given disappoint me even > more. > > Please don't submit any more sparc patches until you can get you act > in gear and no

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread David Miller
Markus, I'm really not going to consider any of these changes. And your replies to the feedback you were given disappoint me even more. Please don't submit any more sparc patches until you can get you act in gear and not waste everyone's time. Thank you.

[PATCH] staging: media: omap4iss: mark omap4iss_flush() static

2016-09-03 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/staging/media/omap4iss/iss.c:64:6: warning: no previous prototype for 'omap4iss_flush' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so th

[PATCH] staging: ks7010: mark symbols static where possible

2016-09-03 Thread Baoyou Xie
We get 2 warnings when building kernel with W=1: drivers/staging/ks7010/ks_hostif.c:72:6: warning: no previous prototype for 'ks_wlan_hw_wakeup_task' [-Wmissing-prototypes] drivers/staging/ks7010/ks_hostif.c:1508:6: warning: no previous prototype for 'hostif_infrastructure_set2_request' [-Wmissin

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread David Miller
From: SF Markus Elfring Date: Sun, 4 Sep 2016 07:45:04 +0200 >> and wasting everyone's time in the process. > > I assume that a few contributors can take the presented ideas for further > considerations. > Will their value evolve a bit more later? No, really, you are wasting everyone's time.

[PATCH] Staging: rtl8192e: mark symbols static where possible

2016-09-03 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/staging/rtl8192e/rtllib_softmac.c:279:13: warning: no previous declaration for 'softmac_ps_mgmt_xmit' [-Wmissing-declarations] drivers/staging/rtl8192e/rtllib_softmac.c:773:24: warning: no previous declaration for 'rtllib_authentication

Re: [PATCH 4/4] sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-03 Thread David Miller
From: Daniel Borkmann Date: Sat, 03 Sep 2016 18:52:44 +0200 > On 09/03/2016 06:41 PM, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Sat, 3 Sep 2016 18:14:19 +0200 >> >> Adjust jump labels according to the current Linux coding style >> convention. >> >> Signed-off-by: Markus Elfring

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread Julian Calaby
Hi Markus, On Sun, Sep 4, 2016 at 3:45 PM, SF Markus Elfring wrote: >>> I hope so. - I propose to give the refactorings "Reduce scope of variable" >>> and "Extract a function" (and the corresponding consequences) another look. >> >> So you _think_ it does. Come back with real proof. > > Which tes

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread SF Markus Elfring
>> I hope so. - I propose to give the refactorings "Reduce scope of variable" >> and "Extract a function" (and the corresponding consequences) another look. > > So you _think_ it does. Come back with real proof. Which test environments would you find acceptable for further clarification? > I mu

[PATCH] ARM: LPAE: initialize cachepolicy correctly

2016-09-03 Thread Stefan Agner
The cachepolicy variable gets initialized using a masked pmd So far, the pmd has been masked with flags valid for the 2-page table format. In the LPAE case, this lead to a wrong assumption of what the initial cachepolicy has been used. Later a check forces the cache policy to writealloc and prints

Re: [PATCH 2/4] sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread Julian Calaby
Hi Markus, On Sun, Sep 4, 2016 at 2:33 PM, SF Markus Elfring wrote: >>> Date: Sat, 3 Sep 2016 17:45:28 +0200 >>> >>> Move the assignments for four local variables a bit at the beginning >>> so that they will only be performed if a corresponding memory allocation >>> succeeded by this function. >

Re: [PATCH v2 0/3] Add Platform MHU mailbox driver for Amlogic GXBB

2016-09-03 Thread Jassi Brar
On Sun, Sep 4, 2016 at 2:15 AM, Kevin Hilman wrote: > On Fri, Sep 2, 2016 at 10:33 PM, Jassi Brar wrote: >> On Sat, Sep 3, 2016 at 5:04 AM, Kevin Hilman wrote: >>> Hi Jassi, >>> >>> Neil Armstrong writes: >>> In order to support Mailbox links for the Amlogic GXBB SoC, add a generic pl

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread Julian Calaby
Hi Markus, On Sun, Sep 4, 2016 at 3:00 PM, SF Markus Elfring wrote: >> Does this change improve the resulting binary? > > I hope so. - I propose to give the refactorings "Reduce scope of variable" > and "Extract a function" (and the corresponding consequences) another look. So you _think_ it doe

arch/mips/include/asm/mach-cavium-octeon/mangle-port.h:19:40: error: right shift count >= width of type

2016-09-03 Thread kbuild test robot
Hi Steven, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 28e68154c5e2793123b248d38cf17b34dcb16d87 commit: 1685ddbe35cd4637f7f841d5f9755dd0470bd68d MIPS: Octeon: Changes to support readq()/writeq() usage. date: 8

Re: cmsg newgroup alt.sex.fetish.bool (was Re: [PATCH] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions)

2016-09-03 Thread Al Viro
On Sun, Sep 04, 2016 at 06:36:56AM +0800, Chen Gang wrote: > And for all: shall I provide the proof for another archs? > > For me, Boolean gives additional chance to compiler to improve the code. Whereas for compiler it gives nothing. Not in those cases. > If the compiler can not improve the c

[PATCH 1/3 (fix commit message)] perf tools: Recognize hugetlb mapping as anon mapping

2016-09-03 Thread Wang Nan
Hugetlbfs mapping should be recognized as anon mapping so user has a chance to create /tmp/perf-.map file for symbol resolving. This patch utilizes MAP_HUGETLB to identify hugetlb mapping. After this patch, if perf is started before the program starts using huge pages (so perf gets MMAP2 events fr

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread SF Markus Elfring
> Does this change improve the resulting binary? I hope so. - I propose to give the refactorings "Reduce scope of variable" and "Extract a function" (and the corresponding consequences) another look. > I.e. does it make it smaller or faster? It is generally possible that a specific code generat

[tip:timers/core 6/6] include/trace/events/alarmtimer.h:62: undefined reference to `rtc_ktime_to_tm'

2016-09-03 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core head: a0a6e06d545a753740c9d8d5ce2c4fdd3ab1c021 commit: a0a6e06d545a753740c9d8d5ce2c4fdd3ab1c021 [6/6] time: alarmtimer: Add tracepoints for alarmtimers config: s390-default_defconfig (attached as .config) compiler: s

Re: [PATCH 2/4] sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread SF Markus Elfring
>> Date: Sat, 3 Sep 2016 17:45:28 +0200 >> >> Move the assignments for four local variables a bit at the beginning >> so that they will only be performed if a corresponding memory allocation >> succeeded by this function. … >> @@ -362,10 +362,10 @@ do { *prog++ = BR_OPC | WDISP22(OFF);

[PATCH] video: mxsfb: get supply regulator optionally

2016-09-03 Thread Stefan Agner
The lcd-supply is meant to be optional, there are several device- trees not specifying it and the code handles error values silently. Therefor, avoid creating a dummy regulator (and the associated warning) by using devm_regulator_get_optional. While at it, document that fact also in the device-tre

Re: [PATCH 09/15] virtio-blk: Pass attribute group to device_add_disk

2016-09-03 Thread Michael S. Tsirkin
On Wed, Aug 17, 2016 at 03:15:09PM +0800, Fam Zheng wrote: > Previously after device_add_disk returns, the KOBJ_ADD uevent is already > emitted. Adding attributes after that is a poor usage of kobject, and > in practice may result in race conditions with userspace, for > example udev checks availab

[PATCH] usb: phy: generic: request regulator optionally

2016-09-03 Thread Stefan Agner
According to the device tree bindings the vcc-supply is optional. So far the driver did request the regulator using devm_regulator_get which creates a dummy regulator for convenience. Since we can have the supply unconnected, we should make use of the optional variant of the regulator call which do

Apply Today

2016-09-03 Thread Loan Firm
Dear Sir/Madam, We give out urgent loan for business and personal purpose with 3% intrest rate applicable to all amount. Kindly get back to us via email: loa...@foxmail.com for further details on how to apply.

Re: [PATCH 2/2] mwifiex: simplify length computation for some memset

2016-09-03 Thread Julian Calaby
Hi All, On Mon, Aug 8, 2016 at 5:39 PM, Christophe JAILLET wrote: > This patch should be a no-op. It just simplifies code by using the name of > a variable instead of its type when calling 'sizeof'. > > Signed-off-by: Christophe JAILLET Reviewed-by: Julian Calaby Thanks, -- Julian Calaby E

core.c:undefined reference to `fpu_save'

2016-09-03 Thread kbuild test robot
Hi Andrew, It's probably a bug fix that unveils the link errors. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 28e68154c5e2793123b248d38cf17b34dcb16d87 commit: c60f169202c7643991a8b4bfeea60e06843d5b5a arch/mn10300/kernel/fpu-nofpu.c: needs asm/elf.h d

Re: [PATCH 2/4] sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread Julian Calaby
Hi Markus, On Sun, Sep 4, 2016 at 2:38 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 3 Sep 2016 17:45:28 +0200 > > Move the assignments for four local variables a bit at the beginning > so that they will only be performed if a corresponding memory allocation > succeeded by thi

Re: [PATCH] ath10k: Spelling and miscellaneous neatening

2016-09-03 Thread Julian Calaby
Hi All, On Tue, Aug 30, 2016 at 3:05 AM, Joe Perches wrote: > Correct some trivial comment typos. > Remove unnecessary parentheses in a long line. > Convert a return; before the end of a void function definition to just ; > > Signed-off-by: Joe Perches This all looks correct to me. I wish you'd

Re: [PATCH] staging: wilc1000: fix spelling mistake: "retyring" -> "retrying"

2016-09-03 Thread Julian Calaby
Hi All, On Sun, Aug 28, 2016 at 9:28 PM, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in dev_err message > > Signed-off-by: Colin Ian King Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/prof

Re: [PATCH] rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

2016-09-03 Thread Julian Calaby
Hi All, On Sun, Sep 4, 2016 at 2:43 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistakes in dev_dbg message. > > Signed-off-by: Colin Ian King Reviewed-by: Julian Calaby Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/pro

Re: [RFC 2/4] mm: replace TIF_MEMDIE checks by tsk_is_oom_victim

2016-09-03 Thread Tetsuo Handa
Michal Hocko wrote: > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 9ee178ba7b71..df58733ca48e 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1899,7 +1899,7 @@ static int try_charge(struct mem_cgroup *memcg, gfp_t > gfp_mask, >* bypass the last charges so that they c

Re: [RFC 3/4] mm, oom: do not rely on TIF_MEMDIE for exit_oom_victim

2016-09-03 Thread Tetsuo Handa
Michal Hocko wrote: > mark_oom_victim and exit_oom_victim are used for oom_killer_disable > which should block as long as there any any oom victims alive. Up to now > we have relied on TIF_MEMDIE task flag to count how many oom victim > we have. This is not optimal because only one thread receives

Re: [RFC 1/4] mm, oom: do not rely on TIF_MEMDIE for memory reserves access

2016-09-03 Thread Tetsuo Handa
Michal Hocko wrote: > @@ -816,7 +816,8 @@ static void oom_kill_process(struct oom_control *oc, > const char *message) > > /* >* If the task is already exiting, don't alarm the sysadmin or kill > - * its children or threads, just set TIF_MEMDIE so it can die quickly > + *

drivers/media/v4l2-core/videobuf2-dma-contig.c:486:2: error: implicit declaration of function 'dma_get_cache_alignment'

2016-09-03 Thread kbuild test robot
Hi Hans, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 28e68154c5e2793123b248d38cf17b34dcb16d87 commit: c1023ba74fc77dc56dc317bd98f5060aab889ac1 [media] drivers/media/platform/Kconfig: fix VIDEO_MEDIATEK_VCODEC de

[RFC v5 16/23] clockevents: clockevents_program_min_delta(): don't set ->next_event

2016-09-03 Thread Nicolai Stange
Currently, clockevents_program_min_delta() sets a clockevent device's ->next_event to the point in time where the minimum delta would actually expire: delta = dev->min_delta_ns; dev->next_event = ktime_add_ns(ktime_get(), delta); For your reference, this is so since the initial advent of cloc

Re: [Question] about patch: don't use [delayed_]work_pending()

2016-09-03 Thread Andreas Mohr
Hi, [no properly binding reference via In-Reply-To: available thus manually re-creating, sorry] https://lkml.org/lkml/2016/9/2/335 I came up with the following somewhat random thoughts: *** this treatment is exclusive to a single use case, i.e. not covering things consistently (API-wide) > +

[RFC v5 20/23] clockevents: purge ->min_delta_ns

2016-09-03 Thread Nicolai Stange
The struct clock_event_device's ->min_delta_ns member isn't used anymore. Purge it. In __clockevents_update_bounds(), shortcut the ->min_delta_ticks => ->min_delta_ns => ->min_delta_ticks_adjusted calculation detour -- it had been made solely for the purpose of ensuring that ->min_delta_ticks_a

[RFC v5 14/23] clockevents: decouple ->max_delta_ns from ->max_delta_ticks

2016-09-03 Thread Nicolai Stange
Before converting the given delta from ns to cycles by means of the mult/shift pair, clockevents_program_event() enforces it to be less or equal than ->max_delta_ns. Simplified, this reads as delta = min(delta, dev->max_delta_ns); clc = (delta * dev->mult) >> dev->shift; A device's ->max_delt

[RFC v5 17/23] clockevents: use ->min_delta_ticks_adjusted to program minimum delta

2016-09-03 Thread Nicolai Stange
The use of a clockevent device's ->min_delta_ns in the event programming path hinders upcoming changes to the clockevent core making it NTP correction aware: both, ->mult and ->min_delta_ns would need to get updated as well as consumed atomically and we'd rather like to avoid any locking here. We

[RFC v5 21/23] clockevents: initial support for mono to raw time conversion

2016-09-03 Thread Nicolai Stange
With NOHZ_FULL and one single well-isolated, CPU consumptive task, one would expect approximately one clockevent interrupt per second. However, on my Intel Haswell where the monotonic clock is the TSC monotonic clock and the clockevent device is the TSC deadline device, it turns out that every seco

[RFC v5 19/23] timer_list: print_tickdevice(): calculate ->min_delta_ns dynamically

2016-09-03 Thread Nicolai Stange
print_tickdevice(), assembling the per-tick device sections in /proc/timer_list, is the last user of struct clock_event_device's ->min_delta_ns member. In order to make this one fully obsolete while retaining userspace ABI, calculate the displayed value of 'min_delta_ns' on the fly from ->min_delt

[RFC v5 18/23] clockevents: min delta increment: calculate min_delta_ns from ticks

2016-09-03 Thread Nicolai Stange
The use of a clockevent device's ->min_delta_ns in the event programming path hinders upcoming changes to the clockevent core making it NTP correction aware: both, ->mult and ->min_delta_ns would need to get updated as well as consumed atomically and we'd rather like to avoid any locking here. We

[RFC v5 22/23] clockevents: make setting of ->mult and ->mult_adjusted atomic

2016-09-03 Thread Nicolai Stange
In order to avoid races between setting a struct clock_event_device's ->mult_adjusted in clockevents_update_freq() and yet to be implemented updates triggered from the timekeeping core, the setting of ->mult and ->mult_adjusted should be made atomic. Protect the update in clockevents_update_freq()

[RFC v5 23/23] timekeeping: inform clockevents about freq adjustments

2016-09-03 Thread Nicolai Stange
Upon adjustments of the monotonic clock's frequencies from the timekeeping core, the clockevents devices' ->mult_adjusted should be changed accordingly, too. Introduce clockevents_adjust_all_freqs() which traverses all registered clockevent devices and, if the CLOCK_EVT_FEAT_NO_ADJUST flag is not

[RFC v5 15/23] clockevents: do comparison of delta against minimum in terms of cycles

2016-09-03 Thread Nicolai Stange
Before converting the given delta from ns to cycles by means of the mult/shift pair, clockevents_program_event() enforces it to be greater or equal than ->max_delta_ns. Simplified, this reads as delta = max(delta, dev->min_delta_ns); clc = (delta * dev->mult) >> dev->shift; Note that ->min_de

[RFC v5 12/23] many clockevent drivers: don't set ->min_delta_ns and ->max_delta_ns

2016-09-03 Thread Nicolai Stange
Now that the clockevent core always initializes the ->*_delta_ns values from their ->_delta_ticks counterparts, there is no point in having the clockevent devices' drivers doing so as well. Don't initialize ->min_delta_ns and ->max_delta_ns from the clockevent devices' drivers. This patch was cre

[RFC v5 13/23] clockevents: introduce CLOCK_EVT_FEAT_NO_ADJUST flag

2016-09-03 Thread Nicolai Stange
Upcoming changes to the clockevent core will make it adjusting a clockevent device's mult/shift pair in order to compensate for NTP corrections made by the timekeeping core. For certain devices this behaviour is unwanted. Introduce the CLOCK_EVT_FEAT_NO_ADJUST flag that, when being set, will cause

[RFC v5 02/23] clocksource: sh_tmu: compute rate before registration again

2016-09-03 Thread Nicolai Stange
With the upcoming NTP correction related rate adjustments to be implemented in the clockevents core, the latter needs to get informed about every rate change of a clockevent device made after its registration. Currently, sh_tmu violates this requirement in that it registers its clockevent device w

[RFC v5 09/23] arch/x86/platform/uv/uv_time: set ->min_delta_ticks and ->max_delta_ticks

2016-09-03 Thread Nicolai Stange
With the yet to come introduction of NTP correction awareness to the clockevent core, drivers should report their valid ranges in units of cycles to the latter. Currently, the x86's uv rtc clockevent device is initialized as follows: clock_event_device_uv.min_delta_ns = NSEC_PER_SEC /

[RFC v5 07/23] many clockevent drivers: set ->min_delta_ticks and ->max_delta_ticks

2016-09-03 Thread Nicolai Stange
The struct clock_event_device has got the ->min_delta_ns, ->max_delta_ns, ->min_delta_ticks and ->max_delta_ticks members for setting the bounds of valid deltas to be programmed. During operation, the clockevent core uses the ->*_delta_ns versions only. OTOH, the ->*_delta_ticks are currently used

[RFC v5 10/23] arch/tile/kernel/time: set ->min_delta_ticks and ->max_delta_ticks

2016-09-03 Thread Nicolai Stange
With the yet to come introduction of NTP correction awareness to the clockevent core, drivers should report their valid ranges in units of cycles to the latter. Currently, the tile's timer clockevent device is initialized as follows: evt->max_delta_ns = clockevent_delta2ns(MAX_TICK, evt); and

[RFC v5 01/23] clocksource: sh_cmt: compute rate before registration again

2016-09-03 Thread Nicolai Stange
With the upcoming NTP correction related rate adjustments to be implemented in the clockevents core, the latter needs to get informed about every rate change of a clockevent device made after its registration. Currently, sh_cmt violates this requirement in that it registers its clockevent device w

[RFC v5 00/23] adapt clockevents frequencies to mono clock

2016-09-03 Thread Nicolai Stange
Goal: avoid programming ced devices too early for large deltas, for details, for details, c.f. the description of [21/23]. Previous v4 of this series can be found here: http://lkml.kernel.org/r/20160822233320.4548-1-nicsta...@gmail.com Raised concerns were 1.) There should be a flag ava

[RFC v5 11/23] clockevents: always initialize ->min_delta_ns and ->max_delta_ns

2016-09-03 Thread Nicolai Stange
Now that all clockevent drivers set ->min_delta_ticks and ->max_delta_ticks independently of whether they use clockevents_config*() or not, the clockevent core can calculate ->min_delta_ns and ->max_delta_ns from these unconditionally. The goal is to prepare the clockevent core for introducing NTP

[RFC v5 04/23] clocksource: em_sti: compute rate before registration

2016-09-03 Thread Nicolai Stange
With the upcoming NTP correction related rate adjustments to be implemented in the clockevents core, the latter needs to get informed about every rate change of a clockevent device made after its registration. Currently, em_sti violates this requirement in that it registers its clockevent device w

[RFC v5 03/23] clocksource: em_sti: split clock prepare and enable steps

2016-09-03 Thread Nicolai Stange
Currently, the em_sti driver prepares and enables the needed clock in em_sti_enable(), potentially called through its clockevent device's ->set_state_oneshot(). However, the clk_prepare() step may sleep whereas tick_program_event() and thus, ->set_state_oneshot(), can be called in atomic context.

[RFC v5 05/23] clocksource: h8300_timer8: don't reset rate in ->set_state_oneshot()

2016-09-03 Thread Nicolai Stange
With the upcoming NTP correction related rate adjustments to be implemented in the clockevents core, the latter needs to get informed about every rate change of a clockevent device made after its registration. Currently, h8300_timer8 violates this requirement in that it registers its clockevent de

[RFC v5 06/23] clockevents: make clockevents_config() static

2016-09-03 Thread Nicolai Stange
A clockevent device's rate should be configured before or at registration and changed afterwards through clockevents_update_freq() only. For the configuration at registration, we already have clockevents_config_and_register(). Right now, there are no clockevents_config() users outside of the cloc

[RFC v5 08/23] arch/s390/kernel/time: set ->min_delta_ticks and ->max_delta_ticks

2016-09-03 Thread Nicolai Stange
With the yet to come introduction of NTP correction awareness to the clockevent core, drivers should report their valid ranges in units of cycles to the latter. Currently, the s390's CPU timer clockevent device is initialized as follows: cd->min_delta_ns= 1; cd->max_delta_ns= LONG_MAX

Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions

2016-09-03 Thread kbuild test robot
Hi Chen, [auto build test ERROR on linus/master] [also build test ERROR on v4.8-rc4 next-20160825] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what

Re: [PATCH V4] leds: trigger: Introduce an USB port trigger

2016-09-03 Thread Alan Stern
On Sat, 3 Sep 2016, Jacek Anaszewski wrote: > >> The remaining issue is the sysfs interface design for defining and > >> presenting multiple USB ports. I'm still in favour of a single > >> attribute with space separated list. This scheme is commonly used > >> in existing interfaces. > > > > No suc

include/linux/kprobes.h:332:2: error: invalid use of undefined type 'struct kprobe_ctlblk'

2016-09-03 Thread kbuild test robot
Hi Christoph, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4b30b6d126ca8b23b319f5329570f6855736a095 commit: abec1a806e0c3cf168999667d5fb6218398ef12a percpu: Make __verify_pcu_ptr handle per cpu pointers to arrays

Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions

2016-09-03 Thread kbuild test robot
Hi Chen, [auto build test ERROR on linus/master] [also build test ERROR on v4.8-rc4 next-20160825] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what

arch/mips/vdso/gettimeofday.c:1:0: error: '-march=r3900' requires '-mfp32'

2016-09-03 Thread kbuild test robot
Hi Guenter, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4b30b6d126ca8b23b319f5329570f6855736a095 commit: 398c7500a1f5f74e207bd2edca1b1721b3cc1f1e MIPS: VDSO: Fix build error with binutils 2.24 and earlier date

mipsel-linux-gnu-gcc: error: unrecognized command line option '-mcompact-branches=optimal'

2016-09-03 Thread kbuild test robot
Hi Paul, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4b30b6d126ca8b23b319f5329570f6855736a095 commit: c1a0e9bc885d46e519fd87d35af6a7937abfb986 MIPS: Allow compact branch policy to be changed date: 10 months ag

Re: [PATCH][RT] netpoll: Always take poll_lock when doing polling

2016-09-03 Thread Alison Chaiken
I asked on 2016-06-07 17:19:43 [-0700]: >>cpsw_rx_poll() is called even when there is essentially no network >>traffic, so I'm not sure how to tell if NAPI is working as intended. On Thu, Jun 9, 2016 at 5:37 AM, Sebastian Andrzej Siewior wrote: > You should see an invocation of __raise_softirq_i

arch/mips/vdso/elf.S:1:0: error: '-march=r3900' requires '-mfp32'

2016-09-03 Thread kbuild test robot
Hi Alex, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4b30b6d126ca8b23b319f5329570f6855736a095 commit: ebb5e78cc63417a35254a791de66e1cc84f963cc MIPS: Initial implementation of a VDSO date: 10 months ago config:

Re: [PATCH 2/2] Staging: comedi: pcl726.c, ni_670x.c: Fix warnings and check.

2016-09-03 Thread kbuild test robot
Hi Amit, [auto build test ERROR on v4.8-rc4] [cannot apply to staging/staging-testing next-20160825] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record wha

Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform

2016-09-03 Thread Sergei Shtylyov
On 09/04/2016 12:55 AM, Randy Li wrote: On the rk3288 USB host-only port (the one that's not the OTG-enabled port) the PHY can get into a bad state when a wakeup is asserted (not just a wakeup from full system suspend but also a wakeup from autosuspend). We can get the PHY out of its bad state

Re: cmsg newgroup alt.sex.fetish.bool (was Re: [PATCH] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions)

2016-09-03 Thread Chen Gang
On 9/3/16 08:07, Vineet Gupta wrote: > On 09/02/2016 04:33 PM, Chen Gang wrote: >> On 9/2/16 04:43, Al Viro wrote: Can you show a proof that it actually improves anything? He who proposes a patch gets to defend it, not the other way round... Al, bloody annoyed >> OK,

[PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-03 Thread Amit Ghadge
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/d

[PATCH 2/2] Staging: comedi: pcl726.c, ni_670x.c: Fix warnings and check.

2016-09-03 Thread Amit Ghadge
pcl726.c: Replace CamelCase range_0_20mA by range_0_20ma ni_670x.c: Fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid of checkpatch.pl "CHECK" output "Prefer using the BIT macro". Replace CamelCase range_0_20mA to

[PATCH] checkpatch: Add a --strict test for macro argument reuse and precedence

2016-09-03 Thread Joe Perches
Add a test for reuse of macro arguments to highlight any possible side-effects from this reuse. Avoid this check on token name pasting and when the argument is used in a typeof or a __builtin. Add a test for macro arguents that have leading or trailing operators where the argument isn't parenthes

Re: [Documentation] State of CPU controller in cgroup v2

2016-09-03 Thread Tejun Heo
Hello, Andy. On Wed, Aug 31, 2016 at 02:46:20PM -0700, Andy Lutomirski wrote: > > Consider a use case where the user isn't interested in fully > > accounting and dividing up system resources but wants to just cap > > resource usage from a subset of workloads. There is no reason to > > require suc

[PATCH v7 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup

2016-09-03 Thread Randy Li
It is a hardware bug in RK3288, the only way to solve it is to reset the phy. Signed-off-by: Randy Li --- .../devicetree/bindings/phy/rockchip-usb-phy.txt | 3 +++ drivers/phy/phy-rockchip-usb.c | 20 2 files changed, 23 insertions(+) diff --git a

[PATCH v7 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset

2016-09-03 Thread Randy Li
The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 has a hardware errata that causes everything to get confused when we get a remote wakeup. We'll use the reset that's in the CRU to reset the port when it's in a bad state. Note that we add the reset to both dwc2 controllers ev

[PATCH v7 0/4] the fix for the USB HOST1 at rk3288 platform

2016-09-03 Thread Randy Li
changelog: v7 Some minor fixup v6 Send the last two patches v5 A few modification at style, add the missing doc in the last commit. v4 1. Adding the reset callback in struct phy_ops. 2. Moving the reset into phy rockchip usb. 3. Trying to call a reset when dwc2 wakeup in rk3288. v3

[PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform

2016-09-03 Thread Randy Li
On the rk3288 USB host-only port (the one that's not the OTG-enabled port) the PHY can get into a bad state when a wakeup is asserted (not just a wakeup from full system suspend but also a wakeup from autosuspend). We can get the PHY out of its bad state by asserting its "port reset", but unfortun

[PATCH v7 1/4] phy: Add reset callback

2016-09-03 Thread Randy Li
The only use for this is for solving a hardware design problem in usb of Rockchip RK3288. Signed-off-by: Randy Li --- include/linux/phy/phy.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h index f08b672..4d34607 100644 --- a/include/linux/

Re: [PATCH v2 0/3] Add Platform MHU mailbox driver for Amlogic GXBB

2016-09-03 Thread Kevin Hilman
On Fri, Sep 2, 2016 at 10:33 PM, Jassi Brar wrote: > On Sat, Sep 3, 2016 at 5:04 AM, Kevin Hilman wrote: >> Hi Jassi, >> >> Neil Armstrong writes: >> >>> In order to support Mailbox links for the Amlogic GXBB SoC, add a generic >>> platform MHU driver based on arm_mhu.c. >>> >>> This patchset fo

Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

2016-09-03 Thread kbuild test robot
Hi Amit, [auto build test ERROR on v4.8-rc4] [cannot apply to staging/staging-testing next-20160825] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record wha

[PATCH] unicore32-pm: Use kmalloc_array() in puv3_pm_init()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 3 Sep 2016 22:34:32 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle so

Re: Possible code defects: macros and precedence

2016-09-03 Thread Dan Carpenter
No. I can't think of a way to write a script for that in smatch. It works on the pre-processed code. There is a hack around to tell if code is inside a macro or not, but you can't tell if code is a macro parameter. regards, dan carpenter

[PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-03 Thread Amit Ghadge
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/d

[PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

2016-09-03 Thread Amit Ghadge
Fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid of checkpatch.pl "CHECK" output "Prefer using the BIT macro". Replace Avoid CamelCase range_0_20mA to range_0_20ma. Signed-off-by: Amit Ghadge --- drivers/stagin

[PATCH] kbuild/builddeb: Fix !CONFIG_GCC_PLUGINS build

2016-09-03 Thread Borislav Petkov
From: Borislav Petkov When building a bindeb-pkg target into an object output dir, i.e., O=, I get: find: `scripts/gcc-plugins': No such file or directory /mnt/kernel/kernel/linux-2.6/scripts/package/Makefile:97: recipe for target 'bindeb-pkg' failed make[3]: *** [bindeb-pkg] Error 1 /m

Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750_chip.c

2016-09-03 Thread Moshe Green
On Fri, Sep 02, 2016 at 01:35:08PM +0200, Greg KH wrote: > > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply

Re: [PATCH v4] iio: humidity: hdc100x: add triggered buffer support for HDC100X

2016-09-03 Thread Jonathan Cameron
On 02/09/16 18:23, Alison Schofield wrote: > Triggered buffer support uses the HDC100X's dual acquisition mode > to read both humidity and temperature in one shot. > > This patch depends on > 447136effbf4 ("iio: humidity: hdc100x: fix sensor data reads of > temp and humi

[PATCH] [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-03 Thread Amit Ghadge
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/d

Re: [PATCH v3 1/4] hwmon: iio_hwmon: delay probing with late_initcall

2016-09-03 Thread Jonathan Cameron
On 01/09/16 10:03, Quentin Schulz wrote: > On 01/09/2016 09:15, Quentin Schulz wrote: >> On 15/08/2016 23:35, Jonathan Cameron wrote: >>> >>> >>> On 15 August 2016 18:07:30 BST, Guenter Roeck wrote: On Mon, Aug 15, 2016 at 04:40:21PM +0100, Jonathan Cameron wrote: > On 26/07/16 17:04, Gue

[PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-03 Thread Amit Ghadge
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/d

Preventing the kernel to perform i/o on plugged in HDD

2016-09-03 Thread David Balažic
Hi! I'm trying to rescue some data from a damaged HDD (attached over USB) and run into the problem that when reading from a damaged part of the drive, it goes into "panic mode" and refusing access even to good parts (happened before with other drive). As the kernel reads the partitioning related

tty, fbcon: use-after-free in fbcon_invert_region

2016-09-03 Thread Dmitry Vyukov
Hello, The following program causes use-after-free in fbcon_invert_region: https://gist.githubusercontent.com/dvyukov/d657f9a9ca39f34c430dcf63ec1153ac/raw/04e1b94aef0fc9eb770d11373b568980ecaa7f34/gistfile1.txt == BUG: KASAN: use-aft

Re: [PATCH V4] leds: trigger: Introduce an USB port trigger

2016-09-03 Thread Jacek Anaszewski
On 09/03/2016 05:17 PM, Alan Stern wrote: On Sat, 3 Sep 2016, Jacek Anaszewski wrote: Maybe it would make more sense, in this case, to allow only three possibilities for a USB port activity trigger. Toggle the LED whenever: There is activity on the specified port, or There is

[PATCH 2/2] tile-module: Rename jump labels in module_alloc()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 3 Sep 2016 20:45:20 +0200 Adjust jump labels according to the current Linux coding style convention. Signed-off-by: Markus Elfring --- arch/tile/kernel/module.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/arch/tile/kernel/module.

[PATCH 1/2] tile-module: Use kmalloc_array() in module_alloc()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 3 Sep 2016 20:40:57 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". * Replace the specification of a data type by a poin

[PATCH 0/2] tile-module: Fine-tuning for module_alloc()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 3 Sep 2016 20:52:10 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use kmalloc_array() Rename jump labels arch/tile/kernel/module.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-

  1   2   3   4   >