*|Deposit|*

2015-10-10 Thread Maria
Accept 19M USD as a cash gift? Write back asap. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH v3] ALSA: bebob: constify various snd_bebob structures

2015-10-10 Thread Julia Lawall
The structures of type snd_bebob_clock_spec, snd_bebob_rate_spec, snd_bebob_meter_spec, and snd_bebob_spec are never modified after they are initialized. Make them all const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- v3: change subject line sound/firewire/bebob/bebob

Re: [PATCH v2] ALSA: bebob: constify snd_bebob_rate_spec structures

2015-10-10 Thread Julia Lawall
On Sun, 11 Oct 2015, Takashi Sakamoto wrote: > Hi, > > On Oct 11 2015 06:24, Julia Lawall wrote: > > The structures of type snd_bebob_clock_spec, snd_bebob_rate_spec, > > snd_bebob_meter_spec, and snd_bebob_spec are never modified after they are > > initialized. Make them all const. > > > > D

[GIT PULL REQUEST] md bugfix

2015-10-10 Thread Neil Brown
The following changes since commit da6fb7a9e5bd6f04f7e15070f630bdf1ea502841: md/bitmap: don't pass -1 to bitmap_storage_alloc. (2015-10-02 17:24:13 +1000) are available in the git repository at: git://neil.brown.name/md tags/md/4.3-rc4-fix for you to fetch changes up to a452744bcbf706eac65

[PATCH] staging: lustre: lclient: NULL comparison style

2015-10-10 Thread Ryan Van Quinlan
Fixes checkpatch.pl checks: CHECK: Comparison to NULL could be written ... Signed-off-by: Ryan Van Quinlan --- drivers/staging/lustre/lustre/lclient/glimpse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/lclient/glimpse.c b/drivers/stag

Re: Updated scalable urandom patchkit

2015-10-10 Thread George Spelvin
Damn, I bow before the master. That is a much neater solution than mine; I had assumed a lock was required for writing. While it's good enough for benchmarking, there are a few leftover problems I mention so they don't get missed. One is the final write back of add_ptr on the last line of _mix_p

Re: Linux Foundation Technical Advisory Board Elections and Nomination process

2015-10-10 Thread Ric Wheeler
I would like to nominate Sage Weil with his consent. Sage has lead the ceph project since its inception, contributed to the kernel as well as had an influence on projects like openstack. thanks! Ric On 10/06/2015 01:06 PM, Grant Likely wrote: [Resending because I messed up the first one]

Re: [Linux] Linux PID algorithm is BRAINDEAD!

2015-10-10 Thread Dave Goel
Hi Ted, Thanks for responding. Fair points all of them. I would like to take exception to one of them, the bottleneck part: > The biggest problem is that accessing this free pid queue is now > a locking bottleneck --- especially on a very large NUMA system That was exactly what I was trying to

Re: [PATCH v2] ALSA: bebob: constify snd_bebob_rate_spec structures

2015-10-10 Thread Takashi Sakamoto
Hi, On Oct 11 2015 06:24, Julia Lawall wrote: > The structures of type snd_bebob_clock_spec, snd_bebob_rate_spec, > snd_bebob_meter_spec, and snd_bebob_spec are never modified after they are > initialized. Make them all const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawal

Re: [PATCH 1/2] sched: Some sched trace points should depend on SCHEDSTATS

2015-10-10 Thread yangoliver
Steve, Any comments about this patch? I think I addressed your question about why sched_stat_template is still required. Because another tracepoint depends on it, and that tracepoint doesn't depend on SCHEDSTATS. If you thought this patch is valid, I could re-submit it with a separte patch. O

[PATCH][v5] x86, suspend: Save/restore extra MSR registers for suspend

2015-10-10 Thread Chen Yu
A bug is reported(https://bugzilla.redhat.com/show_bug.cgi?id=1227208) that, after resumed from S3, CPU is running at a low speed. After investigation, it is found that, BIOS has modified the value of THERM_CONTROL register during S3, and changes it from 0 to 0x10 (thus changes the clock modulation

Re: Updated scalable urandom patchkit

2015-10-10 Thread Theodore Ts'o
On Sat, Oct 10, 2015 at 10:31:46PM -0400, Theodore Ts'o wrote: > To that end, Andi, can you try benchmarking the scalability of the > patch below? I really hope it will be good enough, since besides > using less memory, there are security advantages in not spreading the > entropy across N pools.

RE: [PATCH] [v4] x86, suspend: Save/restore extra MSR registers for suspend

2015-10-10 Thread Chen, Yu C
Hi Rafael, thanks for your comment, > -Original Message- > From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] > Sent: Saturday, October 10, 2015 5:50 AM > To: Chen, Yu C > Cc: pa...@ucw.cz; t...@linutronix.de; mi...@redhat.com; h...@zytor.com; > b...@alien8.de; Zhang, Rui; linux...@vger.k

Re: [patch] sched: disable task group re-weighting on the desktop

2015-10-10 Thread Mike Galbraith
On Sun, 2015-10-11 at 07:14 +1100, paul.sz...@sydney.edu.au wrote: > Dear Mike, > > You CCed me on this patch. Is that because you expect this to solve "my" > problem also? You had some measurements of many oinks vs many perts or > vs "desktop", but not many oinks vs 1 or 2 perts as per my "compla

Re: Updated scalable urandom patchkit

2015-10-10 Thread Theodore Ts'o
On Sat, Oct 10, 2015 at 02:45:46PM -0400, George Spelvin wrote: > In general, fewer larger pools is better for entropy storage. The only > reason for the current three-pool design is to achieve strict isolation > of the /dev/random pool. You're absolutely right, and I would like to see if we can

RE: [PATCH] [v4] x86, suspend: Save/restore extra MSR registers for suspend

2015-10-10 Thread Chen, Yu C
Hi, Doug, thanks for your comment, > -Original Message- > From: Doug Smythies [mailto:dsmyth...@telus.net] > Sent: Saturday, October 10, 2015 2:56 AM > To: Chen, Yu C > Cc: Wysocki, Rafael J; t...@linutronix.de; h...@zytor.com; b...@alien8.de; > Zhang, Rui; linux...@vger.kernel.org; x...@k

Re: [patch] sched: disable task group re-weighting on the desktop

2015-10-10 Thread Mike Galbraith
On Sat, 2015-10-10 at 19:01 +0200, Peter Zijlstra wrote: > But the patch is most horrible.. :/ It completely destroys everything > group scheduling is supposed to be. Yeah, and it works great but... > What are these oink/pert things? Both spinners just with amusing names > to distinguish them?

drivers/media/i2c/adv7604.c:1853:9: error: implicit declaration of function 'v4l2_subdev_get_try_format'

2015-10-10 Thread kbuild test robot
Hi Hans, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4a06c8ac2fb3ef484579ce44f9b809bd310fad48 commit: 85756a069c55e0315ac5990806899cfb607b987f [media] cobalt: add new driver date: 5 months ago config: x86_64-ra

[PATCH 2/2] Fixed Trivial Warnings in file: Deleted Spaces prior to tabs, and added lines. modified: kernel/auditfilter.c

2015-10-10 Thread Scott Matheina
Signed-off-by: Scott Matheina --- kernel/auditfilter.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c index 7714d93..774f9ad 100644 --- a/kernel/auditfilter.c +++ b/kernel/auditfilter.c @@ -39,13 +39,13 @@ * Loc

Re: [PATCH] misc: mic: use kstrdup() in cosm_sysfs

2015-10-10 Thread Ashutosh Dixit
On Sat, Oct 10 2015 at 12:14:30 PM, Joe Perches wrote: > On Sat, 2015-10-10 at 04:46 -0700, Geliang Tang wrote: >> Use kstrdup instead of kmalloc and strncpy. > >> diff --git a/drivers/misc/mic/cosm/cosm_sysfs.c >> b/drivers/misc/mic/cosm/cosm_sysfs.c > [] >> @@ -211,18 +211,14 @@ cmdline_store(s

Re: [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-10 Thread kbuild test robot
Hi Punit, [auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore] reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/staging/rtl8712/rtl871x_i

[PATCH 2/3] tty: core: Use correct spinlock flavor in tiocspgrp()

2015-10-10 Thread Peter Hurley
tiocspgrp() is the ioctl handler for TIOCSPGRP, which runs in non-atomic context; use spin_lock/unlock_irq (since interrupt state is on). Signed-off-by: Peter Hurley --- drivers/tty/tty_io.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/t

[PATCH 3/3] tty: Prevent tty teardown during tty_write_message()

2015-10-10 Thread Peter Hurley
tty_write_message() allows the caller to directly write to a specific tty. Since the line discipline is bypassed for the direct write, nothing prevents the tty from being torn down after the tty count is checked. Hold the tty lock for the duration of the direct write. Signed-off-by: Peter Hurley

[PATCH 1/3] tty: Combine SIGTTOU/SIGTTIN handling

2015-10-10 Thread Peter Hurley
The job_control() check in n_tty_read() has nearly identical purpose and results as tty_check_change(). Both functions' purpose is to determine if the current task's pgrp is the foreground pgrp for the tty, and if not, to signal the current pgrp. Introduce __tty_check_change() which takes the sign

[PATCHv5] staging: vme_user: provide DMA functionality

2015-10-10 Thread Dmitry Kalinkin
This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev ---

[PATCH] Style Error line 1: Deleted trailing space

2015-10-10 Thread Scott Matheina
>From 06fabebf521e29014fd59518c923d671e6df0fce Mon Sep 17 00:00:00 2001 From: Scott Matheina Date: Sat, 10 Oct 2015 16:05:51 -0500 Subject: [PATCH] Style Error line 1: Deleted trailing space This is a simple patch to line 1 of kernel/audit.h, deleting a trailing space to remove a style error.

Re: [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-10 Thread kbuild test robot
Hi Punit, [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore] config: x86_64-randconfig-x005-201541 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): In

Re: [PATCHv4 RESEND] staging: vme_user: provide DMA functionality

2015-10-10 Thread kbuild test robot
Hi Dmitry, [auto build test WARNING on driver-core/driver-core-next -- if it's inappropriate base, please ignore] config: x86_64-randconfig-x010-201541 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: it may well be a FALSE

Re: [PATCH] nouveau: fix OpenFirmware support

2015-10-10 Thread Ilia Mirkin
On Sat, Oct 10, 2015 at 7:45 PM, Laurent Vivier wrote: > > > Le 10/10/2015 21:56, Ilia Mirkin a écrit : >> On Sat, Oct 10, 2015 at 3:29 PM, Laurent Vivier wrote: >>> >>> >>> Le 10/10/2015 20:41, Ilia Mirkin a écrit : Hi Laurent, On Sat, Oct 10, 2015 at 9:27 AM, Laurent Vivier wrot

Re: [PATCH] nouveau: fix OpenFirmware support

2015-10-10 Thread Laurent Vivier
Le 10/10/2015 21:56, Ilia Mirkin a écrit : > On Sat, Oct 10, 2015 at 3:29 PM, Laurent Vivier wrote: >> >> >> Le 10/10/2015 20:41, Ilia Mirkin a écrit : >>> Hi Laurent, >>> >>> On Sat, Oct 10, 2015 at 9:27 AM, Laurent Vivier wrote: On PowerMac G5 (and I think on all OpenFirmware platforms),

Re: [PATCH net-next 3/6] net: remove dsa.h include from linux/netdevice.h

2015-10-10 Thread kbuild test robot
Hi Vivien, [auto build test ERROR on net-next/master -- if it's inappropriate base, please ignore] config: x86_64-randconfig-n0-10110700 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): d

Re: [PATCH v8 2/9] Input: goodix - reset device at init

2015-10-10 Thread kbuild test robot
Hi Irina, [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore] config: x86_64-randconfig-h0-10110617 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/in

Re: [PATCH 1/5] perf: unwind: fix unw_word_t pointer casts

2015-10-10 Thread Arnaldo Carvalho de Melo
Em Sat, Oct 10, 2015 at 05:49:40PM +0200, Rabin Vincent escreveu: > Hi Arnaldo, > > Do you have any comments on this patch set? I looked at the patches now, all seem fine from a quick look. The last patch is interesting, and a more general way of installing what is required for a full build usin

collect2: error: ld returned 1 exit status

2015-10-10 Thread kbuild test robot
Hi Anton, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4a06c8ac2fb3ef484579ce44f9b809bd310fad48 commit: 238abecde8ad43f914e095fcf23e0bd35dc7a7f2 powerpc: Don't use gcc specific options on clang date: 4 months a

drivers/media/pci/netup_unidvb/netup_unidvb_core.c:417:18: error: too many arguments to function 'horus3a_attach'

2015-10-10 Thread kbuild test robot
Hi Kozlov, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4a06c8ac2fb3ef484579ce44f9b809bd310fad48 commit: 52b1eaf4c59a3bbd07afbb4ab4f43418a807d02e [media] netup_unidvb: NetUP Universal DVB-S/S2/T/T2/C PCI-E card d

Re: [PATCH v5 0/7] arm64: berlin: add pinctrl support

2015-10-10 Thread Antoine Tenart
Jisheng, On Fri, Oct 09, 2015 at 07:56:43PM +0800, Jisheng Zhang wrote: > This series adds support for Marvell berlin4ct pin-controller, allowing > to configure the pin muxing from the device tree. For the whole series, Acked-by: Antoine Tenart Thanks! Antoine > > Since v4: > - drop ARCH_B

Re: [PATCH v5 0/7] arm64: berlin: add pinctrl support

2015-10-10 Thread Antoine Tenart
Hi Jisheng, Please keep Acked-by tags when you submit a new version of a series. Thanks, Antoine On Fri, Oct 09, 2015 at 07:56:43PM +0800, Jisheng Zhang wrote: > This series adds support for Marvell berlin4ct pin-controller, allowing > to configure the pin muxing from the device tree. > > Sinc

Re: [PATCH v4 2/6] pinctrl: berlin: add the berlin4ct pinctrl driver

2015-10-10 Thread Antoine Tenart
Hi Jisheng, On Fri, Oct 09, 2015 at 05:22:38PM +0800, Jisheng Zhang wrote: > On Fri, 9 Oct 2015 11:03:53 +0200 > Antoine Tenart wrote: > > > > Finally you can move the OF dependency to the PINCTRL_BERLIN config as > > all Berlin pinctrl drivers depends on it. > > PINCTRL_BERLIN isn't user visib

[PATCHv4 RESEND] staging: vme_user: provide DMA functionality

2015-10-10 Thread Dmitry Kalinkin
This introduces a new dma device that provides a single ioctl call that provides DMA read and write functionality to the user space. Signed-off-by: Dmitry Kalinkin Cc: Igor Alekseev --- In the last reply Martyn suggested a rework of this to make it use existing bus/vme/ctl instead of creating a

Re: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

2015-10-10 Thread Matt Fleming
On Mon, 05 Oct, at 03:13:50PM, Borislav Petkov wrote: > On Tue, Oct 06, 2015 at 04:15:54AM +0800, Kweh, Hock Leong wrote: > > From: "Kweh, Hock Leong" > > > > This patch export efi_capsule_supported() function symbol for capsule > > kernel module to use. > > > > Cc: Matt Fleming > > Signed-off-

[PATCH] vme: 8-bit status/id takes 256 values, not 255

2015-10-10 Thread Dmitry Kalinkin
Fixes an off by one array size. Signed-off-by: Dmitry Kalinkin --- drivers/vme/vme_bridge.h | 4 +++- include/linux/vme.h | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/vme/vme_bridge.h b/drivers/vme/vme_bridge.h index 397578a..b59cbee 100644 --- a/drivers/vm

Re: [Linux] Linux PID algorithm is BRAINDEAD!

2015-10-10 Thread Theodore Ts'o
On Fri, Oct 09, 2015 at 10:00:34PM -0400, Dave Goel wrote: > > All that the entire system needs is one queue of free PIDs. Any time you > need a PID, take it from the head. Any time a PID is newly freed, push it at > the back of the queue. That's it! The overhead seems minimal to me. > > The que

thinkpad_acpi: Lenovo ThinkPad Yoga 12 side lock button (0x6020)

2015-10-10 Thread Darren Hart
The Lenovo ThinkPad Yogo 12 has a button on the side by the power and volume keys with a padlock icon on it, I presume intended to be used as Screenlock. It emits 0x6020 which means it falls into the hotkey_notify_6xxx() block. It seems this should be handled similarly to the 0x1xxx events instead

Re: [PATCH] thinkpad_acpi: Add TP_HKEY_EV_SCREEN_FLIP (0x60c0) for Lenovo ThinkPad Yoga 12

2015-10-10 Thread Darren Hart
On Sat, Oct 10, 2015 at 06:40:34PM -0300, Henrique de Moraes Holschuh wrote: > On Sat, 10 Oct 2015, Darren Hart wrote: > > On Sat, Oct 10, 2015 at 11:41:47AM -0700, Darren Hart wrote: > > > From: Darren Hart > > > > > > thinkpad_acpi reports "unhandled HKEY event 0x60c0" when switching > > > betw

[PATCH] ohci-pci: use USB_DT_*

2015-10-10 Thread Sergei Shtylyov
Toshiba Portege 4000 quirk entry can be written shorter using the PCI_DEVICE_SUB() macro. Signed-off-by: Sergei Shtylyov --- The patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo. drivers/usb/host/ohci-pci.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) Inde

[PATCH 5/5 v2] arm: add missing of_node_put

2015-10-10 Thread Julia Lawall
for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The of_node_put is duplicated in front of each error return, because the function contains a later error return that is beyond the end of the for_each_child_of_node and thus doesn'

Re: [PATCH] thinkpad_acpi: Add TP_HKEY_EV_SCREEN_FLIP (0x60c0) for Lenovo ThinkPad Yoga 12

2015-10-10 Thread Henrique de Moraes Holschuh
On Sat, 10 Oct 2015, Darren Hart wrote: > On Sat, Oct 10, 2015 at 11:41:47AM -0700, Darren Hart wrote: > > From: Darren Hart > > > > thinkpad_acpi reports "unhandled HKEY event 0x60c0" when switching > > between laptop and tent/tablet mode on the ThinkPad Yoga 12. This key is > > reported by atkb

Re: [PATCH] vme: tsi148: silence uninitialized variable warning

2015-10-10 Thread Dmitry Kalinkin
Hi Martyn, Sorry, your comment is too late. This patch is already in staging-next. Dmitri > On 2015/10/10, at 17:35, Martyn Welch wrote: > > On 5 October 2015 at 04:59, Dmitry Kalinkin wrote: >> The warning is a false positive. >> > > That seems very likely. > > Please could you role this

Re: [PATCH] vme: tsi148: silence uninitialized variable warning

2015-10-10 Thread Martyn Welch
On 5 October 2015 at 04:59, Dmitry Kalinkin wrote: > The warning is a false positive. > That seems very likely. Please could you role this into the original patch (vme: change bus error handling scheme)? Martyn > drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_write': > drivers/vm

[PATCH v2] ALSA: bebob: constify snd_bebob_rate_spec structures

2015-10-10 Thread Julia Lawall
The structures of type snd_bebob_clock_spec, snd_bebob_rate_spec, snd_bebob_meter_spec, and snd_bebob_spec are never modified after they are initialized. Make them all const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- v2: extend to snd_bebob_clock_spec, snd_bebob_meter_

Re: [PATCH 5/5] arm: add missing of_node_put

2015-10-10 Thread Arnd Bergmann
On Saturday 10 October 2015 23:10:06 Julia Lawall wrote: > On Sat, 10 Oct 2015, Arnd Bergmann wrote: > > > On Saturday 10 October 2015 14:30:54 Julia Lawall wrote: > > > diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c > > > index 11c54de..432ff34 100644 > > > --- a/arch/arm/kern

Re: [PATCH 5/5] arm: add missing of_node_put

2015-10-10 Thread Julia Lawall
On Sat, 10 Oct 2015, Thomas Petazzoni wrote: > Arnd, > > On Sat, 10 Oct 2015 23:02:15 +0200, Arnd Bergmann wrote: > > > The same for_each_child_of_node() loop has three 'return' statements' > > aside from the 'break' statement here. I think you should change your > > semantic patch to cover both

Re: [PATCH 5/5] arm: add missing of_node_put

2015-10-10 Thread Julia Lawall
On Sat, 10 Oct 2015, Arnd Bergmann wrote: > On Saturday 10 October 2015 14:30:54 Julia Lawall wrote: > > diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c > > index 11c54de..432ff34 100644 > > --- a/arch/arm/kernel/devtree.c > > +++ b/arch/arm/kernel/devtree.c > > @@ -143,6 +143,7

Re: [PATCH 5/5] arm: add missing of_node_put

2015-10-10 Thread Thomas Petazzoni
Arnd, On Sat, 10 Oct 2015 23:02:15 +0200, Arnd Bergmann wrote: > The same for_each_child_of_node() loop has three 'return' statements' > aside from the 'break' statement here. I think you should change your > semantic patch to cover both cases. I think Julia's semantic patch covers both cases, b

Re: [PATCH 5/5] arm: add missing of_node_put

2015-10-10 Thread Arnd Bergmann
On Saturday 10 October 2015 14:30:54 Julia Lawall wrote: > diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c > index 11c54de..432ff34 100644 > --- a/arch/arm/kernel/devtree.c > +++ b/arch/arm/kernel/devtree.c > @@ -143,6 +143,7 @@ void __init arm_dt_init_cpu_maps(void) >

Re: [PATCH 1/2 v3] drivers: staging: rtl8723au: Changed rssi_cmd to little-endian param

2015-10-10 Thread Jes Sorensen
Jacob Kiefer writes: > From: Jacob Kiefer > > Changed rssi_cmd interface to accept le32 param instead of > unnecessary u8 * conversion. Updated existing calls to rssi_cmd. > This patch pushes responsibility to caller to convert to > le32. This cleans up the code quite a bit. > Also removed magic

Re: [PATCH v2 11/20] kvm: rename pfn_t to kvm_pfn_t

2015-10-10 Thread Dan Williams
On Sat, Oct 10, 2015 at 1:35 PM, Paolo Bonzini wrote: > On 10/10/2015 02:56, Dan Williams wrote: >> The core has developed a need for a "pfn_t" type [1]. Move the existing >> pfn_t in KVM to kvm_pfn_t [2]. >> >> [1]: https://lists.01.org/pipermail/linux-nvdimm/2015-September/002199.html >> [2]: h

[BUG] x86: apic: Possible null pointer dereference by apic_ack_edge

2015-10-10 Thread William Breathitt Gray
Hello, In mainline kernel version 4.3-rc4, the following line located in the apic_ack_edge function definition can result in a null pointer dereference: irq_complete_move(irqd_cfg(data)); The irqd_cfg function may return a value of NULL. If NULL is passed to the irq_complete_move

Re: [PATCH 2/2] x86, efi: Add "efi_fake_mem" boot option

2015-10-10 Thread Matt Fleming
On Wed, 30 Sep, at 11:01:56PM, Taku Izumi wrote: > This patch introduces new boot option named "efi_fake_mem". > By specifying this parameter, you can add arbitrary attribute > to specific memory range. > This is useful for debugging of Address Range Mirroring feature. > > For example, if "efi_fak

Re: [PATCH v2 11/20] kvm: rename pfn_t to kvm_pfn_t

2015-10-10 Thread Paolo Bonzini
On 10/10/2015 02:56, Dan Williams wrote: > The core has developed a need for a "pfn_t" type [1]. Move the existing > pfn_t in KVM to kvm_pfn_t [2]. > > [1]: https://lists.01.org/pipermail/linux-nvdimm/2015-September/002199.html > [2]: https://lists.01.org/pipermail/linux-nvdimm/2015-September/002

Re: [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-10 Thread punit vara
On Sun, Oct 11, 2015 at 1:52 AM, punit vara wrote: > On Sun, Oct 11, 2015 at 1:20 AM, Julia Lawall wrote: >> >> >> On Sun, 11 Oct 2015, punit vara wrote: >> >>> On Sat, Oct 10, 2015 at 11:04 PM, Larry Finger >>> wrote: >>> > On 10/10/2015 11:58 AM, Punit Vara wrote: >>> >> >>> >> This patch is t

Re: [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-10 Thread punit vara
On Sun, Oct 11, 2015 at 1:20 AM, Julia Lawall wrote: > > > On Sun, 11 Oct 2015, punit vara wrote: > >> On Sat, Oct 10, 2015 at 11:04 PM, Larry Finger >> wrote: >> > On 10/10/2015 11:58 AM, Punit Vara wrote: >> >> >> >> This patch is to the rtl871x_ioctl_linux.c file that fixes up following >> >>

Re: [patch] sched: disable task group re-weighting on the desktop

2015-10-10 Thread paul . szabo
Dear Mike, You CCed me on this patch. Is that because you expect this to solve "my" problem also? You had some measurements of many oinks vs many perts or vs "desktop", but not many oinks vs 1 or 2 perts as per my "complaint". You also changed the subject line, so maybe this is all un-related. T

Re: [PATCH 3/7] usb: gadget: gserial: Privatize close_wait

2015-10-10 Thread Peter Hurley
[ forgot to addr Felipe here, sorry ] On 10/10/2015 04:00 PM, Peter Hurley wrote: > close_wait is no longer needed or provided by the tty core. > Move close_wait to struct gs_port. > > Signed-off-by: Peter Hurley > --- > drivers/usb/gadget/function/u_serial.c | 6 -- > 1 file changed, 4 ins

[PATCH 1/7] tty: Remove tty_wait_until_sent_from_close()

2015-10-10 Thread Peter Hurley
tty_wait_until_sent_from_close() drops the tty lock while waiting for the tty driver to finish sending previously accepted data (ie., data remaining in its write buffer and transmit fifo). tty_wait_until_sent_from_close() was added by commit a57a7bf3fc7e ("TTY: define tty_wait_until_sent_from_clos

[PATCH 6/7] tty: r3964: Replace/remove bogus tty lock use

2015-10-10 Thread Peter Hurley
The tty lock is strictly for serializing tty lifetime events (open/close/hangup), and not for line discipline serialization. The tty core already provides serialization of concurrent writes to the same tty, and line discipline lifetime management (by ldisc references), so pinning the tty via tty_l

[PATCH 5/7] tty: r3964: Use tty->read_wait waitqueue

2015-10-10 Thread Peter Hurley
The tty core provides read_wait waitqueue specifically for line disciplines to wait readers; otherwise, the line discipline may miss wakeups generated by the tty core. NB: The tty core already provides serialization for the line discipline's close() method, and guarantees no readers or writers wil

[PATCH 2/7] tty: Remove ASYNC_CLOSING checks in open()/hangup() methods

2015-10-10 Thread Peter Hurley
Since at least before 2.6.30, tty drivers that do not drop the tty lock while closing cannot observe ASYNC_CLOSING set while holding the tty lock; this includes the tty driver's open() and hangup() methods, since the tty core calls these methods holding the tty lock. For these drivers, waiting for

[PATCH 4/7] tty: Remove tty_port::close_wait

2015-10-10 Thread Peter Hurley
With the removal of tty_wait_until_sent_from_close(), tty drivers no longer wait during open for parallel closes to complete (instead, the tty core waits before calling the driver open() method). Thus, the close_wait waitqueue is no longer used for waiting. Remove struct tty_port::close_wait. Sig

[PATCH 7/7] tty: Remove wait_event_interruptible_tty()

2015-10-10 Thread Peter Hurley
In-tree users of wait_event_interruptible_tty() have been removed; remove. Signed-off-by: Peter Hurley --- include/linux/tty.h | 26 -- 1 file changed, 26 deletions(-) diff --git a/include/linux/tty.h b/include/linux/tty.h index 090ce2a..c2889f4 100644 --- a/include/linu

[PATCH 3/7] usb: gadget: gserial: Privatize close_wait

2015-10-10 Thread Peter Hurley
close_wait is no longer needed or provided by the tty core. Move close_wait to struct gs_port. Signed-off-by: Peter Hurley --- drivers/usb/gadget/function/u_serial.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/ga

[PATCH 0/7] tty close cleanup

2015-10-10 Thread Peter Hurley
Hi Greg, This series is a redux of cleanup I originally submitted back in 2014; the point is to remove the cruft which stems from dropping the tty lock while waiting for output to drain before closing the tty. Dropping the tty lock during close was added by "TTY: define tty_wait_until_sent_from_c

Re: [PATCH] nouveau: fix OpenFirmware support

2015-10-10 Thread Ilia Mirkin
On Sat, Oct 10, 2015 at 3:29 PM, Laurent Vivier wrote: > > > Le 10/10/2015 20:41, Ilia Mirkin a écrit : >> Hi Laurent, >> >> On Sat, Oct 10, 2015 at 9:27 AM, Laurent Vivier wrote: >>> On PowerMac G5 (and I think on all OpenFirmware platforms), nvbios_pcirTp() >>> returns NULL. But in fact the Ope

Re: [PATCH 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

2015-10-10 Thread punit vara
On Sat, Oct 10, 2015 at 10:37 PM, Julia Lawall wrote: > > > On Sat, 10 Oct 2015, Punit Vara wrote: > >> This patch is to the rtl871x_ioctl_linux.c file that fixes up following > > The entire above line doesn't give any information (except the file name, > but that can easily be seen from what come

Re: [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-10 Thread Julia Lawall
On Sun, 11 Oct 2015, punit vara wrote: > On Sat, Oct 10, 2015 at 11:04 PM, Larry Finger > wrote: > > On 10/10/2015 11:58 AM, Punit Vara wrote: > >> > >> This patch is to the rtl871x_ioctl_linux.c file that fixes up following > >> warning reported by checkpatch.pl : > >> > >> -Prefer ether_addr_

Re: [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()

2015-10-10 Thread punit vara
On Sat, Oct 10, 2015 at 11:04 PM, Larry Finger wrote: > On 10/10/2015 11:58 AM, Punit Vara wrote: >> >> This patch is to the rtl871x_ioctl_linux.c file that fixes up following >> warning reported by checkpatch.pl : >> >> -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp() >> >

[PATCH 1/2] atm: iphase: return -ENOMEM instead of -1 in case of failed kmalloc()

2015-10-10 Thread Tillmann Heidsieck
Smatch complains about returning hard coded error codes, silence this warning. drivers/atm/iphase.c:115 ia_enque_rtn_q() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Tillmann Heidsieck --- drivers/atm/iphase.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

[PATCH 0/2] atm: iphase: Fix misleading indention and return -ENOMEM on error

2015-10-10 Thread Tillmann Heidsieck
OK here it goes ... There are three non-indention specific smatch warnings in atm/iphase.c drivers/atm/iphase.c:115 ia_enque_rtn_q() warn: returning -1 instead of -ENOMEM is sloppy drivers/atm/iphase.c:148 ia_hack_tcq() warn: if(); drivers/atm/iphase.c:1178 rx_pkt() warn: curly braces intended?

[PATCH 2/2] atm: iphase: fix misleading indention

2015-10-10 Thread Tillmann Heidsieck
Fix a smatch warning: drivers/atm/iphase.c:1178 rx_pkt() warn: curly braces intended? The code is correct, the indention is misleading. In case the allocation of skb fails, we want to skip to the end. Signed-off-by: Tillmann Heidsieck --- drivers/atm/iphase.c | 2 +- 1 file changed, 1 insertion

[PATCH] doc: Clarify that nmi_watchdog param is for hardlockups

2015-10-10 Thread Pranith Kumar
The kernel NMI watchdog acts as both a hardlockup and softlockup detector. However, the kernel parameter nmi_watchdog can only enable or disable the hardlockup detector. Clarify that in the documentation. Signed-off-by: Pranith Kumar --- Documentation/kernel-parameters.txt | 7 --- 1 file ch

Re: [PATCH 1/2] x86, efi: rename print_efi_memmap() to efi_print_memmap()

2015-10-10 Thread Matt Fleming
On Wed, 30 Sep, at 07:20:00PM, Taku Izumi wrote: > This patch renames print_efi_memmap() to efi_print_memmap() and > make it global function so that we can invoke it outside of > arch/x86/platform/efi/efi.c > > Signed-off-by: Taku Izumi > --- > arch/x86/include/asm/efi.h | 1 + > arch/x86/platf

Re: [PATCH] nouveau: fix OpenFirmware support

2015-10-10 Thread Laurent Vivier
Le 10/10/2015 20:41, Ilia Mirkin a écrit : > Hi Laurent, > > On Sat, Oct 10, 2015 at 9:27 AM, Laurent Vivier wrote: >> On PowerMac G5 (and I think on all OpenFirmware platforms), nvbios_pcirTp() >> returns NULL. But in fact the OpenFirmware has given us the size >> we can store in image->size.

[PATCH 2/2 v3] drivers: staging: rtl8723au: Changed raid_cmd to little-endian mask

2015-10-10 Thread Jacob Kiefer
From: Jacob Kiefer Changed raid_cmd interface to accept le32 mask instead of u32 and converting internally. Updated existing calls to raid_cmd. This patch pushes responsibility to the caller to convert the mask to le32 and opts for a temp local struct instead of memset/memcpy. This cleans up the

[PATCH 1/2 v3] drivers: staging: rtl8723au: Changed rssi_cmd to little-endian param

2015-10-10 Thread Jacob Kiefer
From: Jacob Kiefer Changed rssi_cmd interface to accept le32 param instead of unnecessary u8 * conversion. Updated existing calls to rssi_cmd. This patch pushes responsibility to caller to convert to le32. This cleans up the code quite a bit. Also removed magic numbers. This patch fixes the foll

Re: 4.2: CONFIG_NO_HZ_FULL_ALL effectively disabling non-boot CPUs

2015-10-10 Thread Paul E. McKenney
On Sat, Oct 10, 2015 at 10:14:25PM +0300, Meelis Roos wrote: > Short summary: turning on CONFIG_NO_HZ_FULL_ALL seems to disable all > non-boot CPUs for scheduler. > > A couple of days ago I noticed that make -j8 on a 4-core i5 is very slow > (with 4.3.0-rc4+git). Looking at top ('1' for per-cpu

Re: [PATCH] mISDN: use kstrdup() in dsp_pipeline_build

2015-10-10 Thread Joe Perches
On Sat, 2015-10-10 at 02:32 -0700, Geliang Tang wrote: > Use kstrdup instead of strlen-kmalloc-strcpy. Not the same code. Instead of returning early, a 0 length string will now set pipeline->inuse to 0. Maybe that's OK, but you should state why in the commit log. > diff --git a/drivers/isdn/mIS

Re: [PATCH 4/5] drivers/tty: make serial/mpsc.c driver explicitly non-modular

2015-10-10 Thread Paul Gortmaker
[Re: [PATCH 4/5] drivers/tty: make serial/mpsc.c driver explicitly non-modular] On 09/10/2015 (Fri 15:38) Thierry Reding wrote: > On Wed, Aug 19, 2015 at 05:48:08PM -0400, Paul Gortmaker wrote: [...] > > static struct platform_driver mpsc_driver = { > > .probe = mpsc_drv_probe, > > - .r

Re: [PATCH] misc: mic: use kstrdup() in cosm_sysfs

2015-10-10 Thread Joe Perches
On Sat, 2015-10-10 at 04:46 -0700, Geliang Tang wrote: > Use kstrdup instead of kmalloc and strncpy. As count is a function argument, this isn't the same code. You should state why it's correct in the commit log. > diff --git a/drivers/misc/mic/cosm/cosm_sysfs.c > b/drivers/misc/mic/cosm/cosm_s

4.2: CONFIG_NO_HZ_FULL_ALL effectively disabling non-boot CPUs

2015-10-10 Thread Meelis Roos
Short summary: turning on CONFIG_NO_HZ_FULL_ALL seems to disable all non-boot CPUs for scheduler. A couple of days ago I noticed that make -j8 on a 4-core i5 is very slow (with 4.3.0-rc4+git). Looking at top ('1' for per-cpu states), only first CPU is loaded and 3 other CPUs are 100% idle. This

Re: [PATCH v2] staging: rtl8723au: Fix sparse errors in rtl8723a_cmd.c

2015-10-10 Thread Greg Kroah-Hartman
On Sat, Oct 10, 2015 at 02:50:44PM -0400, Jacob Kiefer wrote: > Hello > > This patch set fixes the same sparse errors as v2, taking Al's > advice into consideration and changing the interfaces to little-endian. Please resend these in a format that I can apply them in (i.e. one patch per email in

v4.3-rc4: i915: ThinkPad Yoga 12: *ERROR* The master control interrupt lied (SDE)!

2015-10-10 Thread Darren Hart
The Debian 3.16.0 kernel does not emit the error, but I have not attempted a bisection. The warning was added by: 38cc46d drm/i915/bdw: Ack interrupts before handling them (GEN8) 2014-06-18 (1 year, 4 months ago), Oscar Mateo Follows: v3.15-rc8 Preceedes: 3.17-rc1 This is not present in v3.16,

[PATCH 3/3] sched: don't scan all-offline ->cpus_allowed twice if !CONFIG_CPUSETS

2015-10-10 Thread Oleg Nesterov
If CONFIG_CPUSETS=n then "case cpuset" changes the state and runs the already failed for_each_cpu() loop again for no reason. Signed-off-by: Oleg Nesterov --- kernel/sched/core.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sche

[PATCH 1/3] sched: select_task_rq() should check cpu_active() like select_fallback_rq()

2015-10-10 Thread Oleg Nesterov
I do not understand the cpu_active() check in select_fallback_rq(). x86 doesn't need it, and the recent commit dd9d3843755d "sched: Fix cpu_active_mask/cpu_online_mask race" documents the fact that on any architecture we can ignore !active starting from CPU_ONLINE stage. But any possible reason wh

[PATCH 2/3] sched: change select_fallback_rq() to use for_each_cpu_and()

2015-10-10 Thread Oleg Nesterov
We can make "cpumask *nodemask" more local and use for_each_cpu_and() to simplify this code a little bit. And NUMA_NO_NODE looks better than "-1". Signed-off-by: Oleg Nesterov --- kernel/sched/core.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/kernel/sc

[PATCH 0/3] (Was: sched: start stopper early)

2015-10-10 Thread Oleg Nesterov
To avoid the confusion, this has nothing to do with "stop_machine" changes we discuss in another thread, but On 10/09, Oleg Nesterov wrote: > > > case CPU_ONLINE: > > + stop_machine_unpark(cpu); > > /* > > * At this point a starting CPU has marked itself as o

Re: Updated scalable urandom patchkit

2015-10-10 Thread George Spelvin
I'm very very sorry to be so late to the party; I didn't see this thread until the week-delayed LWN article on the subject drew my attention to it. There's a fundamental design issue with this patch set that seems unnecessary to me: multiple nonblocking pools. I know, I know, that seems like the

Re: [PATCH v2] staging: rtl8723au: Fix sparse errors in rtl8723a_cmd.c

2015-10-10 Thread Jacob Kiefer
Hello This patch set fixes the same sparse errors as v2, taking Al's advice into consideration and changing the interfaces to little-endian. Jake >From 8c66f23a08417c59400a60c2dcf5a519795e401f Mon Sep 17 00:00:00 2001 From: Jacob Kiefer Date: Sat, 10 Oct 2015 14:33:02 -0400 Subject: [PATCH 1/2 v

Re: [PATCH] thinkpad_acpi: Add TP_HKEY_EV_SCREEN_FLIP (0x60c0) for Lenovo ThinkPad Yoga 12

2015-10-10 Thread Darren Hart
On Sat, Oct 10, 2015 at 11:41:47AM -0700, Darren Hart wrote: > From: Darren Hart > > thinkpad_acpi reports "unhandled HKEY event 0x60c0" when switching > between laptop and tent/tablet mode on the ThinkPad Yoga 12. This key is > reported by atkbd serio0 as e058 and e059. > > Add TP_HKEY_EV_SCREE

[PATCH] thinkpad_acpi: Add TP_HKEY_EV_SCREEN_FLIP (0x60c0) for Lenovo ThinkPad Yoga 12

2015-10-10 Thread Darren Hart
From: Darren Hart thinkpad_acpi reports "unhandled HKEY event 0x60c0" when switching between laptop and tent/tablet mode on the ThinkPad Yoga 12. This key is reported by atkbd serio0 as e058 and e059. Add TP_HKEY_EV_SCREEN_FLIP to the list of ignored events and silence the warning. Cleanup whit

Re: [PATCH] nouveau: fix OpenFirmware support

2015-10-10 Thread Ilia Mirkin
Hi Laurent, On Sat, Oct 10, 2015 at 9:27 AM, Laurent Vivier wrote: > On PowerMac G5 (and I think on all OpenFirmware platforms), nvbios_pcirTp() > returns NULL. But in fact the OpenFirmware has given us the size > we can store in image->size. > > This size is stored in bios->size by of_init() as

  1   2   3   >