[PATCH 0/2] Remove unused functions

2015-01-31 Thread Chris Rorvick
Found a couple more things to rip out. Regards, Chris Chris Rorvick (2): ALSA: line6: Remove unused line6_midibuf_status() ALSA: line6: Remove unused line6_midibuf_skip_message() sound/usb/line6/midibuf.c | 18 -- 1 file changed, 18 deletions(-) -- 2.1.0 -- To unsubscrib

[PATCH 2/2] ALSA: line6: Remove unused line6_midibuf_skip_message()

2015-01-31 Thread Chris Rorvick
Use of this function ended with commits 3e58c868db1d ("staging: line6: drop midi_mask_receive") and af89d2897a71 ("staging: line6: drop midi_mask_transmit".) Signed-off-by: Chris Rorvick --- sound/usb/line6/midibuf.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/sound/usb/line6

[PATCH 1/2] ALSA: line6: Remove unused line6_midibuf_status()

2015-01-31 Thread Chris Rorvick
This function has not been used since merging the driver into the kernel (and a good while before that.) Signed-off-by: Chris Rorvick --- sound/usb/line6/midibuf.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/sound/usb/line6/midibuf.c b/sound/usb/line6/midibuf.c index b5c4d79..3b8b5

Re: linux-next: manual merge of the block tree with the vfs tree

2015-01-31 Thread Al Viro
On Thu, Jan 29, 2015 at 05:15:55AM +, Al Viro wrote: > On Wed, Jan 28, 2015 at 06:11:02PM +0100, Christoph Hellwig wrote: > > On Tue, Jan 27, 2015 at 04:54:22AM +, Al Viro wrote: > > > I don't mind opening a never-rebased branch for generic iov_iter-related > > > stuff; > > > if you prefer

[PATCH] usb: musb: blackfin: remove incorrect __exit_p()

2015-01-31 Thread Dmitry Torokhov
bfin_remove() is not (nor should it be) marked as __exit, so we should not be using __exit_p() wrapper with it, otherwise unbinding through sysfs does not work properly. Signed-off-by: Dmitry Torokhov --- Not tested, sorry. drivers/usb/musb/blackfin.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Greg Kroah-Hartman
On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvi

Re: [PATCH] staging: xgifb: vb_init: Removed variables that is never used

2015-01-31 Thread Greg Kroah-Hartman
On Sat, Jan 31, 2015 at 04:20:48PM +0100, Rickard Strandqvist wrote: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvi

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Greg Kroah-Hartman
On Sat, Jan 31, 2015 at 11:41:04AM -0600, Larry Finger wrote: > On 01/31/2015 10:19 AM, Dan Carpenter wrote: > >On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: > >>while (phead != plist) { > >>- psta = container_of(plist, struct sta_info , list); > >>+ c

RE: [PATCH 2/3] hv: vmbus_post_msg: retry the hypercall on HV_STATUS_INVALID_CONNECTION_ID

2015-01-31 Thread Dexuan Cui
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Saturday, January 31, 2015 1:29 AM > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; linux-kernel@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@re

Re: General protection fault in iscsi_rx_thread_pre_handler

2015-01-31 Thread Gavin Guo
Hi Nicholas, On Sat, Jan 31, 2015 at 6:53 AM, Nicholas A. Bellinger wrote: > On Fri, 2015-01-23 at 09:30 +0800, Gavin Guo wrote: >> Hi Nicholas, >> >> On Fri, Jan 23, 2015 at 1:35 AM, Nicholas A. Bellinger >> wrote: >> > On Thu, 2015-01-22 at 23:56 +0800, Gavin Guo wrote: >> >> Hi Nicolas, >> >>

__might_sleep() warnings on v3.19-rc6

2015-01-31 Thread Fengguang Wu
Hi all, I see 2 __might_sleep() warnings on when running LKP tests on v3.19-rc6, one related to raid5 and another related to btrfs. They might be exposed by this patch. commit 8eb23b9f35aae413140d3fda766a98092c21e9b0 Author: Peter Zijlstra sched: Debug nested sleeps Validate w

nvram and generic_nvram modules are problematic, was Re: [PATCH] arch: m68k: mac: misc.c: Remove some unused functions

2015-01-31 Thread Finn Thain
On Sun, 4 Jan 2015, Geert Uytterhoeven wrote: > On Sun, Jan 4, 2015 at 8:21 AM, Finn Thain wrote: > > On Thu, 1 Jan 2015, Rickard Strandqvist wrote: > > > Removes some functions that are not used anywhere: > > > mac_pram_write() mac_pram_read() > > > > ... I'd rather not remove all of this code.

[PATCH] leds: leds-gpio: Pass on error codes unmodified

2015-01-31 Thread Soren Brinkmann
Instead of overriding error codes, pass them on unmodified. This way a EPROBE_DEFER is correctly passed to the driver core. This results in the LED driver correctly requesting probe deferral in cases the GPIO controller is not yet available. Signed-off-by: Soren Brinkmann --- Adding pinctrl on Zy

[rcu] [ INFO: suspicious RCU usage. ]

2015-01-31 Thread Fengguang Wu
Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git revert-c418b8035fac0cc7d242e5de126cec1006a34bed-dd2b39be8eee9d175c7842c30e405a5cbe50095a commit dd2b39be8eee9d175c7842c30e405a5cbe50095a Autho

Re: [PATCH 3/3] netlabel: Less function calls in netlbl_mgmt_add_common() after error detection

2015-01-31 Thread Paul Moore
On Sat, Jan 31, 2015 at 4:38 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 31 Jan 2015 21:55:48 +0100 > > The functions "cipso_v4_doi_putdef" and "kfree" could be called in some cases > by the netlbl_mgmt_add_common() function during error handling even if the > passed variable

Re: [PATCH 2/3] netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_free"

2015-01-31 Thread Paul Moore
On Sat, Jan 31, 2015 at 4:36 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 31 Jan 2015 19:35:59 +0100 > > The cipso_v4_doi_free() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected

Re: [PATCH 1/3] netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_putdef"

2015-01-31 Thread Paul Moore
On Sat, Jan 31, 2015 at 4:34 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 31 Jan 2015 19:09:50 +0100 > > The cipso_v4_doi_putdef() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detect

Re: [PATCH] x86, traps: Fix ist_enter from userspace

2015-01-31 Thread Andy Lutomirski
On Jan 31, 2015 12:18 PM, "Paul E. McKenney" wrote: > > On Sat, Jan 31, 2015 at 05:01:34AM -0800, Andy Lutomirski wrote: > > context_tracking_user_exit() has no effect if in_interrupt() returns true, > > so ist_enter() didn't work. Fix it by calling exception_enter(), and thus > > context_trackin

Re: [BUG, bisect] hang when copying large file to disc

2015-01-31 Thread Theodore Ts'o
On Fri, Jan 30, 2015 at 07:40:51PM -0800, Jeremiah Mahler wrote: > > If a large file (> 1 GB) is transferred from a USB stick or a mmc > to an local disc (using ext4), it will proceed normally until it > has transferred approximately 600 MB. Then the speed will drop off > to zero and the terminal

[PATCH] mtd: avoid registering reboot notifier twice

2015-01-31 Thread Niklas Cassel
Calling mtd_device_parse_register with the same mtd_info (e.g. registering several partitions on a single device) would add the same reboot notifier twice, causing an infinte loop in notifier_chain_register during boot up. Signed-off-by: Niklas Cassel --- drivers/mtd/mtdcore.c | 2 +- 1 file cha

Re: [PATCH net-next] drivers: net: cpsw: make cpsw_ale.c a module to allow re-use on Keystone

2015-01-31 Thread David Miller
From: Murali Karicheri Date: Thu, 29 Jan 2015 18:15:51 -0500 > NetCP on Keystone has cpsw ale function similar to other TI SoCs > and this driver is re-used. To allow both ti cpsw and keystone netcp > to re-use the driver, convert the cpsw ale to a module and configure > it through Kconfig option

Re: [PATCH net] hyperv: Fix the error processing in netvsc_send()

2015-01-31 Thread David Miller
From: Haiyang Zhang Date: Thu, 29 Jan 2015 12:34:49 -0800 > The existing code frees the skb in EAGAIN case, in which the skb will be > retried from upper layer and used again. > Also, the existing code doesn't free send buffer slot in error case, because > there is no completion message for unsen

Re: [PATCHv3] staging: vt6656: removed erroneous else statement

2015-01-31 Thread Greg Kroah-Hartman
On Sat, Jan 31, 2015 at 02:05:21PM -0500, Derrick Greenspan wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: else is not generally useful after a break or return > 559: FILE: drivers/staging/vt6656/rxtx.c:559: > return vnt_rxtx_datahead_g_fb(tx_context, &buf->data_head); > } else

Re: [PATCH v2] kernel: Conditionally support non-root users, groups and capabilities

2015-01-31 Thread Richard Weinberger
Am 01.02.2015 um 00:30 schrieb Paul E. McKenney: > On Fri, Jan 30, 2015 at 10:56:14PM +0100, Richard Weinberger wrote: >> On Fri, Jan 30, 2015 at 10:40 PM, Josh Triplett >> wrote: >>> *Today*, Linux is a challenging choice for a tiny embedded system. >>> We're trying to fix that. >> >> Can you pl

Re: [PATCH v2] kernel: Conditionally support non-root users, groups and capabilities

2015-01-31 Thread Paul E. McKenney
On Fri, Jan 30, 2015 at 10:56:14PM +0100, Richard Weinberger wrote: > On Fri, Jan 30, 2015 at 10:40 PM, Josh Triplett wrote: > > *Today*, Linux is a challenging choice for a tiny embedded system. > > We're trying to fix that. > > Can you please more specific about the embedded systems exactly you

Re: [PATCH 05/10] drivers/char: Support compiling out /dev/zero

2015-01-31 Thread Josh Triplett
On Wed, Jan 28, 2015 at 05:20:08PM -0600, Tom Zanussi wrote: > On Wed, 2015-01-28 at 13:51 -0800, j...@joshtriplett.org wrote: > > On Wed, Jan 28, 2015 at 10:07:51PM +0100, Pavel Machek wrote: > > > On Fri 2015-01-23 12:37:11, Tom Zanussi wrote: > > > > Some embedded systems with tightly controlled

Re: [PATCH] net: sched: One function call less in em_meta_change() after error detection

2015-01-31 Thread Lino Sanfilippo
On 31.01.2015 23:20, SF Markus Elfring wrote: >>> I find that all these cases correspond to the current Linux coding >>> style documentation, doesn't it? >> >> Sure, I think it does. > > Thanks for your acknowledgement. > > >> But it was not coding style violation what I was reffering to. > >

[PATCH 5/5] ARM: dts: pxa: add pxa-timer to pxa27x

2015-01-31 Thread Robert Jarzmik
Each pxa has an embedded OS Timers IP. The kernel cannot work without a valid clocksource, and this adds the OS Timers to the pxa device-tree description. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa27x.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/b

[PATCH 4/5] ARM: dts: pxa: add pxa27x-keypad to pxa27x

2015-01-31 Thread Robert Jarzmik
Each pxa27x has an embedded keypad controller. Add it in the pxa27x device-tree description. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa27x.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi index 979560c..7

[PATCH 2/5] ARM: dts: pxa: add clocks

2015-01-31 Thread Robert Jarzmik
Add clocks to the IPs already described in the pxa device-tree files. There are more clocks in the clock tree than IPs described in the current pxa device-tree. This patch ensures that : - the current description is correct - the clocks are actually claimed, so that clock framework doesn't di

[PATCH 3/5] ARM: dts: pxa: add pxa27x-udc to pxa27x

2015-01-31 Thread Robert Jarzmik
Each pxa27x has an embedded usb udc controller. Add it in the pxa27x device-tree description. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa27x.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi index 7cbf36f..9

[PATCH 1/5] ARM: dts: pxa: add pwri2c to pxa device-tree

2015-01-31 Thread Robert Jarzmik
Each pxa variant has 2 I2C busses on the SoC : - the casual I2C - the power I2C, normally driving power regulators, and capable of receiving orders on core frequency modifications Add the missing pwri2c to pxa description. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa2xx.dtsi | 9 +

Video screen corruption after resume from suspend2ram

2015-01-31 Thread Richard Weinberger
Hi! I'm facing a strange issue on my Laptop (Lenovo T430, UEFI boot). Sometimes after resuming from suspend2ram the system freezes after 0 to 2 minutes and my screen corrupts as shown on this photo: http://git.infradead.org/~rw/crash_suspend.jpg The screen corruption always shows the same patter

[PATCH] clocksource: pxa: fix section mismatch

2015-01-31 Thread Robert Jarzmik
As pxa_timer_common_init() is only called in init context, mark it as such, and quiesce the compiler warnings : WARNING: vmlinux.o(.text.unlikely+0x45d4): Section mismatch in reference from the function pxa_timer_common_init() to the function .init.text:sched_clock_register() WARNING: vmlinux.o(.t

[PATCH v2] checkpatch: enhance check for seq_printf uses that could be seq_puts

2015-01-31 Thread Heba Aamer
This patch enhances the check for seq_printf uses that could be seq_puts. It was considering the escape of % is \%, but it is %%. This led to skipping some valid cases related to that warning. Signed-off-by: Heba Aamer --- v2: remove not needed if condition scripts/checkpatch.pl |3 ++- 1

[PATCH] clk: pxa: fix pxa27x_clocks_init scope

2015-01-31 Thread Robert Jarzmik
As pxa27x_clocks_init() is called from early boot stage, it has to be reachable from pxa architecture code, as are pxa25x_clocks_init() and pxa2xx_clock_init(). Remove the static declaration, which was introduced before the order issue between clocks and the timer was discovered (ie. the clocks ha

[PATCH] ARM: pxa: pxa27x skip default device initialization with DT

2015-01-31 Thread Robert Jarzmik
When booting via DT, the default PXA devices must not have been probed before, otherwise the augmented information from the device tree is ignored. This is the twin commit of commit 82ce44d104dc ("ARM: pxa3xx: skip default device initialization when booting via DT"). Signed-off-by: Robert Jarzmik

[PATCH] ARM: pxa: fix pxa interrupts handling in DT

2015-01-31 Thread Robert Jarzmik
The commit "ARM: pxa: arbitrarily set first interrupt number" changed the first pxa interrupt to 16. As a consequence, device-tree builds got broken, because : - pxa_mask_irq() and pxa_unmask_irq() are using IRQ_BIT() - IRQ_BIT(x) calculates the interrupts as : x - PXA_IRQ(0) Before the commit,

Re: [PATCHv3] staging: vt6656: removed erroneous else statement

2015-01-31 Thread Malcolm Priestley
On 31/01/15 19:05, Derrick Greenspan wrote: This patch fixes the checkpatch.pl warning: WARNING: else is not generally useful after a break or return 559: FILE: drivers/staging/vt6656/rxtx.c:559: Checkpatch does not check that the if and else has different function scope. It isn't erroneous

Re: [PATCH] net: sched: One function call less in em_meta_change() after error detection

2015-01-31 Thread SF Markus Elfring
>> I find that all these cases correspond to the current Linux coding >> style documentation, doesn't it? > > Sure, I think it does. Thanks for your acknowledgement. > But it was not coding style violation what I was reffering to. Do you suggest any fine-tuning for the affected documentation s

[PATCH v2] staging: speakup: Fix warning of line over 80 characters.

2015-01-31 Thread Shirish Gajera
This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters All line over 80 characters in driver/staging/speakup/* are fixed. Aditional changes suggest by mailing list are also fixed. Signed-off-by: Shirish Gajera --- drivers/staging/speakup/main.c | 12

Re: [PATCH] net: sched: One function call less in em_meta_change() after error detection

2015-01-31 Thread Lino Sanfilippo
On 31.01.2015 22:48, SF Markus Elfring wrote: > > I find that all these cases correspond to the current Linux coding > style documentation, doesn't it? > Sure, I think it does. But it was not coding style violation what I was reffering to. Regards, Lino -- To unsubscribe from this list: send

Re: [PATCH] staging: vt6655: dpc: Removed variables that is never used

2015-01-31 Thread Malcolm Priestley
On 31/01/15 15:16, Rickard Strandqvist wrote: Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/vt665

Re: [PATCH] net: sched: One function call less in em_meta_change() after error detection

2015-01-31 Thread Lino Sanfilippo
On 31.01.2015 22:52, SF Markus Elfring wrote: >>> -errout: >>> - if (err && meta) >>> - meta_delete(meta); >> >> Since this patch seems to be about optimization and cleanup you should >> probably also remove the now unnecessary initialization of "meta" with >> NULL at the beginning of

Re: Linux 3.19-rc5

2015-01-31 Thread Linus Torvalds
On Sat, Jan 31, 2015 at 12:16 PM, Peter Zijlstra wrote: > > All the stuff it flagged are genuinely wrong, albeit not disastrously > so, things mostly just work. I really disagree. They weren't wrong. They *could* occasionally result in extra reschedules, but that was never wrong to begin with.

Re: [PATCH] net: sched: One function call less in em_meta_change() after error detection

2015-01-31 Thread SF Markus Elfring
>> -errout: >> -if (err && meta) >> -meta_delete(meta); > > Since this patch seems to be about optimization and cleanup you should > probably also remove the now unnecessary initialization of "meta" with > NULL at the beginning of the function... Will the optimiser of the C compil

Re: [PATCH] net: sched: One function call less in em_meta_change() after error detection

2015-01-31 Thread SF Markus Elfring
>> +exit: >> return err; >> } > > Why do you use that exit label if it does nothing more than returning > the error value? Also if nla_parse fails you dont use it but return the > error directly. While using a label which is used only to return an > error may be a matter of taste, its at lea

Mess in the /sysfs: class/power_supply

2015-01-31 Thread Pavel Machek
Hi! So we have multiple values in one sysfs file: root@n900:/sys/class/power_supply# cat bq24150a-0/registers 0x00=0x50 0x01=0xc8 0x02=0x8e 0x03=0x4b 0x04=0x99 (should this go to debugfs somewhere?) Unobvious and undocumented entries: root@n900:/sys/class/power_supply# cat bq24150a-0/boost_sta

[PATCH 3/3] netlabel: Less function calls in netlbl_mgmt_add_common() after error detection

2015-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 31 Jan 2015 21:55:48 +0100 The functions "cipso_v4_doi_putdef" and "kfree" could be called in some cases by the netlbl_mgmt_add_common() function during error handling even if the passed variables contained still a null pointer. * This implementation detail could

[PATCH 2/3] netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_free"

2015-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 31 Jan 2015 19:35:59 +0100 The cipso_v4_doi_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/3] netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_putdef"

2015-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 31 Jan 2015 19:09:50 +0100 The cipso_v4_doi_putdef() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --

Re: patch-2.7.3 no longer applies relative symbolic link patches

2015-01-31 Thread Andreas Gruenbacher
On Tue, 27 Jan 2015 15:47:04 +, Andreas Gruenbacher wrote: > On Mon, 26 Jan 2015 13:50:10 -0800, Linus Torvalds wrote: >> I _think_ we allow arbitrary symlinks to be created, but then we should >> be careful about actually _following_ them. > > I would prefer to allow arbitrary symlinks even i

Re: [PATCH 4/5] locking/rwsem: Avoid deceiving lock spinners

2015-01-31 Thread Davidlohr Bueso
On Sat, 2015-01-31 at 13:14 -0800, Davidlohr Bueso wrote: > - owner changes from nil: implies that a writer now holds the mutex. Why Err... that should say rwsem. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 4/5] locking/rwsem: Avoid deceiving lock spinners

2015-01-31 Thread Davidlohr Bueso
On Sat, 2015-01-31 at 10:29 +0100, Peter Zijlstra wrote: > On Fri, Jan 30, 2015 at 01:14:26AM -0800, Davidlohr Bueso wrote: > > +++ b/kernel/locking/rwsem-xadd.c > > @@ -337,21 +337,30 @@ static inline bool owner_running(struct rw_semaphore > > *sem, > > static noinline > > bool rwsem_spin_on_ow

[BISECTED REGRESSION in 3.19-rc1] [drm/i915] WARNING: drivers/gpu/drm/drm_irq.c:1077 drm_wait_one_vblank

2015-01-31 Thread Andrey Skvortsov
Hi, this warning exist in v3.19-rc6 and does not in v3.18. Bisection points to the commit 51e31d49c890552 "drm/i915: Use generic vblank wait". I have two machines with integrated Intel graphics and the problem happens only on the old one with GM965 chipset and X3100 integrated graphics. backtrac

[PATCH 0/3] netlabel: Deletion of a few unnecessary checks

2015-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 31 Jan 2015 22:00:14 +0100 Further update suggestions were taken into account after patches were applied from static source code analysis. Markus Elfring (3): Deletion of an unnecessary check before the function call "cipso_v4_doi_putdef" Deletion of an unnec

[PATCH v2 2/3] lib: move find_last_bit to lib/find_next_bit.c

2015-01-31 Thread yury . norov
From: Yury Norov Currently all 'find_*_bit' family is located in lib/find_next_bit.c, except 'find_last_bit', which is in lib/find_last_bit.c. It seems, there's no major benefit to have it separated. Signed-off-by: Yury Norov --- lib/Makefile| 2 +- lib/find_last_bit.c | 34 --

[PATCH v2 3/3] lib: rename lib/find_next_bit.c to lib/find_bit.c

2015-01-31 Thread yury . norov
From: Yury Norov This file contains implementation for: - find_last_bit; - find_first_zero_bit; - find_first_bit; - find_next_zero_bit; - find_next_bit. So giving more generic name looks reasonable. Signed-off-by: Yury Norov --- lib/Makefile| 2 +- lib/find_bit.c | 194

[PATCH v2 1/3] lib: find_*_bit reimplementation

2015-01-31 Thread yury . norov
From: Yury Norov New implementations takes less space in source file (see diffstat) and in object. For me it's 710 vs 453 bytes of text. Patch was boot-tested on x86_64 and MIPS (big-endian) machines. Performance tests were ran on userspace with code like this: /* addr[] is filled from

Re: [PATCH] lustre:include:linux:libcfs:libcfs_private.h:fixes the duplicate case value issue.

2015-01-31 Thread Jeremiah Mahler
On Fri, Jan 30, 2015 at 03:55:49PM +0530, chowdegowda...@smartplayin.com wrote: > From: Chowdegowda > There are a lot of problems with this patch. First, is "Chowdegowda" your full name that you would use to sign legal documents? In your Subject line Subject: [PATCH] lustre:include:linux:li

Re: [PATCH] powerpc/mm: bail out early when flushing TLB page

2015-01-31 Thread Benjamin Herrenschmidt
On Fri, 2015-01-30 at 19:08 +0700, Arseny Solokha wrote: > MMU_NO_CONTEXT is conditionally defined as 0 or (unsigned int)-1. However, > in __flush_tlb_page() a corresponding variable is only tested for open > coded 0, which can cause NULL pointer dereference if `mm' argument was > legitimately pass

Re: [PATCH] Warning that occured while compiling the nvec in3.19.0-rc5+ is fixed

2015-01-31 Thread Marc Dietrich
Am Samstag 31 Januar 2015, 20:11:29 schrieb Julian Andres Klode: > On 31 January 2015 at 17:29, Greg KH wrote: > > On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote: > >> The task was to fix a warning which was shown while compiling a driver > >> called NVEC. I wrote a brief description

Re: Linux 3.19-rc5

2015-01-31 Thread Peter Zijlstra
On Sat, Jan 31, 2015 at 10:32:23AM -0800, Linus Torvalds wrote: > On Fri, Jan 30, 2015 at 7:47 AM, Oleg Nesterov wrote: > > > > Perhaps sched_annotate_sleep() shouldn't depend on CONFIG_DEBUG_ATOMIC_SLEEP > > too... > > Ugh. That thing is horrible. The naming doesn't make it obvious at all > that

Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable

2015-01-31 Thread Guenter Roeck
On 01/29/2015 11:30 AM, Guenter Roeck wrote: On Thu, Jan 29, 2015 at 01:07:10PM +0100, Robert Rosengren wrote: Is your hardware big endian or little endian ? CONFIG_CPU_LITTLE_ENDIAN=y Hi Robert, I have another question: What is your i2c controller type ? Robert, I now tried both 3.15

[PATCH 2/6] toshiba_acpi: Add fan entry to sysfs

2015-01-31 Thread Azael Avalos
This patch adds a fan entry to sysfs, enabling the user to get and set the fan status. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 51 - 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/toshiba_acpi.c

[PATCH 1/6] toshiba_acpi: Add version entry to sysfs

2015-01-31 Thread Azael Avalos
This patch adds a new entry to the sysfs, showing the version of the driver. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 4e8a8c

[PATCH 0/6] toshiba_acpi: Add new features plus some profs ports

2015-01-31 Thread Azael Avalos
These patches add five new files to sysfs. With the first two files we are paving the way to the (hopefully) future removal of the (now deprecated) proc entries. The remaining entries were not ported due to the fact that they duplicate existing kernel functionality (eg.: lcd <-> backlight, keys <-

[PATCH 4/6] toshiba_acpi: Add support for Panel Power ON

2015-01-31 Thread Azael Avalos
Toshiba laptops come with a feature called "Panel Open - Power ON", which makes the laptop turn on whenever the LID is opened. This patch adds support for such feature, by creating a sysfs entry named "panel_power_on", accepting only two values, 0 to disable and 1 to enable such feature. Signed-o

[PATCH 5/6] toshiba_acpi: Add support to enable/disable USB 3

2015-01-31 Thread Azael Avalos
Toshiba laptops that come with USB 3 ports have a feature that lets them disable USB 3 functionality and act as a regular USB 2 port, and thus, saving power. This patch adds support to that feature, by creating a sysfs entry named "usb_three", acceptig only two parameters, 0 to disable the USB 3 (

[PATCH 3/6] toshiba_acpi: Add support for Keyboard functions mode

2015-01-31 Thread Azael Avalos
Recent Toshiba laptops that come with the new keyboard layout have the Special Functions (hotkeys) enabled by default, which, in order to access the F{1-12} keys, you need to press the FN-F{1-12} key to access such key. This patch adds support to toggle the Keyboard Functions operation mode by cre

[PATCH 6/6] toshiba_acpi: Bump version number to 0.21

2015-01-31 Thread Azael Avalos
Several new features were added on previous patches, so lets bump up the driver version. And also, update the copyright year. Signed-off-by: Azael Avalos --- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/toshiba_

Re: [PATCH v2 2/3] Documentation: DT bindings: add more Tegra chip compatible strings

2015-01-31 Thread Eduardo Valentin
Hey Paul! On Fri, Jan 30, 2015 at 03:11:04PM -0700, Paul Walmsley wrote: > Align compatible strings for several IP blocks present on Tegra chips > with the latest doctrine from the DT maintainers: > > http://marc.info/?l=devicetree&m=142255654213019&w=2 > > The primary objective here is to avoid

Re: [PATCH v4 2/2] thermal: exynos: Add TMU support for Exynos7 SoC

2015-01-31 Thread Eduardo Valentin
On Tue, Jan 27, 2015 at 11:18:22AM +0530, Abhilash Kesavan wrote: > Add registers, bit fields and compatible strings for Exynos7 TMU > (Thermal Management Unit). Following are a few of the differences > in the Exynos7 TMU from earlier SoCs: > - 8 trigger levels > - Different bit off

[PATCHv3] staging: vt6656: removed erroneous else statement

2015-01-31 Thread Derrick Greenspan
This patch fixes the checkpatch.pl warning: WARNING: else is not generally useful after a break or return 559: FILE: drivers/staging/vt6656/rxtx.c:559: return vnt_rxtx_datahead_g_fb(tx_context, &buf->data_head); } else { Signed-off-by: Derrick Greenspan --- Changes in v2: - Hopefully fixed whit

[Git BUG] Please do not use "-B -M" in "diff" family for now

2015-01-31 Thread Junio C Hamano
Please avoid the combination "-B -M" when running "diff" family of commands, as it can produce incorrect results [*1*] in corner cases. Use of either "-B" or "-M" by itself is fine, but not both at the same time. This problem exists even in Git v1.7.12, and I have no reason to suspect that it work

Re: [PATCH] Warning that occured while compiling the nvec in 3.19.0-rc5+ is fixed

2015-01-31 Thread Julian Andres Klode
On 31 January 2015 at 17:29, Greg KH wrote: > On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote: >> The task was to fix a warning which was shown while compiling a driver >> called NVEC. I wrote a brief description about how to enable support for >> a nVidya complaint embedded controller

[PATCHv2 1/1] cpufreq: exynos: allow modular build

2015-01-31 Thread Eduardo Valentin
From: Arnd Bergmann The exynos cpufreq driver code recently gained a dependency on the cooling code, which may be a loadable module. This breaks an ARM allmodconfig build: drivers/built-in.o: In function `exynos_cpufreq_probe': :(.text+0x1748e8): undefined reference to `of_cpufreq_cooling_regist

[PATCH] thinkpad_acpi: unhandled hkey event

2015-01-31 Thread Xavier Naveira
Pressing Fn+Esc in a Lenovo Thinkpad x240 to lock the Fn keys generates an unhandled hkey event Signed-off-by: Xavier Naveira --- drivers/platform/x86/thinkpad_acpi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_

Re: [PATCH] drivers: mmc: card: Fixing few coding style errors from file block.c

2015-01-31 Thread Joe Perches
On Sat, 2015-01-31 at 23:37 +0530, Sheetal Tigadoli wrote: > The patch fixes some of the following error/warnings from the file block.c > > ./scripts/checkpatch.pl --file --terse drivers/mmc/card/block.c Hi. It's a lot easier to review and accept these sorts of changes if you break them into mo

Re: [PATCH] net: sctp: Deletion of an unnecessary check before the function call "kfree"

2015-01-31 Thread Neil Horman
On Sat, Jan 31, 2015 at 06:15:59PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 31 Jan 2015 18:10:03 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected b

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-01-31 Thread Tomeu Vizoso
On 31 January 2015 at 02:31, Stephen Boyd wrote: > On 01/29, Stephen Boyd wrote: >> On 01/29/15 05:31, Geert Uytterhoeven wrote: >> > Hi Tomeu, Mike, >> > >> > On Fri, Jan 23, 2015 at 12:03 PM, Tomeu Vizoso >> > wrote: >> >> --- a/drivers/clk/clk.c >> >> +++ b/drivers/clk/clk.c >> >> @@ -2391,25

[PATCH v2] ata: libahci: Use of_platform_device_create only if supported

2015-01-31 Thread Guenter Roeck
of_platform_device_create does not exist if OF_ADDRESS is not configured, so limit its use accordingly. Without this fix, the sparc64:allmodconfig build fails with ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined! Fixes: c7d7ddee7e24 ("ata: libahci: Allow using mult

Re: Linux 3.19-rc5

2015-01-31 Thread Linus Torvalds
On Fri, Jan 30, 2015 at 7:47 AM, Oleg Nesterov wrote: > > Perhaps sched_annotate_sleep() shouldn't depend on CONFIG_DEBUG_ATOMIC_SLEEP > too... Ugh. That thing is horrible. The naming doesn't make it obvious at all that it's actually making sure that we have state set to TASK_RUNNING, and I could

[PATCH] Staging: rtl8192e: Fixed unnecessary line continuation.

2015-01-31 Thread Kolbeinn Karlsson
Fixed a coding style issue. Signed-off-by: Kolbeinn Karlsson --- drivers/staging/rtl8192e/rtllib_module.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_module.c b/drivers/staging/rtl8192e/rtllib_module.c index 91e98e8..0cf3809 100644 ---

[PATCH] drivers: mmc: card: Fixing few coding style errors from file block.c

2015-01-31 Thread Sheetal Tigadoli
The patch fixes some of the following error/warnings from the file block.c ./scripts/checkpatch.pl --file --terse drivers/mmc/card/block.c drivers/mmc/card/block.c:45: WARNING: Use #include instead of drivers/mmc/card/block.c:102: WARNING: line over 80 characters drivers/mmc/card/block.c:186:

Re: [PATCH] net: sched: One function call less in em_meta_change() after error detection

2015-01-31 Thread Lino Sanfilippo
On 31.01.2015 17:34, SF Markus Elfring wrote: > -errout: > - if (err && meta) > - meta_delete(meta); Since this patch seems to be about optimization and cleanup you should probably also remove the now unnecessary initialization of "meta" with NULL at the beginning of the function.

Re: [PATCH] staging: rtl8188eu: core: rtw_sta_mgt: Removed variables that is never used

2015-01-31 Thread Larry Finger
On 01/31/2015 10:19 AM, Dan Carpenter wrote: On Sat, Jan 31, 2015 at 03:45:33PM +0100, Rickard Strandqvist wrote: while (phead != plist) { - psta = container_of(plist, struct sta_info , list); + container_of(plist, struct sta_info, list); Argh!!! No. For

Re: [PATCH] ata: libahci: Use of_platform_device_create only if supported

2015-01-31 Thread Guenter Roeck
On 01/31/2015 09:08 AM, Tejun Heo wrote: On Sat, Jan 31, 2015 at 08:53:36AM -0800, Guenter Roeck wrote: I agree, it is weird, as is the whole "all API functions associated with OF_ADDRESS are handled differently on sparc" thing. But that is neither new nor something I can fix. Out of curiousit

[RESEND PATCH] lib/int_sqrt.c: Optimize square root function

2015-01-31 Thread Anshul Garg
From: Anshul Garg Unnecessary instructions are executing even though m is greater than x so added logic to make m less than equal to x before performing these operations. Signed-off-by: Anshul Garg --- lib/int_sqrt.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/int_sqrt.c b/li

Re: [PATCH] net: sched: One function call less in em_meta_change() after error detection

2015-01-31 Thread Lino Sanfilippo
Hi, On 31.01.2015 17:34, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 31 Jan 2015 17:18:48 +0100 > > The meta_delete() function could be called in four cases by the > em_meta_change() function during error handling even if the passed > variable "meta" contained still a null point

[PATCH] net: sctp: Deletion of an unnecessary check before the function call "kfree"

2015-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 31 Jan 2015 18:10:03 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/sctp/as

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-01-31 Thread Alan Stern
On Fri, 30 Jan 2015, Andi Kleen wrote: > > We don't "need" any backward compatility, why not fix the broken drivers > > that are using memory outside of what they are asking for? That's not > > ok no matter what, right? > > How would you find them all? > > We don't even know which place in XHCI

[PATCH 2/2] ARM: OMAP5: dts: Fix the bypass clock source for dpll_iva and others

2015-01-31 Thread Ravikumar Kattekola
Fixes 85dc74e9 (ARM: dts: omap5 clock data) On OMAP54xx, For DPLL_IVA, the ref clock(CLKINP) is connected to sys_clk1 and the bypass input(CLKINPULOW) is connected to iva_dpll_hs_clk_div clock. But the bypass input is not directly routed to bypass clkout instead both CLKINP and CLKINPU

[PATCH 0/2] ARM: DRA7x/OMAP5: Clock: DPLL Clock fixes

2015-01-31 Thread Ravikumar Kattekola
Fix bypass clock source for a few DPLLs. On DRA7x/OMAP5, for a few DPLLs, both CLKINP and CLKINPULOW are connected to a mux and the output from mux is routed to the bypass clkout. Add a mux-clock as bypass clock with CLKINP and CLKINPULOW as parents. Tested against: tree: https://git.ker

Re: [PATCH] ata: libahci: Use of_platform_device_create only if supported

2015-01-31 Thread Tejun Heo
On Sat, Jan 31, 2015 at 08:53:36AM -0800, Guenter Roeck wrote: > I agree, it is weird, as is the whole "all API functions associated > with OF_ADDRESS are handled differently on sparc" thing. But that > is neither new nor something I can fix. Out of curiousity, why isn't the header file doing the

[PATCH 1/2] ARM: DRA7x: dts: Fix the bypass clock source for dpll_iva and others

2015-01-31 Thread Ravikumar Kattekola
Fixes: ee6c750761 (ARM: dts: dra7 clock data) On DRA7x, For DPLL_IVA, the ref clock(CLKINP) is connected to sys_clk1 and the bypass input(CLKINPULOW) is connected to iva_dpll_hs_clk_div clock. But the bypass input is not directly routed to bypass clkout instead both CLKINP and CLKINPULOW are conne

Re: [PATCH v2] kernel: Conditionally support non-root users, groups and capabilities

2015-01-31 Thread Jarkko Sakkinen
On Fri, Jan 30, 2015 at 11:48:04AM -0800, Casey Schaufler wrote: > > The kinds of applications we're talking about here run entirely in one > > binary, serving a few very narrow functions. We're not talking > > "automobile IVI system" here; we're talking "two buttons and an output", > > or "a few

Re: [GIT PULL 0/9] phy: for 3.20 merge window

2015-01-31 Thread Greg KH
On Sat, Jan 31, 2015 at 07:58:07PM +0530, Kishon Vijay Abraham I wrote: > Hi Greg, > > Please find the PULL REQUEST for 3.20 merge window. It's a rather > short pull request which includes a new PHY driver for rockchip and contains > few > misc fixes. > > There is a patch which modifies the dt d

Re: [PATCH] ata: libahci: Use of_platform_device_create only if supported

2015-01-31 Thread Guenter Roeck
On 01/31/2015 08:45 AM, Tejun Heo wrote: On Sat, Jan 31, 2015 at 08:32:18AM -0800, Guenter Roeck wrote: of_platform_device_create does not exist if OF_ADDRESS is not configured, so limit its use accordingly. Without this fix, the sparc64:allmodconfig build fails with ERROR: "of_platform_device

Re: [PATCH v9 2/5] mfd: AXP20x: Add bindings documentation

2015-01-31 Thread Chen-Yu Tsai
Hi Lee, On Thu, Jan 22, 2015 at 5:02 PM, Lee Jones wrote: > On Thu, 22 Jan 2015, Chen-Yu Tsai wrote: > >> From: Carlo Caione >> >> Bindings documentation for the AXP20x driver. In this file also >> sub-nodes are documented. >> >> Signed-off-by: Carlo Caione >> Acked-by: Maxime Ripard >> [w...@

  1   2   3   >