[PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-01-17 Thread Shirish Gajera
This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters All line over 80 characters in driver/staging/speakup/* are fixed Signed-off-by: Shirish Gajera --- drivers/staging/speakup/main.c | 12 drivers/staging/speakup/serialio.h | 3 ++- driver

[PATCH] staging: lustre: remove kmalloc from fld_proc_hash_seq_write

2015-01-17 Thread Tristan Lelong
This patch simplifies the fld_proc_hash_seq_write function by removing the dynamic memory allocation. The longest fh_name used so far in lustre is 4 characters. We use a 8 bytes variable to be on the safe side. Signed-off-by: Tristan Lelong --- Hi Greg, This patch is a rework of "staging: lustr

[PATCH] MAINTAINERS: add Android driver entries

2015-01-17 Thread Greg KH
Put down me, Arve, and Riley as maintainers for the android drivers. Cc: Arve Hjønnevåg Cc: Riley Andrews Signed-off-by: Greg Kroah-Hartman diff --git a/MAINTAINERS b/MAINTAINERS index 3589d67437f8..95fd5c66ba09 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -708,6 +708,16 @@ X: drivers/iio/*/

[PATCH] staging: wlan-ng: hfa384x_usb: fix sparse endianness warnings

2015-01-17 Thread Asaf Vertz
Fixed the following warnings (reported by sparse): drivers/staging/wlan-ng/hfa384x_usb.c:3828:36: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3229:16: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3430:18: warning: cast to restricted __le16

Re: 3.18 regression: Error while assigning device slot ID, USB3 devices not detected

2015-01-17 Thread Greg KH
On Sun, Jan 18, 2015 at 12:08:18AM -0600, Robert Hancock wrote: > I've got an Intel Haswell-based system with a Gigabyte Z87X-D3H motherboard > under Fedora 21. After updating to the 3.18.2-200 Fedora kernel, I noticed > some errors in dmesg and at least some of my USB3 ports don't recognize any >

Re: [PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2015-01-17 Thread Greg KH
On Sat, Jan 17, 2015 at 10:41:44PM -0800, Tristan Lelong wrote: > Hi Greg, > > On Sat, Jan 17, 2015 at 03:28:27PM -0800, Greg KH wrote: > > > > I took your v2 version, please send me the difference as this is a > > mess... > > Not sure I understand what you meant here. > Do you want me to submi

Re: [PATCH v7 06/17] ARM64 / ACPI: Make PCI optional for ACPI on ARM64

2015-01-17 Thread Hanjun Guo
On 2015年01月18日 14:31, Jon Masters wrote: Hi Folks, Sorry for top posting from bed. The mainstream servers will all likely do > PCIe but there are several that may not. They should not be excluded. That said, >if we booted a previously built kernel on a system without an MCFG and > got no ECAM/

[PATCH 1/2] drivers: scsi: mpt2sas: Added pci_dma_mapping_error() call

2015-01-17 Thread Tina Johnson
Replaced null test on dma handle with pci_dma_mapping_error() o check for mapping errors. Coccinelle was used to find cases that do not check for dma mapping errors: @rule1@ statement S; identifier x; @@ *x = pci_map_single(...); if (!x) S Signed-off-by: Tina Johnson Acked-by: Julia Lawall

[PATCH 2/2] drivers: scsi: mpt2sas: Clean up error handling for calls to pci_map_single

2015-01-17 Thread Tina Johnson
*Currently, the error handling code is organized to free dma_addr_out, dma_addr_in and then pci_addr_out, pci_addr_in. Since dma_addr_out and pci_addr_out are allocated first and then dma_addr_in and pci_addr_in, the error handling code is reorganized to free the in variables first and then th

[PATCH 0/2] Added pci_mapping_error() call and related clean up

2015-01-17 Thread Tina Johnson
Replaced null test on dma handle with pci_dma_mapping_error() and cleaned up the error handling code. Tina Johnson (2): drivers: scsi: mpt2sas: Added pci_dma_mapping_error() call drivers: scsi: mpt2sas: Clean up error handling for calls to pci_map_single drivers/scsi/mpt2sas/mpt2sas_transpo

Re: [PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2015-01-17 Thread Tristan Lelong
Hi Greg, On Sat, Jan 17, 2015 at 03:28:27PM -0800, Greg KH wrote: > > I took your v2 version, please send me the difference as this is a > mess... Not sure I understand what you meant here. Do you want me to submit a new patch that contains only the differences between v2 and v3? Thanks, Reg

Re: [PATCH v7 00/17] Introduce ACPI for ARM64 based on ACPI 5.1

2015-01-17 Thread Hanjun Guo
On 2015年01月16日 18:10, Catalin Marinas wrote: On Thu, Jan 15, 2015 at 08:04:37PM +, Jason Cooper wrote: On Thu, Jan 15, 2015 at 07:02:20PM +, Mark Brown wrote: On Thu, Jan 15, 2015 at 06:23:47PM +, Catalin Marinas wrote: On Thu, Jan 15, 2015 at 04:26:20PM +, Grant Likely wrote:

Re: [PATCH v7 06/17] ARM64 / ACPI: Make PCI optional for ACPI on ARM64

2015-01-17 Thread Jon Masters
Hi Folks, Sorry for top posting from bed. The mainstream servers will all likely do PCIe but there are several that may not. They should not be excluded. That said, if we booted a previously built kernel on a system without an MCFG and got no ECAM/root then things would probably still work. I

Re: [RFC 1/3] i2c: Enhancement of i2c API to address circular lock dependency problem

2015-01-17 Thread Tomasz Figa
Hi, [CCing more people] 2015-01-16 23:39 GMT+09:00 Paul Osmialowski : > This enhancement of i2c API is designed to address following problem > caused by circular lock dependency: > > -> #1 (prepare_lock){+.+.+.}: > [2.730502][] __lock_acquire+0x3c0/0x8a4 > [2.735970][] loc

Re: [PATCH v7 06/17] ARM64 / ACPI: Make PCI optional for ACPI on ARM64

2015-01-17 Thread Hanjun Guo
On 2015年01月16日 17:49, Catalin Marinas wrote: On Wed, Jan 14, 2015 at 03:04:54PM +, Hanjun Guo wrote: Since PCI is not required in ACPI spec and ARM can run without it, introduce some stub functions to make PCI optional for ACPI, and make ACPI core run without CONFIG_PCI on ARM64. When PCI i

3.18 regression: Error while assigning device slot ID, USB3 devices not detected

2015-01-17 Thread Robert Hancock
I've got an Intel Haswell-based system with a Gigabyte Z87X-D3H motherboard under Fedora 21. After updating to the 3.18.2-200 Fedora kernel, I noticed some errors in dmesg and at least some of my USB3 ports don't recognize any USB3 devices plugged into them: [0.560838] xhci_hcd :00:14.

[GIT PULL] ARM: SoC fixes

2015-01-17 Thread Olof Johansson
Hi Linus, The following changes since commit eaa27f34e91a14cdceed26ed6c6793ec1d186115: linux 3.19-rc4 (2015-01-11 12:44:53 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/armsoc-for-linus for you to fetch changes up to 9669

Re: [PATCH v7 07/17] ARM64 / ACPI: Disable ACPI if FADT revision is less than 5.1

2015-01-17 Thread Hanjun Guo
On 2015年01月16日 22:33, Lorenzo Pieralisi wrote: On Wed, Jan 14, 2015 at 03:04:55PM +, Hanjun Guo wrote: FADT Major.Minor version was introduced in ACPI 5.1, it is the same as ACPI version. In ACPI 5.1, some major gaps are fixed for ARM, such as updates in MADT table for GIC and SMP init, wit

Re: [net-next PATCH v3 1/1] atm: remove deprecated use of pci api

2015-01-17 Thread David Miller
From: chas williams - CONTRACTOR Date: Fri, 16 Jan 2015 08:57:21 -0500 > Signed-off-by: Chas Williams - CONTRACTOR Applied, thanks Chas. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http:

Re: [PATCH 2/2] Drivers: Isdn: sc: Fixed coding style & spelling mistakes.

2015-01-17 Thread David Miller
From: Akash Shende Date: Fri, 16 Jan 2015 19:12:42 +0530 > Fix some spelling mistakes, coding style and don't assign value to static var. > > Signed-off-by: Akash Shende Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majo

Re: [PATCH] Staging: dgnc: fixed some coding style errors

2015-01-17 Thread Andrew Milkovich
On Sat, Jan 17, 2015 at 09:09:08PM -0800, Andrew Milkovich wrote: > This patch fixes the following checkpatch.pl error: > ERROR: Macros with complex values should be enclosed in parentheses > Outer parentheses were added to macro definitions. > > Signed-off-by: Andrew Milkovich > --- > drivers/s

[PATCH] Staging: dgnc: fixed some coding style errors

2015-01-17 Thread Andrew Milkovich
This patch fixes the following checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses Outer parentheses were added to macro definitions. Signed-off-by: Andrew Milkovich --- drivers/staging/dgnc/digi.h | 60 ++--- 1 file ch

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
On Sat, Jan 17, 2015 at 08:01:52PM -0800, Joe Perches wrote: > On Sat, 2015-01-17 at 19:30 -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. > > which ones? > > As far as I can tell, none of the checkpatch > warnings on this file are actually addressed > by this patc

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Joe Perches
On Sat, 2015-01-17 at 19:30 -0800, Andrew Milkovich wrote: > Fixed coding style errors per checkpatch.pl. which ones? As far as I can tell, none of the checkpatch warnings on this file are actually addressed by this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

[PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich --- drivers/staging/unisys/virtpci/virtpci.c | 24

Re: [PATCH] sysfs: group: allow is_visible to drop permissions

2015-01-17 Thread Greg Kroah-Hartman
On Sat, Jan 17, 2015 at 05:45:15PM -0800, Guenter Roeck wrote: > On 01/17/2015 02:09 PM, Vivien Didelot wrote: > >Hi Guenter, Greg, > > > [ .. ] > > > > >BTW Guenter, does this patch make sense to you? > > > > It does make sense to me to only use the return value from is_visible > for the mode. >

[PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich --- drivers/staging/unisys/virtpci/virtpci.c | 24

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Greg KH
On Sat, Jan 17, 2015 at 07:01:41PM -0800, Andrew Milkovich wrote: > Hi, > > On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > > Fixed coding style errors per checkpatch.pl. Inline comments removed; > > > chanptr > >

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Hi again, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. Inline comments removed; > > chanptr > > comment is implied by the first argument being the channel. No parent bu

Re: [PATCH 4/4] ARM: bcm2835: Use pinctrl header

2015-01-17 Thread Stephen Warren
On 01/16/2015 09:49 AM, Stefan Wahren wrote: > This patch converts all bcm2835 dts files to use the pinctrl > header file. Aside from the one comment I made, the series, Acked-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 2/4] dt-bindings: Add root properties for Raspberry Pi B and B+

2015-01-17 Thread Stephen Warren
On 01/16/2015 09:48 AM, Stefan Wahren wrote: > This patch adds root compatible properties for the following boards: > - Raspberry Pi Model B > - Raspberry Pi Model B+ We may as well add all the models while at it. I think the following is a complete list so far: "model-b-i2c0": early model B with

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Hi, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. Inline comments removed; > > chanptr > > comment is implied by the first argument being the channel. No parent bus > >

[PATCH 4/4] staging: vt6655: correcting parameter related sparse error

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces) drivers

[PATCH 3/4] staging: vt6655: fix wrong parameter as reported by sparse

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c CC [M] drivers/staging/vt6655/device_main.o CHECK drivers/staging/vt6655/card.c CC [M] drivers/staging/vt6655

[PATCH 2/4] staging: vt6655: removing dead function as reported by sparse

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ CHECK drivers/staging/vt6655/mac.c drivers/staging/vt6655/mac.c:162:6: warning: symbol 'MACvGetShortRetryLimit' was not declared. Should it be static? CC [M] drivers/staging/vt6655/mac.o Commit: 87299d

[PATCH 1/4] staging: vt6655: correcting function declaration sparse error

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be static? CC [M

[PATCH 0/4] staging: vt6655: fixing various sparse problems

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier >From a v3.19-rc4 baseline sparse finds the following errors: LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces) drivers/s

[PATCH] mmc: vub300: remove unreachable return value handling

2015-01-17 Thread Nicholas Mc Guire
Signed-off-by: Nicholas Mc Guire --- The return value of wait_for_completion_timeout is unsigned long, as it is used here for wait_for_completion_timeout only the type of commretval was changed to unsigned long. As wait_for_completion_timeout does not return negative values the commretval < 0

Re: [PATCH] hostfs: Use noop_fsync for directories

2015-01-17 Thread Daniel Gröber
From: Richard Weinberger Subject: Re: [PATCH] hostfs: Use noop_fsync for directories Date: Wed, 14 Jan 2015 09:43:53 +0100 > Daniel, are you interested in a small kernel project? Sure, I'm just pretty busy with university right now, I'll probably pick this back up after exams are finished in a m

[PATCH] video: mx3fb: fix up wait_for_completion_timeout return handling

2015-01-17 Thread Nicholas Mc Guire
Signed-off-by: Nicholas Mc Guire --- return type of wait_for_completion_timeout is unsigned long as ret is used only for checking wait_for_completion_timeout here the type was changed to unsigned long, wait_for_completion_timeout return >= 0 only so the checks for negative return canbe dropped.

Re: [PATCH] sysfs: group: allow is_visible to drop permissions

2015-01-17 Thread Guenter Roeck
On 01/17/2015 02:09 PM, Vivien Didelot wrote: Hi Guenter, Greg, [ .. ] BTW Guenter, does this patch make sense to you? It does make sense to me to only use the return value from is_visible for the mode. As for which bits to use, I am not entirely sure. I think it would be more important

Re: Intel GCM: __driver-gcm-aes-aesni setkey missing

2015-01-17 Thread Tadeusz Struk
Hi Stephan, On 01/17/2015 10:23 AM, Stephan Mueller wrote: > during testing of my algif_aead patch with the different GCM implementations > I > am able to trigger a kernel crash from user space using __driver-gcm-aes- > aesni. > > As I hope that algif_aead is going to be included, unprivileged u

Re: [PATCH] device: Change dev_ logging functions to return void

2015-01-17 Thread Greg Kroah-Hartman
On Sat, Jan 17, 2015 at 04:56:20PM -0800, Joe Perches wrote: > On Thu, 2014-12-25 at 15:07 -0800, Joe Perches wrote: > > No caller or macro uses the return value so make all > > the functions return void. > > Ping? It's in my queue, just starting to dig out from under it, give me a few more days

[PATCH v2] staging: rtl8188eu: core: rtw_wlan_util: Remove unused functions

2015-01-17 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: CAM_empty_entry() get_bsstype() rtw_get_oper_choffset() rtw_get_oper_bw() is_ap_in_wep() should_forbid_n_rate() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/st

[PATCH 3/3] x86_64, entry: Create IRET-compatible stack frame at syscall entry

2015-01-17 Thread Alexander van Heukelum
Create an IRET-compatible top of stack at syscall entry and use this information to return to user mode in the sysret path. This removes the need for the FIXUP_TOP_OF_STACK and RESTORE_TOP_OF_STACK macros. Signed-off-by: Alexander van Heukelum --- arch/x86/kernel/entry_64.S | 77 +---

[PATCH 2/3] x86_64: don't use KERNEL_STACK_OFFSET for syscall and sysenter

2015-01-17 Thread Alexander van Heukelum
The syscall and sysenter code use KERNEL_STACK_OFFSET to set the initial stack pointer a bit below the top of the kernel stack page. Stop doing that. Signed-off-by: Alexander van Heukelum --- arch/x86/ia32/ia32entry.S | 4 ++-- arch/x86/include/asm/thread_info.h | 6 ++ arch/x86/ker

[PATCH 0/3] x86_64, entry: some cleanup and simplification...

2015-01-17 Thread Alexander van Heukelum
Hi Andy, Seems you are the person to talk now :). Good to see some activity in the "entry" area of the kernel. I found some (very) old patches in this area lying around and some time to dust them off. Any chance you can review them? They were redone on top of 22f2aa4a0361707a5cfb1de9d45260b39965

[PATCH 1/3] x86_64: remove KERNEL_STACK_OFFSET from THREAD_INFO macro

2015-01-17 Thread Alexander van Heukelum
In the macro THREAD_INFO(reg,offset), the offset is relative to KERNEL_STACK_OFFSET. Change the macro and all its uses so that offset is given as the current top of stack in the pt_regs frame. The generated code is identical. Signed-off-by: Alexander van Heukelum --- arch/x86/ia32/ia32entry.S

[PATCH v2] staging: rtl8712: recv_linux: Remove unused function

2015-01-17 Thread Rickard Strandqvist
Remove the function r8712_os_read_port() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8712/recv_linux.c | 14 -- drivers/staging/rtl8712/recv_osdep.h |1 -

Re: [PATCH] device: Fix dev_dbg_once macro

2015-01-17 Thread Joe Perches
On Sat, 2015-01-03 at 09:51 -0800, Joe Perches wrote: > There is a copy/paste typo in the dev_dbg_once macro. > > It uses dev_info instead of dev_dbg, so use the correct > function instead. > > Signed-off-by: Joe Perches > Noticed-by: Marc Finet Ping? > --- > include/linux/device.h | 2 +- >

Re: [PATCH] device: Change dev_ logging functions to return void

2015-01-17 Thread Joe Perches
On Thu, 2014-12-25 at 15:07 -0800, Joe Perches wrote: > No caller or macro uses the return value so make all > the functions return void. Ping? > Compiled x86 allyesconfig and defconfig w/o CONFIG_PRINTK > > Signed-off-by: Joe Perches > --- > This change is associated to a desire to eventually

[PATCH v2] staging: rtl8723au: core: rtw_cmd: Remove unused functions

2015-01-17 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: rtw_set_ch_cmd23a() rtw_cmd_clr_isr23a() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8723au/core/rtw_cmd.c| 61 --- d

Re: SMBIOS/DMI data under CONFIG_STRICT_DEVMEM

2015-01-17 Thread Jon Masters
On 01/17/2015 06:21 PM, Leif Lindholm wrote: > On Sat, Jan 17, 2015 at 03:12:13PM -0500, Jon Masters wrote: >> Hi Catalin, all, >> >> I would like to ensure that the SMBIOS data provided by firmware is >> always readable from userspace on AArch64, through /dev/mem. > > No, we need to ensure /dev/m

[PATCH v2] staging: rtl8723au: os_dep: usb_intf: Remove unused functions

2015-01-17 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: rtw_hw_resume23a() rtw_hw_suspend23a() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8723au/include/osdep_intf.h |3 - drivers/staging/rtl8723au/

[RFC][PATCH][v2] PCI / PM: Avoid resuming PCI devices during system suspend

2015-01-17 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Commit f25c0ae2b4c4 (ACPI / PM: Avoid resuming devices in ACPI PM domain during system suspend) modified the ACPI PM domain's system suspend callbacks to allow devices attached to it to be left in the runtime-suspended state during system suspend so as to optimize the susp

Re: [PATCH 2/2] ION handle already destroyed in ion_free.

2015-01-17 Thread Greg Kroah-Hartman
On Sat, Jan 17, 2015 at 12:04:21PM +0530, Shailendra Verma wrote: > > Signed-off-by: Shailendra Verma > --- > drivers/staging/android/ion/ion.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion.c > b/drivers/staging/android/ion/ion.c > index 9e56d32..0d

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Greg KH
On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr > comment is implied by the first argument being the channel. No parent bus > comment is already understood by the argument being NULL. > > Signed-off-b

Re: [PATCH] staging: android: Fixed checkpatch.pl warning

2015-01-17 Thread Greg KH
On Mon, Jan 12, 2015 at 05:31:21PM +0100, Moritz Fischer wrote: > The file triggered the following warning: > > WARNING: line over 80 characters > > Signed-off-by: Moritz Fischer > --- > drivers/staging/android/sync_debug.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Someone else

Re: [PATCH 3/3] staging: android: struct sizeof coding style in logger.c

2015-01-17 Thread Greg Kroah-Hartman
On Mon, Jan 05, 2015 at 03:25:37PM +0100, Guillaume Vercoutere wrote: > Replace sizeof struct > > Signed-off-by: Guillaume Vercoutere Doesn't apply as I didn't take patch 2, please fix up and resend. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 2/3] staging: android: Correct NULL comparison style in logger.c

2015-01-17 Thread Greg Kroah-Hartman
On Mon, Jan 05, 2015 at 03:25:23PM +0100, Guillaume Vercoutere wrote: > Replace explicit NULL comparison with ! Not a good idea, you just lost typechecking :( -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Ray Jui
On 1/17/2015 2:40 PM, Russell King - ARM Linux wrote: > On Sat, Jan 17, 2015 at 01:26:41PM -0800, Ray Jui wrote: >> time_left = wait_for_completion_timeout(&iproc_i2c->done, time_left); >> >> /* disable all interrupts */ >> writel(0, iproc_i2c->base + IE_OFFSET); >> >> if (!ti

Re: [PATCH] Staging: slicoss: Fix long line issues in slicoss.c

2015-01-17 Thread Greg KH
On Wed, Dec 03, 2014 at 01:53:18PM +, Sean Cleator wrote: > A patch to the slicoss.c file to fix some of the long line issues found by the > checkpath.pl tool > > Signed-off-by: Sean Cleator > > --- > drivers/staging/slicoss/slicoss.c | 39 > ++- > 1 fi

Re: [PATCH] Staging: wlan-ng: hfa384x_usb: Fix else is not useful warning

2015-01-17 Thread Greg KH
On Thu, Jan 08, 2015 at 03:01:17PM +0100, Sven Dziadek wrote: > This fixes the following checkpatch.pl warning: > WARNING: else is not generally useful after a break or return > > Signed-off-by: Sven Dziadek > --- > drivers/staging/wlan-ng/hfa384x_usb.c | 9 - > 1 file changed, 4 inserti

Re: [PATCH v3] staging: writeboost: Add dm-writeboost

2015-01-17 Thread Greg KH
On Thu, Jan 01, 2015 at 05:44:39PM +0900, Akira Hayakawa wrote: > This patch adds dm-writeboost to staging tree. > > dm-writeboost is a log-structured SSD-caching driver. > It caches data in log-structured way on the cache device > so that the performance is maximized. > > The merit of putting th

Re: [PATCH 1/3] Revert "staging: sm7xxfb: remove driver"

2015-01-17 Thread Greg Kroah-Hartman
On Wed, Dec 31, 2014 at 05:56:43PM +0530, Sudip Mukherjee wrote: > This reverts commit "dc93c85235efa5201e9a3c116bc3fbd1afc1a182" > > Signed-off-by: Sudip Mukherjee > --- > > Hi Greg K-H > With reference to our discussion at https://lkml.org/lkml/2014/11/22/54 , > now I have the hardware and I w

Re: [PATCH] Staging: rts5208: fix space prohibited before ',' error in ms.c

2015-01-17 Thread Greg KH
On Tue, Jan 06, 2015 at 01:29:01AM +1100, Emrys Bayliss wrote: > Fix the checkpatch.pl errors: > ERROR: space prohibited before that ',' (ctx:WxW) > > Signed-off-by: Emrys Bayliss > --- > drivers/staging/rts5208/ms.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Someone els

Re: [PATCH] Staging: clocking-wizard: Added a blank line after declaration

2015-01-17 Thread Greg KH
On Sat, Dec 20, 2014 at 10:11:56PM -0800, Sören Brinkmann wrote: > Hi Mohammad, > > On Sun, 2014-12-21 at 08:03AM +0530, Mohammad Jamal wrote: > > Fix the coding style issue by adding blank line after declaration > > > > Signed-off-by: Mohammad Jamal > > --- > > .../clocking-wizard/clk-xlnx-clo

Re: [PATCH 1/2] staging: andriod: ion: Add ion_phys_get_by_id function

2015-01-17 Thread Greg KH
On Mon, Jan 05, 2015 at 03:51:54PM +, Tang, Feng wrote: > Hi Alan, > > Thanks for the review. > > > -Original Message- > > From: One Thousand Gnomes [mailto:gno...@lxorguk.ukuu.org.uk] > > Sent: Monday, January 05, 2015 10:25 PM > > To: Tang, Feng > > Cc: Greg KH; John Stultz; Colin C

Re: [PATCH 2/2] staging: lustre: declare internal symbols as static

2015-01-17 Thread Greg Kroah-Hartman
On Tue, Jan 13, 2015 at 11:33:03PM +0100, Luca Ceresoli wrote: > Fixes dozens of sparse warnings like: > warning: symbol 'cfs_tracefile_sem' was not declared. Should it be static? > > Signed-off-by: Luca Ceresoli > Cc: Peng Tao > Cc: Jinshan Xiong > Cc: Srikrishan Malik > Cc: hpdd-disc...@li

Re: [PATCH] staging: lustre: Fix spacing error in libcfs_string.c

2015-01-17 Thread Greg KH
On Sun, Jan 11, 2015 at 01:44:03PM -0500, Nickolaus Woodruff wrote: > This patch fixes the following checkpatch.pl error in libcfs_string.c: > > ERROR: spaces required around that '=' > > Signed-off-by: Nickolaus Woodruff > --- > drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +- > 1

[PATCH] fujitsu-laptop: use FB_BLANK_* constants

2015-01-17 Thread Michael Karcher
From: Michael Karcher Signed-off-by: Michael Karcher --- drivers/platform/x86/fujitsu-laptop.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index 7c21c1c..2a9afa2 100644 --- a/drivers/pl

Re: lustre/lnet/lnet/lib-move.c: memcpy with (struct iovec*)->iov_base, which is __user

2015-01-17 Thread Greg KH
On Wed, Jan 07, 2015 at 02:28:12PM +0200, Andrey Utkin wrote: > 2015-01-07 13:32 GMT+02:00 Dilger, Andreas : > > On 2015/01/07, 1:36 AM, "Dan Carpenter" wrote: > >> Didn't Al change these to kvec instead of iovec? You have to look at > >> the callers to figure out if it's actually a user space po

Re: [PATCH] staging: lustre: Fix sparse warning on address-space

2015-01-17 Thread Greg Kroah-Hartman
On Mon, Dec 29, 2014 at 08:49:40PM +0800, Jia He wrote: > This patch is to fix the below warnings generated by sparse: > warning: incorrect type in argument 1 (different address spaces) > expected void const volatile [noderef] * > got int * > Adding the macro "__user" can suppress the warnings,

Re: [PATCH] staging: lustre: do not ignore try_module_get() fail in obd_class_open()

2015-01-17 Thread Greg Kroah-Hartman
On Sat, Dec 27, 2014 at 02:26:53AM +0300, Alexey Khoroshilov wrote: > obd_class_open() ignores error code of try_module_get(), > while it can lead to race with module unload. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > --- > drivers

Re: [RFC 0/3] mmc: Add dynamic frequency scaling

2015-01-17 Thread Mike Turquette
Quoting Ulf Hansson (2015-01-15 02:04:04) > On 15 January 2015 at 10:20, Krzysztof Kozlowski > wrote: > > On czw, 2015-01-15 at 09:20 +0100, Ulf Hansson wrote: > >> + Mike, Stephen (Clock maintainers) > >> > >> On 12 January 2015 at 10:23, Krzysztof Kozlowski > >> wrote: > >> > Hi, > >> > > >> >

Re: [PATCH v2 ] staging: ft1000: fix else style error

2015-01-17 Thread Greg KH
On Tue, Jan 13, 2015 at 10:34:00PM +0100, Bilel DRIRA wrote: > This patch fix the checkpatch.pl error: > > ERROR: else should follow close brace '}' > > Signed-off-by: Bilel DRIRA > --- > v2: remove braces instead of just putting else after close brace. (suggested > by Joe Perches). > >

Re: [PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2015-01-17 Thread Greg KH
On Sat, Dec 06, 2014 at 04:03:22PM -0800, Tristan Lelong wrote: > This patch fix a sparse warning in lustre sources > > warning: incorrect type in argument 1 (different address spaces) > expected void [noderef] *to > got char * > > This is done by adding the missing __user attribute on us

Re: [PATCH] staging: ft1000: Fix code style issue

2015-01-17 Thread Greg KH
On Wed, Jan 07, 2015 at 12:57:05PM +0530, Arjun AK wrote: > Remove unnecessary braces from single statement blocks. > > Signed-off-by: Arjun AK > --- > drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 101 > --- > 1 file changed, 35 insertions(+), 66 deletions(-) Doesn't

[PATCH 1/1] fujitsu-laptop: use FB_BLANK_* constants

2015-01-17 Thread Michael Karcher
From: Michael Karcher --- drivers/platform/x86/fujitsu-laptop.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index 7c21c1c..2a9afa2 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++

[PATCH 1/1] scripts/recordmcount.pl: There is no -m32 option on Super-H

2015-01-17 Thread Michael Karcher
Signed-Off-By: Michael Karcher --- scripts/recordmcount.pl | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl index 56ea99a..537c38c 100755 --- a/scripts/recordmcount.pl +++ b/scripts/recordmcount.pl @@ -255,7 +255,6 @@ if ($arch eq "x86_64") {

Re: [PATCH v2] staging: skein: Remove all do{} while (0) loop from single statement.

2015-01-17 Thread Greg KH
On Sun, Jan 11, 2015 at 03:41:05PM -0800, Shirish Gajera wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Single statement macros should not use a do {} while (0) loop > > I remove do while from the single statement macro. > > Signed-off-by: Shirish Gajera > --- > drivers/stag

Re: [PATCH] staging: skein: Fix checkpatch warnings

2015-01-17 Thread Greg KH
On Sat, Jan 10, 2015 at 04:00:47PM +0100, Arno Tiemersma wrote: > Remove do {} while (0) loops around single statements in > skein/skein_block.c > > Signed-off-by: Arno Tiemersma > --- > drivers/staging/skein/skein_block.c | 16 > 1 file changed, 4 insertions(+), 12 deletions(-)

Re: [PATCH 3/6] dgnc/dpacompat.h: checkpatch: fixed long lines bei moving comments

2015-01-17 Thread Greg KH
On Mon, Dec 22, 2014 at 02:17:31AM +0100, Simone Weiss wrote: > > Signed-off-by: Simone Weiss > Signed-off-by: Helene Gsaenger > --- > drivers/staging/dgnc/dpacompat.h | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/dgnc/dpacompat.h > b/drivers/s

[GIT PULL] clk: fixes for 3.19

2015-01-17 Thread Mike Turquette
The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672: Linux 3.19-rc1 (2014-12-20 17:08:50 -0800) are available in the git repository at: https://git.linaro.org/people/mike.turquette/linux.git tags/clk-fixes-for-linus for you to fetch changes up to c7662fc59ca38517e0e

Re: [PATCH] staging: gdm724x: fix space coding style issue in gdm_mux.c

2015-01-17 Thread Greg KH
On Sun, Jan 04, 2015 at 09:23:44AM +0100, Ning Zhou wrote: > This is a patch to fix a space error found by the checkpatch.pl in > file gdm_mux.c. > > Signed-off-by: Ning Zhou > --- > drivers/staging/gdm724x/gdm_mux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drive

[PATCH v2] soc: intel: sst-haswell-ipc: Remove unused functions

2015-01-17 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: sst_hsw_stream_unmute() sst_hsw_stream_mute() msg_set_stage_type() sst_hsw_dx_get_state() sst_hsw_stream_set_write_position() sst_hsw_stream_get_vol_reg() sst_hsw_stream_get_peak_reg() sst_hsw_stream_get_pointer_reg() sst_hsw_stream_get_read_reg()

Re: [PATCH] staging: octeon: Fix checkpatch line spacing warnings

2015-01-17 Thread Greg Kroah-Hartman
On Mon, Jan 12, 2015 at 06:27:38PM +0200, Tero Marttila wrote: > Fix missing blank lines after declarations in octeon/ethernet-rx.c > > Signed-off-by: Tero Marttila > --- > drivers/staging/octeon/ethernet-rx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/octeon/eth

Re: [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c

2015-01-17 Thread Greg KH
On Sun, Dec 21, 2014 at 11:44:43AM +0100, Robert Nachlinger wrote: > This is a patch to the gdm_mux.c file that fixes a space before comma > coding style issue found by the checkpatch.pl tool. > > Signed-off-by: Robert Nachlinger > --- > drivers/staging/gdm724x/gdm_mux.c | 2 +- > 1 file changed

Re: [PATCH] Staging : gdm724x: Remove space before , in function arguments

2015-01-17 Thread Greg KH
On Sun, Dec 21, 2014 at 08:18:19AM +0530, Mohammad Jamal wrote: > This patch solves space prohibited before , warning in gdm_mux.c > > Signed-off-by: Mohammad Jamal > --- > drivers/staging/gdm724x/gdm_mux.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/stag

Re: [PATCH v3] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-17 Thread Greg KH
On Wed, Jan 14, 2015 at 04:12:58AM +1100, Emrys Bayliss wrote: > This patch fixes the following checkpatch.pl error: > rxtx.c:558: WARNING: else is not generally useful after a break or return > > Signed-off-by: Emrys Bayliss > --- > The else statement was replaced with a block to avoid the follo

[RFC PATCH RESEND] vfs: Move security_inode_killpriv() after permission checks

2015-01-17 Thread Ben Hutchings
chown() and write() should clear all privilege attributes on a file - setuid, setgid, setcap and any other extended privilege attributes. However, any attributes beyond setuid and setgid are managed by the LSM and not directly by the filesystem, so they cannot be set along with the other attribute

Re: [PATCH v7] Staging: comedi: patch to fix line over 80 characters warning

2015-01-17 Thread Greg KH
On Sat, Jan 10, 2015 at 10:20:03AM +0530, jitendra kumar khasdev wrote: > This is patch to pcl812.c that fix line over 80 characters warning > which is found by checkpatch.pl tool. Reduce the extra space around > equal sign that fix warning. > > Signed-off-by: Jitendra kumar khasdev > --- > driv

[PATCH 2/2] IPVS: add wlib & wlip schedulers

2015-01-17 Thread Chris Caputo
From: Chris Caputo IPVS wlib (Weighted Least Incoming Byterate) and wlip (Weighted Least Incoming Packetrate) scheduler docs for ipvsadm-1.27. Signed-off-by: Chris Caputo --- diff -upr ipvsadm-1.27-stock/SCHEDULERS ipvsadm-1.27/SCHEDULERS --- ipvsadm-1.27-stock/SCHEDULERS 2013-09-06 08:

[PATCH 1/2] IPVS: add wlib & wlip schedulers

2015-01-17 Thread Chris Caputo
Wensong, this is something we discussed 10 years ago and you liked it, but it didn't actually get into the kernel. I've updated it, tested it, and would like to work toward inclusion. Thanks, Chris --- From: Chris Caputo IPVS wlib (Weighted Least Incoming Byterate) and wlip (Weighted Least

Re: SMBIOS/DMI data under CONFIG_STRICT_DEVMEM

2015-01-17 Thread Leif Lindholm
On Sat, Jan 17, 2015 at 03:12:13PM -0500, Jon Masters wrote: > Hi Catalin, all, > > I would like to ensure that the SMBIOS data provided by firmware is > always readable from userspace on AArch64, through /dev/mem. No, we need to ensure /dev/mem can be completely disabled on any system that ever

Re: SMBIOS/DMI data under CONFIG_STRICT_DEVMEM

2015-01-17 Thread Jon Masters
On 01/17/2015 05:52 PM, Jon Masters wrote: > Hi Olof, > > On 01/17/2015 04:10 PM, Olof Johansson wrote: >> Hi, >> >> On Sat, Jan 17, 2015 at 12:12 PM, Jon Masters wrote: >>> Hi Catalin, all, >>> >>> I would like to ensure that the SMBIOS data provided by firmware is >>> always readable from users

Re: SMBIOS/DMI data under CONFIG_STRICT_DEVMEM

2015-01-17 Thread Jon Masters
Hi Olof, On 01/17/2015 04:10 PM, Olof Johansson wrote: > Hi, > > On Sat, Jan 17, 2015 at 12:12 PM, Jon Masters wrote: >> Hi Catalin, all, >> >> I would like to ensure that the SMBIOS data provided by firmware is >> always readable from userspace on AArch64, through /dev/mem. > > Seems like this

[PATCH] scsi_debug: use atomic allocation in resp_rsup_opcodes

2015-01-17 Thread Sasha Levin
resp_rsup_opcodes() may get called from atomic context and would need to use GFP_ATOMIC for allocations: [ 1237.913419] BUG: sleeping function called from invalid context at mm/slub.c:1262 [ 1237.914865] in_atomic(): 1, irqs_disabled(): 0, pid: 7556, name: trinity-c311 [ 1237.916142] 3 locks held

Re: [PATCH v18 00/12] input: cyapa: instruction of cyapa patches

2015-01-17 Thread Jeremiah Mahler
Dave, On Sat, Jan 17, 2015 at 06:00:29PM +, David Solda wrote: > Can we just reverse the prior change that caused the bug, or are you saying > that the owner of the prior patch has to fix it? > > Dave > I tried to revert the patch but it didn't do so cleanly. git revert ea2c67bb4aff So

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Russell King - ARM Linux
On Sat, Jan 17, 2015 at 01:26:41PM -0800, Ray Jui wrote: > time_left = wait_for_completion_timeout(&iproc_i2c->done, time_left); > > /* disable all interrupts */ > writel(0, iproc_i2c->base + IE_OFFSET); > > if (!time_left && !atomic_read(&iproc_i2c->transfer_is_successful

  1   2   3   >