Re: current mainline doesn't boot

2014-10-18 Thread Mike Galbraith
On Fri, 2014-10-17 at 18:52 -0500, Steve French wrote: > This is vmware guest Take this with a grain of salt, but you might need to manually update their glue. I was given a gratis copy of the thing with a license for a year. Not being willing to pay to keep the license of a toy I have no real

Re: Upstream kernel build failures in include/net/tcp.h

2014-10-18 Thread Eric Dumazet
On Sat, 2014-10-18 at 21:37 -0700, Guenter Roeck wrote: > Hi, > > I am getting lots of build failures with the latest upstream kernel. > > In file included from net/core/sock.c:140:0: > include/net/tcp.h: In function 'tcp_v6_iif': > include/net/tcp.h:738:32: error: 'union ' has no member named 'h

Re: [PATCHv1 7/8] cgroup: cgroup namespace setns support

2014-10-18 Thread Eric W. Biederman
"Serge E. Hallyn" writes: > Quoting Aditya Kali (adityak...@google.com): >> On Thu, Oct 16, 2014 at 2:12 PM, Serge E. Hallyn wrote: >> > Quoting Aditya Kali (adityak...@google.com): >> >> setns on a cgroup namespace is allowed only if >> >> * task has CAP_SYS_ADMIN in its current user-namespace

Re: [PATCHv1 6/8] cgroup: restrict cgroup operations within task's cgroupns

2014-10-18 Thread Eric W. Biederman
Aditya Kali writes: > Restrict following operations within the calling tasks: > * cgroup_mkdir & cgroup_rmdir > * cgroup_attach_task > * writes to cgroup files outside of task's cgroupns-root > > Also, read of /proc//cgroup file is now restricted only > to tasks under same cgroupns-root. If a tas

Re: [PATCHv1 0/8] CGroup Namespaces

2014-10-18 Thread Eric W. Biederman
Aditya Kali writes: > Second take at the Cgroup Namespace patch-set. > > Major changes form RFC (V0): > 1. setns support for cgroupns > 2. 'mount -t cgroup cgroup ' from inside a cgroupns now >mounts the cgroup hierarcy with cgroupns-root as the filesystem root. > 3. writes to cgroup files ou

Upstream kernel build failures in include/net/tcp.h

2014-10-18 Thread Guenter Roeck
Hi, I am getting lots of build failures with the latest upstream kernel. In file included from net/core/sock.c:140:0: include/net/tcp.h: In function 'tcp_v6_iif': include/net/tcp.h:738:32: error: 'union ' has no member named 'h6' This may have been introduced by 870c3151382 ("ipv6: introduce tc

Re: unaligned accesses in SLAB etc.

2014-10-18 Thread David Miller
From: Meelis Roos Date: Fri, 17 Oct 2014 00:38:20 +0300 (EEST) > arch/sparc/kernel/setup_64.c is the only culprit. > > Attached are 2 versions of the object file as of v3.17-rc1-22-g480cadc > that I tested. Just to confirm, a gcc-4.9 compiled kernel works if just setup_64.c is built with gcc-4

Re: Machine crashes right *after* ~successful resume

2014-10-18 Thread Yinghai Lu
On Sat, Oct 18, 2014 at 4:57 PM, Wilmer van der Gaast wrote: > On 18-10-14 22:28, Yinghai Lu wrote: >> >> Please apply attached debug patch on top of v3.17 and boot with >> "debug ignore_loglevel initcall_debug no_console_suspend". >> >> Hope we can find out which nb notifier cause problem. >> > D

Re: [GIT] Networking

2014-10-18 Thread David Miller
From: Markus Trippelsdorf Date: Sun, 19 Oct 2014 04:15:54 +0200 > On 2014.10.18 at 00:18 -0400, David Miller wrote: >> >> Please pull, thanks a lot. > > In file included from net/core/sock.c:140:0: > include/net/tcp.h: In function ‘tcp_v6_iif’: > include/net/tcp.h:738:32: error: ‘union ’ has no

Re: [PATCH v3 0/3] mtd: nand: gpmi: add proper raw access support

2014-10-18 Thread Huang Shijie
On Tue, Oct 14, 2014 at 04:50:27PM +1100, Iwo Mergler wrote: > > > > > No, it doesn't seem to be correct. > > But it's an MLC flash, so you'll most probably need to apply this patch > > to nandbiterrs testsuite: > > > > http://code.bulix.org/f69wuu-87021 > > > > This patch is flashing the block be

Re: [PATCH] futex: Ensure get_futex_key_refs() always implies a barrier

2014-10-18 Thread Davidlohr Bueso
On Sat, 2014-10-18 at 13:50 -0700, Linus Torvalds wrote: > On Sat, Oct 18, 2014 at 12:58 PM, Davidlohr Bueso wrote: > > > > And [get/put]_futex_keys() shouldn't even be called for private futexes. > > The following patch had some very minor testing on a 60 core box last > > night, but passes both

Re: [GIT] Networking

2014-10-18 Thread Markus Trippelsdorf
On 2014.10.18 at 00:18 -0400, David Miller wrote: > > Please pull, thanks a lot. In file included from net/core/sock.c:140:0: include/net/tcp.h: In function ‘tcp_v6_iif’: include/net/tcp.h:738:32: error: ‘union ’ has no member named ‘h6’ return TCP_SKB_CB(skb)->header.h6.iif;

Re: current mainline doesn't boot

2014-10-18 Thread Steve French
Interesting to see that Fedora has similar problems with current kernel (I pulled mainline again a few hours ago). Fedora 20 x86_64 in vmware boots to logon prompt but no mouse, no keyboard, system hung. Ctl-alt-f1 doesn't do anything. Even with verbose on kernel boot line, the extra debug messa

Re: [PATCH] futex: Ensure get_futex_key_refs() always implies a barrier

2014-10-18 Thread Darren Hart
On October 18, 2014 3:19:50 PM CDT, Davidlohr Bueso wrote: >On Sat, 2014-10-18 at 14:32 -0500, Darren Hart wrote: >> Which is not incomplete (lacking the explicit smp_mb()) added by this >> patch. Perhaps the MB implementation of get_futex_key_refs() need not >be >> explicitly enumerated here? >

[PATCH v2 4/5] Numachip: APIC driver cleanups

2014-10-18 Thread Daniel J Blueman
Drop printing that serves no purpose, as it's printing fixed or known values, and mark constant structure appropriately. Signed-off-by: Daniel J Blueman --- arch/x86/kernel/apic/apic_numachip.c | 22 +++--- arch/x86/pci/numachip.c | 2 +- 2 files changed, 4 insertio

[PATCH v2 2/5] Numachip: APIC fixes

2014-10-18 Thread Daniel J Blueman
Fix 16-bit APIC ID truncation and redundant APIC ICR idle polling for IPI to self (AMD64 APICs are documented in the system developer manuals to queue APIC writes). Signed-off-by: Daniel J Blueman --- arch/x86/kernel/apic/apic_numachip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 1/5] Numachip: Fix build failure with trunk GCC

2014-10-18 Thread Daniel J Blueman
Fix APIC declaration to be consistent with definition; this addresses a compilation failure with the development branch of GCC, see: https://bugzilla.kernel.org/show_bug.cgi?id=78251 Signed-off-by: Daniel J Blueman --- arch/x86/kernel/apic/apic_numachip.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v2 3/5] Numachip: Add safe is-present function

2014-10-18 Thread Daniel J Blueman
Add safe function to check if Numachip is detected, to be used elsewhere. Signed-off-by: Daniel J Blueman --- arch/x86/include/asm/numachip/numachip.h | 9 + arch/x86/kernel/apic/apic_numachip.c | 9 +++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/arch/x86/i

[PATCH v2 5/5] Numachip: use 2GB memory block size

2014-10-18 Thread Daniel J Blueman
Use appropriate memory block size to reduce sysfs entry creation time by 16x. Boot-tested with the four permutations of X86_UV and X86_NUMACHIP. Signed-off-by: Daniel J Blueman --- arch/x86/mm/init_64.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/x86/mm/init_

Re: [PATCH 1/5] lib: string.c: Added a function strzcpy

2014-10-18 Thread Joe Perches
On Sun, 2014-10-19 at 00:03 +0200, Rickard Strandqvist wrote: > Added a function strzcpy which works the same as strncpy, > but guaranteed to produce the trailing null character. > > There are many places in the code where strncpy used although it > must be zero terminated, and switching to strlcp

Re: [PATCH] kernel/sysctl: Resolve missing-field-initializers warnings

2014-10-18 Thread Eric W. Biederman
Jeff Kirsher writes: > From: Mark Rustad > > Resolve missing-field-initializers warnings in W=2 builds by > using designated initialization. ick. No. That gcc warning makes no sense. In this case heeding it makes the code significantly uglier and significantly more confusing. Eric > Signe

[PATCH 3/3] lguest: force file->private_data to be NULL on open()

2014-10-18 Thread Martin Kepplinger
if we depend on private_data being NULL in write() before initialize() make sure it is NULL after open(). Signed-off-by: Martin Kepplinger --- I'm not completely sure if this patch is needed and am still investigating. What do you think? open() could be called by the user I guess. Does lguest_us

[PATCH 1/3] misc: always assign miscdevice to file->private_data in open()

2014-10-18 Thread Martin Kepplinger
As of now, a miscdevice driver has to provide an implementation of the open() file operation if it wants to have misc_open() assign a pointer to struct miscdevice to file->private_data for other file operations to use (given the user calls open()). This leads to situations where a miscdevice drive

[PATCH 2/3] fbdev: pxa3xx-gcu: remove redundant implementation of open()

2014-10-18 Thread Martin Kepplinger
the miscdevice core now does the work in any case. Signed-off-by: Martin Kepplinger --- drivers/video/fbdev/pxa3xx-gcu.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c index 4df3657..7678a94 100644 --- a/driver

Re: [PATCHv4 RESEND 0/3] syscalls,x86: Add execveat() system call

2014-10-18 Thread Eric W. Biederman
Andy Lutomirski writes: > [Added Eric Biederman, since I think your tree might be a reasonable > route forward for these patches.] > > On Thu, Jun 5, 2014 at 6:40 AM, David Drysdale wrote: >> Resending, adding cc:linux-api. >> >> Also, it may help to add a little more background -- this patch is

lguest: lguest_user.c is open() called by the user?

2014-10-18 Thread Martin Kepplinger
hi Just a question for understanding: open() is not implemented in lguest_user.c's miscdevice. The miscdevice core, in this case, does _not_ set file->private_data on a user's open() call. Is open() called by the user here? and do you here _depend_ on file->private_data being NULL after open()? (c

Re: Machine crashes right *after* ~successful resume

2014-10-18 Thread Wilmer van der Gaast
(Resending, forgot to hit reply-to-all.) Hello Yinghai, On 18-10-14 22:28, Yinghai Lu wrote: > > Please apply attached debug patch on top of v3.17 and boot with > "debug ignore_loglevel initcall_debug no_console_suspend". > > Hope we can find out which nb notifier cause problem. > Did that. Stra

Re: [PATCH] misc: always assign miscdevice to file->private_data in open()

2014-10-18 Thread Martin Kepplinger
Am 2014-10-09 17:50, schrieb Greg KH: > On Thu, Oct 09, 2014 at 03:10:21PM +0200, Martin Kepplinger wrote: >> Am 2014-10-08 15:43, schrieb Greg KH: >>> On Wed, Oct 08, 2014 at 10:47:54AM +0200, Martin Kepplinger wrote: As of now, a miscdevice driver has to provide an implementation of the

Re: [PATCH] sched/numa: fix unsafe get_task_struct() in task_numa_assign()

2014-10-18 Thread Kirill Tkhai
19.10.2014, 00:59, "Oleg Nesterov" : >  On 10/18, Kirill Tkhai wrote: >>   18.10.2014, 01:40, "Oleg Nesterov" : >>>   ... >>>   The >>>   task_struct itself can't go away, >>>   ... >>>   --- a/kernel/sched/fair.c >>>   +++ b/kernel/sched/fair.c >>>   @@ -1158,7 +1158,13 @@ static void task_numa_co

Re: [PATCH 3/7] wait.[ch]: Introduce the simple waitqueue (swait) implementation

2014-10-18 Thread Steven Rostedt
On Sat, 2014-10-18 at 23:34 +0200, Peter Zijlstra wrote: > Same comment as before, that is an unbounded loop in a non preemptible > section and therefore violates RT design principles. > > We actually did talk about ways of fixing that. Right, and we should slap Paul for not showing up for it ;-

Re: [PATCH v5 1/6] ARM: rockchip: convert to regmap and use pmu syscon if available

2014-10-18 Thread Heiko Stübner
Am Freitag, 17. Oktober 2014, 21:30:52 schrieb Sonny Rao: > On Wed, Oct 15, 2014 at 10:23 AM, Kever Yang wrote: > > From: Heiko Stuebner > > > > The pmu register space is - like the GRF - shared by quite some > > peripherals. On the rk3188 and rk3288 even parts of the pinctrl are > > living the

[PATCH] ASoC: s6000: remove driver

2014-10-18 Thread Daniel Glöckner
The s6000 Xtensa support is removed from the kernel. There are no other chips known to use this I2S controller. Signed-off-by: Daniel Glöckner --- sound/soc/Kconfig | 1 - sound/soc/Makefile| 1 - sound/soc/s6000/Kconfig | 26 -- sound/soc/s6000/Makefile |

[PATCH] net: s6gmac: remove driver

2014-10-18 Thread Daniel Glöckner
The s6000 Xtensa support is removed from the kernel. There are no other chips using this driver. While the Mentor/Alcatel PE-MCXMAC IP core is also used in other designs (Freescale Gianfar/UCC, QLogic NetXen, Solarflare, Agere ET-1310, Netlogic XLR/XLS), none of these use this driver as it heavily

[PATCH] xtensa: remove s6000 variant and s6105 platform

2014-10-18 Thread Daniel Glöckner
The Stretch s6000 family support has been merged into mainline 5 years ago. There appear to be no users of this code since nobody complained that there is a merge error preventing compilation. Apart from the s6105 IP camera reference design there are no s6000 devices known to ever have run Linux a

Re: [PATCH net] r8152: use cancel_delayed_work for runtime suspend

2014-10-18 Thread Oliver Neukum
On Fri, 2014-10-17 at 13:55 +0800, Hayes Wang wrote: > It would cause dead lock for runtime suspend, when the workqueue > is running and runtime suspend occurs before the workqueue wakes > up the device. The rtl8152_suspend() waits the workqueue to finish > because of calling cancel_delayed_work_sy

[PATCH 1/1] snd-usb-audio: Add support for Steinberg UR22 USB interface

2014-10-18 Thread Vlad Catoi
Adding support for Steinberg UR22 USB interface via quirks table patch See Ubuntu bug report: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1317244 Also see threads: http://linux-audio.4202.n7.nabble.com/Support-for-Steinberg-UR22-Yamaha-USB-chipset-0499-1509-tc82888.html#a82917 http://www.

Re: [PATCH 0/5] fuse: handle release synchronously (v4)

2014-10-18 Thread Eric W. Biederman
Al Viro writes: > On Sat, Oct 18, 2014 at 08:40:05AM -0700, Linus Torvalds wrote: >> On Sat, Oct 18, 2014 at 8:35 AM, Linus Torvalds >> wrote: >> > >> > Look around for AIO. Look around for the loop driver. Look around for >> > a number of things that do "fget()" and that you completely ignored.

[PATCH 5/5] mmc: host: vub300.c: Cleaning up missing null-terminate by switching from strncpy to strzcpy

2014-10-18 Thread Rickard Strandqvist
Ensures that the string is null-terminate in connection with the use of strncpy, by switching from strncpy to strzcpy. Signed-off-by: Rickard Strandqvist --- drivers/mmc/host/vub300.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/mmc/hos

Re: [PATCH 1/4] (CMA_AGGRESSIVE) Add CMA_AGGRESSIVE to Kconfig

2014-10-18 Thread Pavel Machek
Hi! > Add CMA_AGGRESSIVE config that depend on CMA to Linux kernel config. > Add CMA_AGGRESSIVE_PHY_MAX, CMA_AGGRESSIVE_FREE_MIN and CMA_AGGRESSIVE_SHRINK > that depend on CMA_AGGRESSIVE. > > If physical memory size (not include CMA memory) in byte less than or equal to > CMA_AGGRESSIVE_PHY_MAX,

[PATCH 4/5] power: charger-manager.c: Cleaning up missing null-terminate by switching from strncpy to strzcpy

2014-10-18 Thread Rickard Strandqvist
Ensures that the string is null-terminate in connection with the use of strncpy, by switching from strncpy to strzcpy. Signed-off-by: Rickard Strandqvist --- drivers/power/charger-manager.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/charger-manager.c

[PATCH 3/5] video: fbdev: uvesafb.c: Cleaning up missing null-terminate by switching from strncpy to strzcpy

2014-10-18 Thread Rickard Strandqvist
Ensures that the string is null-terminate in connection with the use of strncpy, by switching from strncpy to strzcpy. Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/uvesafb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/uvesafb.c b/drive

Re: [PATCH] PM / Runtime: Rework RPM get callback routines

2014-10-18 Thread Pavel Machek
On Fri 2014-10-17 12:58:02, Andrzej Hajda wrote: > PM uses three separate functions to fetch RPM callbacks. > These functions uses quite complicated macro in their body. > The patch replaces these routines with one small macro and > one helper function. > > Signed-off-by: Andrzej Hajda Looks goo

[PATCH 2/5] scsi: bfa: bfa_fcs_lport.c: Cleaning up missing null-terminate by switching from strncpy to strzcpy

2014-10-18 Thread Rickard Strandqvist
Ensures that the string is null-terminate in connection with the use of strncpy, by switching from strncpy to strzcpy. Signed-off-by: Rickard Strandqvist --- drivers/scsi/bfa/bfa_fcs_lport.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b

Re: [PATCH v2 5/5] tty/serial: Add earlycon support for Spreadtrum serial driver

2014-10-18 Thread One Thousand Gnomes
On Fri, 17 Oct 2014 17:54:25 +0800 Chunyan Zhang wrote: > Add serial driver for spreadtrum sharkl platform with earlycon > support at first. > +#define UART_TXD 0x > +#define UART_RXD 0x0004 > +#define UART_STS00x0008 > +#define UART_STS10x000C > +#define UART_IEN 0x0010

[PATCH 1/5] lib: string.c: Added a function strzcpy

2014-10-18 Thread Rickard Strandqvist
Added a function strzcpy which works the same as strncpy, but guaranteed to produce the trailing null character. There are many places in the code where strncpy used although it must be zero terminated, and switching to strlcpy is not an option because the string must nonetheless be fyld with zero

Re: current mainline doesn't boot

2014-10-18 Thread Steve French
Same thing happened after pulling newly updated mainline kernel changes a few minutes ago. Black screen on boot just when you would expect x to be starting. Hung. Ctl-alt-F1 doesn't do anything. arch is x86_64. 3.17.1 works. When I get time I will see if I can figure out more useful info but th

[PATCH] FS: aio: Fixed some coding style issues.

2014-10-18 Thread Joseph Wessner
Fixed some coding style issues in aio.c Signed-off-by: Joseph Wessner --- fs/aio.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index 84a7510..eab03a6 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -171,6 +171,7 @@ static struct file *a

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-18 Thread One Thousand Gnomes
> Do we really need someone to do more work that has been done on it in > the past as an official "maintainer"? I'll be glad to do it, as I doubt > it will require any time at all. Well every time in the past that Al Viro looked in its direction he broke it so probably. Someone is going to have t

Re: [PATCH 3/7] wait.[ch]: Introduce the simple waitqueue (swait) implementation

2014-10-18 Thread Peter Zijlstra
On Fri, Oct 17, 2014 at 08:22:58PM -0400, Paul Gortmaker wrote: > @@ -75,6 +123,32 @@ static void __cwake_up_common(struct cwait_head *q, > unsigned int mode, > } > } > > +static void __swake_up_common(struct swait_head *q, unsigned int mode, > + int nr_exclusive

Re: Machine crashes right *after* ~successful resume

2014-10-18 Thread Yinghai Lu
On Thu, Oct 16, 2014 at 2:08 PM, Wilmer van der Gaast wrote: > Did that on this run, no difference either. For full completeness, I > reproduced this problem with no modules loaded (done from initramfs) at all, > with a kernel with your workaround included, logs are here: > http://gaast.net/~wilme

[PATCH] Arch: ia64: kernel: acpi: fixed a brace coding style issue.

2014-10-18 Thread Joseph Wessner
Fixed a coding style issue. Signed-off-by: Joseph Wessner --- arch/ia64/kernel/acpi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c index 615ef81..12c032e 100644 --- a/arch/ia64/kernel/acpi.c +++ b/arch/ia64/kernel/acpi.c

Re: [PATCH] sched/numa: fix unsafe get_task_struct() in task_numa_assign()

2014-10-18 Thread Oleg Nesterov
On 10/18, Peter Zijlstra wrote: > > So you worry about the refcount doing 0->1 ? In which case the above is > still wrong and we should be using atomic_inc_not_zero() in order to > acquire the reference count. It is actually worse, please see my reply to Kirill. We simply can't dereference foreign

Re: [PATCH v11 19/21] dax: Add dax_zero_page_range

2014-10-18 Thread Mathieu Desnoyers
- Original Message - > From: "Matthew Wilcox" > To: "Mathieu Desnoyers" > Cc: "Matthew Wilcox" , "Matthew Wilcox" > , > linux-fsde...@vger.kernel.org, linux...@kvack.org, > linux-kernel@vger.kernel.org, "Ross Zwisler" > > Sent: Saturday, October 18, 2014 7:41:00 PM > Subject: Re: [PATC

Re: [PATCH v2] mmc: dw_mmc: Reset DMA before enabling IDMAC

2014-10-18 Thread Sonny Rao
On Fri, Oct 17, 2014 at 1:26 AM, Jaehoon Chung wrote: > Hi, Sonny. > > On 10/17/2014 01:58 AM, Sonny Rao wrote: >> We've already got a reset of DMA after it's done. Add one before we >> start DMA too. This fixes a data corruption on Rockchip SoCs which >> will get bad data when doing a DMA trans

Re: [PATCH] sched/numa: fix unsafe get_task_struct() in task_numa_assign()

2014-10-18 Thread Oleg Nesterov
On 10/18, Kirill Tkhai wrote: > > 18.10.2014, 01:40, "Oleg Nesterov" : > > ... > > The > > task_struct itself can't go away, > > ... > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -1158,7 +1158,13 @@ static void task_numa_compare(struct task_numa_env > > *env, > > > >  

[PATCH RFC] platform: hp_accel: add a i8042 filter to remove accelerometer data

2014-10-18 Thread Giedrius Statkevicius
Hello, this patch fixes bug #84941 from the kernel bugzilla. Basically, it seems that the accelerometer sends some signals as button presses through the keyboard bus. The keys in the report are 0xa5-0xa8 but in the filter function they are reported as 0x25-0x28. This patch adds a i8042 filter that

Re: [PATCH] futex: Ensure get_futex_key_refs() always implies a barrier

2014-10-18 Thread Linus Torvalds
On Sat, Oct 18, 2014 at 12:58 PM, Davidlohr Bueso wrote: > > And [get/put]_futex_keys() shouldn't even be called for private futexes. > The following patch had some very minor testing on a 60 core box last > night, but passes both Darren's and perf's tests. So I *think* this is > right, but lack o

Re: [PATCH v11 04/21] mm: Allow page fault handlers to perform the COW

2014-10-18 Thread Matthew Wilcox
On Fri, Oct 17, 2014 at 03:35:01PM +, Mathieu Desnoyers wrote: > > > The page fault handler being very much performance sensitive, I'm > > > wondering if it would not be better to move cow_page near the end of > > > struct vm_fault, so that the "page" field can stay on the first > > > cache lin

Re: [PATCH v11 19/21] dax: Add dax_zero_page_range

2014-10-18 Thread Matthew Wilcox
On Fri, Oct 17, 2014 at 03:49:39PM +, Mathieu Desnoyers wrote: > > I kind of wonder if we shouldn't just declare the function. It's called > > like this: > > > > if (IS_DAX(inode)) > > return dax_zero_page_range(inode, from, length, > > ext4_get_block);

Re: [PATCH] futex: Ensure get_futex_key_refs() always implies a barrier

2014-10-18 Thread Davidlohr Bueso
On Sat, 2014-10-18 at 14:32 -0500, Darren Hart wrote: > Which is not incomplete (lacking the explicit smp_mb()) added by this > patch. Perhaps the MB implementation of get_futex_key_refs() need not be > explicitly enumerated here? Agreed, how about this: diff --git a/kernel/futex.c b/kernel/futex

Re: [PATCH] futex: Ensure get_futex_key_refs() always implies a barrier

2014-10-18 Thread Davidlohr Bueso
On Sat, 2014-10-18 at 00:33 -0700, Davidlohr Bueso wrote: > On Fri, 2014-10-17 at 17:38 +0100, Catalin Marinas wrote: > > Commit b0c29f79ecea (futexes: Avoid taking the hb->lock if there's > > nothing to wake up) changes the futex code to avoid taking a lock when > > there are no waiters. This code

Re: [PATCH] sched/numa: fix unsafe get_task_struct() in task_numa_assign()

2014-10-18 Thread Peter Zijlstra
On Sat, Oct 18, 2014 at 12:33:27PM +0400, Kirill Tkhai wrote: > How about this? > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index b78280c..d46427e 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1165,7 +1165,21 @@ static void task_numa_compare(struct task_numa

Re: [PATCH v2] mtd: orion_nand: fix error code path in probe

2014-10-18 Thread Andrew Lunn
On Thu, Oct 16, 2014 at 06:58:35AM +0200, Michael Opdenacker wrote: > This replaces kzalloc() and ioremap() calls by devm_ functions > in the probe() routine, which automatically release the corresponding > resources when probe() fails or when the device is removed. > > This simplifies simplifies

Re: [PATCH] futex: Ensure get_futex_key_refs() always implies a barrier

2014-10-18 Thread Darren Hart
On 10/17/14 11:38, Catalin Marinas wrote: > Commit b0c29f79ecea (futexes: Avoid taking the hb->lock if there's > nothing to wake up) changes the futex code to avoid taking a lock when > there are no waiters. This code has been subsequently fixed in commit > 11d4616bd07f (futex: revert back to the e

Re: [alsa-devel] [PATCH v2 5/6] sound/usb: pcm changes to use media token api

2014-10-18 Thread Mauro Carvalho Chehab
Em Thu, 16 Oct 2014 08:59:29 -0600 Shuah Khan escreveu: > On 10/16/2014 08:48 AM, Takashi Iwai wrote: > > At Thu, 16 Oct 2014 08:39:14 -0600, > > Shuah Khan wrote: > >> > >> On 10/16/2014 08:16 AM, Takashi Iwai wrote: > >>> At Thu, 16 Oct 2014 08:10:52 -0600, > >>> Shuah Khan wrote: > >

Re: [PATCH 0/5] fuse: handle release synchronously (v4)

2014-10-18 Thread Al Viro
On Sat, Oct 18, 2014 at 07:24:54PM +0100, Al Viro wrote: > On Sat, Oct 18, 2014 at 08:01:13PM +0200, Miklos Szeredi wrote: > > > And what you don't get is that there's a deep difference between those > > and the /proc file access case. > > > > And the difference is that one is done because of an

Re: [PATCH 0/5] fuse: handle release synchronously (v4)

2014-10-18 Thread Linus Torvalds
On Sat, Oct 18, 2014 at 11:01 AM, Miklos Szeredi wrote: > > And what you don't get is that there's a deep difference between those > and the /proc file access case. No there isn't. Your "action by the holder" argument is pure and utter garbage, for a very simple and core reason: the *filesystem*

Re: [PATCH 0/5] fuse: handle release synchronously (v4)

2014-10-18 Thread Al Viro
On Sat, Oct 18, 2014 at 08:01:13PM +0200, Miklos Szeredi wrote: > And what you don't get is that there's a deep difference between those > and the /proc file access case. > > And the difference is that one is done because of an explicit action > by the holder of the open file. And the other is d

Re: unaligned accesses in SLAB etc.

2014-10-18 Thread David Miller
From: David Miller Date: Sat, 18 Oct 2014 13:59:07 -0400 (EDT) > I don't want to define the array size of the fpregs save area > explicitly and thereby placing an artificial limit there. Nevermind, it seems we have a hard limit of 7 FPU save areas anyways. Meelis, please try this patch: diff -

Re: [PATCH 0/5] fuse: handle release synchronously (v4)

2014-10-18 Thread Al Viro
On Sat, Oct 18, 2014 at 08:40:05AM -0700, Linus Torvalds wrote: > On Sat, Oct 18, 2014 at 8:35 AM, Linus Torvalds > wrote: > > > > Look around for AIO. Look around for the loop driver. Look around for > > a number of things that do "fget()" and that you completely ignored. > > .. actually, there

Re: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-18 Thread Mauro Carvalho Chehab
Em Sat, 18 Oct 2014 13:10:01 +0300 Tomas Melin escreveu: > On Thu, Oct 16, 2014 at 11:49 PM, David Härdeman wrote: > > I think this is already addressed in this thread: > > http://www.spinics.net/lists/linux-media/msg79865.html > The patch in that thread would have broken things since the > stor

Re: [PATCH 0/5] fuse: handle release synchronously (v4)

2014-10-18 Thread Miklos Szeredi
On Sat, Oct 18, 2014 at 5:40 PM, Linus Torvalds wrote: > On Sat, Oct 18, 2014 at 8:35 AM, Linus Torvalds > wrote: >> >> Look around for AIO. Look around for the loop driver. Look around for >> a number of things that do "fget()" and that you completely ignored. > > .. actually, there are more ins

Re: unaligned accesses in SLAB etc.

2014-10-18 Thread David Miller
From: Meelis Roos Date: Fri, 17 Oct 2014 14:12:09 +0300 (EEST) > However, on top of mainline HEAD 3.17.0-09670-g0429fbc it explodes with > scheduler BUG - just reported to LKML + sched maintainers. task_stack_end_corrupted() cannot work properly on sparc64. It stores the magic value at "task_t

Re: [PATCH] iio: inkern: Add of_xlate function to struct iio_dev

2014-10-18 Thread Srinivas Pandruvada
On Sat, 2014-10-18 at 12:42 +0100, Jonathan Cameron wrote: > On 02/10/14 13:32, Ivan T. Ivanov wrote: > > When #iio-cells is greater than '0', the driver could provide > > a custom of_xlate function that reads the *args* and returns > > the appropriate index in registered IIO channels array. > > >

Re: [PATCH 1/2] staging: lustre: lnet: lnet: do not initialise 0

2014-10-18 Thread Sergei Shtylyov
Hello. On 10/18/2014 8:03 AM, Balavasu wrote: This patch fixes the checkpatch.pl issue Error:do not initialise statics to 0 or NULL Signed-off-by: Balavasu --- drivers/staging/lustre/lnet/lnet/router.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drive

Re: [PATCH] net: can: esd_usb2: fix memory leak on disconnect

2014-10-18 Thread Marc Kleine-Budde
On Sat, Oct 11, 2014 at 12:31:07AM +0400, Alexey Khoroshilov wrote: > It seems struct esd_usb2 dev is not deallocated on disconnect. > > The patch adds the deallocation. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Applied to the can

[GIT PULL] NTB bug fixes for v3.18

2014-10-18 Thread Jon Mason
Hi Linus, Below are a few NTB changes for v3.18. Please consider pulling them. Thanks, Jon The following changes since commit bfe01a5ba2490f299e1d2d5508cbbbadd897bbe9: Linux 3.17 (2014-10-05 12:23:04 -0700) are available in the git repository at: git://github.com/jonmason/ntb tags/ntb-3.1

Re: [PATCH] net: m_can: add CONFIG_HAS_IOMEM dependence

2014-10-18 Thread Marc Kleine-Budde
On Wed, Oct 15, 2014 at 02:41:50PM -0700, David Cohen wrote: > m_can uses io memory which makes it not compilable on architectures > without HAS_IOMEM such as UML: > > drivers/built-in.o: In function `m_can_plat_probe': > m_can.c:(.text+0x218cc5): undefined reference to `devm_ioremap_resource' > m

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-18 Thread Dave Hansen
On 10/18/2014 07:49 AM, Dominik Dingel wrote: > On Fri, 17 Oct 2014 15:04:21 -0700 > Dave Hansen wrote: >> Is there ever a time where the VMAs under an mm have mixed VM_NOZEROPAGE >> status? Reading the patches, it _looks_ like it might be an all or >> nothing thing. > > Currently it is an all o

Re: [PATCH] futex: Ensure get_futex_key_refs() always implies a barrier

2014-10-18 Thread Mike Galbraith
On Sat, 2014-10-18 at 08:28 -0700, Linus Torvalds wrote: > On Fri, Oct 17, 2014 at 11:54 PM, Mike Galbraith > wrote: > > > > The barrier fixing up my problematic box smells a lot like evidence. > > Is this a "tested-by"? Did you actuallyu verify that the patch ends up > fixing the problem you sa

RE: Discussion on Linus Trovalds claim of userspace cluelessness, spiralling into other analysis and choice of women. Also systemd.

2014-10-18 Thread Gregory Smith
--- The truth stands alone. Some can't handle it and need it hidden. As I said. Software people, western men in general, are weak and proud to be so. (Except when it comes to bom

Discussion on Linus Trovalds claim of userspace cluelessness, spiralling into other analysis and choice of women. Also systemd.

2014-10-18 Thread Gregory Smith
There was a discussion recently about Mr Trovalds claiming he didn't know anything about user-space at debconf '14, a stunning claim. Now since the discussion is likely to be deleted or edited at the source, well here it is: I guess people really can't handle the obvious truth being stated. -

Re: new GPG key

2014-10-18 Thread Heinz Diehl
On 18.10.2014, Paolo Bonzini wrote: > 5) Get a smartcard or a Yubikey NEO and put the subkeys on it; replace > subkeys with stubs on your usual working machines, especially laptops. It > gives you two factor authentication for free, and can also be used for > SSH if you add a third subkey. AFAIC

Re: [PATCH] um: Remove unused bp stack-frame pointer

2014-10-18 Thread Richard Weinberger
Am 18.10.2014 um 17:24 schrieb Manfred Schlaegl: > On 2014-10-18 17:19, Richard Weinberger wrote: >> Am 18.10.2014 um 17:12 schrieb Manfred Schlaegl: >>> On 2014-10-18 16:42, Richard Weinberger wrote: Am 18.10.2014 um 16:23 schrieb Manfred Schlaegl: > The pointer to bp stack-frame is no lo

Re: [PATCH 0/5] fuse: handle release synchronously (v4)

2014-10-18 Thread Linus Torvalds
On Sat, Oct 18, 2014 at 8:35 AM, Linus Torvalds wrote: > > Look around for AIO. Look around for the loop driver. Look around for > a number of things that do "fget()" and that you completely ignored. .. actually, there are more instances of "get_file()" than of "fget()", the aio one just happened

Re: [PATCH 0/5] fuse: handle release synchronously (v4)

2014-10-18 Thread Linus Torvalds
On Fri, Oct 17, 2014 at 1:55 AM, Miklos Szeredi wrote: > > The problem with those "count elevated by other things" is that they are > actually bugs. No they aren't. You think they are, and then you find one case, and ignore all the others. Look around for AIO. Look around for the loop driver. Lo

Re: [PATCH] futex: Ensure get_futex_key_refs() always implies a barrier

2014-10-18 Thread Linus Torvalds
On Fri, Oct 17, 2014 at 11:54 PM, Mike Galbraith wrote: > > The barrier fixing up my problematic box smells a lot like evidence. Is this a "tested-by"? Did you actuallyu verify that the patch ends up fixing the problem you saw? Linus -- To unsubscribe from this list: send the line "u

Re: [PATCH] um: Remove unused bp stack-frame pointer

2014-10-18 Thread Manfred Schlaegl
On 2014-10-18 17:19, Richard Weinberger wrote: > Am 18.10.2014 um 17:12 schrieb Manfred Schlaegl: >> On 2014-10-18 16:42, Richard Weinberger wrote: >>> Am 18.10.2014 um 16:23 schrieb Manfred Schlaegl: The pointer to bp stack-frame is no longer used. Removed it. >>> >>> Good catch! >> Thank you

[PATCH 4/4] cifs: add set_flag callback

2014-10-18 Thread Dmitry Monakhov
Add set_flag callback which is called from fcntl(F_SETFL) Share common logic for cifs_open and cifs_set_flags I'm not cifs expert, but it is looks like toggling O_DIRECT on file is unsafe operation so disable it temporally. Signed-off-by: Dmitry Monakhov --- fs/cifs/cifsfs.c |6 ++ fs/ci

[PATCH 0/4] fs: fcntl/fadvice fixes v2

2014-10-18 Thread Dmitry Monakhov
fcntl(F_SETFL) and fadvise performs direct manipulation with file's internals. w/o notifying to fs layer. This behavior be not be suitable for some filesystems (mostly stack-fs like ecryptfs, unionfs, etc). Let's introduce new ->set_flags() callback for that purpose. This callback is responsible fo

[PATCH 2/4] fs: add fadvise file_operation

2014-10-18 Thread Dmitry Monakhov
sys_fadvise result in direct f_mode modification, which may be not suitable for some unusual filesytems where file mode invariant is more complex. In order to support such filesystems we have to delegate fadvise logic to filesystem layer. Signed-off-by: Dmitry Monakhov --- include/linux/fs.h |

[PATCH 1/4] fs: fcntl add set_flags wrapper -v2

2014-10-18 Thread Dmitry Monakhov
fcntl(F_SETFL) performs direct f_flags manipulation which may be not be suitable for some filesytems (mostly stack-fs like ecryptfs, unionfs, etc) For example O_DIRECT toggling may require some actions (page cache flush) Let's introduce new ->set_flags() callback for that purpose. This callback is

[PATCH 3/4] ecryptfs: add fadvise/set_flags calbacks

2014-10-18 Thread Dmitry Monakhov
CC: tyhi...@canonical.com CC: ecryp...@vger.kernel.org Signed-off-by: Dmitry Monakhov --- fs/ecryptfs/file.c | 62 1 files changed, 62 insertions(+), 0 deletions(-) diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c index 4ffa35e..c84df35

Re: [PATCH] um: Remove unused bp stack-frame pointer

2014-10-18 Thread Richard Weinberger
Am 18.10.2014 um 17:12 schrieb Manfred Schlaegl: > On 2014-10-18 16:42, Richard Weinberger wrote: >> Am 18.10.2014 um 16:23 schrieb Manfred Schlaegl: >>> The pointer to bp stack-frame is no longer used. Removed it. >> >> Good catch! > Thank you. > >> >>> This also removes a corresponding compiler-

Re: [PATCH 2/5] block: add function to issue compare and write

2014-10-18 Thread Christoph Hellwig
On Fri, Oct 17, 2014 at 07:38:37PM -0400, Martin K. Petersen wrote: > The problem with this is that, as it stands, a bio has no type. And it > would suck if we couldn't keep bio rw and request flags in sync. > > I wonder if it would make more sense to move the remaining rq types to > cmd_flags aft

Re: [PATCH] um: Remove unused bp stack-frame pointer

2014-10-18 Thread Manfred Schlaegl
On 2014-10-18 16:42, Richard Weinberger wrote: > Am 18.10.2014 um 16:23 schrieb Manfred Schlaegl: >> The pointer to bp stack-frame is no longer used. Removed it. > > Good catch! Thank you. > >> This also removes a corresponding compiler-warning. > > Which warning exactly? On "normal" (defconfi

Re: [PATCH] scsi: Resolve some missing-field-initializers warnings

2014-10-18 Thread Christoph Hellwig
On Fri, Oct 17, 2014 at 10:44:36PM +, Rustad, Mark D wrote: > The warning appears in W=2 builds. I had another way to silence it by using > diagnostic control macros, but those macros were not accepted. Using a single > designated initialization also silences it. Oh well. I think the earli

Re: [PATCH v5 09/12] Driver core: Unified interface for firmware node properties

2014-10-18 Thread Grant Likely
On Fri, 17 Oct 2014 14:14:53 +0200 , "Rafael J. Wysocki" wrote: > From: Rafael J. Wysocki > > Add new generic routines are provided for retrieving properties from > device description objects in the platform firmware in case there are > no struct device objects for them (either those objects ha

[GIT PULL] Block driver pull for 3.18

2014-10-18 Thread Jens Axboe
Hi Linus, This is the block driver pull request for 3.18. Not a lot in there this round, and nothing earth shattering. - A round of drbd fixes from the linbit team, and an improvement in asender performance. - Removal of deprecated (and unused) IRQF_DISABLED flag in rsxx and hd from Michael

Re: [PATCH 2/4] mm: introduce new VM_NOZEROPAGE flag

2014-10-18 Thread Dominik Dingel
On Fri, 17 Oct 2014 15:04:21 -0700 Dave Hansen wrote: > Is there ever a time where the VMAs under an mm have mixed VM_NOZEROPAGE > status? Reading the patches, it _looks_ like it might be an all or > nothing thing. Currently it is an all or nothing thing, but for a future change we might want

  1   2   >