Re: [PATCH stable 2/2] virtio-net: make all RX paths handle erors consistently

2013-12-25 Thread Zhi Yong Wu
typo in the subject s/erors/errors/ On Wed, Dec 25, 2013 at 10:56 PM, Michael S. Tsirkin wrote: > receive mergeable now handles errors internally. > Do same for big and small packet paths, otherwise > the logic is too hard to follow. > > Cc: Jason Wang > Cc: David S. Miller > Signed-off-by

Re: [PATCH stable 2/2] virtio-net: make all RX paths handle erors consistently

2013-12-25 Thread Jason Wang
On 12/25/2013 10:56 PM, Michael S. Tsirkin wrote: > receive mergeable now handles errors internally. > Do same for big and small packet paths, otherwise > the logic is too hard to follow. > > Cc: Jason Wang > Cc: David S. Miller > Signed-off-by: Michael S. Tsirkin > > (cherry picked from commit

Re: [PATCH stable 1/2] virtio_net: fix error handling for mergeable buffers

2013-12-25 Thread Jason Wang
On 12/25/2013 10:56 PM, Michael S. Tsirkin wrote: > Eric Dumazet noticed that if we encounter an error > when processing a mergeable buffer, we don't > dequeue all of the buffers from this packet, > the result is almost sure to be loss of networking. > > Jason Wang noticed that we also leak a page

[PATCH] regulator: act8865: fix incorrect devm_kzalloc for act8865

2013-12-25 Thread Wenyou Yang
Which cause to allocate more needless memory. Signed-off-by: Wenyou Yang --- drivers/regulator/act8865-regulator.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c index f853353..aecf01b 10064

Re: [PATCH stable] virtio_net: don't leak memory or block when too many frags

2013-12-25 Thread Michael Dalton
Acked-by: Michael Dalton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH stable 1/2] virtio_net: fix error handling for mergeable buffers

2013-12-25 Thread Michael Dalton
Acked-by: Michael Dalton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [Query]: trace-cmd crashing with '-e syscalls' on 3.13-rc1

2013-12-25 Thread Viresh Kumar
On 24 December 2013 19:18, Steven Rostedt wrote: > Can you also produce this with just > "echo 1 > /sys/kernel/debug/tracing/events/syscalls/enable"? Yeah, running any command after doing above results in crash. I tried this on latest mainline: c5fdd53 Merge branch 'for-linus' of git://git.kerne

Re: mm: kernel BUG at include/linux/swapops.h:131!

2013-12-25 Thread Konstantin Khlebnikov
Bob Liu wrote: >On 12/24/2013 03:45 PM, Joonsoo Kim wrote: >> On Tue, Dec 24, 2013 at 03:07:05PM +0900, Joonsoo Kim wrote: >>> On Mon, Dec 23, 2013 at 10:01:10PM -0500, Sasha Levin wrote: On 12/23/2013 09:51 PM, Joonsoo Kim wrote: > On Mon, Dec 23, 2013 at 12:24:02PM -0500, Sasha Levin wr

[PATCH -tip v2 0/2] perf-probe: Dwarf support for uprobes

2013-12-25 Thread Masami Hiramatsu
Hi, Here is the 2nd version of the series of perf-probe patches which adds basic dwarf(debuginfo) support for uprobes. Currently perf-probe doesn't support debuginfo for uprobes. The lack of the debuginfo support for uprobes sometimes confuses users (or makes them cry) because they can't use perf

[PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to absolute path

2013-12-25 Thread Masami Hiramatsu
Expand given path to absolute path in the option parser, except for a module name. Since realpath at later stage in processing several probe point, can be called several times(even if currently doesn't, it can happen when we expands the feature), it is waste of the performance. Processing it once

[PATCH -tip v2 2/2] perf-probe: Support basic dwarf-based operations on uprobe events

2013-12-25 Thread Masami Hiramatsu
Support basic dwarf(debuginfo) based operations for uprobe events. With this change, perf probe can analyze debuginfo of user application binary to set up new uprobe event. This allows perf-probe --add(with local variables, line numbers) and --line works with -x option. (Actually, --vars has alread

[PATCHSET 0/8] perf tools: A couple of TUI improvements (v3)

2013-12-25 Thread Namhyung Kim
Hello, I reordered the patches so that it can be applied more smoothly. Patch 1-2 are general cleanup/fix and not related to this patchset. Patch 3 implements the header window for perf report. And the rest is for the new log window. * changes from v2) - fix segfault on log window w/ filter (

[PATCH 3/8] perf ui/tui: Implement header window

2013-12-25 Thread Namhyung Kim
From: Namhyung Kim Implement a simple, full-screen header window which shows session header (metadata) information. Press 'i' key to display the header window. Signed-off-by: Namhyung Kim --- tools/perf/Makefile.perf| 1 + tools/perf/ui/browser.h | 2 + tools/perf/ui/brows

[PATCH 2/8] perf ui/tui: Split help message for perf top and report

2013-12-25 Thread Namhyung Kim
From: Namhyung Kim Some hotkeys don't work for perf top so split help messages for them. It'll be helpful to a future modification. Also sort the message by alphabetical order of the hotkey. Signed-off-by: Namhyung Kim --- tools/perf/ui/browsers/hists.c | 49 ++

[PATCH 8/8] perf ui/tui: Remember last log line for filtering

2013-12-25 Thread Namhyung Kim
From: Namhyung Kim When updating log window with filter string, no need to search all logs everytime. Just save the last offset and update from there. Signed-off-by: Namhyung Kim --- tools/perf/ui/browsers/log.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-)

[PATCH 5/8] perf tools: Save message when pr_*() was called

2013-12-25 Thread Namhyung Kim
From: Namhyung Kim The message will be saved in a temp file so that it can be shown at a UI dialog at any time. Signed-off-by: Namhyung Kim --- tools/perf/util/debug.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/perf/util/debug.c b/tools/perf/util/debug.c index 299b55586502

[PATCH 4/8] perf tools: Introduce struct perf_log

2013-12-25 Thread Namhyung Kim
From: Namhyung Kim Add new functions to save error messages in a temp file. It'll be used by some UI front-ends to see the messages. Signed-off-by: Namhyung Kim --- tools/perf/Makefile.perf | 1 + tools/perf/perf.c| 3 ++ tools/perf/util/debug.h | 15 +++ tools/perf/util/log

[PATCH 7/8] perf ui/tui: Filter messages in log window

2013-12-25 Thread Namhyung Kim
From: Namhyung Kim Press '/' key to input filter string like main hist browser does. Requested-by: Jiri Olsa Signed-off-by: Namhyung Kim --- tools/perf/ui/browsers/log.c | 117 +-- 1 file changed, 103 insertions(+), 14 deletions(-) diff --git a/tools/p

[PATCH 1/8] perf ui/tui: Protect windows by ui__lock

2013-12-25 Thread Namhyung Kim
From: Namhyung Kim Sometimes perf top TUI breaks display with concurrent help/input window and pr_* messages since they're not protected by ui__lock. You can check it by pressing (and not releasing) 'h' key on a "perf top -vvv" TUI session. Signed-off-by: Namhyung Kim --- tools/perf/ui/tui/uti

[PATCH 6/8] perf ui/tui: Implement log window

2013-12-25 Thread Namhyung Kim
From: Namhyung Kim Implement a simple, full-screen log window which shows error messages saved so far. Press 'l' (lower-case 'L') key to display the log window. It'll be used usually with -v option. Protect updating log by ui__lock to prevent the linemap reallocation during log window refresh

[GIT PULL] ext4 fixes for 3.13

2013-12-25 Thread Theodore Ts'o
The following changes since commit dc1ccc48159d63eca5089e507c82c7d22ef60839: Linux 3.13-rc2 (2013-11-29 12:57:14 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git tags/ext4_for_linus for you to fetch changes up to f5a44db5d2d677dfbf

Confusion about Pinctrl and GPIO

2013-12-25 Thread 曹荣荣
Hi Linus and Stephen, I'm learning the pinctrl subsystem codes these days, and have a confusion about it, I'm very appreciated if you can help. I noticed that Stephen submitted a patch for pinctrl: http://www.gossamer-threads.com/lists/linux/kernel/1500890?do=post_view_threaded In this patch, St

Re: [PATCH V5 0/4] DRIVERS: IRQCHIP: Add support for crossbar IP

2013-12-25 Thread Sricharan R
Hi Thomas, On Wednesday 18 December 2013 02:49 PM, Sricharan R wrote: > Hi Thomas, > > On Tuesday 03 December 2013 03:57 PM, Sricharan R wrote: >> Some socs have a large number of interrupts requests to service >> the needs of its many peripherals and subsystems. All of the interrupt >> requests l

Re: No freezing of kernel threads (was: Re: [GIT PULL] libata fixes for v3.13-rc5)

2013-12-25 Thread Tejun Heo
Hello, Alan. On Wed, Dec 25, 2013 at 10:29:30PM -0500, Alan Stern wrote: > Thanks. As I understand it (correct me if this is wrong), the problem > is that some subsystems wait for a freezable work queue or kthread to > carry out some job, and they do this as part of their resume pathway. > Obvi

Re: [PATCH 1/2][Untested] ACPI / hotplug: Add demand_offline hotplug profile flag

2013-12-25 Thread Yasuaki Ishimatsu
(2013/12/26 12:10), Yasuaki Ishimatsu wrote: (2013/12/23 23:00), Rafael J. Wysocki wrote: From: Rafael J. Wysocki Add a new ACPI hotplug profile flag, demand_offline, such that if set for the given ACPI device object's scan handler, it will cause acpi_scan_hot_remove() to check if that device

Re: [PATCH v3 2/2] gpio: davinci: reuse for Keystone SoC

2013-12-25 Thread Prabhakar Lad
On Tue, Dec 24, 2013 at 6:57 PM, Grygorii Strashko wrote: > On 12/24/2013 01:20 PM, Prabhakar Lad wrote: >> >> Hi Grygorii, >> >> Thanks for the patch. >> >> On Tue, Dec 24, 2013 at 5:11 PM, Grygorii Strashko >> wrote: >>> >>> The similar GPIO HW block is used by keystone SoCs as >>> in Davinci S

[PATCH] ASoC: fsl_sai: Fix one bug for hardware limitation.

2013-12-25 Thread Xiubo Li
This is maybe one bug or a limitation of the hardware that the {T,R}CR2's Synchronous Mode bits must be set as late as possible, or the SAI device maybe hanged up, and there has not any explaination about this limitation in the SAI Data Sheet. Signed-off-by: Xiubo Li --- sound/soc/fsl/fsl_sai.c

No freezing of kernel threads (was: Re: [GIT PULL] libata fixes for v3.13-rc5)

2013-12-25 Thread Alan Stern
n Wed, 25 Dec 2013, Rafael J. Wysocki wrote: > > Is this discussed in more detail somewhere (an email thread, for > > example)? > > This one, more or less: https://lkml.org/lkml/2013/12/13/402 Thanks. As I understand it (correct me if this is wrong), the problem is that some subsystems wait for

[PATCH] doc/kmemcheck: add kmemcheck to kernel-parameters.txt

2013-12-25 Thread Xishi Qiu
Add kmemcheck to Documentation/kernel-parameters.txt. Signed-off-by: Xishi Qiu --- Documentation/kernel-parameters.txt |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 50680a5..671de56

Re: [PATCH 1/2][Untested] ACPI / hotplug: Add demand_offline hotplug profile flag

2013-12-25 Thread Yasuaki Ishimatsu
(2013/12/23 23:00), Rafael J. Wysocki wrote: From: Rafael J. Wysocki Add a new ACPI hotplug profile flag, demand_offline, such that if set for the given ACPI device object's scan handler, it will cause acpi_scan_hot_remove() to check if that device object's physical companions are offline upfro

Re: [PATCH] mtd: nand: remove unused function input parameter

2013-12-25 Thread Huang Shijie
On Wed, Dec 25, 2013 at 12:40:50PM +, Caizhiyong wrote: > From: Cai Zhiyong > Date: Wed, 25 Dec 2013 20:11:15 +0800 > Subject: [PATCH] mtd: nand: remove unused function input parameter > > The nand_get_flash_type parameter "busw" input value is not used by any > branch, and it is updated befo

RE: [f2fs-dev] [PATCH 1/3 V2] f2fs: check filename length in recover_dentry

2013-12-25 Thread Chao Yu
Hi, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Thursday, December 26, 2013 6:55 AM > To: Chao Yu > Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-f2fs-de...@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 1/3 V2] f2fs

Re: [PATCH 7/10] ACPI / hotplug: Move container-specific code out of the core

2013-12-25 Thread Yasuaki Ishimatsu
HI Rafael, (2013/12/26 10:01), Rafael J. Wysocki wrote: On Monday, December 23, 2013 02:58:38 PM Rafael J. Wysocki wrote: On Saturday, December 14, 2013 06:07:06 AM Rafael J. Wysocki wrote: On Friday, December 13, 2013 02:17:32 PM Yasuaki Ishimatsu wrote: (2013/12/13 13:56), Rafael J. Wysocki

Re: [PATCH] mtd: nand: assign mtd->name in find_full_id_nand

2013-12-25 Thread Huang Shijie
On Thu, Dec 26, 2013 at 01:51:58AM +, Caizhiyong wrote: > From: Cai Zhiyong > Date: Wed, 25 Dec 2013 21:19:21 +0800 > Subject: [PATCH] mtd: nand: assign mtd->name in find_full_id_nand > > This patch assigned the type->name to mtd->name when mtd->name is > NULL in function "find_full_id_nand".

split efi systab in sysfs

2013-12-25 Thread Dave Young
Hi, Matt and Peter Currently /sys/firmware/efi/systab contains multi-lines for efi systab entries. As previous discussion with Greg, this is not a good in sysfs. I wonder if there's other users for this file except kexec-tools. If kexec-tools is the only user, maybe I can split it as several file

Re: [PATCH 1/2] cpufreq: try to resume policies which failed on last resume

2013-12-25 Thread Viresh Kumar
On 26 December 2013 06:35, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Subject: cpufreq: Clean up after a failing light-weight initialization > > If cpufreq_policy_restore() returns NULL during system resume, > __cpufreq_add_dev() should just fall back to the full initialization > instea

Re: split efi systab in sysfs

2013-12-25 Thread H. Peter Anvin
On 12/25/2013 05:53 PM, Dave Young wrote: > Hi, Matt and Peter > > Currently /sys/firmware/efi/systab contains multi-lines for efi systab > entries. As previous discussion with Greg, this is not a good in sysfs. > I wonder if there's other users for this file except kexec-tools. > > If kexec-tool

[PATCH] regulator: act8865: register all regulators regardless of how many are used

2013-12-25 Thread Wenyou Yang
As Mark pointed out, the driver should register all regulators regardless of how many are used in the system in order to aid diagnostics. But in the previous patch, only register the regulators that are used. Signed-off-by: Wenyou Yang --- drivers/regulator/act8865-regulator.c | 13 +-

Re: split efi systab in sysfs

2013-12-25 Thread Dave Young
CCing Simon and kexec list On 12/26/13 at 10:12am, Dave Young wrote: > On 12/25/13 at 05:55pm, H. Peter Anvin wrote: > > On 12/25/2013 05:53 PM, Dave Young wrote: > > > Hi, Matt and Peter > > > > > > Currently /sys/firmware/efi/systab contains multi-lines for efi systab > > > entries. As previous

[PATCH] mtd: nand: assign mtd->name in find_full_id_nand

2013-12-25 Thread Caizhiyong
From: Cai Zhiyong Date: Wed, 25 Dec 2013 21:19:21 +0800 Subject: [PATCH] mtd: nand: assign mtd->name in find_full_id_nand This patch assigned the type->name to mtd->name when mtd->name is NULL in function "find_full_id_nand". mtd->name is NULL may cause some problem. Signed-off-by: Cai Zhiyong

RE: [PATCH] usb/core: fix NULL pointer dereference in recursively_mark_NOTATTACHED

2013-12-25 Thread Du, ChangbinX
> On Tue, 24 Dec 2013, Alan Stern wrote: > I think this will fix it. Take a close look and do some careful testing. > > Alan Stern > > Index: usb-3.13/drivers/usb/core/hub.c > == > = > --- usb-3.13.orig/drivers/usb/core/hub.c > +++

Re: split efi systab in sysfs

2013-12-25 Thread Dave Young
On 12/25/13 at 05:55pm, H. Peter Anvin wrote: > On 12/25/2013 05:53 PM, Dave Young wrote: > > Hi, Matt and Peter > > > > Currently /sys/firmware/efi/systab contains multi-lines for efi systab > > entries. As previous discussion with Greg, this is not a good in sysfs. > > I wonder if there's other

Question about /proc/uptime

2013-12-25 Thread Rob Landley
There are two values here, the first is seconds since boot time (which is just elapsed time; at one point it was ajusted for suspend and that was revered as confusing). The second value isn't documented but looking at fs/proc/uptime.c I think it's idle time? Except, if yo uadd up the idle t

Re: mm: kernel BUG at include/linux/swapops.h:131!

2013-12-25 Thread Bob Liu
On 12/24/2013 03:45 PM, Joonsoo Kim wrote: > On Tue, Dec 24, 2013 at 03:07:05PM +0900, Joonsoo Kim wrote: >> On Mon, Dec 23, 2013 at 10:01:10PM -0500, Sasha Levin wrote: >>> On 12/23/2013 09:51 PM, Joonsoo Kim wrote: On Mon, Dec 23, 2013 at 12:24:02PM -0500, Sasha Levin wrote: >> Ping? >>>

RE: [PATCH] Add the LED burst trigger

2013-12-25 Thread Joe Xue
Hi, Yes, Morse code can indicate any means. But when we look at the LEDs, would we like to also have a Morse code book in hand? The burst led blink idea is because it is easy to use and easy to describe. Mostly when users on site are describing the LEDs states to the support engineer. Joe --

Re: [PATCH 1/2] cpufreq: try to resume policies which failed on last resume

2013-12-25 Thread Rafael J. Wysocki
On Tuesday, December 24, 2013 07:11:00 AM Viresh Kumar wrote: > __cpufreq_add_dev() can fail sometimes while we are resuming our system. > Currently we are clearing all sysfs nodes for cpufreq's failed policy as that > could make userspace unstable. But if we suspend/resume again, we should > atle

Re: [PATCH 7/10] ACPI / hotplug: Move container-specific code out of the core

2013-12-25 Thread Rafael J. Wysocki
On Monday, December 23, 2013 02:58:38 PM Rafael J. Wysocki wrote: > On Saturday, December 14, 2013 06:07:06 AM Rafael J. Wysocki wrote: > > On Friday, December 13, 2013 02:17:32 PM Yasuaki Ishimatsu wrote: > > > (2013/12/13 13:56), Rafael J. Wysocki wrote: > > > > On Friday, December 13, 2013 11:56

Re: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer dereference.

2013-12-25 Thread Tetsuo Handa
Hello. Chris Wilson wrote: > > Since get_pid_task() grabs a reference on the task_struct, we have to drop > > the > > refcount after reading that task\'s comm name. Also, directly reading like > > get_pid_task()->comm can trigger an oops when get_pid_task() returned NULL. > > The second issue is

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-12-25 Thread Rafael J. Wysocki
On Wednesday, December 25, 2013 11:39:07 PM Pavel Machek wrote: > Hi! > > > > > Well, disabling it for the whole duration of suspend/resume and/or > > > > hibernation > > > > may not be the right approach entirely, unless we force the pax perf of > > > > the > > > > > > s/pax/max ? > > > > Yes

[PATCH] ARM: omapfb: Add early framebuffer memory allocator

2013-12-25 Thread Ivaylo Dimitrov
From: Ivaylo Dimitrov On memory limited devices, CMA fails easily when asked to allocate big chunks of memory like framebuffer memory needed for video playback. Add boot parameter "omapfb_memsize" which allocates memory to be used as dma coherent memory, so dma_alloc_attrs won't hit CMA allocato

Re: [PATCH] Add the LED burst trigger

2013-12-25 Thread Pavel Machek
Hi! > +Sometimes, the system has only one no-color led to indicate different stats. > +The LED timer trigger can let LEDs to blink in different frequency, but most > +people maybe just can discriminate two states, slow and fast. > + > +In this case, Morse code maybe is a good choice :-), but who c

Re: [f2fs-dev] [PATCH 1/3 V2] f2fs: check filename length in recover_dentry

2013-12-25 Thread Jaegeuk Kim
Hi, 2013-12-23 (월), 11:12 +0800, Chao Yu: > In current flow, we will get Null return value of f2fs_find_entry in > recover_dentry when name.len is bigger than F2FS_NAME_LEN, and then we > still add this inode into its dir entry. > To avoid this situation, we must check filename length before we us

Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers

2013-12-25 Thread Pavel Machek
Hi! > > > Well, disabling it for the whole duration of suspend/resume and/or > > > hibernation > > > may not be the right approach entirely, unless we force the pax perf of > > > the > > > > s/pax/max ? > > Yes. I'm not sure max frequency is a good idea. In particular, early athlon64 notebook

Re: [GIT PULL] libata fixes for v3.13-rc5

2013-12-25 Thread Rafael J. Wysocki
On Wednesday, December 25, 2013 09:57:09 AM Alan Stern wrote: > On Wed, 25 Dec 2013, Rafael J. Wysocki wrote: > > > On Tuesday, December 24, 2013 04:55:46 PM Alan Stern wrote: > > > On Tue, 24 Dec 2013, Tejun Heo wrote: > > > > > > > Hello, Linus. > > > > > > > > libata fixes for v3.13-rc5. The

Re: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer dereference.

2013-12-25 Thread Chris Wilson
On Tue, Dec 24, 2013 at 08:50:23PM +0900, Tetsuo Handa wrote: > >From 482be6384379072eb4c0d45d0ab8a25df4f59ed7 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Tue, 24 Dec 2013 18:04:14 +0900 > Subject: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer > dereference. > > Since g

[PATCH stable] virtio_net: don't leak memory or block when too many frags

2013-12-25 Thread Michael S. Tsirkin
We leak an skb when there are too many frags, we also stop processing the packet in the middle, the result is almost sure to be loss of networking. Reported-by: Michael Dalton Signed-off-by: Michael S. Tsirkin --- Note: this path is gone upstream, so this patch is for stable kernel only. This i

question about drivers/rtc/rtc-cmos.c

2013-12-25 Thread Julia Lawall
The function cmos_do_probe contains the code: if (is_hpet_enabled()) { int err; rtc_cmos_int_handler = hpet_rtc_interrupt; err = hpet_register_irq_handler(cmos_interrupt); if (err != 0)

Re: [PATCH stable 1/2] virtio_net: fix error handling for mergeable buffers

2013-12-25 Thread Michael S. Tsirkin
On Wed, Dec 25, 2013 at 10:33:37AM -0800, Michael Dalton wrote: > Hi Michael, quick question below: > > On Wed, Dec 25, 2013 at 6:56 AM, Michael S. Tsirkin wrote: > > if (i >= MAX_SKB_FRAGS) { > > pr_debug("%s: packet too long\n", skb->dev->name); > >

Re: [RFC PATCH 0/3] Change how we determine when to hand out THPs

2013-12-25 Thread Alex Thorlton
On Tue, Dec 17, 2013 at 06:55:00PM +0100, Andrea Arcangeli wrote: > On Tue, Dec 17, 2013 at 10:20:07AM -0600, Alex Thorlton wrote: > > This message in particular: > > > > https://lkml.org/lkml/2013/8/2/697 > > I think adding a prctl (or similar) inherited by child to turn off THP > would be a fin

question about drivers/media/usb/gspca/kinect.c

2013-12-25 Thread Julia Lawall
The following code, in the function send_cmd, looks too concise: do { actual_len = kinect_read(udev, ibuf, 0x200); } while (actual_len == 0); PDEBUG(D_USBO, "Control reply: %d", res); if (actual_len < sizeof(*rhdr)) { pr_err("send_cmd

Re: [PATCH stable 1/2] virtio_net: fix error handling for mergeable buffers

2013-12-25 Thread Michael Dalton
Hi Michael, quick question below: On Wed, Dec 25, 2013 at 6:56 AM, Michael S. Tsirkin wrote: > if (i >= MAX_SKB_FRAGS) { > pr_debug("%s: packet too long\n", skb->dev->name); > skb->dev->stats.rx_length_errors++; > -

Re: [PATCH 1/2] Add __compat_aligned_s64 and __compat_aligned_u64

2013-12-25 Thread H.J. Lu
On Wed, Dec 25, 2013 at 09:15:51AM -0800, H.J. Lu wrote: > X32 uses the 32-bit compat layer for 32-bit kernel interface, which is > also used by ia32. But long long is 4-byte aligned for ia32 and 8-byte > aligned for x32. When the long long field in a system call struct has > different offsets be

Re: [PATCH] rcu: Eliminate softirq processing from rcutree

2013-12-25 Thread Mike Galbraith
On Tue, 2013-12-24 at 23:55 -0800, Paul E. McKenney wrote: > On Wed, Dec 25, 2013 at 04:07:34AM +0100, Mike Galbraith wrote: > > > So which code do you think deserves the big lump of coal? ;-) > > > > Sebastian's NO_HZ_FULL locking fixes. Locking is hard, and rt sure > > doesn't make it any ea

[PATCH] Staging: tidspbridge: Use hashtable implementation

2013-12-25 Thread Ivaylo DImitrov
From: Ivaylo Dimitrov Use upstream hashtable implementation instead of generic code Signed-off-by: Ivaylo Dimitrov --- drivers/staging/tidspbridge/gen/gh.c | 141 +++- drivers/staging/tidspbridge/include/dspbridge/gh.h |6 +- drivers/staging/tidspbridge/pmgr/

[PATCH 2/2] Use __compat_aligned_s64 in uapi

2013-12-25 Thread H.J. Lu
The integer64 field in struct snd_ctl_elem_value has different offsets, depending the alignment of long long. This patch replaces long long with the newly introduced __compat_aligned_s64 so that x32 and ia32 can use the same compat system call for struct snd_ctl_elem_value. Signed-off-by: H.J. Lu

[PATCH 1/2] Add __compat_aligned_s64 and __compat_aligned_u64

2013-12-25 Thread H.J. Lu
X32 uses the 32-bit compat layer for 32-bit kernel interface, which is also used by ia32. But long long is 4-byte aligned for ia32 and 8-byte aligned for x32. When the long long field in a system call struct has different offsets between ia32 and x32 due to alignment padding, like struct snd_ctl_

[PATCH] Use __kernel_long_t in struct mq_attr

2013-12-25 Thread H.J. Lu
Both x32 and x86-64 use the same struct mq_attr for system calls. But x32 long is 32-bit. This patch replaces long with __kernel_long_t in struct mq_attr. Signed-off-by: H.J. Lu --- include/uapi/linux/mqueue.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/includ

[PATCH] Use __kernel_ulong_t in shmid64_ds/shminfo64/shm_info

2013-12-25 Thread H.J. Lu
Both x32 and x86-64 use the same struct shmid64_ds/shminfo64/shm_info for system calls. But x32 long is 32-bit. This patch replaces unsigned long with __kernel_ulong_t in struct shmid64_ds/shminfo64/shm_info. Signed-off-by: H.J. Lu --- include/uapi/asm-generic/shmbuf.h | 24

[PATCH] Use __kernel_ulong_t in x86 struct semid64_ds

2013-12-25 Thread H.J. Lu
Both x32 and x86-64 use the same struct semid64_ds for system calls. But x32 long is 32-bit. This patch replaces unsigned long with __kernel_ulong_t in x86 struct semid64_ds. Signed-off-by: H.J. Lu --- arch/x86/include/uapi/asm/sembuf.h | 10 +- 1 file changed, 5 insertions(+), 5 deletio

Re: [RFC PATCH 0/3] Change how we determine when to hand out THPs

2013-12-25 Thread Alex Thorlton
On Thu, Dec 19, 2013 at 03:29:06PM +, Mel Gorman wrote: > On Mon, Dec 16, 2013 at 11:12:15AM -0600, Alex Thorlton wrote: > > > Please cc Andrea on this. > > > > I'm going to clean up a few small things for a v2 pretty soon, I'll be > > sure to cc Andrea there. > > > > > > My proposed solution

[PATCH 1/1] selftests : Adding symbolic link limits test script

2013-12-25 Thread Fabian Frederick
This patch adds fs directory in selftests and a script to explain recursive and consecutive symbolic linking limits who have been debated so many times. Signed-off-by: Fabian Frederick --- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/fs/Makefile| 6 tools/test

[PATCH] Use __kernel_ulong_t in struct msqid64_ds

2013-12-25 Thread H.J. Lu
Both x32 and x86-64 use the same struct msqid64_ds for system calls. But x32 long is 32-bit. This patch replaces unsigned long with __kernel_ulong_t in struct msqid64_ds. Signed-off-by: H.J. Lu --- include/uapi/asm-generic/msgbuf.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[PATCH] Use __kernel_long_t in struct msgbuf

2013-12-25 Thread H.J. Lu
X32 msgsnd/msgrcv system calls are the same as x86-64 msgsnd/msgrcv system calls, which use 64-bit integer for long in struct msgbuf . But x32 long is 32 bit. This patch replaces long in struct msgbuf with __kernel_long_t. Signed-off-by: H.J. Lu --- include/uapi/linux/msg.h | 4 ++-- 1 file cha

[PATCH] Use __kernel_ulong_t in uapi struct ipc64_perm

2013-12-25 Thread H.J. Lu
X32 IPC system call is the same as x86-64 IPC system call, which uses 64-bit integer for unsigned long in struct ipc64_perm. But x32 long is 32 bit. This patch replaces unsigned long in uapi struct ipc64_perm with __kernel_ulong_t. Signed-off-by: H.J. Lu --- include/uapi/asm-generic/ipcbuf.h |

RE: [PATCH] usb/core: fix NULL pointer dereference in recursively_mark_NOTATTACHED

2013-12-25 Thread Alan Stern
On Tue, 24 Dec 2013, Alan Stern wrote: > > This is my analysis, how do you think? > > There is another reason why usb_hub_to_struct_hub() could return NULL: > if usb_get_intfdata(hdev->actconfig->interface[0]) is NULL. This could > happen if recursively_mark_NOTATTACHED() is called _while_ >

Re: [PATCH 4/4] sched: bias to target cpu load to reduce task moving

2013-12-25 Thread Alex Shi
>> From 5cd67d975001edafe2ee820e0be5d86881a23bd6 Mon Sep 17 00:00:00 2001 >> From: Alex Shi >> Date: Sat, 23 Nov 2013 23:18:09 +0800 >> Subject: [PATCH 4/4] sched: bias to target cpu load to reduce task moving >> >> Task migration happens when target just a bit less then source cpu load. >> To re

Re: [GIT PULL] libata fixes for v3.13-rc5

2013-12-25 Thread Alan Stern
On Wed, 25 Dec 2013, Rafael J. Wysocki wrote: > On Tuesday, December 24, 2013 04:55:46 PM Alan Stern wrote: > > On Tue, 24 Dec 2013, Tejun Heo wrote: > > > > > Hello, Linus. > > > > > > libata fixes for v3.13-rc5. There's one interseting commit - "libata, > > > freezer: avoid block device remov

[PATCH] Use __kernel_long_t/__kernel_ulong_t in

2013-12-25 Thread H.J. Lu
Both x32 and x86-64 use the same struct rusage and struct rlimit for system calls. But x32 log is 32-bit. This patch change uapi to use __kernel_long_t in struct rusage and __kernel_ulong_t in and struct rlimit. Signed-off-by: H.J. Lu --- include/uapi/linux/resource.h | 32 ---

[PATCH stable 2/2] virtio-net: make all RX paths handle erors consistently

2013-12-25 Thread Michael S. Tsirkin
receive mergeable now handles errors internally. Do same for big and small packet paths, otherwise the logic is too hard to follow. Cc: Jason Wang Cc: David S. Miller Signed-off-by: Michael S. Tsirkin (cherry picked from commit f121159d72091f25afb22007c833e60a6845e912) --- drivers/net/virtio_

[PATCH stable 1/2] virtio_net: fix error handling for mergeable buffers

2013-12-25 Thread Michael S. Tsirkin
Eric Dumazet noticed that if we encounter an error when processing a mergeable buffer, we don't dequeue all of the buffers from this packet, the result is almost sure to be loss of networking. Jason Wang noticed that we also leak a page and that we don't decrement the rq buf count, so we won't rep

[PATCH] fbcon: Fix memory leak in fbcon_exit().

2013-12-25 Thread Masami Ichikawa
kmemleak reported a memory leak as below. unreferenced object 0x880036ca84c0 (size 16): comm "swapper/0", pid 1, jiffies 4294877407 (age 4434.633s) hex dump (first 16 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ff ff backtrace: [] kmemleak_alloc+0x4e/0xb0

Re: [PATCH -tip v6 06/22] [BUGFIX] x86: Prohibit probing on memcpy/memset

2013-12-25 Thread Jovi Zhangwei
On Tue, Dec 24, 2013 at 11:58 PM, Masami Hiramatsu wrote: > (2013/12/24 18:53), Jovi Zhangwei wrote: Still no crash, use your kernel config. memcpy and __memcpy have same address in /proc/kallsyms. Looks like a interesting problem. >>> >>> Agreed. In my case, those have same ad

Re: [GIT PULL] libata fixes for v3.13-rc5

2013-12-25 Thread Rafael J. Wysocki
On Tuesday, December 24, 2013 04:55:46 PM Alan Stern wrote: > On Tue, 24 Dec 2013, Tejun Heo wrote: > > > Hello, Linus. > > > > libata fixes for v3.13-rc5. There's one interseting commit - "libata, > > freezer: avoid block device removal while system is frozen". It's an > > ugly hack working ar

Re: [PATCH 1/1] reiserfs:Adding tmpfile support

2013-12-25 Thread Richard Weinberger
On Wed, Dec 25, 2013 at 2:23 PM, Fabian Frederick wrote: > This patch is largely based on reiserfs_create function. > -Removing dquot_initialize (cf ext2/tmpfile) > -Removing add_entry code. > -Adding d_tmpfile generic call. > > It was not extensively tested; other solutions would > be to work wit

[PATCH 1/1] reiserfs:Adding tmpfile support

2013-12-25 Thread Fabian Frederick
This patch is largely based on reiserfs_create function. -Removing dquot_initialize (cf ext2/tmpfile) -Removing add_entry code. -Adding d_tmpfile generic call. It was not extensively tested; other solutions would be to work with hidden entries or merge creation - tmpfile process. Signed-off-by: F

[PATCH] mtd: nand: remove unused function input parameter

2013-12-25 Thread Caizhiyong
From: Cai Zhiyong Date: Wed, 25 Dec 2013 20:11:15 +0800 Subject: [PATCH] mtd: nand: remove unused function input parameter The nand_get_flash_type parameter "busw" input value is not used by any branch, and it is updated before use it in the function, so remove it, define the "busw" as an intern

[PATCH] lib/vsprintf: add %pT[C012] format specifier

2013-12-25 Thread Tetsuo Handa
>From 545dae06c6690a0c937e082ed984f828a2ea7aa2 Mon Sep 17 00:00:00 2001 From: Tetsuo Handa Date: Wed, 25 Dec 2013 18:16:17 +0900 Subject: [PATCH] lib/vsprintf: add %pT[C012] format specifier Since task_struct->comm can be modified by other threads while the current thread is reading it, it is rec

Re: [PATCH v3 13/19] media: dvb_core: slight optimization of addr compare

2013-12-25 Thread Sergei Shtylyov
Hello. On 25-12-2013 7:29, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal instead of memcmp. Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Yang Yingliang Signed-off-by: Ding Tianhong --- drivers/media/dvb-cor

Re: [PATCH v3 08/19] ozwpan: slight optimization of addr compare

2013-12-25 Thread Sergei Shtylyov
Hello. On 25-12-2013 7:28, Ding Tianhong wrote: Use possibly more efficient ether_addr_equal instead of memcmp. Cc: Rupesh Gujare Cc: Greg Kroah-Hartman Cc: de...@driverdev.osuosl.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Tan Xiaojun Signed-off-by: Ding Tianhong --- drivers/s

Re: tg3 and sd card reader at acer aspire

2013-12-25 Thread Vasiliy Tolstov
2013/12/25 Yijing Wang : > Maybe BROADCOM TG3 driver maintainer list can help you. > > More info can be found in MAINTAINERS file under linux kernel source > directory. Thank you! -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru jabber: v...@selfip.ru -- To unsubscribe from this list: send the

Re: [CRIU] [PATCH] timerfd: show procfs fdinfo helper

2013-12-25 Thread Andrey Wagin
2013/12/24 Shawn Landden : > | pos: 0 > | flags:02004002 > | clockid: 0 > > Cc: Thomas Gleixner > Cc: Alexander Viro > Signed-off-by: Shawn Landden > --- > fs/timerfd.c | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/fs/timerfd.c b/fs/timerfd.c > index

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-25 Thread rui wang
On 12/24/13, Prarit Bhargava wrote: > > > On 12/23/2013 11:41 PM, rui wang wrote: >> On 12/23/13, Prarit Bhargava wrote: >> > I think I have root caused this to the IRR being set in the down'd cpu. >> > It >> > is >> > admittedly a rare occurrence in the kernel. I usually have to run >> > about

Re: tg3 and sd card reader at acer aspire

2013-12-25 Thread Yijing Wang
On 2013/12/25 15:51, Vasiliy Tolstov wrote: > 2013/12/25 Robert Hancock : >> So apparently this machine got broken when we changed the behavior for the >> ACPI ASPM-not-supported bit from forcing ASPM off for everything to leaving >> ASPM in whatever state the BIOS left it in. And apparently for so