Re: Software interrupt 0x8 guest crash from userspace: virtualbox emulation or guest kernel bug?

2012-08-31 Thread halfdog
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 halfdog wrote: > I have observed a strange guest kernel crash in virtualbox and are > currently trying to understand it. Since I have no real 32-bit > Intel platform any more, I cannot verify that this crash would > happen on native 32bit also, so per

[PATCH] gpio: rdc321x: Prevent removal of modules exporting active GPIOs

2012-08-31 Thread Axel Lin
This driver can be built as a module, set the missing owner field of struct gpio_chip to prevent removal of modules exporting active GPIOs. Signed-off-by: Axel Lin --- drivers/gpio/gpio-rdc321x.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-rdc321x.c b/drivers/gpio/gp

Re: [PATCH 3/13] drivers/gpio/gpio-pxa.c: use clk_prepare_enable and clk_disable_unprepare

2012-08-31 Thread Linus Walleij
On Sun, Aug 26, 2012 at 6:00 PM, Julia Lawall wrote: > From: Julia Lawall > > Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and > clk_enable, and clk_disable and clk_unprepare. They make the code more > concise, and ensure that clk_unprepare is called when clk_enable fails.

Re: [PATCH] security: unconditionally call Yama

2012-08-31 Thread Eric W. Biederman
Kees Cook writes: > On Fri, Aug 31, 2012 at 8:31 PM, Eric W. Biederman > wrote: >> Eric Paris writes: >> >>> On Fri, Aug 31, 2012 at 4:59 PM, Eric W. Biederman >>> wrote: >>> >> Having taken the time now to vet Yama ugh. Having Yama enabled if >> simply compiled in breaks using gdb to attach

[PATCH v3 2/3] dw_dmac: max_mem_width limits value for SRC/DST_TR_WID register

2012-08-31 Thread Hein Tibosch
The dw_dmac driver was earlier adapted to do 64-bit transfers on the memory side (see https://lkml.org/lkml/2012/1/18/52) This works on ARM platforms but for AVR32 (AP700x) the maximum allowed transfer size is 32-bits. This patch allows the arch code to set a new slave property max_mem_width to lim

[PATCH v3 1/3] dw_dmac: make driver endianness configurable

2012-08-31 Thread Hein Tibosch
The dw_dmac was originally developed for avr32 to be used with the Synopsys DesignWare AHB DMA controller. After 2.6.38, access to the device's i/o memory was done with the little-endian readl/writel functions (https://patchwork.kernel.org/patch/608211) This didn't work on the avr32 platform, beca

[PATCH v3 3/3] avr32: at32ap700x: set DMA slave properties for MCI dw_dmac

2012-08-31 Thread Hein Tibosch
The MCI makes use of the dw_dmac driver when DMA is being used. Due to recent changes to dw_dmac the MCI+DMA driver was broken because: - a patch in dw_dmac allowed for 64-bit transfers on the memory side, giving an illegal value of 3 in the SRC/DST_TR_WIDTH register (http://lkml.org/lkml/2012/1/18

[PATCH v3 0/3] dw_dmac: repair driver for use with AVR32 (AP7000)

2012-08-31 Thread Hein Tibosch
@Andrew: This is the third and hopefully final version of the dw_dmac patches. Now the small Atmel patch is included because of its dependency on the second dw_dmac patch. Sorry for the earlier confusion. After some recent changes to dw_dmac, the driver got broken for the AVR32 platform for sever

Re: [PATCH] security: unconditionally call Yama

2012-08-31 Thread Kees Cook
On Fri, Aug 31, 2012 at 8:31 PM, Eric W. Biederman wrote: > Eric Paris writes: > >> On Fri, Aug 31, 2012 at 4:59 PM, Eric W. Biederman >> wrote: >> >>> From a overal kernel maintenance and use perspective the unconditional >>> enablement is a pain. >>> >>> We long ago established the principle t

Re: [PATCH] security: unconditionally call Yama

2012-08-31 Thread Eric W. Biederman
Eric Paris writes: > On Fri, Aug 31, 2012 at 4:59 PM, Eric W. Biederman > wrote: > >> From a overal kernel maintenance and use perspective the unconditional >> enablement is a pain. >> >> We long ago established the principle that compiling additional code >> into the kernel should not change th

Re: [PATCH] security: unconditionally call Yama

2012-08-31 Thread Eric Paris
On Fri, Aug 31, 2012 at 4:59 PM, Eric W. Biederman wrote: > From a overal kernel maintenance and use perspective the unconditional > enablement is a pain. > > We long ago established the principle that compiling additional code > into the kernel should not change the semenatics of the kernel. > >

Re: [PATCH v7 3/9] block: Add bio_reset()

2012-08-31 Thread Tejun Heo
Hello, On Tue, Aug 28, 2012 at 03:17:15PM -0700, Kent Overstreet wrote: > > Better to explain why some bio fields are re-ordered and why that > > shouldn't make things worse cacheline-wise? > > Well it may (struct bio is what, 3 or 4 cachelines now?) but even on > ridiculous million iop devices s

Re: kernel 3.2.27 on arm: WARNING: at mm/page_alloc.c:2109 __alloc_pages_nodemask+0x1d4/0x68c()

2012-08-31 Thread Hugh Dickins
[ Cc'ing original mail to netdev as the problem may be recognized there ] On Wed, 29 Aug 2012, David Madore wrote: > Dear all, > > I hope this is the right place to send this sort of backtrace dump. > > I'm getting the following sort of dumps (below) on a 3.2.27 kernel on > an arm/kirkwood (actu

Re: [PATCH v7 7/9] block: Add bio_clone_bioset(), bio_clone_kmalloc()

2012-08-31 Thread Tejun Heo
Hello, On Tue, Aug 28, 2012 at 03:05:32PM -0700, Kent Overstreet wrote: > On Tue, Aug 28, 2012 at 01:44:01PM -0700, Tejun Heo wrote: > > On Tue, Aug 28, 2012 at 10:37:34AM -0700, Kent Overstreet wrote: > > > +static inline struct bio *bio_clone(struct bio *bio, gfp_t gfp_mask) > > > +{ > > > + ret

Re: [PATCH v7 6/9] block: Consolidate bio_alloc_bioset(), bio_kmalloc()

2012-08-31 Thread Tejun Heo
On Tue, Aug 28, 2012 at 03:03:32PM -0700, Kent Overstreet wrote: > On Tue, Aug 28, 2012 at 01:41:48PM -0700, Tejun Heo wrote: > > Hello, Kent. > > > > On Tue, Aug 28, 2012 at 10:37:33AM -0700, Kent Overstreet wrote: > > > v7: Re-add dropped comments, improv patch description > > > > I don't think

Re: [PATCH v7 9/9] block: Avoid deadlocks with bio allocation by stacking drivers

2012-08-31 Thread Tejun Heo
Hello, Vivek. On Thu, Aug 30, 2012 at 06:07:45PM -0400, Vivek Goyal wrote: > Here is one quick and dirty proof of concept patch. It checks for stack > depth and if remaining space is less than 20% of stack size, then it > defers the bio submission to per queue worker. So, it removes breadth-first

Re: [REGRESSION] Xorg doesn't like 4e8b14526 "time: Improve sanity checking of timekeeping inputs"

2012-08-31 Thread Andreas Bombe
On Fri, Aug 31, 2012 at 10:43:42AM -0700, John Stultz wrote: > On 08/30/2012 09:05 PM, Andreas Bombe wrote: > >With that somewhat easy test I bisected it down to 4e8b14526 "time: > >Improve sanity checking of timekeeping inputs". The latest Linus git > >(155e36d40) with a revert of the bisected com

[RFC PATCH] [media] rc: filter out not allowed protocols when decoding

2012-08-31 Thread Du, Changbin
From: "Du, Changbin" Each rc-raw device has a property "allowed_protos" stored in structure ir_raw_event_ctrl. But it didn't work because all decoders would be called when decoding. This path makes only allowed protocol decoders been invoked. Signed-off-by: Du, Changbin --- drivers/media/rc/ir

Re: [PATCH V2] block/throttle: Add IO throttled information in blkio.throttle.

2012-08-31 Thread Tejun Heo
On Fri, Aug 31, 2012 at 01:15:09PM +0800, Tao Ma wrote: > From: Tao Ma > > Currently, if the IO is throttled by io-throttle, the SA has no idea of What's SA? > the situation and can't report it to the real application user about > that he/she has to do something. So this patch adds a new interf

Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API

2012-08-31 Thread Vinod Koul
On Fri, 2012-08-31 at 22:32 +0530, Vinod Koul wrote: > On Fri, 2012-08-31 at 22:01 +0530, Sekhar Nori wrote: > > >> Yes, this was the problem. Since the SPI driver now depends on > > >> CONFIG_TI_EDMA for basic operation may be select CONFIG_TI_EDMA in > > >> Kconfig if SPI is enabled? That should

Re: [PATCH tip/core/rcu 26/26] ia64: Add missing RCU idle APIs on idle loop

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:43PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > Traditionally, the entire idle task served as an RCU quiescent state. > But when RCU read side critical sections started appearing within the > idle loop, this traditional strategy became untenable.

Re: [PATCH tip/core/rcu 25/26] xtensa: Add missing RCU idle APIs on idle loop

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:42PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > In the old times, the whole idle task was considered > as an RCU quiescent state. But as RCU became more and > more successful overtime, some RCU read side critical > section have been added even in

Re: [PATCH tip/core/rcu 24/26] score: Add missing RCU idle APIs on idle loop

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:41PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > In the old times, the whole idle task was considered > as an RCU quiescent state. But as RCU became more and > more successful overtime, some RCU read side critical > section have been added even in

Re: [PATCH tip/core/rcu 23/26] parisc: Add missing RCU idle APIs on idle loop

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:40PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > In the old times, the whole idle task was considered > as an RCU quiescent state. But as RCU became more and > more successful overtime, some RCU read side critical > section have been added even in

Re: [PATCH tip/core/rcu 22/26] mn10300: Add missing RCU idle APIs on idle loop

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:39PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > In the old times, the whole idle task was considered > as an RCU quiescent state. But as RCU became more and > more successful overtime, some RCU read side critical > section have been added even in

Re: [PATCH tip/core/rcu 21/26] m68k: Add missing RCU idle APIs on idle loop

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:38PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > In the old times, the whole idle task was considered > as an RCU quiescent state. But as RCU became more and > more successful overtime, some RCU read side critical > section have been added even in

Re: [PATCH tip/core/rcu 20/26] m32r: Add missing RCU idle APIs on idle loop

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:37PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > In the old times, the whole idle task was considered > as an RCU quiescent state. But as RCU became more and > more successful overtime, some RCU read side critical > section have been added even in

Re: [PATCH tip/core/rcu 19/26] h8300: Add missing RCU idle APIs on idle loop

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:36PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > In the old times, the whole idle task was considered > as an RCU quiescent state. But as RCU became more and > more successful overtime, some RCU read side critical > section have been added even in

Re: [PATCH tip/core/rcu 18/26] frv: Add missing RCU idle APIs on idle loop

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:35PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > In the old times, the whole idle task was considered > as an RCU quiescent state. But as RCU became more and > more successful overtime, some RCU read side critical > section have been added even in

Re: [PATCH tip/core/rcu 17/26] cris: Add missing RCU idle APIs on idle loop

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:34PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > In the old times, the whole idle task was considered > as an RCU quiescent state. But as RCU became more and > more successful overtime, some RCU read side critical > section have been added even in

Re: [PATCH tip/core/rcu 16/26] alpha: Add missing RCU idle APIs on idle loop

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:33PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > In the old times, the whole idle task was considered > as an RCU quiescent state. But as RCU became more and > more successful overtime, some RCU read side critical > section have been added even in

Re: [PATCH] security: unconditionally call Yama

2012-08-31 Thread Eric W. Biederman
Eric Paris writes: > On Fri, Aug 31, 2012 at 2:39 PM, Alan Cox wrote: >> On Fri, 31 Aug 2012 14:31:26 -0700 >> Kees Cook wrote: >> >>> Unconditionally call Yama, no matter what LSM module is selected. > >> Not a good plan. What happens when everyone decides to stack every module >> by ifdeffing

Re: [PATCH tip/core/rcu 08/26] x86: Syscall hooks for userspace RCU extended QS

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:25PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > Add syscall slow path hooks to notify syscall entry > and exit on CPUs that want to support userspace RCU > extended quiescent state. > > Signed-off-by: Frederic Weisbecker > Cc: Alessio Igor Bogan

Re: [PATCH tip/core/rcu 15/26] alpha: Fix preemption handling in idle loop

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:32PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > cpu_idle() is called on the boot CPU by the init code with > preemption disabled. But the cpu_idle() function in alpha > doesn't handle this when it calls schedule() directly. > > Fix it by converti

Re: [PATCH tip/core/rcu 14/26] rcu: Userspace RCU extended QS selftest

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:31PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > Provide a config option that enables the userspace > RCU extended quiescent state on every CPUs by default. > > This is for testing purpose. > > Signed-off-by: Frederic Weisbecker > Cc: Alessio Ig

Re: [PATCH tip/core/rcu 13/26] x86: Exit RCU extended QS on notify resume

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:30PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > do_notify_resume() may be called on irq or exception > exit. But at that time the exception has already called > rcu_user_enter() and the irq has already called rcu_irq_exit(). > > Since it can use

Re: [PATCH tip/core/rcu 12/26] x86: Use the new schedule_user API on userspace preemption

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:29PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > This way we can exit the RCU extended quiescent state before > we schedule a new task from irq/exception exit. > > Signed-off-by: Frederic Weisbecker > Cc: Alessio Igor Bogani > Cc: Andrew Morton

Re: [PATCH tip/core/rcu 11/26] rcu: Exit RCU extended QS on user preemption

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:28PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > When exceptions or irq are about to resume userspace, if > the task needs to be rescheduled, the arch low level code > calls schedule() directly. > > At that time we may be in extended quiescent sta

Re: [PATCH tip/core/rcu 10/26] rcu: Exit RCU extended QS on kernel preemption after irq/exception

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:27PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > When an exception or an irq exits, and we are going to resume into > interrupted kernel code, the low level architecture code calls > preempt_schedule_irq() if there is a need to reschedule. > > If

Re: [PATCH tip/core/rcu 09/26] x86: Exception hooks for userspace RCU extended QS

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:26PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > Add necessary hooks to x86 exception for userspace > RCU extended quiescent state support. > > This includes traps, page fault, debug exceptions, etc... > > Signed-off-by: Frederic Weisbecker > Cc

Re: [PATCH 2/2] dw_dmac: max_mem_width limits value for SRC/DST_TR_WID register

2012-08-31 Thread Andrew Morton
On Mon, 27 Aug 2012 04:41:04 +0800 Hein Tibosch wrote: > The dw_dmac driver was earlier adapted to do 64-bit transfers > on the memory side (https://lkml.org/lkml/2012/1/18/52) > This works on ARM platforms but for AVR32 (AP700x) the maximum > allowed transfer size is 32-bits. > This patch allows

Re: [PATCH tip/core/rcu 07/26] rcu: Switch task's syscall hooks on context switch

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:24PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > Clear the syscalls hook of a task when it's scheduled out so that if > the task migrates, it doesn't run the syscall slow path on a CPU > that might not need it. > > Also set the syscalls hook on th

Re: [PATCH tip/core/rcu 06/26] rcu: Ignore userspace extended quiescent state by default

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:23PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > By default we don't want to enter into RCU extended quiescent > state while in userspace because doing this produces some overhead > (eg: use of syscall slowpath). Set it off by default and ready to

Re: [PATCH tip/core/rcu 05/26] rcu: Allow rcu_user_enter()/exit() to nest

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:22PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > Allow calls to rcu_user_enter() even if we are already > in userspace (as seen by RCU) and allow calls to rcu_user_exit() > even if we are already in the kernel. > > This makes the APIs more flexibl

Re: [PATCH] avr32-linux: at32ap700x: set DMA slave properties for MCI dw_dmac

2012-08-31 Thread Andrew Morton
On Mon, 27 Aug 2012 04:56:55 +0800 Hein Tibosch wrote: > The MCI makes use of the dw_dmac driver when DMA is being used. > Due to recent changes the driver was broken because: > - the SMS field in the CTLL register received the wrong value 0 > - a patch in dw_dmac allowed for 64-bit transfers on

Re: [PATCH tip/core/rcu 04/26] rcu: Settle config for userspace extended quiescent state

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:21PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker > > Create a new config option under the RCU menu that put > CPUs under RCU extended quiescent state (as in dynticks > idle mode) when they run in userspace. This require > some contribution from archite

Re: [PATCH tip/core/rcu 03/26] rcu: Make RCU_FAST_NO_HZ handle adaptive ticks

2012-08-31 Thread Josh Triplett
On Thu, Aug 30, 2012 at 02:05:20PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > The current implementation of RCU_FAST_NO_HZ tries reasonably hard to rid > the current CPU of RCU callbacks. This is appropriate when the CPU is > entering idle, where it doesn't have much useful to

Re: [PATCH 0/4] clk: Support for smp_twd clock for ux500

2012-08-31 Thread Linus Walleij
On Fri, Aug 31, 2012 at 2:21 PM, Ulf Hansson wrote: > From: Ulf Hansson > > To implement support for the smp_twd clock for ux500 several steps > was needed. This patchseries has also proposed some new changes in the > common clock core, which the ux500 smp_twd clock definition are > relying on.

Re: [rtc-linux] [PATCH 1/1] drivers/rtc/rtc-ab8500.c: Revoke Device Tree enablement

2012-08-31 Thread Linus Walleij
On Sat, Sep 1, 2012 at 1:27 AM, Linus Walleij wrote: > On Fri, Aug 31, 2012 at 1:08 PM, Lee Jones wrote: >> On Tue, Aug 14, 2012 at 10:32:02AM +0200, Linus Walleij wrote: >>> On Thu, Aug 9, 2012 at 5:57 PM, Lee Jones wrote: >>> >>> > All AB8500 devices are now registered via MFD core, so Device

Re: [rtc-linux] [PATCH 1/1] drivers/rtc/rtc-ab8500.c: Revoke Device Tree enablement

2012-08-31 Thread Linus Walleij
On Fri, Aug 31, 2012 at 1:08 PM, Lee Jones wrote: > On Tue, Aug 14, 2012 at 10:32:02AM +0200, Linus Walleij wrote: >> On Thu, Aug 9, 2012 at 5:57 PM, Lee Jones wrote: >> >> > All AB8500 devices are now registered via MFD core, so Device Tree >> > capability is no longer required for probing. Here

Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 04:57:04PM -0600, Mathieu Poirier wrote: > On 12-08-31 04:41 PM, Dmitry Torokhov wrote: > > On Fri, Aug 31, 2012 at 11:02:27PM +0100, Alan Cox wrote: > Why do we need to involve a platform device and not use, for example, a > module > parameter, that could be

Re: [PATCH] gpio: em: Fix checking return value of irq_alloc_descs

2012-08-31 Thread Linus Walleij
On Tue, Aug 28, 2012 at 1:30 PM, Axel Lin wrote: > irq_alloc_descs() returns negative error code on failure. > > Signed-off-by: Axel Lin Applied with Magnus' ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord.

Re: [PATCH] gpio:clk: preparation for switch to common clock framework

2012-08-31 Thread Linus Walleij
On Thu, Aug 30, 2012 at 8:03 PM, Murali Karicheri wrote: > As a first step towards migrating davinci platforms to use common clock > framework, replace all instances of clk_enable() with clk_prepare_enable() > and clk_disable() with clk_disable_unprepare(). Until the platform is > switched to use

Re: [PATCH] gpio: Remove broken mark for da9052 gpio driver

2012-08-31 Thread Linus Walleij
On Wed, Aug 29, 2012 at 8:57 AM, Axel Lin wrote: > The fix for MFD part is merged so remove the broken mark for da9052 gpio > driver. > > Signed-off-by: Axel Lin OK I trust you on this, patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: [PATCH 2/2] gpio: mc9s08dz60: Use devm_kzalloc API

2012-08-31 Thread Linus Walleij
On Wed, Aug 29, 2012 at 3:36 AM, Axel Lin wrote: > Signed-off-by: Axel Lin > --- > drivers/gpio/gpio-mc9s08dz60.c | 21 +++-- > 1 file changed, 3 insertions(+), 18 deletions(-) Patch applied to devel. Freescale folks, if you prefer to take this into your tree tell me and I'l

rcu_bh stalls on 3.2.28

2012-08-31 Thread Henrique de Moraes Holschuh
Just got one of these: kernel: INFO: rcu_bh detected stall on CPU 2 (t=0 jiffies) kernel: Pid: 0, comm: swapper/2 Not tainted 3.2.28+ #2 kernel: Call Trace: kernel: [] __rcu_pending+0x159/0x400 kernel: [] rcu_check_callbacks+0x9b/0x120 kernel: [] update_process_times+0x43/0x80 kernel: [] tick_sc

Re: [PATCH 1/2] gpio: mc9s08dz60: Fix build error if I2C=m

2012-08-31 Thread Linus Walleij
On Wed, Aug 29, 2012 at 3:35 AM, Axel Lin wrote: > Make GPIO_MC9S08DZ60 depend on I2C=y, this fixes below build error: > > LD init/built-in.o > drivers/built-in.o: In function `mc9s08dz60_get_value': > clk-fixed-factor.c:(.text+0x7214): undefined reference to > `i2c_smbus_read_byte_data'

Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-31 Thread Mathieu Poirier
On 12-08-31 04:41 PM, Dmitry Torokhov wrote: > On Fri, Aug 31, 2012 at 11:02:27PM +0100, Alan Cox wrote: Why do we need to involve a platform device and not use, for example, a module parameter, that could be set up from userspace? >>> >>> The platform device comes from the original

Re: [PATCH] gpio: tegra: remove useless includes of

2012-08-31 Thread Linus Walleij
On Tue, Aug 28, 2012 at 7:21 PM, Stephen Warren wrote: > On 08/27/2012 11:59 PM, Stephen Warren wrote: >> From: Stephen Warren >> >> Nothing from these files is needed, so remove the includes. This helps >> single zImage work by reducing use of the mach-tegra/include/mach/ >> directory. > > BTW,

Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-31 Thread Mathieu Poirier
On 12-08-31 04:02 PM, Alan Cox wrote: >>> Why do we need to involve a platform device and not use, for example, a >>> module >>> parameter, that could be set up from userspace? >> >> The platform device comes from the original design and was included to >> minimise the amount of changes in code th

Re: [PATCH] security: unconditionally call Yama

2012-08-31 Thread Eric Paris
On Fri, Aug 31, 2012 at 2:39 PM, Alan Cox wrote: > On Fri, 31 Aug 2012 14:31:26 -0700 > Kees Cook wrote: > >> Unconditionally call Yama, no matter what LSM module is selected. > Not a good plan. What happens when everyone decides to stack every module > by ifdeffing in the kernel - mayhem. I'm a

Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 11:02:27PM +0100, Alan Cox wrote: > > > Why do we need to involve a platform device and not use, for example, a > > > module > > > parameter, that could be set up from userspace? > > > > The platform device comes from the original design and was included to > > minimise th

Re: [PATCH v3] net: add new QCA alx ethernet driver

2012-08-31 Thread Francois Romieu
cj...@qca.qualcomm.com : [...] > diff --git a/drivers/net/ethernet/atheros/alx/alx.h > b/drivers/net/ethernet/atheros/alx/alx.h > new file mode 100644 > index 000..2b4ecc1 > --- /dev/null > +++ b/drivers/net/ethernet/atheros/alx/alx.h [...] > +#define ALX_VLAN_TO_TAG(_vlan, _tag) \ > + do

Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-31 Thread Alan Cox
> > Why do we need to involve a platform device and not use, for example, a > > module > > parameter, that could be set up from userspace? > > The platform device comes from the original design and was included to > minimise the amount of changes in code that make use of the current > keyreset dr

Re: [PATCH 0/4] scripts/checkpatch.pl: A small step for Linux...

2012-08-31 Thread Cruz Julian Bishop
On 01/09/12 04:09, Jesper Juhl wrote: > On Fri, 31 Aug 2012, Cruz Julian Bishop wrote: > >> ...and a big step for learning more Perl. >> >> Hi! >> >> This patch set started off as an experiment, but as I continued, I >> realised that I should submit this and see if it's suitable for merging >> into

Re: [PATCH 2/4] scripts/checkincludes.pl: Simplify and shorten argument logic

2012-08-31 Thread Cruz Julian Bishop
On 01/09/12 01:42, Joe Perches wrote: > On Fri, 2012-08-31 at 23:18 +1000, Cruz Julian Bishop wrote: >> This patch allows for much easier implementation of arguments >> when modifying checkincludes.pl >> >> The variable $file is also initially named $arg - I wasn't sure >> if memory would be a prob

Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-08-31 Thread Mathieu Poirier
On 12-08-30 05:01 PM, Dmitry Torokhov wrote: > Hi Matthieu, > > On Thu, Aug 30, 2012 at 04:30:54PM -0600, mathieu.poir...@linaro.org wrote: >> From: "Mathieu J. Poirier" >> >> This patch adds keyreset functionality to the sysrq driver. It >> allows certain button/key combinations to be used in or

[PATCH 1/1] nbd: clear waiting_queue on shutdown

2012-08-31 Thread paul . clements
From: Paul Clements Signed-off-by: Paul Clements --- nbd.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index d07c9f7..0c03411 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -449,6 +449,14 @@ static void nbd_clear_qu

[PATCH 0/1] nbd: fix dangling requests bug

2012-08-31 Thread paul . clements
This patch fixes a serious, but uncommon bug in nbd. This should probably be considered for backport to one or more stable branches. The bug occurs when there is heavy I/O going to the nbd device while, at the same time, a failure (server, network) or manual disconnect of the nbd connection occurs

Re: [PATCH tip/core/rcu 02/26] rcu: New rcu_user_enter_irq() and rcu_user_exit_irq() APIs

2012-08-31 Thread Josh Triplett
On Fri, Aug 31, 2012 at 09:54:39PM +0200, Frederic Weisbecker wrote: > 2012/8/31 Josh Triplett : > > Given that, the "enter" and "exit" names seem confusing. This seems > > more like a flag you can set and clear, rather than a delimited region > > as suggested by an enter/exit pair. > > > > How ab

Re: [PATCH] security: unconditionally call Yama

2012-08-31 Thread Alan Cox
On Fri, 31 Aug 2012 14:31:26 -0700 Kees Cook wrote: > Unconditionally call Yama, no matter what LSM module is selected. > > Ubuntu and Chrome OS already carry patches to do this, and Fedora has > voiced interest in doing this as well. Instead of having everyone carry > these patches, just switch

[PATCH] security: unconditionally call Yama

2012-08-31 Thread Kees Cook
Unconditionally call Yama, no matter what LSM module is selected. Ubuntu and Chrome OS already carry patches to do this, and Fedora has voiced interest in doing this as well. Instead of having everyone carry these patches, just switch Yama to being unconditional when compiled into the kernel. Sig

Re: [alsa-devel] [PATCH] ASoC: ams-delta: fix card initalization failure

2012-08-31 Thread Mark Brown
On Wed, Aug 29, 2012 at 07:04:48AM +0200, Janusz Krzysztofik wrote: > On Tue, 28 Aug 2012 11:13:39 Mark Brown wrote: > > The above looks like you already have a platform driver? All I'm > > suggesting is changing the above to use platform rather than driver > > data. > The ams-delta asoc driver

Re: [RFC v8 PATCH 13/20] memory-hotplug: check page type in get_page_bootmem

2012-08-31 Thread Andrew Morton
On Tue, 28 Aug 2012 18:00:20 +0800 we...@cn.fujitsu.com wrote: > From: Yasuaki Ishimatsu > > There is a possibility that get_page_bootmem() is called to the same page many > times. So when get_page_bootmem is called to the same page, the function only > increments page->_count. I really don't u

Re: [PATCH] ASoC: correct the check for NULL dma_buffer pointer

2012-08-31 Thread Mark Brown
On Fri, Aug 31, 2012 at 08:55:21AM +0530, Prasad Joshi wrote: > The if condition > if (!buf && !buf->area) > > checks if the buf pointer is NULL and then dereferences it again to > check if the buffer area is NULL, resulting in possible NULL > dereference. Applied, thanks. -- To unsubscribe

Re: [PATCH] frontswap: support exclusive gets if tmem backend is capable

2012-08-31 Thread Konrad Rzeszutek Wilk
On Fri, Aug 31, 2012 at 10:23:21AM -0700, Dan Magenheimer wrote: > > From: Konrad Rzeszutek Wilk > > Hi Konrad -- > > Thanks for the fast feedback! Sure. Had a couple of minutes in between the talks. > > > > +#define FRONTSWAP_HAS_EXCLUSIVE_GETS > > > +extern void frontswap_tmem_exclusive_gets(

Re: [RFC v8 PATCH 08/20] memory-hotplug: remove /sys/firmware/memmap/X sysfs

2012-08-31 Thread Andrew Morton
On Tue, 28 Aug 2012 18:00:15 +0800 we...@cn.fujitsu.com wrote: > From: Yasuaki Ishimatsu > > When (hot)adding memory into system, /sys/firmware/memmap/X/{end, start, type} > sysfs files are created. But there is no code to remove these files. The patch > implements the function to remove them. >

Re: [PATCH v4] linux/kernel.h: Fix DIV_ROUND_CLOSEST to support negative dividends

2012-08-31 Thread Guenter Roeck
On Fri, Aug 31, 2012 at 12:38:12PM -0700, Andrew Morton wrote: > On Fri, 31 Aug 2012 08:02:19 -0700 > Guenter Roeck wrote: > > > DIV_ROUND_CLOSEST returns a bad result for negative dividends: > > DIV_ROUND_CLOSEST(-2, 2) = 0 > > > > Most of the time this does not matter. However, in the hard

[PATCH v2] kernel/resource.c: fix stack overflow in __reserve_region_with_split

2012-08-31 Thread T Makphaibulchoke
Using recurvise call to try adding a non-conflicting region in the function __reserve_region_with_split() could result in a stack overflow in the case that the recursive calls are too deep. Convert the recursive calls to an iterative loop to avoid the problem. Signed-off-by: T Makphaibulchoke -

Re: [RFC v8 PATCH 04/20] memory-hotplug: offline and remove memory when removing the memory device

2012-08-31 Thread Andrew Morton
On Tue, 28 Aug 2012 18:00:11 +0800 we...@cn.fujitsu.com wrote: > +int remove_memory(int nid, u64 start, u64 size) > +{ > + int ret = -EBUSY; > + lock_memory_hotplug(); > + /* > + * The memory might become online by other task, even if you offine it. > + * So we check whether

Re: [RFC v8 PATCH 00/20] memory-hotplug: hot-remove physical memory

2012-08-31 Thread Andrew Morton
On Tue, 28 Aug 2012 18:00:07 +0800 we...@cn.fujitsu.com wrote: > This patch series aims to support physical memory hot-remove. Have you had much review and testing feedback yet? > The patches can free/remove the following things: > > - acpi_memory_info : [RFC PATCH 4/

Re: CMA page migration failure due to buffers on bh_lru

2012-08-31 Thread Laura Abbott
On 8/29/2012 6:03 PM, Laura Abbott wrote: My quick and dirty workaround for testing is to remove the GFP_MOVABLE flag from find_or_create_page but this seems significantly less than optimal. Ideally, it seems like the buffers should be evicted from the LRU when trying to drop (expand on invalid_

Re: [PATCH] [PATCH] usbnet: code clean up using checkpatch

2012-08-31 Thread David Miller
From: Oliver Neukum Date: Thu, 30 Aug 2012 20:58:42 +0200 > Dave, > > please don't take this patch. It changes code and breaks the driver. > A great big NACK. He didn't send it to netdev so I would have ignored it anyways. :-) -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH] net: ethernet: fix kernel OOPS when remove davinci_mdio module

2012-08-31 Thread David Miller
From: Bin Liu Date: Thu, 30 Aug 2012 11:37:32 -0500 > davinci mdio device is not unregistered from mdiobus when removing > the module, which causes BUG_ON() when free the device from mdiobus. > > Calling mdiobus_unregister() before mdiobus_free() fixes the issue. > > Signed-off-by: Bin Liu Ap

Re: [PATCH 0/4] Fix a crash when block device is read and block size is changed at the same time

2012-08-31 Thread Mikulas Patocka
On Fri, 31 Aug 2012, Jeff Moyer wrote: > Mikulas Patocka writes: > > > On Fri, 31 Aug 2012, Mikulas Patocka wrote: > > > >> Hi > >> > >> This is a series of patches to prevent a crash when when someone is > >> reading block device and block size is changed simultaneously. (the crash > >> is

Re: [PATCH 5/7] net/xfrm/xfrm_state.c: fix error return code

2012-08-31 Thread David Miller
From: Julia Lawall Date: Wed, 29 Aug 2012 18:49:15 +0200 > From: Julia Lawall > > Initialize return variable before exiting on an error path. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall

Re: [PATCH 2/7] net: ipv6: fix error return code

2012-08-31 Thread David Miller
From: Julia Lawall Date: Wed, 29 Aug 2012 18:49:12 +0200 > From: Julia Lawall > > Initialize return variable before exiting on an error path. > > The initial initialization of the return variable is also dropped, because > that value is never used. > > A simplified version of the semantic mat

Re: [PATCH v3] net: add new QCA alx ethernet driver

2012-08-31 Thread David Miller
From: Date: Tue, 28 Aug 2012 00:12:43 +0800 > +/* > + * Definition to enable some features > + */ > +#undef CONFIG_ALX_MSIX > +#undef CONFIG_ALX_MSI > +#undef CONFIG_ALX_MTQ > +#undef CONFIG_ALX_MRQ > +#undef CONFIG_ALX_RSS > +/* #define CONFIG_ALX_MSIX */ > +#define CONFIG_ALX_MSI > +#define CON

Re: [PATCH 2/5] net:atm:fix up ENOIOCTLCMD error handling

2012-08-31 Thread David Miller
From: Wanlong Gao Date: Mon, 27 Aug 2012 15:23:13 +0800 > At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be > translated as ENOTTY to user mode. > > Cc: "David S. Miller" > Cc: net...@vger.kernel.org > Signed-off-by: Wanlong Gao Applied to net-next, thanks. -- To unsubscribe fr

Re: [PATCH 0/4] Fix a crash when block device is read and block size is changed at the same time

2012-08-31 Thread Jeff Moyer
Mikulas Patocka writes: > On Fri, 31 Aug 2012, Mikulas Patocka wrote: > >> Hi >> >> This is a series of patches to prevent a crash when when someone is >> reading block device and block size is changed simultaneously. (the crash >> is already happening in the production environment) >> >> The

Re: [PATCH 02/14] aoe: kernel thread handles I/O completions for simple locking

2012-08-31 Thread Andrew Morton
On Sat, 25 Aug 2012 10:39:46 -0400 Ed Cashin wrote: > +static int > +kthread(void *vp) > +{ > + struct ktstate *k; > + DECLARE_WAITQUEUE(wait, current); > + int more; > + > + k = vp; > + current->flags |= PF_NOFREEZE; > + set_user_nice(current, -10); > + complete(&k->r

[PATCH 1/5] ib_srp: free memory correctly in srp_free_iu()

2012-08-31 Thread dongsu . park
From: Dongsu Park As a potential fix for a race condition in srp_free_iu(), hold a mutex in srp_free_target_ib() before calling srp_free_iu(). In addition, also clear rx/tx ring after freeing memory. Both rx_ring[] and tx_ring[] should be reinitialized to NULL, to prevent other tasks from access

[PATCH 2/5] ib_srp: removed superfluous warning in send timeout case

2012-08-31 Thread dongsu . park
From: Dongsu Park Signed-off-By: Sebastian Riemer --- drivers/infiniband/ulp/srp/ib_srp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index a0d0ca2..1b274484 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/

[PATCH 5/5] ib_srp: fix an error accessing invalid memory in rport_dev_loss_timedout

2012-08-31 Thread dongsu . park
From: Bart Van Assche In rport_dev_loss_timedout(), rport must be obtained by accessing the member entry dev_loss_work, not fast_io_fail_work. Signed-off-By: Bart Van Assche --- drivers/scsi/scsi_transport_srp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/s

[PATCH 4/5] ib_srp: check if rport->lld_data is NULL before removing rport

2012-08-31 Thread dongsu . park
From: Dongsu Park After removing rport_delete(), rport->lld_data has to be set to NULL. In addition to that, both srp_rport_delete() and rport_dev_loss_timedout() must check if rport->lld_data is NULL, before accessing to rport->lld_data or any rport's target area. Without this patch, the initia

[PATCH 3/5] ib_srp: hold a mutex when adding a new target port

2012-08-31 Thread dongsu . park
From: Dongsu Park Unter circumstances, srp_rport_add() can make conflicts with srp_rport_delete(), dumping the call trace written below. That does not always occur. But its possible reason is adding sysfs entries for the SRP target too fast, even before the deletion hasn't finished yet. The poss

[PATCH 0/5] Fix bugs in ib_srp patches for H.A. purposes

2012-08-31 Thread dongsu . park
From: Dongsu Park Hi Bart, This patchset aims at fixing bugs that have been discovered in our own SRP test environment so far. These patches are based on your patchset v4, "Make ib_srp better suited for H.A. purposes",(09 Aug 2012). The 5th patch, "fix an error accessing invalid memory in rport

Re: [PATCH] af_unix: fix shutdown parameter checking

2012-08-31 Thread David Miller
From: Xi Wang Date: Sun, 26 Aug 2012 22:47:13 -0400 > Return -EINVAL rather than 0 given an invalid "mode" parameter. > > Signed-off-by: Xi Wang Applied to net-next -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] decnet: fix shutdown parameter checking

2012-08-31 Thread David Miller
From: Steven Whitehouse Date: Mon, 27 Aug 2012 10:16:41 +0100 > On Sun, 2012-08-26 at 22:37 -0400, Xi Wang wrote: >> The allowed value of "how" is SHUT_RD/SHUT_WR/SHUT_RDWR (0/1/2), >> rather than SHUTDOWN_MASK (3). >> >> Signed-off-by: Xi Wang > Acked-by: Steven Whitehouse Applied to net-nex

Re: [PATCH tip/core/rcu 02/26] rcu: New rcu_user_enter_irq() and rcu_user_exit_irq() APIs

2012-08-31 Thread Frederic Weisbecker
2012/8/31 Josh Triplett : > On Thu, Aug 30, 2012 at 02:05:19PM -0700, Paul E. McKenney wrote: >> From: Frederic Weisbecker >> >> In some cases, it is necessary to enter or exit userspace-RCU-idle mode >> from an interrupt handler, for example, if some other CPU sends this >> CPU a resched IPI. In

  1   2   3   4   >