Linus Torvalds wrote:
>
> On Thu, 17 Jan 2008, David Schwartz wrote:
>>> "const" has nothing to do with "logical state". It has one meaning, and
>>> one meaning only: the compiler should complain if that particular type is
>>> used to do a write access.
>> Right, exactly.
>
> So why do you compl
On Fri, Jan 18, 2008 at 09:42:25AM +0800, Dave Young wrote:
...
> After digging the class usage code again, I found that the only
> possible double lock place is the class_interface_register/unregister
> in which the class_device api could be called.
OK, but currently after using mostly:
mutex_loc
On Jan 15, 2008 4:36 AM, Fengguang Wu <[EMAIL PROTECTED]> wrote:
> Andrew,
>
> This patchset mainly polishes the writeback queuing policies.
> The main goals are:
>
> (1) small files should not be starved by big dirty files
> (2) sync as fast as possible for not-blocked inodes/pages
> - don't l
On Jan 18, 2008 3:38 PM, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> On Fri, Jan 18, 2008 at 01:31:17PM +0800, Dave Young wrote:
> > On Jan 18, 2008 11:18 AM, Kay Sievers <[EMAIL PROTECTED]> wrote:
> ...
> > > Yeah, might be better to wait until class_device is gone, otherwise you
> > > may need t
We have some code internally that does just this, though it slightly
abuses struct page by tagging pages with the highest priority that
dirties them.
I'm not sure what a better solution is, though there has been talk about
rewritting it to use a per mapping radix tree to keep mem_map small.
On Fri, 18 Jan 2008 12:39:51 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote:
> Hi Andrew,
>
> The kernel build fails during the headers_check on power box
>
> CHECK include/asm/nvram.h
> /usr/local/autobench/autotest/tmp/build/linux/usr/include/asm/nvram.h
> requires linux/list.h, which d
Fengguang Wu wrote:
On Tue, Jan 15, 2008 at 09:51:49PM -0800, Andrew Morton wrote:
On Wed, 16 Jan 2008 12:55:07 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrote:
On Tue, Jan 15, 2008 at 08:42:36PM -0800, Andrew Morton wrote:
On Wed, 16 Jan 2008 12:25:53 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrot
On Fri, Jan 18, 2008 at 01:31:17PM +0800, Dave Young wrote:
> On Jan 18, 2008 11:18 AM, Kay Sievers <[EMAIL PROTECTED]> wrote:
...
> > Yeah, might be better to wait until class_device is gone, otherwise you
> > may need to fix stuff that is just going to be removed. Your change to
> > have iterator
xming wrote:
The symptom is (with a lot of subjective judgment) when there is a lot (or
too quick) output on the console of the domU (hvc0 connected with either
"xm crea file.cfg -c" or "xm cons id") the whole PV domU hangs. It will
really hang at random places, sometimes right after init and som
On Fri, Jan 18, 2008 at 04:20:40PM +0900, Tejun Heo wrote:
> aha152x.c and fdomain are built twice - once for the isa driver and
> once for the PCMCIA one. Through #ifdefs, the compiled codes are
> slightly different; thus, global symbols need to be given different
> names depending on which flavo
Hi Andrew
> > on X86, ZONE_DMA is very very small.
> > It is often no used at all.
>
> In that case page-reclaim is supposed to set all_unreclaimable and
> basically ignores the zone altogether until it looks like something might
> have changed.
>
> Is that code not working? (quite possible).
On Fri, 18 Jan 2008 12:07:27 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote:
> Hi Andrew,
>
> Patch from Tejun Heo fixes the aha152x.c build failure, and following second
> part
> of the build failure, is still occurring.
>
> drivers/scsi/fdomain.o:(.data+0x0): multiple definition of
> `fdom
Hello,
Firstly, may I apologise as I am not a member of the LKML, and ask that
I be CC'd in any responses that may be forthcoming.
My question concerns the following patch which was incorporated into the
2.6.22 kernel (quoted from that change log):
>Today, all threads waiting for a given futex
On Fri, 18 Jan 2008 15:34:33 +0900 KOSAKI Motohiro <[EMAIL PROTECTED]> wrote:
> Hi
>
> on X86, ZONE_DMA is very very small.
> It is often no used at all.
In that case page-reclaim is supposed to set all_unreclaimable and
basically ignores the zone altogether until it looks like something might
aha152x.c and fdomain are built twice - once for the isa driver and
once for the PCMCIA one. Through #ifdefs, the compiled codes are
slightly different; thus, global symbols need to be given different
names depending on which flavor is being built. This patch adds
GLOBAL() macro to aha152x.h and
Hi Andrew,
The kernel build fails during the headers_check on power box
CHECK include/asm/nvram.h
/usr/local/autobench/autotest/tmp/build/linux/usr/include/asm/nvram.h requires
linux/list.h, which does not exist in exported headers
make[3]: ***
[/usr/local/autobench/autotest/tmp/build/linux
On Jan 18, 2008 2:40 PM, Tetsuo Handa
<[EMAIL PROTECTED]> wrote:
> Hello.
>
> Andrew Morton wrote:
> > It could be compiler version dependent. I used gcc-4.1.0. Which version
> > were you and Zan using please?
I have the same problem, gcc 3.4.6
>
> I'm using gcc 3.3.5 on Debian/Sarge .
>
> By t
On Thu, Jan 17, Olaf Hering wrote:
> On Thu, Jan 17, Christoph Lameter wrote:
>
> > On Thu, 17 Jan 2008, Olaf Hering wrote:
> >
> > > The patch does not help.
> >
> > Duh. We need to know more about the problem.
>
> cache_grow is called from 3 places. The third call has cleared l3 for
> some r
> Simulators can be fixed,
They could, but why? I don't know of a good reason to require CLFLUSH.
> I just verified that Bochs 2.3.0 lacks this CPUID bit whereas the
> current version, 2.3.6, enables CLFLUSH iff SSE2 is enabled. Qemu 0.9.0
> has CLFLUSH. Andi, do you happen to know of any sp
On Jan 17, 2008 8:56 PM, Fengguang Wu <[EMAIL PROTECTED]> wrote:
Once again thanks for the speedy replies. :-)
> On Thu, Jan 17, 2008 at 01:07:05PM -0800, Michael Rubin wrote:
> Suppose we want to grant longer expiration window for temp files,
> adding a new list named s_dirty_tmpfile would be a
Hello.
Andrew Morton wrote:
> It could be compiler version dependent. I used gcc-4.1.0. Which version
> were you and Zan using please?
I'm using gcc 3.3.5 on Debian/Sarge .
By the way, 2.6.24-rc8-mm1 doesn't hang with a kernel config
# make -s allnoconfig
# make -s menuconfig
Set [*] to al
Hi,
I forgot to add one important detail - the Kernel is configured as -
Preemptible Kernel (Low-Latency Desktop).
Cheers // Matias
[EMAIL PROTECTED] skrev:
Hello,
I have some strange behavior in one of my systems.
I have a real-time kernel thread under SCHED_FIFO which is running every
10ms
Andrew Morton wrote:
> On Thu, 17 Jan 2008 21:45:39 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote:
>
>> Hi Andrew,
>>
>> The kernel build fails with following error
>>
>> drivers/scsi/aha152x.o: In function `aha152x_host_reset_host':
>> /home/kamalesh/scrap/linux-2.6.24-rc8/drivers/scsi/aha152x
Hi
What are the different solution to make a user process communicate with a
kernel modules?
Whatis the the advantages and disadvanteges of each solutions ?
--
View this message in context:
http://www.nabble.com/Communication-between-user-process-and-kernel-modules-tp14947386p14947386.html
S
Kyle McMartin wrote:
On Fri, Jan 18, 2008 at 06:53:53AM +0100, Andi Kleen wrote:
One problem that we had in the past is that some simulators
only implement the absolutely minimum feature set and you
might have well broken one of these with this.
Yeah, true. Please ignore the patch folks.
chee
Hi
on X86, ZONE_DMA is very very small.
It is often no used at all.
Unfortunately,
when NR_ACTIVE==0, NR_INACTIVE==0, shrink_zone() try to reclaim 1 page.
because
zone->nr_scan_active +=
(zone_page_state(zone, NR_ACTIVE) >> priority) + 1;
Nick,
On Jan 18, 2008 3:07 AM, Nick Piggin <[EMAIL PROTECTED]> wrote:
>
> On Friday 18 January 2008 00:24, Peter Zijlstra wrote:
> > [ At the very least CC'ing the scheduler maintainer would be
> > helpful :-) ]
> >
> > On Wed, 2008-01-16 at 16:29 -0800, stephane eranian wrote:
> > > Hello,
> > >
On Fri, Jan 18, 2008 at 09:53:16AM +0900, Tejun Heo wrote:
> aha152x.c is built twice - once for the isa driver and once for the
> PCMCIA one. Through #ifdefs, the compiled codes are slightly
> different; thus, global symbols need to be given different names
> depending on which flavor is being bu
On Fri, Jan 18, 2008 at 04:18:43AM +0100, Kay Sievers wrote:
> On Fri, 2008-01-18 at 10:28 +0800, Dave Young wrote:
> > Then what's your opinon about the lockdep warning fix? I wonder
> > whether the "soon" means we should do mutex convert after the
> > class_device going away?
>
> Yeah, might be
Hi Andrew,
The kernel build fails with following error message
scripts/mkubootimg/crc32.c:15:18: error: zlib.h: No such file or directory
scripts/mkubootimg/crc32.c:77: error: expected '=', ',', ';', 'asm' or
'__attribute__' before 'crc_table'
scripts/mkubootimg/crc32.c:153: error: expected '=',
I tried to nail down when the problem was introduced. I compiled some
official kernel release. Here is the result.
2.6.17.14 IDE -- Failed SATA -- passed
2.6.18 IDE -- Failed SATA -- failed
2.6.18.8 IDE -- Failed SATA -- failed
2.6.24-rc7-git6 IDE -- passed SATA DOM -- failed
linux-2
On Fri, Jan 18, 2008 at 06:53:53AM +0100, Andi Kleen wrote:
> One problem that we had in the past is that some simulators
> only implement the absolutely minimum feature set and you
> might have well broken one of these with this.
Yeah, true. Please ignore the patch folks.
cheers, Kyle
--
To unsu
On Friday 18 January 2008 04:04:33 am Jan Engelhardt wrote:
>
> On Jan 16 2008 13:20, Daniel Walker wrote:
> >On Thu, 2008-01-17 at 02:09 +0530, Balaji Rao wrote:
> >> Hi,
> >>
> >> When i set jiffies as the current_clocksource, date(1) tells me
> >> that wallclock time has stopped, and soon afte
On Thu, Jan 17, 2008 at 09:48:25PM +0100, Franck Bui-Huu wrote:
> From: Franck Bui-Huu <[EMAIL PROTECTED]>
>
> This patch makes almost all list mutation primitives use
> rcu_assign_pointer().
>
> The main point of this being readability improvement.
Looks better to me!
Acked-by: Paul E. McKenne
On Sat, 2007-12-08 at 04:07 +0530, Balbir Singh wrote:
> Here's a dumb simple implementation of fake NUMA nodes for PowerPC. Fake
> NUMA nodes can be specified using the following command line option
>
>
> Comments are as always welcome!
Here's some :)
> diff -puN arch/powerpc/mm/numa.c~ppc-fa
Kyle McMartin <[EMAIL PROTECTED]> writes:
> Hopefully nobody will be stupid enough to implement a cpu without
> it. Frankly, it seems safe enough given we already require SSE2.
>
> This means the compiler can optimise away "if (!cpu_has_clflush)"
> blocks.
The original required CPUID bit set for
Oops. I sent to Andrea's old mail address.
Sorry for repost.
---
Hello.
I found the documentation about lowmem_reserve_ratio is not written, and
the lower_zone_protection's description remains yet. I fixed it.
I may be something wrong due to misunderstanding. And probably, sentence
is not natu
On Fri, 2008-01-18 at 16:34 +1100, Michael Ellerman wrote:
> On Sat, 2007-12-08 at 04:07 +0530, Balbir Singh wrote:
> > Changelog
> >
> > 1. Get rid of the constant 5 (based on comments from
> > [EMAIL PROTECTED])
> > 2. Implement suggestions from Olof Johannson
> >
> Fairness is a tradeoff between seeks and bandwidth. Ideally, we
> want to spend 50% of the *disk* time servicing sequential writes and
> 50% of the time servicing seeky writes - that way neither get
> penalised unfairly by the other type of workload.
>
> Switching inodes during writeback implie
Fengguang Wu <[EMAIL PROTECTED]> writes:
>
> Suppose we want to grant longer expiration window for temp files,
> adding a new list named s_dirty_tmpfile would be a handy solution.
How would the kernel know that a file is a tmp file?
> So the question is: should we need more than 3 QoS classes?
[
On Jan 17, 2008 9:01 PM, David Chinner <[EMAIL PROTECTED]> wrote:
First off thank you for the very detailed reply. This rocks and gives
me much to think about.
> On Thu, Jan 17, 2008 at 01:07:05PM -0800, Michael Rubin wrote:
> This seems suboptimal for large files. If you keep feeding in
> new le
Hello.
I found the documentation about lowmem_reserve_ratio is not written, and
the lower_zone_protection's description remains yet. I fixed it.
I may be something wrong due to misunderstanding. And probably, sentence
is not natural. (I'm not native English speaker.)
So, please review it.
Thank
On Sat, 2007-12-08 at 04:07 +0530, Balbir Singh wrote:
> Changelog
>
> 1. Get rid of the constant 5 (based on comments from
> [EMAIL PROTECTED])
> 2. Implement suggestions from Olof Johannson
> 3. Check if cmdline is NULL in fake_numa_create_new_node()
>
> Tested w
On Fri, Jan 18, 2008 at 12:04:54AM -0500, H. Peter Anvin wrote:
> Unnecessary. These overrides are only needed for the anticases (known to
> be zero) or for some special hacks.
>
Cool, guess that means a bunch of them can go...
> Stuff that have proper CPUID bits get these defined as constants
On Fri, Jan 18, 2008 at 11:51:39AM +1100, Rusty Russell wrote:
>With a little macro ugliness, we can make kthread_create() and
>kthread_run() typesafe: avoid the casts to and from void *. To do
>this we use a temporary function pointer which takes the type of the
>data as a callback: if the functi
On Fri, Jan 18, 2008 at 12:02:05AM -0500, H. Peter Anvin wrote:
>
Meh. Waste of my time, you've already done it, but the patch wasn't on
linux-kernel, so I didn't notice.
--Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED
Hi Mike.
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -20,6 +20,7 @@ config X86
> def_bool y
> select HAVE_OPROFILE
> select HAVE_KPROBES
> + select HAVE_SETUP_PER_CPU_AREA if ARCH = "x86_64"
It is simpler to just say:
> + select HAVE_SETUP_PER_CPU_AREA if X86_
Kyle McMartin wrote:
Hopefully nobody will be stupid enough to implement a cpu without
it. Frankly, it seems safe enough given we already require SSE2.
This means the compiler can optimise away "if (!cpu_has_clflush)"
blocks.
Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]>
---
include/asm-x86
On Thu, 17 Jan 2008 19:29:18 -0600 Matt Mackall <[EMAIL PROTECTED]> wrote:
>
> On Thu, 2008-01-17 at 15:10 -0600, Matt Mackall wrote:
> > On Thu, 2008-01-17 at 02:35 -0800, Andrew Morton wrote:
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc8/2.6.24-rc8-mm1/
> >
> >
Kyle McMartin wrote:
Straightforward merge. Kind of a pity that gas doesn't really have the
concept of a "long" (long is 4-bytes for some reason.) Nor is it able to
pad to a non-power of two boundary (for struct alignment) to get rid
of the struct alt_instr padding.
Build tested on i386, i386 wi
On Jan 18, 2008 7:12 AM, Siddha, Suresh B <[EMAIL PROTECTED]> wrote:
>
> On Thu, Jan 17, 2008 at 03:04:03PM -0800, Balbir Singh wrote:
> > I think I found the root cause of the problem and a fix for it.
> > The fix works for me.
> >
>
> Thanks Balbir. But the appended fix is more clean and appropri
> On Thu, 17 Jan 2008, David Schwartz wrote:
> > > "const" has nothing to do with "logical state". It has one
> > > meaning, and
> > > one meaning only: the compiler should complain if that
> > > particular type is
> > > used to do a write access.
> >
> > Right, exactly.
> So why do you complai
Straightforward merge. Kind of a pity that gas doesn't really have the
concept of a "long" (long is 4-bytes for some reason.) Nor is it able to
pad to a non-power of two boundary (for struct alignment) to get rid
of the struct alt_instr padding.
Build tested on i386, i386 with lguest & xen paravir
Harvey Harrison <[EMAIL PROTECTED]> writes:
> Further towards unifying these files, add another helper
> in same spirit as is_errata93.
The better way to handle this would be to move all these workarounds
into notifiers that only get registered on the CPUs that actually have
the bugs.
There is r
On Thu, Jan 17, 2008 at 01:07:05PM -0800, Michael Rubin wrote:
> > Michael, could you sort out and document the new starvation prevention
> > schemes?
>
> The basic idea behind the writeback algorithm to handle starvation.
> The over arching idea is that we want to preserve order of writeback
> b
Hopefully nobody will be stupid enough to implement a cpu without
it. Frankly, it seems safe enough given we already require SSE2.
This means the compiler can optimise away "if (!cpu_has_clflush)"
blocks.
Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]>
---
include/asm-x86/cpufeature_64.h |
On Thu, Jan 17, 2008 at 01:07:05PM -0800, Michael Rubin wrote:
> On Jan 17, 2008 1:41 AM, Fengguang Wu <[EMAIL PROTECTED]> wrote:
> > On Tue, Jan 15, 2008 at 12:09:21AM -0800, Michael Rubin wrote:
> > The main benefit of rbtree is possibly better support of future policies.
> > Can you demonstrate
On Fri, 18 Jan 2008 12:19:56 +0900 Tetsuo Handa <[EMAIL PROTECTED]> wrote:
> Hello.
>
> Andrew Morton wrote:
> > I'd be suspecting git-sched, so in lieu of a full bisection search it would
> > be great if one of you could apply
> > http://userweb.kernel.org/~akpm/git-sched.patch to 2.6.24-rc8 and
I have a CentOS 4.4 system with 2.6.9-42 kernel. I will update the kernel to
the new one.
Regards,
Pravin
-Original Message-
From: Roland Dreier [mailto:[EMAIL PROTECTED]
Sent: Friday, January 18, 2008 1:03 AM
To: Pravin Nanaware
Cc: John Hubbard; LKML
Subject: Re: Bitops source proble
Choose a less generic name for such a special case. Add
a comment explaining the odd use in X86_32.
Change the one user of stack_pointer.
Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>
---
arch/x86/oprofile/backtrace.c |2 +-
include/asm-x86/ptrace.h |8 +++-
2 files change
> As Linus mentioned, main problem is to figure out the correct attribute
> for ioremap() which doesn't specify the actual attribute to be used.
In this case the correct attribute is the one of the underlying MTRR.
And if it conflicts with some other mapping that overrides an MTRR
the driver was
Zhang Rui 写道:
> Hi, Randy and Sam,
>
>>> + if (result)
>>> + goto end;acpi_bus_get_private_data
>>> + }
>>> +
>>> + end:
> Hah, Lindent always does this for me,
>> Labels should begin in column 0 or 1. Only.
> yes, and checkpatch.pl begins to complain abou
On Jan 17, 2008 7:11 PM, Yinghai Lu <[EMAIL PROTECTED]> wrote:
> some problem with PAT
>
> A: 1/17 x86.git with PAT enable kernel
> B. 1/17 x86.git with PAT diabled kernel
> C: RHEL 5.1 stock kernel -53
>
> A kexec B : OK
> B kexec A: OK
> A kexec C: very slow
> B kexec C: OK
> C kexec A: OK
> C
[PATCH] X86: fix typo PAT to X86_PAT
Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]>
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 1b38c21..980f054 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -953,7 +953,7 @@ config MATH_EMULATION
config MTRR
bool "MTRR (Memory Type
Harvey Harrison wrote:
What do you think of:
/*
* (unsigned long)regs looks strange, but it's correct for x86_32. x86_32 CPUs
* don't save the ss and esp registers if the CPU is already in kernel mode
* when it traps. So ®s happens to be esp. Valid only for kernel-mode
* pt_regs.
*/
sta
This is against current x86.git.
The size of the system call table for 32-bit x86 kernels is obtained by
compile-time calculation of the sys_call_table array, not from the value,
which the NR_syscalls macro expands to. This trivial patch removes the
fossil macro.
Manually tested by grepping the x
On Jan 17, 2008 7:42 PM, Cornelia Huck <[EMAIL PROTECTED]> wrote:
> On Thu, 17 Jan 2008 16:15:04 +0800,
> Dave Young <[EMAIL PROTECTED]> wrote:
>
> > On Thu, Jan 17, 2008 at 03:24:50PM +0800, Dave Young wrote:
> > > On Jan 17, 2008 7:06 AM, Gabor Gombas <[EMAIL PROTECTED]> wrote:
> > > > Hi,
> > >
Hi, Randy and Sam,
> > + if (result)
> > + goto end;
> > + }
> > +
> > + end:
Hah, Lindent always does this for me,
> Labels should begin in column 0 or 1. Only.
yes, and checkpatch.pl begins to complain about this
after using Lindent...
I think we should
Hello.
Andrew Morton wrote:
> I'd be suspecting git-sched, so in lieu of a full bisection search it would
> be great if one of you could apply
> http://userweb.kernel.org/~akpm/git-sched.patch to 2.6.24-rc8 and see if it
> fails in the same way.
Too bad. It didn't fail.
Regards.
--
To unsubscribe
On Fri, 2008-01-18 at 10:28 +0800, Dave Young wrote:
> On Jan 18, 2008 9:55 AM, Kay Sievers <[EMAIL PROTECTED]> wrote:
> >
> > On Jan 18, 2008 2:42 AM, Dave Young <[EMAIL PROTECTED]> wrote:
> > >
> > > On Jan 18, 2008 7:26 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> > > >
> > > > On Thu, Jan 1
On 1/17/08, Michael Opdenacker <[EMAIL PROTECTED]> wrote:
> Another issue would be that we would no longer be able
> to load the speaker driver module from a kernel which
> wasn't originally compiled with support for this module.
Have you looked at pcspeaker.o? As far as I can tell, it does *nothi
some problem with PAT
A: 1/17 x86.git with PAT enable kernel
B. 1/17 x86.git with PAT diabled kernel
C: RHEL 5.1 stock kernel -53
A kexec B : OK
B kexec A: OK
A kexec C: very slow
B kexec C: OK
C kexec A: OK
C kexec B: OK
Do we need something to disable PAT when kexec calling shutdown?
YH
-
Hi Ingo,
on recent x86.git kernel fails to kdump with following BUG.
SysRq : Trigger a crashdump
[ cut here ]
kernel BUG at include/linux/elfcore.h:105!
invalid opcode: [1] PREEMPT SMP
In crash_save_cpu(), elf_core_copy_regs() is called and
ELF_CORE_COPY_REGS macro i
On Thu, 2008-01-17 at 18:28 -0800, Andrew Morton wrote:
> On Fri, 18 Jan 2008 02:02:17 + Byron Bradley <[EMAIL PROTECTED]> wrote:
>
> > In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the
> > boot tags. The replacement ramdisk driver has rd_size as static
> > which causes link
Switch add_entropy_words to a byte-oriented interface, eliminating
numerous casts and byte/word size rounding issues. This also
reduces the overall bit/byte/word confusion in this code.
We now mix a byte at a time into the word-based pool. This takes four
times as many iterations, but should be ne
- emphasize bits in the name
- make zero bits lock-free
- simplify logic
diff -r a0689714301a -r 218e9dac90b1 drivers/char/random.c
--- a/drivers/char/random.c Thu Jan 17 20:25:24 2008 -0600
+++ b/drivers/char/random.c Thu Jan 17 20:25:24 2008 -0600
@@ -441,7 +441,7 @@
/*
* This functio
The urandom output pool (ie the fast path) fits in one cacheline, so
this is pretty unnecessary. Further, the output path has already
fetched the entire pool to hash it before calling in here.
(This was the only user of prefetch_range in the kernel, and it passed
in words rather than bytes!)
Sign
The add_ptr variable wasn't used in a sensible way, use only i instead.
i got reused later for a different purpose, use j instead.
While we're here, put tap0 first in the tap list and add a comment.
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]>
diff -r bc31fa097d34 -r 8f286e22c84d drivers/char
- eliminate new_rotate
- move input_rotate masking
- simplify input_rotate update
- move input_rotate update to end of inner loop for readability
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]>
diff -r 70f981257057 -r f06a2e1b4d58 drivers/char/random.c
--- a/drivers/char/random.c Thu Jan 17 2
On Friday 18 January 2008 00:24, Peter Zijlstra wrote:
> [ At the very least CC'ing the scheduler maintainer would be
> helpful :-) ]
>
> On Wed, 2008-01-16 at 16:29 -0800, stephane eranian wrote:
> > Hello,
> >
> > As suggested by people on this list, I have changed perfmon2 to use
> > the high re
- split the SHA variables apart into hash and workspace
- rename data to extract
- wipe extract and workspace after hashing
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]>
diff -r 3e0b0226df90 -r 42aa9f950f97 drivers/char/random.c
--- a/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600
+++
At each extraction, we change (poolbits / 16) + 32 bits in the pool,
or 96 bits in the case of the secondary pools. Thus, a brute-force
backtracking attack on the pool state is less difficult than breaking
the hash. In certain cases, this difficulty may be is reduced to 2^64
iterations.
Instead, h
Earlier changes greatly reduce the number of times we grab the lock
per output byte, so we shouldn't need this particular hack any more.
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]>
diff -r 9569d3011032 -r 70f981257057 drivers/char/random.c
--- a/drivers/char/random.c Thu Jan 17 20:25:23 2
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]>
diff -r 6f8bed9c59f7 -r 3e0b0226df90 drivers/char/random.c
--- a/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600
+++ b/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600
@@ -900,7 +900,7 @@
sizeof(*(utsname())
No locking actually needed.
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]>
diff -r f814137b0bfc -r 6f8bed9c59f7 drivers/char/random.c
--- a/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600
+++ b/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600
@@ -1063,8 +1063,7 @@
return
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]>
diff -r 905475c480bd -r f814137b0bfc drivers/char/random.c
--- a/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600
+++ b/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600
@@ -540,6 +540,10 @@
nbits, r->
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]>
diff -r 5595adaea70f -r 905475c480bd drivers/char/random.c
--- a/drivers/char/random.c Thu Jan 17 13:26:54 2008 -0600
+++ b/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600
@@ -272,7 +272,7 @@
static int trickle_thresh __read_mostly =
This is a collection of drivers/char/random.c cleanups and fixes for
2.6.25. Please apply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
On Fri, 18 Jan 2008 02:02:17 + Byron Bradley <[EMAIL PROTECTED]> wrote:
> In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the
> boot tags. The replacement ramdisk driver has rd_size as static
> which causes linking to fail when ramdisk is built-in.
>
but...
> diff --git a/dr
On Thu, Jan 17, 2008 at 09:03:17PM -0500, H. Peter Anvin wrote:
> The #ifdef is bogus. If it's required, it should go into
> asm-x86/required_features.h and then cpu_has_clflush is static; otherwise
> it's just plain wrong.
>
I have no objection to making cpu_has_clflush constant on x86_64. The
On Jan 18, 2008 9:55 AM, Kay Sievers <[EMAIL PROTECTED]> wrote:
>
> On Jan 18, 2008 2:42 AM, Dave Young <[EMAIL PROTECTED]> wrote:
> >
> > On Jan 18, 2008 7:26 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> > >
> > > On Thu, Jan 17, 2008 at 09:31:55PM +0100, Jarek Poplawski wrote:
> > > > On Thu,
On Thu, 2008-01-17 at 21:03 -0500, H. Peter Anvin wrote:
> Kyle McMartin wrote:
> > i915_flush_ttm was unconditionally executing a clflush instruction
> > to (obviously) flush the cache. Instead, check if the cpu supports
> > clflush, and if not, fall back to calling wbinvd to flush the entire
> >
On Thu, 2008-01-17 at 20:36 -0500, H. Peter Anvin wrote:
> Roland McGrath wrote:
> > It's indeed true that &pt_regs is truly the esp value for x86-32
> > kernel-mode trap frames. Because this nonobvious calculation is
> > only right for a kernel mode pt_regs and not for a user-mode one,
> > I thi
On Thu, Jan 17, 2008 at 03:17:38PM -0800, Pallipadi, Venkatesh wrote:
> >#define X X
> >
> >is a no-op, yes?
> >
>
> Later there is code in generic.h which is doing
> #ifndef ioremap_wc
> #define ioremap_wc ioremap_nocache
> #endif
Ah, that makes a bit more sense.
It'd be nice if there was less
On Fri, 18 Jan 2008 10:20:11 +0900 Tetsuo Handa <[EMAIL PROTECTED]> wrote:
> Hello.
>
> I found the CONFIG_DEBUG_LOCKING_API_SELFTESTS hangs
> at (A-A deadlock)-(wlock) pair.
>
> 2.6.24-rc8 doesn't hang.
> So, I think the bug is in 2.6.24-rc8-mm1.bz2 .
>
> The kernel configs are at
>
> http:
It should depend on CONFIG_LGUEST, not CONFIG_LGUEST_GUEST
Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
---
drivers/Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/Makefile b/drivers/Makefile
index ee1b6a5..58a17e9 100644
--- a/drivers/Ma
In article <[EMAIL PROTECTED]> (at Fri, 18 Jan 2008 11:13:19 +0900 (JST)),
YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> says:
> Assuming IN_BADCLASS() is still there, we should not reuse the name
> of "ipv6_is_badclass" because the their meanings are different.
Again, ipv4_is_badclass()
My h
Kyle McMartin wrote:
i915_flush_ttm was unconditionally executing a clflush instruction
to (obviously) flush the cache. Instead, check if the cpu supports
clflush, and if not, fall back to calling wbinvd to flush the entire
cache.
Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]>
--- a/drivers/c
In article <[EMAIL PROTECTED]> (at Fri, 18 Jan 2008 02:52:08 +0100 (CET)), Jan
Engelhardt <[EMAIL PROTECTED]> says:
>
> On Jan 18 2008 10:26, YOSHIFUJI Hideaki / 吉藤英明 wrote:
> >> -#define IN_EXPERIMENTAL(a) long int) (a)) & 0xf000) ==
> >> 0xf000)
> >> -#define IN_BADCLASS(
Harvey Harrison wrote:
On Thu, 2008-01-17 at 20:56 -0500, H. Peter Anvin wrote:
Harvey Harrison wrote:
Unify the definiton of:
v8086_mode
user_mode
user_mode_vm
stack_pointer
instruction_pointer
frame_pointer
in ptrace.h to make it clear where the differences are between
32 and 64 bit. Change
1 - 100 of 612 matches
Mail list logo
