Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2008-01-01 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Tue, 1 Jan 2008 23:00:08 -0800 > I'm very open to potential patches to do this, just don't ignore the > issues that others have run into in the past when attempting this. Fair enough. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-01 Thread Christoph Hellwig
On Wed, Jan 02, 2008 at 04:02:42AM +0200, Adrian Bunk wrote: > But userspace anyway can't use them since it doesn't know what "uspi" > is, so you should better reduce the userspace visibility of this header. We had this come up before and the header should not be exported to userspace at all. It

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2008-01-01 Thread Greg KH
On Wed, Jan 02, 2008 at 07:13:08AM +0100, Andreas Mohr wrote: > Hi, > > On Tue, Jan 01, 2008 at 10:00:06PM -0800, Greg KH wrote: > > Ok, no, I didn't write that patch, I'm getting very confused here. > > > > In 2.6.24-rc6 there is no usage of debugfs in the ohci driver. > > > > In the -mm tree t

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2008-01-01 Thread Greg KH
On Tue, Jan 01, 2008 at 09:25:01PM -0800, David Miller wrote: > From: Greg KH <[EMAIL PROTECTED]> > Date: Tue, 1 Jan 2008 21:18:28 -0800 > > > But is the usage of this semaphore in the class code really a problem? > > Has it been seen to cause issues anywhere? Does it show up on any > > benchmark

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Tejun Heo
Robert Hancock wrote: > Jeff Garzik wrote: >> Tejun Heo wrote: >>> Thanks a lot for the detailed explanation. Nvidia ppl, any ideas? >>> FLUSH is used regularly. We really need to fix this. >> >> >> I reiterate my opinion :) ... We should remove ADMA support from >> sata_nv. It's only in a fe

(Try #3) [Patch 3/8] S390: Remove 'TOPDIR' from Makefile

2008-01-01 Thread WANG Cong
>If the output file does not exist then kbuild does not care about the >dependencies and will just build the target. >On the second invocation when the target exists then kbuild has >created a file named ..cmd that list the dependencies >and this includes any included .c file. >So there is just no

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Robert Hancock
Jeff Garzik wrote: Tejun Heo wrote: Thanks a lot for the detailed explanation. Nvidia ppl, any ideas? FLUSH is used regularly. We really need to fix this. I reiterate my opinion :) ... We should remove ADMA support from sata_nv. It's only in a few chips, it's not appearing in any new c

(Try #3) [Patch 4/8] CRIS: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread WANG Cong
Refine it as suggested by Andreas. > This patch removes TOPDIR from Cris Makefiles. Cc: Mikael Starvik <[EMAIL PROTECTED]> Cc: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Andreas Schwab <[EMAIL PROTECTED]> Signed-off-by: WANG Cong <[EMAIL PROTECTED]> --- diff --git a/arch/cris/arch-v32/boot/

(Try #3) [Patch 2/8] MIPS: Remove 'TOPDIR' from Makefiles

2008-01-01 Thread WANG Cong
>> >> Shouldn't that use $(LINUXINCLUDE), or $(KBUILD_CPPFLAGS)? >It would be better to use $(LINUXINCLUDE) as we then pull in all config >symbols too and do not have to hardcode kbuild internal names (include2). OK. Refine this patch. ---> Since TOPDIR is obsolete, this patch removes

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Jeff Garzik
Tejun Heo wrote: Thanks a lot for the detailed explanation. Nvidia ppl, any ideas? FLUSH is used regularly. We really need to fix this. I reiterate my opinion :) ... We should remove ADMA support from sata_nv. It's only in a few chips, it's not appearing in any new chips, and nasty pro

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2008-01-01 Thread Andreas Mohr
Hi, On Tue, Jan 01, 2008 at 10:00:06PM -0800, Greg KH wrote: > Ok, no, I didn't write that patch, I'm getting very confused here. > > In 2.6.24-rc6 there is no usage of debugfs in the ohci driver. > > In the -mm tree there is a patch, from Tony Jones, that moves some debug > code out of sysfs an

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2008-01-01 Thread Andreas Mohr
Hi, On Sun, Dec 30, 2007 at 03:34:45PM -0500, Alan Stern wrote: > It looks like Greg misused the debugfs API -- which is ironic, because > he wrote debugfs in the first place! :-) > > Let me know if this patch fixes the problem. If it does, I'll submit > it to Greg with all the proper accoutre

[PATCH] Only print SCSI data direction warning once for a command

2008-01-01 Thread Andi Kleen
When I use cdparanoia my logs get spammed a lot by printk: 464 messages suppressed. sg_write: data in/out 30576/30576 bytes for SCSI command 0xbe--guessing data in; program cdparanoia not setting count and/or reply_len properly printk: 1078 messages suppressed. and many more of those. With th

Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2008-01-01 Thread Greg KH
On Mon, Dec 31, 2007 at 11:26:43AM -0800, Greg KH wrote: > On Mon, Dec 31, 2007 at 12:49:52PM -0500, Alan Stern wrote: > > On Sun, 30 Dec 2007, Greg KH wrote: > > > > > > It looks like Greg misused the debugfs API -- which is ironic, because > > > > he wrote debugfs in the first place! :-) > > >

(Try #3) [Patch 7/8] FS: Remove dead code

2008-01-01 Thread WANG Cong
On Tue, Jan 01, 2008 at 06:37:29PM +0100, Sam Ravnborg wrote: >On Tue, Jan 01, 2008 at 11:27:37AM -0600, Eric Sandeen wrote: >> WANG Cong wrote: >> > TOPDIR is obsolete, use objtree instead. >> > This patch removes TOPDIR from all fs/ Makefiles. >> >> > diff --git a/fs/xfs/Makefile b/fs/xfs/Makefi

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Jon Masters
On Tue, 2008-01-01 at 22:46 -0600, Matt Domsch wrote: > On Tue, Jan 01, 2008 at 09:32:36PM -0500, Jon Masters wrote: > > On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: > > > > > On the second thought: maybe we will be better off with limiting > > > MODULE_VERSION() to the dev

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2008-01-01 Thread Dave Young
On Jan 2, 2008 1:18 PM, Greg KH <[EMAIL PROTECTED]> wrote: > On Wed, Jan 02, 2008 at 08:54:53AM +0800, Dave Young wrote: > > On Dec 30, 2007 1:07 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > > > > > On Sat, Dec 29, 2007 at 03:07:30PM +0800, Dave Young wrote: > > > > On Dec 29, 2007 1:06 PM, Dave Youn

Re: 2.6.24-rc6-git7: Reported regressions from 2.6.23

2008-01-01 Thread Greg KH
On Tue, Jan 01, 2008 at 02:26:06PM -0800, Linus Torvalds wrote: > > > On Tue, 1 Jan 2008, Rafael J. Wysocki wrote: > > > > Subject : Could not set non-blocking flag with 2.6.24-rc5 > > Submitter : Tino Keitel <[EMAIL PROTECTED]> > > Date: 2007-12-13 16:27 > > References :

Re: linux 0.01 released

2008-01-01 Thread WANG Cong
On Tue, Jan 01, 2008 at 09:56:59PM +0100, Abdel wrote: >Hello everybody and happy new year, > > >I have ported linux 0.01 to gcc-4.x, and bach-3.2 (and few others >programs) can run on it. > >so you will find binary Image of linux 0.01 floppy and qemu hdd here: >http://draconux.free.fr/download/os-

Re: [BUG] crash - module radio-sf16fmr2 and esp interfere

2008-01-01 Thread Randy Dunlap
On Wed, 02 Jan 2008 01:19:33 +0100 [EMAIL PROTECTED] wrote: > same with radio-sf16fmr2 and esp > > after repeatedly modrpobe/modprobe -r radio-sf16fmr2, i can hang my system > when loading esp afterwards > > before loading esp, doing a "cat /proc/ioport" segfaults > > this is with 2.6.24rc6

[2.6.23.12] consistent "invalid opcode: 0000"

2008-01-01 Thread Kalin KOZHUHAROV
Hi all, And Happy New Year! May 2008 bring us less bugs :-) Please Cc me, as I am not subscribed anymore. I recently upgraded the kernel of one of my servers to a vanilla* 2.6.23.12 and had it running for a few days (vanilla*, 'cause I change the Makefile to use distcc). After some time I got "

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2008-01-01 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Tue, 1 Jan 2008 21:18:28 -0800 > But is the usage of this semaphore in the class code really a problem? > Has it been seen to cause issues anywhere? Does it show up on any > benchmarks as being something that really needs to be replaced? It's a question of

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2008-01-01 Thread Greg KH
On Wed, Jan 02, 2008 at 08:54:53AM +0800, Dave Young wrote: > On Dec 30, 2007 1:07 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > > > On Sat, Dec 29, 2007 at 03:07:30PM +0800, Dave Young wrote: > > > On Dec 29, 2007 1:06 PM, Dave Young <[EMAIL PROTECTED]> wrote: > > > > > > > > On Dec 29, 2007 12:42 PM

RE: [2.6 patch] #if 0 dma_async_memcpy_buf_to_buf()

2008-01-01 Thread Nelson, Shannon
>From: Alan Cox [mailto:[EMAIL PROTECTED] >Sent: Tuesday, January 01, 2008 6:26 AM >To: Adrian Bunk >Cc: Nelson, Shannon; Williams, Dan J; linux-kernel@vger.kernel.org >Subject: Re: [2.6 patch] #if 0 dma_async_memcpy_buf_to_buf() > >On Tue, 1 Jan 2008 15:49:24 +0200 >Adrian Bunk <[EMAIL PROTECTED]

Re: Get physical MAC address

2008-01-01 Thread Matt Domsch
On Mon, Dec 31, 2007 at 12:39:11PM +0700, Theewara Vorakosit wrote: > Hello, > > I get MAC address from ioctl. However, ifconfig can change this MAC > address. Can I get a real physical MAC address of the NIC? yes. It's ETHTOOL_GPERMADDR to the ethtool ioctl. case ETHTOOL_GPERMADDR:

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Matt Domsch
On Tue, Jan 01, 2008 at 09:32:36PM -0500, Jon Masters wrote: > On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: > > > On the second thought: maybe we will be better off with limiting > > MODULE_VERSION() to the device drivers and the IDE core module for now, > > and just removin

Re: [PATCH] [CFT] Code clarification patch to Kprobes arch code

2008-01-01 Thread Ananth N Mavinakayanahalli
On Tue, Jan 01, 2008 at 04:19:43PM +0100, Ingo Molnar wrote: > > * Quentin Barnes <[EMAIL PROTECTED]> wrote: > > > Since people are discussing some x86 Kprobes code cleanup, I thought I > > would contribute a small change as well. When developing the Kprobes > > arch code for ARM, I ran across

Re: [PATCH 2/2] Markers Implementation for Preempt RCU Boost Tracing

2008-01-01 Thread Frank Ch. Eigler
Ingo Molnar <[EMAIL PROTECTED]> writes: > [...] Firstly, why on earth does a full format string have to be > passed in for something as simple as a CPU id? This way we basically > codify it forever that tracing _has_ to be expensive when > enabled. [...] FWIW, I'm not keen about the format strin

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Tejun Heo
Robert Hancock wrote: >> This is kind of a longstanding problem which has been partially worked >> around, but it seems not entirely. This is what I had diagnosed some >> time ago: >> >> "recently, some issues cropped up with command timeouts when a cache >> flush command was immediately followed b

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Robert Hancock
Robert Hancock wrote: Tejun Heo wrote: [cc'ing Robert Hancock and NVidia people] Whole thread can be read from the following URL. http://thread.gmane.org/gmane.linux.ide/21710 In a nutshell, with ADMA enabled, FLUSH_EXT occasionally times out. I first suspected faulty disk (reallocation fa

Re: [PATCH] Fix errors detected by checkpatch.pl on nmi_int.c

2008-01-01 Thread Carlos R. Mafra
On Tue 1.Jan'08 at 17:05:49 -0800, Carlos R. Mafra wrote: > This patch fixes most errors detected by checkpatch.pl. > [...] As pointed out by Jesper Juhl, my patch was not inlined :-( I did set up mutt especially to send this patch (instead of thunderbird), and I did test it before sending (and

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Robert Hancock
Tejun Heo wrote: [cc'ing Robert Hancock and NVidia people] Whole thread can be read from the following URL. http://thread.gmane.org/gmane.linux.ide/21710 In a nutshell, with ADMA enabled, FLUSH_EXT occasionally times out. I first suspected faulty disk (reallocation failure on flush) but SMA

Re: [PATCH] x86: gitignore arch/x86/vdso files

2008-01-01 Thread Roland McGrath
I'd make those *.lds or at least vdso*.lds, since it is more likely there will be other variants than that there will be any .lds source files (since they are .lds.S instead). Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EM

Re: 2.6.24-rc6-git7: Reported regressions from 2.6.23

2008-01-01 Thread James Bottomley
On Tue, 2008-01-01 at 14:26 -0800, Linus Torvalds wrote: > > Subject : Problems on booting > > Submitter : "werner" <[EMAIL PROTECTED]> > > Date: 2007-12-22 14:29 > > References : http://lkml.org/lkml/2007/12/22/110 > > http://bugzilla.kernel.org/show_bug.cgi?i

Re: [PATCH] net/x25: Add missing x25_neigh_put

2008-01-01 Thread David Miller
From: Julia Lawall <[EMAIL PROTECTED]> Date: Tue, 1 Jan 2008 22:07:04 +0100 (CET) > The function x25_get_neigh increments a reference count. At the point of > the second goto out, the result of calling x25_get_neigh is only stored in > a local variable, and thus no one outside the function will b

Re: [2.6 patch] the scheduled shaper removal

2008-01-01 Thread David Miller
From: Alan Cox <[EMAIL PROTECTED]> Date: Tue, 1 Jan 2008 14:24:30 + > On Tue, 1 Jan 2008 15:47:35 +0200 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch contains the scheduled removal of the shaper driver. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > Acked-by: Alan Co

Re: sata_nv + ADMA + Samsung disk problem

2008-01-01 Thread Tejun Heo
[cc'ing Robert Hancock and NVidia people] Whole thread can be read from the following URL. http://thread.gmane.org/gmane.linux.ide/21710 In a nutshell, with ADMA enabled, FLUSH_EXT occasionally times out. I first suspected faulty disk (reallocation failure on flush) but SMART reports nothing

Re: 2.6.24-rc6-git7: Reported regressions from 2.6.23

2008-01-01 Thread Zhenyu Wang
On 2008.01.01 22:02:57 +, Rafael J. Wysocki wrote: > Subject : linux-2.6.24-rcX regression / > xserver-xorg-video-intel / Q35 > Submitter : Harald Welte <[EMAIL PROTECTED]> > Date : 2007-12-22 04:37 > References: http://lkml.org/lkml/2007/12/21/269 >

Re: Get physical MAC address

2008-01-01 Thread Kyle Moffett
On Jan 01, 2008, at 21:42:18, Jon Masters wrote: On Mon, 2007-12-31 at 12:39 +0700, Theewara Vorakosit wrote: I get MAC address from ioctl. However, ifconfig can change this MAC address. Can I get a real physical MAC address of the NIC? Forgive me reading into your mail...this smells a bit l

Re: [PATCH 25/26] [REVISED] atl1: add NAPI support

2008-01-01 Thread David Miller
From: "Joonwoo Park" <[EMAIL PROTECTED]> Date: Wed, 2 Jan 2008 11:56:36 +0900 > Since we had reached a consensus on fixing it without each drivers > modifications, there is no best solution for that problem for > now. I'm expecting Dave or others work for net-core. > (http://lkml.org/lkml/2007/12/

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2008-01-01 Thread Rene Herman
On 31-12-07 16:56, Alan Cox wrote: Okay. Am about to go stuff my face with new years celebrations but will definitely try to make that old WD8003 hickup. Have fun. Is it an 8390 or an 83905 ? A DP8390BN. And I have a DP8390CN on a 3Com Etherlink II. The NE1000 has a DP83901AV, my new-fangle

RE: [PATCH 25/26] [REVISED] atl1: add NAPI support

2008-01-01 Thread Joonwoo Park
Hi Jay, + if ((work_done < budget) || !netif_running(poll_dev)) { +quit_polling: + netif_rx_complete(poll_dev, napi); + + if (!test_bit(__ATL1_DOWN, &adapter->flags)) + atlx_irq_enable(adapter); + } Not enough :) If netif_running() is

[PATCH 3/3] Nuke duplicate header from sysctl.c

2008-01-01 Thread Jesper Juhl
From: Jesper Juhl <[EMAIL PROTECTED]> Don't include linux/security.h twice in kernel/sysctl.c Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- sysctl.c |1 - 1 file changed, 1 deletion(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index c68f68d..01b12c3 100644 --- a/kernel/sysctl.c

[PATCH 2/3] Nuke a duplicate include from profile.c

2008-01-01 Thread Jesper Juhl
From: Jesper Juhl <[EMAIL PROTECTED]> Remove duplicate inclusion of linux/profile.h from kernel/profile.c Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- profile.c |1 - 1 file changed, 1 deletion(-) diff --git a/kernel/profile.c b/kernel/profile.c index 5e95330..ffaebea 100644 --- a/ke

[PATCH 1/3] Nuke duplicate include from printk.c

2008-01-01 Thread Jesper Juhl
From: Jesper Juhl <[EMAIL PROTECTED]> Remove the duplicate inclusion of linux/jiffies.h from kernel/printk.c Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- printk.c |1 - 1 file changed, 1 deletion(-) diff --git a/kernel/printk.c b/kernel/printk.c index 89011bf..b4bca0d 100644 --- a/k

[PATCH 0/3] Nuke a few duplicate includes

2008-01-01 Thread Jesper Juhl
Including the same header twice (or more) in a .c file, outside any #ifdef's and whatnot, serves no purpose except generating more work for the compiler, so here are 3 patches that get rid of some pointless duplicate includes. Kind regards, Jesper Juhl <[EMAIL PROTECTED]> -- To unsubscribe

Re: Get physical MAC address

2008-01-01 Thread Jon Masters
On Mon, 2007-12-31 at 12:39 +0700, Theewara Vorakosit wrote: > I get MAC address from ioctl. However, ifconfig can change this MAC > address. Can I get a real physical MAC address of the NIC? Forgive me reading into your mail...this smells a bit like some kind of licensing/compliance thing. Jus

Re: [BUG] crash - modules l440gx and parport_pc interfere

2008-01-01 Thread Jon Masters
On Tue, 2008-01-01 at 20:57 +0100, [EMAIL PROTECTED] wrote: > there seems some weird interference between l440gx and parport_pc modules > > i can reproduceable crash my box by either: > > modprobe parport_pc;modprobe l440gx;rmmod parport_pc > > or > > modprobe l440gx; modprobe parport_pc;rmmod

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Jon Masters
On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: > On the second thought: maybe we will be better off with limiting > MODULE_VERSION() to the device drivers and the IDE core module for now, > and just removing all these private version numbers from host drivers > (with one or tw

Re: [PATCH 06/12] pci : Use mutex instead of semaphore in driver core

2008-01-01 Thread Dave Young
On Dec 29, 2007 7:42 PM, Stefan Richter <[EMAIL PROTECTED]> wrote: > Matthew Wilcox wrote: > > Patches should be self-contained for ease of bisecting. I can't tell > > whether this patch is correct or not because you haven't included all > > the other places that need to change at the same time as

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override.

2008-01-01 Thread H. Peter Anvin
Christer Weinigel wrote: Both 0xed and 0xf0 are mapped to internal functions on the AMD Elan SC400 processor. It is an AMD 486 based system on a chip and since AMD just knew that it would never have a math coprocessor, they reused the 0xf0-0xf2 range for the PCMCIA controller. I guess the AMD

Re: asm-x86/byteorder.h: clean up for userspace

2008-01-01 Thread H. Peter Anvin
Adrian Bunk wrote: Userspace either has to #define CONFIG_X86_BSWAP or it'll get the slow versions of these functions... Leaking CONFIG_ variables to userspace is not really funny - I remember e.g. what tricks MySQL does (did?) for (ab)using asm-i386/atomic.h in userspace. True. CONFIG

Re: Get physical MAC address

2008-01-01 Thread Stephen Hemminger
On Wed, 02 Jan 2008 00:07:28 +0100 Bernd Petrovitsch <[EMAIL PROTECTED]> wrote: > On Mon, 2007-12-31 at 12:39 +0700, Theewara Vorakosit wrote: > [...] > > I get MAC address from ioctl. However, ifconfig can change this MAC > > address. Can I get a real physical MAC address of the NIC? > > - You

Re: [2.6 patch] the scheduled 'time' option removal

2008-01-01 Thread Randy Dunlap
On Tue, 1 Jan 2008 15:46:56 +0200 Adrian Bunk wrote: > This patch contains the scheduled removal of the 'time' option. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Thanks. Looks good except that Documentation/kernel-parameters.txt needs a patch also: delete these 3 lines: time

Re: [PATCH linux-acpi] Correct wakeup set error and append a new column PCI ID

2008-01-01 Thread Yi Yang
On Wed, 2008-01-02 at 00:20 +0100, Pavel Machek wrote: > Hi! > > > /proc/acpi/wakeup is also case-sensitive, case-insensitive is better. > > Why? A user uses device bus id like 'C093' to enable or disable wakeup of the device, for example echo "C093" > /proc/acpi/wakeup but i think "c093" shoul

Re: [patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-01 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 08:51:40PM -0500, Mike Frysinger wrote: > Fix the ufs_inotofsba macro to use __u64 rather than u64 since this is > exported to userspace. > > Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> > --- > diff --git a/include/linux/ufs_fs.h b/include/linux/ufs_fs.h > index 10b85

Re: [PATCH] Fix errors detected by checkpatch.pl on nmi_int.c

2008-01-01 Thread Jesper Juhl
On 02/01/2008, Carlos R. Mafra <[EMAIL PROTECTED]> wrote: > This patch fixes most errors detected by checkpatch.pl. > > errors lines of code errors/KLOC > arch/x86/oprofile/nmi_int.c (after) 1 461 2.1 > arch/x86/oprofile/nmi_int.c

[patch] linux/ufs_fs.h: use __u64 for userspace

2008-01-01 Thread Mike Frysinger
Fix the ufs_inotofsba macro to use __u64 rather than u64 since this is exported to userspace. Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> --- diff --git a/include/linux/ufs_fs.h b/include/linux/ufs_fs.h index 10b854d..35b6e59 100644 --- a/include/linux/ufs_fs.h +++ b/include/linux/ufs_fs.h @

[2.6.24 patch] let EXT4DEV_FS depend on BROKEN

2008-01-01 Thread Adrian Bunk
It might make sense to offer ext4 in -mm and even in early -rc kernels, but I've already seen people using ext4 simply because a stable kernel offered it - and that's definitely not intended. Anyone who _really_ wants to test ext4 should anyway be able to do the trivial change of removing the "

Re: asm-x86/byteorder.h: clean up for userspace

2008-01-01 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 01:19:42PM -0800, H. Peter Anvin wrote: > Christoph Hellwig wrote: >> On Mon, Dec 31, 2007 at 01:12:45PM -0500, Mike Frysinger wrote: >>> Since asm-x86/byteorder.h is exported to userspace, use __asm__ rather than >>> asm in its code. >> >> The correct fix is to not export i

Re: [Suspend2-devel] Freezing filesystems (Was Re: What's in store for 2008 for TuxOnIce?)

2008-01-01 Thread Nigel Cunningham
Hi Ted. Theodore Tso wrote: > On Wed, Jan 02, 2008 at 10:54:18AM +1100, Nigel Cunningham wrote: >>> I would also like the TuxOnIce issues related to drivers, ACPI, etc. to go >>> to >>> one of the kernel-related lists, but I think linux-pm may be better for that >>> due to the much lower traffic.

Re: asm-x86/msr.h for sanitized headers: clean it or punt it

2008-01-01 Thread Adrian Bunk
On Mon, Dec 31, 2007 at 01:49:27PM -0500, Mike Frysinger wrote: > Use __asm__ and __volatile__ in code that is exported to userspace. Wrap > kernel functions with __KERNEL__ so they get scrubbed. > > Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> > --- > diff --git a/include/asm-x86/msr.h b/in

[patch] asm-x86/msr.h: pull in linux/types.h

2008-01-01 Thread Mike Frysinger
Forgot to mention this before, but since the msr.h header uses types like __u32, it should pull in linux/types.h. Signed-Off-By: Mike Frysinger <[EMAIL PROTECTED]> --- diff --git a/include/asm-x86/msr.h b/include/asm-x86/msr.h index ba4b314..beea1bf 100644 --- a/include/asm-x86/msr.h +++ b/include

Re: [PATCH 04/12] i2c : Use mutex instead of semaphore in driver core

2008-01-01 Thread Dave Young
On Dec 29, 2007 7:49 PM, Stefan Richter <[EMAIL PROTECTED]> wrote: > Dave Young wrote: > > --- linux/drivers/i2c/i2c-core.c 2007-12-28 10:06:58.0 +0800 > > +++ linux.new/drivers/i2c/i2c-core.c 2007-12-28 10:08:58.0 +0800 > > @@ -33,8 +33,8 @@ > > #include > > #include > >

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override.

2008-01-01 Thread Rene Herman
On 02-01-08 01:55, Christer Weinigel wrote: On Wed, 02 Jan 2008 00:11:54 +0100 Rene Herman <[EMAIL PROTECTED]> wrote: Well, on the PIIX it is and I guess on anything where it's _not_ fully internal an 0xf0 write wouldn't have any effect on IRQ13... When you earlier mentioned this it seemed 0x

[PATCH] Fix errors detected by checkpatch.pl on nmi_int.c

2008-01-01 Thread Carlos R. Mafra
This patch fixes most errors detected by checkpatch.pl. errors lines of code errors/KLOC arch/x86/oprofile/nmi_int.c (after) 1 461 2.1 arch/x86/oprofile/nmi_int.c (before) 60 477 125.7 No code changed. s

[RFC PATCH] Add input event to APM event bridge for embedded devices

2008-01-01 Thread Richard Purdie
This patch adds a very simple input power event to APM user suspend event bridge. Its currently only works for the systems using the emulated APM driver but could easily be extended to work with anything with a true APM BIOS too. This covers a standard embedded system need which is to suspend when

Re: [BUG][PATCH] bluetooth: put_device before device_del fix

2008-01-01 Thread Dave Young
On Dec 30, 2007 11:18 AM, David Miller <[EMAIL PROTECTED]> wrote: > From: Dave Young <[EMAIL PROTECTED]> > Date: Thu, 27 Dec 2007 13:27:50 +0800 > > > Because of workqueue delay, the put_device could be called before > > device_del, so move it to del_conn. > > > > Signed-off-by: Dave Young <[EMAIL

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2008-01-01 Thread Dave Young
On Dec 30, 2007 6:01 AM, Alan Stern <[EMAIL PROTECTED]> wrote: > > On Sat, 29 Dec 2007, Dave Young wrote: > > > On Dec 29, 2007 1:06 PM, Dave Young <[EMAIL PROTECTED]> wrote: > > > > > > On Dec 29, 2007 12:42 PM, Greg KH <[EMAIL PROTECTED]> wrote: > > > > On Sat, Dec 29, 2007 at 10:36:49AM +0800, D

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override.

2008-01-01 Thread Christer Weinigel
On Wed, 02 Jan 2008 00:11:54 +0100 Rene Herman <[EMAIL PROTECTED]> wrote: > Well, on the PIIX it is and I guess on anything where it's _not_ > fully internal an 0xf0 write wouldn't have any effect on IRQ13... > > When you earlier mentioned this it seemed 0xed switched on DMI would > be good enoug

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2008-01-01 Thread Dave Young
On Dec 30, 2007 1:07 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > On Sat, Dec 29, 2007 at 03:07:30PM +0800, Dave Young wrote: > > On Dec 29, 2007 1:06 PM, Dave Young <[EMAIL PROTECTED]> wrote: > > > > > > On Dec 29, 2007 12:42 PM, Greg KH <[EMAIL PROTECTED]> wrote: > > > > On Sat, Dec 29, 2007 at 10:

Re: [2.6 patch] remove broken MTD drivers

2008-01-01 Thread Adrian Bunk
On Wed, Jan 02, 2008 at 01:28:26AM +0100, Wolfgang Denk wrote: > In message <[EMAIL PROTECTED]> you wrote: > > > > The header of ppchameleonevb.c claims it comes from [EMAIL PROTECTED] > > Argh. That's indeed ancient code. > > So what should I do to fix this? Wait for Thomas' response, or port >

Re: [PATCH] [2.6.24] Add PPC nvram ioctls to compat_ioctl

2008-01-01 Thread Arnd Bergmann
On Monday 31 December 2007, Olof Johansson wrote: > Fix the following console warning when running 'nvsetenv', and makes > setting of new variables work again: > > ioctl32(nvsetenv:4022): Unknown cmd fd(3) cmd(20007043){t:'p';sz:0} > arg(0003) on /dev/nvram > > That's the IOC_NVRAM_SYNC call.

Re: [2.6 patch] remove broken MTD drivers

2008-01-01 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > > The header of ppchameleonevb.c claims it comes from [EMAIL PROTECTED] Argh. That's indeed ancient code. So what should I do to fix this? Wait for Thomas' response, or port patches here? Best regards, Wolfgang Denk -- DENX Software Engineering Gmb

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override.

2008-01-01 Thread Rene Herman
On 02-01-08 00:11, Rene Herman wrote: On 01-01-08 23:39, H. Peter Anvin wrote: Yes, we do. It's exactly this side effect which makes this safer than either 0x80 or 0xED -- it's a port that *guaranteed* can't be reclaimed for other purposes without breaking MS-DOS compatibility. I see that

Re: [Suspend2-devel] Reboot problem

2008-01-01 Thread Christian Hesse
On Wednesday 02 January 2008, Nigel Cunningham wrote: > Hi Christian. > > Christian Hesse wrote: > > On Tuesday 01 January 2008, Nigel Cunningham wrote: > >> Third, regarding the patch itself, I'm taking my time in working towards > >> the 3.0 release. We don't have any major bugs with 3.0-rc3 repo

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override.

2008-01-01 Thread Christer Weinigel
On Tue, 1 Jan 2008 23:12:50 + Alan Cox <[EMAIL PROTECTED]> wrote: > > Besides the above there are only a handful of _p uses outside of > > real ISA device drivers, and those should not be relevant for a > > modern PC unless somebody wants to use an 8390 based PCMCIA card, > > but we could tell

[BUG] crash - module radio-sf16fmr2 and esp interfere

2008-01-01 Thread devzero
same with radio-sf16fmr2 and esp after repeatedly modrpobe/modprobe -r radio-sf16fmr2, i can hang my system when loading esp afterwards before loading esp, doing a "cat /proc/ioport" segfaults this is with 2.6.24rc6 and also with 2.6.22 i have found these issues by running some (probably sic

Re: [PATCH 1/3] arch/powerpc/platforms/pseries: Add missing of_node_put

2008-01-01 Thread Stephen Rothwell
On Tue, 1 Jan 2008 22:02:49 +0100 (CET) Julia Lawall <[EMAIL PROTECTED]> wrote: > > From: Julia Lawall <[EMAIL PROTECTED]> > > Of_get_parent and of_find_compatible_node do an of_node_get, and thus a > corresponding of_code_put is needed in the error case. Thanks for these. In the future, any pat

Re: [2.6 patch] remove CONFIG_EXPERIMENTAL

2008-01-01 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 05:35:32PM +, Alan Cox wrote: > > So smbfs is still considered rock solid while no serious distribution > > would be crazy enough to ship the EXPERIMENTAL NFSv4 support to their > > customers? > > Thats a different problem. The kernel as I've said many times has no >

Re: [Suspend2-devel] Reboot problem

2008-01-01 Thread Nigel Cunningham
Hi Christian. Christian Hesse wrote: > On Tuesday 01 January 2008, Nigel Cunningham wrote: >> Third, regarding the patch itself, I'm taking my time in working towards >> the 3.0 release. We don't have any major bugs with 3.0-rc3 reported [...]. > > Well, I think I still have a bug, though it is p

Re: [2.6 patch] the scheduled 'time' option removal

2008-01-01 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 06:53:54PM +0100, Jan Engelhardt wrote: > > On Jan 1 2008 15:46, Adrian Bunk wrote: > >index 20c4c8b..93aac19 100644 > >--- a/Documentation/feature-removal-schedule.txt > >+++ b/Documentation/feature-removal-schedule.txt > >@@ -233,10 +233,2 @@ Who:Jean Delvare <[EMAIL

Freezing filesystems (Was Re: What's in store for 2008 for TuxOnIce?)

2008-01-01 Thread Nigel Cunningham
Hi. Rafael J. Wysocki wrote: > On Tuesday, 1 of January 2008, Nigel Cunningham wrote: >> Hi all. > > Hi Nigel, Gidday :) >> With the start of a new year, I suppose it's a good time to think about >> what I'd like to do with TuxOnIce this year and see what feedback I get. >> >> First up, I'm thi

Reboot problem (was: Re: [Suspend2-devel] What's in store for 2008 for TuxOnIce?)

2008-01-01 Thread Christian Hesse
On Tuesday 01 January 2008, Nigel Cunningham wrote: > Third, regarding the patch itself, I'm taking my time in working towards > the 3.0 release. We don't have any major bugs with 3.0-rc3 reported [...]. Well, I think I still have a bug, though it is possibly a mainline problem and it's not a sho

Re: [2.6 patch] CIFS: #if 0 mode_to_access_flags()

2008-01-01 Thread Steve French
The cifsacl code which uses that function was not ready in time for 2.6.24 but is in the cifs development tree now.. On Jan 1, 2008 12:10 PM, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Tue, Jan 01, 2008 at 03:46:44PM +0200, Adrian Bunk wrote: > > This patch #if 0's the unused mode_to_access

[PATCH 1/4] PM: Introduce destroy_suspended_device()

2008-01-01 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> It sometimes is necessary to destroy a device object during a suspend or hibernation, but the PM core is supposed to control all device objects in that cases. For this reason, it is necessary to introduce a mechanism allowing one to ask the PM core to r

[PATCH 2/4] PM: Do not destroy/create devices while suspended in msr.c (rev. 2)

2008-01-01 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> The MSR driver should not attempt to destroy/create a device while suspended, unless this device corresponds to a nonboot CPU that failed to go online during a resume, in which case the PM core should be asked to remove it. Signed-off-by: Rafael J. Wyso

[PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2)

2008-01-01 Thread Rafael J. Wysocki
Hi, Some device drivers register CPU hotplug notifiers and use them to destroy device objects when removing the corresponding CPUs and to create these objects when adding the CPUs back. Unfortunately, this is not the right thing to do during suspend/hibernation, since in that cases the CPU hotplu

[PATCH 4/4] PM: Do not destroy/create devices while suspended in cpuid.c

2008-01-01 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> The cpuid driver should not attempt to destroy/create a device while suspended, unless this device corresponds to a nonboot CPU that failed to go online during a resume, in which case the PM core should be asked to remove it. Signed-off-by: Rafael J. Wy

[PATCH 3/4] PM: Do not destroy/create devices while suspended in mce_64.c

2008-01-01 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> The x86-64 MCE driver should not attempt to destroy/create a suspended device, unless it corresponds to a nonboot CPU that failed to go online during a resume. Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/mcheck/mce_64.c

Re: [PATCH] Hibernation: Document __save_processor_state() on x86-64 (rev. 2)

2008-01-01 Thread Rafael J. Wysocki
On Wednesday, 2 of January 2008, Pavel Machek wrote: > On Sun 2007-12-30 23:13:51, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > Document the fact that __save_processor_state() has to save all CPU > > registers referred to by the kernel in case a different kernel

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override.

2008-01-01 Thread Alan Cox
> Besides the above there are only a handful of _p uses outside of real > ISA device drivers, and those should not be relevant for a modern PC > unless somebody wants to use an 8390 based PCMCIA card, but we could > tell them "don't do that then". We need to build 8390.c twice anyway - once for PC

Re: [PATCH linux-acpi] Correct wakeup set error and append a new column PCI ID

2008-01-01 Thread Pavel Machek
Hi! > /proc/acpi/wakeup is also case-sensitive, case-insensitive is better. Why? > In addtion, this patch appends a new column 'PCI ID' to /proc/acpi/wakeup > , the user can use it to get the corresponding device name very > conveniently because PCI ID is a unique identifier and platform-indepen

Re: What's in store for 2008 for TuxOnIce?

2008-01-01 Thread Rafael J. Wysocki
On Tuesday, 1 of January 2008, Nigel Cunningham wrote: > Hi all. Hi Nigel, > With the start of a new year, I suppose it's a good time to think about > what I'd like to do with TuxOnIce this year and see what feedback I get. > > First up, I'm thinking about closing the mailing lists and asking pe

Re: [PATCH] x86_64: clear IO_APIC before enabing apic error vector. v2

2008-01-01 Thread Adrian Bunk
On Sun, Dec 30, 2007 at 05:03:50PM -0800, Yinghai Lu wrote: > On Dec 30, 2007 4:28 PM, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > On Sun, Dec 30, 2007 at 04:01:39PM -0800, Yinghai Lu wrote: >... > > > the old one is in x86-mm tree > > > > > > http://git.kernel.org/?p=linux/kernel/git/x86/linux-

Re: [PATCH] x86_64: clear IO_APIC before enabing apic error vector. v2

2008-01-01 Thread Adrian Bunk
On Sun, Dec 30, 2007 at 04:56:35PM -0800, Yinghai Lu wrote: > On Dec 30, 2007 4:28 PM, Adrian Bunk <[EMAIL PROTECTED]> wrote: >... > > Sorry for the dumb question, but what in > > > > + if (!smp_processor_id() && !skip_ioapic_setup && nr_ioapics) > > + enable_IO_APIC(); > > > >

Re: [2.6 patch] OSS msnd: fix array overflows

2008-01-01 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 07:43:23PM +0100, Oliver Pinter (Pintér Olivér) wrote: > then it is auch to 2.6.22-stable? That's a very old bug in a driver for ancient hardware, so there's no need to hurry. > On 1/1/08, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > This patch fixes array overflows in the

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override.

2008-01-01 Thread Rene Herman
On 01-01-08 23:39, H. Peter Anvin wrote: Yes, we do. It's exactly this side effect which makes this safer than either 0x80 or 0xED -- it's a port that *guaranteed* can't be reclaimed for other purposes without breaking MS-DOS compatibility. I see that with CR0.NE set (*) we indeed don't care

Re: [2.6 patch] remove broken MTD drivers

2008-01-01 Thread Wolfgang Denk
In message <[EMAIL PROTECTED]> you wrote: > This patch removes two MTD drivers that have been marked as > BROKEN 19 months ago due to requiring nonexisting header files. ... > drivers/mtd/nand/Kconfig | 12 > drivers/mtd/nand/Makefile |2 > drivers/mtd/nand/ppchameleonevb.

Re: [2.6 patch] remove broken MTD drivers

2008-01-01 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 04:30:57PM +, David Woodhouse wrote: > On Tue, 2008-01-01 at 15:48 +0200, Adrian Bunk wrote: > > This patch removes two MTD drivers that have been marked as > > BROKEN 19 months ago due to requiring nonexisting header files. > > > > Signed-off-by: Adrian Bunk <[EMAIL PR

  1   2   3   4   >