Re: [PATCH 3/4] [SCSI] ips: PCI API cleanups

2007-10-24 Thread Rolf Eike Beer
Jeff Garzik wrote: > * pass Scsi_Host to ips_remove_device() via pci_set_drvdata(), > allowing us to eliminate the ips_ha[] search loop and call > ips_release() directly. > > * call pci_{request,release}_regions() and eliminate individual > request/release_[mem_]region() calls > > * call pci_

Re: [PATCH 0/2] add new notifier function ,take2

2007-10-24 Thread Takenori Nagano
Nick Piggin wrote: >>> Is it possible to use a single bit of common code and a single >>> notifier for these things? Or is it too difficult? >> > >> > I'm sorry, I can't understand your image well. I'd like to know details of >> > your image. > > Rather than have each of "RAS tools" have their own

Re: [PATCH 1/3] iwl3945 & iwl4965: mark more functions/variables static

2007-10-24 Thread Zhu Yi
On Fri, 2007-10-12 at 14:32 +0200, Christoph Hellwig wrote: > int iwl_param_disable; /* def: enable radio */ > int iwl_param_antenna; /* def: 0 = both antennas (use diversity) > */ > int iwl_param_hwcrypto; /* def: using software encryption */ > -int iwl_param_qos_enable = 1; > +s

Re: [PATCH 2.6.24-rc1] fix sg_phys to use dma_addr_t

2007-10-24 Thread Hugh Dickins
On Wed, 24 Oct 2007, Arjan van de Ven wrote: > > Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> > > --- > > Whether this is a complete patch, suitable for all architectures, > > I'm not sure: it builds, boots and runs correctly on the x86_32 box > > in question, but you'll be a lot wiser than me a

Re: [PATCH+comment] fix tmpfs BUG and AOP_WRITEPAGE_ACTIVATE

2007-10-24 Thread Hugh Dickins
On Thu, 25 Oct 2007, Pekka Enberg wrote: > On 10/25/07, Hugh Dickins <[EMAIL PROTECTED]> wrote: > > --- 2.6.24-rc1/mm/shmem.c 2007-10-24 07:16:04.0 +0100 > > +++ linux/mm/shmem.c2007-10-24 22:31:09.0 +0100 > > @@ -915,6 +915,21 @@ static int shmem_writepage(struct page * >

Re: [git pull] lguest: paravirt boot code

2007-10-24 Thread Stephen Rothwell
On Thu, 25 Oct 2007 15:19:05 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > So, this time for sure! I haven't figured out how everyone does those neat > committer: commits* lists, but I'm sure there's an option here somewhere... try "git request-pull ..." -- Cheers, Stephen Rothwell

Re: sysfs sys/kernel/ namespace (was Re: [PATCH 0/2] add new notifier function ,take2)

2007-10-24 Thread Nick Piggin
On Thursday 25 October 2007 15:45, Greg KH wrote: > On Thu, Oct 25, 2007 at 12:31:06PM +1000, Nick Piggin wrote: > > On Wednesday 24 October 2007 21:12, Kay Sievers wrote: > > > On 10/24/07, Nick Piggin <[EMAIL PROTECTED]> wrote: > > > It was intended to be something like /proc/sys/kernel/ only. >

Re: [RFC - GIT pull] first step to get rid of x86_64 and i386 dirs

2007-10-24 Thread Yinghai Lu
On 10/24/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Wed, 24 Oct 2007 23:30:52 +0200 Sam Ravnborg wrote: > > > Hi Ingo. > > > > This is first step in getting rid of the two directories. > > I had to do some very minor modifications in common files > > to let it work out - but nothing really ha

Exporting a lot of data to other processes?

2007-10-24 Thread Ph. Marek
Hello everybody, I've already pondered about a question for some time, and would like to ask for a better idea here. It's not entirely about the kernel - although that surely has some impact, too. I've got some process/daemon, that wants to export information to other processes. As model for

Re: [git patches] IDE updates (part 2)

2007-10-24 Thread Jeff Garzik
Al Viro wrote: Proposed addition to icside part, provided that ARM folks ACK it - gets icside to build and AFAICS it's correct: diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c index be30923..842fe08 100644 --- a/drivers/ata/pata_icside.c +++ b/drivers/ata/pata_icside.c @@ -332

Re: [2.6 patch] libata-core.c: make 2 functions static

2007-10-24 Thread Jeff Garzik
Adrian Bunk wrote: strn_pattern_cmp() and ata_port_detach() can become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) applied - To unsubscribe from this list: send the line "unsubscribe linu

Re: [Bugme-new] [Bug 9217] New: CONFIG_CMDLINE doesn't pass to kernel

2007-10-24 Thread mwester
On Wed, 24 Oct 2007 05:32:14 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9217 > >            Summary: CONFIG_CMDLINE doesn't pass to kernel >            Product: Other >            Version: 2.5 >      KernelVersion: 2.6.23 >           Platform: All >      

Re: sysfs sys/kernel/ namespace (was Re: [PATCH 0/2] add new notifier function ,take2)

2007-10-24 Thread Greg KH
On Thu, Oct 25, 2007 at 12:31:06PM +1000, Nick Piggin wrote: > On Wednesday 24 October 2007 21:12, Kay Sievers wrote: > > On 10/24/07, Nick Piggin <[EMAIL PROTECTED]> wrote: > > > On Tuesday 23 October 2007 10:55, Takenori Nagano wrote: > > > > Nick Piggin wrote: > > > > > One thing I'd suggest is

Re: [PATCH] ata: ahci: Enable enclosure management via LED (resend)

2007-10-24 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Enable enclosure management via LED As described in the AHCI spec, some AHCI controllers may support Enclosure management via a variety of protocols. This patch adds support for the LED message type that is specified in AHCI 1.1 and higher. Signed-off-by: Kri

Re: 2.6.24-rc1 oops

2007-10-24 Thread FUJITA Tomonori
Jens, I should have CC'ed to you. On Thu, 25 Oct 2007 10:22:02 +0900 FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > On Thu, 25 Oct 2007 01:40:00 +0100 > Sid Boyce <[EMAIL PROTECTED]> wrote: > > > x86_64 dual, gcc version 4.2.2 (SUSE Linux). > > [ cut here ] > > kernel BUG a

Re: [patch 0/3] MBCS: Convert semaphores to the mutex API

2007-10-24 Thread Matthias Kaehlcke
El Wed, Oct 24, 2007 at 09:11:49PM -0700 Andrew Morton ha dit: > On Wed, 24 Oct 2007 19:08:58 +0200 [EMAIL PROTECTED] wrote: > > > MBCS: Convert the semaphores algolock, dmareadlock and dmawritelock to the > > mutex API > > Thanks. Has this actually been runtime-tested? no, i could only test

Re: [PATCH] Input: Support for a less exclusive grab.

2007-10-24 Thread Ryan Lortie
On Wed, 2007-24-10 at 11:35 -0400, Zephaniah E. Hull wrote: > We need a way to, at the absolute minimum, unbind the keyboard from the > text console. The current solution sucks for things like rfkill. > > I'm not convinced that Ryan's fix is any better, but just saying that X > should open the co

Re: [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks.

2007-10-24 Thread Jeff Garzik
David Miller wrote: The forthcoming patches are also available from: kernel.org:/pub/scm/linux/kernel/git/davem/msiquirk-2.6.git and clean up the handling of the common quirk wherein setting INTX_DISABLE will mistakedly disable MSI generation for some devices. For devices without that

Re: [PATCH+comment] fix tmpfs BUG and AOP_WRITEPAGE_ACTIVATE

2007-10-24 Thread Pekka Enberg
Hi Hugh, On 10/25/07, Hugh Dickins <[EMAIL PROTECTED]> wrote: > --- 2.6.24-rc1/mm/shmem.c 2007-10-24 07:16:04.0 +0100 > +++ linux/mm/shmem.c2007-10-24 22:31:09.0 +0100 > @@ -915,6 +915,21 @@ static int shmem_writepage(struct page * > struct inode *inode; > >

Re: [patch 2/2] Enable Aggressive Link Power management for AHCI controllers.

2007-10-24 Thread Jeff Garzik
Kristen Carlson Accardi wrote: This patch will set the correct bits to turn on Aggressive Link Power Management (ALPM) for the ahci driver. This will cause the controller and disk to negotiate a lower power state for the link when there is no activity (see the AHCI 1.x spec for details). This f

Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers

2007-10-24 Thread Jens Axboe
On Thu, Oct 25 2007, FUJITA Tomonori wrote: > On Wed, 24 Oct 2007 21:38:30 +0530 > Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > > > FUJITA Tomonori wrote: > > > On Wed, 24 Oct 2007 12:54:36 +0100 > > > Andy Whitcroft <[EMAIL PROTECTED]> wrote: > > > > > >> On Tue, Oct 23, 2007 at 08:44:20PM +020

Re: [2.6 patch] fujitsu-laptop.c: remove dead code

2007-10-24 Thread Jonathan Woithe
> This patch removes dead code spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Ack. Signed-off-by: Jonathan Woithe <[EMAIL PROTECTED]> jonathan --- --- linux-2.6/drivers/misc/fujitsu-laptop.c.old 2007-10-23 18:51:10.0 +0200 +++ linux-2.6/drivers/mis

Re: [2.6 patch] fujitsu-laptop.c: make 2 functions static

2007-10-24 Thread Jonathan Woithe
> acpi_fujitsu_{add,remove}() can become static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Looks fine. Ack. Signed-off-by: Jonathan Woithe <[EMAIL PROTECTED]> jonathan --- drivers/misc/fujitsu-laptop.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) 175c8b648a54b625037

Re: 2.6.24-rc1 doesn't build...

2007-10-24 Thread Kamalesh Babulal
Theodore Tso wrote: > I can't seem to get 2.6.24-rc1 to build: > > ... > LD .tmp_vmlinux1 > arch/x86/kernel/built-in.o: In function `smp_send_nmi_allbutself': > /usr/projects/linux/linux-2.6/arch/x86/kernel/crash.c:85: undefined reference > to `genapic' > make: *** [.tmp_vmlinux1] Error

Re: [patch 1/2] Enable link power management for ata drivers

2007-10-24 Thread Jeff Garzik
applied as the attached two patches to jgarzik/libata-dev.git#alpm open issues: 1) need to check ata_dev_set_feature() return value in ata_dev_set_dipm() and do something useful with it 2) as the name implies, this probably better belongs in ata_link. 3) however, the feature is tightly coupl

Re: [git pull] lguest: paravirt boot code

2007-10-24 Thread Rusty Russell
On Wednesday 24 October 2007 02:10:21 Linus Torvalds wrote: > On Tue, 23 Oct 2007, Rusty Russell wrote: > > Well, with that out the way, and some scatterlist fixups, please pull > > from > > > > git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-lguest.git > > Ok. However, please inc

Re: [PATCH] napi: use non-interruptible sleep in napi_disable

2007-10-24 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: The current napi_disable() uses msleep_interruptible() but doesn't (and can't) exit in case there's a signal, thus ending up doing a hot spin without a cpu_relax. Use uninterruptible sleep instead. Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- incl

Re: [PATCH 1/4] [SCSI] ips: remove ips_ha members that duplicate struct pci_dev members

2007-10-24 Thread Jeff Garzik
Andrew Morton wrote: On Wed, 24 Oct 2007 19:48:26 -0400 (EDT) Jeff Garzik <[EMAIL PROTECTED]> wrote: drivers/scsi/ips.c | 178 this driver seems a bit of a basket case :( What's going on here? scb->dcdb.cmd_attribute =

Re: Is gcc thread-unsafe?

2007-10-24 Thread Nick Piggin
Hi David, [BTW. can you retain cc lists, please?] On Thursday 25 October 2007 14:29, David Schwartz wrote: > > Well that's exactly right. For threaded programs (and maybe even > > real-world non-threaded ones in general), you don't want to be > > even _reading_ global variables if you don't need

Re: Sky2 Driver Issue

2007-10-24 Thread Stephen Hemminger
On Wed, 24 Oct 2007 19:06:37 +0100 "Tom Spink" <[EMAIL PROTECTED]> wrote: > On 24/10/2007, Tom Spink <[EMAIL PROTECTED]> wrote: > > Hi, > > > > A couple of kernels ago, I ran into an issue with the sky2 driver. > > Basically, I began getting repeated errors on my console of the > > following: > >

Re: Is gcc thread-unsafe?

2007-10-24 Thread Arjan van de Ven
On Wed, 24 Oct 2007 21:29:56 -0700 "David Schwartz" <[EMAIL PROTECTED]> wrote: > > > Well that's exactly right. For threaded programs (and maybe even > > real-world non-threaded ones in general), you don't want to be > > even _reading_ global variables if you don't need to. Cache misses > > and c

Re: [patch 2.6.24-rc1] resource_len() utility function

2007-10-24 Thread David Brownell
On Wednesday 24 October 2007, Jeff Garzik wrote: > >> Then a dev_iomap() analogue to pci_iomap() should be pretty > >> straightforward to create. > > > > Another minor nit:  addressing the various resource types. > > The platform bus code has multiple lookup schemes. > > > > Calls like resource

RE: Is gcc thread-unsafe?

2007-10-24 Thread David Schwartz
> Well that's exactly right. For threaded programs (and maybe even > real-world non-threaded ones in general), you don't want to be > even _reading_ global variables if you don't need to. Cache misses > and cacheline bouncing could easily cause performance to completely > tank in some cases while

Re: [PATCH 1/4] [SCSI] ips: remove ips_ha members that duplicate struct pci_dev members

2007-10-24 Thread Andrew Morton
On Wed, 24 Oct 2007 19:48:26 -0400 (EDT) Jeff Garzik <[EMAIL PROTECTED]> wrote: > drivers/scsi/ips.c | 178 > this driver seems a bit of a basket case :( What's going on here? scb->dcdb.cmd_attribute = i

Re: [PATCH 4/5] Add lock_page_killable

2007-10-24 Thread Nick Piggin
On Thursday 25 October 2007 14:11, Andrew Morton wrote: > On Wed, 24 Oct 2007 08:24:57 -0400 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > and associated infrastructure such as sync_page_killable and > > fatal_signal_pending. Use lock_page_killable in > > do_generic_mapping_read() to allow us to k

Re: [patch 2/2] Use BOOTMEM_EXCLUSIVE for kdump

2007-10-24 Thread Paul Mundt
On Wed, Oct 24, 2007 at 09:05:33PM -0700, Andrew Morton wrote: > On Wed, 24 Oct 2007 18:37:35 +0200 Bernhard Walle <[EMAIL PROTECTED]> wrote: > > This patch uses the BOOTMEM_EXCLUSIVE, introduced in the previous patch, > > to avoid conflicts while reserving the memory for the kdump carpture kernel

QUESTION: How to fix race between .suspend routine and watchdog timer

2007-10-24 Thread Maxim Levitsky
Hi, Recently, trying to fix saa7134 suspend/resume problems I found that there is a race between IRQ handler and .suspend , and that I cant let driver access the device while its in D3 since it can lock up some systems. Now I am looking to fix those issues in two drivers that have my .suspend/

Re: [patch 0/3] MBCS: Convert semaphores to the mutex API

2007-10-24 Thread Andrew Morton
On Wed, 24 Oct 2007 19:08:58 +0200 [EMAIL PROTECTED] wrote: > MBCS: Convert the semaphores algolock, dmareadlock and dmawritelock to the > mutex API Thanks. Has this actually been runtime-tested? btw, your patches are in `patch -p2' form: --- kernel.orig/linux-2.6/drivers/char/mbcs.c +++ kern

Re: [PATCH 4/5] Add lock_page_killable

2007-10-24 Thread Andrew Morton
On Wed, 24 Oct 2007 08:24:57 -0400 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > and associated infrastructure such as sync_page_killable and > fatal_signal_pending. Use lock_page_killable in do_generic_mapping_read() > to allow us to kill `cat' of a file on an NFS-mounted filesystem. whoa, big ch

Re: How to debug complete kernel lock-ups

2007-10-24 Thread Grant Grundler
On Wed, Oct 24, 2007 at 11:17:40AM +0200, John Sigler wrote: ... > I've tested with a vanilla 2.6.22.10 kernel (no PREEMPT_RT patch). > That system also locks up and remains completely unresponsive (I can't open > new ssh sessions, the system won't answer ICMP echo requests). > > How do driver wri

Re: [Bugme-new] [Bug 9217] New: CONFIG_CMDLINE doesn't pass to kernel

2007-10-24 Thread Bill Gatliff
Andrew Morton wrote: Something broke CONFIG_CMDLINE of ARM (at least) between 2.6.22 and 2.6.23. I don't know whether it was an ARM patch one of those kernel-wide changes. We have futzed with the command-line parsing a bit recently, but the 2.6.23 changelog doesn't suggest anything obvious.

Re: Is gcc thread-unsafe?

2007-10-24 Thread Nick Piggin
On Thursday 25 October 2007 13:46, Arjan van de Ven wrote: > On Thu, 25 Oct 2007 13:24:49 +1000 > > Nick Piggin <[EMAIL PROTECTED]> wrote: > > Hi, > > > > Andi spotted this exchange on the gcc list. I don't think he's > > brought it up here yet, but it worries me enough that I'd like > > to discuss

Re: [patch 2/2] Use BOOTMEM_EXCLUSIVE for kdump

2007-10-24 Thread Andrew Morton
On Wed, 24 Oct 2007 18:37:35 +0200 Bernhard Walle <[EMAIL PROTECTED]> wrote: > This patch uses the BOOTMEM_EXCLUSIVE, introduced in the previous patch, > to avoid conflicts while reserving the memory for the kdump carpture kernel > (crashkernel=). > > > Signed-off-by: Bernhard Walle <[EMAIL PROT

Re: [PATCH 0/5] TASK_KILLABLE

2007-10-24 Thread Nick Piggin
On Friday 19 October 2007 08:25, Matthew Wilcox wrote: > This series of patches introduces the facility to deliver only fatal > signals to tasks which are otherwise waiting uninterruptibly. This is pretty nice I think. It also is a significant piece of infrastructure required to fix some of the m

Re: [PATCH 5/5] Make wait_on_retry_sync_kiocb killable

2007-10-24 Thread Nick Piggin
On Friday 19 October 2007 08:26, Matthew Wilcox wrote: > Use TASK_KILLABLE to allow wait_on_retry_sync_kiocb to return -EINTR. > All callers then check the return value and break out of their loops. > > Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> > --- > fs/read_write.c | 17 --

[PATCH] napi: use non-interruptible sleep in napi_disable

2007-10-24 Thread Benjamin Herrenschmidt
The current napi_disable() uses msleep_interruptible() but doesn't (and can't) exit in case there's a signal, thus ending up doing a hot spin without a cpu_relax. Use uninterruptible sleep instead. Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> --- include/linux/netdevice.h |2 +-

Re: [PATCH 0/5] Detect hwmon and i2c bus drivers interfering with ACPI Operation Region resources

2007-10-24 Thread Andrew Morton
On Wed, 24 Oct 2007 16:31:59 +0200 Thomas Renninger <[EMAIL PROTECTED]> wrote: > it seems Len's test tree and Linus tree diverged a bit, at least with > this patch set things do not apply cleanly. > > Therefore I post these for discussion whether and in which kernel tree > they should end up befo

Re: [PATCH 2/5] Use macros instead of TASK_ flags

2007-10-24 Thread Nick Piggin
On Friday 19 October 2007 08:25, Matthew Wilcox wrote: > Abstracting away direct uses of TASK_ flags allows us to change the > definitions of the task flags more easily. > > Also restructure do_wait() a little > > Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> > --- > arch/ia64/kernel/perfmon.c

Re: [Fwd: [PATCH 3/5] Export acpi_check_resource_conflict]

2007-10-24 Thread Andrew Morton
On Wed, 24 Oct 2007 16:33:07 +0200 Thomas Renninger <[EMAIL PROTECTED]> wrote: > From: Thomas Renninger <[EMAIL PROTECTED]> > To: linux-acpi <[EMAIL PROTECTED]> > Cc: linux-kernel , Len Brown <[EMAIL > PROTECTED]>, Andrew Morton <[EMAIL PROTECTED]>, Jean Delvare <[EMAIL > PROTECTED]> > Reply-To:

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-24 Thread Kyle Moffett
On Oct 24, 2007, at 17:37:04, Serge E. Hallyn wrote: The scariest thing to consider is programs which don't appropriately handle failure. So I don't know, maybe the system runs a remote logger to which the multiadm policy gives some extra privs, but now the portac module prevents it from se

Re: Is gcc thread-unsafe?

2007-10-24 Thread Arjan van de Ven
On Thu, 25 Oct 2007 13:24:49 +1000 Nick Piggin <[EMAIL PROTECTED]> wrote: > Hi, > > Andi spotted this exchange on the gcc list. I don't think he's > brought it up here yet, but it worries me enough that I'd like > to discuss it. > > Starts here > http://gcc.gnu.org/ml/gcc/2007-10/msg00266.html >

Re: [patch 2.6.24-rc1] resource_len() utility function

2007-10-24 Thread Jeff Garzik
David Brownell wrote: On Wednesday 24 October 2007, Jeff Garzik wrote: With regards to resource reservation... IMO we should mimic struct pci_dev and add struct resource[] to struct device. One minor difficulty: PCI has a limit on the number of BARs, but other busses don't. It'd be better a

[PATCH 1/2] [NetLabel] Introduce a new kernel configuration API for NetLabel - Version 9 (2.6.24-rc1) Smack: Simplified Mandatory Access Control Kernel

2007-10-24 Thread Casey Schaufler
From: Paul Moore <[EMAIL PROTECTED]> Add a new set of configuration functions to the NetLabel/LSM API so that LSMs can perform their own configuration of the NetLabel subsystem without relying on assistance from userspace. Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- include/net/netlabel.h

[PATCH 0/2] Version 9 (2.6.24-rc1) Smack: Simplified Mandatory Access Control Kernel

2007-10-24 Thread Casey Schaufler
The Smack patch and Paul Moore's netlabel API patch, together for 2.6.24-rc1. Paul's changes are identical to the previous posting, but it's been a while so they're here again. The sole intent of change has been to address locking and/or list processing issues. Please don't hesitate to point out

Re: [PATCH 5/5] Make wait_on_retry_sync_kiocb killable

2007-10-24 Thread Andrew Morton
On Wed, 24 Oct 2007 08:24:58 -0400 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > Use TASK_KILLABLE to allow wait_on_retry_sync_kiocb to return -EINTR. > All callers then check the return value and break out of their loops. > Let's cc the AIO list on AIO patches, please. > --- > fs/read_write.c |

Re: Quad core CPU detected but shows as single core in 2.6.23.1

2007-10-24 Thread Chris Snook
Zurk Tech wrote: Hi guys, I have a tyan s3992 h2000 with single barcelona amd quad core cpu (the other cpu socket is empty). cat /proc/cpuinfo shows amd quad core processor but core : 1ive compiled the kernel from scratch with smp and amd64 + the numa stuff. i also tried debian etchs amd64 sm

Is gcc thread-unsafe?

2007-10-24 Thread Nick Piggin
Hi, Andi spotted this exchange on the gcc list. I don't think he's brought it up here yet, but it worries me enough that I'd like to discuss it. Starts here http://gcc.gnu.org/ml/gcc/2007-10/msg00266.html Concrete example here http://gcc.gnu.org/ml/gcc/2007-10/msg00275.html Basically, what the

Re: [PATCH 2/5] Use macros instead of TASK_ flags

2007-10-24 Thread Andrew Morton
On Wed, 24 Oct 2007 08:24:55 -0400 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > Abstracting away direct uses of TASK_ flags allows us to change the > definitions of the task flags more easily. > > Also restructure do_wait() a little umm, spose so. There's an excellent chance that a millionth of

Re: USB: FIx locks and urb->status in adutux

2007-10-24 Thread Pete Zaitcev
BTW, the patch in my previous message had one buglet - an extra remove_wait_queue. It was in an error case though, so it should be ok to test. But just in case, here's a fixed one. -- Pete diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index c567aa7..6914c0b 100644 --- a/drive

Re: [PATCH 1/4] stringbuf: A string buffer implementation

2007-10-24 Thread Matthew Wilcox
On Wed, Oct 24, 2007 at 08:07:23PM -0400, Kyle Moffett wrote: > No, the problem is what happens when you don't have enough space > allocated: you call "vsnprintf(s, len, format, args);" and then > later call "vsprintf(s, format, args);" with the *SAME* "args". > That's what's broken. Ah, g

Re: USB: FIx locks and urb->status in adutux

2007-10-24 Thread Pete Zaitcev
On Wed, 24 Oct 2007 17:09:47 +0300, Vitaliy Ivanov <[EMAIL PROTECTED]> wrote: > > static void adu_abort_transfers(struct adu_device *dev) > > { > ... > > + mutex_lock(&dev->mtx); > ... > > + mutex_unlock(&dev->mtx); > > > } > > Don't you think it's needed? You call adu_abort_transfers fr

Re: [2.6 patch] blackfin: "extern inline" -> "static inline"

2007-10-24 Thread Mike Frysinger
On 10/24/07, H. Peter Anvin <[EMAIL PROTECTED]> wrote: > Mike Frysinger wrote: > > On 10/24/07, Jie Zhang <[EMAIL PROTECTED]> wrote: > >> On 10/25/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > >>> "extern inline" will have different semantics with gcc 4.3. > >>> > >>> Signed-off-by: Adrian Bunk <[EM

Using -traditional in EXTRA_AFLAGS

2007-10-24 Thread Glauber de Oliveira Costa
Guys, is there any particular reason we're using -traditional in EXTRA_AFLAGS in Makefiles? According to http://gcc.gnu.org/onlinedocs/cpp/Traditional-macros.html#Traditional-macros, (and to my painful recent experience), it disallows the use of token pasting in pre-processor macros, which is a f

Re: SLUB 0:1 SLAB (OOM during massive parallel kernel builds)

2007-10-24 Thread Nick Piggin
On Thursday 25 October 2007 12:43, Christoph Lameter wrote: > On Thu, 25 Oct 2007, Nick Piggin wrote: > > > Ummm... all unreclaimable is set! Are you mlocking the pages in memory? > > > Or what causes this? All pages under writeback? What is the dirty ratio > > > set to? > > > > Why is SLUB behavin

Re: Quad core CPU detected but shows as single core in 2.6.23.1

2007-10-24 Thread Arjan van de Ven
On Wed, 24 Oct 2007 23:02:14 -0400 "Zurk Tech" <[EMAIL PROTECTED]> wrote: > Hi guys, > I have a tyan s3992 h2000 with single barcelona amd quad core cpu (the > other cpu socket is empty). cat /proc/cpuinfo shows amd quad core > processor > but core : 1ive compiled the kernel from scratch with

Re: [2.6 patch] blackfin: "extern inline" -> "static inline"

2007-10-24 Thread H. Peter Anvin
Mike Frysinger wrote: On 10/24/07, Jie Zhang <[EMAIL PROTECTED]> wrote: On 10/25/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: "extern inline" will have different semantics with gcc 4.3. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- a/include/asm-blackfin/string.h +++ b/include/asm-blackfin

Re: [Bugme-new] [Bug 9217] New: CONFIG_CMDLINE doesn't pass to kernel

2007-10-24 Thread Andrew Morton
On Wed, 24 Oct 2007 05:32:14 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9217 > >Summary: CONFIG_CMDLINE doesn't pass to kernel >Product: Other >Version: 2.5 > KernelVersion: 2.6.23 > Platform: All >

Quad core CPU detected but shows as single core in 2.6.23.1

2007-10-24 Thread Zurk Tech
Hi guys, I have a tyan s3992 h2000 with single barcelona amd quad core cpu (the other cpu socket is empty). cat /proc/cpuinfo shows amd quad core processor but core : 1ive compiled the kernel from scratch with smp and amd64 + the numa stuff. i also tried debian etchs amd64 smp kernel and same r

Re: [2.6 patch] blackfin: "extern inline" -> "static inline"

2007-10-24 Thread Mike Frysinger
On 10/24/07, Jie Zhang <[EMAIL PROTECTED]> wrote: > On 10/25/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > "extern inline" will have different semantics with gcc 4.3. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > > --- a/include/asm-blackfin/string.h > > +++ b/include/asm-blackfin/s

Re: [2.6 patch] blackfin: "extern inline" -> "static inline"

2007-10-24 Thread Jie Zhang
On 10/25/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > "extern inline" will have different semantics with gcc 4.3. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- a/include/asm-blackfin/string.h > +++ b/include/asm-blackfin/string.h > @@ -4,7 +4,7 @@ > #ifdef __KERNEL__ /* o

Re: [patch 2.6.24-rc1] resource_len() utility function

2007-10-24 Thread David Brownell
On Wednesday 24 October 2007, Jeff Garzik wrote: > With regards to resource reservation...  IMO we should mimic struct > pci_dev and add struct resource[] to struct device. One minor difficulty: PCI has a limit on the number of BARs, but other busses don't. It'd be better as a "struct resource

Re: SLUB 0:1 SLAB (OOM during massive parallel kernel builds)

2007-10-24 Thread Christoph Lameter
On Thu, 25 Oct 2007, Nick Piggin wrote: > > Ummm... all unreclaimable is set! Are you mlocking the pages in memory? Or > > what causes this? All pages under writeback? What is the dirty ratio set > > to? > > Why is SLUB behaving differently, though. Nore sure. Are we really sure that this does n

Re: SLUB 0:1 SLAB (OOM during massive parallel kernel builds)

2007-10-24 Thread Nick Piggin
On Thursday 25 October 2007 12:15, Christoph Lameter wrote: > On Wed, 24 Oct 2007, Alexey Dobriyan wrote: > > [12728.701398] DMA free:8032kB min:32kB low:40kB high:48kB active:2716kB > > inactive:2208kB present:12744kB pages_scanned:9299 all_unreclaimable? > > yes [12728.701567] lowmem_reserve[]: 0

Re: [patch 2.6.24-rc1] resource_len() utility function

2007-10-24 Thread David Brownell
On Wednesday 24 October 2007, Alan Cox wrote: > On Wed, 24 Oct 2007 18:20:52 -0700 > David Brownell <[EMAIL PROTECTED]> wrote: > > > Add a new resource_len() function, so drivers can start using this > > instead of driver-private code for a common idiom. The call can be > > useful with at least:

Re: sysfs sys/kernel/ namespace (was Re: [PATCH 0/2] add new notifier function ,take2)

2007-10-24 Thread Nick Piggin
On Wednesday 24 October 2007 21:12, Kay Sievers wrote: > On 10/24/07, Nick Piggin <[EMAIL PROTECTED]> wrote: > > On Tuesday 23 October 2007 10:55, Takenori Nagano wrote: > > > Nick Piggin wrote: > > > > One thing I'd suggest is not to use debugfs, if it is going to > > > > be a useful end-user feat

Re: + reiserfs-dont-drop-pg_dirty-when-releasing-sub-page-sized-dirty-file .patch added to -mm tree

2007-10-24 Thread Fengguang Wu
On Wed, Oct 24, 2007 at 04:07:37PM -0700, [EMAIL PROTECTED] wrote: > > The patch titled > reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file > has been added to the -mm tree. Its filename is > > reiserfs-dont-drop-pg_dirty-when-releasing-sub-page-sized-dirty-file.pa

Re: [PATCH 2.6.24-rc1] fix sg_phys to use dma_addr_t

2007-10-24 Thread Arjan van de Ven
> Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> > --- > Whether this is a complete patch, suitable for all architectures, > I'm not sure: it builds, boots and runs correctly on the x86_32 box > in question, but you'll be a lot wiser than me about using dma_addr_t > for everyone. (Seems a bit of

Re: [lm-sensors] hwmon/f75375s.c: buggy if()

2007-10-24 Thread Mark M. Hoffman
Hi Riku: * Riku Voipio <[EMAIL PROTECTED]> [2007-10-24 14:50:34 +0300]: > On Fri, Oct 19, 2007 at 02:37:54PM +0200, Jean Delvare wrote: > > Riku, can you please submit a patch fixing this? The attribute should > > be declared read-only, and then you can use sysfs_chmod_file() to > > change it to r

Re: [patch 1/5] wait: use lock bitops for __wait_on_bit_lock

2007-10-24 Thread Nick Piggin
On Thursday 25 October 2007 11:14, Andrew Morton wrote: > On Wed, 24 Oct 2007 18:13:06 +1000 [EMAIL PROTECTED] wrote: > > Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> > > > > --- > > kernel/wait.c |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Index: linux-2.6/kernel/wait.c

Re: [PATCH] Hardware Monitor LM70: Convert semaphore to mutex

2007-10-24 Thread Mark M. Hoffman
Hi: * Matthias Kaehlcke <[EMAIL PROTECTED]> [2007-10-24 14:59:09 +0200]: > Hardware Monitor LM70: Convert the semaphore lm70->sem to the mutex > API > > Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> Applied to hwmon-2.6.git/testing, thanks. -- Mark M. Hoffman [EMAIL PROTECTED] - To uns

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-24 Thread Arjan van de Ven
On Wed, 24 Oct 2007 17:41:28 -0700 Chris Wright <[EMAIL PROTECTED]> wrote: > * Linus Torvalds ([EMAIL PROTECTED]) wrote: > > Do other people want to stand up and be "LSM maintainers" in the > > sense that they also end up being informed members who can also > > stand up for new modules and help me

Re: [2.6 patch] make jffs2_get_acl() static

2007-10-24 Thread KaiGai Kohei
Adrian Bunk wrote: jffs2_get_acl() can now become static again. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: KaiGai Kohei <[EMAIL PROTECTED]> --- fs/jffs2/acl.c |2 +- fs/jffs2/acl.h |2 -- 2 files changed, 1 insertion(+), 3 deletions(-) add2b887d64536f3fe978e62f077429

Re: SLUB 0:1 SLAB (OOM during massive parallel kernel builds)

2007-10-24 Thread Christoph Lameter
On Wed, 24 Oct 2007, Alexey Dobriyan wrote: > [12728.701398] DMA free:8032kB min:32kB low:40kB high:48kB active:2716kB > inactive:2208kB present:12744kB pages_scanned:9299 all_unreclaimable? > yes [12728.701567] lowmem_reserve[]: 0 2003 2003 2003 [12728.701654] Ummm... all unreclaimable is set

Re: [patch 2.6.24-rc1] resource_len() utility function

2007-10-24 Thread Jeff Garzik
Alan Cox wrote: On Wed, 24 Oct 2007 18:20:52 -0700 David Brownell <[EMAIL PROTECTED]> wrote: Add a new resource_len() function, so drivers can start using this instead of driver-private code for a common idiom. The call can be useful with at least: - request_region(), release_region() - req

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-24 Thread david
On Thu, 25 Oct 2007, Alan Cox wrote: The idea that poor security is worse than no security is fallacious, and not backed up by common experience. There is a ton of evidence both in computing and outside of it which shows that poor security can be very much worse than no security at all. In par

SPI doesn't detect first dataflash (CS0) on a AT91rm9200ek with kernel 2.6.23.1

2007-10-24 Thread Bruno Vétel
Hello I want to use SPI on a at91rm9200ek. The SPI starts and the dataflash is probed but fails with error 255. I tried on another board very similar to at91rm9200ek but with 4 dataflashs (chip select 0 to 3). The flashs 1 2 3 are well detected but the 0 fails also with the same error code. Debug

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-24 Thread david
On Wed, 24 Oct 2007, Serge E. Hallyn wrote: The scariest thing to consider is programs which don't appropriately handle failure. So I don't know, maybe the system runs a remote logger to which the multiadm policy gives some extra privs, but now the portac module prevents it from sending its dat

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-24 Thread Alan Cox
> The idea that poor security is worse than no security is fallacious, > and not backed up by common experience. There is a ton of evidence both in computing and outside of it which shows that poor security can be very much worse than no security at all. In particular stuff which makes users think

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-24 Thread Chris Wright
* Linus Torvalds ([EMAIL PROTECTED]) wrote: > Do other people want to stand up and be "LSM maintainers" in the sense > that they also end up being informed members who can also stand up for new > modules and help merge them, rather than just push the existing one(s)? > Chris? Casey? Crispin? St

[PATCH 2.6.24-rc1] fix sg_phys to use dma_addr_t

2007-10-24 Thread Hugh Dickins
x86_32 CONFIG_HIGHMEM64G with 5GB RAM hung when booting, after issuing some "request_module: runaway loop modprobe binfmt-" messages in trying to exec /sbin/init. The binprm buf doesn't see the right ".ELF" header because sg_phys() is providing the wrong physical addresses for high pages: a 32

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-24 Thread Casey Schaufler
--- Chris Wright <[EMAIL PROTECTED]> wrote: > * Casey Schaufler ([EMAIL PROTECTED]) wrote: > > And don't give me the old "LKML is a tough crowd" feldercarb. > > Security modules have been much worse. Innovation, even in > > security, is a good thing and treating people harshly, even > > "for thei

Re: [patch 2.6.24-rc1] resource_len() utility function

2007-10-24 Thread Alan Cox
On Wed, 24 Oct 2007 18:20:52 -0700 David Brownell <[EMAIL PROTECTED]> wrote: > Add a new resource_len() function, so drivers can start using this > instead of driver-private code for a common idiom. The call can be > useful with at least: > > - request_region(), release_region() > - request_me

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-24 Thread Peter Dolding
I have different deal breakers. If a LSM is something simple/commonly required it should be made like posix file capability's provided to all to use. Sorry to say I see the file protection in apparmor as something everyone should be able to use at will like posix file capability's. All enforcem

Re: [dm-devel] [PATCH] dm: noflush resizing (0/3)

2007-10-24 Thread Alasdair G Kergon
On Wed, Oct 24, 2007 at 05:25:17PM -0400, Jun'ichi Nomura wrote: > - For some device-mapper targets (multipath and mirror), > the mapping table sometimes has to be replaced to cope with device > failure. > OTOH, device-mapper flushes all pending I/Os upon table replacement > and m

Re: 2.6.24-rc1 oops

2007-10-24 Thread FUJITA Tomonori
On Thu, 25 Oct 2007 01:40:00 +0100 Sid Boyce <[EMAIL PROTECTED]> wrote: > x86_64 dual, gcc version 4.2.2 (SUSE Linux). > [ cut here ] > kernel BUG at include/linux/scatterlist.h:50! > invalid opcode: [1] SMP > CPU 1 > Modules linked in: ub crc_itu_t hwmon cdrom soundco

[patch 2.6.24-rc1] resource_len() utility function

2007-10-24 Thread David Brownell
Add a new resource_len() function, so drivers can start using this instead of driver-private code for a common idiom. The call can be useful with at least: - request_region(), release_region() - request_mem_region(), release_mem_region() - ioremap() Candidate drivers include those using platf

Re: [patch 1/5] wait: use lock bitops for __wait_on_bit_lock

2007-10-24 Thread Andrew Morton
On Wed, 24 Oct 2007 18:13:06 +1000 [EMAIL PROTECTED] wrote: > Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> > > --- > kernel/wait.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/kernel/wait.c > ==

Re: Linux Security *Module* Framework (Was: LSM conversion to static interface)

2007-10-24 Thread Casey Schaufler
--- Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Thu, 25 Oct 2007, Adrian Bunk wrote: > > > > What I'm giving you is "Linus has decreed there can be LSMs other than > > SELinux." > > > > Getting LSMs included should no longer be harder than for other > > parts of the kernel. > > Well

Re: [uml-devel] User Mode Linux still doesn't build in 2.6.23-final.

2007-10-24 Thread Jeff Dike
On Wed, Oct 24, 2007 at 04:46:54PM -0500, Rob Landley wrote: > Prebuilt for Ubuntu 7.04: > http://landley.net/code/firmware/downloads/cross-compiler/host-i686/cross-compiler-sparc.tar.bz2 > > Source code: > Or http://landley.net/code/firmware/downloads/firmware-0.2.2.tar.bz2 Thanks - I already go

Re: [2.6 patch] drivers/base/node.c: cleanups

2007-10-24 Thread KAMEZAWA Hiroyuki
On Wed, 24 Oct 2007 09:52:56 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Wed, 24 Oct 2007, Adrian Bunk wrote: > > > This patch contains the following cleanups: > > - make the following needlessly globalcode static: > > - register_node() > > - node_state_attr[] > > - #if 0 th

  1   2   3   4   5   6   7   >