[PATCH] CPU HOTPLUG: Avoid hotadd when proper possible_map isn't specified.

2007-09-27 Thread KAMEZAWA Hiroyuki
cpu-hot-add should be fail if cpu is not set in cpu_possible_map. If go ahead, the system will panic soon. Especially, arch which requires additional_cpus= parameter should handle this. Tested on ia64. Signed-off-by: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> --- kernel/cpu.c |8 1 file

Re: Warnings and Oops on 2.6.23-rc6 while activily using rfcomm links (mm/slab.c)

2007-09-27 Thread Cornelia Huck
On Thu, 27 Sep 2007 20:07:54 +0200, Pierre-Yves Paulus <[EMAIL PROTECTED]> wrote: > Another one below, complete log from power-up to reboot, with some bugs > and one Oops. I only trimmed the numerous "l2cap_recv_acldata" and "ACL > packet for unknown connection handle" lines which always fill up

Re: A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?)

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 23:32:36 -0700 "Chakri n" <[EMAIL PROTECTED]> wrote: > Hi, > > In my testing, a unresponsive file system can hang all I/O in the system. > This is not seen in 2.4. > > I started 20 threads doing I/O on a NFS share. They are just doing 4K > writes in a loop. > > Now I stop NF

Re: [PATCH -mm1 1/2] fixing idr_find() locking

2007-09-27 Thread Andrew Morton
On Fri, 28 Sep 2007 08:31:44 +0200 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On Thu, Sep 27, 2007 at 04:33:55PM +0200, [EMAIL PROTECTED] wrote: > > [PATCH 01/02] > > > > > > This is a patch that fixes the way idr_find() used to be called in > > ipc_lock(): > > in all the paths that don't imp

Re: [RFC] QoS params patch

2007-09-27 Thread Paul Mundt
On Thu, Sep 27, 2007 at 11:25:01PM -0700, Andrew Morton wrote: > On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross <[EMAIL PROTECTED]> wrote: > > +int qos_add_requirement(int qos, char *name, s32 value); > > +int qos_update_requirement(int qos, char *name, s32 new_value); > > +void qos_remove_requireme

Re: [PATCH -mm1 0/2] Fix unlocked call to idr_find()

2007-09-27 Thread Jarek Poplawski
On Fri, Sep 28, 2007 at 08:12:56AM +0200, Nadia Derbey wrote: > Jarek Poplawski wrote: > >On Thu, Sep 27, 2007 at 04:33:54PM +0200, [EMAIL PROTECTED] wrote: > > > >>This a series of 2 patches that should be applied on top of the other ipc > >>patches, in 2.6.23-rc6-mm1. > > > >... > > > >>They shou

A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?)

2007-09-27 Thread Chakri n
Hi, In my testing, a unresponsive file system can hang all I/O in the system. This is not seen in 2.4. I started 20 threads doing I/O on a NFS share. They are just doing 4K writes in a loop. Now I stop NFS server hosting the NFS share and start a "dd" process to write a file on local EXT3 file s

Re: 2.6.23-rc7 - _random_ IRQ23 : nobody cared

2007-09-27 Thread Paul Rolland
Hi, On Fri, 28 Sep 2007 08:27:58 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > This is an Asus P5W-DH Deluxe motherboard, with a Core2 6400 CPU, > > a bunch of disk (2 IDE, 3 SATA, 1 CDRW and 1 DVDRW-DL), and a damned > > Olitec PCI V92 V2 modem. > > What chipset ? 965gm ? 975x

Re: [PATCH -mm1 1/2] fixing idr_find() locking

2007-09-27 Thread Jarek Poplawski
On Thu, Sep 27, 2007 at 04:33:55PM +0200, [EMAIL PROTECTED] wrote: > [PATCH 01/02] > > > This is a patch that fixes the way idr_find() used to be called in ipc_lock(): > in all the paths that don't imply an update of the ipcs idr, it was called > without the idr tree being locked. > > The change

Re: [RFC] QoS params patch

2007-09-27 Thread Andrew Morton
On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross <[EMAIL PROTECTED]> wrote: > +#define QOS_RESERVED 0 > +#define QOS_CPU_DMA_LATENCY 1 > +#define QOS_NETWORK_LATENCY 2 > +#define QOS_NETWORK_THROUGHPUT 3 > + > +#define QOS_NUM_CLASSES 4 > +#define QOS_DEFAULT_VALUE -1 > + > +int qos_add_requirement(i

[PATCH] PCI legacy I/O port free driver - Making fusion MPT driver

2007-09-27 Thread Masao Fukuchi
Hi, This patch makes Fusion MPT driver legacy I/O port free. The latest kernel has interface for PCI device drivers to tell the kernel which resource the driver want to use. I've made a patch which makes Fusion MPT driver legacy I/O port free by using PCI core changes. Fusion MPT driver basicall

AW: More E820 brokenness

2007-09-27 Thread Joerg Pommnitz
Hello all, I won't be able to test anything before next Tuesday, but I'm with Jordan on this one. Have a look at the dmsg output I sent you some time ago (http://article.gmane.org/gmane.linux.kernel/584681). This was as plain from Linus' tree as you get it (git bisect, make defconfig, make) and I

[PATCH] Inconsistent mmap()/mremap() flags

2007-09-27 Thread Thayne Harbaugh
The x86_64 mmap() accepts the MAP_32BIT flag to request 32-bit clean addresses. It seems to me that for consistency x86_64 mremap() should also accept this (or an equivalent) flag. Here is a trivial and untested patch for basis of discussion: --- linux-source-2.6.22/mm/mremap.c.orig2007-

Re: [PATCH -mm1 0/2] Fix unlocked call to idr_find()

2007-09-27 Thread Nadia Derbey
Jarek Poplawski wrote: On Thu, Sep 27, 2007 at 04:33:54PM +0200, [EMAIL PROTECTED] wrote: This a series of 2 patches that should be applied on top of the other ipc patches, in 2.6.23-rc6-mm1. ... They should be applied to 2.6.23-rc6-mm1, in the following order: Didn't you mean 2.6.23-rc8

Re: [PATCH -mm1 0/2] Fix unlocked call to idr_find()

2007-09-27 Thread Jarek Poplawski
On Thu, Sep 27, 2007 at 04:33:54PM +0200, [EMAIL PROTECTED] wrote: > > This a series of 2 patches that should be applied on top of the other ipc > patches, in 2.6.23-rc6-mm1. ... > They should be applied to 2.6.23-rc6-mm1, in the following order: Didn't you mean 2.6.23-rc8-mm1, btw? Regards, Jar

Re: [PATCH] Module use count must be updated as bridges are created/destroyed

2007-09-27 Thread Herbert Xu
Jan Beulich <[EMAIL PROTECTED]> wrote: > > So we have an unsolvable problem here then, unless infrastructure gets added > that allows a module to declare itself as not-implicit-unload-safe, forcing > modprobe -r to keep its hands off it. Ugly. Yes I've always wanted to have a separate count that i

Re: sata_sil24 broken since 2.6.23-rc4-mm1

2007-09-27 Thread Torsten Kaiser
On 9/27/07, Tejun Heo <[EMAIL PROTECTED]> wrote: > Torsten Kaiser wrote: > > Known good is for me 2.6.23-rc3-mm1, the first known bad is 2.6.23-rc4-mm1. > > I will try to look at the diff between these revisions some more, but > > the change in sata_sil24.c looked like a perfect match for the > > s

Re: Problems with SMP & ACPI powering off

2007-09-27 Thread Len Brown
On Thursday 27 September 2007 18:00, Rafael J. Wysocki wrote: > On Thursday, 27 September 2007 23:29, Mark Lord wrote: > > Question: do we disable all CPUs except 0 when doing ACPI power off? > > No, but we should. We used to. It is absolutely mandatory -- else it confuses the BIOS on some board

Re: [13/17] Virtual compound page freeing in interrupt context

2007-09-27 Thread KAMEZAWA Hiroyuki
On Tue, 25 Sep 2007 16:42:17 -0700 Christoph Lameter <[EMAIL PROTECTED]> wrote: > +static noinline void vcompound_free(void *addr) > +{ > + if (in_interrupt()) { Should be (in_interrupt() || irqs_disabled()) ? Regards, -Kame - To unsubscribe from this list: send the line "unsubscribe linux-

Re: drivers/usb/misc/emi*.c have the biggest data objects in the whole tree

2007-09-27 Thread Greg KH
On Fri, Sep 14, 2007 at 11:35:34AM +0100, Denys Vlasenko wrote: > Hi Tapio, > > You are the author of these files. Are you still maintaining them? > If not, do you know who is the current maintainer? > > These two object files hold the biggest data objects in the whole Linux kernel > after lockde

[git patches] net driver fixes

2007-09-27 Thread Jeff Garzik
And an e1000 id patch. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/e1000/e1000_ethtool.c |1 + drivers/net/e1000/e1000_hw.c |1 + drivers/net/e1000/e100

[PATCH] libata drain fifo on stuck DRQ HSM violation

2007-09-27 Thread Mark Lord
Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Alan Cox wrote: I think there have been enough cases where this draining was necessary. IIRC, ata_piix was involved in those cases, right? If so, can you please submit a patch which applies this only to affected controllers? I don't feel t

Re: Stardom SATA HSM violation

2007-09-27 Thread Mark Lord
Tejun Heo wrote: Alan Cox wrote: I think there have been enough cases where this draining was necessary. IIRC, ata_piix was involved in those cases, right? If so, can you please submit a patch which applies this only to affected controllers? I don't feel too confident about applying this to al

Re: [3/4] dma: document dma_flags_set_dmabarrier()

2007-09-27 Thread Grant Grundler
On Thu, Sep 27, 2007 at 06:13:02PM -0700, [EMAIL PROTECTED] wrote: > > Document dma_flags_set_dmabarrier(). > > Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> This looks really good! thanks, grant Acked-by: Grant Grundler <[EMAIL PROTECTED]> > > --- > DMA-API.txt | 26 ++

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Greg KH
On Thu, Sep 27, 2007 at 05:28:57PM -0600, Matthew Wilcox wrote: > On Thu, Sep 27, 2007 at 07:19:27PM -0400, Theodore Tso wrote: > > Would you accept a patch which causes the deprecated sysfs > > files/directories to disappear, even if CONFIG_SYS_DEPRECATED is > > defined, via a boot-time parameter?

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Greg KH
On Thu, Sep 27, 2007 at 07:19:27PM -0400, Theodore Tso wrote: > On Thu, Sep 27, 2007 at 02:34:45PM -0700, Greg KH wrote: > > Ok, how then should I advertise this better? What can we do better to > > help userspace programmers out in this regard? > > Would you accept a patch which causes the depre

Re: iwl4965 and driver merging policy

2007-09-27 Thread Benjamin Herrenschmidt
On Thu, 2007-09-27 at 22:30 -0400, John W. Linville wrote: > > It doesn't seem to pull any depedency nor affect any other external > > piece of code unless I'm missing something, so it's a perfect > example of > > what we've been discussing back then: there is just no point not > merging > > it at

Re: iwl4965 and driver merging policy

2007-09-27 Thread Benjamin Herrenschmidt
> > Well, pulling in iwlwifi would require also pulling in the mac80211 > subsystem, so it's not quite that simple (although I'm not sure what's > holding back that going into the kernel.) I though that was already in 2.6.23 ... my bad if I missed something (there is definitely something there c

Re: iwl4965 and driver merging policy

2007-09-27 Thread John W. Linville
On Fri, Sep 28, 2007 at 11:39:27AM +1000, Benjamin Herrenschmidt wrote: > Just a little question in the light of the discussion we had at Kernel > Summit about merging drivers upstream (and here, I strongly agree with > Linus, hence my message). You must not have been watching me SPAM netdev for

Re: iwl4965 and driver merging policy

2007-09-27 Thread Theodore Tso
On Fri, Sep 28, 2007 at 11:39:27AM +1000, Benjamin Herrenschmidt wrote: > > Just a little question in the light of the discussion we had at Kernel > Summit about merging drivers upstream (and here, I strongly agree with > Linus, hence my message). > > I just got that new T61 laptop which happens

WARNING: at arch/x86_64/kernel/smp.c:397 smp_call_function_mask()

2007-09-27 Thread Fengguang Wu
On Thu, Sep 27, 2007 at 02:22:20AM -0700, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ Laurent, It triggered a WARNING on first run in qemu: [0.31] WARNING: at arch/x86_64/kernel/smp.c:397 smp_call_function_mask() [

Re: [patch 2/2] VFS: allow filesystem to override mknod capability checks

2007-09-27 Thread Neil Brown
On Monday September 24, [EMAIL PROTECTED] wrote: > From: Miklos Szeredi <[EMAIL PROTECTED]> > > Add a new super block flag, that results in the VFS not checking if > the current process has enough privileges to do an mknod(). > > If this flag is set, all mounts for this super block will have the

Re: Floating Point Issue

2007-09-27 Thread WANG Cong
On Thu, Sep 27, 2007 at 05:17:44PM +0200, Jan Engelhardt wrote: > >On Sep 27 2007 12:41, mahamuni ashish wrote: >>I have small code > >This is not a kernel problem. (Read your C book and/or ask in >a C newsgroup.) Please goto comp.lang.c for help. ;) -- "Bill, look, we understand that you're

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Srivatsa Vaddagiri
On Thu, Sep 27, 2007 at 04:42:41PM -0700, Andrew Morton wrote: > > @@ -219,6 +225,9 @@ static inline struct task_grp *task_grp( > > > > #ifdef CONFIG_FAIR_USER_SCHED > > tg = p->user->tg; > > +#elif CONFIG_FAIR_CGROUP_SCHED > > + tg = container_of(task_subsys_state(p, cpu_cgroup_subsys_id)

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Theodore Tso
On Thu, Sep 27, 2007 at 05:28:57PM -0600, Matthew Wilcox wrote: > On Thu, Sep 27, 2007 at 07:19:27PM -0400, Theodore Tso wrote: > > Would you accept a patch which causes the deprecated sysfs > > files/directories to disappear, even if CONFIG_SYS_DEPRECATED is > > defined, via a boot-time parameter?

Re: [PATCH] i915: make vbl interrupts work properly on i965g/gm

2007-09-27 Thread Jesse Barnes
On Thursday, September 27, 2007 7:05:31 pm Dave Airlie wrote: > Hi Linus, > > The attached patch is to fix a bug reported on 965gm chipsets (lots of new > laptops), I think distros will all have to patch this in to fix it, so can > we get it into the 2.6.23 final? > > (Otherwise I'll wait until sta

2.6.23-rc8 network problem. Mem leak? ip1000a?

2007-09-27 Thread linux
Uniprocessor Althlon 64, 64-bit kernel, 2G ECC RAM, 2.6.23-rc8 + linuxpps (5.0.0) + ip1000a driver. (patch from http://marc.info/?l=linux-netdev&m=118980588419882) After a few hours of operation, ntp loses the ability to send packets. sendto() returns -EAGAIN to everything, including the 24-byte U

[PATCH] i915: make vbl interrupts work properly on i965g/gm

2007-09-27 Thread Dave Airlie
Hi Linus, The attached patch is to fix a bug reported on 965gm chipsets (lots of new laptops), I think distros will all have to patch this in to fix it, so can we get it into the 2.6.23 final? (Otherwise I'll wait until stable..) Dave.From 14e53712e5e2ccc72dac1131de78e590e9a9d451 Mon Sep 17

Re: State of the Linux PCI Subsystem for 2.6.23-rc8

2007-09-27 Thread Greg KH
On Thu, Sep 27, 2007 at 09:18:50PM -0400, Jeff Garzik wrote: > Greg KH wrote: >> On Thu, Sep 27, 2007 at 03:22:35AM -0400, Jeff Garzik wrote: >>> Greg KH wrote: On Wed, Sep 26, 2007 at 11:40:58PM +0200, Brice Goglin wrote: > Greg KH wrote: >> Here's a summary of the current state of th

iwl4965 and driver merging policy

2007-09-27 Thread Benjamin Herrenschmidt
Hi ! Just a little question in the light of the discussion we had at Kernel Summit about merging drivers upstream (and here, I strongly agree with Linus, hence my message). I just got that new T61 laptop which happens to have an iwl4xxx chip. The distro I installed on it (ubuntu) has a driver for

Re: [RFC] New kernel-message logging API (take 2)

2007-09-27 Thread linux
> Example: { > struct kprint_block out; > kprint_block_init(&out, KPRINT_DEBUG); > kprint_block(&out, "Stack trace:"); > > while(unwind_stack()) { > kprint_block(&out, "%p %s", address, symbol); > } > kprint_block_flush(&out); > } Assuming that kpr

Re: [PATCH] UML - Correctly handle skb allocation failures

2007-09-27 Thread Jeff Dike
On Thu, Sep 27, 2007 at 04:53:40PM -0700, Andrew Morton wrote: > Still wanna know why it is safe for uml_net_rx to be playing with > drop_skb when update_drop_skb() could be concurrently reallocating > and freeing it. Ah, yes, I missed that point in the horror of my botch last night. I'll add irq

Re: State of the Linux PCI Subsystem for 2.6.23-rc8

2007-09-27 Thread Jeff Garzik
Greg KH wrote: On Thu, Sep 27, 2007 at 03:22:35AM -0400, Jeff Garzik wrote: Greg KH wrote: On Wed, Sep 26, 2007 at 11:40:58PM +0200, Brice Goglin wrote: Greg KH wrote: Here's a summary of the current state of the Linux PCI subsystem, as of 2.6.23-rc8. If the information in here is incorrect,

Re: [PATCH] writeback: remove unnecessary wait in throttle_vm_writeout()

2007-09-27 Thread Fengguang Wu
On Thu, Sep 27, 2007 at 11:16:10AM -0400, Rik van Riel wrote: > On Thu, 27 Sep 2007 09:50:16 +0800 > Fengguang Wu <[EMAIL PROTECTED]> wrote: > > > We don't want to introduce pointless delays in throttle_vm_writeout() > > when the writeback limits are not yet exceeded, do we? > > Good catch. Than

[4/4] mthca: allow setting "dmabarrier" on user-allocated memory

2007-09-27 Thread akepner
Use the dma_flags_set_dmabarrier() interface to allow a "dmabarrier" attribute to be associated with user-allocated memory. (For now, it's only implemented for mthca.) Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> --- drivers/infiniband/core/umem.c |7 +-- drivers/infi

[3/4] dma: document dma_flags_set_dmabarrier()

2007-09-27 Thread akepner
Document dma_flags_set_dmabarrier(). Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> --- DMA-API.txt | 26 ++ 1 files changed, 26 insertions(+) diff --git a/Documentation/DMA-API.txt b/Documentation/DMA-API.txt index cc7a8c3..5fc0bba 100644 --- a/Documentation/DMA-AP

[2/4] dma: redefine dma_flags_set_dmabarrier() for sn-ia64

2007-09-27 Thread akepner
define dma_flags_set_dmabarrier() for sn-ia64 - it "borrows" bits from the direction argument (renamed "flags") to the dma_map_* routines to pass an additional "dmabarrier" attribute. Also define routines to retrieve the original direction and attribute from "flags". Signed-off-by: Arthur Kepner

[1/4] dma: add dma_flags_set_dmabarrier() to dma interface

2007-09-27 Thread akepner
Introduce the dma_flags_set_dmabarrier() interface and give it a default no-op implementation. Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> --- dma-mapping.h |6 ++ 1 files changed, 6 insertions(+) diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 2dc21

[PATCH 0/4] allow drivers to flush in-flight DMA v2

2007-09-27 Thread akepner
On Altix, DMA may be reordered between a device and host memory. This reordering can happen in the NUMA interconnect, and it usually results in correct operation and improved performance. In some situations it may be necessary to explicitly synchronize DMA from the device. This patchset allow

Re: sys_chroot+sys_fchdir Fix

2007-09-27 Thread David Newall
Bill Davidsen wrote: It seems there are (at least) two parts to this, one regarding changing working directory which is clearly stated in the standards and must work as it does, and the various issues regarding getting out of the chroot after the cwd has entered that changed root. That second

Re: [PATCH] pci: use pci=bfsort for HP DL385 G2, DL585 G2

2007-09-27 Thread Matt Domsch
On Thu, Sep 27, 2007 at 11:18:44AM +0200, Michal Schmidt wrote: > Hello, > > HP ProLiant systems DL385 G2 and DL585 G2 need pci=bfsort to enumerate PCI > devices in the expected order. > > (John, can you please confirm and ACK this?) As a shameless plug, biosdevname is a userspace app I wrote to

Re: [PATCH 0/4] allow drivers to flush in-flight DMA

2007-09-27 Thread akepner
On Wed, Sep 26, 2007 at 12:49:50AM -0600, Grant Grundler wrote: [edited out several points that I think have been already addresed by others in this thread.] > > Defining it terms of completion queues won't mean much to most folks. > Better to add a description of completion queues to the D

Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

2007-09-27 Thread akepner
On Tue, Sep 25, 2007 at 10:13:33PM -0700, Randy Dunlap wrote: > On Tue, 25 Sep 2007 17:00:57 -0700 [EMAIL PROTECTED] wrote: > .. > 1. Function signature should be on one line if possible (and it is). > Aw crud, I looked at dma-mapping.h and it uses this format sometimes. > Well, it's undesirab

Re: More E820 brokenness

2007-09-27 Thread H. Peter Anvin
Jordan Crouse wrote: > > Worked, but that just raises more questions. Why didn't more x86 boxes > break or, alternatively, why did a new version of the BIOS fix the problem? > I guess we shouldn't look a gift horse in the mouth. Or something. > Why didn't more x86 boxes break... well, it's pre

Re: [RFC] QoS params patch update.

2007-09-27 Thread Paul Mundt
On Thu, Sep 27, 2007 at 01:17:39PM -0700, Mark Gross wrote: > Updated qos PM parameter patch: > Note: the replacing of latency.c with this is a separate patch. > > this patch attempts to address the issues raised so far. > [snip] > +static int register_new_qos_misc(struct qos_object *qos) > +{ >

Re: More E820 brokenness

2007-09-27 Thread Jordan Crouse
On 27/09/07 16:36 -0700, H. Peter Anvin wrote: > Jordan Crouse wrote: > >>> > >> Oh bugger, looks like this one might be genuinely my fault after all. > >> The ID check in the new code is buggy. > >> > >> Can you please test this revised patch out (against current -git)? > > > > > > That looks th

Re: Stardom SATA HSM violation

2007-09-27 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> Alan Cox wrote: I think there have been enough cases where this draining was necessary. IIRC, ata_piix was involved in those cases, right? If so, can you please submit a patch which applies this only to affected controllers? I don't fee

Re: [PATCH] UML - Correctly handle skb allocation failures

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 13:01:26 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote: > +static int update_drop_skb(int max) > +{ > + struct sk_buff *new; > + int err = 0; > + > + spin_lock(&drop_lock); > + > + if (max <= drop_max) > + goto out; > + > + err = -ENOMEM; > + new

Re: [PATCH] Some IO scheduler cleanup in Documentation/block

2007-09-27 Thread Jens Axboe
On Thu, Sep 27 2007, Alan D. Brunelle wrote: > > [PATCH] Some IO scheduler cleanup in Documentation/block [snip] Thanks Alan, applied. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Stardom SATA HSM violation

2007-09-27 Thread Jeff Garzik
Tejun Heo wrote: Alan Cox wrote: I think there have been enough cases where this draining was necessary. IIRC, ata_piix was involved in those cases, right? If so, can you please submit a patch which applies this only to affected controllers? I don't feel too confident about applying this to al

Re: [PATCH -mm] Hook up group scheduler with control groups

2007-09-27 Thread Andrew Morton
On Fri, 28 Sep 2007 01:05:12 +0530 Dhaval Giani <[EMAIL PROTECTED]> wrote: > On Thu, Sep 27, 2007 at 12:00:33PM -0700, Randy Dunlap wrote: > > On Thu, 27 Sep 2007 23:34:15 +0530 Dhaval Giani wrote: > > > > > > > > > +config RESOURCE_COUNTERS > > > + bool "Resource counters" > > > + help > > > +

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Jens Axboe
On Thu, Sep 27 2007, Theodore Tso wrote: > On Thu, Sep 27, 2007 at 04:19:12PM +0100, Alan Cox wrote: > > > Well it's not my call, just seems like a really bad idea to change the > > > error value. You can't claim full coverage for such testing anyway, it's > > > one of those things that people will

Re: More E820 brokenness

2007-09-27 Thread H. Peter Anvin
Jordan Crouse wrote: >>> >> Oh bugger, looks like this one might be genuinely my fault after all. >> The ID check in the new code is buggy. >> >> Can you please test this revised patch out (against current -git)? > > > That looks the same as the previous patch you sent? > Sorry, this is the rig

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 04:10:31PM -0600, Matthew Wilcox wrote: > In the error handler, we wait_for_completion(io_reset_wait). > In sym2_io_error_detected, we init_completion(io_reset_wait). > Isn't it possible that we hit the error handler before we hit the > io_error_detected path, and thus the c

Re: More E820 brokenness

2007-09-27 Thread Jordan Crouse
On 27/09/07 16:27 -0700, H. Peter Anvin wrote: > Jordan Crouse wrote: > > On 27/09/07 15:47 -0700, H. Peter Anvin wrote: > >> Jordan Crouse wrote: > >>> Breaks on the Geode - original behavior. > >>> > >>> I think that having boot_prams.e820_entries != 0 makes the kernel > >>> assume the e820 data

Re: Stardom SATA HSM violation

2007-09-27 Thread Tejun Heo
Alan Cox wrote: >> I think there have been enough cases where this draining was necessary. >> IIRC, ata_piix was involved in those cases, right? If so, can you >> please submit a patch which applies this only to affected controllers? >> I don't feel too confident about applying this to all SFF co

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Matthew Wilcox
On Thu, Sep 27, 2007 at 07:19:27PM -0400, Theodore Tso wrote: > Would you accept a patch which causes the deprecated sysfs > files/directories to disappear, even if CONFIG_SYS_DEPRECATED is > defined, via a boot-time parameter? How about a mount option? That way people can test without a reboot:

Re: More E820 brokenness

2007-09-27 Thread H. Peter Anvin
Jordan Crouse wrote: > On 27/09/07 15:47 -0700, H. Peter Anvin wrote: >> Jordan Crouse wrote: >>> Breaks on the Geode - original behavior. >>> >>> I think that having boot_prams.e820_entries != 0 makes the kernel >>> assume the e820 data is correct. >>> >> Okay, now I'm utterly baffled how 2.6.22 e

Re: sata_sil24 broken since 2.6.23-rc4-mm1

2007-09-27 Thread Tejun Heo
Torsten Kaiser wrote: > Known good is for me 2.6.23-rc3-mm1, the first known bad is 2.6.23-rc4-mm1. > I will try to look at the diff between these revisions some more, but > the change in sata_sil24.c looked like a perfect match for the > symptoms I was seeing. I think the first thing to do here i

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Greg KH
On Thu, Sep 27, 2007 at 06:27:48PM -0400, Kyle Moffett wrote: > On Sep 27, 2007, at 17:34:45, Greg KH wrote: >> On Thu, Sep 27, 2007 at 02:37:42PM -0400, Theodore Tso wrote: >>> That fact that sysfs is all laid out in a directory, but for which some >>> directories/symlinks are OK to use, and some

Re: More E820 brokenness

2007-09-27 Thread H. Peter Anvin
Jordan Crouse wrote: > > I copied in a 2.6.22 kernel to see that it really did work, and it did. > But here's the crazy part - I did a dmesg, and it looks like it > *is* using e820 data, and it looks complete (I see the entire map - > including the ACPI and reserved blocks way up high). > > So a

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Theodore Tso
On Thu, Sep 27, 2007 at 02:34:45PM -0700, Greg KH wrote: > Ok, how then should I advertise this better? What can we do better to > help userspace programmers out in this regard? Would you accept a patch which causes the deprecated sysfs files/directories to disappear, even if CONFIG_SYS_DEPRECATE

Re: More E820 brokenness

2007-09-27 Thread Jordan Crouse
On 27/09/07 15:47 -0700, H. Peter Anvin wrote: > Jordan Crouse wrote: > > > > Breaks on the Geode - original behavior. > > > > I think that having boot_prams.e820_entries != 0 makes the kernel > > assume the e820 data is correct. > > > > Okay, now I'm utterly baffled how 2.6.22 ever worked on t

Re: [PATCH] kswapd should only wait on IO if there is IO

2007-09-27 Thread Rik van Riel
On Thu, 27 Sep 2007 15:59:07 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > And lost the changelog ;) Good point. The current kswapd (and try_to_free_pages) code has an oddity where the code will wait on IO, even if there is no IO in flight. This problem is notable especially when the system

Re: Problems with SMP & ACPI powering off

2007-09-27 Thread Mark Lord
Rafael J. Wysocki wrote: On Thursday, 27 September 2007 23:29, Mark Lord wrote: Question: do we disable all CPUs except 0 when doing ACPI power off? No, but we should. Background: I have a machine here dedicated to running MythTV. It powers up to record, and then sets the RTC alarm for next

Re: [Announce] Linux-tiny project revival

2007-09-27 Thread Rob Landley
On Thursday 27 September 2007 2:00:36 am Arnd Bergmann wrote: > #define KERN_NOTICE "<5>", > > #define PRINTK_CONTINUED "", > > #define printk(level, str, ...) \ >do { \ > if (sizeof(level) == 1) /* continued printk */\ > actual_printk(str, __VA_ARGS__); \ > else if ((level[1]

Re: [Bluez-devel] Warnings and Bug on 2.6.23-rc6 closing rfcomm links (device_move() API ?)

2007-09-27 Thread Marcel Holtmann
Hi Cornelia, > > >> Yet another report, once again while putting rfcomm system under load. > > >> Several USB adapters, several links. > > > > > > Is this a regression or does it happen with 2.6.22 too? > > > > I've not tested with 2.6.22, but have done it a few days ago with > > 2.6.21-2-486

Re: [PATCH] kswapd should only wait on IO if there is IO

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 18:50:27 -0400 Rik van Riel <[EMAIL PROTECTED]> wrote: > On Thu, 27 Sep 2007 15:21:21 -0700 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > Nope, sc.nr_io_pages will also be incremented when the code runs into > > > pages that are already PageWriteback. > > > > yup, I didn

Re: [PATCH] kswapd should only wait on IO if there is IO

2007-09-27 Thread Rik van Riel
On Thu, 27 Sep 2007 15:21:21 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > Nope, sc.nr_io_pages will also be incremented when the code runs into > > pages that are already PageWriteback. > > yup, I didn't think of that. Hopefully someone else will be in there > working on that zone too. If

[PATCH] removes array_size duplicates

2007-09-27 Thread roel
This patch removes some ARRAY_SIZE macro duplicates. There is also one in arch/um/include/user.h, which isn't fixed here because comments in that file explicitly state a preference for the 'less fancy' version. If that's the case as well for any of the other replacements please comment. Signed-off

Re: More E820 brokenness

2007-09-27 Thread H. Peter Anvin
Jordan Crouse wrote: > > Breaks on the Geode - original behavior. > > I think that having boot_prams.e820_entries != 0 makes the kernel > assume the e820 data is correct. > Okay, now I'm utterly baffled how 2.6.22 ever worked on this Geode, because this, to the best of my reading, mimics the 2.

Re: [PATCHSET 4/4] sysfs: implement new features

2007-09-27 Thread Kyle Moffett
On Sep 25, 2007, at 18:50:05, Greg KH wrote: On Thu, Sep 20, 2007 at 05:31:37PM +0900, Tejun Heo wrote: * Name-formatting for symlinks. e.g. symlink pointing to /dira/ dirb/leaf can be named as "symlink:%1-%0" and it will show up as "symlink:dirb-leaf". This only applies when new interface i

Re: [Announce] Linux-tiny project revival

2007-09-27 Thread Arnd Bergmann
On Thursday 27 September 2007, you wrote: > > Then you don't have to change every single printk in the kernel, but > > only those that don't currently come with a log level. More importantly, > > you can do the conversion without a flag day, by spreading (an empty) > > PRINTK_CONTINUED in places th

Re: More E820 brokenness

2007-09-27 Thread Jordan Crouse
On 27/09/07 15:17 -0700, H. Peter Anvin wrote: > As luck would have it, it's not just an obscure Geode system which has a > broken E820 implementation. Today I received a bug report about a Dell > system (XPS M1330) with broken E820. > > Unfortunately, the workaround for the Geode breaks this sys

Re: 2.6.23-rc7 - _random_ IRQ23 : nobody cared

2007-09-27 Thread Benjamin Herrenschmidt
On Thu, 2007-09-27 at 10:05 +, Paul Rolland wrote: > Hello, > > On Thu, 27 Sep 2007 19:04:11 +1000 > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > Let me guess... this is a T61 or X61 ? > Bad luck ;) > > This is an Asus P5W-DH Deluxe motherboard, with a Core2 6400 CPU, > a bunch

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Kyle Moffett
On Sep 27, 2007, at 17:34:45, Greg KH wrote: On Thu, Sep 27, 2007 at 02:37:42PM -0400, Theodore Tso wrote: That fact that sysfs is all laid out in a directory, but for which some directories/symlinks are OK to use, and some are NOT OK to use --- is why I call the sysfs interface "an open pit"

Re: [PATCH] kswapd should only wait on IO if there is IO

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 18:13:25 -0400 Rik van Riel <[EMAIL PROTECTED]> wrote: > On Thu, 27 Sep 2007 14:47:02 -0700 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Thu, 27 Sep 2007 17:08:16 -0400 > > Rik van Riel <[EMAIL PROTECTED]> wrote: > > > > > The current kswapd (and try_to_free_pages) cod

Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-27 Thread Jiri Kosina
On Thu, 27 Sep 2007, Andrew Morton wrote: > > +extern void arch_randomize_brk(void); > > #include "../../../fs/binfmt_elf.c" > Is this sinful extern-decl-in-C acually needed? Some time passed since I have written the patch, but I remember that this was needed, otherwise under some circumstance

More E820 brokenness

2007-09-27 Thread H. Peter Anvin
As luck would have it, it's not just an obscure Geode system which has a broken E820 implementation. Today I received a bug report about a Dell system (XPS M1330) with broken E820. Unfortunately, the workaround for the Geode breaks this system, because x86-64 doesn't fall back to the e801/88 info

[PATCH] clockevents: fix bogus next_event reset for oneshot broadcast devices

2007-09-27 Thread Thomas Gleixner
In periodic broadcast mode the next_event member of the broadcast device structure is set to KTIME_MAX in the interrupt handler. This is wrong, as we calculate the next periodic interrupt with this variable. Remove it. Noticed by Ralf. MIPS is the first user of this mode, it does not affect exist

Re: 2.6.23-rc8-mm1 -- powerpc link failure

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 14:13:21 +0200 (CEST) Jiri Kosina <[EMAIL PROTECTED]> wrote: > i386 and x86_64: randomize brk() > > ... > > --- a/arch/x86_64/ia32/ia32_binfmt.c > +++ b/arch/x86_64/ia32/ia32_binfmt.c > @@ -262,6 +262,7 @@ static void elf32_init(struct pt_regs *); > #define ARCH_HAS_SETUP_ADD

Re: [PATCH] kswapd should only wait on IO if there is IO

2007-09-27 Thread Rik van Riel
On Thu, 27 Sep 2007 14:47:02 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 27 Sep 2007 17:08:16 -0400 > Rik van Riel <[EMAIL PROTECTED]> wrote: > > > The current kswapd (and try_to_free_pages) code has an oddity where the > > code will wait on IO, even if there is no IO in flight. Thi

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-09-27 Thread Matthew Wilcox
On Thu, Sep 27, 2007 at 05:00:22PM -0500, Linas Vepstas wrote: > On Wed, Sep 26, 2007 at 09:02:16AM -0600, Matthew Wilcox wrote: > > I'm a little concerned by the mention of MMIO. It's entirely possible > > for the sym2 driver to be using ioports to access the card rather than > > MMIO. Is it sim

Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

2007-09-27 Thread Peter Zijlstra
On Thu, 2007-09-27 at 14:51 -0700, Andrew Morton wrote: > So your stuff becomes dependent on Nick's stuff, and Nick's stuff is still > failing on NFS, I think. It worked today, it turned out to be a UML bug. Real hardware seemed to work properly, but will test a bit more tomorrow. - To unsubscr

Re: Why do so many machines need "noapic"?

2007-09-27 Thread Phillip Susi
Dave Jones wrote: If memory serves correctly, that was circa 2.6.10, back in these commits.. commit a068ea13d1db406e15c346e93530343f6e70184c Author: Len Brown <[EMAIL PROTECTED]> Date: Sun Oct 10 05:21:08 2004 -0400 [ACPI] If BIOS disabled the LAPIC, believe it by default. "lapic" is

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-09-27 Thread Linas Vepstas
On Wed, Sep 26, 2007 at 09:02:16AM -0600, Matthew Wilcox wrote: > On Fri, Apr 20, 2007 at 03:47:20PM -0500, Linas Vepstas wrote: > > Implement the so-called "first failure data capture" (FFDC) for the > > symbios PCI error recovery. After a PCI error event is reported, > > the driver requests that

Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 14:51:25 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > Plus, reiserfs seems to compile with that patch I just sent. Sure as > > heck surprised me. > > > > That'll be because reiserfs-convert-to-new-aops.patch witched reiserfs over > to ->write_begin() and ->write_end().

2.6.23-rc8-mm2 NULL dereference in __mnt_is_readonly in ftruncate

2007-09-27 Thread Zan Lynx
Kernel 2.6.23-rc8-mm2 on a AMD-64, filesystems mounted are reiserfs, reiser4 and tmpfs. netconsole dmesg output and .config are included below. Near the end of my boot sequence, there is a kernel error. I am not sure exactly what user-space is doing to make this happen, but I know that a simple s

Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 14:27:14 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote: > On Thu, 2007-09-27 at 22:04 +0100, Christoph Hellwig wrote: > > On Thu, Sep 27, 2007 at 01:53:39PM -0700, Dave Hansen wrote: > > > -int reiserfs_commit_write(struct file *f, struct page *page, > > > - uns

Re: [PATCH] kswapd should only wait on IO if there is IO

2007-09-27 Thread Andrew Morton
On Thu, 27 Sep 2007 17:08:16 -0400 Rik van Riel <[EMAIL PROTECTED]> wrote: > The current kswapd (and try_to_free_pages) code has an oddity where the > code will wait on IO, even if there is no IO in flight. This problem is > notable especially when the system scans through many unfreeable pages,

  1   2   3   4   >