Re: [PATCH] zero_user_page uses in fs/buffer.c and fs/libfs.c

2007-04-29 Thread Satyam Sharma
On 4/30/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: There are a couple of places where kmap_atomic is surrounding two memory operations. Usually only one of them is performed. So it is possible to also use zero_user_page there. I do like the patch, but would prefer if you'd give a better/c

Re: [PATCH linux-2.6-block.git] Fix blktrace trace ordering for plug branch

2007-04-29 Thread Jens Axboe
On Fri, Apr 27 2007, Alan D. Brunelle wrote: > The attached patch will correct the ordering of trace output between > request queue insertions (I) and unplug calls (U). Right now the insert > precedes the unplug, which just isn't right: > > 65,128 0167.699868965 7882 Q R 0 + 1 [

Re: [DOC] Fix wrong identifier name in Documentation/driver-model/devres.txt

2007-04-29 Thread Greg KH
On Sun, Apr 29, 2007 at 04:50:29PM +0900, Tejun Heo wrote: > Jeff Garzik wrote: > > Now that devres is in the kernel, I don't think I am the best person to > > merge these sort of patches. Certainly I can, and I know the code from > > my original review and subsequent usage, but I think the patch

Re: Linux 2.6.21

2007-04-29 Thread Andrew Morton
On Mon, 30 Apr 2007 00:09:06 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Sunday, 29 April 2007 22:52, Alexey Dobriyan wrote: > > On Sun, Apr 29, 2007 at 10:18:10PM +0200, Rafael J. Wysocki wrote: > > > [For example, you can create a bugzilla entry with a link to the lkml.org > > >

man-pages-2.45 and man-pages-2.46 are released

2007-04-29 Thread Michael Kerrisk
Gidday, I just released man-pages-2.45 and man-pages-2.46. These releases are now available for download at: ftp://ftp.kernel.org/pub/linux/docs/manpages or mirrors: ftp://ftp.XX.kernel.org/pub/linux/docs/manpages and soon at: ftp://ftp.win.tue.nl/pub/linux-local/manpages These re

Re: [PATCH] usb/hid:The HID Simple Driver Patches 0.5.1

2007-04-29 Thread Jiri Kosina
On Mon, 30 Apr 2007, Li Yu wrote: > This patch set include : > 1. usb/hid: The HID Simple Driver Interface 0.5.0 (core) > 2. usb/hid:Microsoft Natural Ergonomic Keyboard 4000 Driver 0.5.1 > 3. Some related kbuild changes. > The changelog since 0.5.0: > 1. The parameter asci

Re: Linux 2.6.21

2007-04-29 Thread Tomasz Chmielewski
Adrian Bunk schrieb: On Sun, Apr 29, 2007 at 11:04:10PM +0200, Tomasz Chmielewski wrote: Linus Torvalds wrote: On Sun, 29 Apr 2007, Adrian Bunk wrote: The kernel Bugzilla currently contains 1600 open bugs. Adrian, why do you keep harping on this, and ignoring reality? Kernel bugzilla has 160

[PATCH] usb/hid:The HID Simple Driver Patches 0.5.1

2007-04-29 Thread Li Yu
This patch set include : 1. usb/hid: The HID Simple Driver Interface 0.5.0 (core) 2. usb/hid:Microsoft Natural Ergonomic Keyboard 4000 Driver 0.5.1 3. Some related kbuild changes. The changelog since 0.5.0: 1. The parameter ascii_keycode of usbnek4k.ko is

[PATCH] zero_user_page uses in fs/buffer.c and fs/libfs.c

2007-04-29 Thread Christoph Lameter
There are a couple of places where kmap_atomic is surrounding two memory operations. Usually only one of them is performed. So it is possible to also use zero_user_page there. Cc: Nate Diller <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/buffer.c | 29

Re: Linux 2.6.21

2007-04-29 Thread Tomasz Chmielewski
David Miller wrote: > I reported a bug that eats people's hard disks due to a bug > in the X.ORG PCI support code on sparc, NOBODY has fixed > the bug in 2 years even though a full bugzilla entry with > even a full patch fix is in there. Well but at least they could find it again if they wanted

Re: [PATCH 0/5] fallocate system call

2007-04-29 Thread Chris Wedgwood
On Mon, Apr 30, 2007 at 03:56:32PM +1000, David Chinner wrote: > On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: > IIRC, the argument for FA_ALLOCATE changing file size is that > posix_fallocate() is supposed to change the file size. But it's not posix_fallocate; it's something mo

Re: can a kmalloc be both GFP_ATOMIC and GFP_KERNEL at the same time?

2007-04-29 Thread Christoph Lameter
On Sat, 28 Apr 2007, Alan Cox wrote: > > > drivers/scsi/aic7xxx_old.c: aic_dev = kmalloc(sizeof(struct > > > aic_dev_data), GFP_ATOMIC | GFP_KERNEL); > > > drivers/message/i2o/device.c: resblk = kmalloc(buflen + 8, GFP_KERNEL | > > > GFP_ATOMIC); > > > > > > clarification? > > > > oh, i'm

Re: [PATCH 0/5] fallocate system call

2007-04-29 Thread David Chinner
On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote: > On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote: > > > For FA_ALLOCATE, it's supposed to change the file size if we > > allocate past EOF, right? > > I would argue no. Use truncate for that. I'm going from the ext4

Re: [PATCH] [9/26] x86_64: Fix vmalloc_32 to really allocate <4GB on 64bit platforms

2007-04-29 Thread Borislav Petkov
Sorry, I meant this one: Index: 2.6.21/mm/vmalloc.c === --- 2.6.21.orig/mm/vmalloc.c +++ 2.6.21/mm/vmalloc.c @@ -577,6 +577,16 @@ void *vmalloc_exec(unsigned long size) return __vmalloc(size, GFP_KERNEL | __GFP_HIGHMEM, PAGE_

Re: Incorrect order of last two arguments of ptrace for requests PPC_PTRACE_GETREGS, SETREGS, GETFPREGS, SETFPREGS

2007-04-29 Thread Paul Mackerras
Anton Blanchard writes: > I looked at this a while ago and my decision at the time was to keep the > old implementation around for a while and create two new ones that match > the x86 numbering: > > #define PTRACE_GETREGS12 > #define PTRACE_SETREGS13 > #define PTRACE_GETFP

Re: Linux 2.6.21

2007-04-29 Thread Willy Tarreau
On Sun, Apr 29, 2007 at 07:37:25PM +0200, Andi Kleen wrote: > > My personal experience with bugzilla is that it's very unfriendly to > > reporters. IMHO it's suitable for tracking unresolved problems along with > > debug patches, system information etc., but not for _reporting_ new ones. > > What

[PATCH] Propagate errors from find in scripts/gen_initramfs_list.sh

2007-04-29 Thread Michael Ellerman
If the find(1) in scripts/gen_initramfs_list.sh generates any errors, it will cause gen_initramfs_list.sh to fail (because of "set -e"), however the errors from find are not printed to the user. This is rather confusing: ~/src/powerpc$ make O=~/build/powerpc-cell32/ make[2]: *** [usr/initramfs_dat

Re: [00/17] Large Blocksize Support V3

2007-04-29 Thread Christoph Lameter
On Fri, 27 Apr 2007, Andrew Morton wrote: > By misunderstanding any suggestions, misrepresenting them, making incorrect > statements about them, by not suggesting any alternatives yourself, all of > it buttressed by a stolid refusal to recognise that this patch has any > costs. That was even ment

Re: [patches] [PATCH] [21/22] x86_64: Extend bzImage protocol for relocatable bzImage

2007-04-29 Thread Eric W. Biederman
Rusty Russell <[EMAIL PROTECTED]> writes: > On Sun, 2007-04-29 at 21:38 -0700, H. Peter Anvin wrote: >> Rusty Russell wrote: >> > >> > Dammit, Eric, you spend a lot of time using words like "insane" where >> > you mean we didn't do everything all at once. >> > >> > It's *not* clear that using %e

Re: [PATCH 0/5] fallocate system call

2007-04-29 Thread Chris Wedgwood
On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote: > For FA_ALLOCATE, it's supposed to change the file size if we > allocate past EOF, right? I would argue no. Use truncate for that. > For FA_DEALLOCATE, does it change the filesize at all? Same as above. > Or does > it just punch

Re: 2.6.21-rc7-mm2 hangs in boot

2007-04-29 Thread Andrew Morton
On Sun, 29 Apr 2007 22:01:32 -0700 Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Wed, 25 Apr 2007 22:57:16 -0700 Andrew Morton wrote: > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc7/2.6.21-rc7-mm2/ > > I'm getting a hang near the end of booting on x86_64 UP. >

Re: [00/17] Large Blocksize Support V3

2007-04-29 Thread Christoph Lameter
On Sat, 28 Apr 2007, Maxim Levitsky wrote: > 1) Is it possible for block device to assume that it will alway get big > requests (and aligned by big blocksize) ? That is one of the key problems. We hope that Mel Gorman's antifrag work will get us there. > 2) Does metadata reading/writing occur

Re: [patch] CFS scheduler, -v7

2007-04-29 Thread Al Boldi
Ingo Molnar wrote: > > i'm pleased to announce release -v7 of the CFS scheduler patchset. (The > main goal of CFS is to implement "desktop scheduling" with as high > quality as technically possible.) : : > As usual, any sort of feedback, bugreport, fix and suggestion is more > than welcome, This o

gdb-6.4: is not handling input 'q' properly

2007-04-29 Thread Dharmosoth Seetharam
Hi, The following result was the effect of "info threads" command Architecture: x86_64 , Linux kernel : 2.6.7 and 2.6.20 34 process 541 0xa017544e in ?? () 33 process 540 schedule_timeout (timeout=1101144554856) at kernel/timer.c:1164 32 process 493 md_thread (arg=0xfff

Re: Linux 2.6.21

2007-04-29 Thread Gene Heskett
On Monday 30 April 2007, Bernd Eckenfels wrote: >In article <[EMAIL PROTECTED]> you wrote: >> You can't have it even do a search to see if it already has something >> similar without creating an account and logging in. Since I'm out of wall >> space, and the missus is bugging me to paint over all

Re: [patches] [PATCH] [21/22] x86_64: Extend bzImage protocol for relocatable bzImage

2007-04-29 Thread Rusty Russell
On Sun, 2007-04-29 at 21:38 -0700, H. Peter Anvin wrote: > Rusty Russell wrote: > > > > Dammit, Eric, you spend a lot of time using words like "insane" where > > you mean we didn't do everything all at once. > > > > It's *not* clear that using %esi is sane, but nothing in the current > > code pre

Re: Linux 2.6.21

2007-04-29 Thread Kyle Moffett
It might not be bad to write up an email-based BTS-alike bug-tracking system just for the Linux kernel. It should probably even be implemented 100% via email at first, with a web-based status viewer as a later add-on. Here's a possible email format: [kbugger: action1 arg1 arg2 ..., action

Re: [PATCH] [9/26] x86_64: Fix vmalloc_32 to really allocate <4GB on 64bit platforms

2007-04-29 Thread Borislav Petkov
On Mon, Apr 30, 2007 at 01:46:18AM +0200, Andi Kleen wrote: > > Ugly ifdef, but should handle all 64bit platforms that have suitable > zones. On some like Altix it's probably impossible without IOMMU > use to get memory <4GB this way, but they have to live with that. > Signed-off-by: Andi Kleen <

Re: Linux 2.6.21

2007-04-29 Thread Bernd Eckenfels
In article <[EMAIL PROTECTED]> you wrote: > You can't have it even do a search to see if it already has something similar > without creating an account and logging in. Since I'm out of wall space, and > the missus is bugging me to paint over all that, I left. Well, thats not a bugzilla problem.

Re: [patch 03/32] xen: Add nosegneg capability to the vsyscall page notes

2007-04-29 Thread Jeremy Fitzhardinge
Roland McGrath wrote: > I wouldn't add that macro to asm/elf.h. There is nothing magical or > standard about that number. > It was just there for a later patch to set/clear the mask dynamically depending on whether we're running under Xen. But I haven't implemented that yet. J - To unsub

Re: Linux 2.6.21

2007-04-29 Thread Bernd Eckenfels
In article <[EMAIL PROTECTED]> you wrote: > If it is considered useful it shouldn't be a problem to automatically > forward all incoming Bugzilla bugs to linux-kernel. Yes, most of it to linux-kernel, some components (netdev@, architecture) to a more specific list. Gruss Bernd - To unsubscribe f

Slab allocators: Remove useless __GFP_NO_GROW flag (fwd)

2007-04-29 Thread Christoph Lameter
Forgot to CC lkml. -- Forwarded message -- Date: Sun, 29 Apr 2007 21:52:32 -0700 (PDT) From: Christoph Lameter <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: Slab allocators: Remove useless __GFP_NO_GROW flag There is no user remaining and I have never seen any use of that fla

Re: vmstat: use our own timer events

2007-04-29 Thread Christoph Lameter
On Sun, 29 Apr 2007, Andrew Morton wrote: > > on each node at the second and then each of the other processor on a > > node on a subsequent tick. That may be useful to keep a large amount > > of the second free of timer activity. Maybe the timer folks will have > > some feedback on this one? > >

Re: [patches] [PATCH] [21/22] x86_64: Extend bzImage protocol for relocatable bzImage

2007-04-29 Thread Rusty Russell
On Sun, 2007-04-29 at 00:24 -0700, Jeremy Fitzhardinge wrote: > Is it possible to decompress and extract the kernel image from the > bzImage without executing it? Ie, is there enough information to find > the compressed data part of the bzImage by inspection? > > At some point we'll need to chang

Re: [patches] [PATCH] [21/22] x86_64: Extend bzImage protocol for relocatable bzImage

2007-04-29 Thread H. Peter Anvin
Rusty Russell wrote: > > Dammit, Eric, you spend a lot of time using words like "insane" where > you mean we didn't do everything all at once. > > It's *not* clear that using %esi is sane, but nothing in the current > code prevents that. > Why not? -hpa - To unsubscribe from this list:

Re: utrace comments

2007-04-29 Thread Roland McGrath
I'm sorry I've taken so long to reply to your review comments. I won't dwell on that, and just dive into the discussion. > --- linux-2.6/include/asm-i386/thread_info.h.utrace-ptrace-compat > +++ linux-2.6/include/asm-i386/thread_info.h > @@ -135,13 +135,13 @@ static inline struct thread_info *curr

Re: [PATCH] utrace: remove indirections

2007-04-29 Thread Roland McGrath
I am not in favor of this change. Previously you said: > This shows very nicely why the tracehooks vs utrace abstraction > is utter madness. Every tracehook 'abstraction' just conatains > an ifdef block. Just kill CONFIG_UTRACE as there is no point > in making this funct

Re: [PATCH] utrace: remove exports

2007-04-29 Thread Roland McGrath
> All the exports in utrace are totally unused, and not really something > I'd want modules to use anyway :) Previously you said: > EXPORT_SYMBOL_GPL(utrace_attach); > > There is not modular user of this, so this and the other utrace_ > functions should not be exported. Nor do I thi

[PATCH] Move sig_kernel_* et al macros to linux/signal.h

2007-04-29 Thread Roland McGrath
This patch moves the sig_kernel_* and related macros from kernel/signal.c to linux/signal.h, and cleans them up slightly. I need the sig_kernel_* macros for default signal behavior in the utrace code, and want to avoid duplication or overhead to share the knowledge. Signed-off-by: Roland McGrath

Re: [-mm patch] i386: enable 4k stacks by default

2007-04-29 Thread David Chinner
On Sat, Apr 28, 2007 at 03:18:38PM -0600, Zan Lynx wrote: > On Sat, 2007-04-28 at 21:19 +0200, Adrian Bunk wrote: > > 4k stacks have become a well-tested feature used fore a long time in > > Fedora and even in RHEL 4. > > So has anyone fixed the bugs involving ext3 and LVM snapshots on top of > DM

Re: [PATCH] x86_64: support poll() on /dev/mcelog

2007-04-29 Thread Tim Hockin
Crap - I have just got soft lockup detected. Back to debug. Call Trace: [] wake_up_process+0x10/0x20 [] softlockup_tick+0xea/0x110 [] run_local_timers+0x13/0x20 [] update_process_times+0x57/0x90 [] mcheck_check_cpu+0x0/0x40 [] smp_local_timer_interrupt+0x34/0x60 [] smp_apic_timer_interru

[PATCH 1/1] fs: add 4th case to do_path_lookup

2007-04-29 Thread Josef Sipek
Signed-off-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> diff --git a/fs/namei.c b/fs/namei.c index 2995fba..1516a9b 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1125,6 +1125,10 @@ static int fastcall do_path_lookup(int dfd, const char *name, nd->mnt = mntget(fs->rootmnt);

[PATCH 0/1] [RFC] New mode for path_lookup (V1)

2007-04-29 Thread Josef Sipek
Stackable file systems frequently need to lookup paths or path components starting from an arbitrary point in the namespace (identified by a dentry and a vfsmount). Currently, such file systems use lookup_one_len, which is frowned upon [1] as it does not pass the lookup intent along; not passing a

[PATCH] Add preallocation beyond EOF to fallocate

2007-04-29 Thread David Chinner
Add new mode to ->fallocate() to allow allocation to occur beyond the current EOF without changing the file size. Implement in XFS ->fallocate() vector. Signed-Off-By: Dave Chinner <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_iops.c |8 +--- include/linux/fs.h |1 + 2 files

[PATCH 1/2] atl1: use dev_printk macros

2007-04-29 Thread Jay Cliburn
Use dev_printk macros for PCI related errors, warnings, debug and info console messages. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_ethtool.c | 19 +++-- drivers/net/atl1/atl1_hw.c | 22 +-- drivers/net/atl1/atl1_main.c| 83

[PATCH 0/2] atl1: minor cleanup

2007-04-29 Thread Jay Cliburn
Please accept the following trivial patches to the atl1 driver. - use dev_printk macros - fix whitespace damage drivers/net/atl1/atl1_ethtool.c | 19 +++-- drivers/net/atl1/atl1_hw.c | 44 ++--- drivers/net/atl1/atl1_main.c| 83 +---

[PATCH 2/2] atl1: fix whitespace damage

2007-04-29 Thread Jay Cliburn
Remove trailing whitespace and spaces preceding tabs. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> --- drivers/net/atl1/atl1_hw.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/atl1/atl1_hw.c b/drivers/net/atl1/atl1_hw.c index 5b9dd3c

[PATCH] XFS ->fallocate() support

2007-04-29 Thread David Chinner
Add XFS support for ->fallocate() vector. Signed-Off-By: Dave Chinner <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_iops.c | 48 1 file changed, 48 insertions(+) Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_iops.c ==

[PATCH] ia64 fallocate syscall

2007-04-29 Thread David Chinner
ia64 fallocate syscall support. Signed-Off-By: Dave Chinner <[EMAIL PROTECTED]> --- arch/ia64/kernel/entry.S |1 + include/asm-ia64/unistd.h |3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) Index: 2.6.x-xfs-new/arch/ia64/kernel/entry.S ===

[patch]add the ATI SB700 SATA controller device id to AHCI pci table

2007-04-29 Thread Henry Su
From: [EMAIL PROTECTED] Adding the device ID to AHCI pci table for ATI SB700 SATA controller, the subsequent chipset of SB600. Signed-off-by:henry su<[EMAIL PROTECTED]> diff -Nur linux-2.6.21.orig/drivers/ata/ahci.c linux-2.6.21/drivers/ata/ahci.c --- linux-2.6.21.orig/

Re: [patches] [PATCH] [21/22] x86_64: Extend bzImage protocol for relocatable bzImage

2007-04-29 Thread Rusty Russell
On Sun, 2007-04-29 at 09:11 -0600, Eric W. Biederman wrote: > Right now I'm a little frustrated that insanity below slipped into > head.S right after the 32bit entry point after the review said > use the normal linux parameters for parameter passing. > > > #ifdef CONFIG_PARAVIRT > >

Re: Linux 2.6.21

2007-04-29 Thread Adrian Bunk
On Sun, Apr 29, 2007 at 11:04:10PM +0200, Tomasz Chmielewski wrote: > Linus Torvalds wrote: > >> On Sun, 29 Apr 2007, Adrian Bunk wrote: >>> The kernel Bugzilla currently contains 1600 open bugs. >> Adrian, why do you keep harping on this, and ignoring reality? >> Kernel bugzilla has 1600 open bugs

Re: 2.6.21-rc7-mm1 BUG at kernel/sched-clock.c:175 init_sched_clock()

2007-04-29 Thread Tejun Heo
Hello. Berck E. Nash wrote: > Okay, while this patch allows my system to boot, it eventually crashed. > Unfortunately, I don't know enough to know if this crash is at all > related, but it seems like it might be? > > [ 1314.960784] irq 316: nobody cared (try booting with the "irqpoll" option) >

Re: [RFC PATCH] PCI MMCONFIG: add validation against ACPI motherboard resources

2007-04-29 Thread Randy Dunlap
On Sun, 29 Apr 2007 20:14:37 -0600 Robert Hancock wrote: > diff -up linux-2.6.21.1/arch/i386/pci/mmconfig-shared.c > linux-2.6.21.1edit/arch/i386/pci/mmconfig-shared.c > --- linux-2.6.21.1/arch/i386/pci/mmconfig-shared.c2007-04-27 > 15:49:26.0 -0600 > +++ linux-2.6.21.1edit/arch/i386

[patch] Add the combined mode for ATI SB700

2007-04-29 Thread Henry Su
From: [EMAIL PROTECTED] Besides those modes in ATI SB600 SATA controller, ATI SB700 supports one more mode:the combined mode. \ The combined mode is a Legacy IDE mode used for compatibility with some old OS without AHCI driver, \ but now it is not necessary for Linux since the kernel has supported

[PATCH] x86_64: support poll() on /dev/mcelog

2007-04-29 Thread Tim Hockin
From: Tim Hockin <[EMAIL PROTECTED]> Background: /dev/mcelog is typically polled manually. This is less than optimal for some situations. Calling poll() on /dev/mcelog does not work. Description: This patch adds support for poll() to /dev/mcelog. This results in immediate wakeup of user ap

[RFC PATCH] PCI MMCONFIG: add validation against ACPI motherboard resources

2007-04-29 Thread Robert Hancock
This path adds validation of the MMCONFIG table against the ACPI reserved motherboard resources. If the MMCONFIG table is found to be reserved in ACPI, we don't bother checking the E820 table. The PCI Express firmware spec apparently tells BIOS developers that reservation in ACPI is required and E

Re: [PATCH] support PCI MCFG space on Intel i915 bridges

2007-04-29 Thread Robert Hancock
Jesse Barnes wrote: Add support for Intel 915 bridge chips to the new PCI MMConfig detection code. Tested and works on my sole 915 based platform (a Toshiba laptop). I added register masking per Oliver's suggestion, and moved the __init qualifier to after the 'static const char' to match Ogawa-

Re: checkpatch, a patch checking script.

2007-04-29 Thread Matt Mackall
On Sun, Apr 29, 2007 at 05:18:00PM -0700, Randy Dunlap wrote: > Matt Mackall wrote: > >On Sun, Apr 29, 2007 at 04:37:01PM -0700, Randy Dunlap wrote: > >>On Sat, 28 Apr 2007 12:21:54 -0500 Matt Mackall wrote: > >> > >>>On Sat, Apr 28, 2007 at 01:11:01PM -0400, Dave Jones wrote: > On Sat, Apr 28,

Re: NR_UNSTABLE_FS vs. NR_FILE_DIRTY: double counting pages?

2007-04-29 Thread Trond Myklebust
On Sun, 2007-04-29 at 17:26 -0700, Ethan Solomita wrote: > Trond Myklebust wrote: > > On Fri, 2007-04-27 at 18:21 -0700, Ethan Solomita wrote: > >> There are several places where we add together NR_UNSTABLE_FS and > >> NF_FILE_DIRTY: > >> > >> sync_inodes_sb() > >> balance_dirty_pages() > >> wakeup

Re: Linux 2.6.21

2007-04-29 Thread Gene Heskett
On Sunday 29 April 2007, Michal Piotrowski wrote: >Hi Diego, > >On 29/04/07, Diego Calleja <[EMAIL PROTECTED]> wrote: >[..] > >> So unless someone is willing to write such tool (which I doubt, since it >> doesn't looks easy), all this discussion seems pointless, and we should >> stick with this htt

Re: Critical points about kernel 2.6.21 and pseudo-authorities

2007-04-29 Thread Trent Piepho
On Sun, 29 Apr 2007, Linus Torvalds wrote: > On Sun, 29 Apr 2007, Uwe Bugla wrote: > > > BUT: This 2.6.21-git2 is unusable in so far as it contains regressive code > > in the dvb-section, authored by Trent Piepho, acked by Michael Krufky, and > > signed-off-by Mauro Carvalho Chehab: > > You never

Re: NR_UNSTABLE_FS vs. NR_FILE_DIRTY: double counting pages?

2007-04-29 Thread Ethan Solomita
Ethan Solomita wrote: Trond Myklebust wrote: It should not happen. If the page is on the unstable list, then it will be committed before nfs_updatepage is allowed to redirty it. See the recent fixes in 2.6.21-rc7. Above I present a codepath called straight from sys_write() which seems to

Re: Linux 2.6.21

2007-04-29 Thread Björn Steinbrink
[Oops, the first try of this mail got out from my local address, sorry] On 2007.04.29 19:55:35 -0400, Theodore Tso wrote: > On Sun, Apr 29, 2007 at 03:15:42PM +0200, Andi Kleen wrote: > > This means we need people who figure out who to assign bugs too. > > Aka bugmasters. > > > > BTW one big prob

Re: [patch 20/38] Minor fault path optimization.

2007-04-29 Thread Paul Mackerras
Christoph Hellwig writes: > Well, here's my powerpc patch to do the direct call that I sent out > a few weeks ago. It not just speed up the pagefault path a lot, > but also is a major code cleanup. Andi and Anton didn't like it > because they have ambition for murky debugger code to possibly >

Re: checkpatch, a patch checking script.

2007-04-29 Thread Randy Dunlap
On Fri, 27 Apr 2007 22:18:03 -0700 Andrew Morton wrote: > On Fri, 27 Apr 2007 23:08:05 -0400 Dave Jones <[EMAIL PROTECTED]> wrote: > > > You can find the script at http://www.codemonkey.org.uk/projects/checkpatch/ > > hm. > ... > box:/usr/src/25> ~/checkpatch.pl patches/git-powerpc.patch > Che

Re: [linux-dvb] Re: Critical points about kernel 2.6.21 and pseudo-authorities

2007-04-29 Thread hermann pitton
Am Montag, den 30.04.2007, 01:00 +0200 schrieb Uwe Bugla: > Original-Nachricht > Datum: Sun, 29 Apr 2007 14:19:22 -0700 (PDT) > Von: Linus Torvalds <[EMAIL PROTECTED]> > An: Uwe Bugla <[EMAIL PROTECTED]> > CC: [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], > linux-kerne

Re: [PATCH 0/5] fallocate system call

2007-04-29 Thread David Chinner
On Thu, Apr 26, 2007 at 11:20:56PM +0530, Amit K. Arora wrote: > Based on the discussion, this new patchset uses following as the > interface for fallocate() system call: > > asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len) Ok, so now for the hard questions - what are t

Re: ACPI interpreter errors (aer_init)

2007-04-29 Thread Dave Jones
On Sat, Apr 28, 2007 at 02:31:52AM -0400, Len Brown wrote: > On a quick glance, it appears that these messages have been in the aer driver > since it was born. > Did you run with CONFIG_PCIEAER in 2.6.19 or 2.6.20 and not have them there? > > I agree with Bob, as status 5 is AE_NOT_FOUND, >

Re: checkpatch, a patch checking script.

2007-04-29 Thread Randy Dunlap
On Fri, 27 Apr 2007 20:36:17 -0700 Roland Dreier wrote: > > http://www.codemonkey.org.uk/projects/checkpatch/example.log shows > > what fell out of running it on my mbox of lkml from the past month. > > Some of them are kinda noisy, and perhaps should be moved under --pedantic > > > > I'm al

Re: Linux 2.6.21

2007-04-29 Thread Andi Kleen
Theodore Tso <[EMAIL PROTECTED]> writes: > > Folks might want to take a look at the Debian Bug Tracking System > (BTS). It has a web interface which you can use to query history, but > *everything* is e-mail driven, and the way you submit, close, update, > tag/classfy bugs --- everything --- is v

Re: Why ask Sun for ZFS while we have ReiserFS4 !?

2007-04-29 Thread Chris Adams
Once upon a time, Theodore Tso <[EMAIL PROTECTED]> said: >The people who want ZFS have in mind certain features, such as the >ability to scale to very large sizes, and ease of use when >administering filesystems that span multiple disks (ZFS subsumes the >device-mapper/RAID layer in Solaris, so th

Re: NR_UNSTABLE_FS vs. NR_FILE_DIRTY: double counting pages?

2007-04-29 Thread Ethan Solomita
Trond Myklebust wrote: On Fri, 2007-04-27 at 18:21 -0700, Ethan Solomita wrote: There are several places where we add together NR_UNSTABLE_FS and NF_FILE_DIRTY: sync_inodes_sb() balance_dirty_pages() wakeup_pdflush() wb_kupdate() prefetch_suitable() I can trace a standard codepath where it

Re: [linux-dvb] Re: [PATCH] Re: More than 2Gb problem (dvb related) ?

2007-04-29 Thread Oliver Endriss
Jon Burgess wrote: > On Sat, 2007-04-28 at 18:17 +0100, Jon Burgess wrote: > > On Fri, 2007-04-27 at 18:06 -0400, Lee Revell wrote: > > > On 4/27/07, Jon Burgess <[EMAIL PROTECTED]> wrote: > > > > Interesting - I see similar symptoms after upgrading my PC: > > > > * old PC was AMD Athlon 64 3000 w/

Re: "REPORT: sd-0.46 vs cfs-v6 vs mainline 2.6.21-rc7 Beryl + Video + Audio"

2007-04-29 Thread hechacker1
Another update: This is the same testing but for cfs-v7. Summary: 1. context switch rate is much higher than for cfs-v6 for the same sched_granularity_ns 20 2. Video playback suffered. FPS is much lower. 3. Trying different values of sched-granularity_ns didn't help (neither did the default)

Re: Linux 2.6.21

2007-04-29 Thread Dave Jones
On Sun, Apr 29, 2007 at 07:55:35PM -0400, Theodore Tso wrote: > but if the goal is to > make it easier to archive and track information about a bug, at > *least* with the Debian BTS, when you reply to an e-mail message, the > reply is automatically appended to the bug log! bugzilla does that

Re: checkpatch, a patch checking script.

2007-04-29 Thread Randy Dunlap
Matt Mackall wrote: On Sun, Apr 29, 2007 at 04:37:01PM -0700, Randy Dunlap wrote: On Sat, 28 Apr 2007 12:21:54 -0500 Matt Mackall wrote: On Sat, Apr 28, 2007 at 01:11:01PM -0400, Dave Jones wrote: On Sat, Apr 28, 2007 at 11:11:36AM -0500, Matt Mackall wrote: > > I'm all ears for additional r

Re: checkpatch, a patch checking script.

2007-04-29 Thread Matt Mackall
On Sun, Apr 29, 2007 at 04:37:01PM -0700, Randy Dunlap wrote: > On Sat, 28 Apr 2007 12:21:54 -0500 Matt Mackall wrote: > > > On Sat, Apr 28, 2007 at 01:11:01PM -0400, Dave Jones wrote: > > > On Sat, Apr 28, 2007 at 11:11:36AM -0500, Matt Mackall wrote: > > > > > I'm all ears for additional regexp

Re: [PATCH] [19/26] i386: Enable bank 0 on non K7 Athlon

2007-04-29 Thread Dave Jones
On Mon, Apr 30, 2007 at 01:46:28AM +0200, Andi Kleen wrote: > > As a bug workaround bank 0 on K7s is normally disabled, but no need > to do that on other AMD CPUs. > > Cc: [EMAIL PROTECTED] > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> ACK, looks good to me. thanks, Dave

Re: [2.6.21] BUG: clocksource_watchdog isn't reset after resume

2007-04-29 Thread Indan Zupancic
On Sun, April 29, 2007 21:25, Thomas Gleixner wrote: > --- linux-2.6.orig/kernel/time/tick-common.c > +++ linux-2.6/kernel/time/tick-common.c > @@ -308,16 +308,20 @@ static void tick_suspend(void) > spin_unlock_irqrestore(&tick_device_lock, flags); > } > > -static void tick_resume(void) > +s

Re: Linux 2.6.21

2007-04-29 Thread Indan Zupancic
On Mon, April 30, 2007 01:41, Johannes Stezenbach wrote: > Developers are just humans and if they have no incentive to > act on a bug report they will ignore it. I think this is a > fact that you have to deal with. Reporters are just humans too and if they have no incentive to post bugs they won't

[PATCH] [19/26] i386: Enable bank 0 on non K7 Athlon

2007-04-29 Thread Andi Kleen
As a bug workaround bank 0 on K7s is normally disabled, but no need to do that on other AMD CPUs. Cc: [EMAIL PROTECTED] Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/i386/kernel/cpu/mcheck/k7.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Index: linux/arch/i386/

Re: Linux 2.6.21

2007-04-29 Thread Theodore Tso
On Sun, Apr 29, 2007 at 03:15:42PM +0200, Andi Kleen wrote: > This means we need people who figure out who to assign bugs too. > Aka bugmasters. > > BTW one big problem in our current bugzilla is that a lot of people > cannot reassign bugs they don't own. I sometimes see bugs that I don't > own bu

[PATCH] [26/26] i386: i386 separate hardware-defined TSS from Linux additions

2007-04-29 Thread Andi Kleen
From: Rusty Russell <[EMAIL PROTECTED]> On Thu, 2007-03-29 at 13:16 +0200, Andi Kleen wrote: > Please clean it up properly with two structs. Not sure about this, now I've done it. Running it here. If you like it, I can do x86-64 as well. == lguest defines its own TSS struct because the "struct

[PATCH] [20/26] x86: Allow percpu variables to be page-aligned

2007-04-29 Thread Andi Kleen
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Let's allow page-alignment in general for per-cpu data (wanted by Xen, and Ingo suggested KVM as well). Because larger alignments can use more room, we increase the max per-cpu memory to 64k rather than 32k: it's getting a little tight. Signed-off-by

[PATCH] [23/26] i386: Allow boot-time disable of SMP altinstructions

2007-04-29 Thread Andi Kleen
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Add "noreplace-smp" to disable SMP instruction replacement. Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- Documentation/kernel-parameters.txt |6 ++ arch/i386/kernel/alternative.c

[PATCH] [6/26] x86: fix amd64-agp aperture validation

2007-04-29 Thread Andi Kleen
From: "Jan Beulich" <[EMAIL PROTECTED]> Under CONFIG_DISCONTIGMEM, assuming that a !pfn_valid() implies all subsequent pfn-s are also invalid is wrong. Thus replace this by explicitly checking against the E820 map. AK: make e820 on x86-64 not initdata Signed-off-by: Jan Beulich <[EMAIL PROTECTED

[PATCH] [18/26] i386: Update smp_call_function* comments

2007-04-29 Thread Andi Kleen
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Update documentation for i386 smp_call_function* functions. As reported by Randy Dunlap <[EMAIL PROTECTED]> [ I've posted this before but it seems to have been lost along the way. ] Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Signed-off-b

[PATCH] [17/26] i386: Use menuconfig objects - APM

2007-04-29 Thread Andi Kleen
From: Jan Engelhardt <[EMAIL PROTECTED]> (I hope Andi is the right one to Cc, otherwise please add, thanks!) Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Signed-off-by

[PATCH] [1/26] i386: Add smp_ops interface

2007-04-29 Thread Andi Kleen
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Subject: Add smp_ops interface Add a smp_ops interface. This abstracts the API defined by for use within arch/i386. The primary intent is that it be used by a paravirtualizing hypervisor to implement SMP, but it could also be used by non-APIC-using

[PATCH] [24/26] x86_64: Fix x86_64 compilation with DEBUG_SIG on

2007-04-29 Thread Andi Kleen
From: Glauber de Oliveira Costa <[EMAIL PROTECTED]> Setting the DEBUG_SIG flag breaks compilation due to a wrong struct access. Aditionally, it raises two warnings. This is one patch to fix them all. Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> Signed-off-by: Andi Kleen <[EMAIL P

[PATCH] [16/26] i386: Enable machine check for AMD Family 10

2007-04-29 Thread Andi Kleen
From: Joachim Deguara <[EMAIL PROTECTED]> We don't check for any specific family because the code is generic to all systems supporting the Intel machine check architecture. Just check the CPUID bit instead Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/i386/kernel/cpu/mcheck/mce.c |

[PATCH] [15/26] x86: Don't use MWAIT on AMD Family 10

2007-04-29 Thread Andi Kleen
It doesn't put the CPU into deeper sleep states, so it's better to use the standard idle loop to save power. But allow to reenable it anyways for benchmarking. I also removed the obsolete idle=halt on i386 Cc: [EMAIL PROTECTED] Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- Documentation/

[PATCH] [22/26] i386: Remove smp_alt_instructions

2007-04-29 Thread Andi Kleen
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]> The .smp_altinstructions section and its corresponding symbols are completely unused, so remove them. Also, remove stray #ifdef __KENREL__ in asm-i386/alternative.h Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Signed-off-by: Andi Kleen <[EM

[PATCH] [8/26] x86_64: fix arithmetic in comment

2007-04-29 Thread Andi Kleen
From: Avi Kivity <[EMAIL PROTECTED]> The xmm space on x86_64 is 256 bytes. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- include/asm-x86_64/processor.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/include/asm-x86_64/pro

[PATCH] [2/26] i386: Add machine_ops interface to abstract halting and rebooting

2007-04-29 Thread Andi Kleen
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]> machine_ops is an interface for the machine_* functions defined in . This is intended to allow hypervisors to intercept the reboot process, but it could be used to implement other x86 subarchtecture reboots. Signed-off-by: Jeremy Fitzhardinge <[EMAIL

[PATCH] [11/26] i386: clean up identify_cpu

2007-04-29 Thread Andi Kleen
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]> identify_cpu() is used to identify both the boot CPU and secondary CPUs, but it performs some actions which only apply to the boot CPU. Those functions are therefore really __init functions, but because they're called by identify_cpu(), they must be ma

[PATCH] [14/26] x86_64: Clean up asm-x86_64/bugs.h

2007-04-29 Thread Andi Kleen
From: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Most of asm-x86_64/bugs.h is code which should be in a C file, so put it there. Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Cc: Andi Kleen <[EMAIL PROTECTED]> Cc: Linus Torvalds <[EMAIL PROTECTE

[PATCH] [21/26] x86: Clean up x86 control register and MSR macros (corrected)

2007-04-29 Thread Andi Kleen
From: "H. Peter Anvin" <[EMAIL PROTECTED]> This patch is based on Rusty's recent cleanup of the EFLAGS-related macros; it extends the same kind of cleanup to control registers and MSRs. It also unifies these between i386 and x86-64; at least with regards to MSRs, the two had definitely gotten out

[PATCH] [9/26] x86_64: Fix vmalloc_32 to really allocate <4GB on 64bit platforms

2007-04-29 Thread Andi Kleen
Ugly ifdef, but should handle all 64bit platforms that have suitable zones. On some like Altix it's probably impossible without IOMMU use to get memory <4GB this way, but they have to live with that. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- mm/vmalloc.c | 12 ++-- 1 file chan

  1   2   3   4   5   >