Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3)

2006-12-20 Thread Linus Torvalds
On Thu, 21 Dec 2006, Gordon Farquharson wrote: > > Unfortunately, I cannot get the latest git version of the kernel to > boot on the ARM machine on which Martin and I are experiencing the apt > segfault. Ouch. > After the kernel is finished uncompressing it prints "done, > booting the kernel."

Re: [RFC PATCH 1/8] rqbased-dm: allow blk_get_request() to be called from interrupt context

2006-12-20 Thread Jens Axboe
On Wed, Dec 20 2006, Kiyoshi Ueda wrote: > Hi Jens, > > On Wed, 20 Dec 2006 19:49:17 +0100, Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > Big NACK on this - it's not only really ugly, it's also buggy to pass > > > > interrupt flags as function arguments. As you also mention in the 0/1 > > > > mail

Re: [RFC PATCH 2/8] rqbased-dm: add block layer hook

2006-12-20 Thread Jens Axboe
On Wed, Dec 20 2006, Kiyoshi Ueda wrote: > Hi Jens, > > Sorry for the less explanation. > > On Wed, 20 Dec 2006 14:49:24 +0100, Jens Axboe <[EMAIL PROTECTED]> wrote: > > On Tue, Dec 19 2006, Kiyoshi Ueda wrote: > > > This patch adds new "end_io_first" hook in __end_that_request_first() > > > for

Re: [GIT PATCH] PCI patches for 2.6.20-rc1

2006-12-20 Thread Grant Grundler
On Wed, Dec 20, 2006 at 12:01:42PM -0800, Greg KH wrote: > Here are some PCI patches for 2.6.20-rc1 > > They contain a number of PCI quirk fixes and some PCI hotplug driver > fixes and changes, and some other stuff that is detailed below. Any reasons why the Documentation/pci.txt patch isn't incl

Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3)

2006-12-20 Thread Gordon Farquharson
On 12/20/06, Linus Torvalds <[EMAIL PROTECTED]> wrote: Ok, I'll just put my money where my mouth is, and suggest a patch like THIS instead. Martin, Andrei, does this make any difference for your corruption cases? Unfortunately, I cannot get the latest git version of the kernel to boot on th

Re: [PATCH] Relay CPU Hotplug support

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 19:31:01 -0500 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > Hi, > > Here is a patch, result of the combined work of Tom Zanussi and myself, to add > CPU hotplug support to Relay. > > ... > > + > + lock_cpu_hotplug(); > + for_each_online_cpu(i) > + if (ch

Re: [PATCH update9] drivers: add LCD support

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 15:10:00 +0100 Miguel Ojeda Sandonis <[EMAIL PROTECTED]> wrote: > --- a/drivers/auxdisplay/Kconfig > +++ b/drivers/auxdisplay/Kconfig > @@ -65,6 +65,7 @@ config KS0108_DELAY > config CFAG12864B > tristate "CFAG12864B LCD" > depends on X86 > + depends on F

Re: Linux disk performance.

2006-12-20 Thread Daniel Cheng
Manish Regmi wrote: [...] If you upgrade to a newer kernel you can try other i/o scheduler options, default cfq or even deadline might be helpful. I tried all disk schedulers but all had timing bumps. :( Did you try to disable the on disk write cache? man hdparm(8) -W Disable/enable

[BUG ?] oom with empty nodes.

2006-12-20 Thread KAMEZAWA Hiroyuki
On some system, there are memory-less-nodes. (IOW, cpu-only-node) Then,there are online nodes which has no memory. Now, below code is used to detect the context where oom happens. === static inline int constrained_alloc(struct zonelist *zonelist, gfp_t gfp_mask) { #ifdef CONFIG_NUMA struc

Re: [PATCH] scsi_execute_async() should add to the tail of the queue

2006-12-20 Thread Dan Aloni
Steven Hayter wrote: Dan Aloni wrote: Hello, scsi_execute_async() has replaced scsi_do_req() a few versions ago, but it also incurred a change of behavior. I noticed that over-queuing a SCSI device using that function causes I/Os to be starved from low-level queuing for no justified reason.

[patch] high-res timers: core, do itimer rearming in process context, fix2

2006-12-20 Thread Thomas Gleixner
Subject: [patch] high-res timers: core, do itimer rearming in process context, fix2 From: Thomas Gleixner <[EMAIL PROTECTED]> The rearming code in signal.c has to read the time and can not rely on the timer->base->softirq time anymore, as it is not longer running in softirq context. Ensure, that

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Stephen Hemminger
David Brownell wrote: Hmm, this reminds me of a thread from last summer, following up on some PM discussions at OLS. Thread "Runtime power management for network interfaces", at the end of July. 2) Network device infrastructure should make it easier for devices: bring interface down on

Re: [solved] Yenta Cardbus allocation failure

2006-12-20 Thread Linus Torvalds
On Wed, 20 Dec 2006, Andrew Morton wrote: > > Linus has wondered "how much does Windows use"? How might we determine > that? Google knows everything, and finds, on MS own site no less: "Windows 2000 default resources: One 4K memory window One 2 MB memory window Two 256-byte I/O

Re: Changes to sysfs PM layer break userspace

2006-12-20 Thread David Brownell
On Wednesday 20 December 2006 9:02 pm, Andrew Morton wrote: > > ... see my original reply in this thread. If "the answer" is > > to involve making PCI devices work again, better solutions include reverting > > the patch I mentioned (adding the suspend_late/resume_early support to PCI) > > or a ve

Re: [PATCH -mm 3/5][time][x86_64] Split x86_64/kernel/time.c up

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 17:13:37 -0500 john stultz <[EMAIL PROTECTED]> wrote: > + > +unsigned int __init hpet_calibrate_tsc(void) > +{ > + int tsc_start, hpet_start; > + int tsc_now, hpet_now; > + unsigned long flags; > + > + local_irq_save(flags); > + local_irq_disable(); > + > +

nasty thread-related bugs, maybe in exit

2006-12-20 Thread Albert Cahalan
There are big nasty bugs related to threaded processes exiting, especially when involving: zombie leaders, clone w/o SIGCHLD, and ptrace. I can make tasks that remain until reboot. I've seen things stuck in "X" state. I've seen pending SIGKILL and even blocked SIGKILL. I've seen "D" state pretendi

Re: [patch 2.6.20-rc1 3/6] AT91 GPIO wrappers

2006-12-20 Thread David Brownell
On Wednesday 20 December 2006 10:10 pm, Andrew Morton wrote: > On Wed, 20 Dec 2006 13:11:19 -0800 > David Brownell <[EMAIL PROTECTED]> wrote: > > > +static inline int gpio_get_value(unsigned gpio) > > + { return at91_get_gpio_value(gpio); } > > + > > +static inline void gpio_set_value(unsigned g

Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

2006-12-20 Thread David Brownell
On Wednesday 20 December 2006 10:12 pm, Andrew Morton wrote: > On Wed, 20 Dec 2006 13:12:35 -0800 > David Brownell <[EMAIL PROTECTED]> wrote: > > > +/* REVISIT these macros are correct, but suffer code explosion > > + * for non-constant parameters. Provide out-line versions too. > > + */ > > +#de

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread David Brownell
Hmm, this reminds me of a thread from last summer, following up on some PM discussions at OLS. Thread "Runtime power management for network interfaces", at the end of July. > 2) Network device infrastructure should make it easier for devices: > bring interface down on suspend and bring it up

Fwd: sk buffer to user space

2006-12-20 Thread vimal.raj
Hi kernel experts, I'm a newbie to linux kernel. I need to take the sk buffer and directly pass to the application which is in the user space. How can i do it (my project want to read data packets from driver and give it to application without the help of socket mechanism.) I saw tha

Re: [PATCH -mm 5/5][time][x86_64] Re-enable vsyscall support for x86_64

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 17:13:49 -0500 john stultz <[EMAIL PROTECTED]> wrote: > Cleanup and re-enable vsyscall gettimeofday using the generic > clocksource infrastructure. This patch disagrees violently with the post-2.6.20-rc1-mm1 introduce-time_data-a-new-structure-to-hold-jiffies-xtime-xtime_lock

[PATCH] md: Fix a few problems with the interface (sysfs and ioctl) to md.

2006-12-20 Thread NeilBrown
Following patch is suitable for 2.6.20. It fixes some minor bugs that need to be fix in order to use new functionality in mdadm-2.6. Thanks, NeilBrown ### Comments for Changeset While developing more functionality in mdadm I found some bugs in md... - When we remove a device from an inactive a

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 13:13:21 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > +#define gpio_get_value(gpio) \ > + (GPLR & GPIO_GPIO(gpio)) > + > +#define gpio_set_value(gpio,value) \ > + ((value) ? (GPSR = GPIO_GPIO(gpio)) : (GPCR(gpio) = GPIO_GPIO(gpio))) likewise. - To unsubscribe from

Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 13:12:35 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > +/* REVISIT these macros are correct, but suffer code explosion > + * for non-constant parameters. Provide out-line versions too. > + */ > +#define gpio_get_value(gpio) \ > + (GPLR(gpio) & GPIO_bit(gpio)) > + > +#d

Re: [patch 2.6.20-rc1 3/6] AT91 GPIO wrappers

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 13:11:19 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > +static inline int gpio_get_value(unsigned gpio) > + { return at91_get_gpio_value(gpio); } > + > +static inline void gpio_set_value(unsigned gpio, int value) > + { (void) at91_set_gpio_value(gpio, value); } wha

Re: Linux disk performance.

2006-12-20 Thread Manish Regmi
On 12/21/06, Bill Davidsen <[EMAIL PROTECTED]> wrote: > > But isn't O_DIRECT supposed to bypass buffering in Kernel? That's correct. But it doesn't put your write at the head of any queue, it just doesn't buffer it for you. > Doesn't it directly write to disk? Also correct, when it's your turn t

Re: [PATCH] procfs: export context switch counts in /proc/*/stat

2006-12-20 Thread Al Boldi
Albert Cahalan wrote: > On 12/20/06, David Wragg <[EMAIL PROTECTED]> wrote: > > "Albert Cahalan" <[EMAIL PROTECTED]> writes: > > > On Mon, Dec 18, 2006 at 11:50:08PM +, David Wragg wrote: > > >> This patch (against 2.6.19/2.6.19.1) adds the four context > > >> switch values (voluntary context s

Re: Updated Kernel Hacker's guide to git

2006-12-20 Thread Nigel Cunningham
Hi. On Wed, 2006-12-20 at 22:04 -0500, Jeff Garzik wrote: > I refreshed my git intro/cookbook for kernel hackers, at > http://linux.yyz.us/git-howto.html > > This describes most of the commands I use in day-to-day kernel hacking. > Let me know if there are glaring errors or missing key comman

Re: [PATCH] alsa soc wm8750 fix 2.6.20-rc1-mm1

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 20:20:45 +0300 "Eugene Ilkov" <[EMAIL PROTECTED]> wrote: > There was some INIT_WORK related changes, here is patch against > wm8750 codec driver. Tested on sharp sl-c1000 > > > --- linux-2.6.20-rc1-mm1/sound/soc/codecs/wm8750.c2006-12-20 > 19:23:27.0 +0300 > +++

Re: Updated Kernel Hacker's guide to git

2006-12-20 Thread Willy Tarreau
Hi Jeff ! On Wed, Dec 20, 2006 at 10:04:17PM -0500, Jeff Garzik wrote: > I refreshed my git intro/cookbook for kernel hackers, at > http://linux.yyz.us/git-howto.html Thanks for this update, it was my most useful source of inspiration when I started with git. > This describes most of the comman

Re: [PATCH] pc110pad: return proper error

2006-12-20 Thread Dmitry Torokhov
On Tuesday 19 December 2006 03:44, Akinobu Mita wrote: > According to the comment, "if we find any PCI devices in the machine, > we don't have a PC110" in pc110pad.c, we should return -ENODEV > rather than -ENOENT in this case. > Applied, thank you. -- Dmitry - To unsubscribe from this list: se

Re: [BUG] [PATCH] [RFC] garbage instead of zeroes in UFS

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 17:54:12 +0300 Evgeniy Dushistov <[EMAIL PROTECTED]> wrote: > On Wed, Dec 20, 2006 at 03:09:55AM -0800, Andrew Morton wrote: > > On Wed, 20 Dec 2006 14:04:06 +0300 > > "Tomasz Kvarsin" <[EMAIL PROTECTED]> wrote: > > > > > Forgot to say I use linux-2.6.20-rc1-mm1 > > > > > > O

Re: 2.4.28: __alloc_pages: 0-order allocation failed (gfp=0x1d2/0) ?

2006-12-20 Thread Willy Tarreau
Hello, On Mon, Dec 18, 2006 at 11:32:43AM +0100, rrcwjpgr wrote: > Hello, > > first thanks for your great support on the Linux kernel. > I have a problem with kernel 2.4.28 and maybe somebody has an idea about my > problem. When I type dmesg, I get this error messages: > __alloc_pages: 0-order a

Re: [PATCH update9] drivers: add LCD support

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 15:10:00 +0100 Miguel Ojeda Sandonis <[EMAIL PROTECTED]> wrote: > Andrew, another one for drivers-add-lcd-support saga. Thanks you. This patch appears to be against some private tree of yours, not against -mm. Which tells me that it hasn't been tested against the patches in -

Re: [PATCH] add i386 idle notifier (take 3)

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 06:05:00 -0800 Stephane Eranian <[EMAIL PROTECTED]> wrote: > Hello, > > Here is the latest version of the idle notifier for i386. > This patch is against 2.6.20-rc1 (GIT). In this kernel, the idle > loop code was modified such that the lowest level idle > routines do not have

Re: [Patch](memory hotplug) fix compile error for i386 with NUMA config (take 3).

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 23:09:58 +0900 Yasunori Goto <[EMAIL PROTECTED]> wrote: > +EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); Exported to acpi_memhotplug, I guess. Is not actually needed on NUMAQ. I don't think anyone will complain much ;) - To unsubscribe from this list: send the line "unsubs

Re: Changes to sysfs PM layer break userspace

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 20:56:27 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > On Wednesday 20 December 2006 7:51 pm, Andrew Morton wrote: > > > > + if (!warned) { > > > + printk(KERN_WARNING > > > + "*** WARNING *** sysfs devices/.../power/state files " > > > +

Re: Changes to sysfs PM layer break userspace

2006-12-20 Thread David Brownell
On Wednesday 20 December 2006 7:51 pm, Andrew Morton wrote: > > + if (!warned) { > > + printk(KERN_WARNING > > + "*** WARNING *** sysfs devices/.../power/state files " > > + "are only for testing, and will be removed\n"); > > + warned = err

Re: [PATCH 2.6.20-rc1 05/10] if_fddi.h: Add a missing inclusion

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 12:01:55 + (GMT) "Maciej W. Rozycki" <[EMAIL PROTECTED]> wrote: > This is a change to include in > which is needed for "struct fddi_statistics". > > Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> > --- > > Please apply. > > Maciej > > patch-mips-2.6.18-2006

Re: [PATCH 2.6.20-rc1 01/10] TURBOchannel update to the driver model

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 12:01:30 + (GMT) "Maciej W. Rozycki" <[EMAIL PROTECTED]> wrote: > +/** > + * tc_register_driver - register a new TC driver > + * @drv: the driver structure to register > + * > + * Adds the driver structure to the list of registered drivers > + * Returns a negative value on

Re: [PATCH 1/2] Fix /sys/device/.../power/state

2006-12-20 Thread David Brownell
On Wednesday 20 December 2006 8:06 pm, Matthew Garrett wrote: > On Wed, Dec 20, 2006 at 07:04:28PM -0800, David Brownell wrote: > > On Wednesday 20 December 2006 5:29 pm, Matthew Garrett wrote: > > > I dislike that. > > > > Tough noogies, as they say. In a tradeoff between correctness and your >

Re: [RFC] [PATCH] Fix kmalloc flags used in ext3 with an active journal handle

2006-12-20 Thread Andrew Morton
On Tue, 19 Dec 2006 18:22:03 -0800 Suzuki <[EMAIL PROTECTED]> wrote: > > Andrew Morton wrote: > > On Tue, 19 Dec 2006 17:58:12 -0800 > > Suzuki <[EMAIL PROTECTED]> wrote: > > > > > >>* Fix the kmalloc flags used from within ext3, when we have an active > >>journal handle > >> > >>If we do

Re: [PATCH 2.6.20-rc1 03/10] defxx: TURBOchannel support

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 12:01:42 + (GMT) "Maciej W. Rozycki" <[EMAIL PROTECTED]> wrote: > > This is a set of changes to add TURBOchannel support to the defxx driver. my, what a lot of rejects. > patch-mips-2.6.18-20060920-defta-69 2.6.18? - To unsubscribe from this list: send the line "unsu

Re: Patch "i386: Relocatable kernel support" causes instant reboot

2006-12-20 Thread Vivek Goyal
On Wed, Dec 20, 2006 at 09:43:40PM +0100, Jean Delvare wrote: > Hi Eric, > > On Wed, 20 Dec 2006 07:00:11 -0700, Eric W. Biederman wrote: > > Jean Delvare writes: > > > One of my test machines (i586, Asus P4P800-X) reboots instantly when I > > > try to boot a 2.6.20-rc1 kernel. 2.6.19 and 2.6.19.1

Re: [RFC] HZ free ntp

2006-12-20 Thread Andrew Morton
On Tue, 19 Dec 2006 17:54:18 -0800 john stultz <[EMAIL PROTECTED]> wrote: > On Tue, 2006-12-19 at 17:32 -0800, john stultz wrote: > > On Wed, 2006-12-13 at 21:40 +0100, Roman Zippel wrote: > > > On Wed, 13 Dec 2006, john stultz wrote: > > > > > You don't have to introduce anything new, it's tick_l

Re: [patch] aio: fix buggy put_ioctx call in aio_complete

2006-12-20 Thread Andrew Morton
On Tue, 19 Dec 2006 13:49:18 -0800 "Chen, Kenneth W" <[EMAIL PROTECTED]> wrote: > Regarding to a bug report on: > http://marc.theaimsgroup.com/?l=linux-kernel&m=116599593200888&w=2 > > flush_workqueue() is not allowed to be called in the softirq context. > However, aio_complete() called from I/O

Re: [PATCH 1/2] Fix /sys/device/.../power/state

2006-12-20 Thread Matthew Garrett
On Wed, Dec 20, 2006 at 07:04:28PM -0800, David Brownell wrote: > On Wednesday 20 December 2006 5:29 pm, Matthew Garrett wrote: > > I dislike that. > > Tough noogies, as they say. In a tradeoff between correctness and your > personal taste (or even mine, sigh!), the normal tradeoff is in favor >

Re: Changes to sysfs PM layer break userspace

2006-12-20 Thread Andrew Morton
On Tue, 19 Dec 2006 19:29:13 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > On Tuesday 19 December 2006 6:15 pm, Andrew Morton wrote: > > On Tue, 19 Dec 2006 13:34:49 -0800 > > David Brownell <[EMAIL PROTECTED]> wrote: > > > > > Documentation/feature-removal-schedule.txt has warned about this

Re: [PATCH] mm: Remove final traces of deprecated kmem_cache_t.

2006-12-20 Thread Andrew Morton
On Tue, 19 Dec 2006 13:10:11 -0500 (EST) "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -14,8 +14,6 @@ > #include > #include > > -typedef struct kmem_cache kmem_cache_t __deprecated; > - Nope, let's leave that there for a couple o

RE: [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c to ahci.c

2006-12-20 Thread Peer Chen
Thanks. BRs Peer Chen -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Thursday, December 21, 2006 3:20 AM To: Peer Chen Cc: linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org; Andrew Morton Subject: Re: [PATCH 1/2] sata_nv & ahci: Move some IDs from sata_nv.c

Re: [solved] Yenta Cardbus allocation failure

2006-12-20 Thread Andrew Morton
On Tue, 19 Dec 2006 01:12:07 +0100 "Markus Rechberger" <[EMAIL PROTECTED]> wrote: > I went on with investigating that problem and found the problem, > though I'm not sure if that solution is acceptable.. > > seems like the memory range gets preallocated in setup-bus.c, and > CARDBUS_MEM_SIZE defi

Re: [PATCH] ppc : Use syslog macro for the printk log level.

2006-12-20 Thread Andrew Morton
On Mon, 18 Dec 2006 14:36:23 -0800 (PST) David Rientjes <[EMAIL PROTECTED]> wrote: > --- a/arch/arm/vfp/vfphw.S > +++ b/arch/arm/vfp/vfphw.S > @@ -18,13 +18,15 @@ #include > #include > #include "../kernel/entry-header.S" > > +#define KERN_DEBUG "<7>" > + These definitions should be availa

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Dan Williams
On Thu, 2006-12-21 at 03:25 +, Matthew Garrett wrote: > On Wed, Dec 20, 2006 at 10:08:22PM -0500, Daniel Drake wrote: > > Matthew Garrett wrote: > > >Hm. Does the spec not set any upper bound on how long it might take for > > >APs to respond? I'm afraid that my 802.11 knowledge is pretty slim.

Re: [Ltt-dev] [PATCH 7/10] local_t : powerpc

2006-12-20 Thread Mathieu Desnoyers
* Mathieu Desnoyers ([EMAIL PROTECTED]) wrote: > --- a/include/asm-powerpc/local.h > +++ b/include/asm-powerpc/local.h > +/** > + * local_add_unless - add unless the number is a given value > + * @l: pointer of type local_t > + * @a: the amount to add to l... > + * @u: ...unless l is equal to u. >

Re: [PATCH 1/2] Fix /sys/device/.../power/state

2006-12-20 Thread David Brownell
On Wednesday 20 December 2006 5:29 pm, Matthew Garrett wrote: > On Wed, Dec 20, 2006 at 01:18:06PM -0800, David Brownell wrote: > > > /* disallow incomplete suspend sequences */ > > > - if (dev->bus && (dev->bus->suspend_late || dev->bus->resume_early)) > > > + if (dev->bus && dev->bus->pm_has_no

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Dan Williams
On Thu, 2006-12-21 at 03:14 +, Matthew Garrett wrote: > On Wed, Dec 20, 2006 at 10:06:51PM -0500, Dan Williams wrote: > > > a) tied to the wireless hardware, switch kills hardware directly > > b) tied to wireless hardware, but driver handles the kill request > > c) just another key, a separate

Re: [PATCH 7/9] atomic.h : powerpc

2006-12-20 Thread Mathieu Desnoyers
* Benjamin Herrenschmidt ([EMAIL PROTECTED]) wrote: > > > + > > +/** > > + * atomic64_add_unless - add unless the number is a given value > > + * @v: pointer of type atomic64_t > > + * @a: the amount to add to v... > > + * @u: ...unless v is equal to u. > > + * > > + * Atomically adds @a to @v, so

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Dan Williams
On Wed, 2006-12-20 at 22:08 -0500, Daniel Drake wrote: > Matthew Garrett wrote: > >> There are additional implementation problems: scanning requires 2 > >> different ioctl calls: siwscan, then several giwscan. If you want the > >> driver to effectively temporarily bring the interface up when user

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Matthew Garrett
On Wed, Dec 20, 2006 at 10:08:22PM -0500, Daniel Drake wrote: > Matthew Garrett wrote: > >Hm. Does the spec not set any upper bound on how long it might take for > >APs to respond? I'm afraid that my 802.11 knowledge is pretty slim. > > I'm not sure, but thats not entirely relevant either. The

Re: [PATCH] Relay CPU Hotplug support

2006-12-20 Thread Mathieu Desnoyers
* Tom Zanussi ([EMAIL PROTECTED]) wrote: > Mathieu Desnoyers writes: > > Hi, > > > > Here is a patch, result of the combined work of Tom Zanussi and myself, to > add > > CPU hotplug support to Relay. > > > > This patch applies on 2.6.20-rc1-git7. > > > > Signed-off-by : Mathieu Desnoyer

Re: 2.6.19.1-rt15: BUG in __tasklet_action at kernel/softirq.c:568

2006-12-20 Thread Steven Rostedt
On Wed, 2006-12-20 at 20:50 +0100, Ingo Molnar wrote: > * Robert Crocombe <[EMAIL PROTECTED]> wrote: > > > On 12/19/06, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > >yeah. This is something that triggers very rarely on certain boxes. Not > > >fixed yet, and it's been around for some time. > > > > I

Re: [PATCH 7/9] atomic.h : powerpc

2006-12-20 Thread Benjamin Herrenschmidt
> + > +/** > + * atomic64_add_unless - add unless the number is a given value > + * @v: pointer of type atomic64_t > + * @a: the amount to add to v... > + * @u: ...unless v is equal to u. > + * > + * Atomically adds @a to @v, so long as it was not @u. > + * Returns non-zero if @v was not @u, and z

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Matthew Garrett
On Wed, Dec 20, 2006 at 10:06:51PM -0500, Dan Williams wrote: > a) tied to the wireless hardware, switch kills hardware directly > b) tied to wireless hardware, but driver handles the kill request > c) just another key, a separate key driver handles the event and asks > the wireless driver to kill

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Dan Williams
On Thu, 2006-12-21 at 02:18 +, Matthew Garrett wrote: > On Wed, Dec 20, 2006 at 09:05:27PM -0500, Michael Wu wrote: > > > Softmac isn't the only wireless code that likes to be configured after > > going > > up first. Configuring after the card goes up has generally been more > > reliable, t

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Daniel Drake
Matthew Garrett wrote: There are additional implementation problems: scanning requires 2 different ioctl calls: siwscan, then several giwscan. If you want the driver to effectively temporarily bring the interface up when userspace requests a scan but the interface was down, then how does the dr

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Dan Williams
On Thu, 2006-12-21 at 01:15 +, Matthew Garrett wrote: > On Wed, Dec 20, 2006 at 01:12:51PM -0500, Dan Williams wrote: > > > Entirely correct. If the card is DOWN, the radio should be off (both TX > > & RX) and it should be in max power save mode. If userspace expects to > > be able to get th

Updated Kernel Hacker's guide to git

2006-12-20 Thread Jeff Garzik
I refreshed my git intro/cookbook for kernel hackers, at http://linux.yyz.us/git-howto.html This describes most of the commands I use in day-to-day kernel hacking. Let me know if there are glaring errors or missing key commands. Jeff - To unsubscribe from this list: send the line "

Re: [PATCH] Relay CPU Hotplug support

2006-12-20 Thread Tom Zanussi
Mathieu Desnoyers writes: > Hi, > > Here is a patch, result of the combined work of Tom Zanussi and myself, to > add > CPU hotplug support to Relay. > > This patch applies on 2.6.20-rc1-git7. > > Signed-off-by : Mathieu Desnoyers <[EMAIL PROTECTED]> > Hi Mathieu, It looks like you

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Dan Williams
On Thu, 2006-12-21 at 02:20 +, Matthew Garrett wrote: > On Wed, Dec 20, 2006 at 08:57:05PM -0500, Michael Wu wrote: > > (allowing scanning while the interface is down) > > > No, it's absolutely a bug. It just so happens that some drivers incorrectly > > allowed it. > > Ok. Would it be reaso

Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3)

2006-12-20 Thread Trond Myklebust
On Wed, 2006-12-20 at 15:55 -0800, Linus Torvalds wrote: > > With your change I think what'll happen is that we'll correctly handle the > > case where the page and its buffers are dirty (it gets left in place), but > > we'll needlessy fail in the case where the page is dirty but the buffers > > are

Re: [BUG] daemon.c blows up on OSX

2006-12-20 Thread Albert Cahalan
Linus Torvalds writes: So it would appear that for OS X, the #define _XOPEN_SOURCE_EXTENDED 1 /* AIX 5.3L needs this */ #define _GNU_SOURCE #define _BSD_SOURCE sequence actually _disables_ those things. Yes, of course. The odd one here is glibc. Normal systems enable everyt

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Matthew Garrett
On Wed, Dec 20, 2006 at 09:38:20PM -0500, Daniel Drake wrote: > I don't think that supporting scanning when the interface is supposed to > be disabled is sensible. If you want to scan, you are simply sending and > receiving frames, it's no different from having the interface up and > sending/re

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Daniel Drake
Matthew Garrett wrote: In order to scan, we need to have the radio on and we need to be able to send and receive. What are you gonna turn off? The obvious route would be to power the card down, but come back up every two minutes to perform a scan, or if userspace explicitly requests one. Woul

Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3)

2006-12-20 Thread Trond Myklebust
On Wed, 2006-12-20 at 23:15 +0100, Peter Zijlstra wrote: > I think this is also needed: NAK invalidate_inode_pages2() should _not_ be pretending that dirty pages are clean. This patch is incorrect both for the NFS usage and for the directIO usage. In the latter case, if someone has the page mmap

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Daniel Drake
Matthew Garrett wrote: Veering off at something of a tangent - how much of this should be true for wireless devices? Softmac seems to be unhappy about setting the essid unless the card is up, which breaks various assumptions... You might regard that as a bug - I agree it probably makes sense f

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Michael Wu
On Wednesday 20 December 2006 20:15, Matthew Garrett wrote: > Because it works on the common hardware? If there's documentation about > what userspace can legitimately expect, then I'm happy to defer to that. > But in the absence of any indication as to what functionality users can > depend on, dec

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Matthew Garrett
On Wed, Dec 20, 2006 at 08:57:05PM -0500, Michael Wu wrote: (allowing scanning while the interface is down) > No, it's absolutely a bug. It just so happens that some drivers incorrectly > allowed it. Ok. Would it be reasonable to add warnings to any devices that allow it? -- Matthew Garrett |

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Matthew Garrett
On Wed, Dec 20, 2006 at 09:05:27PM -0500, Michael Wu wrote: > Softmac isn't the only wireless code that likes to be configured after going > up first. Configuring after the card goes up has generally been more > reliable, though that should not be necessary and is a bug IMHO. Ok, that's nice t

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Jesse Brandeburg
On 12/20/06, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > Yeah, I guess that's a problem. From a user perspective, the > functionality is only really useful if the latency is very small. I > think where possible we'd want to power down the chip while keeping the > phy up, but it would be nice t

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Michael Wu
On Wednesday 20 December 2006 20:12, Matthew Garrett wrote: > Veering off at something of a tangent - how much of this should be true > for wireless devices? Softmac seems to be unhappy about setting the > essid unless the card is up, which breaks various assumptions... > Softmac isn't the only wir

Re: What's in git.git (stable), and Announcing GIT 1.4.4.3

2006-12-20 Thread Randal L. Schwartz
> "Linus" == Linus Torvalds <[EMAIL PROTECTED]> writes: Linus> Master right now is at 54851157ac. On a more positive note, with my local (unacceptable) changes to muck with headers, the 54 release does in fact make git-index-pack take under a minute for 313037 objects on OSX. Yeay! -- Ran

[PATCH 0/4] Linux Kernel Markers

2006-12-20 Thread Mathieu Desnoyers
Hi, You will find, in the following posts, the latest revision of the Linux Kernel Markers. Due to the need some tracing projects (LTTng, SystemTAP) has of this kind of mechanism, it could be nice to consider it for mainstream inclusion. The following patches apply on 2.6.20-rc1-git7. Signed-off

Re: [PATCH 1/2] Fix /sys/device/.../power/state

2006-12-20 Thread Matthew Garrett
On Wed, Dec 20, 2006 at 01:18:06PM -0800, David Brownell wrote: > > /* disallow incomplete suspend sequences */ > > - if (dev->bus && (dev->bus->suspend_late || dev->bus->resume_early)) > > + if (dev->bus && dev->bus->pm_has_noirq_stage > > + && dev->bus->pm_has_noirq_stage(dev)) > >

Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3)

2006-12-20 Thread David Chinner
On Wed, Dec 20, 2006 at 03:55:25PM -0800, Linus Torvalds wrote: > On Thu, 21 Dec 2006, David Chinner wrote: > > > > XFS appears to call clear_page_dirty to get the mapping tree dirty > > tag set correctly at the same time the page dirty flag is cleared. I > > note that this can be done by set_page

Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3)

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 16:43:31 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Wed, 20 Dec 2006, Linus Torvalds wrote: > > > > > > There's also redirty_page_for_writepage(). > > > > _dirtying_ a page makes sense in any situation. You can always dirty them. > > I'm just saying tha

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Matthew Garrett
On Wed, Dec 20, 2006 at 01:12:51PM -0500, Dan Williams wrote: > Entirely correct. If the card is DOWN, the radio should be off (both TX > & RX) and it should be in max power save mode. If userspace expects to > be able to get the card to do _anything_ when it's down, that's just > 110% wrong. Y

Re: Network drivers that don't suspend on interface down

2006-12-20 Thread Matthew Garrett
On Wed, Dec 20, 2006 at 02:49:06PM -0800, Stephen Hemminger wrote: > When device is down, it should: >a) use as few resources as possible: > - not grab memory for buffers > - not assign IRQ unless it could get one > - turn off all power consumpt

[PATCH -mm 0/4] PM: Change ordering of suspend and resume code

2006-12-20 Thread Rafael J. Wysocki
Hi, As indicated in a recent thread on Linux-PM, it's necessary to call pm_ops->finish() before devce_resume(), but enable_nonboot_cpus() has to be called before pm_ops->finish() (cf. http://lists.osdl.org/pipermail/linux-pm/2006-November/004164.html). For consistency, it seems reasonable to call

[PATCH -mm 1/4] PM: Change code ordering in main.c

2006-12-20 Thread Rafael J. Wysocki
Change the ordering of code in kernel/power/main.c so that device_suspend() is called before disable_nonboot_cpus() and pm_ops->finish() is called after enable_nonboot_cpus() and before device_resume(), as indicated by recent discussion on Linux-PM (cf. http://lists.osdl.org/pipermail/linux-pm/2006

[PATCH -mm 3/4] swsusp: Change code ordering in user.c

2006-12-20 Thread Rafael J. Wysocki
Change the ordering of code in kernel/power/user.c so that device_suspend() is called before disable_nonboot_cpus() and device_resume() is called after enable_nonboot_cpus(). This is needed to make the userland suspend call pm_ops->finish() after enable_nonboot_cpus() and before device_resume(), a

[PATCH -mm 4/4] swsusp: Change pm_ops handling by userland interface

2006-12-20 Thread Rafael J. Wysocki
Make the userland interface of swsusp call pm_ops->finish() after enable_nonboot_cpus() and before resume_device(), as indicated by the recent discussion on Linux-PM (cf. http://lists.osdl.org/pipermail/linux-pm/2006-November/004164.html). This patch changes the SNAPSHOT_PMOPS ioctl so that its fi

[PATCH -mm 2/4] swsusp: Change code ordering in disk.c

2006-12-20 Thread Rafael J. Wysocki
Change the ordering of code in kernel/power/disk.c so that device_suspend() is called before disable_nonboot_cpus() and platform_finish() is called after enable_nonboot_cpus() and before device_resume(), as indicated by the recent discussion on Linux-PM (cf. http://lists.osdl.org/pipermail/linux-pm

Re: Mutex debug lock failure [was Re: Bad gcc-4.1.0 leads to Power4 crashes... and power5 too, actually

2006-12-20 Thread Linas Vepstas
On Thu, Dec 21, 2006 at 11:36:59AM +1100, Anton Blanchard wrote: > > On Wed, Dec 20, 2006 at 05:46:47PM -0600, Linas Vepstas wrote: > > > System assert at: file: rtas_io_config.c -- line: 195 > > rio_hub_num: 10 > > drawer_num: 6 > > phb_num: 3 > > buid: 7 > > Looks like a firmware assert. Did

Re: Mutex debug lock failure [was Re: Bad gcc-4.1.0 leads to Power4 crashes... and power5 too, actually

2006-12-20 Thread Anton Blanchard
On Wed, Dec 20, 2006 at 05:46:47PM -0600, Linas Vepstas wrote: > System assert at: file: rtas_io_config.c -- line: 195 > rio_hub_num: 10 > drawer_num: 6 > phb_num: 3 > buid: 7 Looks like a firmware assert. Did you pass in something dodgy to a config read/write op? Maybe a bad buid? Anton - To

Re: [PATCH] MAINTAINERS: fix email for S3C2410 and S3C2440

2006-12-20 Thread Andrew Morton
On Mon, 18 Dec 2006 10:24:11 + Ben Dooks <[EMAIL PROTECTED]> wrote: > --- linux-2.6.20-rc1/MAINTAINERS 2006-12-17 23:04:58.0 + > +++ linux-2.6.20-rc1-fix2/MAINTAINERS 2006-12-18 10:21:25.0 + > @@ -406,14 +406,14 @@ S: Maintained > > ARM/S3C2410 ARM ARCHITEC

Re: [PATCH] microcode: Fix mc_cpu_notifier section warning

2006-12-20 Thread Andrew Morton
On Tue, 19 Dec 2006 09:10:25 + (GMT) Tigran Aivazian <[EMAIL PROTECTED]> wrote: > Hi Jean, > > On Tue, 19 Dec 2006, Jean Delvare wrote: > > I don't see anything in arch/i386/kernel/microcode.c depending on > > CONFIG_HOTPLUG_CPU (in 2.6.20-rc1), sorry. > > I run 2.6.19.1 and there both mc_cp

Re: [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().

2006-12-20 Thread Andrew Morton
On Sun, 17 Dec 2006 07:43:39 -0500 (EST) "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > as with ARRAY_SIZE(), there are a number of places (mercifully, far > fewer) that recode what could be done with the FIELD_SIZEOF() macro in > kernel.h. > Looks sane. > include/acpi/actbl.h

Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2006-12-20 Thread Casey Schaufler
--- Giuseppe Bilotta <[EMAIL PROTECTED]> wrote: > Except that we're talking about *hardware* companies > here, not > *software* companies. *Hardware* companies make > money by selling > *hardware*, not the software that drives it: in > fact, they always > distribute the 'software' they write (th

LCA 2007 Kernel Miniconf CFP (better late than never...)

2006-12-20 Thread Dave Airlie
The Kernel miniconference at LCA 20007 is finally being organised and this is the call for participation: http://lca2007.linux.org.au/Miniconfs/Kernel The current schedule gives us 6 slots. One slot is reserved for 5 minute lightning talks - this gives us 8 lightning talks, where people working

Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file content corruption on ext3)

2006-12-20 Thread Linus Torvalds
On Wed, 20 Dec 2006, Linus Torvalds wrote: > > > > There's also redirty_page_for_writepage(). > > _dirtying_ a page makes sense in any situation. You can always dirty them. > I'm just saying that you can't just mark them *clean*. > > If your point was that the filesystem had better be able to

  1   2   3   4   5   >