[PATCH] KEYS: trusted: Remove redundant static calls usage

2023-10-05 Thread Sumit Garg
usage from module __init and __exit functions or not. Reported-by: Hyeonggon Yoo <42.hye...@gmail.com> Closes: https://lore.kernel.org/lkml/ZRhKq6e5nF%2F4ZIV1@fedora/#t Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework") Signed-off-by: Sumit Garg ---

[PATCH v2] KEYS: trusted: Remove redundant static calls usage

2023-10-05 Thread Sumit Garg
and __exit functions or not. Reported-by: Hyeonggon Yoo <42.hye...@gmail.com> Link: https://lore.kernel.org/lkml/ZRhKq6e5nF%2F4ZIV1@fedora/#t Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework") Signed-off-by: Sumit Garg --- Changes in v2: - Polish commit me

Re: [PATCH v2] KEYS: trusted: Remove redundant static calls usage

2023-10-10 Thread Sumit Garg
On Tue, 10 Oct 2023 at 18:03, Jarkko Sakkinen wrote: > > On Fri, 2023-10-06 at 10:48 +0530, Sumit Garg wrote: > > Static calls invocations aren't well supported from module __init and > > __exit functions. Especially the static call from cleanup_trusted() led > >

Re: [PATCH v2] KEYS: trusted: Remove redundant static calls usage

2023-10-10 Thread Sumit Garg
On Tue, 10 Oct 2023 at 23:59, Linus Torvalds wrote: > > On Thu, 5 Oct 2023 at 22:18, Sumit Garg wrote: > > > > Static calls invocations aren't well supported from module __init and > > __exit functions. Especially the static call from cleanup_trusted() led >

Re: [PATCH v2] KEYS: trusted: Remove redundant static calls usage

2023-10-10 Thread Sumit Garg
On Wed, 11 Oct 2023 at 00:35, Jarkko Sakkinen wrote: > > On Tue, 2023-10-10 at 11:28 -0700, Linus Torvalds wrote: > > On Thu, 5 Oct 2023 at 22:18, Sumit Garg wrote: > > > > > > Static calls invocations aren't well supported from module __init and > >

Re: [PATCH] KEYS: trusted: Rollback init_trusted() consistently

2023-10-10 Thread Sumit Garg
On Wed, 11 Oct 2023 at 04:46, Jarkko Sakkinen wrote: > > Do bind neither static calls nor trusted_key_exit() before a successful > init, in order to maintain a consistent state. In addition, depart the > init_trusted() in the case of a real error (i.e. getting back something > else than -ENODEV).

Re: [PATCH] KEYS: trusted: Rollback init_trusted() consistently

2023-10-11 Thread Sumit Garg
On Wed, 11 Oct 2023 at 16:04, Jarkko Sakkinen wrote: > > On Wed, 2023-10-11 at 13:12 +0300, Jarkko Sakkinen wrote: > > On Wed, 2023-10-11 at 11:27 +0530, Sumit Garg wrote: > > > On Wed, 11 Oct 2023 at 04:46, Jarkko Sakkinen wrote: > > > > > > > > Do b

Re: [PATCH] KEYS: trusted: Rollback init_trusted() consistently

2023-10-11 Thread Sumit Garg
On Wed, 11 Oct 2023 at 18:07, Jarkko Sakkinen wrote: > > On Wed, 2023-10-11 at 17:47 +0530, Sumit Garg wrote: > > On Wed, 11 Oct 2023 at 16:04, Jarkko Sakkinen wrote: > > > > > > On Wed, 2023-10-11 at 13:12 +0300, Jarkko Sakkinen wrote: > > > > On Wed, 2

Re: [PATCH] KEYS: trusted: Rollback init_trusted() consistently

2023-10-11 Thread Sumit Garg
On Wed, 11 Oct 2023 at 18:36, Jarkko Sakkinen wrote: > > On Wed, 2023-10-11 at 18:25 +0530, Sumit Garg wrote: > > On Wed, 11 Oct 2023 at 18:07, Jarkko Sakkinen wrote: > > > > > > On Wed, 2023-10-11 at 17:47 +0530, Sumit Garg wrote: > > > > On Wed, 11

Re: [PATCH] KEYS: trusted: Rollback init_trusted() consistently

2023-10-12 Thread Sumit Garg
On Wed, 11 Oct 2023 at 19:35, Jarkko Sakkinen wrote: > > On Wed, 2023-10-11 at 16:55 +0300, Jarkko Sakkinen wrote: > > On Wed, 2023-10-11 at 19:12 +0530, Sumit Garg wrote: > > > On Wed, 11 Oct 2023 at 18:36, Jarkko Sakkinen wrote: > > > > > > > >

Re: [PATCH 0/4] Add support for the TPM FF-A start method

2025-02-10 Thread Sumit Garg
+ Jens Hi Stuart, On Tue, 11 Feb 2025 at 04:52, Stuart Yoder wrote: > > These patches add support for the CRB FF-A start method defined > in the TCG ACPI specification v1.4 and the FF-A ABI defined > in the Arm TPM Service CRB over FF-A (DEN0138) specification. > (https://developer.arm.com/docum

Re: [PATCH 0/4] Add support for the TPM FF-A start method

2025-02-12 Thread Sumit Garg
+ Rob On Thu, 13 Feb 2025 at 03:25, Stuart Yoder wrote: > > > > On 2/12/25 1:39 AM, Sumit Garg wrote: > > On Tue, 11 Feb 2025 at 21:39, Stuart Yoder wrote: > >> > >> Hi Sumit, > >> > >> On 2/11/25 12:45 AM, Sumit Garg wrote: > >>>

Re: [PATCH 0/4] Add support for the TPM FF-A start method

2025-02-16 Thread Sumit Garg
On Thu, Feb 13, 2025 at 09:19:58AM -0600, Stuart Yoder wrote: > > > On 2/12/25 11:31 PM, Sumit Garg wrote: > > + Rob > > > > On Thu, 13 Feb 2025 at 03:25, Stuart Yoder wrote: > > > > > > > > > > > > On 2/12/25 1:39 AM, Sumit

Re: [PATCH 0/4] Add support for the TPM FF-A start method

2025-02-11 Thread Sumit Garg
On Tue, 11 Feb 2025 at 21:39, Stuart Yoder wrote: > > Hi Sumit, > > On 2/11/25 12:45 AM, Sumit Garg wrote: > > + Jens > > > > Hi Stuart, > > > > On Tue, 11 Feb 2025 at 04:52, Stuart Yoder wrote: > >> > >> These patches add suppor

Re: [PATCH 2/2] tpm/tpm_ftpm_tee: use send_recv() op

2025-03-24 Thread Sumit Garg
Garzarella > --- > v1: > - added Jens' T-b > --- > drivers/char/tpm/tpm_ftpm_tee.h | 4 -- > drivers/char/tpm/tpm_ftpm_tee.c | 86 - > 2 files changed, 21 insertions(+), 69 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git

Re: [PATCH v3 3/4] tpm/tpm_ftpm_tee: support TPM_CHIP_FLAG_SYNC

2025-04-28 Thread Sumit Garg
(). Also we don't need to implement recv() op. > > > > Signed-off-by: Stefano Garzarella > > --- > > v2: > > - set TPM_CHIP_FLAG_SYNC and support it in the new send() > > - removed Jens' T-b > > @Jens @Sumit can you test/review this patch again s

Re: [PATCH] tpm: ftpm_tee: remove incorrect of_match_ptr annotation

2025-02-27 Thread Sumit Garg
drivers/char/tpm/tpm_ftpm_tee.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c > index 139556b21cc6..8d9209dfc384 100644 > --- a/drivers/char/t

Re: [RFC PATCH 2/3] tpm/tpm_ftpm_tee: use send_recv() op

2025-03-13 Thread Sumit Garg
+ Jens Hi Stefano, On Tue, Mar 11, 2025 at 11:01:29AM +0100, Stefano Garzarella wrote: > This driver does not support interrupts, and receiving the response is > synchronous with sending the command. > > It used an internal buffer to cache the response when .send() is called, > and then return i

Re: [PATCH 0/4] Add support for the TPM FF-A start method

2025-02-21 Thread Sumit Garg
On Mon, Feb 17, 2025 at 10:56:58AM -0600, Stuart Yoder wrote: > > > On 2/16/25 11:17 PM, Sumit Garg wrote: > > On Thu, Feb 13, 2025 at 09:19:58AM -0600, Stuart Yoder wrote: > > > > > > > > > On 2/12/25 11:31 PM, Sumit Garg wrote: > > > &g