Re: [PATCH] tpm: Start the tpm2 before running a self test.

2023-11-21 Thread Paul Menzel
Dear Hermin, Thank you for your patch. It’d be great if you removed the dot/period from the end of the commit message summary/title. Am 22.11.23 um 07:55 schrieb Hermin Anggawijaya: Before sending a command to attempt the self test, the TPM may need to be started, otherwise the self test

tpm_tis_remove: `WARNING: CPU: 6 PID: 265 at kernel/workqueue.c:3397 __flush_work.isra.0+0x29f/0x2c0`

2024-01-16 Thread Paul Menzel
#regzbot introduced: v5.15.131..v6.6.11 Dear Linux folks, On a Dell OptiPlex 5055 with an AMD Ryzen, Linux always logged the error tpm_tis: probe of MSFT0101:00 failed with error -1 but upgrading from 5.15.131 to 6.6.11, the warning below is also logged: ``` [0.00] Linux version

init_tis() takes 50 ms on Dell XPS 13 9360 – almost 10 % of whole time until initrd

2024-02-14 Thread Paul Menzel
Dear Linux folks, Trying to optimize the boot time of Linux on the Dell XPS 13 9360, probing of MSFT0101:00 takes 52 ms, making `init_tis()` taking almost 10 % alone until starting the initrd: [0.00] Linux version 6.8.0-rc4 (bu...@bohemianrhapsody.molgen.mpg.de) (gcc (Debian 13.

Re: init_tis() takes 50 ms on Dell XPS 13 9360 – almost 10 % of whole time until initrd

2024-02-16 Thread Paul Menzel
Dear Jarkko, Thank you for your reply. Am 16.02.24 um 23:07 schrieb Jarkko Sakkinen: On Wed Feb 14, 2024 at 3:10 PM UTC, Paul Menzel wrote: Trying to optimize the boot time of Linux on the Dell XPS 13 9360, probing of MSFT0101:00 takes 52 ms, making `init_tis()` taking almost 10 % alone

Re: [PATCH] MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and TPM DEVICE RIVER

2024-02-25 Thread Paul Menzel
://gitlab.com/jarkkojs/linux-tpmdd-test Q:https://patchwork.kernel.org/project/linux-integrity/list/ T:git git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git F:drivers/char/tpm/ Acked-by: Paul Menzel Kind regards, Paul

Re: [PATCH] tpm,tpm_tis: Avoid warning splat at shutdown

2024-03-05 Thread Paul Menzel
Dear Lino, Thank you for the patch. Am 01.02.24 um 12:36 schrieb Lino Sanfilippo: If interrupts are not activated the work struct 'free_irq_work' is not initialized. This results in a warning splat at module shutdown. Fix this by always initializing the work regardless of whether interrupts a

Re: tpm_tis_remove: `WARNING: CPU: 6 PID: 265 at kernel/workqueue.c:3397 __flush_work.isra.0+0x29f/0x2c0`

2024-03-05 Thread Paul Menzel
#regzbot fixed-by: d6fb14208e22c7bb6f54cb9df960bfc21e4663e3 Dear Jarkko, Am 02.02.24 um 00:02 schrieb Jarkko Sakkinen: On Tue Jan 16, 2024 at 4:44 PM EET, Paul Menzel wrote: #regzbot introduced: v5.15.131..v6.6.11 On a Dell OptiPlex 5055 with an AMD Ryzen, Linux always logged the error

Re: [PATCH] tpm,tpm_tis: Avoid warning splat at shutdown

2024-03-07 Thread Paul Menzel
Dear Jarkko, Am 07.03.24 um 21:05 schrieb Jarkko Sakkinen: On Tue Mar 5, 2024 at 5:43 PM EET, Paul Menzel wrote: Am 01.02.24 um 12:36 schrieb Lino Sanfilippo: If interrupts are not activated the work struct 'free_irq_work' is not initialized. This results in a warning splat

Re: [PATCH v2] tpm: Fix suspend/shutdown on some boards by preserving chip Locality

2024-03-08 Thread Paul Menzel
= BIT(9), + TPM_CHIP_FLAG_PRESERVE_LOCALITY = BIT(10), }; #define to_tpm_chip(d) container_of(d, struct tpm_chip, dev) Reviewed-by: Paul Menzel Kind regards, Paul

Re: [PATCH v3 42/74] x86/cpu/vfm: Update tpm files

2024-04-17 Thread Paul Menzel
Dear Tony, Thank you for your patch. It’d be great if you changed the commit message summary/title to be more specific. Currently, the short log, `git log --oneline`, is not very meaningful. Maybe: tpm: Use new VFM macro INTEL_ATOM_AIRMONT or x86/cpu/vfm: Use macro INTEL_ATOM_AIRMONT in tp

Re: [PATCH] tpm: Open code tpm_buf_parameters()

2024-05-25 Thread Paul Menzel
Dear Jarkko, Thank you for your patch. Am 25.05.24 um 17:44 schrieb Jarkko Sakkinen: With only single call site, this no sense, and it actually slipped out this *makes* no sense? of the radar during the review. Open code and document the action directly to the site, to make it more readabl

Re: [RFC] integrity: wait for completion of i2c initialization using late_initcall_sync()

2024-07-01 Thread Paul Menzel
Dear Romain, Thank you for your patch. Am 01.07.24 um 15:38 schrieb Romain Naour: From: Romain Naour It has been reported that on some plateforms the ima and evm platforms initialization were performed too early during initcall initialization process and misses TPM chip detection [1] [2]

Re: [PATCH v8 2/3] tpm: Rollback tpm2_load_null()

2024-10-27 Thread Paul Menzel
Dear Jarkko, Thank you for your patch. Am 28.10.24 um 06:50 schrieb Jarkko Sakkinen: Do not continue on tpm2_create_primary() failure in tpm2_load_null(). Could you please elaborate, why this is done, that means the motivation for your change? Cc: sta...@vger.kernel.org # v6.10+ Fixes: e

Re: [PATCH v8 2/3] tpm: Rollback tpm2_load_null()

2024-10-28 Thread Paul Menzel
Dear Jarkko, Am 28.10.24 um 13:10 schrieb Jarkko Sakkinen: On Mon Oct 28, 2024 at 8:13 AM EET, Paul Menzel wrote: Am 28.10.24 um 06:50 schrieb Jarkko Sakkinen: Do not continue on tpm2_create_primary() failure in tpm2_load_null(). Could you please elaborate, why this is done, that means

Re: [PATCH v5 0/5] Lazy flush for the auth session

2024-09-21 Thread Paul Menzel
Dear Jarkko, Thank you for working on this and your patches. Am 21.09.24 um 14:08 schrieb Jarkko Sakkinen: This patch set aims to fix: https://bugzilla.kernel.org/show_bug.cgi?id=219229. If I am not mistaken this is about reducing the boot time, right? It’d be great if you documented the nu

Re: [PATCH] tpm/eventlog: Use kvmalloc() for event log buffer

2024-11-07 Thread Paul Menzel
Dear Takashi, Thank you for the patch. Am 07.11.24 um 12:18 schrieb Takashi Iwai: The TPM2 ACPI table may request a large size for the event log, and it may be over the max size of kmalloc(). When this happens, the driver What is kmalloc()’s maximum size? spews the kernel WARNING at the p

Re: [PATCH v2] tpm, tpm_tis: Workaround failed command reception on Infineon devices

2025-03-11 Thread Paul Menzel
Dear Jonathan, Some nits, should you resend. Feel free to ignore. The verb *work around* is spelled with a space. Am 10.03.25 um 13:19 schrieb Jonathan McDowell: From: Jonathan McDowell Some Infineon devices have a issue where the status register will get stuck with a quick REQUEST_USE / C

Re: [PATCH v5 2/5] tpm_crb: clean-up and refactor check for idle support

2025-02-20 Thread Paul Menzel
Dear Stuart, Thank you for the patch. Should you respin, you could spell *clean up* in the summary/title with a space. The diff looks good. Kind regards, Paul

Re: [PATCH] tpm: tis: Increase the default for timeout B

2025-04-03 Thread Paul Menzel
Dear Michal, Thank you for the patch. For the summary/title you could be more specific by using *Double*: tpm: tis: Double default for timeout B to 4 s Am 03.04.25 um 20:25 schrieb Michal Suchanek: With some Infineon chips the timeouts in tpm_tis_send_data (both B and C) can reach up to abo

Re: [PATCH v4 1/1] tpm_crb_ffa: handle tpm busy return code

2025-06-13 Thread Paul Menzel
Dear Praochotan, Am 14.06.25 um 01:31 schrieb Prachotan Bathi: For CRB over FF-A interface, if the firmwre TPM or TPM service [1] shares firmw*a*re its Secure Partition (SP) with another service, message requests may fail with a -EBUSY error. Platforms supporting direct message request v2[1