Re: [RFC PATCH v2 1/4] tsm: Runtime measurement register support

2024-01-29 Thread Dionna Amalie Glaze
The rtmr backend doesn't specify the digest size it expects to user space, so rtmr_extend could be zero-fill, or provide a truncated update, or be strict and return an error. Should the expected digest size for writes not also be a RO attribute? On Sun, Jan 28, 2024 at 1:27 PM Samuel Ortiz wrote:

Re: [PATCH 3/3] x86/sev: add a SVSM vTPM platform device

2025-01-22 Thread Dionna Amalie Glaze
On Tue, Jan 14, 2025 at 3:12 PM Jarkko Sakkinen wrote: > > On Wed Jan 15, 2025 at 12:48 AM EET, Jarkko Sakkinen wrote: > > On Wed Jan 15, 2025 at 12:46 AM EET, Jarkko Sakkinen wrote: > > > On Tue Jan 14, 2025 at 12:42 PM EET, Stefano Garzarella wrote: > > > > Hi Jarkko, > > > > > > > > On Thu, 19

Re: [PATCH v5 1/4] x86/sev: add SVSM vTPM probe/send_command functions

2025-04-04 Thread Dionna Amalie Glaze
On Tue, Apr 1, 2025 at 9:13 PM Dionna Amalie Glaze wrote: > > On Mon, Mar 31, 2025 at 3:39 AM Stefano Garzarella > wrote: > > > > From: Stefano Garzarella > > > > Add two new functions to probe and send commands to the SVSM vTPM. > > They leverag

Re: [PATCH v5 1/4] x86/sev: add SVSM vTPM probe/send_command functions

2025-04-05 Thread Dionna Amalie Glaze
On Mon, Mar 31, 2025 at 3:39 AM Stefano Garzarella wrote: > > From: Stefano Garzarella > > Add two new functions to probe and send commands to the SVSM vTPM. > They leverage the two calls defined by the AMD SVSM specification [1] > for the vTPM protocol: SVSM_VTPM_QUERY and SVSM_VTPM_CMD. > > Exp

Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

2025-03-31 Thread Dionna Amalie Glaze
On Mon, Mar 31, 2025 at 2:26 PM James Bottomley wrote: > > On Mon, 2025-03-31 at 13:56 -0700, Dionna Amalie Glaze wrote: > [...] > > I might be unclear on how I should be testing this, but I do see > > /dev/tpm0 and /dev/tpmrm0 when I build with CONFIG_TCG_SVSM=y, but I &g

Re: [RFC PATCH v2 5/6] tpm: add SNP SVSM vTPM driver

2025-02-28 Thread Dionna Amalie Glaze
On Fri, Feb 28, 2025 at 5:51 PM Jarkko Sakkinen wrote: > > On Fri, Feb 28, 2025 at 06:07:19PM +0100, Stefano Garzarella wrote: > > Add driver for the vTPM defined by the AMD SVSM spec [1]. > > > > The specification defines a protocol that a SEV-SNP guest OS can use to > > discover and talk to a vT

Re: [PATCH v6 3/4] tpm: add SNP SVSM vTPM driver

2025-04-04 Thread Dionna Amalie Glaze
On Thu, Apr 3, 2025 at 3:10 AM Stefano Garzarella wrote: > > From: Stefano Garzarella > > Add driver for the vTPM defined by the AMD SVSM spec [1]. > > The specification defines a protocol that a SEV-SNP guest OS can use to > discover and talk to a vTPM emulated by the Secure VM Service Module (S

Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

2025-04-04 Thread Dionna Amalie Glaze
On Mon, Mar 31, 2025 at 10:34 AM Jarkko Sakkinen wrote: > > On Mon, Mar 31, 2025 at 12:38:56PM +0200, Stefano Garzarella wrote: > > From: Stefano Garzarella > > > > Add driver for the vTPM defined by the AMD SVSM spec [1]. > > > > The specification defines a protocol that a SEV-SNP guest OS can u

Re: [PATCH v4 1/4] x86/sev: add SVSM vTPM probe/send_command functions

2025-03-25 Thread Dionna Amalie Glaze
On Mon, Mar 24, 2025 at 3:47 AM Stefano Garzarella wrote: > > From: Stefano Garzarella > > Add two new functions to probe and send commands to the SVSM vTPM. > They leverage the two calls defined by the AMD SVSM specification [1] > for the vTPM protocol: SVSM_VTPM_QUERY and SVSM_VTPM_CMD. > > Exp

Re: [PATCH v6 3/4] tpm: add SNP SVSM vTPM driver

2025-04-04 Thread Dionna Amalie Glaze
On Fri, Apr 4, 2025 at 11:37 AM Stefano Garzarella wrote: > > On Fri, 4 Apr 2025 at 19:32, Dionna Amalie Glaze > wrote: > > > > On Thu, Apr 3, 2025 at 3:10 AM Stefano Garzarella > > wrote: > > > > > > From: Stefano Garzarella > > > >