Re: [RFC PATCH v2 2/6] x86/sev: add SVSM vTPM probe/send_command functions

2025-03-10 Thread Tom Lendacky
On 3/10/25 07:46, Stefano Garzarella wrote: > On Mon, Mar 10, 2025 at 12:30:06PM +0100, Borislav Petkov wrote: >> On Fri, Feb 28, 2025 at 06:07:16PM +0100, Stefano Garzarella wrote: >>> +bool snp_svsm_vtpm_probe(void) >>> +{ >>> +    struct svsm_call call = {}; >>> +    u64 send_cmd_mask = 0; >>> +

Re: [RFC PATCH v2 1/6] x86/sev: add SVSM call macros for the vTPM protocol

2025-03-10 Thread Borislav Petkov
On Fri, Feb 28, 2025 at 06:07:15PM +0100, Stefano Garzarella wrote: > Add macros for SVSM_VTPM_QUERY and SVSM_VTPM_CMD calls as defined > in the "Secure VM Service Module for SEV-SNP Guests" > Publication # 58019 Revision: 1.00 > > Link: > https://www.amd.com/content/dam/amd/en/documents/epyc-tec

Re: [RFC PATCH v2 1/6] x86/sev: add SVSM call macros for the vTPM protocol

2025-03-10 Thread Stefano Garzarella
On Mon, Mar 10, 2025 at 12:08:34PM +0100, Borislav Petkov wrote: On Fri, Feb 28, 2025 at 06:07:15PM +0100, Stefano Garzarella wrote: Add macros for SVSM_VTPM_QUERY and SVSM_VTPM_CMD calls as defined in the "Secure VM Service Module for SEV-SNP Guests" Publication # 58019 Revision: 1.00 Link: h

[PATCH v2] tpm, tpm_tis: Workaround failed command reception on Infineon devices

2025-03-10 Thread Jonathan McDowell
From: Jonathan McDowell Some Infineon devices have a issue where the status register will get stuck with a quick REQUEST_USE / COMMAND_READY sequence. This is not simply a matter of requiring a longer timeout; the work around is to retry the command submission. Add appropriate logic to do this i

Re: [RFC PATCH v2 2/6] x86/sev: add SVSM vTPM probe/send_command functions

2025-03-10 Thread Borislav Petkov
On Mon, Mar 10, 2025 at 02:59:44PM +0100, Stefano Garzarella wrote: > On Mon, Mar 10, 2025 at 02:51:33PM +0100, Borislav Petkov wrote: > > On Mon, Mar 10, 2025 at 08:27:37AM -0500, Tom Lendacky wrote: > > > I don't think anything needs to be checked or printed. > > > > Yes. > > Ack, I removed the

Re: [RFC PATCH v2 2/6] x86/sev: add SVSM vTPM probe/send_command functions

2025-03-10 Thread Stefano Garzarella
On Mon, Mar 10, 2025 at 02:51:33PM +0100, Borislav Petkov wrote: On Mon, Mar 10, 2025 at 08:27:37AM -0500, Tom Lendacky wrote: I don't think anything needs to be checked or printed. Yes. Ack, I removed the check and the print. @Boris I also removed `ret` to continue the slimming, so the end

Re: [RFC PATCH v2 2/6] x86/sev: add SVSM vTPM probe/send_command functions

2025-03-10 Thread Borislav Petkov
On Mon, Mar 10, 2025 at 08:56:53AM -0500, Tom Lendacky wrote: > It isn't needed. It's similar to "device" information/capabilities. > Maybe pr_debug() then? But I'm also fine with not printing anything. Yap, nothing it is then. If the need arises, then we can debate :) -- Regards/Gruss, Bor