Re: [RFC PATCH v2 07/13] tpm: enable bank selection for PCR extend

2025-04-05 Thread Jarkko Sakkinen
On Sun, Mar 23, 2025 at 03:09:05PM +0100, Nicolai Stange wrote: > The existing tpm_pcr_extend() extends all of a PCR's allocated banks with > the corresponding digest from the provided digests[] argument. Why not "just" tpm_pcr_extend(). We don't have a concept of "non-existing tpm_pcr_extend()".

Re: [RFC PATCH v2 07/13] tpm: enable bank selection for PCR extend

2025-03-26 Thread Nicolai Stange
Jarkko Sakkinen writes: > On Sun, Mar 23, 2025 at 03:09:05PM +0100, Nicolai Stange wrote: >> The existing tpm_pcr_extend() extends all of a PCR's allocated banks with >> the corresponding digest from the provided digests[] argument. > > Why not "just" tpm_pcr_extend(). We don't have a concept of

Re: [RFC PATCH v2 07/13] tpm: enable bank selection for PCR extend

2025-03-26 Thread Nicolai Stange
Mimi Zohar writes: > On Sun, 2025-03-23 at 15:09 +0100, Nicolai Stange wrote: > >> diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c >> index dfdcbd009720..23ded8ea47dc 100644 >> --- a/drivers/char/tpm/tpm2-cmd.c >> +++ b/drivers/char/tpm/tpm2-cmd.c >> @@ -226,16 +226,34 @@ i

Re: [RFC PATCH v2 07/13] tpm: enable bank selection for PCR extend

2025-03-25 Thread Mimi Zohar
On Sun, 2025-03-23 at 15:09 +0100, Nicolai Stange wrote: > diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c > index dfdcbd009720..23ded8ea47dc 100644 > --- a/drivers/char/tpm/tpm2-cmd.c > +++ b/drivers/char/tpm/tpm2-cmd.c > @@ -226,16 +226,34 @@ int tpm2_pcr_read(struct tpm_c