Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

2025-04-05 Thread Stefano Garzarella
On Tue, 1 Apr 2025 at 00:59, James Bottomley wrote: > > On Mon, 2025-03-31 at 15:23 -0700, Dionna Amalie Glaze wrote: > > On Mon, Mar 31, 2025 at 2:26 PM James Bottomley > > wrote: > > > > > > On Mon, 2025-03-31 at 13:56 -0700, Dionna Amalie Glaze wrote: > > > [...] > > > > I might be unclear on

Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

2025-04-04 Thread Dionna Amalie Glaze
On Mon, Mar 31, 2025 at 10:34 AM Jarkko Sakkinen wrote: > > On Mon, Mar 31, 2025 at 12:38:56PM +0200, Stefano Garzarella wrote: > > From: Stefano Garzarella > > > > Add driver for the vTPM defined by the AMD SVSM spec [1]. > > > > The specification defines a protocol that a SEV-SNP guest OS can u

Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

2025-04-01 Thread Jarkko Sakkinen
On Tue, Apr 01, 2025 at 11:08:49AM +0200, Stefano Garzarella wrote: > On Mon, Mar 31, 2025 at 08:34:42PM +0300, Jarkko Sakkinen wrote: > > On Mon, Mar 31, 2025 at 12:38:56PM +0200, Stefano Garzarella wrote: > > > From: Stefano Garzarella > > > > > > Add driver for the vTPM defined by the AMD SVSM

Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

2025-04-01 Thread Stefano Garzarella
On Mon, Mar 31, 2025 at 08:34:42PM +0300, Jarkko Sakkinen wrote: On Mon, Mar 31, 2025 at 12:38:56PM +0200, Stefano Garzarella wrote: From: Stefano Garzarella Add driver for the vTPM defined by the AMD SVSM spec [1]. The specification defines a protocol that a SEV-SNP guest OS can use to disco

Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

2025-03-31 Thread James Bottomley
On Mon, 2025-03-31 at 15:23 -0700, Dionna Amalie Glaze wrote: > On Mon, Mar 31, 2025 at 2:26 PM James Bottomley > wrote: > > > > On Mon, 2025-03-31 at 13:56 -0700, Dionna Amalie Glaze wrote: > > [...] > > > I might be unclear on how I should be testing this, but I do see > > > /dev/tpm0 and /dev/

Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

2025-03-31 Thread Dionna Amalie Glaze
On Mon, Mar 31, 2025 at 2:26 PM James Bottomley wrote: > > On Mon, 2025-03-31 at 13:56 -0700, Dionna Amalie Glaze wrote: > [...] > > I might be unclear on how I should be testing this, but I do see > > /dev/tpm0 and /dev/tpmrm0 when I build with CONFIG_TCG_SVSM=y, but I > > don't see the event log

Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

2025-03-31 Thread James Bottomley
On Mon, 2025-03-31 at 13:56 -0700, Dionna Amalie Glaze wrote: [...] > I might be unclear on how I should be testing this, but I do see > /dev/tpm0 and /dev/tpmrm0 when I build with CONFIG_TCG_SVSM=y, but I > don't see the event log in securityfs. What am I missing? The vtpm driver for EDK2/OVMF I

Re: [PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

2025-03-31 Thread Jarkko Sakkinen
On Mon, Mar 31, 2025 at 12:38:56PM +0200, Stefano Garzarella wrote: > From: Stefano Garzarella > > Add driver for the vTPM defined by the AMD SVSM spec [1]. > > The specification defines a protocol that a SEV-SNP guest OS can use to > discover and talk to a vTPM emulated by the Secure VM Service

[PATCH v5 3/4] tpm: add SNP SVSM vTPM driver

2025-03-31 Thread Stefano Garzarella
From: Stefano Garzarella Add driver for the vTPM defined by the AMD SVSM spec [1]. The specification defines a protocol that a SEV-SNP guest OS can use to discover and talk to a vTPM emulated by the Secure VM Service Module (SVSM) in the guest context, but at a more privileged level (VMPL0). Th