[PATCH v2 1/2] drivers/hv: introduce vmbus_channel_set_cpu()

2025-01-10 Thread Hamza Mahfooz
I would like to reuse target_cpu_store() within the driver. So, move most of it's body into vmbus_channel_set_cpu(). Cc: Boqun Feng Cc: Wei Liu Signed-off-by: Hamza Mahfooz --- v2: separate vmbus_channel_set_cpu() changes from cpu offlining changes. --- drivers/hv/vmbus_drv.c

[PATCH v2 2/2] drivers/hv: add CPU offlining support

2025-01-10 Thread Hamza Mahfooz
trying to offline to a new "randomly" selected CPU. Cc: Boqun Feng Cc: Wei Liu Signed-off-by: Hamza Mahfooz --- v2: remove cpus_read_{un,}lock() from hv_pick_new_cpu() and add lockdep_assert_cpus_held(). --- drivers/hv/hv.c | 56 -

[PATCH v5 2/3] drivers/hv: introduce vmbus_channel_set_cpu()

2025-01-17 Thread Hamza Mahfooz
intended. Cc: Boqun Feng Cc: Michael Kelley Cc: Wei Liu Signed-off-by: Hamza Mahfooz --- v2: separate vmbus_channel_set_cpu() changes from cpu offlining changes. v3: address comments from Michael. v5: return count if ret is 0. --- drivers/hv/vmbus_drv.c | 52

[PATCH v5 1/3] cpu: export lockdep_assert_cpus_held()

2025-01-17 Thread Hamza Mahfooz
If CONFIG_HYPERV=m, lockdep_assert_cpus_held() is undefined for HyperV. So, export the function so that GPL drivers can use it more broadly. Cc: Michael Kelley Signed-off-by: Hamza Mahfooz --- v5: new to the series --- kernel/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel

[PATCH v5 3/3] drivers/hv: add CPU offlining support

2025-01-17 Thread Hamza Mahfooz
d channels associated with CPUs that a user is trying to offline to a new "randomly" selected CPU. Cc: Boqun Feng Cc: Michael Kelley Cc: Wei Liu Signed-off-by: Hamza Mahfooz --- v2: remove cpus_read_{un,}lock() from hv_pick_new_cpu() and add lockdep_assert_cpus_held(). v3: use fo

Re: [PATCH] drivers/hv: select PCI_HYPERV if PCI is enabled

2025-01-27 Thread Hamza Mahfooz
On Mon, Jan 27, 2025 at 09:02:22PM +, Michael Kelley wrote: > From: Hamza Mahfooz Sent: Monday, January > 27, 2025 10:10 AM > > > > We should select PCI_HYPERV here, otherwise it's possible for devices to > > not show up as expected, at least not in an or

[PATCH] drivers/hv: select PCI_HYPERV if PCI is enabled

2025-01-27 Thread Hamza Mahfooz
We should select PCI_HYPERV here, otherwise it's possible for devices to not show up as expected, at least not in an orderly manner. Cc: sta...@vger.kernel.org Cc: Wei Liu Signed-off-by: Hamza Mahfooz --- drivers/hv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hv/Kc

[PATCH v4 1/2] drivers/hv: introduce vmbus_channel_set_cpu()

2025-01-16 Thread Hamza Mahfooz
intended. Cc: Boqun Feng Cc: Michael Kelley Cc: Wei Liu Signed-off-by: Hamza Mahfooz --- v2: separate vmbus_channel_set_cpu() changes from cpu offlining changes. v3: address comments from Michael. --- drivers/hv/vmbus_drv.c | 50 +- include/linux

[PATCH v4 2/2] drivers/hv: add CPU offlining support

2025-01-16 Thread Hamza Mahfooz
associated with CPUs that a user is trying to offline to a new "randomly" selected CPU. Cc: Boqun Feng Cc: Michael Kelley Cc: Wei Liu Signed-off-by: Hamza Mahfooz --- v2: remove cpus_read_{un,}lock() from hv_pick_new_cpu() and add lockdep_assert_cpus_held(). v3: use fo

[PATCH] drivers/hv: add CPU offlining support

2025-01-10 Thread Hamza Mahfooz
trying to offline to a new "randomly" selected CPU. Cc: Boqun Feng Cc: Wei Liu Signed-off-by: Hamza Mahfooz --- drivers/hv/hv.c| 57 +++--- drivers/hv/vmbus_drv.c | 51 + include/linux/hyperv.h | 1 +

Re: [PATCH v2 2/2] drivers/hv: add CPU offlining support

2025-01-15 Thread Hamza Mahfooz
On Tue, Jan 14, 2025 at 02:43:33AM +, Michael Kelley wrote: > From: Hamza Mahfooz Sent: Friday, January > 10, 2025 2:00 PM > > > > Currently, it is effectively impossible to offline CPUs. Since, most > > CPUs will have vmbus channels attached to them. So, as made

[PATCH v3 1/2] drivers/hv: introduce vmbus_channel_set_cpu()

2025-01-15 Thread Hamza Mahfooz
intended. Cc: Boqun Feng Cc: Michael Kelley Cc: Wei Liu Signed-off-by: Hamza Mahfooz --- v2: separate vmbus_channel_set_cpu() changes from cpu offlining changes. v3: address comments from Michael. --- drivers/hv/vmbus_drv.c | 50 +- include/linux

[PATCH v3 2/2] drivers/hv: add CPU offlining support

2025-01-15 Thread Hamza Mahfooz
associated with CPUs that a user is trying to offline to a new "randomly" selected CPU. Cc: Boqun Feng Cc: Michael Kelley Cc: Wei Liu Signed-off-by: Hamza Mahfooz --- v2: remove cpus_read_{un,}lock() from hv_pick_new_cpu() and add lockdep_assert_cpus_held(). v3: use fo

[PATCH v5 1/2] drivers/hv: introduce vmbus_channel_set_cpu()

2025-01-16 Thread Hamza Mahfooz
intended. Cc: Boqun Feng Cc: Michael Kelley Cc: Wei Liu Signed-off-by: Hamza Mahfooz --- v2: separate vmbus_channel_set_cpu() changes from cpu offlining changes. v3: address comments from Michael. --- drivers/hv/vmbus_drv.c | 50 +- include/linux

[PATCH v5 2/2] drivers/hv: add CPU offlining support

2025-01-16 Thread Hamza Mahfooz
d channels associated with CPUs that a user is trying to offline to a new "randomly" selected CPU. Cc: Boqun Feng Cc: Michael Kelley Cc: Wei Liu Signed-off-by: Hamza Mahfooz --- v2: remove cpus_read_{un,}lock() from hv_pick_new_cpu() and add lockdep_assert_cpus_held(). v3: use fo

Re: [PATCH v5 1/3] cpu: export lockdep_assert_cpus_held()

2025-02-11 Thread Hamza Mahfooz
ping? On Wed, Jan 22, 2025 at 03:37:44PM +, Michael Kelley wrote: > From: Hamza Mahfooz Sent: Friday, January > 17, 2025 12:33 PM > > > > If CONFIG_HYPERV=m, lockdep_assert_cpus_held() is undefined for HyperV. > > So, export the function so that GPL drivers

[PATCH v2] panic: call panic handlers before panic_other_cpus_shutdown()

2025-02-21 Thread Hamza Mahfooz
as VMBUS_CONNECT_CPU, VMBUS_CONNECT_CPU will be offlined by crash_smp_send_stop() before the vmbus channel can be deconstructed. Signed-off-by: Hamza Mahfooz --- v2: keep printk_legacy_allow_panic_sync() after panic_other_cpus_shutdown(). --- kernel/panic.c | 8 1 file changed, 4

Re: [PATCH RFC] panic: call panic handlers before panic_other_cpus_shutdown()

2025-02-21 Thread Hamza Mahfooz
Hey Ryo, On Fri, Feb 21, 2025 at 11:23:28AM +0900, Ryo Takakura wrote: > Hi Hamza! > > On Thu, 20 Feb 2025 17:53:00 -0500, Hamza Mahfooz wrote: > >Since, the panic handlers may require certain cpus to be online to panic > >gracefully, we should call them before turning

[PATCH RFC] panic: call panic handlers before panic_other_cpus_shutdown()

2025-02-20 Thread Hamza Mahfooz
as VMBUS_CONNECT_CPU, VMBUS_CONNECT_CPU will be offlined by crash_smp_send_stop() before the vmbus channel can be deconstructed. Signed-off-by: Hamza Mahfooz --- kernel/panic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/panic.c b/kernel/panic.c index

Re: [PATCH v2] panic: call panic handlers before panic_other_cpus_shutdown()

2025-02-24 Thread Hamza Mahfooz
On Mon, Feb 24, 2025 at 07:59:28PM +, Michael Kelley wrote: > From: Hamza Mahfooz Sent: Monday, February > 24, 2025 6:49 AM > > > > On Fri, Feb 21, 2025 at 11:01:09PM +, Michael Kelley wrote: > > > From: Hamza Mahfooz Sent: Friday, > >

Re: [PATCH v2] panic: call panic handlers before panic_other_cpus_shutdown()

2025-02-24 Thread Hamza Mahfooz
On Fri, Feb 21, 2025 at 11:01:09PM +, Michael Kelley wrote: > From: Hamza Mahfooz Sent: Friday, February > 21, 2025 1:31 PM > > > > Since, the panic handlers may require certain cpus to be online to panic > > gracefully, we should call them before turning off