On Wed, Mar 12, 2025 at 01:59:37PM -0700, Bobby Eshleman wrote:
From: Stefano Garzarella
This patch assigns the network namespace of the process that opened
vhost-vsock-netns device (e.g. VMM) to the packets coming from the
guest, allowing only host sockets in the same network namespace to
comm
From: Michael Kelley Sent: Tuesday, March 18, 2025 7:10
PM
>
> From: Nuno Das Neves Sent: Tuesday, March
> 18, 2025 5:34 PM
> >
> > On 3/17/2025 4:51 PM, Michael Kelley wrote:
> > > From: Nuno Das Neves Sent: Wednesday,
> > > February 26, 2025 3:08 PM
[snip]
> > >> +
> > >> +region
On Wed, Mar 19, 2025 at 11:56:54AM +0100, Thomas Gleixner wrote:
> Split the lock protected functionality of msix_capability_init() out into a
> helper function and use guard(msi_desc_lock) to replace the lock/unlock
> pair.
>
> Simplify the error path in the helper function by utilizing a custom
On Wed, Mar 19, 2025 at 11:56:53AM +0100, Thomas Gleixner wrote:
> Split the lock protected functionality of msi_capability_init() out into a
> helper function and use guard(msi_desc_lock) to replace the lock/unlock
> pair.
>
> No functional change intended.
>
> Signed-off-by: Thomas Gleixner
A
On Wed, Mar 19, 2025 at 11:56:50AM +0100, Thomas Gleixner wrote:
> Let cleanup handle the freeing of the affinity mask. That prepares for
> switching the MSI descriptor locking to a guard().
>
> No functional change.
>
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> ---
> V4: Split
On 12/03/2025 06:51, Ricardo Neri wrote:
> On Tue, Mar 11, 2025 at 11:01:28AM +0100, Krzysztof Kozlowski wrote:
>> On 03/03/2025 23:21, Ricardo Neri wrote:
>>> On Fri, Sep 20, 2024 at 01:15:41PM +0200, Krzysztof Kozlowski wrote:
>>>
>>> [...]
>>>
enable-method is part of CPUs, so you probabl
On 3/12/25 9:59 PM, Bobby Eshleman wrote:
> @@ -753,6 +783,8 @@ static int vhost_vsock_dev_release(struct inode *inode,
> struct file *file)
> virtio_vsock_skb_queue_purge(&vsock->send_pkt_queue);
>
> vhost_dev_cleanup(&vsock->dev);
> + if (vsock->net)
> + put_net(vso
From: Mark Rutland Sent: Monday, March 17, 2025 4:38 AM
>
> On Fri, Mar 14, 2025 at 05:19:22PM -0700, Roman Kisel wrote:
> > The arm64 Hyper-V startup path relies on ACPI to detect
> > running under a Hyper-V compatible hypervisor. That
> > doesn't work on non-ACPI systems.
> >
> > Hoist the ACPI
Provide a lock guard for MSI descriptor locking and update the core code
accordingly.
No functional change intended.
Signed-off-by: Thomas Gleixner
Reviewed-by: Jonathan Cameron
---
V2: Remove the gotos - Jonathan
---
include/linux/irqdomain.h |2
include/linux/msi.h |3 +
ker
In cases where an allocation is consumed by another function, the
allocation needs to be retained on success or freed on failure. The code
pattern is usually:
struct foo *f = kzalloc(sizeof(*f), GFP_KERNEL);
struct bar *b;
,,,
// Initialize f
...
if
Convert the trivial cases of msi_desc_lock/unlock() pairs.
No functional change.
Signed-off-by: Thomas Gleixner
---
V4: Split out from the previous combo patch
---
drivers/pci/msi/api.c |6 ++
drivers/pci/msi/msi.c | 12 ++--
2 files changed, 8 insertions(+), 10 deletions(-)
Convert the code to use the new guard(msi_descs_lock).
No functional change intended.
Signed-off-by: Thomas Gleixner
Tested-by: Nishanth Menon
Reviewed-by: Jonathan Cameron
Reviewed-by: Dhruva Gole
Cc: Tero Kristo
Cc: Santosh Shilimkar
---
drivers/soc/ti/ti_sci_inta_msi.c | 10 +++-
Split the lock protected functionality of msix_capability_init() out into a
helper function and use guard(msi_desc_lock) to replace the lock/unlock
pair.
Simplify the error path in the helper function by utilizing a custom
cleanup to get rid of the remaining gotos.
No functional change intended.
Split the lock protected functionality of msi_capability_init() out into a
helper function and use guard(msi_desc_lock) to replace the lock/unlock
pair.
No functional change intended.
Signed-off-by: Thomas Gleixner
---
V4: Split out from the previous combo patch
---
drivers/pci/msi/msi.c | 68
Now that all abuse is gone and the legit users are converted to
guard(msi_descs_lock), rename the lock functions and document them as
internal.
No functional change.
Signed-off-by: Thomas Gleixner
Reviewed-by: Jonathan Cameron
---
include/linux/msi.h |8
kernel/irq/msi.c|
Convert the code to use the new guard(msi_descs_lock).
No functional change intended.
Signed-off-by: Thomas Gleixner
Reviewed-by: Jonathan Cameron
Reviewed-by: Michael Kelley
Acked-by: Wei Liu
Acked-by: Bjorn Helgaas
Cc: Haiyang Zhang
Cc: linux-hyperv@vger.kernel.org
Cc: linux-...@vger.kern
The driver abuses the MSI descriptors for internal purposes. Aside of core
code and MSI providers nothing has to care about their existence. They have
been encapsulated with a lot of effort because this kind of abuse caused
all sorts of issues including a maintainability nightmare.
Rewrite the cod
This is version 4 of the cleanup work. The previous version can be found
here:
https://lore.kernel.org/all/20250317092919.008573...@linutronix.de
While converting the MSI descriptor locking to a lock guard() I stumbled
over various abuse of MSI descriptors (again).
The following series cleans
The PCI/TPH driver fiddles with the MSI-X control word of an active
interrupt completely unserialized against concurrent operations issued
from the interrupt core. It also brings the PCI/MSI-X internal cached
control word out of sync.
Provide a function, which has the required serialization and ke
The comment claiming that pci_dev::msi_enabled has to be set across setup
is a leftover from ancient code versions. Nothing in the setup code
requires the flag to be set anymore.
Set it in the success path and remove the extra goto label.
Signed-off-by: Thomas Gleixner
---
V4: New patch
---
dri
Convert the code to use the new guard(msi_descs_lock).
No functional change intended.
Signed-off-by: Thomas Gleixner
Reviewed-by: Jonathan Cameron
Reviewed-by: Logan Gunthorpe
Acked-by: Dave Jiang
Cc: Jon Mason
Cc: Allen Hubbe
Cc: n...@lists.linux.dev
---
drivers/ntb/msi.c | 22 ++
Let cleanup handle the freeing of the affinity mask. That prepares for
switching the MSI descriptor locking to a guard().
No functional change.
Signed-off-by: Thomas Gleixner
---
V4: Split out of the previous combo patch
---
drivers/pci/msi/msi.c | 13 -
1 file changed, 4 insertio
On Wed, Mar 12, 2025 at 01:59:35PM -0700, Bobby Eshleman wrote:
From: Stefano Garzarella
This patch adds a check of the "net" assigned to a socket during
the vsock_find_bound_socket() and vsock_find_connected_socket()
to support network namespace, allowing to share the same address
(cid, port)
On 3/19/2025 8:26 AM, Michael Kelley wrote:
> From: Michael Kelley Sent: Tuesday, March 18, 2025
> 7:10 PM
>>
>> From: Nuno Das Neves Sent: Tuesday, March
>> 18, 2025 5:34 PM
>>>
>>> On 3/17/2025 4:51 PM, Michael Kelley wrote:
From: Nuno Das Neves Sent: Wednesday,
February 26, 2025 3
On Wed, Mar 19, 2025 at 11:56:47AM +0100, Thomas Gleixner wrote:
> Convert the trivial cases of msi_desc_lock/unlock() pairs.
>
> No functional change.
>
> Signed-off-by: Thomas Gleixner
Acked-by: Bjorn Helgaas
> ---
> V4: Split out from the previous combo patch
> ---
> drivers/pci/msi/api.c
On Wed, Mar 19, 2025 at 07:05:56PM +0530, Naman Jain wrote:
> On 3/18/2025 6:58 PM, Greg Kroah-Hartman wrote:
> > > +/*
> > > + * hv_create_ring_sysfs - create ring sysfs entry corresponding to ring
> > > buffers for a channel
> > > + */
> >
> > Kerneldoc?
>
> Documentation of the ring sysfs is
On Wed, Mar 19, 2025 at 02:02:32PM +0100, Stefano Garzarella wrote:
> On Wed, Mar 12, 2025 at 01:59:35PM -0700, Bobby Eshleman wrote:
> > From: Stefano Garzarella
> >
> > This patch adds a check of the "net" assigned to a socket during
> > the vsock_find_bound_socket() and vsock_find_connected_so
On Wed, Mar 19, 2025 at 02:26:04PM +0100, Stefano Garzarella wrote:
> On Wed, Mar 12, 2025 at 01:59:36PM -0700, Bobby Eshleman wrote:
> > From: Stefano Garzarella
> >
> > This patch allows transports that use virtio_transport_common
> > to specify the network namespace where a received packet is
On Wed, Mar 19, 2025 at 03:15:36PM +0100, Stefano Garzarella wrote:
> On Wed, Mar 12, 2025 at 01:59:37PM -0700, Bobby Eshleman wrote:
> > From: Stefano Garzarella
> >
> > This patch assigns the network namespace of the process that opened
> > vhost-vsock-netns device (e.g. VMM) to the packets com
On Wed, 2025-03-19 at 11:56 +0100, Thomas Gleixner wrote:
> In cases where an allocation is consumed by another function, the
> allocation needs to be retained on success or freed on failure. The
> code
> pattern is usually:
>
> struct foo *f = kzalloc(sizeof(*f), GFP_KERNEL);
> struct
On 3/18/2025 6:58 PM, Greg Kroah-Hartman wrote:
On Tue, Mar 18, 2025 at 11:45:58AM +0530, Naman Jain wrote:
On regular bootup, devices get registered to vmbus first, so when
uio_hv_generic driver for a particular device type is probed,
the device is already initialized and added, so sysfs cre
On Wed, Mar 12, 2025 at 01:59:36PM -0700, Bobby Eshleman wrote:
From: Stefano Garzarella
This patch allows transports that use virtio_transport_common
to specify the network namespace where a received packet is to
be delivered.
virtio_transport and vhost_transport, for now, still do not use th
On Wed, Mar 19, 2025 at 11:56:49AM +0100, Thomas Gleixner wrote:
> The comment claiming that pci_dev::msi_enabled has to be set across setup
> is a leftover from ancient code versions. Nothing in the setup code
> requires the flag to be set anymore.
>
> Set it in the success path and remove the ex
33 matches
Mail list logo