Re: [PATCH v6 09/10] hyperv: Add definitions for root partition driver to hv headers

2025-03-18 Thread Easwar Hariharan
On 3/14/2025 12:28 PM, Nuno Das Neves wrote: > A few additional definitions are required for the mshv driver code > (to follow). Introduce those here and clean up a little bit while > at it. > > Signed-off-by: Nuno Das Neves > Reviewed-by: Roman Kisel > Reviewed-by: Stanislav Kinsburskii > Revi

Re: [patch V3 05/10] PCI/MSI: Switch to MSI descriptor locking to guard()

2025-03-18 Thread Bjorn Helgaas
On Mon, Mar 17, 2025 at 02:29:27PM +0100, Thomas Gleixner wrote: > Convert the code to use the new guard(msi_descs_lock). > > No functional change intended. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Jonathan Cameron > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org Acked-by: Bjorn H

Re: [PATCH net-next 0/7] net: xdp: Add missing metadata support for some xdp drvs

2025-03-18 Thread Paolo Abeni
On 3/11/25 1:18 PM, Lorenzo Bianconi wrote: > Introduce missing metadata support for some xdp drivers setting metadata > size building the skb from xdp_buff. > Please note most of the drivers are just compile tested. I'm sorry, but you should at very least report explicitly on per patch basis whic

Re: [PATCH net, v2] net: mana: Support holes in device list reply msg

2025-03-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Tue, 11 Mar 2025 13:12:54 -0700 you wrote: > According to GDMA protocol, holes (zeros) are allowed at the beginning > or middle of the gdma_list_devices_resp message. The existing code > cannot properly handle this, and ma

Re: [PATCH v2] uio_hv_generic: Fix sysfs creation path for ring buffer

2025-03-18 Thread Greg Kroah-Hartman
On Tue, Mar 18, 2025 at 11:45:58AM +0530, Naman Jain wrote: > On regular bootup, devices get registered to vmbus first, so when > uio_hv_generic driver for a particular device type is probed, > the device is already initialized and added, so sysfs creation in > uio_hv_generic probe works fine. Howe

[PATCH net-next v2 7/7] net: ti: cpsw: Add metadata support for xdp mode

2025-03-18 Thread Lorenzo Bianconi
Set metadata size building the skb from xdp_buff in cpsw/cpsw_new drivers. ti cpsw and cpsw_new drivers set xdp headroom at least to CPSW_HEADROOM_NA: CPSW_HEADROOM_NA max(XDP_PACKET_HEADROOM, NET_SKB_PAD) + NET_IP_ALIGN so the headroom is large enough to contain xdp_frame and xdp metadata. Pleas

[PATCH net-next v2 0/7] net: xdp: Add missing metadata support for some xdp drvs

2025-03-18 Thread Lorenzo Bianconi
Introduce missing metadata support for some xdp drivers setting metadata size building the skb from xdp_buff. Please note most of the drivers are just compile tested. --- Changes in v2: - Improve commit logs for each patch specifying xdp headroom size for each modified driver. - Link to v1: htt

[PATCH net-next v2 1/7] net: mvneta: Add metadata support for xdp mode

2025-03-18 Thread Lorenzo Bianconi
Set metadata size building the skb from xdp_buff in mvneta driver mvneta sets xdp headroom to: MVNETA_MH_SIZE + MVNETA_SKB_HEADROOM where MVNETA_MH_SIZE 2 MVNETA_SKB_HEADROOM max(NET_SKB_PAD, XDP_PACKET_HEADROOM) so the headroom is large enough to contain xdp_frame and xdp metadata. Reviewed-b

[PATCH net-next v2 2/7] net: mvpp2: Add metadata support for xdp mode

2025-03-18 Thread Lorenzo Bianconi
Set metadata size building the skb from xdp_buff in mvpp2 driver mvpp2 driver sets xdp headroom to: MVPP2_MH_SIZE + MVPP2_SKB_HEADROOM where MVPP2_MH_SIZE 2 MVPP2_SKB_HEADROOM min(max(XDP_PACKET_HEADROOM, NET_SKB_PAD), 224) so the headroom is large enough to contain xdp_frame and xdp metadata.

[PATCH net-next v2 3/7] net: netsec: Add metadata support for xdp mode

2025-03-18 Thread Lorenzo Bianconi
Set metadata size building the skb from xdp_buff in netsec driver. netsec driver sets xdp headroom to NETSEC_RXBUF_HEADROOM: NETSEC_RXBUF_HEADROOM max(XDP_PACKET_HEADROOM, NET_SKB_PAD) + NET_IP_ALIGN so the headroom is large enough to contain xdp_frame and xdp metadata. Please note this patch is

[PATCH net-next v2 5/7] net: ethernet: mediatek: Add metadata support for xdp mode

2025-03-18 Thread Lorenzo Bianconi
Set metadata size building the skb from xdp_buff in mediatek driver. mtk_eth_soc driver sets xdp headroom to XDP_PACKET_HEADROOM so the headroom is large enough to contain xdp_frame and xdp metadata. Please note this patch is just compiled tested. Reviewed-by: Michal Kubiak Signed-off-by: Lorenzo

Re: [patch V3 01/10] cleanup: Provide retain_ptr()

2025-03-18 Thread Thomas Gleixner
On Mon, Mar 17 2025 at 09:57, James Bottomley wrote: > On Mon, 2025-03-17 at 14:29 +0100, Thomas Gleixner wrote: >> +#define retain_ptr(p) \ >> +__get_and_null(p, NULL) > > This doesn't score very highly on the Rusty API design scale because it > can be used anywhe

Re: [PATCH v2 4/4] xen: balloon: update the NR_BALLOON_PAGES state

2025-03-18 Thread Jürgen Groß
On 14.03.25 22:37, Nico Pache wrote: Update the NR_BALLOON_PAGES counter when pages are added to or removed from the Xen balloon. Signed-off-by: Nico Pache Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature.asc Descriptio

[PATCH 1/1] x86/hyperv: Add comments about hv_vpset and var size hypercall input args

2025-03-18 Thread mhkelley58
From: Michael Kelley Current code varies in how the size of the variable size input header for hypercalls is calculated when the input contains struct hv_vpset. Surprisingly, this variation is correct, as different hypercalls make different choices for what portion of struct hv_vpset is treated a

RE: [PATCH v5 10/10] Drivers: hv: Introduce mshv_root module to expose /dev/mshv to VMMs

2025-03-18 Thread Michael Kelley
From: Wei Liu Sent: Tuesday, March 18, 2025 10:25 AM > > On Mon, Mar 17, 2025 at 11:51:52PM +, Michael Kelley wrote: > > From: Nuno Das Neves Sent: Wednesday, > February 26, 2025 3:08 PM > [...] > > > +static long > > > +mshv_vp_ioctl_get_set_state(struct mshv_vp *vp, > > > +

Re: [PATCH v5 10/10] Drivers: hv: Introduce mshv_root module to expose /dev/mshv to VMMs

2025-03-18 Thread Wei Liu
On Tue, Mar 18, 2025 at 05:45:46PM +, Michael Kelley wrote: > From: Wei Liu Sent: Tuesday, March 18, 2025 10:25 AM > > > > On Mon, Mar 17, 2025 at 11:51:52PM +, Michael Kelley wrote: > > > From: Nuno Das Neves Sent: Wednesday, > > February 26, 2025 3:08 PM > > [...] > > > > +static long

Re: [PATCH v5 10/10] Drivers: hv: Introduce mshv_root module to expose /dev/mshv to VMMs

2025-03-18 Thread Nuno Das Neves
On 3/17/2025 4:51 PM, Michael Kelley wrote: > From: Nuno Das Neves Sent: Wednesday, > February 26, 2025 3:08 PM >> + >> +/* TODO move this to another file when debugfs code is added */ >> +enum hv_stats_vp_counters { /* HV_THREAD_COUNTER */ >> +#if defined(CONFIG_X86) >> +VpR

Re: [PATCH v6 10/10] Drivers: hv: Introduce mshv_root module to expose /dev/mshv to VMMs

2025-03-18 Thread Wei Liu
On Tue, Mar 18, 2025 at 07:54:49PM +, Michael Kelley wrote: > From: Nuno Das Neves Sent: Friday, March > 14, 2025 12:29 PM > > > > Provide a set of IOCTLs for creating and managing child partitions when > > running as root partition on Hyper-V. The new driver is enabled via > > CONFIG_MSHV_RO

Re: [PATCH v5 10/10] Drivers: hv: Introduce mshv_root module to expose /dev/mshv to VMMs

2025-03-18 Thread Wei Liu
On Mon, Mar 17, 2025 at 11:51:52PM +, Michael Kelley wrote: > From: Nuno Das Neves Sent: Wednesday, > February 26, 2025 3:08 PM [...] > > +static long > > +mshv_vp_ioctl_get_set_state(struct mshv_vp *vp, > > + struct mshv_get_set_vp_state __user *user_args, > > +

RE: [PATCH v5 10/10] Drivers: hv: Introduce mshv_root module to expose /dev/mshv to VMMs

2025-03-18 Thread Michael Kelley
From: Nuno Das Neves Sent: Tuesday, March 18, 2025 5:34 PM > > On 3/17/2025 4:51 PM, Michael Kelley wrote: > > From: Nuno Das Neves Sent: Wednesday, > February 26, 2025 3:08 PM > > >> + > >> +/* TODO move this to another file when debugfs code is added */ > >> +enum hv_stats_vp_counters {

RE: [PATCH v6 10/10] Drivers: hv: Introduce mshv_root module to expose /dev/mshv to VMMs

2025-03-18 Thread Michael Kelley
From: Wei Liu Sent: Tuesday, March 18, 2025 1:00 PM > > On Tue, Mar 18, 2025 at 07:54:49PM +, Michael Kelley wrote: > > From: Nuno Das Neves Sent: Friday, March > > 14, > 2025 12:29 PM > > > > > > Provide a set of IOCTLs for creating and managing child partitions when > > > running as root

RE: [PATCH v6 10/10] Drivers: hv: Introduce mshv_root module to expose /dev/mshv to VMMs

2025-03-18 Thread Michael Kelley
From: Nuno Das Neves Sent: Friday, March 14, 2025 12:29 PM > > Provide a set of IOCTLs for creating and managing child partitions when > running as root partition on Hyper-V. The new driver is enabled via > CONFIG_MSHV_ROOT. > [snip] > + > +int > +hv_call_clear_virtual_interrupt(u64 partition

Re: [PATCH v6 01/10] hyperv: Log hypercall status codes as strings

2025-03-18 Thread Easwar Hariharan
On 3/14/2025 12:28 PM, Nuno Das Neves wrote: > Introduce hv_status_printk() macros as a convenience to log hypercall > errors, formatting them with the status code (HV_STATUS_*) as a raw hex > value and also as a string, which saves some time while debugging. > > Create a table of HV_STATUS_ codes

Re: [PATCH v6 03/10] arm64/hyperv: Add some missing functions to arm64

2025-03-18 Thread Easwar Hariharan
On 3/14/2025 12:28 PM, Nuno Das Neves wrote: > These non-nested msr and fast hypercall functions are present in x86, > but they must be available in both architectures for the root partition > driver code. > > While at it, remove the redundant 'extern' keywords from the > hv_do_hypercall() variant

Re: fbdev deferred I/O broken in some scenarios

2025-03-18 Thread Helge Deller
Hi Michael, On 3/18/25 03:05, Michael Kelley wrote: I've been trying to get mmap() working with the hyperv_fb.c fbdev driver, which is for Linux guests running on Microsoft's Hyper-V hypervisor. The hyperv_fb driver uses fbdev deferred I/O for performance reasons. But it looks to me like fbdev