Re: [PATCH v6 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp_id()

2025-01-09 Thread Wei Liu
On Thu, Jan 09, 2025 at 01:40:34PM -0800, Roman Kisel wrote: > > > On 1/9/2025 12:18 PM, Wei Liu wrote: > > On Wed, Jan 08, 2025 at 02:21:33PM -0800, Roman Kisel wrote: > > [...] > > > Roman Kisel (5): > > >hyperv: Define struct hv_output_get_vp_registers > > >hyperv: Fix pointer type in

Re: [PATCH v6 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp_id()

2025-01-09 Thread Roman Kisel
On 1/9/2025 12:28 PM, Nuno Das Neves wrote: On 1/9/2025 12:18 PM, Wei Liu wrote: On Wed, Jan 08, 2025 at 02:21:33PM -0800, Roman Kisel wrote: [...] Roman Kisel (5): hyperv: Define struct hv_output_get_vp_registers hyperv: Fix pointer type in get_vtl(void) hyperv: Enable the hypercal

Re: [PATCH v6 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp_id()

2025-01-09 Thread Roman Kisel
On 1/9/2025 1:56 PM, Wei Liu wrote: On Thu, Jan 09, 2025 at 01:40:34PM -0800, Roman Kisel wrote: [...] needs to have the `u32 exception_type;` field: ```c union hv_arm64_pending_synthetic_exception_event { u64 as_uint64[2]; struct { u8 event_pending : 1;

Re: [PATCH v6 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp_id()

2025-01-09 Thread Roman Kisel
On 1/9/2025 12:18 PM, Wei Liu wrote: On Wed, Jan 08, 2025 at 02:21:33PM -0800, Roman Kisel wrote: [...] Roman Kisel (5): hyperv: Define struct hv_output_get_vp_registers hyperv: Fix pointer type in get_vtl(void) hyperv: Enable the hypercall output page for the VTL mode hyperv: Do

[PATCH] treewide: const qualify ctl_tables where applicable

2025-01-09 Thread Joel Granados
Add the const qualifier to all the ctl_tables in the tree except the ones in ./net dir. The "net" sysctl code is special as it modifies the arrays before passing it on to the registration function. Constifying ctl_table structs will prevent the modification of proc_handler function pointers as the

Re: [PATCH v6 1/5] hyperv: Define struct hv_output_get_vp_registers

2025-01-09 Thread Roman Kisel
On 1/8/2025 9:50 PM, Wei Liu wrote: On Wed, Jan 08, 2025 at 03:25:22PM -0800, Nuno Das Neves wrote: On 1/8/2025 2:21 PM, Roman Kisel wrote: [...] I can fix this when I commit the change . This patch will be folded into your old one anyway. Nuno, thank you very much for spotting that!

Re: [PATCH] treewide: const qualify ctl_tables where applicable

2025-01-09 Thread Song Liu
On Thu, Jan 9, 2025 at 5:16 AM Joel Granados wrote: > [...] > drivers/base/firmware_loader/fallback_table.c | 2 +- > drivers/cdrom/cdrom.c | 2 +- > drivers/char/hpet.c | 2 +- > drivers/char/ipmi/ipmi_poweroff.c | 2 +- > drivers/cha

Re: [PATCH] treewide: const qualify ctl_tables where applicable

2025-01-09 Thread Steven Rostedt
On Thu, 09 Jan 2025 14:16:39 +0100 Joel Granados wrote: > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 2e113f8b13a2..489cbab3d64c 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -8786,7 +8786,7 @@ ftrace_enable_sysctl(const struct ctl_table *table, in

Re: [PATCH] treewide: const qualify ctl_tables where applicable

2025-01-09 Thread Jani Nikula
On Thu, 09 Jan 2025, Joel Granados wrote: > diff --git a/drivers/gpu/drm/i915/i915_perf.c > b/drivers/gpu/drm/i915/i915_perf.c > index 2406cda75b7b..5384d1bb4923 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4802,7 +4802,7 @@ int i915_perf_remove_c

Re: [PATCH] treewide: const qualify ctl_tables where applicable

2025-01-09 Thread Martin K. Petersen
Joel, > Add the const qualifier to all the ctl_tables in the tree except the > ones in ./net dir. The "net" sysctl code is special as it modifies the > arrays before passing it on to the registration function. Reviewed-by: Martin K. Petersen # SCSI -- Martin K. Petersen Oracle Linux Eng

Re: [PATCH] treewide: const qualify ctl_tables where applicable

2025-01-09 Thread Corey Minyard
On Thu, Jan 09, 2025 at 02:16:39PM +0100, Joel Granados wrote: > Add the const qualifier to all the ctl_tables in the tree except the > ones in ./net dir. The "net" sysctl code is special as it modifies the > arrays before passing it on to the registration function. > ... > diff --git a/drivers/ch

Re: [PATCH] treewide: const qualify ctl_tables where applicable

2025-01-09 Thread Darrick J. Wong
On Thu, Jan 09, 2025 at 02:16:39PM +0100, Joel Granados wrote: > Add the const qualifier to all the ctl_tables in the tree except the > ones in ./net dir. The "net" sysctl code is special as it modifies the > arrays before passing it on to the registration function. > > Constifying ctl_table struc

Re: [PATCH] rhashtable: Fix potential deadlock by moving schedule_work outside lock

2025-01-09 Thread Breno Leitao
Hello Michael, On Thu, Jan 09, 2025 at 03:16:03AM +, Michael Kelley wrote: > From: Breno Leitao Sent: Thursday, January 2, 2025 2:16 AM > > > > On Sat, Dec 21, 2024 at 05:06:55PM +0800, Herbert Xu wrote: > > > On Thu, Dec 12, 2024 at 08:33:31PM +0800, Herbert Xu wrote: > > > > > > > > The gr

Re: [PATCH v6 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp_id()

2025-01-09 Thread Wei Liu
On Wed, Jan 08, 2025 at 02:21:33PM -0800, Roman Kisel wrote: [...] > Roman Kisel (5): > hyperv: Define struct hv_output_get_vp_registers > hyperv: Fix pointer type in get_vtl(void) > hyperv: Enable the hypercall output page for the VTL mode > hyperv: Do not overlap the hvcall IO areas in ge

Re: [PATCH v6 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp_id()

2025-01-09 Thread Nuno Das Neves
On 1/9/2025 12:18 PM, Wei Liu wrote: > On Wed, Jan 08, 2025 at 02:21:33PM -0800, Roman Kisel wrote: > [...] >> Roman Kisel (5): >> hyperv: Define struct hv_output_get_vp_registers >> hyperv: Fix pointer type in get_vtl(void) >> hyperv: Enable the hypercall output page for the VTL mode >> hy

Re: [PATCH v6 1/5] hyperv: Define struct hv_output_get_vp_registers

2025-01-09 Thread Wei Liu
On Thu, Jan 09, 2025 at 09:25:58AM -0800, Roman Kisel wrote: > > > On 1/8/2025 9:50 PM, Wei Liu wrote: > > On Wed, Jan 08, 2025 at 03:25:22PM -0800, Nuno Das Neves wrote: > > > On 1/8/2025 2:21 PM, Roman Kisel wrote: > > [...] > > > > > > > > I can fix this when I commit the change . This pat