Re: [PATCH 1/2] hyperv: Fix pointer type for the output of the hypercall in get_vtl(void)

On 12/18/2024 6:45 PM, Wei Liu wrote: On Wed, Dec 18, 2024 at 12:54:20PM -0800, Roman Kisel wrote: Commit bc905fa8b633 ("hyperv: Switch from hyperv-tlfs.h to hyperv/hvhdk.h") changed the type of the output pointer to `struct hv_register_assoc` from `struct hv_get_vp_registers_output`. That le

Re: [PATCH 1/2] hyperv: Fix pointer type for the output of the hypercall in get_vtl(void)

On 12/19/2024 12:04 PM, Easwar Hariharan wrote: [snip] This could be accompanied with migration of hv_get_vpreg128 in arm64/ and removal of struct hv_get_registers_output, or that could be deferred to a later patch. [snip] To clarify, I didn't mean to include implementing extended fa

Re: [PATCH 2/2] hyperv: Do not overlap the input and output hypercall areas in get_vtl(void)

On 12/18/2024 6:42 PM, Wei Liu wrote: On Wed, Dec 18, 2024 at 12:54:21PM -0800, Roman Kisel wrote: The Top-Level Functional Specification for Hyper-V, Section 3.6 [1, 2], disallows overlapping of the input and output hypercall areas, and get_vtl(void) does overlap them. To fix this, enable

Re: [PATCH 1/2] hyperv: Fix pointer type for the output of the hypercall in get_vtl(void)

On 12/19/2024 11:23 AM, Nuno Das Neves wrote: > On 12/19/2024 11:13 AM, Easwar Hariharan wrote: >> On 12/19/2024 10:40 AM, Nuno Das Neves wrote: >>> On 12/18/2024 12:54 PM, Roman Kisel wrote: Commit bc905fa8b633 ("hyperv: Switch from hyperv-tlfs.h to hyperv/hvhdk.h") changed the type of t

Re: [PATCH 1/2] hyperv: Fix pointer type for the output of the hypercall in get_vtl(void)

On 12/18/2024 12:54 PM, Roman Kisel wrote: > Commit bc905fa8b633 ("hyperv: Switch from hyperv-tlfs.h to hyperv/hvhdk.h") > changed the type of the output pointer to `struct hv_register_assoc` from > `struct hv_get_vp_registers_output`. That leads to an incorrect computation, > and leaves the system

Re: [PATCH 1/2] hyperv: Fix pointer type for the output of the hypercall in get_vtl(void)

On 12/19/2024 11:13 AM, Easwar Hariharan wrote: > On 12/19/2024 10:40 AM, Nuno Das Neves wrote: >> On 12/18/2024 12:54 PM, Roman Kisel wrote: >>> Commit bc905fa8b633 ("hyperv: Switch from hyperv-tlfs.h to hyperv/hvhdk.h") >>> changed the type of the output pointer to `struct hv_register_assoc` from

Re: [PATCH 1/2] hyperv: Fix pointer type for the output of the hypercall in get_vtl(void)

On 12/19/2024 10:40 AM, Nuno Das Neves wrote: > On 12/18/2024 12:54 PM, Roman Kisel wrote: >> Commit bc905fa8b633 ("hyperv: Switch from hyperv-tlfs.h to hyperv/hvhdk.h") >> changed the type of the output pointer to `struct hv_register_assoc` from >> `struct hv_get_vp_registers_output`. That leads t

Re: [PATCH 1/2] hyperv: Fix pointer type for the output of the hypercall in get_vtl(void)

On 12/19/2024 10:40 AM, Nuno Das Neves wrote: On 12/18/2024 12:54 PM, Roman Kisel wrote: Commit bc905fa8b633 ("hyperv: Switch from hyperv-tlfs.h to hyperv/hvhdk.h") changed the type of the output pointer to `struct hv_register_assoc` from `struct hv_get_vp_registers_output`. That leads to an

Re: [PATCH 1/2] hyperv: Fix pointer type for the output of the hypercall in get_vtl(void)

On 12/19/2024 12:00 PM, Roman Kisel wrote: > > > On 12/19/2024 11:13 AM, Easwar Hariharan wrote: >> On 12/19/2024 10:40 AM, Nuno Das Neves wrote: >>> On 12/18/2024 12:54 PM, Roman Kisel wrote: Commit bc905fa8b633 ("hyperv: Switch from hyperv-tlfs.h to hyperv/ hvhdk.h") changed the

Re: [PATCH 1/2] hyperv: Fix pointer type for the output of the hypercall in get_vtl(void)

On 12/19/2024 11:32 AM, Easwar Hariharan wrote: On 12/19/2024 11:23 AM, Nuno Das Neves wrote: On 12/19/2024 11:13 AM, Easwar Hariharan wrote: On 12/19/2024 10:40 AM, Nuno Das Neves wrote: On 12/18/2024 12:54 PM, Roman Kisel wrote: Commit bc905fa8b633 ("hyperv: Switch from hyperv-tlfs.h to

Re: [PATCH 1/2] hyperv: Fix pointer type for the output of the hypercall in get_vtl(void)

On 12/19/2024 11:13 AM, Easwar Hariharan wrote: On 12/19/2024 10:40 AM, Nuno Das Neves wrote: On 12/18/2024 12:54 PM, Roman Kisel wrote: Commit bc905fa8b633 ("hyperv: Switch from hyperv-tlfs.h to hyperv/hvhdk.h") changed the type of the output pointer to `struct hv_register_assoc` from `stru

Re: [PATCH 2/2] hyperv: Do not overlap the input and output hypercall areas in get_vtl(void)

On Thu, Dec 19, 2024 at 10:19:07AM -0800, Roman Kisel wrote: > > > On 12/18/2024 6:42 PM, Wei Liu wrote: > > On Wed, Dec 18, 2024 at 12:54:21PM -0800, Roman Kisel wrote: > > > The Top-Level Functional Specification for Hyper-V, Section 3.6 [1, 2], > > > disallows > > > overlapping of the input a

RE: [PATCH 2/2] hyperv: Do not overlap the input and output hypercall areas in get_vtl(void)

From: Roman Kisel Sent: Thursday, December 19, 2024 10:19 AM > > On 12/18/2024 6:42 PM, Wei Liu wrote: > > On Wed, Dec 18, 2024 at 12:54:21PM -0800, Roman Kisel wrote: [...] > >> diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c > >> index c7185c6a290b..90c9ea00273e 100644 > >

Re: [PATCH 2/2] hyperv: Do not overlap the input and output hypercall areas in get_vtl(void)

On 12/19/2024 1:37 PM, Michael Kelley wrote: From: Roman Kisel Sent: Thursday, December 19, 2024 10:19 AM [...] There will surely be more hypercall usage in the VTL mode that return data and require the output pages as we progress with upstreaming the VTL patches. Enabling the hypercall

RE: [PATCH 2/2] hyperv: Do not overlap the input and output hypercall areas in get_vtl(void)

From: Roman Kisel Sent: Thursday, December 19, 2024 3:39 PM > > On 12/19/2024 1:37 PM, Michael Kelley wrote: > > From: Roman Kisel Sent: Thursday, December 19, > 2024 10:19 AM > > [...] > > >> > >> There will surely be more hypercall usage in the VTL mode that return > >> data and require the