Re: [PATCH 2/7] dt-bindings: x86: Add ACPI wakeup mailbox

2024-08-08 Thread Krzysztof Kozlowski
On 07/08/2024 18:56, Yunhong Jiang wrote: > On Wed, Aug 07, 2024 at 07:57:43AM +0200, Krzysztof Kozlowski wrote: >> On 07/08/2024 00:12, Yunhong Jiang wrote: >>> Add the binding to use the ACPI wakeup mailbox mechanism to bringup APs. >> >> We do not have bindings for ACPI. I think in the past it w

Re: [PATCH v2 net] net: mana: Fix doorbell out of order violation and avoid unnecessary doorbell rings

2024-08-08 Thread Shradha Gupta
On Wed, Aug 07, 2024 at 04:17:06PM -0700, lon...@linuxonhyperv.com wrote: > From: Long Li > > After napi_complete_done() is called when NAPI is polling in the current > process context, another NAPI may be scheduled and start running in > softirq on another CPU and may ring the doorbell before th

Re: [PATCH v2 net] net: mana: Fix doorbell out of order violation and avoid unnecessary doorbell rings

2024-08-08 Thread Jakub Kicinski
On Wed, 7 Aug 2024 16:17:06 -0700 lon...@linuxonhyperv.com wrote: > Cc: sta...@vger.kernel.org > Fixes: e1b5683ff62e ("net: mana: Move NAPI from EQ to CQ") > > Reviewed-by: Haiyang Zhang no empty lines between trailers please

RE: [PATCH v2 net] net: mana: Fix doorbell out of order violation and avoid unnecessary doorbell rings

2024-08-08 Thread Long Li
> > + if (w < cq->budget) { > > + mana_gd_ring_cq(gdma_queue, SET_ARM_BIT); > > + cq->work_done_since_doorbell = 0; > > + napi_complete_done(&cq->napi, w); > > + } else if (cq->work_done_since_doorbell > > > + cq->gdma_cq->queue_size / COMP_ENTRY_SIZE

RE: [PATCH v2 net] net: mana: Fix doorbell out of order violation and avoid unnecessary doorbell rings

2024-08-08 Thread Long Li
> Subject: Re: [PATCH v2 net] net: mana: Fix doorbell out of order violation and > avoid unnecessary doorbell rings > > On Wed, 7 Aug 2024 16:17:06 -0700 lon...@linuxonhyperv.com wrote: > > Cc: sta...@vger.kernel.org > > Fixes: e1b5683ff62e ("net: mana: Move NAPI from EQ to CQ") > > > > Reviewed-

Re: [PATCH v2 net] net: mana: Fix doorbell out of order violation and avoid unnecessary doorbell rings

2024-08-08 Thread Jakub Kicinski
On Thu, 8 Aug 2024 15:33:55 + Long Li wrote: > > no empty lines between trailers please > > I'm sending v3 to fix this. I hope you don't mean you're sending it _now_, given: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html