RE: Drivers: hv: vmbus: One function call less in create_gpadl_header() after error detection

2024-01-11 Thread Michael Kelley
From: Dan Carpenter Sent: Wednesday, January 10, 2024 11:05 PM > > On Wed, Jan 10, 2024 at 10:17:17PM +, Michael Kelley wrote: > > From: Dan Carpenter Sent: Wednesday, January > 10, 2024 10:38 AM > > > > > > The second half of the if statement is basically duplicated. It doesn't > > > need

[PATCH 1/2] Drivers: hv: vmbus: Remove duplication and cleanup code in create_gpadl_header()

2024-01-11 Thread mhkelley58
From: Michael Kelley create_gpadl_header() creates a message header, and one or more message bodies if the number of GPADL entries exceeds what fits in the header. Currently the code for creating the message header is duplicated in the two halves of the main "if" statement governing whether messa

[PATCH 2/2] Drivers: hv: vmbus: Update indentation in create_gpadl_header()

2024-01-11 Thread mhkelley58
From: Michael Kelley A previous commit left the indentation in create_gpadl_header() unchanged for ease of review. Update the indentation and remove line wrap in two places where it is no longer necessary. No functional change. Signed-off-by: Michael Kelley --- drivers/hv/channel.c | 142

Re: [PATCH v3 3/3] x86/hyperv: Make encrypted/decrypted changes safe for load_unaligned_zeropad()

2024-01-11 Thread Edgecombe, Rick P
On Fri, 2024-01-05 at 10:30 -0800, mhkelle...@gmail.com wrote: >   * hv_vtom_set_host_visibility - Set specified memory visible to > host. >   * > @@ -521,7 +547,7 @@ static bool hv_vtom_set_host_visibility(unsigned > long kbuffer, int pagecount, bo >   > pfn_array = kmalloc(HV_HYP_PAGE_SIZ

Re: [PATCH v3 2/3] x86/mm: Regularize set_memory_p() parameters and make non-static

2024-01-11 Thread Edgecombe, Rick P
On Fri, 2024-01-05 at 10:30 -0800, mhkelle...@gmail.com wrote: > From: Michael Kelley > > set_memory_p() is currently static.  It has parameters that don't > match set_memory_p() under arch/powerpc and that aren't congruent > with the other set_memory_* functions. There's no good reason for > the

Re: [PATCH v3 1/3] x86/hyperv: Use slow_virt_to_phys() in page transition hypervisor callback

2024-01-11 Thread Edgecombe, Rick P
On Fri, 2024-01-05 at 10:30 -0800, mhkelle...@gmail.com wrote: > + * It is also used in callbacks for CoCo VM page transitions between > private > + * and shared because it works when the PRESENT bit is not set in > the leaf > + * PTE. In such cases, the state of the PTEs, including the PFN, is > o

RE: [PATCH v3 3/3] x86/hyperv: Make encrypted/decrypted changes safe for load_unaligned_zeropad()

2024-01-11 Thread Michael Kelley
From: Edgecombe, Rick P Sent: Thursday, January 11, 2024 4:27 PM > > On Fri, 2024-01-05 at 10:30 -0800, mhkelle...@gmail.com wrote: > >   * hv_vtom_set_host_visibility - Set specified memory visible to host. > >   * > > @@ -521,7 +547,7 @@ static bool hv_vtom_set_host_visibility(unsigned long >