Re: [PATCH net,v2, 3/3] net: mana: Fix oversized sge0 for GSO packets

2023-10-03 Thread Simon Horman
On Fri, Sep 29, 2023 at 01:42:27PM -0700, Haiyang Zhang wrote: > Handle the case when GSO SKB linear length is too large. > > MANA NIC requires GSO packets to put only the header part to SGE0, > otherwise the TX queue may stop at the HW level. > > So, use 2 SGEs for the skb linear part which cont

Re: [PATCH net,v2, 2/3] net: mana: Fix the tso_bytes calculation

2023-10-03 Thread Shradha Gupta
On Fri, Sep 29, 2023 at 01:42:26PM -0700, Haiyang Zhang wrote: > sizeof(struct hop_jumbo_hdr) is not part of tso_bytes, so remove > the subtraction from header size. > > Cc: sta...@vger.kernel.org > Fixes: bd7fc6e1957c ("net: mana: Add new MANA VF performance counters for > easier troubleshooting

Re: [PATCH net,v2, 1/3] net: mana: Fix TX CQE error handling

2023-10-03 Thread Shradha Gupta
On Fri, Sep 29, 2023 at 01:42:25PM -0700, Haiyang Zhang wrote: > For an unknown TX CQE error type (probably from a newer hardware), > still free the SKB, update the queue tail, etc., otherwise the > accounting will be wrong. > > Also, TX errors can be triggered by injecting corrupted packets, so >

Re: [PATCH] hyperv: rndis_filter needs to select NLS

2023-10-03 Thread Simon Horman
On Fri, Sep 29, 2023 at 07:32:34PM -0700, Randy Dunlap wrote: > rndis_filter uses utf8s_to_utf16s() which is provided by setting > NLS, so select NLS to fix the build error: > > ERROR: modpost: "utf8s_to_utf16s" [drivers/net/hyperv/hv_netvsc.ko] undefined! > > Fixes: 1ce09e899d28 ("hyperv: Add su

Re: [PATCH net,v2, 3/3] net: mana: Fix oversized sge0 for GSO packets

2023-10-03 Thread Shradha Gupta
On Fri, Sep 29, 2023 at 01:42:27PM -0700, Haiyang Zhang wrote: > Handle the case when GSO SKB linear length is too large. > > MANA NIC requires GSO packets to put only the header part to SGE0, > otherwise the TX queue may stop at the HW level. > > So, use 2 SGEs for the skb linear part which cont

RE: [PATCH] hyperv: rndis_filter needs to select NLS

2023-10-03 Thread Michael Kelley (LINUX)
From: Randy Dunlap Sent: Friday, September 29, 2023 7:33 PM > Patches for this driver usually use the subject prefix "hv_netvsc: ", not "hyperv". Other than that minor tweak, Reviewed-by: Michael Kelley > rndis_filter uses utf8s_to_utf16s() which is provided by setting > NLS, so select NLS

RE: [PATCH net-next v6] net: hv_netvsc: fix netvsc_send_completion to avoid multiple message length checks

2023-10-03 Thread Michael Kelley (LINUX)
From: Sonia Sharma Sent: Wednesday, September 27, 2023 2:19 PM > Patches to the Hyper-V netvsc driver usually have the patch subject prefix as only "hv_netvsc: ". Look at the commit log for the files in drivers/net/hyperv. There's value in consistency unless someone really thinks we need the

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-03 Thread Wei Liu
On Sun, Oct 01, 2023 at 08:19:27AM +0200, Greg KH wrote: > On Sat, Sep 30, 2023 at 10:01:58PM +, Wei Liu wrote: > > On Sat, Sep 30, 2023 at 08:09:19AM +0200, Greg KH wrote: > > > On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote: > > > > These must be in uapi because they will be u

Re: [PATCH v4 15/15] Drivers: hv: Add modules to expose /dev/mshv to VMMs running on Hyper-V

2023-10-03 Thread Wei Liu
On Sun, Oct 01, 2023 at 08:20:37AM +0200, Greg KH wrote: > On Sat, Sep 30, 2023 at 09:13:07PM +, Wei Liu wrote: > > On Sat, Sep 30, 2023 at 08:31:13PM +0200, Greg KH wrote: > > > On Sat, Sep 30, 2023 at 06:11:19PM +, Wei Liu wrote: > > > > On Sat, Sep 30, 2023 at 08:11:37AM +0200, Greg KH w

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-03 Thread Nuno Das Neves
On 9/30/2023 11:19 PM, Greg KH wrote: On Sat, Sep 30, 2023 at 10:01:58PM +, Wei Liu wrote: On Sat, Sep 30, 2023 at 08:09:19AM +0200, Greg KH wrote: On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote: +/* Define connection identifier type. */ +union hv_connection_id { + __

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-03 Thread Greg KH
On Tue, Oct 03, 2023 at 04:37:01PM -0700, Nuno Das Neves wrote: > On 9/30/2023 11:19 PM, Greg KH wrote: > > On Sat, Sep 30, 2023 at 10:01:58PM +, Wei Liu wrote: > > > On Sat, Sep 30, 2023 at 08:09:19AM +0200, Greg KH wrote: > > > > On Fri, Sep 29, 2023 at 11:01:39AM -0700, Nuno Das Neves wrote:

Re: [PATCH v4 13/15] uapi: hyperv: Add mshv driver headers defining hypervisor ABIs

2023-10-03 Thread Greg KH
On Tue, Oct 03, 2023 at 11:29:42PM +, Wei Liu wrote: > > > > > diff --git a/include/uapi/hyperv/hvgdk.h b/include/uapi/hyperv/hvgdk.h > > > > > new file mode 100644 > > > > > index ..9bcbb7d902b2 > > > > > --- /dev/null > > > > > +++ b/include/uapi/hyperv/hvgdk.h > > > > > @@ -0,0 +