RE: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-11-06 Thread Thomas Gleixner
On Wed, Nov 06 2024 at 22:19, David Laight wrote: > From: Thomas Gleixner >> Still the macro should be documented. > > I was wondering if it really had any purpose at all. > It just obfuscates code, doesn't even make it smaller. What is obfuscated here? secs_to_jiffies() is clearly describing wha

RE: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-11-06 Thread David Laight
From: Thomas Gleixner > Sent: 29 October 2024 17:25 > > On Tue, Oct 29 2024 at 17:22, Geert Uytterhoeven wrote: > > On Tue, Oct 29, 2024 at 5:08 PM Thomas Gleixner wrote: > >> On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote: > >> > diff --git a/include/linux/jiffies.h b/include/linux/jiffies

Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-10-29 Thread Easwar Hariharan
On 10/29/2024 10:25 AM, Thomas Gleixner wrote: > On Tue, Oct 29 2024 at 17:22, Geert Uytterhoeven wrote: >> On Tue, Oct 29, 2024 at 5:08 PM Thomas Gleixner wrote: >>> On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote: diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h inde

Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-10-29 Thread Thomas Gleixner
On Tue, Oct 29 2024 at 17:22, Geert Uytterhoeven wrote: > On Tue, Oct 29, 2024 at 5:08 PM Thomas Gleixner wrote: >> On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote: >> > diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h >> > index 1220f0fbe5bf..e5256bb5f851 100644 >> > --- a/incl

Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-10-29 Thread Geert Uytterhoeven
Hi Thomas, On Tue, Oct 29, 2024 at 5:08 PM Thomas Gleixner wrote: > On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote: > > diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h > > index 1220f0fbe5bf..e5256bb5f851 100644 > > --- a/include/linux/jiffies.h > > +++ b/include/linux/jiffie

Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-10-29 Thread Thomas Gleixner
On Mon, Oct 28 2024 at 19:11, Easwar Hariharan wrote: > diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h > index 1220f0fbe5bf..e5256bb5f851 100644 > --- a/include/linux/jiffies.h > +++ b/include/linux/jiffies.h > @@ -526,6 +526,8 @@ static __always_inline unsigned long > msecs_to_jif

Re: [PATCH v2 1/2] jiffies: Define secs_to_jiffies()

2024-10-28 Thread Luiz Augusto von Dentz
Hi Easwar, On Mon, Oct 28, 2024 at 3:11 PM Easwar Hariharan wrote: > > secs_to_jiffies() is defined in hci_event.c and cannot be reused by > other call sites. Hoist it into the core code to allow conversion of the > ~1150 usages of msecs_to_jiffies() that either: > - use a multiplier value of 100