RE: [PATCH 1/6] Drivers: hv: vmbus: Add utility function for querying ring size

2024-03-12 Thread Long Li
> Subject: [PATCH 1/6] Drivers: hv: vmbus: Add utility function for querying > ring size > > Add a function to query for the preferred ring buffer size of VMBus device. Patch looks good to me. It will be helpful if you can document the ring sizes for each device and put it in the comment. (e.g

Re: [PATCH 1/6] Drivers: hv: vmbus: Add utility function for querying ring size

2024-02-18 Thread Greg KH
On Sun, Feb 18, 2024 at 12:03:06AM -0800, Saurabh Singh Sengar wrote: > On Sun, Feb 18, 2024 at 08:11:58AM +0100, Greg KH wrote: > > On Sat, Feb 17, 2024 at 10:03:35AM -0800, Saurabh Sengar wrote: > > > Add a function to query for the preferred ring buffer size of VMBus > > > device. > > > > That

Re: [PATCH 1/6] Drivers: hv: vmbus: Add utility function for querying ring size

2024-02-18 Thread Saurabh Singh Sengar
On Sun, Feb 18, 2024 at 08:11:58AM +0100, Greg KH wrote: > On Sat, Feb 17, 2024 at 10:03:35AM -0800, Saurabh Sengar wrote: > > Add a function to query for the preferred ring buffer size of VMBus > > device. > > That says what you did, but not why you did it. I thought subsequent patch will make i

Re: [PATCH 1/6] Drivers: hv: vmbus: Add utility function for querying ring size

2024-02-17 Thread Greg KH
On Sat, Feb 17, 2024 at 10:03:35AM -0800, Saurabh Sengar wrote: > Add a function to query for the preferred ring buffer size of VMBus > device. That says what you did, but not why you did it. > > Signed-off-by: Saurabh Sengar > --- > drivers/hv/channel_mgmt.c | 7 +-- > drivers/hv/hyperv_v