Re: [patch V3 09/10] scsi: ufs: qcom: Remove the MSI descriptor abuse

2025-04-05 Thread Thomas Gleixner
On Mon, Mar 17 2025 at 12:26, James Bottomley wrote: >>  nr_irqs = hba->nr_hw_queues - hba- >> >nr_queues[HCTX_TYPE_POLL]; >> +qi = devm_kcalloc(hba->dev, nr_irqs, sizeof(*qi), >> GFP_KERNEL); >> +if (qi) > > Typo causing logic inversion: should be !qi here (you need a more > responsive

Re: [patch V3 09/10] scsi: ufs: qcom: Remove the MSI descriptor abuse

2025-03-17 Thread James Bottomley
On Mon, 2025-03-17 at 14:29 +0100, Thomas Gleixner wrote: > The driver abuses the MSI descriptors for internal purposes. Aside of > core code and MSI providers nothing has to care about their > existence. They have been encapsulated with a lot of effort because > this kind of abuse caused all sorts

[patch V3 09/10] scsi: ufs: qcom: Remove the MSI descriptor abuse

2025-03-17 Thread Thomas Gleixner
The driver abuses the MSI descriptors for internal purposes. Aside of core code and MSI providers nothing has to care about their existence. They have been encapsulated with a lot of effort because this kind of abuse caused all sorts of issues including a maintainability nightmare. Rewrite the cod